[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347533#comment-16347533
 ] 

Colm O hEigeartaigh commented on EAGLE-331:
---

[~jhsenjaliya], I can't assign it to myself as I didn't create it, and I don't 
have the permissions on this project to assign arbitrary issues to myself.

> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher

[Jayesh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayesh reassigned EAGLE-1075:
-

Assignee: Jayesh

> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Assignee: Jayesh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the 
> AlertFilePublisher in the UI. So for example we can't configure the file 
> name/path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher

[Jayesh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayesh reassigned EAGLE-1075:
-

Assignee: (was: Jayesh)

> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the 
> AlertFilePublisher in the UI. So for example we can't configure the file 
> name/path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347471#comment-16347471
 ] 

ASF GitHub Bot commented on EAGLE-1075:
---

Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/978


> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the 
> AlertFilePublisher in the UI. So for example we can't configure the file 
> name/path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle pull request #978: EAGLE-1075 - Can't specify configuration options fo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/978


---

[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347467#comment-16347467
 ] 

ASF GitHub Bot commented on EAGLE-1075:
---

Github user jhsenjaliya commented on the issue:

https://github.com/apache/eagle/pull/978
  
+1, merging since its improved than earlier and more improvements can be 
later.  Thanks for the PR.


> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the 
> AlertFilePublisher in the UI. So for example we can't configure the file 
> name/path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle issue #978: EAGLE-1075 - Can't specify configuration options for Alert...

[jhsenjaliya]

Github user jhsenjaliya commented on the issue:

https://github.com/apache/eagle/pull/978
  
+1, merging since its improved than earlier and more improvements can be 
later.  Thanks for the PR.


---

[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347461#comment-16347461
 ] 

ASF GitHub Bot commented on EAGLE-1075:
---

Github user jhsenjaliya commented on a diff in the pull request:

https://github.com/apache/eagle/pull/978#discussion_r165162632
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertFilePublisher.java
 ---
@@ -54,13 +54,26 @@ public void init(Config config, Publishment 
publishment, Map conf) throws Except
 int numOfFiles = DEFAULT_FILE_NUMBER;
 if (publishment.getProperties() != null) {
 if 
(publishment.getProperties().containsKey(PublishConstants.FILE_NAME)) {
-fileName = (String) 
publishment.getProperties().get(PublishConstants.FILE_NAME);
+String property = (String) 
publishment.getProperties().get(PublishConstants.FILE_NAME);
+if (property != null && !"".equals(property)) {
+fileName = property;
+}
 }
 if 
(publishment.getProperties().containsKey(PublishConstants.ROTATE_EVERY_KB)) {
-rotateSize = 
Integer.valueOf(publishment.getProperties().get(PublishConstants.ROTATE_EVERY_KB).toString());
+Object property = 
publishment.getProperties().get(PublishConstants.ROTATE_EVERY_KB);
+if (property instanceof Integer) {
+rotateSize = (Integer)property;
+} else if (property instanceof String && 
!"".equals((String)property)) {
--- End diff --

could also check for null once its is instanceof string.


> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the 
> AlertFilePublisher in the UI. So for example we can't configure the file 
> name/path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle pull request #978: EAGLE-1075 - Can't specify configuration options fo...

[jhsenjaliya]

Github user jhsenjaliya commented on a diff in the pull request:

https://github.com/apache/eagle/pull/978#discussion_r165162632
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertFilePublisher.java
 ---
@@ -54,13 +54,26 @@ public void init(Config config, Publishment 
publishment, Map conf) throws Except
 int numOfFiles = DEFAULT_FILE_NUMBER;
 if (publishment.getProperties() != null) {
 if 
(publishment.getProperties().containsKey(PublishConstants.FILE_NAME)) {
-fileName = (String) 
publishment.getProperties().get(PublishConstants.FILE_NAME);
+String property = (String) 
publishment.getProperties().get(PublishConstants.FILE_NAME);
+if (property != null && !"".equals(property)) {
+fileName = property;
+}
 }
 if 
(publishment.getProperties().containsKey(PublishConstants.ROTATE_EVERY_KB)) {
-rotateSize = 
Integer.valueOf(publishment.getProperties().get(PublishConstants.ROTATE_EVERY_KB).toString());
+Object property = 
publishment.getProperties().get(PublishConstants.ROTATE_EVERY_KB);
+if (property instanceof Integer) {
+rotateSize = (Integer)property;
+} else if (property instanceof String && 
!"".equals((String)property)) {
--- End diff --

could also check for null once its is instanceof string.


---

[jira] [Commented] (EAGLE-1077) Set the secure processing feature on all DocumentBuilderFactory instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347457#comment-16347457
 ] 

ASF GitHub Bot commented on EAGLE-1077:
---

Github user jhsenjaliya commented on the issue:

https://github.com/apache/eagle/pull/980
  
+1, merging.. Thanks for the PR.


> Set the secure processing feature on all DocumentBuilderFactory instances
> -
>
> Key: EAGLE-1077
> URL: https://issues.apache.org/jira/browse/EAGLE-1077
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> We should set the secure processing feature on all DocumentBuilderFactory 
> instances, to prevent attacks such as XXE attacks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle issue #980: EAGLE-1077 - Set the secure processing feature on all Docu...

[jhsenjaliya]

Github user jhsenjaliya commented on the issue:

https://github.com/apache/eagle/pull/980
  
+1, merging.. Thanks for the PR.


---

[GitHub] eagle pull request #980: EAGLE-1077 - Set the secure processing feature on a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/980


---

[jira] [Commented] (EAGLE-1077) Set the secure processing feature on all DocumentBuilderFactory instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347456#comment-16347456
 ] 

ASF GitHub Bot commented on EAGLE-1077:
---

Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/980


> Set the secure processing feature on all DocumentBuilderFactory instances
> -
>
> Key: EAGLE-1077
> URL: https://issues.apache.org/jira/browse/EAGLE-1077
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> We should set the secure processing feature on all DocumentBuilderFactory 
> instances, to prevent attacks such as XXE attacks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

[Jayesh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347349#comment-16347349
 ] 

Jayesh commented on EAGLE-331:
--

[~coheigea], can u pease assign this to yourself, Jira cant find ur username 
somehow.  Thanks

> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (EAGLE-331) avoid to use junit.framework.Assert

[Jayesh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayesh reassigned EAGLE-331:


Assignee: (was: Lingang Deng)

> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347334#comment-16347334
 ] 

ASF GitHub Bot commented on EAGLE-331:
--

Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/979


> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Assignee: Lingang Deng
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle pull request #979: EAGLE-331 - avoid to use junit.framework.Assert

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/979


---

[GitHub] eagle issue #979: EAGLE-331 - avoid to use junit.framework.Assert

[jhsenjaliya]

Github user jhsenjaliya commented on the issue:

https://github.com/apache/eagle/pull/979
  
+1, merging.. Thanks!


---

[jira] [Commented] (EAGLE-1077) Set the secure processing feature on all DocumentBuilderFactory instances

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347226#comment-16347226
 ] 

ASF GitHub Bot commented on EAGLE-1077:
---

GitHub user coheigea opened a pull request:

https://github.com/apache/eagle/pull/980

EAGLE-1077 - Set the secure processing feature on all DocumentBuilder…

…Factory instances



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coheigea/eagle EAGLE-1077

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/980.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #980


commit a380163ae3771beacefe6fcacf29bd9abe66ced8
Author: Colm O hEigeartaigh 
Date:   2018-01-31T17:23:41Z

EAGLE-1077 - Set the secure processing feature on all 
DocumentBuilderFactory instances




> Set the secure processing feature on all DocumentBuilderFactory instances
> -
>
> Key: EAGLE-1077
> URL: https://issues.apache.org/jira/browse/EAGLE-1077
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> We should set the secure processing feature on all DocumentBuilderFactory 
> instances, to prevent attacks such as XXE attacks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle pull request #980: EAGLE-1077 - Set the secure processing feature on a...

[coheigea]

GitHub user coheigea opened a pull request:

https://github.com/apache/eagle/pull/980

EAGLE-1077 - Set the secure processing feature on all DocumentBuilder…

…Factory instances



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coheigea/eagle EAGLE-1077

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/980.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #980


commit a380163ae3771beacefe6fcacf29bd9abe66ced8
Author: Colm O hEigeartaigh 
Date:   2018-01-31T17:23:41Z

EAGLE-1077 - Set the secure processing feature on all 
DocumentBuilderFactory instances




---

[jira] [Created] (EAGLE-1077) Set the secure processing feature on all DocumentBuilderFactory instances

[Colm O hEigeartaigh (JIRA)]

Colm O hEigeartaigh created EAGLE-1077:
--

 Summary: Set the secure processing feature on all 
DocumentBuilderFactory instances
 Key: EAGLE-1077
 URL: https://issues.apache.org/jira/browse/EAGLE-1077
 Project: Eagle
  Issue Type: Improvement
Reporter: Colm O hEigeartaigh
 Fix For: v0.5.1


We should set the secure processing feature on all DocumentBuilderFactory 
instances, to prevent attacks such as XXE attacks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-159) XML parser configured in org.apache.eagle.jobrunning.crawler.XmlHelper is not protected from Xml eXternal Entities injection attack

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347176#comment-16347176
 ] 

Colm O hEigeartaigh commented on EAGLE-159:
---

XmlHelper is no longer included in the Eagle source, so this issue could be 
resolved.

> XML parser configured in org.apache.eagle.jobrunning.crawler.XmlHelper is not 
> protected from Xml eXternal Entities injection attack
> ---
>
> Key: EAGLE-159
> URL: https://issues.apache.org/jira/browse/EAGLE-159
> Project: Eagle
>  Issue Type: Bug
>Reporter: Michael Wu
>Assignee: Hao Chen
>Priority: Major
>
> Scanned and found by Fortify app:
> At org.apache.eagle.jobrunning.crawler.XmlHelper:41, XML parser configured at 
> this position does not prevent nor limit external entities resolution, this 
> can expose the parser to an XML External Entities attack.
> >> Explanation of the issue:
> 1. XML External Entities attacks benefit from an XML feature to build 
> documents dynamically at the time of processing. An XML entity allows 
> inclusion of data dynamically from a given resource. External entities allow 
> an XML document to include data from an external URI. Unless configured to do 
> otherwise, external entities force the XML parser to access the resource 
> specified by the URI, e.g., a file on the local machine or on a remote 
> system. This behavior exposes the application to XML External Entity (XXE) 
> attacks, which can be used to perform denial of service of the local system, 
> gain unauthorized access to files on the local machine, scan remote machines, 
> and perform denial of service of remote systems.
> 2. The following XML document shows an example of an XXE attack.
> *
> 
> 
>   ]>
> *
> This example could crash the server (on a UNIX system), if the XML parser 
> attempts to substitute the entity with the contents of the /dev/random file.
> >> Solving recommendation:
> 1. The XML unmarshaller should be configured securely so that it does not 
> allow external entities as part of an incoming XML document.
> 2. To avoid XXE injection do not use unmarshal methods that process an XML 
> source directly as java.io.File, java.io.Reader or java.io.InputStream. Parse 
> the document with a securely configured parser and use an unmarshal method 
> that takes the secure parser as the XML source as shown in the following 
> example:
> **
> // suppose we've got Unmarshaller instance referenced by unmarshaller 
> DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
> dbf.setExpandEntityReferences(false);
> DocumentBuilder db = dbf.newDocumentBuilder();
> Document document = db.parse();
> Model model = (Model) unmarshaller.unmarshal(document);
> **



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-331) avoid to use junit.framework.Assert

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347166#comment-16347166
 ] 

ASF GitHub Bot commented on EAGLE-331:
--

GitHub user coheigea opened a pull request:

https://github.com/apache/eagle/pull/979

EAGLE-331 - avoid to use junit.framework.Assert



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coheigea/eagle EAGLE-331

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/979.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #979


commit 1b72b39893eef46e893bb4295355d67ac477e23a
Author: Colm O hEigeartaigh 
Date:   2018-01-31T16:54:01Z

EAGLE-331 - avoid to use junit.framework.Assert




> avoid to use junit.framework.Assert
> ---
>
> Key: EAGLE-331
> URL: https://issues.apache.org/jira/browse/EAGLE-331
> Project: Eagle
>  Issue Type: Bug
>Reporter: Edward Zhang
>Assignee: Lingang Deng
>Priority: Trivial
>
> all eagle code should not use deprecated Assert



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle pull request #979: EAGLE-331 - avoid to use junit.framework.Assert

[coheigea]

GitHub user coheigea opened a pull request:

https://github.com/apache/eagle/pull/979

EAGLE-331 - avoid to use junit.framework.Assert



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coheigea/eagle EAGLE-331

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/979.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #979


commit 1b72b39893eef46e893bb4295355d67ac477e23a
Author: Colm O hEigeartaigh 
Date:   2018-01-31T16:54:01Z

EAGLE-331 - avoid to use junit.framework.Assert




---

[jira] [Commented] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346991#comment-16346991
 ] 

ASF GitHub Bot commented on EAGLE-1075:
---

GitHub user coheigea reopened a pull request:

https://github.com/apache/eagle/pull/978

EAGLE-1075 - Can't specify configuration options for AlertFilePublisher



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coheigea/eagle EAGLE-1075

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #978


commit fb3868a8532a6e3b40c305ddd3d317b3fc8e1a29
Author: Colm O hEigeartaigh 
Date:   2018-01-31T15:15:57Z

EAGLE-1075 - Can't specify configuration options for AlertFilePublisher




> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the 
> AlertFilePublisher in the UI. So for example we can't configure the file 
> name/path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] eagle pull request #978: EAGLE-1075 - Can't specify configuration options fo...

[coheigea]

GitHub user coheigea reopened a pull request:

https://github.com/apache/eagle/pull/978

EAGLE-1075 - Can't specify configuration options for AlertFilePublisher



Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[EAGLE-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/coheigea/eagle EAGLE-1075

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #978


commit fb3868a8532a6e3b40c305ddd3d317b3fc8e1a29
Author: Colm O hEigeartaigh 
Date:   2018-01-31T15:15:57Z

EAGLE-1075 - Can't specify configuration options for AlertFilePublisher




---

[jira] [Commented] (EAGLE-936) eagle-0.4.0 :mvn clean package -DskipTests meet this question:Failed to execute goal org.scala-tools:maven-scala-plugin:2.15.0

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346990#comment-16346990
 ] 

Colm O hEigeartaigh commented on EAGLE-936:
---

This should be resolved as it's working correctly now.

> eagle-0.4.0 :mvn clean package -DskipTests  meet this question:Failed to 
> execute goal org.scala-tools:maven-scala-plugin:2.15.0
> ---
>
> Key: EAGLE-936
> URL: https://issues.apache.org/jira/browse/EAGLE-936
> Project: Eagle
>  Issue Type: Bug
> Environment:  Version:apache-eagle-0.4.0-incubating-src.tar.gz
> mvn clean package -DskipTests 
> meet this question:Failed to execute goal 
> org.scala-tools:maven-scala-plugin:2.15.0
> How can I solve it ?Thanks.
>Reporter: eward chen
>Priority: Major
>
> [INFO] Total time: 28.374s
> [INFO] Finished at: Wed Mar 01 04:57:40 PST 2017
> [INFO] Final Memory: 30M/90M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.scala-tools:maven-scala-plugin:2.15.0:compile (scala-compile-first) on 
> project eagle-stream-process-base: wrap: 
> org.apache.commons.exec.ExecuteException: Process exited with an error: 
> 1(Exit value: 1) -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :eagle-stream-process-base
> [root@master eagle-0.4]# mvn clean package -DskipTests



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-101) cannot compile eagle successfully with jdk1.8

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346961#comment-16346961
 ] 

Colm O hEigeartaigh commented on EAGLE-101:
---

This issue could be resolved as the build now works fine with Java 1.8.

> cannot compile eagle successfully with jdk1.8
> -
>
> Key: EAGLE-101
> URL: https://issues.apache.org/jira/browse/EAGLE-101
> Project: Eagle
>  Issue Type: Bug
> Environment: 1. mac
> 2. jenkins CI job
>Reporter: Michael Wu
>Assignee: H Lu
>Priority: Trivial
>  Time Spent: 48h
>  Remaining Estimate: 0h
>
> While using jdk1.8 to compile the project, there are constantly errors thrown 
> as  following:
> [INFO] --- maven-scala-plugin:2.15.0:compile (scala-compile-first) @ 
> eagle-stream-process-base ---
> [INFO] Checking for multiple versions of scala
> [WARNING]  Expected all dependencies to require Scala version: 2.10.0
> [WARNING]  org.apache.kafka:kafka_2.10:0.8.1.2.2.0.0-2041 requires scala 
> version: 2.10.4
> [WARNING] Multiple versions of scala libraries detected!
> [INFO] includes = [**/*.java,**/*.scala,]
> [INFO] excludes = []
> [INFO] 
> /Users/ziwu/test/incubator-eagle/eagle-core/eagle-data-process/eagle-stream-process-base/src/main/java:-1:
>  info: compiling
> [INFO] 
> /Users/ziwu/test/incubator-eagle/eagle-core/eagle-data-process/eagle-stream-process-base/src/main/scala:-1:
>  info: compiling
> [INFO] Compiling 17 source files to 
> /Users/ziwu/test/incubator-eagle/eagle-core/eagle-data-process/eagle-stream-process-base/target/classes
>  at 1451275265312
> [ERROR] error: error while loading CharSequence, class file 
> '/Library/Java/JavaVirtualMachines/jdk1.8.0_51.jdk/Contents/Home/jre/lib/rt.jar(java/lang/CharSequence.class)'
>  is broken
> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte 10)
> [ERROR] error: error while loading AnnotatedElement, class file 
> '/Library/Java/JavaVirtualMachines/jdk1.8.0_51.jdk/Contents/Home/jre/lib/rt.jar(java/lang/reflect/AnnotatedElement.class)'
>  is broken
> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte 76)
> [ERROR] error: error while loading ConcurrentMap, class file 
> '/Library/Java/JavaVirtualMachines/jdk1.8.0_51.jdk/Contents/Home/jre/lib/rt.jar(java/util/concurrent/ConcurrentMap.class)'
>  is broken
> [INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte 61)
> [ERROR] three errors found
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Eagle Parent  SUCCESS [  0.494 
> s]
> [INFO] eagle core . SUCCESS [  0.012 
> s]
> [INFO] eagle-query-parent . SUCCESS [  0.099 
> s]
> [INFO] eagle-common ... SUCCESS [  2.992 
> s]
> [INFO] eagle-data-process-parent .. SUCCESS [  0.009 
> s]
> [INFO] eagle-stream-process-base .. FAILURE [  2.843 
> s]
> [INFO] eagle-embed-parent . SKIPPED
> [INFO] eagle-embed-server . SKIPPED
> [INFO] eagle-embed-hbase .. SKIPPED
> [INFO] eagle-antlr  SKIPPED
> [INFO] eagle-entity-base .. SKIPPED
> [INFO] eagle-client-base .. SKIPPED
> [INFO] eagle-alert-parent . SKIPPED
> [INFO] eagle-alert-base ... SKIPPED
> [INFO] eagle-metric ... SKIPPED
> [INFO] eagle-alert-process  SKIPPED
> [INFO] eagle-stream-process-api ... SKIPPED
> [INFO] eagle-job-common ... SKIPPED
> [INFO] eagle-storm-jobrunning-spout ... SKIPPED
> [INFO] eagle-query-base ... SKIPPED
> [INFO] eagle-storage-base . SKIPPED
> [INFO] eagle-storage-hbase  SKIPPED
> [INFO] eagle-service-base . SKIPPED
> [INFO] eagle-alert-service  SKIPPED
> [INFO] eagle-storage-jdbc . SKIPPED
> [INFO] eagle-machinelearning-parent ... SKIPPED
> [INFO] eagle-machinelearning-base . SKIPPED
> [INFO] eagle-security-parent .. SKIPPED
> [INFO] eagle-security-common .. SKIPPED
> [INFO] eagle-security-hbase-web ... SKIPPED
> [INFO] eagle-security-hive-web  

[jira] [Updated] (EAGLE-1076) Fix "Fix Versions" of the following JIRAs

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated EAGLE-1076:
---
Description: 
The following JIRAs are "resolved" for 0.5.1 when they are actually fixed in 
0.5.0:

https://issues.apache.org/jira/browse/EAGLE-1056

https://issues.apache.org/jira/browse/EAGLE-487

 

These are resolved for 0.6.0 when they are fixed in 0.5.0 as well:

https://issues.apache.org/jira/browse/EAGLE-1053

https://issues.apache.org/jira/browse/EAGLE-943

 

This has no fix-for version but it is fixed in 0.5.0 and should be resolved as 
well:

https://issues.apache.org/jira/browse/EAGLE-476 

 

The "Fix for" versions for these JIRAs should be changed to 0.5.0.

  was:
The following JIRAs are "resolved" for 0.5.1 when they are actually fixed in 
0.5.0:

https://issues.apache.org/jira/browse/EAGLE-1056

https://issues.apache.org/jira/browse/EAGLE-487

 

These are resolved for 0.6.0 when they are fixed in 0.5.0 as well:

https://issues.apache.org/jira/browse/EAGLE-1053

https://issues.apache.org/jira/browse/EAGLE-943

 

The "Fix for" versions for these JIRAs should be changed to 0.5.0.


> Fix "Fix Versions" of the following JIRAs
> -
>
> Key: EAGLE-1076
> URL: https://issues.apache.org/jira/browse/EAGLE-1076
> Project: Eagle
>  Issue Type: Task
>Reporter: Colm O hEigeartaigh
>Priority: Trivial
> Fix For: v0.5.1
>
>
> The following JIRAs are "resolved" for 0.5.1 when they are actually fixed in 
> 0.5.0:
> https://issues.apache.org/jira/browse/EAGLE-1056
> https://issues.apache.org/jira/browse/EAGLE-487
>  
> These are resolved for 0.6.0 when they are fixed in 0.5.0 as well:
> https://issues.apache.org/jira/browse/EAGLE-1053
> https://issues.apache.org/jira/browse/EAGLE-943
>  
> This has no fix-for version but it is fixed in 0.5.0 and should be resolved 
> as well:
> https://issues.apache.org/jira/browse/EAGLE-476 
>  
> The "Fix for" versions for these JIRAs should be changed to 0.5.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-476) Outdated HBase audit log parser

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346975#comment-16346975
 ] 

Colm O hEigeartaigh commented on EAGLE-476:
---

This should be marked as "fix for" v0.5.0 and resolved.

> Outdated HBase audit log parser
> ---
>
> Key: EAGLE-476
> URL: https://issues.apache.org/jira/browse/EAGLE-476
> Project: Eagle
>  Issue Type: Bug
>Reporter: Peter Kim
>Priority: Major
>
> The parsing logic for HBase audit logs (security logs) fails for some of the 
> newly formatted hbase audit logs. Obviously, this can cause the eagle service 
> to overlook these log lines, and fail to generate alerts, which can have a 
> severe outcome in terms of security. For example:
> 2016-08-17 14:09:52,232 TRACE 
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController: 
> Access allowed for user petkim; reason: Table permission granted; remote 
> address: /127.0.0.1; request: flush; context: (user=petkim, scope=hbase:meta, 
> params=[table=hbase:meta],action=ADMIN)
> 2016-08-17 14:04:27,042 TRACE 
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController: 
> Access allowed for user petkim; reason: All users allowed; remote address: 
> /111.1.1.1; request: scan; context: (user=petkim, scope=hbase:meta, 
> family=info, params=[table=hbase:meta,family=info],action=READ)
> These log lines are not parsed correctly as the fields that the current regex 
> matches are static. The first log does not have the field "family" and the 
> second one has a new field named "params". So, the parsing logic fails here.
> To fix this and ensure scalability (reliable no matter how many fields are 
> omitted or added), I will extend the current parsing logic to more reliable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-954) Optimizing Dependency

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346970#comment-16346970
 ] 

Colm O hEigeartaigh commented on EAGLE-954:
---

Please add more information or close this JIRA.

> Optimizing Dependency
> -
>
> Key: EAGLE-954
> URL: https://issues.apache.org/jira/browse/EAGLE-954
> Project: Eagle
>  Issue Type: Improvement
>Reporter: JiJun Tang
>Assignee: luokun
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (EAGLE-1038) Support alertDuplication customization for each policy

[Colm O hEigeartaigh (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346968#comment-16346968
 ] 

Colm O hEigeartaigh commented on EAGLE-1038:


This Jira should be resolved as "won't fix" based on the comments on the PR.

> Support alertDuplication customization for each policy 
> ---
>
> Key: EAGLE-1038
> URL: https://issues.apache.org/jira/browse/EAGLE-1038
> Project: Eagle
>  Issue Type: Sub-task
>Affects Versions: v0.5.1
>Reporter: Zhao, Qingwen
>Assignee: Zhao, Qingwen
>Priority: Major
>
> Requirements
> * compatible with old versions
> * enable alertDuplication check for each policy 
> * optimize DefaultDeduplicator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (EAGLE-1075) Can't specify configuration options for AlertFilePublisher

[Colm O hEigeartaigh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/EAGLE-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated EAGLE-1075:
---
Fix Version/s: v0.5.1

> Can't specify configuration options for AlertFilePublisher
> --
>
> Key: EAGLE-1075
> URL: https://issues.apache.org/jira/browse/EAGLE-1075
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Priority: Major
> Fix For: v0.5.1
>
>
> Right now it's not possible to specify the configuration options for the 
> AlertFilePublisher in the UI. So for example we can't configure the file 
> name/path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (EAGLE-1076) Fix "Fix Versions" of the following JIRAs

[Colm O hEigeartaigh (JIRA)]

Colm O hEigeartaigh created EAGLE-1076:
--

 Summary: Fix "Fix Versions" of the following JIRAs
 Key: EAGLE-1076
 URL: https://issues.apache.org/jira/browse/EAGLE-1076
 Project: Eagle
  Issue Type: Task
Reporter: Colm O hEigeartaigh
 Fix For: v0.5.1


The following JIRAs are "resolved" for 0.5.1 when they are actually fixed in 
0.5.0:

https://issues.apache.org/jira/browse/EAGLE-1056

https://issues.apache.org/jira/browse/EAGLE-487

 

These are resolved for 0.6.0 when they are fixed in 0.5.0 as well:

https://issues.apache.org/jira/browse/EAGLE-1053

https://issues.apache.org/jira/browse/EAGLE-943

 

The "Fix for" versions for these JIRAs should be changed to 0.5.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)