[jira] [Assigned] (EAGLE-1095) restart eagle server
[ https://issues.apache.org/jira/browse/EAGLE-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao, Qingwen reassigned EAGLE-1095: Assignee: Zhao, Qingwen > restart eagle server > > > Key: EAGLE-1095 > URL: https://issues.apache.org/jira/browse/EAGLE-1095 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Dylan Zhao >Assignee: Zhao, Qingwen >Priority: Major > Fix For: v0.5.0 > > > After restarting the eagle server, the newly created site and data will be > reset. How to solve this problem, the work before the service restart is in > vain? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1095) restart eagle server
[ https://issues.apache.org/jira/browse/EAGLE-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835280#comment-16835280 ] Zhao, Qingwen commented on EAGLE-1095: -- Hi [~DylanZhao], Do you use the in-memory storage in your configuration? I think you can use a persistent one, such as MySQL. > restart eagle server > > > Key: EAGLE-1095 > URL: https://issues.apache.org/jira/browse/EAGLE-1095 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Dylan Zhao >Priority: Major > Fix For: v0.5.0 > > > After restarting the eagle server, the newly created site and data will be > reset. How to solve this problem, the work before the service restart is in > vain? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (EAGLE-1096) getJSONArray may cause exception, optJSONArray should be used
[
https://issues.apache.org/jira/browse/EAGLE-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on EAGLE-1096 started by Zhao, Qingwen.
> getJSONArray may cause exception, optJSONArray should be used
> -
>
> Key: EAGLE-1096
> URL: https://issues.apache.org/jira/browse/EAGLE-1096
> Project: Eagle
> Issue Type: Bug
>Reporter: bd2019us
>Assignee: Zhao, Qingwen
>Priority: Major
> Attachments: 1.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Hello,
> The method call jsonBeansObject.getJSONArray("beans") may throw
> JSONException when the key does not exist, which will crash the program. To
> ensure safety, optJSONArray is recommended to use, which will avoid the
> exception in case no such key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [eagle] qingwen220 commented on a change in pull request #1001: [EAGLE-1096] getJSONArray may cause exception, optJSONArray can be used
qingwen220 commented on a change in pull request #1001: [EAGLE-1096]
getJSONArray may cause exception, optJSONArray can be used
URL: https://github.com/apache/eagle/pull/1001#discussion_r281904704
##
File path:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/utils/JMXQueryHelper.java
##
@@ -56,7 +56,7 @@
final Map resultMap = new HashMap();
final JSONTokener tokener = new JSONTokener(is);
final JSONObject jsonBeansObject = new JSONObject(tokener);
-final JSONArray jsonArray = jsonBeansObject.getJSONArray("beans");
+final JSONArray jsonArray = jsonBeansObject.optJSONArray("beans");
int size = jsonArray.length();
Review comment:
Agree with @jhsenjaliya, this change will incur the NPE issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work logged] (EAGLE-1096) getJSONArray may cause exception, optJSONArray should be used
[
https://issues.apache.org/jira/browse/EAGLE-1096?focusedWorklogId=238970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-238970
]
ASF GitHub Bot logged work on EAGLE-1096:
-
Author: ASF GitHub Bot
Created on: 08/May/19 03:50
Start Date: 08/May/19 03:50
Worklog Time Spent: 10m
Work Description: qingwen220 commented on pull request #1001:
[EAGLE-1096] getJSONArray may cause exception, optJSONArray can be used
URL: https://github.com/apache/eagle/pull/1001#discussion_r281904704
##
File path:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/utils/JMXQueryHelper.java
##
@@ -56,7 +56,7 @@
final Map resultMap = new HashMap();
final JSONTokener tokener = new JSONTokener(is);
final JSONObject jsonBeansObject = new JSONObject(tokener);
-final JSONArray jsonArray = jsonBeansObject.getJSONArray("beans");
+final JSONArray jsonArray = jsonBeansObject.optJSONArray("beans");
int size = jsonArray.length();
Review comment:
Agree with @jhsenjaliya, this change will incur the NPE issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 238970)
Time Spent: 0.5h (was: 20m)
> getJSONArray may cause exception, optJSONArray should be used
> -
>
> Key: EAGLE-1096
> URL: https://issues.apache.org/jira/browse/EAGLE-1096
> Project: Eagle
> Issue Type: Bug
>Reporter: bd2019us
>Priority: Major
> Attachments: 1.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Hello,
> The method call jsonBeansObject.getJSONArray("beans") may throw
> JSONException when the key does not exist, which will crash the program. To
> ensure safety, optJSONArray is recommended to use, which will avoid the
> exception in case no such key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (EAGLE-1096) getJSONArray may cause exception, optJSONArray should be used
[
https://issues.apache.org/jira/browse/EAGLE-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835276#comment-16835276
]
Zhao, Qingwen commented on EAGLE-1096:
--
Hi [~bd2019us],
Thanks for contributing the fixing. It will be appreciated if you could
continue to refine your change.
> getJSONArray may cause exception, optJSONArray should be used
> -
>
> Key: EAGLE-1096
> URL: https://issues.apache.org/jira/browse/EAGLE-1096
> Project: Eagle
> Issue Type: Bug
>Reporter: bd2019us
>Priority: Major
> Attachments: 1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hello,
> The method call jsonBeansObject.getJSONArray("beans") may throw
> JSONException when the key does not exist, which will crash the program. To
> ensure safety, optJSONArray is recommended to use, which will avoid the
> exception in case no such key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (EAGLE-1096) getJSONArray may cause exception, optJSONArray should be used
[
https://issues.apache.org/jira/browse/EAGLE-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhao, Qingwen reassigned EAGLE-1096:
Assignee: (was: Zhao, Qingwen)
> getJSONArray may cause exception, optJSONArray should be used
> -
>
> Key: EAGLE-1096
> URL: https://issues.apache.org/jira/browse/EAGLE-1096
> Project: Eagle
> Issue Type: Bug
>Reporter: bd2019us
>Priority: Major
> Attachments: 1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hello,
> The method call jsonBeansObject.getJSONArray("beans") may throw
> JSONException when the key does not exist, which will crash the program. To
> ensure safety, optJSONArray is recommended to use, which will avoid the
> exception in case no such key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (EAGLE-1096) getJSONArray may cause exception, optJSONArray should be used
[
https://issues.apache.org/jira/browse/EAGLE-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhao, Qingwen reassigned EAGLE-1096:
Assignee: Zhao, Qingwen
> getJSONArray may cause exception, optJSONArray should be used
> -
>
> Key: EAGLE-1096
> URL: https://issues.apache.org/jira/browse/EAGLE-1096
> Project: Eagle
> Issue Type: Bug
>Reporter: bd2019us
>Assignee: Zhao, Qingwen
>Priority: Major
> Attachments: 1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hello,
> The method call jsonBeansObject.getJSONArray("beans") may throw
> JSONException when the key does not exist, which will crash the program. To
> ensure safety, optJSONArray is recommended to use, which will avoid the
> exception in case no such key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (EAGLE-1097) CorrelationSpout存在性能问题
[ https://issues.apache.org/jira/browse/EAGLE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao, Qingwen reassigned EAGLE-1097: Assignee: Zhao, Qingwen > CorrelationSpout存在性能问题 > -- > > Key: EAGLE-1097 > URL: https://issues.apache.org/jira/browse/EAGLE-1097 > Project: Eagle > Issue Type: Improvement > Components: Core::Eagle Server >Affects Versions: v0.3.0 >Reporter: zhangchi >Assignee: Zhao, Qingwen >Priority: Major > Fix For: v0.3.1 > > Attachments: Catch(04-23-09-26-01).jpg, Catch633F(04-23-09-26-01).jpg > > > I ran into a problem where performance dropped dramatically when I switched > on two strategies.These two policies subscribe to two kafka topics, > respectively. I looked at processes that were using too much CPU, and found > that the performance bottlenecks were in the spout send phase.The topics I > subscribed to were divided into 10 sections, and the numOfSpoutTasks I > configured was 20. How shall I adjust the performance problem? > --- > 我遇到了一个问题，在我开启了两个策略的时候，性能会急剧下降。这两个策略分别订阅两个kafka > topic,我查看了CPU使用过高的进程，发现性能瓶颈都是在spout发送这一环节。我订阅的topic分别有10个分区，我配置的numOfSpoutTasks是20.请问我要怎么调整这个性能问题。 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (EAGLE-1097) CorrelationSpout存在性能问题
[ https://issues.apache.org/jira/browse/EAGLE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on EAGLE-1097 started by Zhao, Qingwen. > CorrelationSpout存在性能问题 > -- > > Key: EAGLE-1097 > URL: https://issues.apache.org/jira/browse/EAGLE-1097 > Project: Eagle > Issue Type: Improvement > Components: Core::Eagle Server >Affects Versions: v0.3.0 >Reporter: zhangchi >Assignee: Zhao, Qingwen >Priority: Major > Fix For: v0.3.1 > > Attachments: Catch(04-23-09-26-01).jpg, Catch633F(04-23-09-26-01).jpg > > > I ran into a problem where performance dropped dramatically when I switched > on two strategies.These two policies subscribe to two kafka topics, > respectively. I looked at processes that were using too much CPU, and found > that the performance bottlenecks were in the spout send phase.The topics I > subscribed to were divided into 10 sections, and the numOfSpoutTasks I > configured was 20. How shall I adjust the performance problem? > --- > 我遇到了一个问题，在我开启了两个策略的时候，性能会急剧下降。这两个策略分别订阅两个kafka > topic,我查看了CPU使用过高的进程，发现性能瓶颈都是在spout发送这一环节。我订阅的topic分别有10个分区，我配置的numOfSpoutTasks是20.请问我要怎么调整这个性能问题。 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (EAGLE-1097) CorrelationSpout存在性能问题
[ https://issues.apache.org/jira/browse/EAGLE-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835273#comment-16835273 ] Zhao, Qingwen commented on EAGLE-1097: -- Hi [~zhangchi], You can either increase the topic partitions or reduce the numberOfSpoutTasks. If you the partition number < the totalTasks, some tasks will be idle. You can check the source code at here [https://github.com/apache/storm/blob/0.9.x-branch/external/storm-kafka/src/jvm/storm/kafka/ZkCoordinator.java#L80] > CorrelationSpout存在性能问题 > -- > > Key: EAGLE-1097 > URL: https://issues.apache.org/jira/browse/EAGLE-1097 > Project: Eagle > Issue Type: Improvement > Components: Core::Eagle Server >Affects Versions: v0.3.0 >Reporter: zhangchi >Priority: Major > Fix For: v0.3.1 > > Attachments: Catch(04-23-09-26-01).jpg, Catch633F(04-23-09-26-01).jpg > > > I ran into a problem where performance dropped dramatically when I switched > on two strategies.These two policies subscribe to two kafka topics, > respectively. I looked at processes that were using too much CPU, and found > that the performance bottlenecks were in the spout send phase.The topics I > subscribed to were divided into 10 sections, and the numOfSpoutTasks I > configured was 20. How shall I adjust the performance problem? > --- > 我遇到了一个问题，在我开启了两个策略的时候，性能会急剧下降。这两个策略分别订阅两个kafka > topic,我查看了CPU使用过高的进程，发现性能瓶颈都是在spout发送这一环节。我订阅的topic分别有10个分区，我配置的numOfSpoutTasks是20.请问我要怎么调整这个性能问题。 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
