[GitHub] [eagle] trixpan closed pull request #1002: fix minor typo
trixpan closed pull request #1002: URL: https://github.com/apache/eagle/pull/1002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [eagle] yonzhang commented on issue #1010: (DON'T MERGE) Eagle 1.0 preparation
yonzhang commented on issue #1010: (DON'T MERGE) Eagle 1.0 preparation URL: https://github.com/apache/eagle/pull/1010#issuecomment-616221175 modified branch name This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] yonzhang closed pull request #1010: (DON'T MERGE) Eagle 1.0 preparation
yonzhang closed pull request #1010: (DON'T MERGE) Eagle 1.0 preparation URL: https://github.com/apache/eagle/pull/1010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] yonzhang opened a new pull request #1011: (DON'T MERGE) EAGLE-1104, Eagle 1.0 preparation
yonzhang opened a new pull request #1011: (DON'T MERGE) EAGLE-1104, Eagle 1.0 preparation URL: https://github.com/apache/eagle/pull/1011 Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] yonzhang opened a new pull request #1010: (DON'T MERGE) Eagle 1.0 preparation
yonzhang opened a new pull request #1010: (DON'T MERGE) Eagle 1.0 preparation URL: https://github.com/apache/eagle/pull/1010 Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] YYTVicky opened a new pull request #1009: Leave a node to tell user that it is not secure
YYTVicky opened a new pull request #1009: Leave a node to tell user that it is not secure URL: https://github.com/apache/eagle/pull/1009 Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] dependabot[bot] opened a new pull request #1008: Bump angular from 1.5.0 to 1.7.9 in /eagle-server/src/main/webapp/app
dependabot[bot] opened a new pull request #1008: Bump angular from 1.5.0 to 1.7.9 in /eagle-server/src/main/webapp/app URL: https://github.com/apache/eagle/pull/1008 Bumps [angular](https://github.com/angular/angular.js) from 1.5.0 to 1.7.9. Changelog *Sourced from [angular's changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md).* > # 1.7.9 pollution-eradication (2019-11-19) > > ## Bug Fixes > - **angular.merge:** do not merge __proto__ property > ([726f49](https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a)) > (Thanks to the [Snyk Security Research Team](https://snyk.io/blog/snyk-research-team-discovers-severe-prototype-pollution-security-vulnerabilities-affecting-all-versions-of-lodash/) for identifyng this issue.) > - **ngStyle:** correctly remove old style when new style value is invalid > ([5edd25](https://github.com/angular/angular.js/commit/5edd25364f617083363dc2bd61f9230b38267578), > [#16860](https://github-redirect.dependabot.com/angular/angular.js/issues/16860), > [#16868](https://github-redirect.dependabot.com/angular/angular.js/issues/16868)) > > > > # 1.7.8 enthusiastic-oblation (2019-03-11) > > > ## Bug Fixes > - **required:** correctly validate required on non-input element surrounded by ngIf > ([a4c7bd](https://github.com/angular/angular.js/commit/a4c7bdccd76c39c30e33f6215da9a00cc8acde2c), > [#16830](https://github-redirect.dependabot.com/angular/angular.js/issues/16830), > [#16836](https://github-redirect.dependabot.com/angular/angular.js/issues/16836)) > > > > # 1.7.7 kingly-exiting (2019-02-04) > > ## Bug Fixes > - **ngRequired:** set error correctly when inside ngRepeat and false by default > ([5ad4f5](https://github.com/angular/angular.js/commit/5ad4f5562c37b1cb575e3e5fddd96e9dd10408e2), > [#16814](https://github-redirect.dependabot.com/angular/angular.js/issues/16814), > [#16820](https://github-redirect.dependabot.com/angular/angular.js/issues/16820)) > > > > # 1.7.6 gravity-manipulation (2019-01-17) > > ## Bug Fixes > - **$compile:** fix ng-prop-* with undefined values > ([772440](https://github.com/angular/angular.js/commit/772440cdaf9a9bfa40de1675e20a5f0e356089ed), > [#16797](https://github-redirect.dependabot.com/angular/angular.js/issues/16797), > [#16798](https://github-redirect.dependabot.com/angular/angular.js/issues/16798)) > - **compile:** properly handle false value for boolean attrs with jQuery > ([27486b](https://github.com/angular/angular.js/commit/27486bd15e70946ece2ba713e4e8654b7f9bddad), > [#16778](https://github-redirect.dependabot.com/angular/angular.js/issues/16778), > [#16779](https://github-redirect.dependabot.com/angular/angular.js/issues/16779)) > - **ngRepeat:** > - fix reference to last collection value remaining across linkages > ([cf919a](https://github.com/angular/angular.js/commit/cf919a6fb7fc655f3fa37a74899a797ea5b8073e)) > - fix trackBy function being invoked with incorrect scope > ([d4d103](https://github.com/angular/angular.js/commit/d4d1031bcd9b30ae6a58bd60a79bcc9d20f0f2b7), > ... (truncated) Commits - [`d257c45`](https://github.com/angular/angular.js/commit/d257c4564d069a279c5625ad6b68008d4a4dbb11) docs: release notes for 1.7.9 - [`1b1684c`](https://github.com/angular/angular.js/commit/1b1684c2b20a75df677426d4e4a61d51af3b5c44) docs($compile): fix typos and incorrect example - [`726f49d`](https://github.com/angular/angular.js/commit/726f49dcf6c23106ddaf5cfd5e2e592841db743a) fix(angular.merge): do not merge __proto__ property - [`8a187f1`](https://github.com/angular/angular.js/commit/8a187f16c37e0574b1a1fa7ccc54f3690d9d81ec) chore(saucelabs): switch to latest version of desktop Safari - [`d97e6f1`](https://github.com/angular/angular.js/commit/d97e6f169536fdb7bd8b0c7735b79348d5669213) chore(saucelabs): upgrade SauceConnect to 4.5.4 - [`26e893a`](https://github.com/angular/angular.js/commit/26e893a2faa5be9b563948963dc4ac71990e5100) docs(guide/migration): fix typo (misceallenous --> miscellaneous) - [`5edd253`](https://github.com/angular/angular.js/commit/5edd25364f617083363dc2bd61f9230b38267578) fix(ngStyle): correctly remove old style when new style value is invalid - [`019dded`](https://github.com/angular/angular.js/commit/019dded64b7a58d67994af5f0f5b532f1c97b908) chore(*): update jQuery from 3.2.1 to 3.4.0 - [`0007be1`](https://github.com/angular/angular.js/commit/0007be1ca2f3d3b8e1b914e2cdc3c943cbe16bc9) chore(*): make yarn.lock & GitHub templates identical between master & v1.7.x - [`863528f`](https://github.com/angular/angular.js/commit/863528f2999a32cfb16761258e94e03479e349e8) docs(DEVELOPERS): remove git revert misleading information - Additional commits viewable in [com
[GitHub] [eagle] dependabot[bot] opened a new pull request #1007: Bump fasterxml-jackson.version from 2.5.4 to 2.10.1
dependabot[bot] opened a new pull request #1007: Bump fasterxml-jackson.version from 2.5.4 to 2.10.1 URL: https://github.com/apache/eagle/pull/1007 Bumps `fasterxml-jackson.version` from 2.5.4 to 2.10.1. Updates `jackson-core` from 2.5.4 to 2.10.1 Commits - [`60956fc`](https://github.com/FasterXML/jackson-core/commit/60956fccd24d6bdb66abb3182cb2234122039b7a) [maven-release-plugin] prepare release jackson-core-2.10.1 - [`05a025d`](https://github.com/FasterXML/jackson-core/commit/05a025d16b32bf69184811dcebae9e000a56e0cb) ... - [`81a9952`](https://github.com/FasterXML/jackson-core/commit/81a9952a681f6f6e1fab6fa5216749cf75f4a7e9) prepare for 2.10.1 - [`ce0d5e1`](https://github.com/FasterXML/jackson-core/commit/ce0d5e10ddb290cdc6b107805fb15b5eed97f5f3) revert now unnecessary sonatype deploy plugin - [`adf6fd0`](https://github.com/FasterXML/jackson-core/commit/adf6fd02a4aa0ba872f6857c6e1ac38d3b96c9dc) Add Sonatype deploy plugin to simplify releases - [`7ca30ec`](https://github.com/FasterXML/jackson-core/commit/7ca30eccc96e8eb02bc6b1a4aab3d78c1bba1388) array index out of bounds in hex lookup ([#578](https://github-redirect.dependabot.com/FasterXML/jackson-core/issues/578)) - [`da5365e`](https://github.com/FasterXML/jackson-core/commit/da5365edc9b0644ed446ce8b227dadb62a8821e9) Fix [#578](https://github-redirect.dependabot.com/FasterXML/jackson-core/issues/578): non-blocking path still had potential problem, but changed method i... - [`db0f586`](https://github.com/FasterXML/jackson-core/commit/db0f5860085425dbe08b3e2b81801fc0e5e62bba) ... - [`243fadc`](https://github.com/FasterXML/jackson-core/commit/243fadc879345732a9a5bb18b2d587a0272e5ddc) Fix [#567](https://github-redirect.dependabot.com/FasterXML/jackson-core/issues/567) - [`714df7b`](https://github.com/FasterXML/jackson-core/commit/714df7b5f3507d13ba7480c27b30e96d69fc076b) ... - Additional commits viewable in [compare view](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.5.4...jackson-core-2.10.1) Updates `jackson-annotations` from 2.5.4 to 2.10.1 Commits - See full diff in [compare view](https://github.com/FasterXML/jackson/commits) Updates `jackson-databind` from 2.5.4 to 2.10.1 Commits - See full diff in [compare view](https://github.com/FasterXML/jackson/commits) Updates `jackson-module-scala_2.11` from 2.5.4 to 2.10.1 Commits - See full diff in [compare view](https://github.com/FasterXML/jackson-module-scala/commits/jackson-module-scala-2.10.1) Updates `jackson-jaxrs-json-provider` from 2.5.4 to 2.10.1 Updates `jackson-jaxrs-base` from 2.5.4 to 2.10.1 Commits - [`ad33cf2`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/ad33cf266959f19d802c73c0f2f5c833dc1bf9d7) [maven-release-plugin] prepare release jackson-jaxrs-providers-2.10.1 - [`390b081`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/390b081f6f37291c8e5048bf79548d26cde99221) prepare for 2.10.1 - [`1e12ad4`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/1e12ad4348f4e769faa88e04840326572e657a47) Allow access to JsonEndpointConfig and message providers for jdk 11 and up - [`f3d031c`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/f3d031c28568436ecbb38226b75e54bf0dbda84d) Update release notes wrt [#114](https://github-redirect.dependabot.com/FasterXML/jackson-jaxrs-providers/issues/114) - [`00a2819`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/00a28193c27f1e174196c67baf01dd383a680744) Merge pull request [#116](https://github-redirect.dependabot.com/FasterXML/jackson-jaxrs-providers/issues/116) from GedMarc/2.10 - [`e204d37`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/e204d3796ca41ffd4673e0e6ab466aeb7593a0b8) Update `javax.ws.rs-api` dep from 2.0.1 to 2.1.1 - [`f3cd3b6`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/f3cd3b6edddeae1843dcea1817add710476a88e5) [FasterXML/jackson-jaxrs-providers#114](https://github-redirect.dependabot.com/FasterXML/jackson-jaxrs-providers/issues/114) - [`30d02c1`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/30d02c1c93329c8335b31c0f841c9a20d3ff9594) Merge pull request [#1](https://github-redirect.dependabot.com/FasterXML/jackson-jaxrs-providers/issues/1) from FasterXML/2.10 - [`8b1219e`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/8b1219e6736603bc7ad54fc2e1761e01757c0ac6) [maven-release-plugin] prepare for next development iteration - [`d498824`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/d4988248b0399619ca544e96b0931986f0eb26b8) [maven-release-plugin] prepare release jackson-jaxrs-providers-2.10.0 - Additional commits viewable in [compare view](https://github.com/FasterXML/jackson-jaxrs-providers/compare/jackson-jaxrs-providers-2.5.4...jackson-jaxrs-p
[GitHub] [eagle] dependabot[bot] commented on issue #1006: Bump fasterxml-jackson.version from 2.5.4 to 2.10.0
dependabot[bot] commented on issue #1006: Bump fasterxml-jackson.version from 2.5.4 to 2.10.0 URL: https://github.com/apache/eagle/pull/1006#issuecomment-553245940 Superseded by #1007. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] dependabot[bot] closed pull request #1006: Bump fasterxml-jackson.version from 2.5.4 to 2.10.0
dependabot[bot] closed pull request #1006: Bump fasterxml-jackson.version from 2.5.4 to 2.10.0 URL: https://github.com/apache/eagle/pull/1006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] dependabot[bot] opened a new pull request #1006: Bump fasterxml-jackson.version from 2.5.4 to 2.10.0
dependabot[bot] opened a new pull request #1006: Bump fasterxml-jackson.version from 2.5.4 to 2.10.0 URL: https://github.com/apache/eagle/pull/1006 Bumps `fasterxml-jackson.version` from 2.5.4 to 2.10.0. Updates `jackson-core` from 2.5.4 to 2.10.0 Commits - [`2ce8890`](https://github.com/FasterXML/jackson-core/commit/2ce88904df6c60ef0c4708f6c514885cef850409) [maven-release-plugin] prepare release jackson-core-2.10.0 - [`0e59212`](https://github.com/FasterXML/jackson-core/commit/0e5921298398d8a4d1410a1b5d7823e619f53353) Prepare for 2.10.0 - [`e8c9f22`](https://github.com/FasterXML/jackson-core/commit/e8c9f228c057033d205057293ea034bbb4a1c4a1) Merge branch '2.9' into 2.10 - [`4899c28`](https://github.com/FasterXML/jackson-core/commit/4899c28558e73bed16eddc8013a12def6643f231) [maven-release-plugin] prepare for next development iteration - [`d4bfe20`](https://github.com/FasterXML/jackson-core/commit/d4bfe205405caf948de35b4380f2d3221cdad072) [maven-release-plugin] prepare release jackson-core-2.9.10 - [`b17e3f1`](https://github.com/FasterXML/jackson-core/commit/b17e3f1d4b21d105b443e4f0cc9ea215578415a5) Prepare for 2.9.10 - [`fc73bee`](https://github.com/FasterXML/jackson-core/commit/fc73bee380444112e9294545d4f0b66094884dab) Fix [#563](https://github-redirect.dependabot.com/FasterXML/jackson-core/issues/563) (async parser, location for array values) - [`ce70782`](https://github.com/FasterXML/jackson-core/commit/ce70782781693c8f3410c1ea9f0c6a9f66750523) Start work on [#563](https://github-redirect.dependabot.com/FasterXML/jackson-core/issues/563) - [`1c852df`](https://github.com/FasterXML/jackson-core/commit/1c852dfb26f008047b676d435395ced3ebd2946c) ... - [`8a0df82`](https://github.com/FasterXML/jackson-core/commit/8a0df820bb997f4e82a1c6859820f39a8652185a) Minor test change - Additional commits viewable in [compare view](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.5.4...jackson-core-2.10.0) Updates `jackson-annotations` from 2.5.4 to 2.10.0 Commits - See full diff in [compare view](https://github.com/FasterXML/jackson/commits) Updates `jackson-databind` from 2.5.4 to 2.10.0 Commits - See full diff in [compare view](https://github.com/FasterXML/jackson/commits) Updates `jackson-module-scala_2.11` from 2.5.4 to 2.10.0 Commits - See full diff in [compare view](https://github.com/FasterXML/jackson-module-scala/commits/jackson-module-scala-2.10.0) Updates `jackson-jaxrs-json-provider` from 2.5.4 to 2.10.0 Updates `jackson-jaxrs-base` from 2.5.4 to 2.10.0 Commits - [`d498824`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/d4988248b0399619ca544e96b0931986f0eb26b8) [maven-release-plugin] prepare release jackson-jaxrs-providers-2.10.0 - [`b14e622`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/b14e6220a39d0201de25991548629232dfa93abd) whops. New attempt - [`e060269`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/e06026995bc6a9bc79e94b3b45aee8bbdf75a5cb) [maven-release-plugin] prepare for next development iteration - [`ccc1917`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/ccc191786bbe7ad40b0680fd5196f3b287276468) [maven-release-plugin] prepare release jackson-jaxrs-providers-2.10.0 - [`a52215c`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/a52215cd0760c9a0430e09ad1ab4216513f2819d) Prepare for 2.10.0 - [`72193d6`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/72193d65a865171c5329a76eb87e8898382f36eb) Merge branch '2.9' into 2.10 - [`769dba1`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/769dba1e9bd696e6b854932f0756892f6fa3f3c8) [maven-release-plugin] prepare for next development iteration - [`d16a5db`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/d16a5db556f0761f18cd4d57b81e073eb52568a3) [maven-release-plugin] prepare release jackson-jaxrs-providers-2.9.10 - [`c1f6058`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/c1f605849f97efcfedc759b81b00e3cc2173f423) Prepare for 2.9.10 - [`bfd688a`](https://github.com/FasterXML/jackson-jaxrs-providers/commit/bfd688a3022da4e8fe9893b6f29b8d7f407c8e8e) ... - Additional commits viewable in [compare view](https://github.com/FasterXML/jackson-jaxrs-providers/compare/jackson-jaxrs-providers-2.5.4...jackson-jaxrs-providers-2.10.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` wi
[GitHub] [eagle] asfgit closed pull request #1005: [EAGLE-1102] Integrate CVE maven plugin
asfgit closed pull request #1005: [EAGLE-1102] Integrate CVE maven plugin URL: https://github.com/apache/eagle/pull/1005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] haoch commented on issue #1005: [EAGLE-1102] Integrate CVE maven plugin
haoch commented on issue #1005: [EAGLE-1102] Integrate CVE maven plugin URL: https://github.com/apache/eagle/pull/1005#issuecomment-539350699 LGTM, thanks @grainier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] grainier commented on issue #1005: [EAGLE-1102] Integrate CVE maven plugin
grainier commented on issue #1005: [EAGLE-1102] Integrate CVE maven plugin URL: https://github.com/apache/eagle/pull/1005#issuecomment-538711494 @haoch It's attached on the parent issue [1]. And the `dependency-check-report.html` can be found on [2]. [1] https://issues.apache.org/jira/browse/EAGLE-1100 [2] https://issues.apache.org/jira/secure/attachment/12982206/dependency-check-report.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] haoch commented on issue #1005: [EAGLE-1102] Integrate CVE maven plugin
haoch commented on issue #1005: [EAGLE-1102] Integrate CVE maven plugin URL: https://github.com/apache/eagle/pull/1005#issuecomment-538710474 @grainier Could you please attach the CVE alerts on the jira/PR as well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] grainier opened a new pull request #1005: [EAGLE-1102] Integrate CVE maven plugin
grainier opened a new pull request #1005: [EAGLE-1102] Integrate CVE maven plugin URL: https://github.com/apache/eagle/pull/1005 ## Purpose Purpose of this pull request is to integrate the CVE maven plugin for eagle to check security vulnerabilities in dependencies during build time. This will help to detect publicly disclosed vulnerabilities contained within eagle's dependencies (and the dependencies of all child modules). ## Usage This plugin configuration is attached to the `mvn verify` phase. Therefore, this will run automatically when we perform a `mvn clean verify`. Once the `mvn` process is completed, the plugin will create a `dependency-check-report.html` report in `target/` dir with the detect vulnerabilities. In case if you need to skip this plugin, use `owasp.check.skip=true` property (i.e `mvn clean verify -Dowasp.check.skip=true`). ## Remarks - Fixes https://issues.apache.org/jira/browse/EAGLE-1102 - https://issues.apache.org/jira/browse/EAGLE-1100 - https://github.com/jeremylong/DependencyCheck - https://jeremylong.github.io/DependencyCheck/dependency-check-maven/aggregate-mojo.html - https://jeremylong.github.io/DependencyCheck/general/suppression.html --- Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] asfgit closed pull request #1004: [EAGLE-1101] Update merge-eagle-pr.py to support python 3.x
asfgit closed pull request #1004: [EAGLE-1101] Update merge-eagle-pr.py to support python 3.x URL: https://github.com/apache/eagle/pull/1004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] asfgit closed pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
asfgit closed pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] haoch opened a new pull request #1004: [DevTool] Update merge-eagle-pr.py to support python 3.x
haoch opened a new pull request #1004: [DevTool] Update merge-eagle-pr.py to support python 3.x URL: https://github.com/apache/eagle/pull/1004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003#issuecomment-536406186 LGTM, will merge if no more questions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] grainier commented on a change in pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
grainier commented on a change in pull request #1003: [EAGLE-1068] Upgrade
Siddhi dependency to v5.1.4
URL: https://github.com/apache/eagle/pull/1003#discussion_r327474090
##
File path:
eagle-core/eagle-common/src/test/java/org/apache/eagle/common/TestDateTimeUtil.java
##
@@ -49,7 +49,7 @@ public void testRound2() {
cal.set(Calendar.MINUTE, 0);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);
-Assert.assertEquals(tsInHour, cal.getTimeInMillis());
+//Assert.assertEquals(tsInHour, cal.getTimeInMillis());
Review comment:
@haoch, sorry, it was a mistake. When I tried to build, this failed
intermittently (even with the master), so I commented it out. Reverted with
1240042
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [eagle] haoch commented on a change in pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
haoch commented on a change in pull request #1003: [EAGLE-1068] Upgrade Siddhi
dependency to v5.1.4
URL: https://github.com/apache/eagle/pull/1003#discussion_r327296261
##
File path:
eagle-core/eagle-common/src/test/java/org/apache/eagle/common/TestDateTimeUtil.java
##
@@ -49,7 +49,7 @@ public void testRound2() {
cal.set(Calendar.MINUTE, 0);
cal.set(Calendar.SECOND, 0);
cal.set(Calendar.MILLISECOND, 0);
-Assert.assertEquals(tsInHour, cal.getTimeInMillis());
+//Assert.assertEquals(tsInHour, cal.getTimeInMillis());
Review comment:
@grainier Why remove this assertion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [eagle] haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
haoch commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003#issuecomment-534253270 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] jhsenjaliya commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
jhsenjaliya commented on issue #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003#issuecomment-531496811 looking at this PR, all siddhi extension code upgrade looks right, @haoch can u pls help review this PR as well since you have more insights into siddhi's execution engine. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] grainier opened a new pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4
grainier opened a new pull request #1003: [EAGLE-1068] Upgrade Siddhi dependency to v5.1.4 URL: https://github.com/apache/eagle/pull/1003 ## Purpose Purpose of this pull request is to upgrade the [Siddhi](https://mvnrepository.com/artifact/io.siddhi) dependency version to `v5.1.4`. With this, it'll also; - Fix `alert-core` and tests to support new Siddhi APIs. - Fix existing custom Siddhi extensions to support new Siddhi APIs. - Improve extension loading (use annotation support instead of `siddhiext`). - Add the following dependencies (since they are now separated from Siddhi core); ```xml io.siddhi.extension.execution.regex siddhi-execution-regex 5.0.5 io.siddhi.extension.execution.string siddhi-execution-string 5.0.5 ``` ## Remarks - Fixes https://issues.apache.org/jira/browse/EAGLE-1068 - https://issues.apache.org/jira/browse/EAGLE-1065 --- Contribution Tasks: - [x] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] pkuwm closed pull request #426: [EAGLE-522] Implement HOURLY_RULE for Absence Alert.
pkuwm closed pull request #426: [EAGLE-522] Implement HOURLY_RULE for Absence Alert. URL: https://github.com/apache/eagle/pull/426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] pkuwm closed pull request #505: [EAGLE-581] Generate buildnumber when building the project.
pkuwm closed pull request #505: [EAGLE-581] Generate buildnumber when building the project. URL: https://github.com/apache/eagle/pull/505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] qingwen220 commented on a change in pull request #1001: [EAGLE-1096] getJSONArray may cause exception, optJSONArray can be used
qingwen220 commented on a change in pull request #1001: [EAGLE-1096]
getJSONArray may cause exception, optJSONArray can be used
URL: https://github.com/apache/eagle/pull/1001#discussion_r281904704
##
File path:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/utils/JMXQueryHelper.java
##
@@ -56,7 +56,7 @@
final Map resultMap = new HashMap();
final JSONTokener tokener = new JSONTokener(is);
final JSONObject jsonBeansObject = new JSONObject(tokener);
-final JSONArray jsonArray = jsonBeansObject.getJSONArray("beans");
+final JSONArray jsonArray = jsonBeansObject.optJSONArray("beans");
int size = jsonArray.length();
Review comment:
Agree with @jhsenjaliya, this change will incur the NPE issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [eagle] trixpan opened a new pull request #1002: fix minor typo
trixpan opened a new pull request #1002: fix minor typo URL: https://github.com/apache/eagle/pull/1002 Fixes a minor typo in documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] jhsenjaliya commented on a change in pull request #1001: [EAGLE-1096] getJSONArray may cause exception, optJSONArray can be used
jhsenjaliya commented on a change in pull request #1001: [EAGLE-1096]
getJSONArray may cause exception, optJSONArray can be used
URL: https://github.com/apache/eagle/pull/1001#discussion_r275139161
##
File path:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/utils/JMXQueryHelper.java
##
@@ -56,7 +56,7 @@
final Map resultMap = new HashMap();
final JSONTokener tokener = new JSONTokener(is);
final JSONObject jsonBeansObject = new JSONObject(tokener);
-final JSONArray jsonArray = jsonBeansObject.getJSONArray("beans");
+final JSONArray jsonArray = jsonBeansObject.optJSONArray("beans");
int size = jsonArray.length();
Review comment:
if jsonArray is going to be null, can u add that handling as well ? Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [eagle] bd2019us opened a new pull request #1001: [EAGLE-1096] getJSONArray may cause exception, optJSONArray can be used
bd2019us opened a new pull request #1001: [EAGLE-1096] getJSONArray may cause exception, optJSONArray can be used URL: https://github.com/apache/eagle/pull/1001 Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [eagle] bd2019us opened a new pull request #1000: [EAGLE-1094] change JSONObject.getString() to optString() to avoid exception
bd2019us opened a new pull request #1000: [EAGLE-1094] change JSONObject.getString() to optString() to avoid exception URL: https://github.com/apache/eagle/pull/1000 Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. This command causes style. - [x] Replace `` in the title with the actual Jira issue number, if there is one. --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
