[GitHub] eagle pull request #799: [EAGLE-890] Add Job Scheduling Framework and Hadoop...
Github user haoch closed the pull request at: https://github.com/apache/eagle/pull/799 ---
[GitHub] eagle issue #922: [MINOR] Fix some project construction problems about `test...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/922 @asdf2014 Thanks! ---
[GitHub] eagle pull request #989: [MINOR] Upgrade jquery to v3.3.1
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/989 [MINOR] Upgrade jquery to v3.3.1 Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle patch-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/989.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #989 commit 134cc7e6765259607d38c87f019b4567aa4a096a Author: Hao Chen <haoch@...> Date: 2018-03-06T06:45:10Z [MINOR] Upgrade jquery to v3.3.1 ---
[GitHub] eagle issue #974: EAGLE-1072 - Fixing SHA link
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/974 Merged. ---
[GitHub] eagle issue #974: EAGLE-1072 - Fixing SHA link
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/974 LGTM, thanks very much! ---
[GitHub] eagle pull request #971: Add eagle v0.5.0 release doc
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/971 Add eagle v0.5.0 release doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle site Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/971.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #971 commit 038bde7f53fa48655340d043465e74a1698564c6 Author: Hao Chen <hch...@ebay.com> Date: 2017-11-22T05:50:39Z Add eagle v0.5.0 release doc ---
[GitHub] eagle pull request #967: [MINOR] Docs: remove incubator words
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/967 [MINOR] Docs: remove incubator words - Docs: remove incubator words You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle removeIncubatorWords Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/967.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #967 commit f2b6a74a67028a274007089125cc9ce4183ea496 Author: Hao Chen <hch...@ebay.com> Date: 2017-08-08T06:09:09Z [DOC] remove incubator words --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #965: EAGLE-1059: fix a bug in PolicyResource.java
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/965 OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #959: EAGLE-1051: update removePolicy
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/959 @qingwen220 should it be included in `v0.5.0` release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #966: [EAGLE-1060] updating version to 0.5.0
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/966 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #906: [Minor] add copyright of mkdocs to LICENSE
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/906 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #908: [EAGLE-998]Add eagle csd
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/908 @baibaichen @chitin reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #904: [MINOR][DOC]Add oozie applicaton installation doc
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/904 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/783 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #849: [EAGLE-934] eagle 0.5 assembly update
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/849 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #783: [EAGLE-872] Transform counter metric to rate metric
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/783
@r7raul1984 how do you think expose `CountMetricFilter` as a parameter to
choose which metric to convert as `count`, and the current hard-code behavior
should only be some kind of default implementation?
@FunctionInterface
interface CountMetricFilter extends Function<Map, Boolean>
DefaultCountMetricFilter = (metric) ->
metric["metric"].endsWith("*.count")
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #849: [EAGLE-934] eagle 0.5 assembly update
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/849#discussion_r106598634
--- Diff: eagle-assembly/src/main/conf/eagle.conf ---
@@ -75,7 +77,8 @@ metadata {
username = "root"
password = ""
driverClassName = com.mysql.jdbc.Driver
-url = "jdbc:mysql://server.eagle.apache.org:3306/eagle"
+database = "eagle"
+connection =
"jdbc:mysql://server.eagle.apache.org:3306/eagle?user=root"
--- End diff --
Is the `user=root` duplicated with `username` field?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #884: [MINOR] Fix jdbc depenency problem in package assembly
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/884 Related to #834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #884: [MINOR] Fix jdbc depenency problem in package assem...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/884 [MINOR] Fix jdbc depenency problem in package assembly You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle FixJDBCLoader Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/884.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #884 commit 844d58afbcb946c1031697210796c426db3e9eea Author: Hao Chen <h...@apache.org> Date: 2017-03-17T06:43:22Z Fix jdbc deps in assembly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #880: [MINOR] fix system-metric-collector collect disk info bug
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/880 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #871: [Eagle 952] system dashbord
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/871 @koone cool, please update once it's done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #871: [Eagle 952] system dashbord
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/871 @koone @chitin how about this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #869: EAGLE-946: Refactor MRRunningJobApp & HadoopQueueApp
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/869 @qingwen220 i think you are right, please move forward to merge it after refining the configuration properties. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #869: EAGLE-946: Refactor MRRunningJobApp & HadoopQueueApp
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/869 @qingwen220 What's the default value for each configurations as mentioned above? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #871: [Eagle 952] system dashbord
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/871 @koone could you please add a screenshot about the feature in jira ticket? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #868: [MINOR] Fix metadata updating bug by impl equals/ha...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/868 [MINOR] Fix metadata updating bug by impl equals/hashCode Fix metadata updating bug by impl equals/hashCode You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle FixMetadataUpdate Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/868.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #868 commit 78a4ea543cbfa7cda36cfdb863d5e04eda94bf0e Author: Hao Chen <h...@apache.org> Date: 2017-03-13T07:40:38Z Fix metadata updating bug by impl equals/hascode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #865: [EAGLE-950] Add REST Stream Proxy for easy integrat...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/865 [EAGLE-950] Add REST Stream Proxy for easy integration https://issues.apache.org/jira/browse/EAGLE-950 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle ImproveMetricMonitor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/865.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #865 commit 243c0848153154fce684101d34aa20f8dd628617 Author: Hao Chen <h...@apache.org> Date: 2017-03-03T08:17:06Z Fix metric monitoring commit e454426fcba81ecc15f0a46e2879a0f60ce3ee03 Author: Hao Chen <h...@apache.org> Date: 2017-03-03T13:54:48Z Initialize StreamProxy commit fc2e46a3e89cdae2e03a5ff8f12649b41a7352bc Author: Hao Chen <h...@apache.org> Date: 2017-03-10T09:42:48Z Implement basic version of stream proxy commit dd950e20a3933695e407af811e68a993b857fe76 Author: Hao Chen <h...@apache.org> Date: 2017-03-10T10:30:50Z Add StreamValidator --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #854: [EAGLE-935] add jdbc storage support for sla job me...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/854#discussion_r104364892
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/test/ApplicationSimulatorImpl.java
---
@@ -74,24 +75,25 @@ public void start(String appType, Map<String, Object>
appConfig) {
// Start application
applicationResource.startApplication(new
ApplicationOperations.StartOperation(applicationEntity.getUuid()));
statusUpdateService.updateApplicationEntityStatus(applicationEntity);
-applicationResource.stopApplication(new
ApplicationOperations.StopOperation(applicationEntity.getUuid()));
-int attempt = 0;
-while (attempt < 10) {
-attempt++;
-
statusUpdateService.updateApplicationEntityStatus(applicationEntity);
-if (applicationEntity.getStatus() ==
ApplicationEntity.Status.STOPPED
-|| applicationEntity.getStatus() ==
ApplicationEntity.Status.INITIALIZED) {
-break;
-} else {
+Semaphore semp = new Semaphore(1);
+Thread stopThread = new Thread(() -> {
+applicationResource.stopApplication(new
ApplicationOperations.StopOperation(applicationEntity.getUuid()));
+while (applicationEntity.getStatus() !=
ApplicationEntity.Status.INITIALIZED
+&& applicationEntity.getStatus() !=
ApplicationEntity.Status.STOPPED) {
+
statusUpdateService.updateApplicationEntityStatus(applicationEntity);
try {
-Thread.sleep(500);
-} catch (InterruptedException e) {
-// Ignore
+Thread.sleep(1000);
+} catch (Exception e) {
}
}
-}
-if (attempt >= 10 ) {
-throw new IllegalStateException("Application status didn't
become STOPPED in 10 attempts");
+semp.release();
+});
+stopThread.start();
+try {
+stopThread.join();
+semp.acquire();
--- End diff --
Add `timeout`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #853: Eagle-923 Integrate role-based Authentication in UI
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/853 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #852: [MINOR] Fix BasicAuthFilter when username/password ...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/852 [MINOR] Fix BasicAuthFilter when username/password is null * Fix BasicAuthFilter when username/password is null * Disable BasicAuthFilter when authentication is disabled. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle FixBasicAuthFilter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/852.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #852 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #851: [MINOR] Add Authorization into Access-Control-Allow...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/851 [MINOR] Add Authorization into Access-Control-Allow-Headers header Add `Authorization` into `Access-Control-Allow-Headers` header: "Access-Control-Allow-Headers": "Origin, Accept, X-Requested-With, Content-Type, Access-Control-Request-Method, Access-Control-Request-Headers, Authorization" You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle FixAuthHeader Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/851.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/795 OK, please move on to merge the PR directly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #848: [EAGLE-932] Support group in stream definition
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/848 [EAGLE-932] Support group in stream definition https://issues.apache.org/jira/browse/EAGLE-932 Support group in stream definition You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle SupportStreamGroup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/848.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #848 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #845: EAGLE-930 UI Notification support
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/845 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #842: [EAGLE-928] Refine system metric schema design and ...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/842#discussion_r103380011
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/environment/builder/ApplicationBuilder.java
---
@@ -1,127 +1,131 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.eagle.app.environment.builder;
-
-
-import backtype.storm.generated.StormTopology;
-import backtype.storm.topology.TopologyBuilder;
-import backtype.storm.tuple.Fields;
-import com.google.common.base.Preconditions;
-import com.typesafe.config.Config;
-import org.apache.eagle.app.environment.impl.StormEnvironment;
-import org.apache.eagle.app.messaging.MetricSchemaGenerator;
-import org.apache.eagle.app.messaging.MetricStreamPersist;
-import org.apache.eagle.app.messaging.StormStreamSource;
-
-import java.util.concurrent.atomic.AtomicInteger;
-
-/**
- * Storm Application Builder DSL.
- */
-public class ApplicationBuilder {
-private final StormEnvironment environment;
-private final Config appConfig;
-private final TopologyBuilder topologyBuilder;
-private final AtomicInteger identifier;
-
-public ApplicationBuilder(Config appConfig, StormEnvironment
environment) {
-this.appConfig = appConfig;
-this.environment = environment;
-this.identifier = new AtomicInteger(0);
-this.topologyBuilder = new TopologyBuilder();
-}
-
-public class BuilderContext {
-public StormTopology toTopology() {
-return topologyBuilder.createTopology();
-}
-}
-
-public abstract class InitializedStream extends BuilderContext {
-private String id;
-
-InitializedStream(String id) {
-Preconditions.checkNotNull(id);
-this.id = id;
-}
-
-String getId() {
-return this.id;
-}
-
-/**
- * Persist source data stream as metric.
- */
-public BuilderContext saveAsMetric(MetricDefinition
metricDefinition) {
-String metricDataID = generateId("MetricDataSink");
-String metricSchemaID = generateId("MetricSchemaGenerator");
-topologyBuilder.setBolt(metricDataID, new
MetricStreamPersist(metricDefinition, appConfig)).shuffleGrouping(getId());
-topologyBuilder.setBolt(metricSchemaID, new
MetricSchemaGenerator(metricDefinition,appConfig)).fieldsGrouping(metricDataID,new
Fields(MetricStreamPersist.METRIC_NAME_FIELD));
-return this;
-}
-
-public TransformedStream transformBy(TransformFunction function) {
-String componentId = generateId(function.getName());
-topologyBuilder.setBolt(componentId, new
TransformFunctionBolt(function)).shuffleGrouping(getId());
-return new TransformedStream(componentId);
-}
-}
-
-public class SourcedStream extends InitializedStream {
-private final Config appConfig;
-private final StormStreamSource streamSource;
-
-private SourcedStream(SourcedStream withSourcedStream) {
-this(withSourcedStream.getId(), withSourcedStream.appConfig,
withSourcedStream.streamSource);
-}
-
-private SourcedStream(String componentId, Config appConfig,
StormStreamSource streamSource) {
-super(componentId);
-this.appConfig = appConfig;
-this.streamSource = streamSource;
-topologyBuilder.setSpout(componentId, streamSource);
-}
-}
-
-public class TransformedStream extends InitializedStream {
-public TransformedStream(String id) {
-super(id);
-throw new IllegalStateException("TODO: Not implemented yet");
-
[GitHub] eagle issue #840: [EAGLE-924]urls to healthy and unhealthy region-servers in...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/840 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #844: [MINOR] support sequence in policy definition
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/844 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #840: [EAGLE-924]urls to healthy and unhealthy region-ser...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/840#discussion_r103176287
--- Diff:
eagle-metric/eagle-hbase-web/src/main/webapp/app/apps/hbase/ctrls/overview.js
---
@@ -59,7 +59,10 @@
$scope.site = $wrapState.param.siteId;
var result = cache[name] ||
activeMasterInfo._promise.then(function (res) {
- var hostname = cache[hostname]
= cache[hostname] || res[0].tags.hostname;
+ if(typeof res[0].tags ===
'undefined') {
--- End diff --
Maybe it possible: `res.length == 0`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #840: [EAGLE-924]urls to healthy and unhealthy region-servers in...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/840 @anyway1021 please confirm about the changes and deploy to QA to validate whether https://issues.apache.org/jira/browse/EAGLE-924 is resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #840: [EAGLE-924]urls to healthy and unhealthy region-servers in...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/840 @zombieJ please help review about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #838: [MINOR] Add kafka log4j appender integration test cases
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/838 @DadanielZ merged, please pull latest code for testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #838: [MINOR] Add kafka log4j appender integration test c...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/838 [MINOR] Add kafka log4j appender integration test cases * Add kafka log4j appender integration test cases `KafkaLog4jAppenderIT` You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle AddKafkaLog4jAppenderIT Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/838.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #838 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #837: [MINOR] Support source_host aside host in metric co...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/837 [MINOR] Support source_host aside host in metric collector Support source_host aside host in metric collector for case when requesting host is not the actual host for reason like network settings. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle patch-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/837.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #837 commit 7a52ce7e59570da58d60947770becbf6081b7243 Author: Hao Chen <ha...@users.noreply.github.com> Date: 2017-02-22T13:57:11Z [MINOR] Support source_host aside host in metric collector --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #836: [EAGLE-908] Hdfs JMX Monitoring Dashboard
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/836 Is this feature finished? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #812: [EAGLE-906] org.apache.storm 1.x with API changes
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/812 Just worry about potential compatibility issue as `kafka` which was refactored a lot recently and here are some tricky dependencies behavior in `storm-kafka` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #831: [EAGLE-918] Support auth annotations PermitAll/DenyAll/Rol...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/831 Merged as Approved by @r7raul1984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #834: EAGLE-902 Add JDBC data storage dependency into eagle serv...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/834 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/795 @DadanielZ is this PR still valid? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #831: [EAGLE-918] Improve eagle auth to support @PermitAll/DenyA...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/831 @r7raul1984 I have finished this PR, please help continue to review. If no more problem, I will merge it after approved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #831: [EAGLE-918] Improve eagle auth to support @PermitAl...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/831#discussion_r102397848
--- Diff:
eagle-server/src/main/java/org/apache/eagle/server/authentication/config/UserAccount.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.server.authentication.config;
+
+import org.apache.eagle.common.authentication.UserPrincipal;
+
+import java.util.List;
+
+public class UserAccount {
+private String username;
+private String password;
+private List roles;
+
+public UserAccount(String username, String password) {
+this.username = username;
+this.password = password;
+}
+
+public String getUsername() {
+return username;
+}
+
+public void setUsername(String username) {
+this.username = username;
+}
+
+public String getPassword() {
+return password;
+}
+
+public void setPassword(String password) {
+this.password = password;
--- End diff --
Resolved with password encryption.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #811: [EAGLE-870] adding required packages into storm-jar
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/811 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #812: [EAGLE-906] org.apache.storm 1.x with API changes
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/812 Have you tested about consuming `kafka:0.8.1` with `storm-kafka:1.0.2` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #825: [EAGLE-900] Only show left navigation item (HDFS, HBase) w...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/825 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #831: [EAGLE-918] Improve eagle auth to support @PermitAll/DenyA...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/831 @zombieJ please move on to refactor eagle login page after this PR merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #831: [EAGLE-918] Improve eagle auth to support @PermitAl...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/831 [EAGLE-918] Improve eagle auth to support @PermitAll/DenyAll/RolesAllowed/Auth and API * Improve eagle auth framework to support annotations under Jersey 1.9 and Dropwizard 0.7.1 ~~~ @PermitAll @DenyAll @RolesAllowed @Auth ~~~ * Add Authentication API ~~~ GET /auth/principal GET /auth/validate GET /auth/login ~~~ You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle EnableAuthAPI Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/831.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #831 commit 5dc42d1ce5d9be74cfa0683bbef57ddcc3e8f1bb Author: Hao Chen <h...@apache.org> Date: 2017-02-20T11:27:38Z Add User.Role commit 753d4bf87f52056ffc1717498bf829bb52517671 Author: Hao Chen <h...@apache.org> Date: 2017-02-21T09:49:01Z Support @RolesAllowed @DenyAll @PermitAll security annoations commit 3e16a20199d9c6af670d30b00dd065835e76a542 Author: Hao Chen <h...@apache.org> Date: 2017-02-21T11:41:54Z Remove VISITOR role commit 30c06cbc8381366e3c1847091f7ad52944b7a705 Author: Hao Chen <h...@apache.org> Date: 2017-02-21T11:42:23Z Clean useless code commit 844a05180deaff666472d74e50ba4cdd2269ebf0 Author: Hao Chen <h...@apache.org> Date: 2017-02-21T15:50:15Z Improve Unit test coverage commit 78d39c58e0956cbebb7e7f20d4469a7c2bd9eb78 Author: Hao Chen <h...@apache.org> Date: 2017-02-21T15:53:13Z Rename package authentication to security --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #822: Eagle-914 UI move alert & policy to site spec
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/822 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #812: [EAGLE-906] org.apache.storm 1.x with API changes
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/812 @jhsenjaliya building failed, could you please check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #816: EAGLE-910 support merge portal
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/816 Will fix the UT exception in #818 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #808: [MINOR] Add hadoop_jmx_metric_${siteId} to support ...
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/808
[MINOR] Add hadoop_jmx_metric_${siteId} to support dynamically changing
topic name
* Add hadoop_jmx_metric_${siteId} to support dynamically changing topic
name according site context
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/eagle SupportTemplatedConfig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #808
commit 7de45b2f2188f1ed092beb69ce2b475cc2005d7e
Author: Hao Chen <h...@apache.org>
Date: 2017-02-16T06:39:17Z
Add hadoop_jmx_metric_
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #806: EAGLE-901 add site filter
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/806 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #796: [EAGLE-888] Application submitted to Storm is always shown...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/796 @wujinhu please help review the PR about app/server config changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #785: EAGLE-876 TopologyBaseAPIEntity comparison should consider...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/785 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #786: [EAGLE-877] Rename metric hadoop.hbase.ipc.ipc.* to...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/786 [EAGLE-877] Rename metric hadoop.hbase.ipc.ipc.* to hadoop.hbase.regionserver.ipc.* Rename metric "hadoop.hbase.ipc.ipc." to "hadoop.hbase.regionserver.ipc." to support different hbase version metrics. https://issues.apache.org/jira/browse/EAGLE-877 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle EAGLE-877 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/786.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #786 commit 439bb368d9291f065d4397935a0b9ca49bb5ec7c Author: Hao Chen <h...@apache.org> Date: 2017-01-19T09:42:35Z Rename metric hadoop.hbase.ipc.ipc.* to hadoop.hbase.regionserver.ipc.* to support different hbase version metric --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #782: [IMPROVEMENT] Using aggregation query in backend instead o...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/782 LGTM, thanks for the contribution @chitin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #780: [EAGLE-863] Refactor Topology Monitoring Widgets
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/780 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #778: [MINOR] Refactor Percentile Chart for Assign, Bulk Assign ...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/778 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #777: [EAGLE-865] correcting logger class for MapRFSAuditLogPars...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/777 LGTM, thanks for the contribution @jhsenjaliya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #779: [EAGLE-869] Fix MetricStreamPersist bug: no tuple p...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/779 [EAGLE-869] Fix MetricStreamPersist bug: no tuple pass on when batchSize > 1 https://issues.apache.org/jira/browse/EAGLE-869 You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle FixMetricStreamPersist Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/779.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #779 commit e2e1791e99dec3830a012810f85a7c4363c1a8b1 Author: Hao Chen <h...@apache.org> Date: 2017-01-16T08:02:40Z Fix MetricStreamPersist bug: no tuple pass on when batchSize > 1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #776: [MINOR] Fix unit test cases
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/776 [MINOR] Fix unit test cases Fix unit test cases in: * `TestGenericEntityServiceResource.java` * `TestResourceUnmarshal.java` You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle FixUT Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #776 commit fc733a4b1339cb5bf11be5cf6737f7bf5bc2bec1 Author: Hao Chen <h...@apache.org> Date: 2017-01-13T11:00:57Z Fix UT commit a01fd43ae1bfaba377d51520525b2c50a6643e89 Author: Hao Chen <h...@apache.org> Date: 2017-01-13T11:01:07Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/eagle into FixUT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #775: [MINOR] Fix license header missing in eagle-jpm-ana...
GitHub user haoch opened a pull request: https://github.com/apache/eagle/pull/775 [MINOR] Fix license header missing in eagle-jpm-analyzer [MINOR] Fix license header missing in eagle-jpm-analyzer You can merge this pull request into a Git repository by running: $ git pull https://github.com/haoch/eagle FixMissingAL Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/775.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #775 commit 6c6c621a69dac8d41a74ffc7846e25eae4c0ee18 Author: Hao Chen <h...@apache.org> Date: 2017-01-13T10:05:51Z [MINOR] Fix license header missing in eagle-jpm-analyzer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #769: [MINOR] Change AlertEagleStorePlugin in sql file
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/769#discussion_r95959975
--- Diff: eagle-server-assembly/src/main/bin/metadata-ddl.sql ---
@@ -134,4 +134,5 @@ INSERT INTO publishment_type(id, content) VALUES
('Kafka',
'{"name":"Kafka","type":"org.apache.eagle.alert.engine.publisher.impl.AlertKafkaPublisher","description":null,"fields":[{"name":"kafka_broker","value":"sandbox.hortonworks.com:6667"},{"name":"topic"}]}'),
('Email',
'{"name":"Email","type":"org.apache.eagle.alert.engine.publisher.impl.AlertEmailPublisher","description":null,"fields":[{"name":"subject"},{"name":"sender"},
{"name":"recipients"}]}'),
('Slack',
'{"name":"Slack","type":"org.apache.eagle.alert.engine.publisher.impl.AlertSlackPublisher","description":null,"fields":[{"name":"token"},{"name":"channels"},
{"name":"severitys"}, {"name":"urltemplate"}]}'),
-('Storage',
'{"name":"Storage","type":"org.apache.eagle.alert.app.AlertEagleStorePlugin","description":null,"fields":[]}');
+('HbaseStorage',
'{"name":"HbaseStorage","type":"org.apache.eagle.alert.app.AlertEagleStorePlugin","description":null,"fields":[]}'),
--- End diff --
"HbaseStorage" -> "HBaseStorage"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #772: [EAGLE-860] TopologyDataExtractor can't extract right rack...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/772 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #765: [EAGLE-851] Add validation for policy name
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/765 But it should be better to add validate in both front-end and backend at same time :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #765: [EAGLE-851] Add validation for policy name
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/765 I think the feature should be added into backend `org.apache.eagle.service.metadata.resource.MetadataResource#validatePolicy()` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #763: [EAGLE-849] Refactor system metric collector script...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/763#discussion_r94724261
--- Diff: eagle-external/hadoop_jmx_collector/system_metric_collector.py ---
@@ -0,0 +1,300 @@
+# !/usr/bin/python
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from metric_collector import MetricCollector, Runner
+import logging, socket, string, os, re, time
+
+
+class SystemMetricCollector(MetricCollector):
+METRIC_PREFIX = "system"
+METRIC_NAME_EXCLUDE = re.compile(r"[\(|\)]")
+
+def run(self):
+self.try_exec_func(
+self.collect_cpu_metric,
+self.collect_uptime_metric,
+self.collect_memory_metric,
+self.collect_loadavg_metric,
+self.collect_ipmi_cpu_temp,
+self.collect_nic_metric,
+self.collect_smartdisk_metric,
+self.collect_diskstat_metric
+)
+
+def try_exec_func(self, *funcs):
+for func in funcs:
+try:
+logging.info("Executing: %s", func.__name__)
+func()
+except Exception as e:
+logging.warn("Failed to execute: %s", func.__name__)
+logging.exception(e)
+
+#
+# CPU Usage
+#
+
+def collect_cpu_metric(self):
+cpu_metric = self.new_metric()
+cpu_info = os.popen('cat /proc/stat').readlines()
+demension = ["cpu", "user", "nice", "system", "idle", "wait",
"irq", "softirq", "steal", "guest"]
+
+total_cpu = 0
+total_cpu_usage = 0
+cpu_stat_pre = None
+
+data_dir = "/tmp/eagle_cpu_stat_previous"
--- End diff --
Resolved as suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #763: [EAGLE-849] Refactor system metric collector script...
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/763#discussion_r94717251
--- Diff: eagle-external/hadoop_jmx_collector/system_metric_collector.py ---
@@ -0,0 +1,300 @@
+# !/usr/bin/python
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from metric_collector import MetricCollector, Runner
+import logging, socket, string, os, re, time
+
+
+class SystemMetricCollector(MetricCollector):
+METRIC_PREFIX = "system"
+METRIC_NAME_EXCLUDE = re.compile(r"[\(|\)]")
+
+def run(self):
+self.try_exec_func(
+self.collect_cpu_metric,
+self.collect_uptime_metric,
+self.collect_memory_metric,
+self.collect_loadavg_metric,
+self.collect_ipmi_cpu_temp,
+self.collect_nic_metric,
+self.collect_smartdisk_metric,
+self.collect_diskstat_metric
+)
+
+def try_exec_func(self, *funcs):
+for func in funcs:
+try:
+logging.info("Executing: %s", func.__name__)
+func()
+except Exception as e:
+logging.warn("Failed to execute: %s", func.__name__)
+logging.exception(e)
+
+#
+# CPU Usage
+#
+
+def collect_cpu_metric(self):
+cpu_metric = self.new_metric()
+cpu_info = os.popen('cat /proc/stat').readlines()
+demension = ["cpu", "user", "nice", "system", "idle", "wait",
"irq", "softirq", "steal", "guest"]
+
+total_cpu = 0
+total_cpu_usage = 0
+cpu_stat_pre = None
+
+data_dir = "/tmp/eagle_cpu_stat_previous"
+if os.path.exists(data_dir):
+fd = open(data_dir, "r")
+cpu_stat_pre = fd.read()
+fd.close()
+
+for item in cpu_info:
+if re.match(r'^cpu\d+', item) is None:
+continue
+
+items = re.split("\s+", item.strip())
+demens = min(len(demension), len(items))
+tuple = dict()
+for i in range(1, demens):
+tuple[demension[i]] = int(items[i])
+cpu_metric['timestamp'] = int(round(time.time() * 1000))
+cpu_metric['metric'] = self.METRIC_PREFIX + "." + 'cpu.' +
demension[i]
+cpu_metric['device'] = items[0]
+cpu_metric['value'] = items[i]
+self.collect(cpu_metric)
+
+per_cpu_usage = tuple["user"] + tuple["nice"] +
tuple["system"] + tuple["wait"] + tuple["irq"] + tuple[
+"softirq"] + tuple["steal"] + tuple["guest"]
+per_cpu_total = tuple["user"] + tuple["nice"] +
tuple["system"] + tuple["idle"] + tuple["wait"] + tuple[
+"irq"] + \
+tuple["softirq"] + tuple["steal"] +
tuple["guest"]
+total_cpu += per_cpu_total
+total_cpu_usage += per_cpu_usage
--- End diff --
Data Source is:
~~~
[root@sandbox hadoop_jmx_collector]# cat /proc/stat
cpu 328118 17 134709 9869983 3745 3100 23742 0 0
cpu0 42170 1 17838 1224218 625 3058 3162 0 0
cpu1 41435 1 16803 1233688 403 4 2772 0 0
cpu2 42173 1 17059 1232358 582 6 2706 0 0
cpu3 40543 1 16920 1234035 471 6 2879 0 0
cpu4 41876 2 16936 1233251 456 6 2816 0 0
cpu5 41248 1 16654 1234433 551 5 2664 0 0
cpu6 41576 1 17046 1233823 335 5 2773 0 0
cpu7 37094 5 15448 1244174 318
[GitHub] eagle issue #753: EAGLE-845 JMX Dashboard
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/753 @chitin hi Lingang, how about the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #757: [MINOR] Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-SNAPSHO...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/757 @jhsenjaliya fixed as well. If no more problem, I will merge the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle pull request #757: [MINOR] Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-...
Github user haoch commented on a diff in the pull request: https://github.com/apache/eagle/pull/757#discussion_r94131957 --- Diff: eagle-core/eagle-alert-parent/eagle-alert-app/pom.xml --- @@ -15,13 +15,12 @@ ~ See the License for the specific language governing permissions and ~ limitations under the License. --> -http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; xmlns="http://maven.apache.org/POM/4.0.0; -xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;> +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> --- End diff -- I changed the `120` limitation to `200` in checkstyle.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] eagle issue #757: [MINOR] Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-SNAPSHO...
Github user haoch commented on the issue: https://github.com/apache/eagle/pull/757 @jhsenjaliya I think i have resolved all "incubating" things, please help review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
