[GitHub] eagle pull request #798: [EAGLE-864] Make sure "HBase" nav active in sidebar...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/eagle/pull/798


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] eagle pull request #798: [EAGLE-864] Make sure "HBase" nav active in sidebar...

2017-02-13 Thread zombieJ
Github user zombieJ commented on a diff in the pull request:

https://github.com/apache/eagle/pull/798#discussion_r100751524
  
--- Diff: eagle-server/src/main/webapp/app/dev/public/js/app.js ---
@@ -324,6 +324,22 @@ var app = {};
});
 
//  Function 

+   // Get parent side bar navigation item class by submenu
+   $scope.getPNavClass = function (subportals) {
--- End diff --

`getPageNavClass` or `getPortalNavClass`? No need abbr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] eagle pull request #798: [EAGLE-864] Make sure "HBase" nav active in sidebar...

2017-02-09 Thread r7raul1984
GitHub user r7raul1984 opened a pull request:

https://github.com/apache/eagle/pull/798

[EAGLE-864] Make sure "HBase" nav active in sidebar when visiting through 
URL

 - When active submenu  then it's parent menu will active also.

https://issues.apache.org/jira/browse/EAGLE-864


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1haodian/eagle EAGLE-864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/eagle/pull/798.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #798


commit ac311d28faeaba268cd1a54c85ef5d015d99131f
Author: r7raul1984 
Date:   2017-02-09T08:24:39Z

[EAGLE-864] Make sure "HBase" nav active in sidebar when visiting hbase 
monitoring web through URL
 - When active submenu  then it's parent menu will active also.

https://issues.apache.org/jira/browse/EAGLE-864




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---