[jira] [Commented] (EAGLE-876) TopologyBaseAPIEntity comparison should consider rack info
[ https://issues.apache.org/jira/browse/EAGLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831179#comment-15831179 ] ASF GitHub Bot commented on EAGLE-876: -- Github user r7raul1984 commented on the issue: https://github.com/apache/eagle/pull/787 @qingwen220 Because ClusterNodeAPITopologyRackResolver use "/default-rack" .I think it will issue some problem when you complete EAGLE-876. > TopologyBaseAPIEntity comparison should consider rack info > -- > > Key: EAGLE-876 > URL: https://issues.apache.org/jira/browse/EAGLE-876 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Zhao, Qingwen >Assignee: Zhao, Qingwen > Fix For: v0.5.0 > > > TopologyBaseAPIEntity comparison should consider rack info -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-876) TopologyBaseAPIEntity comparison should consider rack info
[ https://issues.apache.org/jira/browse/EAGLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831095#comment-15831095 ] ASF GitHub Bot commented on EAGLE-876: -- Github user asfgit closed the pull request at: https://github.com/apache/eagle/pull/785 > TopologyBaseAPIEntity comparison should consider rack info > -- > > Key: EAGLE-876 > URL: https://issues.apache.org/jira/browse/EAGLE-876 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Zhao, Qingwen >Assignee: Zhao, Qingwen > Fix For: v0.5.0 > > > TopologyBaseAPIEntity comparison should consider rack info -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-876) TopologyBaseAPIEntity comparison should consider rack info
[ https://issues.apache.org/jira/browse/EAGLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829930#comment-15829930 ] ASF GitHub Bot commented on EAGLE-876: -- Github user haoch commented on the issue: https://github.com/apache/eagle/pull/785 LGTM > TopologyBaseAPIEntity comparison should consider rack info > -- > > Key: EAGLE-876 > URL: https://issues.apache.org/jira/browse/EAGLE-876 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Zhao, Qingwen >Assignee: Zhao, Qingwen > Fix For: v0.5.0 > > > TopologyBaseAPIEntity comparison should consider rack info -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EAGLE-876) TopologyBaseAPIEntity comparison should consider rack info
[ https://issues.apache.org/jira/browse/EAGLE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829566#comment-15829566 ] ASF GitHub Bot commented on EAGLE-876: -- GitHub user qingwen220 opened a pull request: https://github.com/apache/eagle/pull/785 EAGLE-876 TopologyBaseAPIEntity comparison should consider rack info https://issues.apache.org/jira/browse/EAGLE-876 You can merge this pull request into a Git repository by running: $ git pull https://github.com/qingwen220/incubator-eagle EAGLE-876 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/eagle/pull/785.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #785 commit cb7f41d48081e078b131419a78a3b110856f6867 Author: Zhao, Qingwen Date: 2017-01-19T09:05:41Z Fix persisting key commit 8205d99d075ac1ac90c43072f51f819592cb1d35 Author: Zhao, Qingwen Date: 2017-01-19T09:11:04Z fix conflicts commit 03cfcb139861696160a3c257b090ddb13a2ca89a Author: Zhao, Qingwen Date: 2017-01-19T09:13:05Z Merge branch 'EAGLE-876' of https://github.com/qingwen220/incubator-eagle into EAGLE-876 > TopologyBaseAPIEntity comparison should consider rack info > -- > > Key: EAGLE-876 > URL: https://issues.apache.org/jira/browse/EAGLE-876 > Project: Eagle > Issue Type: Bug >Affects Versions: v0.5.0 >Reporter: Zhao, Qingwen >Assignee: Zhao, Qingwen > Fix For: v0.5.0 > > > TopologyBaseAPIEntity comparison should consider rack info -- This message was sent by Atlassian JIRA (v6.3.4#6332)