[jira] [Closed] (FINERACT-480) Setup is failing due to migration 118.7

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-480.
-

fixed.

> Setup is failing due to migration 118.7
> ---
>
> Key: FINERACT-480
> URL: https://issues.apache.org/jira/browse/FINERACT-480
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Nitin Kumar
>Assignee: Santosh Math
>Priority: Major
>
> Logs :
> Caused by: org.springframework.beans.factory.BeanCreationException: Error 
> creating bean with name 'tenantDatabaseUpgradeService': Invocation of init 
> method failed; nested exception is 
> com.googlecode.flyway.core.api.FlywayException: Migration of schema 
> `mifostenant-default` to version 118.7 failed! Please restore backups and 
> roll back database and code!; for Tenant DB URL: 
> jdbc:mysql:thin://localhost:3306/mifostenant-default, username: root
>   at 
> org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:136)
>   at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInitialization(AbstractAutowireCapableBeanFactory.java:407)
>   at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1546)
>   at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:539)
>   at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:475)
>   at 
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:302)
>   at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:228)
>   at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:298)
>   at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:193)
>   at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:292)
>   at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:193)
>   at 
> org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:328)
>   ... 124 more
> Caused by: com.googlecode.flyway.core.api.FlywayException: Migration of 
> schema `mifostenant-default` to version 118.7 failed! Please restore backups 
> and roll back database and code!; for Tenant DB URL: 
> jdbc:mysql:thin://localhost:3306/mifostenant-default, username: root
>   at 
> org.apache.fineract.infrastructure.core.service.TenantDatabaseUpgradeService.upgradeAllTenants(TenantDatabaseUpgradeService.java:78)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FINERACT-517) "Recalculate Interest for Loans" scheduler job has no effect when partial payment is made with less amount on scheduled date.

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-517.
-

Not an issue. 

> "Recalculate Interest for Loans" scheduler job has no effect when partial 
> payment is made with less amount on scheduled date.
> -
>
> Key: FINERACT-517
> URL: https://issues.apache.org/jira/browse/FINERACT-517
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Santosh Math
>Priority: Major
>  Labels: p1
>
> When there is less repayment is made(Ex;  500 in stead of 1000), it is needed 
> to run the scheduler job but running this scheduler job has no effect and 
> interest is not getting recalculated .
> 1. Create a loan product (Monthly repayment) with Interest Recalculation 
> enabled. (Reduced EMI Amount, no compounding is required)
> 2.  Disburse loan on January 1, 2017 whose first repayment date will be 01 
> February 2017.
> 3.  Consider repayment amount is 800, but you make repayment only 400 on 01 
> February 2017.
> 4. Run Scheduler job "Recalculate Interest for Loans'
> >When you come back to the loan account, you see the same repayment schedule  
> >before running the scheduler job.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FINERACT-588) Bulk Import tool into fineract

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-588.
-

It's done in 1.1.0

> Bulk Import tool into fineract
> --
>
> Key: FINERACT-588
> URL: https://issues.apache.org/jira/browse/FINERACT-588
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FINERACT-682) Renaming stretchy_report parameters conflicting with sql injection

2019-01-09 Thread Shruthi M R (JIRA)


[ 
https://issues.apache.org/jira/browse/FINERACT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739153#comment-16739153
 ] 

Shruthi  M R commented on FINERACT-682:
---

[~vishwasbabu],
 
    Thanks for highlighting issues. Yes, if I rename those parameters it will 
definitely hit the existing hardcoded parameters containing DDL, DML keywords.
 
 ->  parameter names (which are replaced with their corresponding queries by 
fineract and not passed to the database) should only be validated against an 
alphanumeric regex. Is there a need to validate them for containing DDL or DML 
keywords ?  
       - Agreed. And yes I shouldn't have put an extra validation to check 
against DDL and DML keywords against above mentioned cases. I will remove the 
extra validation.

> Renaming stretchy_report parameters conflicting with sql injection
> --
>
> Key: FINERACT-682
> URL: https://issues.apache.org/jira/browse/FINERACT-682
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Shruthi  M R
>Assignee: Shruthi  M R
>Priority: Major
> Fix For: 1.3.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FINERACT-682) Renaming stretchy_report parameters conflicting with sql injection

2019-01-09 Thread Shruthi M R (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shruthi  M R updated FINERACT-682:
--
Issue Type: Bug  (was: Improvement)

> Renaming stretchy_report parameters conflicting with sql injection
> --
>
> Key: FINERACT-682
> URL: https://issues.apache.org/jira/browse/FINERACT-682
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Shruthi  M R
>Assignee: Shruthi  M R
>Priority: Major
> Fix For: 1.3.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FINERACT-433) Transactions done by cashier for one teller is replicating in other teller with same cashier but different time duration.

2019-01-09 Thread Santosh Math (JIRA)


[ 
https://issues.apache.org/jira/browse/FINERACT-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739128#comment-16739128
 ] 

Santosh Math commented on FINERACT-433:
---

Moved this ticket to 1.4.0

> Transactions done by cashier for one teller is replicating in other teller 
> with same cashier but different time duration.
> -
>
> Key: FINERACT-433
> URL: https://issues.apache.org/jira/browse/FINERACT-433
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Organization
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Major
>  Labels: gsoc2017, p2
> Fix For: 1.4.0
>
>
> 1. Create a 'Teller 1' with 'cashier A'  with time duration 9am to 1pm.
> 2. Create another 'Teller 2', with same 'cashier A' and time duration 2pm to 
> 5pm
> 3. Create an user with employee as 'cashier A' with valid credentials and 
> permissions.
> 4. Login with the credentials of the user for  cashier A and do all 
> disbursements and repayments,etc. for the time duration between 9am to 1pm
> >If you check the transactions for Teller 1 and Teller 2, both have same 
> >transactions  though same cashier is assigned with different time duration.
> > The transactions done by cashier for specific teller(say Teller 1) at 
> > specific time duration must be highlighted only to that teller , not in 
> > other teller . 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FINERACT-433) Transactions done by cashier for one teller is replicating in other teller with same cashier but different time duration.

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math updated FINERACT-433:
--
Fix Version/s: (was: 1.1.0)
   1.4.0

> Transactions done by cashier for one teller is replicating in other teller 
> with same cashier but different time duration.
> -
>
> Key: FINERACT-433
> URL: https://issues.apache.org/jira/browse/FINERACT-433
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Organization
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Major
>  Labels: gsoc2017, p2
> Fix For: 1.4.0
>
>
> 1. Create a 'Teller 1' with 'cashier A'  with time duration 9am to 1pm.
> 2. Create another 'Teller 2', with same 'cashier A' and time duration 2pm to 
> 5pm
> 3. Create an user with employee as 'cashier A' with valid credentials and 
> permissions.
> 4. Login with the credentials of the user for  cashier A and do all 
> disbursements and repayments,etc. for the time duration between 9am to 1pm
> >If you check the transactions for Teller 1 and Teller 2, both have same 
> >transactions  though same cashier is assigned with different time duration.
> > The transactions done by cashier for specific teller(say Teller 1) at 
> > specific time duration must be highlighted only to that teller , not in 
> > other teller . 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FINERACT-587) Two factor authentication support

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-587.
-

Fixed. 

> Two factor authentication support
> -
>
> Key: FINERACT-587
> URL: https://issues.apache.org/jira/browse/FINERACT-587
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FINERACT-586) As a user I should be able to add family members to a client

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-586.
-

> As a user I should be able to add family members to a client
> 
>
> Key: FINERACT-586
> URL: https://issues.apache.org/jira/browse/FINERACT-586
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FINERACT-586) As a user I should be able to add family members to a client

2019-01-09 Thread Santosh Math (JIRA)


[ 
https://issues.apache.org/jira/browse/FINERACT-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738975#comment-16738975
 ] 

Santosh Math commented on FINERACT-586:
---

Done with the PR

> As a user I should be able to add family members to a client
> 
>
> Key: FINERACT-586
> URL: https://issues.apache.org/jira/browse/FINERACT-586
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FINERACT-585) Allow predefined SMS messages and Emails to be sent via existing SMS/Email implementations

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-585.
-

> Allow predefined SMS messages and Emails to be sent via existing SMS/Email 
> implementations
> --
>
> Key: FINERACT-585
> URL: https://issues.apache.org/jira/browse/FINERACT-585
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FINERACT-585) Allow predefined SMS messages and Emails to be sent via existing SMS/Email implementations

2019-01-09 Thread Santosh Math (JIRA)


[ 
https://issues.apache.org/jira/browse/FINERACT-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738958#comment-16738958
 ] 

Santosh Math commented on FINERACT-585:
---

Fixed with 1.1.0

> Allow predefined SMS messages and Emails to be sent via existing SMS/Email 
> implementations
> --
>
> Key: FINERACT-585
> URL: https://issues.apache.org/jira/browse/FINERACT-585
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FINERACT-682) Renaming stretchy_report parameters conflicting with sql injection

2019-01-09 Thread Vishwas Babu A J (JIRA)


[ 
https://issues.apache.org/jira/browse/FINERACT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738483#comment-16738483
 ] 

Vishwas Babu A J commented on FINERACT-682:
---

Thanks for explaining the issue Shruthi. If I understand correctly, you are 
planning to rename existing report parameters as they now do not pass 
SQLInjectorValidation. There might be side effects of doing the same
-> A user interface which has hardcoded existing parameter names for embedding 
context specific reports etc would break.
-> Another possible issue would be that users might have already introduced 
other similarly named reporting parameters in their installations and they 
would still continue to break.
 
Can you confirm that these is a need to validate parameter names for containing 
DML and DDL substrings ? I ask since these parameter names are replaced with 
their corresponding queries by fineract while executing them against the 
database, so validating them against an alphanumeric regex should be 
sufficient. If you can confirm that this is right, then the more appropriate 
fix would be to update the validation itself

> Renaming stretchy_report parameters conflicting with sql injection
> --
>
> Key: FINERACT-682
> URL: https://issues.apache.org/jira/browse/FINERACT-682
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shruthi  M R
>Assignee: Shruthi  M R
>Priority: Major
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (FINERACT-682) Renaming stretchy_report parameters conflicting with sql injection

2019-01-09 Thread Vishwas Babu A J (JIRA)


[ 
https://issues.apache.org/jira/browse/FINERACT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738483#comment-16738483
 ] 

Vishwas Babu A J edited comment on FINERACT-682 at 1/9/19 5:51 PM:
---

Thanks for explaining the issue [~Shruthi M R]. If I understand correctly, you 
are planning to rename existing report parameters as they now do not pass 
SQLInjectorValidation. There might be side effects of doing the same
 -> A user interface which has hardcoded existing parameter names for embedding 
context specific reports etc would break.
 -> Another possible issue would be that users might have already introduced 
other similarly named reporting parameters in their installations and they 
would still continue to break.
  
 Can you confirm that these is a need to validate parameter names for 
containing DML and DDL substrings ? I ask since these parameter names are 
replaced with their corresponding queries by fineract while executing them 
against the database, so validating them against an alphanumeric regex should 
be sufficient. If you can confirm that this is right, then the more appropriate 
fix would be to update the validation itself


was (Author: vishwasbabu):
Thanks for explaining the issue Shruthi. If I understand correctly, you are 
planning to rename existing report parameters as they now do not pass 
SQLInjectorValidation. There might be side effects of doing the same
-> A user interface which has hardcoded existing parameter names for embedding 
context specific reports etc would break.
-> Another possible issue would be that users might have already introduced 
other similarly named reporting parameters in their installations and they 
would still continue to break.
 
Can you confirm that these is a need to validate parameter names for containing 
DML and DDL substrings ? I ask since these parameter names are replaced with 
their corresponding queries by fineract while executing them against the 
database, so validating them against an alphanumeric regex should be 
sufficient. If you can confirm that this is right, then the more appropriate 
fix would be to update the validation itself

> Renaming stretchy_report parameters conflicting with sql injection
> --
>
> Key: FINERACT-682
> URL: https://issues.apache.org/jira/browse/FINERACT-682
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shruthi  M R
>Assignee: Shruthi  M R
>Priority: Major
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FINERACT-584) As a user I should be able to configure the credit bureau properties

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-584.
-

Invalid

> As a user I should be able to configure the credit bureau properties 
> -
>
> Key: FINERACT-584
> URL: https://issues.apache.org/jira/browse/FINERACT-584
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FINERACT-583) Notification enhancments

2019-01-09 Thread Santosh Math (JIRA)


 [ 
https://issues.apache.org/jira/browse/FINERACT-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santosh Math closed FINERACT-583.
-

Done. 

> Notification enhancments
> 
>
> Key: FINERACT-583
> URL: https://issues.apache.org/jira/browse/FINERACT-583
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Shaik Nazeer Hussain
>Assignee: Santosh Math
>Priority: Major
> Fix For: 1.1.0
>
>
> app notifications similar to sms notifications



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)