[jira] [Created] (FINCN-131) Invalid link for most GET requests
Evaldas Latoškinas created FINCN-131: Summary: Invalid link for most GET requests Key: FINCN-131 URL: https://issues.apache.org/jira/browse/FINCN-131 Project: Fineract Cloud Native Issue Type: Bug Components: fineract-cn-mobile Environment: Android Studio Emulator (API 28) Reporter: Evaldas Latoškinas Attachments: image-2019-03-02-17-26-30-863.png Most GET requests seem to point to the domain [https://pilot.kuelap.io/,] which cannot be found when opened in web browser. To reproduce, simply start the apache fineract-cn-mobile app and enter the test credentials. Most other functionalities in the mobile app seem to produce the same errors, as they point to the same domain. See attachment for the error message. Error was reproduced in the project [https://github.com/apache/fineract-cn-mobile] , built using the readme instructions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FINCN-111) Fix lint warnings and errors
[ https://issues.apache.org/jira/browse/FINCN-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782445#comment-16782445 ] Evaldas Latoškinas commented on FINCN-111: -- [~therajanmaurya] I would like to take part in this issue by fixing Android & Java related errors. > Fix lint warnings and errors > > > Key: FINCN-111 > URL: https://issues.apache.org/jira/browse/FINCN-111 > Project: Fineract Cloud Native > Issue Type: Task > Components: fineract-cn-mobile > Environment: Ubuntu 18.04.1 > Android Studio 3.2.1 >Reporter: Dundi Raja Vamsi Reddy >Priority: Minor > Labels: error, lint, warning > Attachments: Screenshot from 2019-02-01 00-18-58.png > > > *Summary:* > It is a good practice to keep the codebase free of lint warnings, to make it > more robust, performant, and readable. > *Steps to reproduce:* > Go to Analyze -> Inspect Code... -> select the Whole project > *Expected behavior:* > Minimized number of warnings, leaving only those whose fixation would crash > the app itself. > *Observed behavior:* > Following warnings and errors are present in the codebase: > * Android - 1 errors and 264 warnings > * Groovy - 6 warnings > * Java - 1047 errors > * Kotlin - 23 warnings > * XML - 1 error and many more -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FINERACT-574) Issues related to share Account Creation
[
https://issues.apache.org/jira/browse/FINERACT-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782499#comment-16782499
]
Vishwas Babu A J commented on FINERACT-574:
---
[~Shruthi M R] and [~santoshmath] : Reconfirming that this issue is working as
expected?
1) On
[https://github.com/apache/fineract/commit/3bdfa5abe10f1299104247ae92ec3a6b51fccbe8]
, the credit and debit are for different amounts
2) The integration test "rejectShareAccount" fails. The cause of the failure is
as follows, one of the JSON elements "purchasedShares" retrieved while fetching
a share account is as follows
{code:java}
purchasedShares=[{accountId=15, amount=52.0, amountPaid=50.0,
numberOfShares=25, purchasedDate=[2016, 1, 1], chargeAmount=2.0, id=30,
type={code=purchasedSharesType.purchased, id=500, value=Purchase},
purchasedPrice=2.0, status={code=purchasedSharesStatusType.applied, id=100,
value=Pending Approval}}, {accountId=15, amount=2.0, amountPaid=0,
purchasedDate=[2019, 3, 1], chargeAmount=0, id=31, type={code=charge.payment,
id=700, value=Charge Payment}, status={code=purchasedSharesStatusType.approved,
id=300, value=Approved}}]
{code}
Note that here, for the share purchase the amount is 52 (sum of share amount +
charge) while the amount paid is 50 when the share is in approved state.
When the share moves to rejected state. the JSON element "purchasedShares" now
changes to
{code:java}
[{accountId=15, amount=50.0, amountPaid=50.0, numberOfShares=25,
purchasedDate=[2016, 1, 1], chargeAmount=2.0, id=30,
type={code=purchasedSharesType.purchased, id=500, value=Purchase},
purchasedPrice=2.0, status={code=purchasedSharesStatusType.rejected, id=400,
value=Rejected}}, {accountId=15, amount=2.0, amountPaid=0, purchasedDate=[2019,
3, 1], chargeAmount=0, id=31, type={code=charge.payment, id=700, value=Charge
Payment}, status={code=purchasedSharesStatusType.approved, id=300,
value=Approved}}]
{code}
i.e the amount changes from 50 from 52.
Ideally, the API response should be consistent. If there is a rationale for the
change, please update the Integration test accordingly. For now, this
integration test has been Ignored to ensure that the build does not break
> Issues related to share Account Creation
>
>
> Key: FINERACT-574
> URL: https://issues.apache.org/jira/browse/FINERACT-574
> Project: Apache Fineract
> Issue Type: Bug
> Components: Shares
>Reporter: Santosh Math
>Assignee: Santosh Math
>Priority: Critical
> Labels: gci, gsoc, p1
> Fix For: 1.3.0
>
> Attachments: Screenshot from 2017-12-12 21-05-47.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> 1. Create Share Product with Accounting Enabled
> 2. Create a share charge with type 'Share Purchase' ,'Flat' amount $2.
> 3. Create and activate savings account for client which is needed to link
> with share account
> 4. Create a share Account application for current date using above product
> and charge and number of shares issued as 10 , each share price as $0.5.
> > Once you 'Submit' the share application journal entries are created
> > (including charge) even though share account is not yet approved/activated.
> >Approve the share account and again duplicate jounal entries are created.
> >If share account application is attached with 'Share Activation Fee' , upon
> >submission of share account application, if we check 'Transaction Overview'
> >tab, it shows 'Activation Fee' is received even though share account is not
> >activated. Same is updated in the database
> >table,"m_share_account_charge_paid_by". But under the 'Charges' tab, it
> >shows Outstanding(which is correct).
> The all scenarios can be tested here by modifying application and using the
> charges
> 'Share Purchase Fee' or 'Share Activation Fee'
> https://staging.openmf.org/#/viewshareaccount/5
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FINERACT-574) Issues related to share Account Creation
[ https://issues.apache.org/jira/browse/FINERACT-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782528#comment-16782528 ] Vishwas Babu A J commented on FINERACT-574: --- Also, the behavior of the share functionality looks inconsistent compared with the rest of Fineract. Journal entries are created as soon as the share is purchased (not yet approved) and then reversed when rejected, I would presume that accounting entries should be created only after a share has been approved. But this is an issue for another Jira ticket and would be happy to close this particular ticket if the previous comment is addressed > Issues related to share Account Creation > > > Key: FINERACT-574 > URL: https://issues.apache.org/jira/browse/FINERACT-574 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Santosh Math >Assignee: Santosh Math >Priority: Critical > Labels: gci, gsoc, p1 > Fix For: 1.3.0 > > Attachments: Screenshot from 2017-12-12 21-05-47.png > > Time Spent: 10m > Remaining Estimate: 0h > > 1. Create Share Product with Accounting Enabled > 2. Create a share charge with type 'Share Purchase' ,'Flat' amount $2. > 3. Create and activate savings account for client which is needed to link > with share account > 4. Create a share Account application for current date using above product > and charge and number of shares issued as 10 , each share price as $0.5. > > Once you 'Submit' the share application journal entries are created > > (including charge) even though share account is not yet approved/activated. > >Approve the share account and again duplicate jounal entries are created. > >If share account application is attached with 'Share Activation Fee' , upon > >submission of share account application, if we check 'Transaction Overview' > >tab, it shows 'Activation Fee' is received even though share account is not > >activated. Same is updated in the database > >table,"m_share_account_charge_paid_by". But under the 'Charges' tab, it > >shows Outstanding(which is correct). > The all scenarios can be tested here by modifying application and using the > charges > 'Share Purchase Fee' or 'Share Activation Fee' > https://staging.openmf.org/#/viewshareaccount/5 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (FINERACT-574) Issues related to share Account Creation
[ https://issues.apache.org/jira/browse/FINERACT-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishwas Babu A J reopened FINERACT-574: --- > Issues related to share Account Creation > > > Key: FINERACT-574 > URL: https://issues.apache.org/jira/browse/FINERACT-574 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Santosh Math >Assignee: Santosh Math >Priority: Critical > Labels: gci, gsoc, p1 > Fix For: 1.3.0 > > Attachments: Screenshot from 2017-12-12 21-05-47.png > > Time Spent: 10m > Remaining Estimate: 0h > > 1. Create Share Product with Accounting Enabled > 2. Create a share charge with type 'Share Purchase' ,'Flat' amount $2. > 3. Create and activate savings account for client which is needed to link > with share account > 4. Create a share Account application for current date using above product > and charge and number of shares issued as 10 , each share price as $0.5. > > Once you 'Submit' the share application journal entries are created > > (including charge) even though share account is not yet approved/activated. > >Approve the share account and again duplicate jounal entries are created. > >If share account application is attached with 'Share Activation Fee' , upon > >submission of share account application, if we check 'Transaction Overview' > >tab, it shows 'Activation Fee' is received even though share account is not > >activated. Same is updated in the database > >table,"m_share_account_charge_paid_by". But under the 'Charges' tab, it > >shows Outstanding(which is correct). > The all scenarios can be tested here by modifying application and using the > charges > 'Share Purchase Fee' or 'Share Activation Fee' > https://staging.openmf.org/#/viewshareaccount/5 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (FINERACT-574) Issues related to share Account Creation
[ https://issues.apache.org/jira/browse/FINERACT-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishwas Babu A J reassigned FINERACT-574: - Assignee: Shruthi M R (was: Santosh Math) > Issues related to share Account Creation > > > Key: FINERACT-574 > URL: https://issues.apache.org/jira/browse/FINERACT-574 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Santosh Math >Assignee: Shruthi M R >Priority: Critical > Labels: gci, gsoc, p1 > Fix For: 1.3.0 > > Attachments: Screenshot from 2017-12-12 21-05-47.png > > Time Spent: 10m > Remaining Estimate: 0h > > 1. Create Share Product with Accounting Enabled > 2. Create a share charge with type 'Share Purchase' ,'Flat' amount $2. > 3. Create and activate savings account for client which is needed to link > with share account > 4. Create a share Account application for current date using above product > and charge and number of shares issued as 10 , each share price as $0.5. > > Once you 'Submit' the share application journal entries are created > > (including charge) even though share account is not yet approved/activated. > >Approve the share account and again duplicate jounal entries are created. > >If share account application is attached with 'Share Activation Fee' , upon > >submission of share account application, if we check 'Transaction Overview' > >tab, it shows 'Activation Fee' is received even though share account is not > >activated. Same is updated in the database > >table,"m_share_account_charge_paid_by". But under the 'Charges' tab, it > >shows Outstanding(which is correct). > The all scenarios can be tested here by modifying application and using the > charges > 'Share Purchase Fee' or 'Share Activation Fee' > https://staging.openmf.org/#/viewshareaccount/5 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FINERACT-718) Fix failure with rejectShareAccount Test case
Vishwas Babu A J created FINERACT-718:
-
Summary: Fix failure with rejectShareAccount Test case
Key: FINERACT-718
URL: https://issues.apache.org/jira/browse/FINERACT-718
Project: Apache Fineract
Issue Type: Sub-task
Reporter: Vishwas Babu A J
Test case fails with below error
{code:java}
org.junit.ComparisonFailure: expected:<5[2].0> but was:<5[0].0>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.fineract.integrationtests.common.shares.ShareAccountIntegrationTests.rejectShareAccount(ShareAccountIntegrationTests.java:270)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FINERACT-718) Fix failure with rejectShareAccount Test case
[
https://issues.apache.org/jira/browse/FINERACT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782529#comment-16782529
]
Vishwas Babu A J commented on FINERACT-718:
---
Am commenting out this test case as the underlying cause for failure is
ambiguity around https://issues.apache.org/jira/browse/FINERACT-574 . The same
should be re-enabled once https://issues.apache.org/jira/browse/FINERACT-574 is
closed
> Fix failure with rejectShareAccount Test case
> -
>
> Key: FINERACT-718
> URL: https://issues.apache.org/jira/browse/FINERACT-718
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Vishwas Babu A J
>Priority: Major
>
> Test case fails with below error
>
> {code:java}
> org.junit.ComparisonFailure: expected:<5[2].0> but was:<5[0].0>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.fineract.integrationtests.common.shares.ShareAccountIntegrationTests.rejectShareAccount(ShareAccountIntegrationTests.java:270)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (FINERACT-719) Fix test cases around loan and savings Import
Vishwas Babu A J created FINERACT-719: - Summary: Fix test cases around loan and savings Import Key: FINERACT-719 URL: https://issues.apache.org/jira/browse/FINERACT-719 Project: Apache Fineract Issue Type: Sub-task Reporter: Vishwas Babu A J The following test cases are currently failing and have been Ignored for the time being as they are related to functionality which (I believe) is not widely used LoanImportHandlerTest. testLoanImport SavingsImportHandlerTest. testSavingsImport There is an open pull request at [https://github.com/apache/fineract/pull/444] which possible fixes some of these failing test. However, we are waiting for feedback on the same to be incorporated before it can be merged -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FINERACT-719) Fix test cases around loan and savings Import
[ https://issues.apache.org/jira/browse/FINERACT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishwas Babu A J updated FINERACT-719: -- Labels: gsoc2019 (was: ) > Fix test cases around loan and savings Import > - > > Key: FINERACT-719 > URL: https://issues.apache.org/jira/browse/FINERACT-719 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > > The following test cases are currently failing and have been Ignored for the > time being as they are related to functionality which (I believe) is not > widely used > LoanImportHandlerTest. testLoanImport > SavingsImportHandlerTest. testSavingsImport > There is an open pull request at > [https://github.com/apache/fineract/pull/444] which possible fixes some of > these failing test. However, we are waiting for feedback on the same to be > incorporated before it can be merged > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FINERACT-707) Fix failing integration test cases
[ https://issues.apache.org/jira/browse/FINERACT-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishwas Babu A J updated FINERACT-707: -- Affects Version/s: (was: 1.2.0) 1.3.0 > Fix failing integration test cases > -- > > Key: FINERACT-707 > URL: https://issues.apache.org/jira/browse/FINERACT-707 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.3.0 >Reporter: Vishwas Babu A J >Assignee: Vishwas Babu A J >Priority: Blocker > Fix For: 1.3.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > More than 10 Integration tests are currently failing on Fineract. The same > needs to be fixed before a new release can be shipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FINERACT-719) Fix test cases around loan and savings Import
[ https://issues.apache.org/jira/browse/FINERACT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishwas Babu A J updated FINERACT-719: -- Description: The following test cases are currently failing and have been Ignored for the time being as they are related to functionality which (I believe) is not widely used LoanImportHandlerTest. testLoanImport SavingsImportHandlerTest. testSavingsImport There is an open pull request at [https://github.com/apache/fineract/pull/444] which possible fixes some of these failing test. However, we are waiting for feedback on the same to be incorporated before it can be merged. was: The following test cases are currently failing and have been Ignored for the time being as they are related to functionality which (I believe) is not widely used LoanImportHandlerTest. testLoanImport SavingsImportHandlerTest. testSavingsImport There is an open pull request at [https://github.com/apache/fineract/pull/444] which possible fixes some of these failing test. However, we are waiting for feedback on the same to be incorporated before it can be merged > Fix test cases around loan and savings Import > - > > Key: FINERACT-719 > URL: https://issues.apache.org/jira/browse/FINERACT-719 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > > The following test cases are currently failing and have been Ignored for the > time being as they are related to functionality which (I believe) is not > widely used > LoanImportHandlerTest. testLoanImport > SavingsImportHandlerTest. testSavingsImport > There is an open pull request at > [https://github.com/apache/fineract/pull/444] which possible fixes some of > these failing test. However, we are waiting for feedback on the same to be > incorporated before it can be merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FINERACT-719) Fix test cases around loan and savings Import
[ https://issues.apache.org/jira/browse/FINERACT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vishwas Babu A J updated FINERACT-719: -- Affects Version/s: 1.3.0 1.2.0 > Fix test cases around loan and savings Import > - > > Key: FINERACT-719 > URL: https://issues.apache.org/jira/browse/FINERACT-719 > Project: Apache Fineract > Issue Type: Sub-task >Affects Versions: 1.2.0, 1.3.0 >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > > The following test cases are currently failing and have been Ignored for the > time being as they are related to functionality which (I believe) is not > widely used > LoanImportHandlerTest. testLoanImport > SavingsImportHandlerTest. testSavingsImport > There is an open pull request at > [https://github.com/apache/fineract/pull/444] which possible fixes some of > these failing test. However, we are waiting for feedback on the same to be > incorporated before it can be merged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
