[jira] [Resolved] (FINERACT-796) Use Hikari instead of Tomcat Connection Pool

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger resolved FINERACT-796.

Resolution: Fixed

> Use Hikari instead of Tomcat Connection Pool
> 
>
> Key: FINERACT-796
> URL: https://issues.apache.org/jira/browse/FINERACT-796
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
> Fix For: 1.4.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In [https://github.com/apache/fineract/pull/642] for FINERACT-724, ivan333m 
> said:
> {quote}New version of spring-boot-starter-data-jpa uses HikariCP as default 
> connection pool instead of tomcat-jdbc. So I need to add this dependency. 
> Also I have excluded HikariCP in the latest commit.{quote}
> Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc 
> default to HikariCP, and that e.g. 
> https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database
>  explicitly states:
> {quote}We prefer HikariCP for its performance and concurrency. If HikariCP is 
> available, we always choose it. Otherwise, if the Tomcat pooling DataSource 
> is available, we use it.{quote}
> I think we should eventually replace our use of the Tomcat JDBC Connection 
> Pool with Hikari.
> I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a 
> pre-req. to it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-797) Use Spring Boot BOM to avoid maintaining version numbers in dependencies.gradle

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-797:
--

Assignee: Yemdjih Kaze Nasser

> Use Spring Boot BOM to avoid maintaining version numbers in 
> dependencies.gradle
> ---
>
> Key: FINERACT-797
> URL: https://issues.apache.org/jira/browse/FINERACT-797
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
> Fix For: 1.4.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/fineract/pull/642 for FINERACT-724, ivan333m and 
> I discussed:
> {quote}In an ideal world, in a future PR, it would be really really cool if 
> we could just avoid having to repeat using fixed version, and could use the 
> implicit versions via Spring BOM dependency management, see 
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#managing-dependencies
>  ...{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-796) Use Hikari instead of Tomcat Connection Pool

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-796:
--

Assignee: Yemdjih Kaze Nasser  (was: Michael Vorburger)

> Use Hikari instead of Tomcat Connection Pool
> 
>
> Key: FINERACT-796
> URL: https://issues.apache.org/jira/browse/FINERACT-796
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
> Fix For: 1.4.0
>
>
> In [https://github.com/apache/fineract/pull/642] for FINERACT-724, ivan333m 
> said:
> {quote}New version of spring-boot-starter-data-jpa uses HikariCP as default 
> connection pool instead of tomcat-jdbc. So I need to add this dependency. 
> Also I have excluded HikariCP in the latest commit.{quote}
> Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc 
> default to HikariCP, and that e.g. 
> https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database
>  explicitly states:
> {quote}We prefer HikariCP for its performance and concurrency. If HikariCP is 
> available, we always choose it. Otherwise, if the Tomcat pooling DataSource 
> is available, we use it.{quote}
> I think we should eventually replace our use of the Tomcat JDBC Connection 
> Pool with Hikari.
> I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a 
> pre-req. to it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-696) use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-696:
--

Assignee: Yemdjih Kaze Nasser  (was: Michael Vorburger)

> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> ---
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Build
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
>  Labels: beginner, starter
> Fix For: 1.4.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
>  While code reviewing [https://github.com/apache/fineract/pull/464], I came 
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it 
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but 
> just an automated build failure. This is possible using SpotBugs (not 
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible 
> successor)  and [https://github.com/KengoTODA/findbugs-slf4j/] (for this 
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but 
> using findbugs-slf4j for Fineract would have value even before that's 
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just 
> waiting to have issues to working on (I'm joking) - so I was wondering if 
> perhaps you knew of anyone who would be willing to work on this one?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-696) use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

2020-03-28 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069947#comment-17069947
 ] 

Michael Vorburger commented on FINERACT-696:


> I've tried assigning myself to issues but it does not work. Not sure why that 
> happens.

You were missing the Contributor role in JIRA; I've just fixed that, now you 
can assign issues.

This issue was implemented in [https://github.com/apache/fineract/pull/716,] so 
closing it as Resolved (delivered) for 1.4.0.

> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> ---
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Build
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>  Labels: beginner, starter
> Fix For: 1.4.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
>  While code reviewing [https://github.com/apache/fineract/pull/464], I came 
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it 
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but 
> just an automated build failure. This is possible using SpotBugs (not 
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible 
> successor)  and [https://github.com/KengoTODA/findbugs-slf4j/] (for this 
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but 
> using findbugs-slf4j for Fineract would have value even before that's 
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just 
> waiting to have issues to working on (I'm joking) - so I was wondering if 
> perhaps you knew of anyone who would be willing to work on this one?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-696) use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-696:
--

Assignee: Michael Vorburger  (was: Yemdjih Kaze Nasser)

> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> ---
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Build
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>  Labels: beginner, starter
> Fix For: 1.4.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
>  While code reviewing [https://github.com/apache/fineract/pull/464], I came 
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it 
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but 
> just an automated build failure. This is possible using SpotBugs (not 
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible 
> successor)  and [https://github.com/KengoTODA/findbugs-slf4j/] (for this 
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but 
> using findbugs-slf4j for Fineract would have value even before that's 
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just 
> waiting to have issues to working on (I'm joking) - so I was wondering if 
> perhaps you knew of anyone who would be willing to work on this one?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-696) use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-696:
--

Assignee: Yemdjih Kaze Nasser

> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> ---
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Build
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
>  Labels: beginner, starter
> Fix For: 1.4.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
>  While code reviewing [https://github.com/apache/fineract/pull/464], I came 
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it 
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but 
> just an automated build failure. This is possible using SpotBugs (not 
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible 
> successor)  and [https://github.com/KengoTODA/findbugs-slf4j/] (for this 
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but 
> using findbugs-slf4j for Fineract would have value even before that's 
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just 
> waiting to have issues to working on (I'm joking) - so I was wondering if 
> perhaps you knew of anyone who would be willing to work on this one?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (FINERACT-696) use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger resolved FINERACT-696.

Resolution: Fixed

> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> ---
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Build
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>  Labels: beginner, starter
> Fix For: 1.4.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
>  While code reviewing [https://github.com/apache/fineract/pull/464], I came 
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it 
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but 
> just an automated build failure. This is possible using SpotBugs (not 
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible 
> successor)  and [https://github.com/KengoTODA/findbugs-slf4j/] (for this 
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but 
> using findbugs-slf4j for Fineract would have value even before that's 
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just 
> waiting to have issues to working on (I'm joking) - so I was wondering if 
> perhaps you knew of anyone who would be willing to work on this one?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-696) use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger updated FINERACT-696:
---
Fix Version/s: 1.4.0

> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> ---
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Build
>Reporter: Michael Vorburger
>Priority: Major
>  Labels: beginner, starter
> Fix For: 1.4.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
>  While code reviewing [https://github.com/apache/fineract/pull/464], I came 
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it 
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but 
> just an automated build failure. This is possible using SpotBugs (not 
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible 
> successor)  and [https://github.com/KengoTODA/findbugs-slf4j/] (for this 
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but 
> using findbugs-slf4j for Fineract would have value even before that's 
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just 
> waiting to have issues to working on (I'm joking) - so I was wondering if 
> perhaps you knew of anyone who would be willing to work on this one?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time

2020-03-28 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069475#comment-17069475
 ] 

Michael Vorburger commented on FINERACT-713:


To anyone reading along here ntoe that first sub-task FINERACT-725 to add 
Jacoco is now done.

> Improve code-coverage to at-least 50% and reduce execution time
> ---
>
> Key: FINERACT-713
> URL: https://issues.apache.org/jira/browse/FINERACT-713
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Vishwas Babu A J
>Priority: Major
>  Labels: gsoc2019
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> While Fineract has integration tests, they currently cover very limited 
> scenarios and code coverage is very low.
> Enable gradle plugins to report the current code coverage and add new 
> Integration tests to ensure that code coverage, esp in critical packages like 
> loans, savings, and accounting is at-least 50%. Once the packages with low 
> code coverage have been identified, we could take the help of [~santoshmath] 
> to collect manual test cases covering these packages and go about automating 
> the same.
> Also, the existing tests are run sequentially and take around 23 minutes to 
> complete on [https://travis-ci.org/apache/fineract.] Along with improving 
> code coverage, we would also have to determine which tests can be run in 
> parallel and enable parallelization to ensure the total time taken is still 
> reasonable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-725) Measure current code coverage

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-725:
--

Assignee: Manthan Surkar  (was: Michael Vorburger)

> Measure current code coverage
> -
>
> Key: FINERACT-725
> URL: https://issues.apache.org/jira/browse/FINERACT-725
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Vishwas Babu A J
>Assignee: Manthan Surkar
>Priority: Major
>
> Integrate a plugin like 
> [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate 
> the code coverage report for running integration tests on Fineract.
> Using this report, we can quickly determine which package have low code 
> coverage and work on remediating the same



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-725) Measure current code coverage

2020-03-28 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069474#comment-17069474
 ] 

Michael Vorburger commented on FINERACT-725:


[~Manthan] ĥas made another great contribution and pretty much already done 
this in [https://github.com/apache/fineract/pull/742] !

> Measure current code coverage
> -
>
> Key: FINERACT-725
> URL: https://issues.apache.org/jira/browse/FINERACT-725
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Vishwas Babu A J
>Assignee: Manthan Surkar
>Priority: Major
>
> Integrate a plugin like 
> [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate 
> the code coverage report for running integration tests on Fineract.
> Using this report, we can quickly determine which package have low code 
> coverage and work on remediating the same



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-725) Measure current code coverage

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-725:
--

Assignee: Michael Vorburger  (was: Manthan Surkar)

> Measure current code coverage
> -
>
> Key: FINERACT-725
> URL: https://issues.apache.org/jira/browse/FINERACT-725
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Vishwas Babu A J
>Assignee: Michael Vorburger
>Priority: Major
>
> Integrate a plugin like 
> [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate 
> the code coverage report for running integration tests on Fineract.
> Using this report, we can quickly determine which package have low code 
> coverage and work on remediating the same



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-725) Measure current code coverage

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-725:
--

Assignee: Michael Vorburger

> Measure current code coverage
> -
>
> Key: FINERACT-725
> URL: https://issues.apache.org/jira/browse/FINERACT-725
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Vishwas Babu A J
>Assignee: Michael Vorburger
>Priority: Major
>
> Integrate a plugin like 
> [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate 
> the code coverage report for running integration tests on Fineract.
> Using this report, we can quickly determine which package have low code 
> coverage and work on remediating the same



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-725) Measure current code coverage

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-725:
--

Assignee: Manthan Surkar  (was: Michael Vorburger)

> Measure current code coverage
> -
>
> Key: FINERACT-725
> URL: https://issues.apache.org/jira/browse/FINERACT-725
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Vishwas Babu A J
>Assignee: Manthan Surkar
>Priority: Major
>
> Integrate a plugin like 
> [https://docs.gradle.org/current/userguide/jacoco_plugin.html] and generate 
> the code coverage report for running integration tests on Fineract.
> Using this report, we can quickly determine which package have low code 
> coverage and work on remediating the same



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-796) Use Hikari instead of Tomcat Connection Pool

2020-03-28 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069466#comment-17069466
 ] 

Michael Vorburger commented on FINERACT-796:


https://github.com/apache/fineract/pull/746

> Use Hikari instead of Tomcat Connection Pool
> 
>
> Key: FINERACT-796
> URL: https://issues.apache.org/jira/browse/FINERACT-796
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.4.0
>
>
> In [https://github.com/apache/fineract/pull/642] for FINERACT-724, ivan333m 
> said:
> {quote}New version of spring-boot-starter-data-jpa uses HikariCP as default 
> connection pool instead of tomcat-jdbc. So I need to add this dependency. 
> Also I have excluded HikariCP in the latest commit.{quote}
> Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc 
> default to HikariCP, and that e.g. 
> https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database
>  explicitly states:
> {quote}We prefer HikariCP for its performance and concurrency. If HikariCP is 
> available, we always choose it. Otherwise, if the Tomcat pooling DataSource 
> is available, we use it.{quote}
> I think we should eventually replace our use of the Tomcat JDBC Connection 
> Pool with Hikari.
> I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a 
> pre-req. to it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-796) Use Hikari instead of Tomcat Connection Pool

2020-03-28 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger updated FINERACT-796:
---
Fix Version/s: 1.4.0

> Use Hikari instead of Tomcat Connection Pool
> 
>
> Key: FINERACT-796
> URL: https://issues.apache.org/jira/browse/FINERACT-796
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.4.0
>
>
> In [https://github.com/apache/fineract/pull/642] for FINERACT-724, ivan333m 
> said:
> {quote}New version of spring-boot-starter-data-jpa uses HikariCP as default 
> connection pool instead of tomcat-jdbc. So I need to add this dependency. 
> Also I have excluded HikariCP in the latest commit.{quote}
> Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc 
> default to HikariCP, and that e.g. 
> https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database
>  explicitly states:
> {quote}We prefer HikariCP for its performance and concurrency. If HikariCP is 
> available, we always choose it. Otherwise, if the Tomcat pooling DataSource 
> is available, we use it.{quote}
> I think we should eventually replace our use of the Tomcat JDBC Connection 
> Pool with Hikari.
> I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a 
> pre-req. to it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-866) Improve Robustness of Mifos X and Apache Fineract by Fixing Issues/Feature Requests in Backlog

2020-03-28 Thread Percy Ashu (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069289#comment-17069289
 ] 

Percy Ashu commented on FINERACT-866:
-

Hello [~sanyam96] I have written a draft proposal for this project to The 
Apache Foundation please can you review it and provide comments .

> Improve Robustness of Mifos X and Apache Fineract by Fixing Issues/Feature 
> Requests in Backlog
> --
>
> Key: FINERACT-866
> URL: https://issues.apache.org/jira/browse/FINERACT-866
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Sanyam Goel
>Priority: Major
>  Labels: fineract, gsoc, gsoc2020
>
> |*Overview & Objectives*
> Mifos X and Apache Fineract is widely used by financial institutions of all 
> different sizes and methodologies around the world. With that widespread user 
> base there is a vast array of different processes and procedures that would 
> like to be supported as slight modifications over the common functionality 
> provided. Over the past several years, we have captured these minor 
> enhancements in our issue tracker as feature requests. Also included in this 
> backlog or additional minor and less critical bugs that have been reported 
> but have not been fixed yet.  This backlog has grown and it would be a very 
> impactful project for an intern to work on completing as many of these bug 
> fixes and minor enhancement as possible.
>  The difficult level of these issues ranges from low to higher and touch all 
> componets of the platform - most don't require too much domain knowledge but 
> some will. |
> |*Description*
> We have groomed the backlog and tagged issues and feature requests that are 
> relevant for this project with the labels gsoc and/or Volunteer.  Priority 
> level of tasks is measured by p1 being the highest priority. Tasks with an 
> assigned fix version of either 1.4.0 or 1.5.0 have a higher priority. 
>  There are more than 120 tickets in the saved filter. You are not expected to 
> complete all of the tasks in the backlog but throughout the internship you 
> should fix as many issues/feature requests as possible. You will work with 
> your mentor to deliver a plan for each sprint and adjust velocity as you get 
> scaled up.
>  Issues to be worked on can be found at 
> [https://issues.apache.org/jira/issues/?filter=12345785] - the saved filter 
> is named *2019 Intern Project.* |
> |*Helpful Skills:*
> *HTML, Spring, Hibernate, REST, Java, AngularJS, Javascript, SQL*|
> |*Impact:*
> Better internal control and financial transparency|
> |*Other Resources:*
> Getting Started with Apache Fineract: 
> [https://cwiki.apache.org/confluence/display/FINERACT/Getting+Started+Docs]|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)