[jira] [Commented] (FINERACT-1049) Shares account delete gives 405

2020-06-23 Thread Karan (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143343#comment-17143343
 ] 

Karan commented on FINERACT-1049:
-

[~vorburger] Thanks for the quick and thorough response, I think there should 
be an option to delete a shares account firstly there is a frontend option in 
community app to do so secondly there are similar close/delete options for 
loans/savings accounts. Close is used on active accounts (green ones) whereas 
delete is used on 'pending for approval' applications (yellow ones).  
!screenshot(7).png!!screenshot(8).png!

> Shares account delete gives 405
> ---
>
> Key: FINERACT-1049
> URL: https://issues.apache.org/jira/browse/FINERACT-1049
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Karan
>Priority: Minor
>  Labels: beginner
> Attachments: Screenshot from 2020-06-23 16-27-59.png, 
> screenshot(7).png, screenshot(8).png
>
>
> Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-1049) Shares account delete gives 405

2020-06-23 Thread Karan (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karan updated FINERACT-1049:

Attachment: screenshot(7).png
screenshot(8).png

> Shares account delete gives 405
> ---
>
> Key: FINERACT-1049
> URL: https://issues.apache.org/jira/browse/FINERACT-1049
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Karan
>Priority: Minor
>  Labels: beginner
> Attachments: Screenshot from 2020-06-23 16-27-59.png, 
> screenshot(7).png, screenshot(8).png
>
>
> Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1054) Error at Loan Repayments

2020-06-23 Thread Francis Guchie (Jira)
Francis Guchie created FINERACT-1054:


 Summary: Error at Loan Repayments
 Key: FINERACT-1054
 URL: https://issues.apache.org/jira/browse/FINERACT-1054
 Project: Apache Fineract
  Issue Type: Bug
  Components: Loan
Affects Versions: 1.5.0
Reporter: Francis Guchie



GET 
https:///fineract-provider/api/v1/loans/3/transactions/template?command=repayment

timestamp   1592952834187
status  500
error   "Internal Server Error"
message "PreparedStatementCallback; bad SQL grammar [select 
if(max(tr.transaction_date)>ls.dueDate,max(tr.transaction_date),ls.dueDate) as 
transactionDate,ls.principal_amount - IFNULL(ls.principal_writtenoff_derived,0) 
- IFNULL(ls.principal_completed_derived,0) as principalDue,ls.interest_amount - 
IFNULL(ls.interest_completed_derived,0) - IFNULL(ls.interest_waived_derived,0) 
- IFNULL(ls.interest_writtenoff_derived,0) as interestDue,ls.fee_charges_amount 
- IFNULL(ls.fee_charges_completed_derived,0) - IFNULL(ls.fee_c…N ls.loan_id = 
l.id AND ls.completed_derived = 0 join( (select min(ls.duedate) 
datedue,ls.loan_id from m_loan_repayment_schedule ls where ls.loan_id = ? and 
ls.completed_derived = 0) )asq on asq.loan_id = ls.loan_id and asq.datedue = 
ls.duedate where l.id =?]; nested exception is 
java.sql.SQLSyntaxErrorException: In aggregated query without GROUP BY, 
expression #2 of SELECT list contains nonaggregated column 
'fineract_default.ls.principal_amount'; this is incompatible with 
sql_mode=only_full_group_by"

path"/fineract-provider/api/v1/loans/3/transactions/template"





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1053) Custom Account number length - Global Setting

2020-06-23 Thread Francis Guchie (Jira)
Francis Guchie created FINERACT-1053:


 Summary: Custom Account number length - Global Setting
 Key: FINERACT-1053
 URL: https://issues.apache.org/jira/browse/FINERACT-1053
 Project: Apache Fineract
  Issue Type: Improvement
  Components: Client, Groups, Loan, Savings, Shares
Affects Versions: 1.3.0, 1.2.0, 1.4.0, 1.5.0
Reporter: Francis Guchie
 Attachments: Custom account number length.jpg

Impacted versions:
all versions of MifosX

Steps to reproduce:
Do any of the following, 
  Register a client or group
  Create a Savings, Recurring or fixed deposit
  Create a Loan

Current behavior:
By default the account numbers are 9 digits

Expected behavior:
In a digital banking environment, an account number should have 18 Characters, 
10 of which is the actual account number of the client. So having 10 digits for 
account numbers will be a good standard 


This could be set in the global settings of mifosX



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1052) Over Payment of loans is Allowed by Default

2020-06-23 Thread Francis Guchie (Jira)
Francis Guchie created FINERACT-1052:


 Summary: Over Payment of loans is Allowed by Default 
 Key: FINERACT-1052
 URL: https://issues.apache.org/jira/browse/FINERACT-1052
 Project: Apache Fineract
  Issue Type: New Feature
  Components: Loan
Affects Versions: 1.3.0, 1.4.0, 1.5.0
Reporter: Francis Guchie
 Fix For: 1.5.0
 Attachments: Config - Disable Loan Over Payment.jpg

Impacted versions: all MifosX versions including latest build

Steps to reproduce:
Select any loan in MifosX and make a payment over and above the dues

Current behavior:
MifosX will accept this

Expected behavior:
We create a global setting where its optional for super user to set allow or 
restrict users from over paying loans -- This can be done at global 
configurations => 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1049) Shares account delete gives 405

2020-06-23 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143299#comment-17143299
 ] 

Michael Vorburger commented on FINERACT-1049:
-

[~karantakalkar] actually, looking at 
https://demo.fineract.dev/fineract-provider/api-docs/apiLive.htm#shareaccount_close
 I'm pretty sure now that it was not just forgotten, and that full deleting is 
intentionally not available - why not just use that API to _Close a share 
account?_

> Shares account delete gives 405
> ---
>
> Key: FINERACT-1049
> URL: https://issues.apache.org/jira/browse/FINERACT-1049
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Karan
>Priority: Minor
>  Labels: beginner
> Attachments: Screenshot from 2020-06-23 16-27-59.png
>
>
> Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-1049) Shares account delete gives 405

2020-06-23 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger updated FINERACT-1049:

Labels: beginner  (was: )

> Shares account delete gives 405
> ---
>
> Key: FINERACT-1049
> URL: https://issues.apache.org/jira/browse/FINERACT-1049
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Karan
>Priority: Minor
>  Labels: beginner
> Attachments: Screenshot from 2020-06-23 16-27-59.png
>
>
> Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-921) Upgrade Jersey library from 1.x to 2.30.1 or later

2020-06-23 Thread Natasha Natarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Natasha Natarajan reassigned FINERACT-921:
--

Assignee: (was: Natasha Natarajan)

> Upgrade Jersey library from 1.x to 2.30.1 or later
> --
>
> Key: FINERACT-921
> URL: https://issues.apache.org/jira/browse/FINERACT-921
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
>
> https://eclipse-ee4j.github.io/jersey/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FINERACT-921) Upgrade Jersey library from 1.x to 2.30.1 or later

2020-06-23 Thread Natasha Natarajan (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143253#comment-17143253
 ] 

Natasha Natarajan edited comment on FINERACT-921 at 6/23/20, 7:53 PM:
--

[~vorburger]  The latest stable release is 2.31. 

Looking at the 
[documentation|https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/index.html],
 this appears to be an involved, longer term project. 

Each previous release is included in the migration guide, requiring several 
changes for each individual release, some involving breaking changes (2.0, 2.2, 
2.3, 2.4, 2.4.1, 2.5, 2.5.1, 2.6, 2.7, 2.8, 2.9, 2.10, 2.11, 2.15, 2.16, 2.17, 
2.18, 2.19, 2.21, 2.22, 2.22.1, 2.23).

 


was (Author: natashan):
[~vorburger]  The latest stable release is 2.31. 

Looking at the 
[documentation|https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/index.html],
 this appears to an involved, longer term project. 

Each previous release is included in the migration guide, requiring changes for 
each individual release,  some involving breaking changes (2.0, 2.2, 2.3, 2.4, 
2.4.1, 2.5, 2.5.1, 2.6, 2.7, 2.8, 2.9, 2.10, 2.11, 2.15, 2.16, 2.17, 2.18, 
2.19, 2.21, 2.22, 2.22.1, 2.23).

 

> Upgrade Jersey library from 1.x to 2.30.1 or later
> --
>
> Key: FINERACT-921
> URL: https://issues.apache.org/jira/browse/FINERACT-921
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Natasha Natarajan
>Priority: Major
>
> https://eclipse-ee4j.github.io/jersey/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-921) Upgrade Jersey library from 1.x to 2.30.1 or later

2020-06-23 Thread Natasha Natarajan (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143253#comment-17143253
 ] 

Natasha Natarajan commented on FINERACT-921:


[~vorburger]  The latest stable release is 2.31. 

Looking at the 
[documentation|https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/index.html],
 this appears to an involved, longer term project. 

Each previous release is included in the migration guide, requiring changes for 
each individual release,  some involving breaking changes (2.0, 2.2, 2.3, 2.4, 
2.4.1, 2.5, 2.5.1, 2.6, 2.7, 2.8, 2.9, 2.10, 2.11, 2.15, 2.16, 2.17, 2.18, 
2.19, 2.21, 2.22, 2.22.1, 2.23).

 

> Upgrade Jersey library from 1.x to 2.30.1 or later
> --
>
> Key: FINERACT-921
> URL: https://issues.apache.org/jira/browse/FINERACT-921
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Natasha Natarajan
>Priority: Major
>
> https://eclipse-ee4j.github.io/jersey/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1001) Enable and Enforce PMD on Fineract

2020-06-23 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143239#comment-17143239
 ] 

Michael Vorburger commented on FINERACT-1001:
-

[~awasum] nope, because I have not used PMD myself in projects in my previous 
lifes... :P but I have used Checkstyle and SpotBugs and Error Prone. I'm 
personally not entirely sure how much additional value PMD adds to the project, 
now that we have made great progress with CS, SB and EP. 

Perhaps what could be interesting would be to have a closer look at your 
attached main.html report, and over 
https://pmd.github.io/pmd-6.24.0/pmd_rules_java.html ... I suspect completely 
addressing each and every one of all 19575 rule violations is not going to be 
possible in a reasonable amount of time - but perhaps there are a few "high 
value" ones we can pick? Or decide it's "not worth it at all". I only had a 
very quick look over the main.html, and didn't really see anything there *yet* 
that made me think like "oh wow yes that sounds like a real bug, glad it caught 
that". One that I liked, which I don't think CS/SB/EP caught, is "Using 
equalsIgnoreCase() is cleaner than using 
toUpperCase/toLowerCase().equals()."... that's a good one. But that alone, if 
we don't find other good catches, perhaps doesn't justify the introduction of a 
4th code quality control tool?

Most other ones seems to be much more "style" than "bug" (or raises things 
which I suspect our recent CS/SB/EP work meanwhile already addressed). But it's 
kind of hard to read, because it's "by occurrence" instead of "by kind of 
problem" - if it's possible to customize the reporting, perhaps that would make 
it easier to analyze and discuss what (if anything at all...) could be "worth 
it".

One thing I'm curious about is how much extra build time overhead adding the 
latest version of PMD adds, now that we have the latest Gradle. It's something 
to keep in mind, because I remember having raised 
https://github.com/apache/fineract/pull/612 because it was really slowing the 
build down. [~Percy Ashu] I'm curious if re-adding PMD now adds just like an 
extra 10% or xN like 300% or so to a "./gradle clean build" - do you want to 
try?

Something else I feel quite strongly about is that just having a PR which 
re-adds PMD and prints a lot of warnings (as it originally used to) doesn't 
really help the project. Only a more fine grained approach of suppressing 
warnings, and gradually re-enabling any "high-value" ones, step by step in PRs 
which actually fix violations, and then enforce those (by failing the build if 
there are regression), like we did for CS, SB and EP, really makes sense. I 
don't even know if that's possible with PMD configuration.. if not, perhaps we 
shouldn't adopt it. Let's find out!

> Enable and Enforce PMD on Fineract
> --
>
> Key: FINERACT-1001
> URL: https://issues.apache.org/jira/browse/FINERACT-1001
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Awasum Yannick
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: main.html
>
>
> Enable and Enforce PMD ( [https://pmd.github.io/ )|https://pmd.github.io/] on 
> Fineract. Make PMD fail until violations are fixed just like we do for 
> Spotbug, checkstyle etc. See previous work here:
> [https://github.com/apache/fineract/pull/295]
> See where PMD was commented out because it was not use: 
> [https://github.com/apache/fineract/pull/612]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1048) SchedulerJob executeAndAwait predicate returns false with successful transaction

2020-06-23 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143227#comment-17143227
 ] 

Michael Vorburger commented on FINERACT-1048:
-

> Schedularjob acting crazy again. Time execution time comparison is faulty in 
> tests.

[~kaze] I'm not entirely sure what this mean, would you like elaborate more 
what you mean by this, what error and how to reproduce? Only with EclipseLink, 
or even with OpenJPA?

> SchedulerJob executeAndAwait predicate returns false with successful 
> transaction
> 
>
> Key: FINERACT-1048
> URL: https://issues.apache.org/jira/browse/FINERACT-1048
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Priority: Major
>
> Schedularjob acting crazy again. Time execution time comparison is faulty in 
> tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINCN-231) Implementation of FCM Notifications in FineractCN

2020-06-23 Thread Garvit Agarwal (Jira)


 [ 
https://issues.apache.org/jira/browse/FINCN-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Garvit Agarwal updated FINCN-231:
-
Description: 
Currently, the Notification system for FineractCN can only generate an email or 
an SMS regarding the changes related to the user's information. There are no 
API Endpoints which can be used to fetch these notifications. Presently, there 
is no support for FCM for FineractCN.

Now it is desired to support push notifications using FCM. There is no 
implementation for generating notifications at the backend side for the 
payments of a loan, so there is a need to make changes in the back-office app, 
fineract-cn-mobile.

  was:
Currently, the Notification system for FineractCN can only generate an email or 
an SMS regarding the changes related to the user's information. There are no 
API Endpoints which can be used to fetch these notifications. Presently, there 
is no support for FCM for FineractCN.

Now it is desired to support push notifications. There is no implementation for 
generating notifications at the backend side for the payments of a loan, so 
there is a need to make changes in the back-office app, fineract-cn-mobile.


> Implementation of FCM Notifications in FineractCN
> -
>
> Key: FINCN-231
> URL: https://issues.apache.org/jira/browse/FINCN-231
> Project: Fineract Cloud Native
>  Issue Type: Improvement
>  Components: fineract-cn-notifications
>Reporter: Garvit Agarwal
>Priority: Critical
>
> Currently, the Notification system for FineractCN can only generate an email 
> or an SMS regarding the changes related to the user's information. There are 
> no API Endpoints which can be used to fetch these notifications. Presently, 
> there is no support for FCM for FineractCN.
> Now it is desired to support push notifications using FCM. There is no 
> implementation for generating notifications at the backend side for the 
> payments of a loan, so there is a need to make changes in the back-office 
> app, fineract-cn-mobile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINCN-231) Implementation of FCM Notifications in FineractCN

2020-06-23 Thread Garvit Agarwal (Jira)
Garvit Agarwal created FINCN-231:


 Summary: Implementation of FCM Notifications in FineractCN
 Key: FINCN-231
 URL: https://issues.apache.org/jira/browse/FINCN-231
 Project: Fineract Cloud Native
  Issue Type: Improvement
  Components: fineract-cn-notifications
Reporter: Garvit Agarwal


Currently, the Notification system for FineractCN can only generate an email or 
an SMS regarding the changes related to the user's information. There are no 
API Endpoints which can be used to fetch these notifications. Presently, there 
is no support for FCM for FineractCN.

Now it is desired to support push notifications. There is no implementation for 
generating notifications at the backend side for the payments of a loan, so 
there is a need to make changes in the back-office app, fineract-cn-mobile.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-1050) loan_repayment_schedule_id column contraint errors

2020-06-23 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser updated FINERACT-1050:
--
Summary: loan_repayment_schedule_id column contraint errors  (was: Failing 
ClientLoanIntegrationTest)

> loan_repayment_schedule_id column contraint errors
> --
>
> Key: FINERACT-1050
> URL: https://issues.apache.org/jira/browse/FINERACT-1050
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Priority: Major
>
> Dupicate value for column loan_repayment_schedule_id. I think the entity 
> relationship around this column are messed up. I don't know how they manage 
> to work till now but eclipselink doesn't seem to agree with it.
> {code:java}
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.7.7.v20200504-69f2c2b80d): 
> org.eclipse.persistence.exceptions.DatabaseException\nInternal Exception: 
> java.sql.SQLIntegrityConstraintViolationException: Column 
> 'loan_repayment_schedule_id' cannot be null\nError Code: 1048\nCall: INSERT 
> INTO m_loan_transaction_repayment_schedule_mapping (loan_transaction_id, ID, 
> amount, fee_charges_portion_derived, interest_portion_derived, 
> penalty_charges_portion_derived, principal_portion_derived, 
> loan_repayment_schedule_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?)\n\tbind => [5022, 
> null, 412.00, null, 12.00, null, 400.00, null]\nQuery: 
> ValueReadQuery(name=\"SEQ_GEN_IDENTITY\" sql=\"SELECT LAST_INSERT_ID()\"); 
> nested exception is javax.persistence.PersistenceException: Exception 
> [EclipseLink-4002] (Eclipse Persistence Services - 
> 2.7.7.v20200504-69f2c2b80d): 
> org.eclipse.persistence.exceptions.DatabaseException\nInternal Exception: 
> java.sql.SQLIntegrityConstraintViolationException: Column 
> 'loan_repayment_schedule_id' cannot be null\nError Code: 1048\nCall: INSERT 
> INTO m_loan_transaction_repayment_schedule_mapping (loan_transaction_id, ID, 
> amount, fee_charges_portion_derived, interest_portion_derived, 
> penalty_charges_portion_derived, principal_portion_derived, 
> loan_repayment_schedule_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?)\n\tbind => [5022, 
> null, 412.00, null, 12.00, null, 400.00, null]\nQuery: 
> ValueReadQuery(name=\"SEQ_GEN_IDENTITY\" sql=\"SELECT 
> LAST_INSERT_ID()\")","path":"/fineract-provider/api/v1/loans/1113"}"
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-1050) Failing ClientLoanIntegrationTest

2020-06-23 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser updated FINERACT-1050:
--
Description: 
Dupicate value for column loan_repayment_schedule_id. I think the entity 
relationship around this column are messed up. I don't know how they manage to 
work till now but eclipselink doesn't seem to agree with it.
{code:java}
Exception [EclipseLink-4002] (Eclipse Persistence Services - 
2.7.7.v20200504-69f2c2b80d): 
org.eclipse.persistence.exceptions.DatabaseException\nInternal Exception: 
java.sql.SQLIntegrityConstraintViolationException: Column 
'loan_repayment_schedule_id' cannot be null\nError Code: 1048\nCall: INSERT 
INTO m_loan_transaction_repayment_schedule_mapping (loan_transaction_id, ID, 
amount, fee_charges_portion_derived, interest_portion_derived, 
penalty_charges_portion_derived, principal_portion_derived, 
loan_repayment_schedule_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?)\n\tbind => [5022, 
null, 412.00, null, 12.00, null, 400.00, null]\nQuery: 
ValueReadQuery(name=\"SEQ_GEN_IDENTITY\" sql=\"SELECT LAST_INSERT_ID()\"); 
nested exception is javax.persistence.PersistenceException: Exception 
[EclipseLink-4002] (Eclipse Persistence Services - 2.7.7.v20200504-69f2c2b80d): 
org.eclipse.persistence.exceptions.DatabaseException\nInternal Exception: 
java.sql.SQLIntegrityConstraintViolationException: Column 
'loan_repayment_schedule_id' cannot be null\nError Code: 1048\nCall: INSERT 
INTO m_loan_transaction_repayment_schedule_mapping (loan_transaction_id, ID, 
amount, fee_charges_portion_derived, interest_portion_derived, 
penalty_charges_portion_derived, principal_portion_derived, 
loan_repayment_schedule_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?)\n\tbind => [5022, 
null, 412.00, null, 12.00, null, 400.00, null]\nQuery: 
ValueReadQuery(name=\"SEQ_GEN_IDENTITY\" sql=\"SELECT 
LAST_INSERT_ID()\")","path":"/fineract-provider/api/v1/loans/1113"}"
{code}

  was:
Dupicate value for column loan_repayment_schedule_id. I think the entity 
relationship around this column are messed up. I don't know how they manage to 
work till now but eclipselink doesn't seem to agree with it.
{code:java}
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <500>.

at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
 Method)
at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
at 
org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
at 
org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
at 
org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:277)
at 
io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure.validate(ResponseSpecificationImpl.groovy:493)
at 
io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure$validate$1.call(Unknown
 Source)
at 
io.restassured.internal.RequestSpecificationImpl.applyPathParamsAndSendRequest(RequestSpecificationImpl.groovy:1656)
at jdk.internal.reflect.GeneratedMethodAccessor85.invoke(Unknown Source)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:107)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1262)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1029)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:816)
at groovy.lang.GroovyObject.invokeMethod(GroovyObject.java:39)
at 
org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.call(PogoInterceptableSite.java:45)
at 
org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.callCurrent(PogoInterceptableSite.java:55)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:203)
at 
io.restassured.internal.RequestSpecificationImpl.applyPathParamsAndSendRequest(RequestSpecificationImpl.groovy:1661)
at jdk.internal.reflect.GeneratedMethodAccessor84.invoke(Unknown Source)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at 

[jira] [Updated] (FINERACT-1050) Failing ClientLoanIntegrationTest

2020-06-23 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser updated FINERACT-1050:
--
Description: 
Dupicate value for column loan_repayment_schedule_id. I think the entity 
relationship around this column are messed up. I don't know how they manage to 
work till now but eclipselink doesn't seem to agree with it.
{code:java}
java.lang.AssertionError: 1 expectation failed.
Expected status code <200> but was <500>.

at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
 Method)
at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
at 
org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
at 
org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:59)
at 
org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:277)
at 
io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure.validate(ResponseSpecificationImpl.groovy:493)
at 
io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure$validate$1.call(Unknown
 Source)
at 
io.restassured.internal.RequestSpecificationImpl.applyPathParamsAndSendRequest(RequestSpecificationImpl.groovy:1656)
at jdk.internal.reflect.GeneratedMethodAccessor85.invoke(Unknown Source)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:107)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1262)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1029)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:816)
at groovy.lang.GroovyObject.invokeMethod(GroovyObject.java:39)
at 
org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.call(PogoInterceptableSite.java:45)
at 
org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.callCurrent(PogoInterceptableSite.java:55)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:203)
at 
io.restassured.internal.RequestSpecificationImpl.applyPathParamsAndSendRequest(RequestSpecificationImpl.groovy:1661)
at jdk.internal.reflect.GeneratedMethodAccessor84.invoke(Unknown Source)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:107)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1262)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1029)
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:816)
at groovy.lang.GroovyObject.invokeMethod(GroovyObject.java:39)
at 
org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.call(PogoInterceptableSite.java:45)
at 
org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.callCurrent(PogoInterceptableSite.java:55)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:203)
at 
io.restassured.internal.RequestSpecificationImpl.post(RequestSpecificationImpl.groovy:175)
at 
io.restassured.internal.RequestSpecificationImpl.post(RequestSpecificationImpl.groovy)
at 
org.apache.fineract.integrationtests.common.Utils.performServerPost(Utils.java:154)
at 
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.performLoanTransaction(LoanTransactionHelper.java:590)
at 
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.forecloseLoan(LoanTransactionHelper.java:296)
at 
org.apache.fineract.integrationtests.ClientLoanIntegrationTest.testLoanForeclosure(ClientLoanIntegrationTest.java:4999)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 

[jira] [Updated] (FINERACT-1051) Failing RecurringDepositTest

2020-06-23 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser updated FINERACT-1051:
--
Affects Version/s: 1.4.0

> Failing RecurringDepositTest 
> -
>
> Key: FINERACT-1051
> URL: https://issues.apache.org/jira/browse/FINERACT-1051
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Priority: Major
>
> {code:java}
> org.opentest4j.AssertionFailedError: Verifying Pre-Closure maturity amount 
> ==> expected: <4014.0> but was: <4002.0>
>   at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
>   at 
> org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
>   at 
> org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
>   at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:787)
>   at 
> org.apache.fineract.integrationtests.RecurringDepositTest.testPrematureClosureAmountWithPenalInterestForWholeTerm_With_360_Days(RecurringDepositTest.java:1859)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:675)
>   at 
> org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
>   at 
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:125)
>   at 
> org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:132)
>   at 
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:124)
>   at 
> org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:74)
>   at 
> org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
>   at 
> org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
>   at 
> org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:104)
>   at 
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:62)
>   at 
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:43)
>   at 
> org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:35)
>   at 
> org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
>   at 
> org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
>   at 
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:202)
>   at 
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
>   at 
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:198)
>   at 
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
>   at 
> org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:69)
>   at 
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
>   at 
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
>   at 
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
>   at 
> org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
>   at 
> org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
>   at 
> org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
>   at 
> org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
>   at 
> org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
>   at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)
>   at 
> 

[jira] [Updated] (FINERACT-1048) SchedulerJob executeAndAwait predicate returns false with successful transaction

2020-06-23 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser updated FINERACT-1048:
--
Affects Version/s: 1.4.0

> SchedulerJob executeAndAwait predicate returns false with successful 
> transaction
> 
>
> Key: FINERACT-1048
> URL: https://issues.apache.org/jira/browse/FINERACT-1048
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Priority: Major
>
> Schedularjob acting crazy again. Time execution time comparison is faulty in 
> tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1051) Failing RecurringDepositTest

2020-06-23 Thread Yemdjih Kaze Nasser (Jira)
Yemdjih Kaze Nasser created FINERACT-1051:
-

 Summary: Failing RecurringDepositTest 
 Key: FINERACT-1051
 URL: https://issues.apache.org/jira/browse/FINERACT-1051
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Yemdjih Kaze Nasser


{code:java}
org.opentest4j.AssertionFailedError: Verifying Pre-Closure maturity amount ==> 
expected: <4014.0> but was: <4002.0>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at 
org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
at 
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:787)
at 
org.apache.fineract.integrationtests.RecurringDepositTest.testPrematureClosureAmountWithPenalInterestForWholeTerm_With_360_Days(RecurringDepositTest.java:1859)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:675)
at 
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:125)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:132)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:124)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:74)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:104)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:62)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:43)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:35)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:202)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:198)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:69)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)
at 
org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 

[jira] [Created] (FINERACT-1050) Failing ClientLoanIntegrationTest

2020-06-23 Thread Yemdjih Kaze Nasser (Jira)
Yemdjih Kaze Nasser created FINERACT-1050:
-

 Summary: Failing ClientLoanIntegrationTest
 Key: FINERACT-1050
 URL: https://issues.apache.org/jira/browse/FINERACT-1050
 Project: Apache Fineract
  Issue Type: Bug
Affects Versions: 1.4.0
Reporter: Yemdjih Kaze Nasser


Dupicate value for column loan_repayment_schedule_id. I think the entity 
relationship around this column are messed up. I don't know how they manage to 
work till now but eclipselink doesn't seem to agree with it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1049) Shares account delete gives 405

2020-06-23 Thread Karan (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142839#comment-17142839
 ] 

Karan commented on FINERACT-1049:
-

Hi all, this is my first issue here, have I opened it at the right place? are 
there any conventions I must follow?

 

> Shares account delete gives 405
> ---
>
> Key: FINERACT-1049
> URL: https://issues.apache.org/jira/browse/FINERACT-1049
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Karan
>Priority: Minor
> Attachments: Screenshot from 2020-06-23 16-27-59.png
>
>
> Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1049) Shares account delete gives 405

2020-06-23 Thread Karan (Jira)
Karan created FINERACT-1049:
---

 Summary: Shares account delete gives 405
 Key: FINERACT-1049
 URL: https://issues.apache.org/jira/browse/FINERACT-1049
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Karan
 Attachments: Screenshot from 2020-06-23 16-27-59.png

Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)