[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1

2020-06-26 Thread Yemdjih Kaze Nasser (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146530#comment-17146530
 ] 

Yemdjih Kaze Nasser commented on FINERACT-1022:
---

Thanks [~ptuomola] for going ahead and dealing with this. That's really awesome.

> Update ehcache: 2.10.6 to current 3.8.1
> ---
>
> Key: FINERACT-1022
> URL: https://issues.apache.org/jira/browse/FINERACT-1022
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> Update artifactory and version number



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146499#comment-17146499
 ] 

Michael Vorburger commented on FINERACT-1022:
-

[~ptuomola] cool! Thanks, you're awesome... :D re. above, one could imagine 
have a Logback appender with a ring buffer keeping recent error logs, and a 
REST API to check if any... but that's a bit out there, and probably not really 
"worth it" today, for this project - we've got bigger fish to fry here? ;) 
Still just wanted to throw this out.

[~kaze] would you like to review and (manually, I guess?) test 
https://github.com/apache/fineract/pull/1115 about this, and merge it if it's 
OK for you, and then close this issue?

> Update ehcache: 2.10.6 to current 3.8.1
> ---
>
> Key: FINERACT-1022
> URL: https://issues.apache.org/jira/browse/FINERACT-1022
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> Update artifactory and version number



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1055) Update Gradle from v6.1 to v6.3+

2020-06-26 Thread Natasha Natarajan (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146450#comment-17146450
 ] 

Natasha Natarajan commented on FINERACT-1055:
-

>From our conversation, Gradle version 6.5 on project, will research IntelliJ.

> Update Gradle from v6.1 to v6.3+ 
> -
>
> Key: FINERACT-1055
> URL: https://issues.apache.org/jira/browse/FINERACT-1055
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Natasha Natarajan
>Priority: Minor
> Fix For: 1.4.0
>
>
> Prerequisite for 
> [FINERACT-1023|https://issues.apache.org/jira/browse/FINERACT-1023]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FINERACT-1055) Update Gradle from v6.1 to v6.3+

2020-06-26 Thread Natasha Natarajan (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146293#comment-17146293
 ] 

Natasha Natarajan edited comment on FINERACT-1055 at 6/26/20, 1:35 PM:
---

[~vorburger], It is then strange that when running the project, yesterday, the 
error message within IntelliJ indicated that the project is running on Gradle 
6.1. See the error message below:

 

A problem occurred evaluating root project 'fineract-provider'.
 > Failed to apply plugin [id 'org.springframework.boot']
 > Spring Boot plugin requires Gradle 5 (5.6.x only) or Gradle 6 (6.3 or 
 > later). The current version is Gradle 6.1

 

 


was (Author: natashan):
[~vorburger], It is then strange that when running the project, yesterday, the 
error message within IntelliJ indicate that the project in running on Gradle 
6.1. See my error message indicated below:

 

A problem occurred evaluating root project 'fineract-provider'.
> Failed to apply plugin [id 'org.springframework.boot']
 > Spring Boot plugin requires Gradle 5 (5.6.x only) or Gradle 6 (6.3 or 
 > later). The current version is Gradle 6.1

 

 

> Update Gradle from v6.1 to v6.3+ 
> -
>
> Key: FINERACT-1055
> URL: https://issues.apache.org/jira/browse/FINERACT-1055
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Natasha Natarajan
>Priority: Minor
> Fix For: 1.4.0
>
>
> Prerequisite for 
> [FINERACT-1023|https://issues.apache.org/jira/browse/FINERACT-1023]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FINERACT-1056) Update Jetty to v9.4.22+

2020-06-26 Thread Natasha Natarajan (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Natasha Natarajan closed FINERACT-1056.
---
Resolution: Invalid

> Update Jetty to v9.4.22+
> 
>
> Key: FINERACT-1056
> URL: https://issues.apache.org/jira/browse/FINERACT-1056
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Natasha Natarajan
>Priority: Minor
> Fix For: 1.4.0
>
>
> Prerequisite for FINERACT-1023



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1056) Update Jetty to v9.4.22+

2020-06-26 Thread Natasha Natarajan (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146305#comment-17146305
 ] 

Natasha Natarajan commented on FINERACT-1056:
-

[~vorburger], Thank you for this feedback! I thought that had found an 
indication of Jetty in the project, but now it makes sense to why their 
documentation would not work.

> Update Jetty to v9.4.22+
> 
>
> Key: FINERACT-1056
> URL: https://issues.apache.org/jira/browse/FINERACT-1056
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Natasha Natarajan
>Priority: Minor
> Fix For: 1.4.0
>
>
> Prerequisite for FINERACT-1023



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1

2020-06-26 Thread Petri Tuomola (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146282#comment-17146282
 ] 

Petri Tuomola commented on FINERACT-1022:
-

I've sent a PR that should fix this - looks like it required changes to a 
number of configuration files and also to dependencies. 

Also checked on the integrationTests for this: there's a test that turns on 
caching and turns it off. Unfortunately from client side it's not easy to see 
if that actually has had any effect. I've added a log error message to log if 
cache is turned on which has not been populated/configured - so going forward 
we should at least see an error in the logs. Ideally of course would be good to 
have the test fail if the cache is not configured / working - but not sure how 
to best achieve this from client side...

> Update ehcache: 2.10.6 to current 3.8.1
> ---
>
> Key: FINERACT-1022
> URL: https://issues.apache.org/jira/browse/FINERACT-1022
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> Update artifactory and version number



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1

2020-06-26 Thread Petri Tuomola (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146282#comment-17146282
 ] 

Petri Tuomola edited comment on FINERACT-1022 at 6/26/20, 1:14 PM:
---

[~vorburger] I've sent a PR that should fix this - looks like it required 
changes to a number of configuration files and also to dependencies. 

Also checked on the integrationTests for this: there's a test that turns on 
caching and turns it off. Unfortunately from client side it's not easy to see 
if that actually has had any effect. I've added a log error message to log if 
cache is turned on which has not been populated/configured - so going forward 
we should at least see an error in the logs. Ideally of course would be good to 
have the test fail if the cache is not configured / working - but not sure how 
to best achieve this from client side...


was (Author: ptuomola):
I've sent a PR that should fix this - looks like it required changes to a 
number of configuration files and also to dependencies. 

Also checked on the integrationTests for this: there's a test that turns on 
caching and turns it off. Unfortunately from client side it's not easy to see 
if that actually has had any effect. I've added a log error message to log if 
cache is turned on which has not been populated/configured - so going forward 
we should at least see an error in the logs. Ideally of course would be good to 
have the test fail if the cache is not configured / working - but not sure how 
to best achieve this from client side...

> Update ehcache: 2.10.6 to current 3.8.1
> ---
>
> Key: FINERACT-1022
> URL: https://issues.apache.org/jira/browse/FINERACT-1022
> Project: Apache Fineract
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> Update artifactory and version number



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-962) Use Renovate for Fineract

2020-06-26 Thread Rhys Arkins (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146237#comment-17146237
 ] 

Rhys Arkins commented on FINERACT-962:
--

Sorry, I missed the previous comment. The default app limit is 20 concurrent 
PRs so unlikely to be hitting that.

> Use  Renovate for Fineract
> --
>
> Key: FINERACT-962
> URL: https://issues.apache.org/jira/browse/FINERACT-962
> Project: Apache Fineract
>  Issue Type: Sub-task
>  Components: Build
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>  Labels: dependencies, tech-debt, technical
> Fix For: 1.4.0
>
>
> https://renovate.whitesourcesoftware.com
> Based solely on comparing the initial list on 
> https://github.com/vorburger/fineract/pull/2 VS 
> https://github.com/vorburger/fineract/pulls?q=is%3Apr+author%3Aapp%2Fdependabot-preview+,
>  Renovate and Dependabot seem to find similar results. It could still be fun 
> to run them both?
> INFRA-19586 explains that ASF can't accept the Renovate GitHub App.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-962) Use Renovate for Fineract

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146235#comment-17146235
 ] 

Michael Vorburger commented on FINERACT-962:


To answer myself, it looks like we keep getting new PRs, so nothing is being 
"held back". With that, this is "fully done" and we're "in production" with 
Renovate.

> Use  Renovate for Fineract
> --
>
> Key: FINERACT-962
> URL: https://issues.apache.org/jira/browse/FINERACT-962
> Project: Apache Fineract
>  Issue Type: Sub-task
>  Components: Build
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>  Labels: dependencies, tech-debt, technical
> Fix For: 1.4.0
>
>
> https://renovate.whitesourcesoftware.com
> Based solely on comparing the initial list on 
> https://github.com/vorburger/fineract/pull/2 VS 
> https://github.com/vorburger/fineract/pulls?q=is%3Apr+author%3Aapp%2Fdependabot-preview+,
>  Renovate and Dependabot seem to find similar results. It could still be fun 
> to run them both?
> INFRA-19586 explains that ASF can't accept the Renovate GitHub App.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-462) Need an option to filter provisioning entries by date

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146230#comment-17146230
 ] 

Michael Vorburger commented on FINERACT-462:


https://github.com/apache/fineract/pull/1113

> Need an option to filter provisioning entries by date
> -
>
> Key: FINERACT-462
> URL: https://issues.apache.org/jira/browse/FINERACT-462
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Santosh Math
>Priority: Major
>  Labels: 2019-mifos-gsoc, Volunteer, gsoc, p2
>
> Go to Accounting>Provisioning  Entries 
> There is no option to filter provisioning entries by date. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1023) Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146226#comment-17146226
 ] 

Michael Vorburger commented on FINERACT-1023:
-

please see my answers in sub-tasks FINERACT-1055 and FINERACT-1056.

> Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE
> -
>
> Key: FINERACT-1023
> URL: https://issues.apache.org/jira/browse/FINERACT-1023
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Awasum Yannick
>Priority: Minor
> Fix For: 1.4.0
>
>
> Renovate tried to upgrade to Spring Boot 2.3: 
> [https://github.com/apache/fineract/pull/998]
> This failed as shown here: 
> [https://travis-ci.org/github/apache/fineract/builds/695663148]
> Looks like validation dependency is missing in the new release. We have to 
> upgrade manually by adding it? 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1056) Update Jetty to v9.4.22+

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146224#comment-17146224
 ] 

Michael Vorburger commented on FINERACT-1056:
-

Apache Fineract currently does not use Jetty, but Tomcat. An "upgrade" does 
makes no sense and should not be required as a prerequisite for FINERACT-1023.


> Update Jetty to v9.4.22+
> 
>
> Key: FINERACT-1056
> URL: https://issues.apache.org/jira/browse/FINERACT-1056
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Natasha Natarajan
>Priority: Minor
> Fix For: 1.4.0
>
>
> Prerequisite for FINERACT-1023



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1055) Update Gradle from v6.1 to v6.3+

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146223#comment-17146223
 ] 

Michael Vorburger commented on FINERACT-1055:
-

[~natashan] we are already using Gradle 6.5... ;) see 
https://github.com/apache/fineract/blob/develop/fineract-provider/gradle/wrapper/gradle-wrapper.properties

> Update Gradle from v6.1 to v6.3+ 
> -
>
> Key: FINERACT-1055
> URL: https://issues.apache.org/jira/browse/FINERACT-1055
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Natasha Natarajan
>Priority: Minor
> Fix For: 1.4.0
>
>
> Prerequisite for 
> [FINERACT-1023|https://issues.apache.org/jira/browse/FINERACT-1023]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1047) Integration tests for audit trails

2020-06-26 Thread Manthan Surkar (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146221#comment-17146221
 ] 

Manthan Surkar commented on FINERACT-1047:
--

More to come! It seems like we were typing the comment at the same time. :P

> Integration tests for audit trails
> --
>
> Key: FINERACT-1047
> URL: https://issues.apache.org/jira/browse/FINERACT-1047
> Project: Apache Fineract
>  Issue Type: Test
>Reporter: Manthan Surkar
>Assignee: Manthan Surkar
>Priority: Major
> Fix For: 1.4.0
>
>
> Related to FINERACT-799



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1047) Integration tests for audit trails

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146218#comment-17146218
 ] 

Michael Vorburger commented on FINERACT-1047:
-

[~Manthan] close this, or more to come?

> Integration tests for audit trails
> --
>
> Key: FINERACT-1047
> URL: https://issues.apache.org/jira/browse/FINERACT-1047
> Project: Apache Fineract
>  Issue Type: Test
>Reporter: Manthan Surkar
>Assignee: Manthan Surkar
>Priority: Major
> Fix For: 1.4.0
>
>
> Related to FINERACT-799



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1047) Integration tests for audit trails

2020-06-26 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-1047:
---

Assignee: Manthan Surkar  (was: Michael Vorburger)

> Integration tests for audit trails
> --
>
> Key: FINERACT-1047
> URL: https://issues.apache.org/jira/browse/FINERACT-1047
> Project: Apache Fineract
>  Issue Type: Test
>Reporter: Manthan Surkar
>Assignee: Manthan Surkar
>Priority: Major
> Fix For: 1.4.0
>
>
> Related to FINERACT-799



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-1047) Integration tests for audit trails

2020-06-26 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger updated FINERACT-1047:

Fix Version/s: 1.4.0

> Integration tests for audit trails
> --
>
> Key: FINERACT-1047
> URL: https://issues.apache.org/jira/browse/FINERACT-1047
> Project: Apache Fineract
>  Issue Type: Test
>Reporter: Manthan Surkar
>Assignee: Manthan Surkar
>Priority: Major
> Fix For: 1.4.0
>
>
> Related to FINERACT-799



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1047) Integration tests for audit trails

2020-06-26 Thread Manthan Surkar (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146219#comment-17146219
 ] 

Manthan Surkar commented on FINERACT-1047:
--

[~vorburger] 
Can you please guide me on the following doubts:
1. To test each operation like limit, sortBy, orderBY it is expected to have 
some audits. The audits are already created(And verified) In the creation test. 
Am I expected to use the same audits(by somehow making that test run first) or 
to create new audits again? 
2. For OrderBy -> The route OrderBy="somethingnotallowed" gives a error and 
OrderBy="somethingallowed" gives a 200, in this case, am I expected to check if 
the received data is in order or just verifying that the code is 200 would 
work. 

> Integration tests for audit trails
> --
>
> Key: FINERACT-1047
> URL: https://issues.apache.org/jira/browse/FINERACT-1047
> Project: Apache Fineract
>  Issue Type: Test
>Reporter: Manthan Surkar
>Assignee: Manthan Surkar
>Priority: Major
> Fix For: 1.4.0
>
>
> Related to FINERACT-799



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1047) Integration tests for audit trails

2020-06-26 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger reassigned FINERACT-1047:
---

Assignee: Michael Vorburger  (was: Manthan Surkar)

> Integration tests for audit trails
> --
>
> Key: FINERACT-1047
> URL: https://issues.apache.org/jira/browse/FINERACT-1047
> Project: Apache Fineract
>  Issue Type: Test
>Reporter: Manthan Surkar
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.4.0
>
>
> Related to FINERACT-799



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-835) Generate swagger-ui/response.json at build time

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146216#comment-17146216
 ] 

Michael Vorburger commented on FINERACT-835:


https://github.com/apache/fineract/pull/1101

> Generate swagger-ui/response.json at build time
> ---
>
> Key: FINERACT-835
> URL: https://issues.apache.org/jira/browse/FINERACT-835
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Major
>  Labels: beginner, documentation
> Fix For: 1.4.0
>
>
> We currently have src/main/resources/swagger-ui/response.json (checked into 
> Git).
> That file seems to have been manually put there by people over time. 
> https://github.com/apache/fineract/pull/629 (which got superseded by 
> https://github.com/apache/fineract/pull/695) mentions that, quote:
> {quote}The already existing response.json file in 
> src/main/resources/swagger-ui/ is the spec generated with the request 
> https://localhost:8443/fineract-provider/api/v1/swagger.json. Every time a 
> modification is done on the swagger docs or a new swagger doc is added, this 
> spec needs to be generated again at runtime and the response.json file as 
> well updated so that the modifications can be seen on the UI.{quote}
> and also:
> {quote}The io.swagger.core.v3.swagger-gradle-plugin is a plugin i had added 
> to automatically generate the specs during build time and not at run time. 
> This was so that every time one builds on the project, the response.json 
> updates. But this did not work as expected.{quote}
> The review process of the PR raise for this issue will be as follows: We will 
> modify one of the descriptions in one of those annotations added in the 
> original PR. We will (manually, locally) run {{./gradlew build}}. If that 
> updates the src/main/resources/swagger-ui/response.json, then this task is 
> done, and the proposed PR will be merged. 
> [~kangbreder] would you like to do this? Please raise PR with ONLY this 
> change, nothing else. Specifically, please do NOT add other Gradle plugins to 
> the build which are not directly related to this specific goal. For example, 
> building client libraries, or moving that response.json file elsewhere, is 
> out of scope of this sub-task. (I'll be creating another sub-task about those 
> things.)
> [~awasum] [~sanyam] ([~sanyam96] ?) FYI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1043) Unable to create client due to invalid error message about required address field

2020-06-26 Thread Michael Vorburger (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146208#comment-17146208
 ] 

Michael Vorburger commented on FINERACT-1043:
-

https://github.com/apache/fineract/pull/1110 merged. In an ideal world, an 
Integration Test (IT) for this would be great.. perhaps you'd like to 
contribute an IT in a follow-up PR?

> Unable to create client due to invalid error message about required address 
> field
> -
>
> Key: FINERACT-1043
> URL: https://issues.apache.org/jira/browse/FINERACT-1043
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0
> Environment: 
> https://cui.fineract.dev/?baseApiUrl=https://demo.fineract.dev=default#
>Reporter: Ed Cable
>Assignee: Rahul Pawar
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: Screenshot 2020-06-19 at 3.54.14 PM.png
>
>
> To reproduce this issue, one must first have the global configuration value 
> of "Enable-Address" enabled to enforce a client needing to have an address.
> Once that configuration is enable, create a client and fill out the required 
> fields. 
> Once filling out the address, when attempting to submit it will tell you the 
> address street cannot be blank. First off the validation error is being 
> displayed even when there is a value entered. Secondly, the error message 
> should refer to the proper name of the field, Address Line 1 and not street.
> I wasn't sure if this was just a front-end issue or on the back-end so 
> created it here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-1043) Unable to create client due to invalid error message about required address field

2020-06-26 Thread Michael Vorburger (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Vorburger updated FINERACT-1043:

Fix Version/s: 1.4.0

> Unable to create client due to invalid error message about required address 
> field
> -
>
> Key: FINERACT-1043
> URL: https://issues.apache.org/jira/browse/FINERACT-1043
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client
>Affects Versions: 1.4.0
> Environment: 
> https://cui.fineract.dev/?baseApiUrl=https://demo.fineract.dev=default#
>Reporter: Ed Cable
>Assignee: Rahul Pawar
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: Screenshot 2020-06-19 at 3.54.14 PM.png
>
>
> To reproduce this issue, one must first have the global configuration value 
> of "Enable-Address" enabled to enforce a client needing to have an address.
> Once that configuration is enable, create a client and fill out the required 
> fields. 
> Once filling out the address, when attempting to submit it will tell you the 
> address street cannot be blank. First off the validation error is being 
> displayed even when there is a value entered. Secondly, the error message 
> should refer to the proper name of the field, Address Line 1 and not street.
> I wasn't sure if this was just a front-end issue or on the back-end so 
> created it here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1049) Shares account delete gives 405

2020-06-26 Thread Manthan Surkar (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146195#comment-17146195
 ] 

Manthan Surkar commented on FINERACT-1049:
--

[~vorburger] I had a discussion with [~karantakalkar] on this issue, I am 
taking this up.


> Shares account delete gives 405
> ---
>
> Key: FINERACT-1049
> URL: https://issues.apache.org/jira/browse/FINERACT-1049
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Shares
>Reporter: Karan
>Priority: Minor
>  Labels: beginner
> Attachments: Screenshot from 2020-06-23 16-27-59.png, 
> screenshot(7).png, screenshot(8).png
>
>
> Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1049) Shares account delete gives 405

2020-06-26 Thread Manthan Surkar (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manthan Surkar reassigned FINERACT-1049:


Assignee: Manthan Surkar

> Shares account delete gives 405
> ---
>
> Key: FINERACT-1049
> URL: https://issues.apache.org/jira/browse/FINERACT-1049
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Shares
>Reporter: Karan
>Assignee: Manthan Surkar
>Priority: Minor
>  Labels: beginner
> Attachments: Screenshot from 2020-06-23 16-27-59.png, 
> screenshot(7).png, screenshot(8).png
>
>
> Shares account delete support is required.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1057) Running -Psecurity=oauth leads to memory leak issue

2020-06-26 Thread Saransh Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146033#comment-17146033
 ] 

Saransh Sharma commented on FINERACT-1057:
--

Fixes this 

> Running -Psecurity=oauth leads to memory leak issue 
> 
>
> Key: FINERACT-1057
> URL: https://issues.apache.org/jira/browse/FINERACT-1057
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Saransh Sharma
>Priority: Major
>
> When running -Psecurity=oauth 
> JAX_API thrown hikari data pool memory leak issue 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1057) Running -Psecurity=oauth leads to memory leak issue

2020-06-26 Thread Saransh Sharma (Jira)
Saransh Sharma created FINERACT-1057:


 Summary: Running -Psecurity=oauth leads to memory leak issue 
 Key: FINERACT-1057
 URL: https://issues.apache.org/jira/browse/FINERACT-1057
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Saransh Sharma


When running -Psecurity=oauth 

JAX_API thrown hikari data pool memory leak issue 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)