[jira] [Created] (FINERACT-1078) Make spring logs colorful
Yemdjih Kaze Nasser created FINERACT-1078: - Summary: Make spring logs colorful Key: FINERACT-1078 URL: https://issues.apache.org/jira/browse/FINERACT-1078 Project: Apache Fineract Issue Type: Improvement Components: Build Affects Versions: 1.4.0 Reporter: Yemdjih Kaze Nasser [~vorburger] once expressed this in a comment. Adding springs support for colored build logs which could be useful, making logs more readable and errors easier to spot. I just think it's a great feature to add. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1023) Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE
[ https://issues.apache.org/jira/browse/FINERACT-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser resolved FINERACT-1023. --- Resolution: Fixed > Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE > - > > Key: FINERACT-1023 > URL: https://issues.apache.org/jira/browse/FINERACT-1023 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Awasum Yannick >Assignee: Percy Ashu >Priority: Minor > Fix For: 1.4.0 > > > Renovate tried to upgrade to Spring Boot 2.3: > [https://github.com/apache/fineract/pull/998] > This failed as shown here: > [https://travis-ci.org/github/apache/fineract/builds/695663148] > Looks like validation dependency is missing in the new release. We have to > upgrade manually by adding it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1023) Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE
[ https://issues.apache.org/jira/browse/FINERACT-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser updated FINERACT-1023: -- Affects Version/s: 1.4.0 > Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE > - > > Key: FINERACT-1023 > URL: https://issues.apache.org/jira/browse/FINERACT-1023 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Awasum Yannick >Assignee: Percy Ashu >Priority: Minor > Fix For: 1.4.0 > > > Renovate tried to upgrade to Spring Boot 2.3: > [https://github.com/apache/fineract/pull/998] > This failed as shown here: > [https://travis-ci.org/github/apache/fineract/builds/695663148] > Looks like validation dependency is missing in the new release. We have to > upgrade manually by adding it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1077) Migrate from legacy plugins applications to plugins DSL in build.gradle
[ https://issues.apache.org/jira/browse/FINERACT-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser updated FINERACT-1077: -- Affects Version/s: (was: 1.5.0) 1.4.0 > Migrate from legacy plugins applications to plugins DSL in build.gradle > --- > > Key: FINERACT-1077 > URL: https://issues.apache.org/jira/browse/FINERACT-1077 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Priority: Major > > We are still using the old way of applying gradle plugins in our > build.gradle. Today there is more convenient way of doing this which more and > more packages are using. This would make the build less cumbersome too and > plugins easier to maintain and apply. > [https://docs.gradle.org/current/userguide/plugins.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1077) Migrate from legacy plugins applications to plugins DSL in build.gradle
Yemdjih Kaze Nasser created FINERACT-1077: - Summary: Migrate from legacy plugins applications to plugins DSL in build.gradle Key: FINERACT-1077 URL: https://issues.apache.org/jira/browse/FINERACT-1077 Project: Apache Fineract Issue Type: Improvement Components: Build Affects Versions: 1.5.0 Reporter: Yemdjih Kaze Nasser We are still using the old way of applying gradle plugins in our build.gradle. Today there is more convenient way of doing this which more and more packages are using. This would make the build less cumbersome too and plugins easier to maintain and apply. [https://docs.gradle.org/current/userguide/plugins.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINCN-234) Add task management feature into the App.
Ahmad Jawid Muhammadi created FINCN-234: --- Summary: Add task management feature into the App. Key: FINCN-234 URL: https://issues.apache.org/jira/browse/FINCN-234 Project: Fineract Cloud Native Issue Type: New Feature Components: fineract-cn-mobile Reporter: Ahmad Jawid Muhammadi The support for closing, locking, and reopening of a user account has already been added in the app but currently, the app does not have any support for loan account-related tasks like *approve* the loan, *close* or *delete* loan accounts and *disburse* the loan. Whenever a user clicks on the Tasks option in the _CustomerLoanDetailsFragment,_ nothing happens. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1066) NullPointerException at SQLInjectionValidator.validateSQLInput()
[
https://issues.apache.org/jira/browse/FINERACT-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manthan Surkar reassigned FINERACT-1066:
Assignee: Manthan Surkar
> NullPointerException at SQLInjectionValidator.validateSQLInput()
>
>
> Key: FINERACT-1066
> URL: https://issues.apache.org/jira/browse/FINERACT-1066
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Manthan Surkar
>Priority: Blocker
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat} java.lang.NullPointerException
> at
> org.apache.fineract.infrastructure.security.utils.SQLInjectionValidator.validateSQLInput
> (SQLInjectionValidator.java:36)
> at
> org.apache.fineract.infrastructure.security.utils.ColumnValidator.validateSqlInjection
> (ColumnValidator.java:94)
> at
> org.apache.fineract.portfolio.group.service.CenterReadPlatformServiceImpl.retrieveAll
> (CenterReadPlatformServiceImpl.java:432)
> at
> org.apache.fineract.portfolio.group.api.CentersApiResource.retrieveAll
> (CentersApiResource.java:219) {noformat}
> [~Manthan] is this perhaps something you'd like to pick up?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1066) NullPointerException at SQLInjectionValidator.validateSQLInput()
[
https://issues.apache.org/jira/browse/FINERACT-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151315#comment-17151315
]
Manthan Surkar commented on FINERACT-1066:
--
Picking this up.
> NullPointerException at SQLInjectionValidator.validateSQLInput()
>
>
> Key: FINERACT-1066
> URL: https://issues.apache.org/jira/browse/FINERACT-1066
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Blocker
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat} java.lang.NullPointerException
> at
> org.apache.fineract.infrastructure.security.utils.SQLInjectionValidator.validateSQLInput
> (SQLInjectionValidator.java:36)
> at
> org.apache.fineract.infrastructure.security.utils.ColumnValidator.validateSqlInjection
> (ColumnValidator.java:94)
> at
> org.apache.fineract.portfolio.group.service.CenterReadPlatformServiceImpl.retrieveAll
> (CenterReadPlatformServiceImpl.java:432)
> at
> org.apache.fineract.portfolio.group.api.CentersApiResource.retrieveAll
> (CentersApiResource.java:219) {noformat}
> [~Manthan] is this perhaps something you'd like to pick up?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1074) Upgrade all plugins to latest versions
[ https://issues.apache.org/jira/browse/FINERACT-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1074: Description: There are Gradle plugins (eg license plugin) that have been superseded by newer ones - replace these with the latest versions and clean up all the plugin configurations so they are in clearly segregated sections (was: There are Gradle plugins (eg license plugin) that have been superseded by newer ones - replace these with the latest versions) > Upgrade all plugins to latest versions > -- > > Key: FINERACT-1074 > URL: https://issues.apache.org/jira/browse/FINERACT-1074 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > There are Gradle plugins (eg license plugin) that have been superseded by > newer ones - replace these with the latest versions and clean up all the > plugin configurations so they are in clearly segregated sections -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1074) Clean up plugin configurations
[ https://issues.apache.org/jira/browse/FINERACT-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1074: Summary: Clean up plugin configurations (was: Upgrade all plugins to latest versions) > Clean up plugin configurations > -- > > Key: FINERACT-1074 > URL: https://issues.apache.org/jira/browse/FINERACT-1074 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > There are Gradle plugins (eg license plugin) that have been superseded by > newer ones - replace these with the latest versions and clean up all the > plugin configurations so they are in clearly segregated sections -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1074) Upgrade all plugins to latest versions
[ https://issues.apache.org/jira/browse/FINERACT-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1074: --- Assignee: Petri Tuomola > Upgrade all plugins to latest versions > -- > > Key: FINERACT-1074 > URL: https://issues.apache.org/jira/browse/FINERACT-1074 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > There are Gradle plugins (eg license plugin) that have been superseded by > newer ones - replace these with the latest versions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1072) Apply Spotless to Gradle files
[ https://issues.apache.org/jira/browse/FINERACT-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick resolved FINERACT-1072. -- Resolution: Fixed Thanks [~ptuomola]. > Apply Spotless to Gradle files > -- > > Key: FINERACT-1072 > URL: https://issues.apache.org/jira/browse/FINERACT-1072 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.4.0 > > > Apply GroovyGradle to gradle files to improve formatting -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1023) Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE
[ https://issues.apache.org/jira/browse/FINERACT-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151273#comment-17151273 ] Awasum Yannick commented on FINERACT-1023: -- See PR: [https://github.com/apache/fineract/pull/1146] from [~Percy Ashu] > Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE > - > > Key: FINERACT-1023 > URL: https://issues.apache.org/jira/browse/FINERACT-1023 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Awasum Yannick >Assignee: Percy Ashu >Priority: Minor > Fix For: 1.4.0 > > > Renovate tried to upgrade to Spring Boot 2.3: > [https://github.com/apache/fineract/pull/998] > This failed as shown here: > [https://travis-ci.org/github/apache/fineract/builds/695663148] > Looks like validation dependency is missing in the new release. We have to > upgrade manually by adding it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1023) Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE
[ https://issues.apache.org/jira/browse/FINERACT-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Percy Ashu reassigned FINERACT-1023: Assignee: Percy Ashu > Update dependency spring-boot-gradle-plugin from v2.2.7 to v2.3.1.RELEASE > - > > Key: FINERACT-1023 > URL: https://issues.apache.org/jira/browse/FINERACT-1023 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Awasum Yannick >Assignee: Percy Ashu >Priority: Minor > Fix For: 1.4.0 > > > Renovate tried to upgrade to Spring Boot 2.3: > [https://github.com/apache/fineract/pull/998] > This failed as shown here: > [https://travis-ci.org/github/apache/fineract/builds/695663148] > Looks like validation dependency is missing in the new release. We have to > upgrade manually by adding it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151256#comment-17151256 ] Percy Ashu commented on FINERACT-822: - [~awasum] I have complete all except "TypeParameterUnusedInFormals" > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Fix For: 1.4.0 > > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1012) Spring Security OAuth 2.x to Spring Security 5.2.x
[
https://issues.apache.org/jira/browse/FINERACT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wandji Collins reassigned FINERACT-1012:
Assignee: (was: Wandji Collins)
> Spring Security OAuth 2.x to Spring Security 5.2.x
> --
>
> Key: FINERACT-1012
> URL: https://issues.apache.org/jira/browse/FINERACT-1012
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Priority: Critical
> Labels: beginner
> Fix For: 1.4.0
>
>
> The bump of spring-security-oauth2 from 2.3.6.RELEASE to 2.4.1.RELEASE in
> https://github.com/apache/fineract/pull/863 as part of FINERACT-963
> introduced usage of {{@Deprecated}} code, which we are trying to avoid (and
> which since FINERACT-959 we're intentionally making the build fail).
> I'm going to use a {{@SuppressWarnings("deprecation")}} to be able to do the
> upgrade anyway, because upgrading a security related library to its latest
> version seems like a sensible thing to do, but we really should remove the
> suppression and switch to using Spring's newer APIs.
> https://github.com/spring-projects/spring-security/wiki/OAuth-2.0-Migration-Guide
> affects {{UserDetailsApiResource}} and
> {{TwoFactorAuthenticationFilter.createUpdatedAuthentication()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1076) Error Prone: Enable Var Check
[ https://issues.apache.org/jira/browse/FINERACT-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-1076: - Labels: beginner technical (was: ) > Error Prone: Enable Var Check > -- > > Key: FINERACT-1076 > URL: https://issues.apache.org/jira/browse/FINERACT-1076 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Awasum Yannick >Priority: Minor > Labels: beginner, technical > > [https://errorprone.info/bugpattern/Var] > Enable and enforce Var check. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151220#comment-17151220 ] Awasum Yannick commented on FINERACT-822: - [~vorburger] thanks for prioritizing this. And [~Percy Ashu], thanks for the list. and which of the ones prioritized by Mike have you completed and which of them are left? Ignore the not so important ones above as I will create separate issues for beginners of Fineract to start picking up over the next few months..just to get their feet in the door. > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Fix For: 1.4.0 > > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1075) Error Prone: Enable JdkObsolete Check
Awasum Yannick created FINERACT-1075: Summary: Error Prone: Enable JdkObsolete Check Key: FINERACT-1075 URL: https://issues.apache.org/jira/browse/FINERACT-1075 Project: Apache Fineract Issue Type: Improvement Reporter: Awasum Yannick Enable Error Prone check for [https://errorprone.info/bugpattern/JdkObsolete] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1075) Error Prone: Enable JdkObsolete Check
[ https://issues.apache.org/jira/browse/FINERACT-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awasum Yannick updated FINERACT-1075: - Labels: beginner technical (was: ) > Error Prone: Enable JdkObsolete Check > -- > > Key: FINERACT-1075 > URL: https://issues.apache.org/jira/browse/FINERACT-1075 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Awasum Yannick >Priority: Major > Labels: beginner, technical > > Enable Error Prone check for [https://errorprone.info/bugpattern/JdkObsolete] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
