[jira] [Commented] (FINERACT-1049) Shares account delete gives 405
[ https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159672#comment-17159672 ] Karan commented on FINERACT-1049: - [~natashan] I tried hacking on this bug however due to occupations with my frontend project and being totally new to java i couldn't finish it, I only discussed with Manthan about building the code base an how to test changes in it, and requested if he could take it over the line. here is my attempt [https://github.com/karantakalkar/fineract/commit/edee7281e12fc545afc2513019edf9c7d7a22b68] hope this points to right files at least. > Shares account delete gives 405 > --- > > Key: FINERACT-1049 > URL: https://issues.apache.org/jira/browse/FINERACT-1049 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Karan >Assignee: Natasha Natarajan >Priority: Minor > Labels: beginner > Attachments: Screenshot from 2020-06-23 16-27-59.png, > screenshot(7).png, screenshot(8).png > > > Shares account delete support is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-519) Default list of only active employees
[ https://issues.apache.org/jira/browse/FINERACT-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159541#comment-17159541 ] Natasha Natarajan commented on FINERACT-519: Closed. > Default list of only active employees > - > > Key: FINERACT-519 > URL: https://issues.apache.org/jira/browse/FINERACT-519 > Project: Apache Fineract > Issue Type: Improvement > Components: Organization, User Management >Reporter: Santosh Math >Assignee: Natasha Natarajan >Priority: Major > Labels: beginner, functional, gsoc, p2 > > Reported by [~mexina], > For now when you create an employee through navigating Admin -> Organization > -> Manage Employees > The employee is created and there is only the option to edit him/her. > What if an employee leaves the organization? there should be also the button > to delete him. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FINERACT-519) Default list of only active employees
[ https://issues.apache.org/jira/browse/FINERACT-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natasha Natarajan closed FINERACT-519. -- Resolution: Invalid This is a front end issue. > Default list of only active employees > - > > Key: FINERACT-519 > URL: https://issues.apache.org/jira/browse/FINERACT-519 > Project: Apache Fineract > Issue Type: Improvement > Components: Organization, User Management >Reporter: Santosh Math >Assignee: Natasha Natarajan >Priority: Major > Labels: beginner, functional, gsoc, p2 > > Reported by [~mexina], > For now when you create an employee through navigating Admin -> Organization > -> Manage Employees > The employee is created and there is only the option to edit him/her. > What if an employee leaves the organization? there should be also the button > to delete him. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1091) PersistenceException: Field 'constitution_cv_id' doesn't have a default value
[
https://issues.apache.org/jira/browse/FINERACT-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159522#comment-17159522
]
Yemdjih Kaze Nasser commented on FINERACT-1091:
---
No this is not one of the issues. This is probably something else. I'd bet on
what [~ptuomola] proposes.
> PersistenceException: Field 'constitution_cv_id' doesn't have a default value
> -
>
> Key: FINERACT-1091
> URL: https://issues.apache.org/jira/browse/FINERACT-1091
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Blocker
>
> See FINERACT-932 for general background; I've found this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat}org.apache.openjpa.persistence.PersistenceException: The
> transaction has been rolled back. See the nested exceptions for details on
> the errors that occurred.
> at
> org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignObjectId(StateManagerImpl.java:618)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignField(StateManagerImpl.java:705)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.beforeAccessField(StateManagerImpl.java:1750)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.accessingField(StateManagerImpl.java:1679)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.pcGetid(AbstractPersistableCustom.java)
> ~[app/:na]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.getId(AbstractPersistableCustom.java:50)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.address.service.AddressWritePlatformServiceImpl.addNewClientAddress(AddressWritePlatformServiceImpl.java:143)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:328)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke()
> ~[app/:na]
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> ~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$EnhancerBySpringCGLIB$$3e889443.createClient()
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler.processCommand(CreateClientCommandHandler.java:45)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler$$FastClassBySpringCGLIB$$6bce1ca9.invoke()
> ~[app/:na]
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> ~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
>
[jira] [Closed] (FINERACT-1084) Creating guarantor to put funds on hold - Some clients will not be seen
[ https://issues.apache.org/jira/browse/FINERACT-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Guchie closed FINERACT-1084. Resolution: Not A Problem > Creating guarantor to put funds on hold - Some clients will not be seen > --- > > Key: FINERACT-1084 > URL: https://issues.apache.org/jira/browse/FINERACT-1084 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0 >Reporter: Francis Guchie >Priority: Major > > * *Browser used:* Mozilla and Chrome > * *OS:* Linux 18.04.01 LTS > *Actual behavior:* > Some clients can not be seen even if the the response from > [https://serveraddressOrname/fineract-provider/api/v1/clients|https://serveraddressorname/fineract-provider/api/v1/clients] > shows that all clients from table m_client are queried but not all show up in > the response payload (pageItems: ) > Only clients of MAIN PARENT BRANCH (branch id =1 ) will appear This does for > self and non-self guarantor > The Listed clients will include clients from BRANCH ID 1 and that Particular > branch but the total shall be 200 and the user does not have the opportunity > to filter the list generated. > *Steps to reproduce: use steps below* > [https://mifosforge.jira.com/wiki/spaces/docs/pages/85623288/How+to+Place+Guarantee+Funds+On-Hold] > *Expected behavior:* > The page should load a limited list of clients avoid over loading the page > but user should be able to select any client in the system by filtering the > list using a branch selection, and a name of set of names > Imagine a large database, the page should not load any data until the user > filters this by branch and then later by client name or client id (if > possible) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1084) Creating guarantor to put funds on hold - Some clients will not be seen
[ https://issues.apache.org/jira/browse/FINERACT-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159485#comment-17159485 ] Francis Guchie commented on FINERACT-1084: -- There is no need for changes in the fineract for this Issue. This issues can be closed > Creating guarantor to put funds on hold - Some clients will not be seen > --- > > Key: FINERACT-1084 > URL: https://issues.apache.org/jira/browse/FINERACT-1084 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0 >Reporter: Francis Guchie >Priority: Major > > * *Browser used:* Mozilla and Chrome > * *OS:* Linux 18.04.01 LTS > *Actual behavior:* > Some clients can not be seen even if the the response from > [https://serveraddressOrname/fineract-provider/api/v1/clients|https://serveraddressorname/fineract-provider/api/v1/clients] > shows that all clients from table m_client are queried but not all show up in > the response payload (pageItems: ) > Only clients of MAIN PARENT BRANCH (branch id =1 ) will appear This does for > self and non-self guarantor > The Listed clients will include clients from BRANCH ID 1 and that Particular > branch but the total shall be 200 and the user does not have the opportunity > to filter the list generated. > *Steps to reproduce: use steps below* > [https://mifosforge.jira.com/wiki/spaces/docs/pages/85623288/How+to+Place+Guarantee+Funds+On-Hold] > *Expected behavior:* > The page should load a limited list of clients avoid over loading the page > but user should be able to select any client in the system by filtering the > list using a branch selection, and a name of set of names > Imagine a large database, the page should not load any data until the user > filters this by branch and then later by client name or client id (if > possible) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1066) NullPointerException at SQLInjectionValidator.validateSQLInput()
[
https://issues.apache.org/jira/browse/FINERACT-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159445#comment-17159445
]
Manthan Surkar commented on FINERACT-1066:
--
https://github.com/apache/fineract/pull/1159
My bad, I wrote wrong issue number in pr commit msg, I will fix this.
> NullPointerException at SQLInjectionValidator.validateSQLInput()
>
>
> Key: FINERACT-1066
> URL: https://issues.apache.org/jira/browse/FINERACT-1066
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Manthan Surkar
>Priority: Blocker
> Fix For: 1.4.0
>
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat} java.lang.NullPointerException
> at
> org.apache.fineract.infrastructure.security.utils.SQLInjectionValidator.validateSQLInput
> (SQLInjectionValidator.java:36)
> at
> org.apache.fineract.infrastructure.security.utils.ColumnValidator.validateSqlInjection
> (ColumnValidator.java:94)
> at
> org.apache.fineract.portfolio.group.service.CenterReadPlatformServiceImpl.retrieveAll
> (CenterReadPlatformServiceImpl.java:432)
> at
> org.apache.fineract.portfolio.group.api.CentersApiResource.retrieveAll
> (CentersApiResource.java:219) {noformat}
> [~Manthan] is this perhaps something you'd like to pick up?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1066) NullPointerException at SQLInjectionValidator.validateSQLInput()
[
https://issues.apache.org/jira/browse/FINERACT-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159442#comment-17159442
]
Awasum Yannick commented on FINERACT-1066:
--
[~Manthan] which PR fixed this or it was a false alarm?
> NullPointerException at SQLInjectionValidator.validateSQLInput()
>
>
> Key: FINERACT-1066
> URL: https://issues.apache.org/jira/browse/FINERACT-1066
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Manthan Surkar
>Priority: Blocker
> Fix For: 1.4.0
>
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat} java.lang.NullPointerException
> at
> org.apache.fineract.infrastructure.security.utils.SQLInjectionValidator.validateSQLInput
> (SQLInjectionValidator.java:36)
> at
> org.apache.fineract.infrastructure.security.utils.ColumnValidator.validateSqlInjection
> (ColumnValidator.java:94)
> at
> org.apache.fineract.portfolio.group.service.CenterReadPlatformServiceImpl.retrieveAll
> (CenterReadPlatformServiceImpl.java:432)
> at
> org.apache.fineract.portfolio.group.api.CentersApiResource.retrieveAll
> (CentersApiResource.java:219) {noformat}
> [~Manthan] is this perhaps something you'd like to pick up?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1082) Automate Fineract version number population into Swagger doc
[ https://issues.apache.org/jira/browse/FINERACT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159434#comment-17159434 ] Manthan Surkar commented on FINERACT-1082: -- [~ptuomola] can you guide me a little on from where to fetch the version? I could not find the version property anywhere. i found -> releaseVersion=1.0.0 in gradle.properties is this wrong and needs to be updated? > Automate Fineract version number population into Swagger doc > > > Key: FINERACT-1082 > URL: https://issues.apache.org/jira/browse/FINERACT-1082 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Petri Tuomola >Assignee: Manthan Surkar >Priority: Minor > > Currently the Fineract version (e.g. 1.4.0) for Swagger documentation is > hardcoded into fineract-provider/config/swagger/fineract-input.json. This > should be automatically populated based on current Fineract version -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-742) Swagger guide for new api's
[ https://issues.apache.org/jira/browse/FINERACT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159431#comment-17159431 ] Manthan Surkar commented on FINERACT-742: - [~vorburger] Here is the guide that was written(GSoC'19) : https://docs.google.com/document/d/1BkN-Iw5kNrfia7chsgeNoyo6Z1vnBqRnioF0_IRwDyE/edit Should we add it to readme? and then mark this as closed? or you have any other idea on what we can do with the guide? > Swagger guide for new api's > > > Key: FINERACT-742 > URL: https://issues.apache.org/jira/browse/FINERACT-742 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > > Create swagger documentation guide for developers to apply swagger > annotations on fineract apis. > Going forward, whenever new api will be created, it's swagger document can be > created along with api. > For reference : https://goo.gl/8RMMhN -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-742) Swagger guide for new api's
[ https://issues.apache.org/jira/browse/FINERACT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar reassigned FINERACT-742: --- Assignee: Manthan Surkar > Swagger guide for new api's > > > Key: FINERACT-742 > URL: https://issues.apache.org/jira/browse/FINERACT-742 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Assignee: Manthan Surkar >Priority: Minor > Labels: fineract-swagger-doc > > Create swagger documentation guide for developers to apply swagger > annotations on fineract apis. > Going forward, whenever new api will be created, it's swagger document can be > created along with api. > For reference : https://goo.gl/8RMMhN -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-834) Minor quick win: Please raise very small PR documenting Swagger use on README
[ https://issues.apache.org/jira/browse/FINERACT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159430#comment-17159430 ] Manthan Surkar commented on FINERACT-834: - [~vorburger] [~ptuomola] do you think it would be a good idea to add a small video demo on how to use swagger-api? otherwise, we can write it in Text format about features like Filter and try-it. > Minor quick win: Please raise very small PR documenting Swagger use on README > - > > Key: FINERACT-834 > URL: https://issues.apache.org/jira/browse/FINERACT-834 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Priority: Major > > Based on some of the discussion in > https://github.com/apache/fineract/pull/629 (which got superseded by > https://github.com/apache/fineract/pull/695), I think it would be very useful > to have a short line (or a or two paragraph, max) in > https://github.com/apache/fineract/blob/develop/README.md#apache-fineract-platform-api > which simply explains how one actually may currently use the Swagger UI, as > it currently is. > I will just be completely honest and admit that personally I do not actually > know how! ;-) Is there a special URL one has to access? Does one need to > locally install anything? > [~kangbreder] would you like to do this? Please do raise 1 small PR with ONLY > this README change. > [~awasum] [~sanyam] ([~sanyam96] ?) FYI -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-746) Add/update swagger document for commands api's
[ https://issues.apache.org/jira/browse/FINERACT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159428#comment-17159428 ] Manthan Surkar commented on FINERACT-746: - This probably needs some work, taking this up. > Add/update swagger document for commands api's > -- > > Key: FINERACT-746 > URL: https://issues.apache.org/jira/browse/FINERACT-746 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Assignee: Manthan Surkar >Priority: Minor > Labels: fineract-swagger-doc > > Add documentation for remaining api's of commands module. > Update/correct existing documentation of commands module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-746) Add/update swagger document for commands api's
[ https://issues.apache.org/jira/browse/FINERACT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar reassigned FINERACT-746: --- Assignee: Manthan Surkar > Add/update swagger document for commands api's > -- > > Key: FINERACT-746 > URL: https://issues.apache.org/jira/browse/FINERACT-746 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Assignee: Manthan Surkar >Priority: Minor > Labels: fineract-swagger-doc > > Add documentation for remaining api's of commands module. > Update/correct existing documentation of commands module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-741) Improving Swagger UI to group related APIs together instead of random order
[ https://issues.apache.org/jira/browse/FINERACT-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar reassigned FINERACT-741: --- Assignee: Manthan Surkar > Improving Swagger UI to group related APIs together instead of random order > --- > > Key: FINERACT-741 > URL: https://issues.apache.org/jira/browse/FINERACT-741 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Assignee: Manthan Surkar >Priority: Minor > Labels: fineract-swagger-doc > > All API's are currently listed in a random order and someone new to the > system cannot comprehend relationships between them. The home page needs to > be improved with either a sidebar or a navbar (similar to the one in the > existing documentation) which groups together related API's and provides > hyperlinks to their swagger documentation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-741) Improving Swagger UI to group related APIs together instead of random order
[ https://issues.apache.org/jira/browse/FINERACT-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159425#comment-17159425 ] Manthan Surkar commented on FINERACT-741: - I am taking this :) > Improving Swagger UI to group related APIs together instead of random order > --- > > Key: FINERACT-741 > URL: https://issues.apache.org/jira/browse/FINERACT-741 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > > All API's are currently listed in a random order and someone new to the > system cannot comprehend relationships between them. The home page needs to > be improved with either a sidebar or a navbar (similar to the one in the > existing documentation) which groups together related API's and provides > hyperlinks to their swagger documentation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-743) Add/update swagger document for accounting api's
[ https://issues.apache.org/jira/browse/FINERACT-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159422#comment-17159422 ] Manthan Surkar commented on FINERACT-743: - Closing this, based upon my review (on live swagger-ui) and GSoC report of [~kangbreder]. > Add/update swagger document for accounting api's > > > Key: FINERACT-743 > URL: https://issues.apache.org/jira/browse/FINERACT-743 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > > Add documentation for remaining api's of accounting module. > Update/correct existing documentation of accounting module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-743) Add/update swagger document for accounting api's
[ https://issues.apache.org/jira/browse/FINERACT-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar resolved FINERACT-743. - Fix Version/s: 1.4.0 Resolution: Fixed > Add/update swagger document for accounting api's > > > Key: FINERACT-743 > URL: https://issues.apache.org/jira/browse/FINERACT-743 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > Fix For: 1.4.0 > > > Add documentation for remaining api's of accounting module. > Update/correct existing documentation of accounting module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-745) Update swagger document for batch api
[ https://issues.apache.org/jira/browse/FINERACT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar resolved FINERACT-745. - Fix Version/s: 1.4.0 Resolution: Fixed > Update swagger document for batch api > - > > Key: FINERACT-745 > URL: https://issues.apache.org/jira/browse/FINERACT-745 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > Fix For: 1.4.0 > > > Update/correct existing documentation of batch api module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-745) Update swagger document for batch api
[ https://issues.apache.org/jira/browse/FINERACT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159420#comment-17159420 ] Manthan Surkar commented on FINERACT-745: - Closing this, based upon my review (on live swagger-ui) and GSoC report of [~kangbreder]. > Update swagger document for batch api > - > > Key: FINERACT-745 > URL: https://issues.apache.org/jira/browse/FINERACT-745 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > > Update/correct existing documentation of batch api module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-744) Add swagger document for adhocquery api
[ https://issues.apache.org/jira/browse/FINERACT-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar updated FINERACT-744: Fix Version/s: 1.4.0 > Add swagger document for adhocquery api > --- > > Key: FINERACT-744 > URL: https://issues.apache.org/jira/browse/FINERACT-744 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > Fix For: 1.4.0 > > > Add documentation for adhocquery api module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1066) NullPointerException at SQLInjectionValidator.validateSQLInput()
[
https://issues.apache.org/jira/browse/FINERACT-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manthan Surkar updated FINERACT-1066:
-
Fix Version/s: 1.4.0
> NullPointerException at SQLInjectionValidator.validateSQLInput()
>
>
> Key: FINERACT-1066
> URL: https://issues.apache.org/jira/browse/FINERACT-1066
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Manthan Surkar
>Priority: Blocker
> Fix For: 1.4.0
>
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat} java.lang.NullPointerException
> at
> org.apache.fineract.infrastructure.security.utils.SQLInjectionValidator.validateSQLInput
> (SQLInjectionValidator.java:36)
> at
> org.apache.fineract.infrastructure.security.utils.ColumnValidator.validateSqlInjection
> (ColumnValidator.java:94)
> at
> org.apache.fineract.portfolio.group.service.CenterReadPlatformServiceImpl.retrieveAll
> (CenterReadPlatformServiceImpl.java:432)
> at
> org.apache.fineract.portfolio.group.api.CentersApiResource.retrieveAll
> (CentersApiResource.java:219) {noformat}
> [~Manthan] is this perhaps something you'd like to pick up?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1047) Integration tests for audit trails
[ https://issues.apache.org/jira/browse/FINERACT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar resolved FINERACT-1047. -- Resolution: Fixed > Integration tests for audit trails > -- > > Key: FINERACT-1047 > URL: https://issues.apache.org/jira/browse/FINERACT-1047 > Project: Apache Fineract > Issue Type: Test >Reporter: Manthan Surkar >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.4.0 > > > Related to FINERACT-799 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1083) Swagger UI resource location to be version independent
[ https://issues.apache.org/jira/browse/FINERACT-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar updated FINERACT-1083: - Fix Version/s: 1.4.0 > Swagger UI resource location to be version independent > -- > > Key: FINERACT-1083 > URL: https://issues.apache.org/jira/browse/FINERACT-1083 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.4.0 > > > Swagger UI application is now included through the runtime dependency in the > Gradle file (dependency on 'org.webjars.npm:swagger-ui-dist'), and Tomcat is > then instructed to route requests for /swagger-ui to the WebJar (see code in > org.apache.fineract.infrastructure.core.boot.WebFrontEndConfiguration). > The only problem is that the code in > org.apache.fineract.infrastructure.core.boot.WebFrontEndConfiguration refers > to the WebJAR with a specific version number. When we upgrade the dependency > we need to also change the source code to point to the right version. A > better solution would be to make this version agnostic - either by using the > webjars-locator > ([https://mvnrepository.com/artifact/org.webjars/webjars-locator) > |https://mvnrepository.com/artifact/org.webjars/webjars-locator]or by simply > writing some code to find swagger.json from classpath and using the found > location to determine the right resource location to use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1090) Add a Search/Filter option in swagger-ui
[ https://issues.apache.org/jira/browse/FINERACT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar resolved FINERACT-1090. -- Fix Version/s: 1.4.0 Resolution: Fixed > Add a Search/Filter option in swagger-ui > > > Key: FINERACT-1090 > URL: https://issues.apache.org/jira/browse/FINERACT-1090 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Manthan Surkar >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.4.0 > > > Currently, It is very hard to navigate in swagger-UI, it would be nice to > have a search/filter option to find relevant APIs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1045) Replace links to demo.openmf.org on Swagger with (local) / links
[ https://issues.apache.org/jira/browse/FINERACT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar updated FINERACT-1045: - Fix Version/s: 1.4.0 > Replace links to demo.openmf.org on Swagger with (local) / links > > > Key: FINERACT-1045 > URL: https://issues.apache.org/jira/browse/FINERACT-1045 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.4.0 > > > Following [~ptuomola] PR [https://github.com/apache/fineract/pull/1069/files] > for FINERACT-835, we can now see stuff on > [http://localhost:8080/fineract-provider/swagger-ui/index.html#/] but the > very start of it, that top level description "Apache Fineract is a..." which > has many links to [https://demo.openmf.org/api-docs/apiLive.htm] looks weird, > now that we have apiLive.htm bundled in the app.. > As a first step, let's just replace all those links with absolute root links > to the instance's own self-hosted doc. > The goal of this issue should be that searching (grep) for "openmf.org" finds > no more matches at all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1044) fineract-provider/swagger-ui/ => /fineract-provider/swagger-ui/index.html
[ https://issues.apache.org/jira/browse/FINERACT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar updated FINERACT-1044: - Fix Version/s: 1.4.0 > fineract-provider/swagger-ui/ => /fineract-provider/swagger-ui/index.html > - > > Key: FINERACT-1044 > URL: https://issues.apache.org/jira/browse/FINERACT-1044 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Minor > Fix For: 1.4.0 > > > Based on my current local testing of > https://github.com/apache/fineract/pull/1069/ for FINERACT-835: > It would be "nice to have" (prio Minor) if e.g. > http://localhost:8080/fineract-provider/swagger-ui/ would redirect to > http://localhost:8080/fineract-provider/swagger-ui/index.html > This is probably possible with a 2-3 lines of customization in > fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/WebFrontEndConfiguration.java > ? > [~Manthan] and [~ptuomola] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-519) Default list of only active employees
[ https://issues.apache.org/jira/browse/FINERACT-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159400#comment-17159400 ] Natasha Natarajan commented on FINERACT-519: [~vorburger], Agreed. I have already asked Awasum the same. I am waiting to see if my PR is merged and then I will close here. > Default list of only active employees > - > > Key: FINERACT-519 > URL: https://issues.apache.org/jira/browse/FINERACT-519 > Project: Apache Fineract > Issue Type: Improvement > Components: Organization, User Management >Reporter: Santosh Math >Assignee: Natasha Natarajan >Priority: Major > Labels: beginner, functional, gsoc, p2 > > Reported by [~mexina], > For now when you create an employee through navigating Admin -> Organization > -> Manage Employees > The employee is created and there is only the option to edit him/her. > What if an employee leaves the organization? there should be also the button > to delete him. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-519) Default list of only active employees
[ https://issues.apache.org/jira/browse/FINERACT-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159374#comment-17159374 ] Michael Vorburger commented on FINERACT-519: Question: Is there also going to be (a need for) a change in [https://github.com/apache/fineract/] for this Improvement, and thus a corresponding PR, or is this pure front-end? If it's front-end only, then this Jira issue here on apache.org should be closed (if no contributions to Apache Fineract are required), as [https://github.com/openMF/community-app/issues/2432] already tracks the same. We only need a JIRA here if work in the back-end Java code is required. > Default list of only active employees > - > > Key: FINERACT-519 > URL: https://issues.apache.org/jira/browse/FINERACT-519 > Project: Apache Fineract > Issue Type: Improvement > Components: Organization, User Management >Reporter: Santosh Math >Assignee: Natasha Natarajan >Priority: Major > Labels: beginner, functional, gsoc, p2 > > Reported by [~mexina], > For now when you create an employee through navigating Admin -> Organization > -> Manage Employees > The employee is created and there is only the option to edit him/her. > What if an employee leaves the organization? there should be also the button > to delete him. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1089) Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in InterestRateChartReadPlatformServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159335#comment-17159335
]
Percy Ashu commented on FINERACT-1089:
--
Thanks for the pointer [~ptuomola] will look into it an send a PR
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in
> InterestRateChartReadPlatformServiceImpl
> --
>
> Key: FINERACT-1089
> URL: https://issues.apache.org/jira/browse/FINERACT-1089
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Percy Ashu
>Priority: Blocker
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev, this seems to be a similar problem to that was
> previously fixed in FINERACT-995 and FINERACT-1061:
> {noformat}
> org.springframework.dao.TransientDataAccessResourceException:
> PreparedStatementCallback; SQL [select irc.id as ircId, irc.name as ircName,
> irc.description as ircDescription,irc.from_date as ircFromDate, irc.end_date
> as ircEndDate, irc.is_primary_grouping_by_amount as
> isPrimaryGroupingByAmount, ircd.id as ircdId, ircd.description as
> ircdDescription, ircd.period_type_enum ircdPeriodTypeId, ircd.from_period as
> ircdFromPeriod, ircd.to_period as ircdToPeriod, ircd.amount_range_from as
> ircdAmountRangeFrom, ircd.amount_range_to as ircdAmountRangeTo,
> ircd.annual_interest_rate as ircdAnnualInterestRate, curr.code as
> currencyCode, curr.name as currencyName, curr.internationalized_name_code as
> currencyNameCode, curr.display_symbol as currencyDisplaySymbol,
> curr.decimal_places as currencyDigits, curr.currency_multiplesof as
> inMultiplesOf, sp.id as savingsProductId, sp.name as savingsProductName,
> iri.id as iriId, iri.entiry_type as entityType, iri.attribute_name as
> attributeName , iri.condition_type as conditionType, iri.attribute_value as
> attributeValue, iri.incentive_type as incentiveType, iri.amount as amount,
> code.code_value as attributeValueDesc from m_interest_rate_chart irc left
> join m_interest_rate_slab ircd on irc.id=ircd.interest_rate_chart_id left
> join m_interest_incentives iri on iri.interest_rate_slab_id = ircd.id left
> join m_code_value code on code.id = iri.attribute_value left join m_currency
> curr on ircd.currency_code= curr.code left join
> m_deposit_product_interest_rate_chart dpirc on
> irc.id=dpirc.interest_rate_chart_id left join m_savings_product sp on
> sp.id=dpirc.deposit_product_id where sp.id = ? order by irc.id, CASE WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_from WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_to END,ircd.from_period,
> ircd.to_period,CASE WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_from WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_to END]; Operation not allowed for a result set of type
> ResultSet.TYPE_FORWARD_ONLY.; nested exception is java.sql.SQLException:
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
> at
> org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate
> (SQLStateSQLExceptionTranslator.java:110)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:72)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at org.springframework.jdbc.core.JdbcTemplate.translateException
> (JdbcTemplate.java:1443)
> at org.springframework.jdbc.core.JdbcTemplate.execute
> (JdbcTemplate.java:633)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:669)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:700)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:718)
> at
> org.apache.fineract.portfolio.interestratechart.service.InterestRateChartReadPlatformServiceImpl.retrieveAllWithSlabs
> (InterestRateChartReadPlatformServiceImpl.java:102)
> Caused by: java.sql.SQLException: Operation not allowed for a result set of
> type ResultSet.TYPE_FORWARD_ONLY.
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:129)
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:97)
> at
> com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException
> (SQLExceptionsMapping.java:122)
> at com.mysql.cj.jdbc.result.ResultSetImpl.previous
>
[jira] [Commented] (FINERACT-1049) Shares account delete gives 405
[ https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159307#comment-17159307 ] Natasha Natarajan commented on FINERACT-1049: - [~awasum], Thank you! I appreciate your feedback! > Shares account delete gives 405 > --- > > Key: FINERACT-1049 > URL: https://issues.apache.org/jira/browse/FINERACT-1049 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Karan >Assignee: Natasha Natarajan >Priority: Minor > Labels: beginner > Attachments: Screenshot from 2020-06-23 16-27-59.png, > screenshot(7).png, screenshot(8).png > > > Shares account delete support is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1091) PersistenceException: Field 'constitution_cv_id' doesn't have a default value
[
https://issues.apache.org/jira/browse/FINERACT-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159199#comment-17159199
]
Petri Tuomola commented on FINERACT-1091:
-
At first glance it looks like the validator in
ClientDataValidator.getDataValidationErrorsForCreateOnClientNonPerson() is
broken... it only complains if the constitution code value is incorrect, not if
it is missing altogether. It is mandatory at database level so a value should
be passed in...
> PersistenceException: Field 'constitution_cv_id' doesn't have a default value
> -
>
> Key: FINERACT-1091
> URL: https://issues.apache.org/jira/browse/FINERACT-1091
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Blocker
>
> See FINERACT-932 for general background; I've found this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat}org.apache.openjpa.persistence.PersistenceException: The
> transaction has been rolled back. See the nested exceptions for details on
> the errors that occurred.
> at
> org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignObjectId(StateManagerImpl.java:618)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignField(StateManagerImpl.java:705)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.beforeAccessField(StateManagerImpl.java:1750)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.accessingField(StateManagerImpl.java:1679)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.pcGetid(AbstractPersistableCustom.java)
> ~[app/:na]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.getId(AbstractPersistableCustom.java:50)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.address.service.AddressWritePlatformServiceImpl.addNewClientAddress(AddressWritePlatformServiceImpl.java:143)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:328)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke()
> ~[app/:na]
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> ~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$EnhancerBySpringCGLIB$$3e889443.createClient()
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler.processCommand(CreateClientCommandHandler.java:45)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler$$FastClassBySpringCGLIB$$6bce1ca9.invoke()
> ~[app/:na]
>
[jira] [Commented] (FINERACT-1089) Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in InterestRateChartReadPlatformServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159178#comment-17159178
]
Petri Tuomola commented on FINERACT-1089:
-
Looking at the code - hopefully fixing this should be just a matter of changing
the rs.previous() / while(rs.next()) in
InterestRateChartSlabExtractor.extractData() to use a do / while(rs.next())
instead...
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in
> InterestRateChartReadPlatformServiceImpl
> --
>
> Key: FINERACT-1089
> URL: https://issues.apache.org/jira/browse/FINERACT-1089
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Percy Ashu
>Priority: Blocker
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev, this seems to be a similar problem to that was
> previously fixed in FINERACT-995 and FINERACT-1061:
> {noformat}
> org.springframework.dao.TransientDataAccessResourceException:
> PreparedStatementCallback; SQL [select irc.id as ircId, irc.name as ircName,
> irc.description as ircDescription,irc.from_date as ircFromDate, irc.end_date
> as ircEndDate, irc.is_primary_grouping_by_amount as
> isPrimaryGroupingByAmount, ircd.id as ircdId, ircd.description as
> ircdDescription, ircd.period_type_enum ircdPeriodTypeId, ircd.from_period as
> ircdFromPeriod, ircd.to_period as ircdToPeriod, ircd.amount_range_from as
> ircdAmountRangeFrom, ircd.amount_range_to as ircdAmountRangeTo,
> ircd.annual_interest_rate as ircdAnnualInterestRate, curr.code as
> currencyCode, curr.name as currencyName, curr.internationalized_name_code as
> currencyNameCode, curr.display_symbol as currencyDisplaySymbol,
> curr.decimal_places as currencyDigits, curr.currency_multiplesof as
> inMultiplesOf, sp.id as savingsProductId, sp.name as savingsProductName,
> iri.id as iriId, iri.entiry_type as entityType, iri.attribute_name as
> attributeName , iri.condition_type as conditionType, iri.attribute_value as
> attributeValue, iri.incentive_type as incentiveType, iri.amount as amount,
> code.code_value as attributeValueDesc from m_interest_rate_chart irc left
> join m_interest_rate_slab ircd on irc.id=ircd.interest_rate_chart_id left
> join m_interest_incentives iri on iri.interest_rate_slab_id = ircd.id left
> join m_code_value code on code.id = iri.attribute_value left join m_currency
> curr on ircd.currency_code= curr.code left join
> m_deposit_product_interest_rate_chart dpirc on
> irc.id=dpirc.interest_rate_chart_id left join m_savings_product sp on
> sp.id=dpirc.deposit_product_id where sp.id = ? order by irc.id, CASE WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_from WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_to END,ircd.from_period,
> ircd.to_period,CASE WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_from WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_to END]; Operation not allowed for a result set of type
> ResultSet.TYPE_FORWARD_ONLY.; nested exception is java.sql.SQLException:
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
> at
> org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate
> (SQLStateSQLExceptionTranslator.java:110)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:72)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at org.springframework.jdbc.core.JdbcTemplate.translateException
> (JdbcTemplate.java:1443)
> at org.springframework.jdbc.core.JdbcTemplate.execute
> (JdbcTemplate.java:633)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:669)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:700)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:718)
> at
> org.apache.fineract.portfolio.interestratechart.service.InterestRateChartReadPlatformServiceImpl.retrieveAllWithSlabs
> (InterestRateChartReadPlatformServiceImpl.java:102)
> Caused by: java.sql.SQLException: Operation not allowed for a result set of
> type ResultSet.TYPE_FORWARD_ONLY.
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:129)
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:97)
> at
>
[jira] [Commented] (FINERACT-1091) PersistenceException: Field 'constitution_cv_id' doesn't have a default value
[
https://issues.apache.org/jira/browse/FINERACT-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159120#comment-17159120
]
Michael Vorburger commented on FINERACT-1091:
-
[~xurror] I remember you saying somewhere in FINERACT-849 or
[https://github.com/apache/fineract/pull/928] (I don't remember / can't find
anymore exactly where) that as part of your exploration of migrating from
OpenJPA to EclipseLink, you have fixed a few things which seemed real bugs that
EclipseLink pointed out because it was somehow more strict than OpenJPA? Was
this perhaps one of them? If you do, I highly encourage you to break those
fixes out of the overall (big) OpenJPA to EclipseLink migration, and submit
them as smaller PR specifically fixing bugs such as this. (And if this
"'constitution_cv_id" doesn't ring any bell, just ignore.)
> PersistenceException: Field 'constitution_cv_id' doesn't have a default value
> -
>
> Key: FINERACT-1091
> URL: https://issues.apache.org/jira/browse/FINERACT-1091
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Blocker
>
> See FINERACT-932 for general background; I've found this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat}org.apache.openjpa.persistence.PersistenceException: The
> transaction has been rolled back. See the nested exceptions for details on
> the errors that occurred.
> at
> org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignObjectId(StateManagerImpl.java:618)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignField(StateManagerImpl.java:705)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.beforeAccessField(StateManagerImpl.java:1750)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.accessingField(StateManagerImpl.java:1679)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.pcGetid(AbstractPersistableCustom.java)
> ~[app/:na]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.getId(AbstractPersistableCustom.java:50)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.address.service.AddressWritePlatformServiceImpl.addNewClientAddress(AddressWritePlatformServiceImpl.java:143)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:328)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke()
> ~[app/:na]
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> ~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
>
[jira] [Created] (FINERACT-1091) PersistenceException: Field 'constitution_cv_id' doesn't have a default value
Michael Vorburger created FINERACT-1091:
---
Summary: PersistenceException: Field 'constitution_cv_id' doesn't
have a default value
Key: FINERACT-1091
URL: https://issues.apache.org/jira/browse/FINERACT-1091
Project: Apache Fineract
Issue Type: Bug
Reporter: Michael Vorburger
See FINERACT-932 for general background; I've found this in logs of
[https://www.fineract.dev|https://www.fineract.dev/]:
{noformat}org.apache.openjpa.persistence.PersistenceException: The transaction
has been rolled back. See the nested exceptions for details on the errors that
occurred.
at
org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470)
~[openjpa-3.1.1.jar:3.1.1]
at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308)
~[openjpa-3.1.1.jar:3.1.1]
at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199)
~[openjpa-3.1.1.jar:3.1.1]
at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962)
~[openjpa-3.1.1.jar:3.1.1]
at
org.apache.openjpa.kernel.StateManagerImpl.assignObjectId(StateManagerImpl.java:618)
~[openjpa-3.1.1.jar:3.1.1]
at
org.apache.openjpa.kernel.StateManagerImpl.assignField(StateManagerImpl.java:705)
~[openjpa-3.1.1.jar:3.1.1]
at
org.apache.openjpa.kernel.StateManagerImpl.beforeAccessField(StateManagerImpl.java:1750)
~[openjpa-3.1.1.jar:3.1.1]
at
org.apache.openjpa.kernel.StateManagerImpl.accessingField(StateManagerImpl.java:1679)
~[openjpa-3.1.1.jar:3.1.1]
at
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.pcGetid(AbstractPersistableCustom.java)
~[app/:na]
at
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.getId(AbstractPersistableCustom.java:50)
~[app/:na]
at
org.apache.fineract.portfolio.address.service.AddressWritePlatformServiceImpl.addNewClientAddress(AddressWritePlatformServiceImpl.java:143)
~[app/:na]
at
org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:328)
~[app/:na]
at
org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke()
~[app/:na]
at
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366)
~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118)
~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$EnhancerBySpringCGLIB$$3e889443.createClient()
~[app/:na]
at
org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler.processCommand(CreateClientCommandHandler.java:45)
~[app/:na]
at
org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler$$FastClassBySpringCGLIB$$6bce1ca9.invoke()
~[app/:na]
at
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
at
[jira] [Updated] (FINERACT-1091) PersistenceException: Field 'constitution_cv_id' doesn't have a default value
[
https://issues.apache.org/jira/browse/FINERACT-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1091:
Priority: Blocker (was: Major)
> PersistenceException: Field 'constitution_cv_id' doesn't have a default value
> -
>
> Key: FINERACT-1091
> URL: https://issues.apache.org/jira/browse/FINERACT-1091
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Blocker
>
> See FINERACT-932 for general background; I've found this in logs of
> [https://www.fineract.dev|https://www.fineract.dev/]:
> {noformat}org.apache.openjpa.persistence.PersistenceException: The
> transaction has been rolled back. See the nested exceptions for details on
> the errors that occurred.
> at
> org.apache.openjpa.kernel.BrokerImpl.newFlushException(BrokerImpl.java:2470)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:2308)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flushSafe(BrokerImpl.java:2199)
> ~[openjpa-3.1.1.jar:3.1.1]
> at org.apache.openjpa.kernel.BrokerImpl.flush(BrokerImpl.java:1962)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignObjectId(StateManagerImpl.java:618)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.assignField(StateManagerImpl.java:705)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.beforeAccessField(StateManagerImpl.java:1750)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.openjpa.kernel.StateManagerImpl.accessingField(StateManagerImpl.java:1679)
> ~[openjpa-3.1.1.jar:3.1.1]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.pcGetid(AbstractPersistableCustom.java)
> ~[app/:na]
> at
> org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom.getId(AbstractPersistableCustom.java:50)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.address.service.AddressWritePlatformServiceImpl.addNewClientAddress(AddressWritePlatformServiceImpl.java:143)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:328)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke()
> ~[app/:na]
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> ~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118)
> ~[spring-tx-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> ~[spring-aop-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$EnhancerBySpringCGLIB$$3e889443.createClient()
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler.processCommand(CreateClientCommandHandler.java:45)
> ~[app/:na]
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler$$FastClassBySpringCGLIB$$6bce1ca9.invoke()
> ~[app/:na]
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> ~[spring-core-5.2.6.RELEASE.jar:5.2.6.RELEASE]
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
>
[jira] [Commented] (FINERACT-996) Fineract Java Client API library
[ https://issues.apache.org/jira/browse/FINERACT-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159104#comment-17159104 ] Michael Vorburger commented on FINERACT-996: My idea here was to possibly have a hand-written and maintained client lib based on Retrofit, but seeing how FINERACT-838 may actually finally move forward sooner rather than later, this issue may end up just being closed as a dupe of FINERACT-838... but let's still keep it open - for now, and see how FINERACT-838 evolves. > Fineract Java Client API library > > > Key: FINERACT-996 > URL: https://issues.apache.org/jira/browse/FINERACT-996 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Michael Vorburger >Priority: Minor > > It may be neat to have a Java Client API library for Fineract. > [https://square.github.io/retrofit/] is a nice way to build that (just > quickly hand hard-code!). > This could (should) live in a separate directory in > https://github.com/apache/fineract/. > Integration Tests could use this (instead of http://rest-assured.io). Future > scale tests could use this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-838) Swagger generated client libraries
[
https://issues.apache.org/jira/browse/FINERACT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159103#comment-17159103
]
Michael Vorburger commented on FINERACT-838:
[https://github.com/apache/fineract/commit/acca72f83d6772927b0406a0a4261509c93708dd]
https://github.com/Grandolf49/fineract-client
> Swagger generated client libraries
> --
>
> Key: FINERACT-838
> URL: https://issues.apache.org/jira/browse/FINERACT-838
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Priority: Major
>
> In the review discussion of the first Swagger PR
> https://github.com/apache/fineract/pull/629 (which got superseded by
> https://github.com/apache/fineract/pull/695), this came up:
> {quote}The other plugin org.hidetake.swagger.generator is used to generate
> code from the openAPI spec file using swagger-codegen. So this does not
> generate response.json. It rather uses response.json to generate client
> code.{quote}
> and {quote} think i had explained the usage of this in my gist
> https://gist.github.com/kangbreder/034f47e2e8015cee10b48b7c5f1b8df1,
> generating client libraries and language-specific SDKs in languages such as
> java and angular from swagger specification file. This was part of the goals
> of the project listed in
> https://mifosforge.jira.com/wiki/spaces/RES/pages/812810251/Google+Summer+of+Code+2019+Ideas.{quote}
> Having (Swagger automatically generate!) client libraries in Java (and even
> other languages?!) seems like a cool idea. It's also something that perhaps
> needs a bit more investigation than only adding the respective Gradle plugin.
> If we actually do do this, after having done all of the work in the other
> Sub Tasks, then I think we would have to include sample code in the repo
> building against the generated client libraries to test and illustrate their
> usage. We would also have to publish those client libraries, e.g. as
> downloadable JAR from the release page (or later even made available on Maven
> central). It would perhaps be clearest if there was another directory in the
> Fineract source tree, next to and outside of not inside, the
> fineract-provider (which is the "server") for this purpose.
> [~kangbreder] [~awasum] [~sanyam] ([~sanyam96] ?) FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1049) Shares account delete gives 405
[ https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159030#comment-17159030 ] Awasum Yannick commented on FINERACT-1049: -- [~natashan] I am happy you picked this up. Please don't sit and wait for notes from manthan. Just take a look at the issue with fresh eyes. Reproduce it locally and go ahead to provide a fix for it. [~Manthan], please next time have a discuss via email on the mailing list so that others will be able to gain context. Or discuss here. Videos calls should really be used sparingly in Open Source so that people don;t get lost. I think asynchronous onlist discussions is how Open Source has grown over the years. There are more beginner issues you can work on [~natashan]. See here: https://issues.apache.org/jira/browse/FINERACT-1076?jql=labels%20%3D%20beginner%20and%20project%20%3D%20%22Apache%20Fineract%22%20 > Shares account delete gives 405 > --- > > Key: FINERACT-1049 > URL: https://issues.apache.org/jira/browse/FINERACT-1049 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Karan >Assignee: Natasha Natarajan >Priority: Minor > Labels: beginner > Attachments: Screenshot from 2020-06-23 16-27-59.png, > screenshot(7).png, screenshot(8).png > > > Shares account delete support is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1049) Shares account delete gives 405
[ https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159015#comment-17159015 ] Natasha Natarajan commented on FINERACT-1049: - Ok, thanks, [~Manthan] can you share your notes from your discussion with Karan? > Shares account delete gives 405 > --- > > Key: FINERACT-1049 > URL: https://issues.apache.org/jira/browse/FINERACT-1049 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Karan >Assignee: Natasha Natarajan >Priority: Minor > Labels: beginner > Attachments: Screenshot from 2020-06-23 16-27-59.png, > screenshot(7).png, screenshot(8).png > > > Shares account delete support is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1049) Shares account delete gives 405
[ https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manthan Surkar reassigned FINERACT-1049: Assignee: Natasha Natarajan (was: Manthan Surkar) > Shares account delete gives 405 > --- > > Key: FINERACT-1049 > URL: https://issues.apache.org/jira/browse/FINERACT-1049 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Karan >Assignee: Natasha Natarajan >Priority: Minor > Labels: beginner > Attachments: Screenshot from 2020-06-23 16-27-59.png, > screenshot(7).png, screenshot(8).png > > > Shares account delete support is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1049) Shares account delete gives 405
[ https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159012#comment-17159012 ] Manthan Surkar commented on FINERACT-1049: -- Yes [~natashan] please take this, I am working on other issues and there is no point in delaying this. Assigning to you. > Shares account delete gives 405 > --- > > Key: FINERACT-1049 > URL: https://issues.apache.org/jira/browse/FINERACT-1049 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Karan >Assignee: Manthan Surkar >Priority: Minor > Labels: beginner > Attachments: Screenshot from 2020-06-23 16-27-59.png, > screenshot(7).png, screenshot(8).png > > > Shares account delete support is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1049) Shares account delete gives 405
[ https://issues.apache.org/jira/browse/FINERACT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159005#comment-17159005 ] Natasha Natarajan commented on FINERACT-1049: - [~vorburger] [~Manthan], has this one been resolved or should I look into this one this week? > Shares account delete gives 405 > --- > > Key: FINERACT-1049 > URL: https://issues.apache.org/jira/browse/FINERACT-1049 > Project: Apache Fineract > Issue Type: Bug > Components: Shares >Reporter: Karan >Assignee: Manthan Surkar >Priority: Minor > Labels: beginner > Attachments: Screenshot from 2020-06-23 16-27-59.png, > screenshot(7).png, screenshot(8).png > > > Shares account delete support is required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
