[jira] [Created] (FINCN-237) APIs for saving user's location Path

2020-08-03 Thread Ahmad Jawid Muhammadi (Jira)
Ahmad Jawid Muhammadi created FINCN-237:
---

 Summary: APIs for saving user's location Path
 Key: FINCN-237
 URL: https://issues.apache.org/jira/browse/FINCN-237
 Project: Fineract Cloud Native
  Issue Type: New Feature
  Components: fineract-cn-api
Reporter: Ahmad Jawid Muhammadi


In the *Fineract CN Mobile* application, I implemented a feature to save and 
track the user's location path in the sever so that we can show a list of 
visited customers. Here is the 
[link|[https://github.com/apache/fineract-cn-mobile/pull/110]] for the pull 
request but currently, the Fineract CN platform doesn't have any support for 
this feature. The JSON schema should look like this:

{

"user_id": "user_id1",

"client_name": "Ahmad Jawid",

"address": "Konark Pooram",

"geoPoint": [

{

"lat": "23.0003",

"lng": "49.0003"

},{

"lat": "23.0003",

"lng": "49.0003"

}],

"start_time": "1290390394932",

"stop_time": "1290390394932",

 "date": "12903903554432"

}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (FINERACT-1104) Adjust JPQL query in likelihood repository

2020-08-03 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser resolved FINERACT-1104.
---
Resolution: Fixed

> Adjust JPQL query in likelihood repository
> --
>
> Key: FINERACT-1104
> URL: https://issues.apache.org/jira/browse/FINERACT-1104
> Project: Apache Fineract
>  Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.JPQLException:  
> Exception Description: Problem compiling [select liklihood FROM Likelihood 
> liklihood WHERE ppi_name =:ppiName AND id <>:id].  
> [49, 57] The identification variable 'ppi_name' is not defined in the FROM 
> clause. 
> [73, 75] The identification variable 'id' is not defined in the FROM clause. 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.buildException(HermesParser.java:157)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.validate(HermesParser.java:349)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.populateQueryImp(HermesParser.java:280)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.buildQuery(HermesParser.java:165)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.buildEJBQLDatabaseQuery(EJBQueryImpl.java:142)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.buildEJBQLDatabaseQuery(EJBQueryImpl.java:118)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.(EJBQueryImpl.java:104)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.(EJBQueryImpl.java:88)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.createQuery(EntityManagerImpl.java:1749)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na]{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (FINERACT-1103) Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException

2020-08-03 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser resolved FINERACT-1103.
---
Resolution: Fixed

> Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
> --
>
> Key: FINERACT-1103
> URL: https://issues.apache.org/jira/browse/FINERACT-1103
> Project: Apache Fineract
>  Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.IntegrityException:  
> Descriptor Exceptions:  
> - 
>  
> Exception [EclipseLink-93] (Eclipse Persistence Services - 
> 2.7.7.v20200504-69f2c2b80d): 
> org.eclipse.persistence.exceptions.DescriptorException 
> Exception Description: The table [m_organisation_creditbureau] is not present 
> in this descriptor. 
> Descriptor: 
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
>  --> [DatabaseTable(m_creditbureau)]) 
>  
> Exception [EclipseLink-41] (Eclipse Persistence Services - 
> 2.7.7.v20200504-69f2c2b80d): 
> org.eclipse.persistence.exceptions.DescriptorException 
> Exception Description: A non-read-only mapping must be defined for the 
> sequence number field. 
> Descriptor: 
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
>  --> [DatabaseTable(m_creditbureau)]){code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1077) Migrate from legacy plugins applications to plugins DSL in build.gradle

2020-08-03 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser reassigned FINERACT-1077:
-

Assignee: (was: Yemdjih Kaze Nasser)

> Migrate from legacy plugins applications to plugins DSL in build.gradle
> ---
>
> Key: FINERACT-1077
> URL: https://issues.apache.org/jira/browse/FINERACT-1077
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Build
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Priority: Major
>
> We are still using the old way of applying gradle plugins in our 
> build.gradle. Today there is more convenient way of doing this which more and 
> more packages are using. This would make the build less cumbersome too and 
> plugins easier to maintain and apply.
> [https://docs.gradle.org/current/userguide/plugins.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1104) Adjust JPQL query in likelihood repository

2020-08-03 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser reassigned FINERACT-1104:
-

Assignee: Yemdjih Kaze Nasser

> Adjust JPQL query in likelihood repository
> --
>
> Key: FINERACT-1104
> URL: https://issues.apache.org/jira/browse/FINERACT-1104
> Project: Apache Fineract
>  Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.JPQLException:  
> Exception Description: Problem compiling [select liklihood FROM Likelihood 
> liklihood WHERE ppi_name =:ppiName AND id <>:id].  
> [49, 57] The identification variable 'ppi_name' is not defined in the FROM 
> clause. 
> [73, 75] The identification variable 'id' is not defined in the FROM clause. 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.buildException(HermesParser.java:157)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.validate(HermesParser.java:349)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.populateQueryImp(HermesParser.java:280)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.jpql.HermesParser.buildQuery(HermesParser.java:165)
>  ~[org.eclipse.persistence.core-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.buildEJBQLDatabaseQuery(EJBQueryImpl.java:142)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.buildEJBQLDatabaseQuery(EJBQueryImpl.java:118)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.(EJBQueryImpl.java:104)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EJBQueryImpl.(EJBQueryImpl.java:88)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
>     at 
> org.eclipse.persistence.internal.jpa.EntityManagerImpl.createQuery(EntityManagerImpl.java:1749)
>  ~[org.eclipse.persistence.jpa-2.7.7.jar:na]{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1103) Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException

2020-08-03 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser reassigned FINERACT-1103:
-

Assignee: Yemdjih Kaze Nasser

> Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
> --
>
> Key: FINERACT-1103
> URL: https://issues.apache.org/jira/browse/FINERACT-1103
> Project: Apache Fineract
>  Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.IntegrityException:  
> Descriptor Exceptions:  
> - 
>  
> Exception [EclipseLink-93] (Eclipse Persistence Services - 
> 2.7.7.v20200504-69f2c2b80d): 
> org.eclipse.persistence.exceptions.DescriptorException 
> Exception Description: The table [m_organisation_creditbureau] is not present 
> in this descriptor. 
> Descriptor: 
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
>  --> [DatabaseTable(m_creditbureau)]) 
>  
> Exception [EclipseLink-41] (Eclipse Persistence Services - 
> 2.7.7.v20200504-69f2c2b80d): 
> org.eclipse.persistence.exceptions.DescriptorException 
> Exception Description: A non-read-only mapping must be defined for the 
> sequence number field. 
> Descriptor: 
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
>  --> [DatabaseTable(m_creditbureau)]){code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1104) Adjust JPQL query in likelihood repository

2020-08-03 Thread Yemdjih Kaze Nasser (Jira)
Yemdjih Kaze Nasser created FINERACT-1104:
-

 Summary: Adjust JPQL query in likelihood repository
 Key: FINERACT-1104
 URL: https://issues.apache.org/jira/browse/FINERACT-1104
 Project: Apache Fineract
  Issue Type: Sub-task
Affects Versions: 1.4.0
Reporter: Yemdjih Kaze Nasser


{code:java}
Caused by: org.eclipse.persistence.exceptions.JPQLException:  
Exception Description: Problem compiling [select liklihood FROM Likelihood 
liklihood WHERE ppi_name =:ppiName AND id <>:id].  
[49, 57] The identification variable 'ppi_name' is not defined in the FROM 
clause. 
[73, 75] The identification variable 'id' is not defined in the FROM clause. 
    at 
org.eclipse.persistence.internal.jpa.jpql.HermesParser.buildException(HermesParser.java:157)
 ~[org.eclipse.persistence.core-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.jpql.HermesParser.validate(HermesParser.java:349)
 ~[org.eclipse.persistence.core-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.jpql.HermesParser.populateQueryImp(HermesParser.java:280)
 ~[org.eclipse.persistence.core-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.jpql.HermesParser.buildQuery(HermesParser.java:165)
 ~[org.eclipse.persistence.core-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.EJBQueryImpl.buildEJBQLDatabaseQuery(EJBQueryImpl.java:142)
 ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.EJBQueryImpl.buildEJBQLDatabaseQuery(EJBQueryImpl.java:118)
 ~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.EJBQueryImpl.(EJBQueryImpl.java:104) 
~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.EJBQueryImpl.(EJBQueryImpl.java:88) 
~[org.eclipse.persistence.jpa-2.7.7.jar:na] 
    at 
org.eclipse.persistence.internal.jpa.EntityManagerImpl.createQuery(EntityManagerImpl.java:1749)
 ~[org.eclipse.persistence.jpa-2.7.7.jar:na]{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1103) Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException

2020-08-03 Thread Yemdjih Kaze Nasser (Jira)
Yemdjih Kaze Nasser created FINERACT-1103:
-

 Summary: Resolve 
org.eclipse.persistence.exceptions.EntityManagerSetupException
 Key: FINERACT-1103
 URL: https://issues.apache.org/jira/browse/FINERACT-1103
 Project: Apache Fineract
  Issue Type: Sub-task
Affects Versions: 1.4.0
Reporter: Yemdjih Kaze Nasser


{code:java}
Caused by: org.eclipse.persistence.exceptions.IntegrityException:  
Descriptor Exceptions:  
- 
 
Exception [EclipseLink-93] (Eclipse Persistence Services - 
2.7.7.v20200504-69f2c2b80d): 
org.eclipse.persistence.exceptions.DescriptorException 
Exception Description: The table [m_organisation_creditbureau] is not present 
in this descriptor. 
Descriptor: 
RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
 --> [DatabaseTable(m_creditbureau)]) 
 
Exception [EclipseLink-41] (Eclipse Persistence Services - 
2.7.7.v20200504-69f2c2b80d): 
org.eclipse.persistence.exceptions.DescriptorException 
Exception Description: A non-read-only mapping must be defined for the sequence 
number field. 
Descriptor: 
RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
 --> [DatabaseTable(m_creditbureau)]){code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1102) Swagger Codegen Client JAR should be available on a Maven repo

2020-08-03 Thread Chinmay Kulkarni (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169816#comment-17169816
 ] 

Chinmay Kulkarni commented on FINERACT-1102:


Sounds great [~vorburger]. I'll look into JitPack for this

> Swagger Codegen Client JAR should be available on a Maven repo
> --
>
> Key: FINERACT-1102
> URL: https://issues.apache.org/jira/browse/FINERACT-1102
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
>
> FINERACT-838 contributed Swagger Codegen Client generation.
> In order for the JAR built from that to actually be easily usable, we should 
> "distribute" it...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1100) Swagger CodeGen WARN i.s.c.v.g.java.AbstractJavaCodegen - New (reserved word) cannot be used as model name. Renamed to ModelNew

2020-08-03 Thread Chinmay Kulkarni (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169814#comment-17169814
 ] 

Chinmay Kulkarni commented on FINERACT-1100:


Sure, I'll look into this. I'll post here if I find anything.

> Swagger CodeGen WARN  i.s.c.v.g.java.AbstractJavaCodegen - New (reserved 
> word) cannot be used as model name. Renamed to ModelNew
> 
>
> Key: FINERACT-1100
> URL: https://issues.apache.org/jira/browse/FINERACT-1100
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
>
> [https://travis-ci.org/github/apache/fineract/builds/714158191] for 
> [https://github.com/apache/fineract/pull/1228] for FINERACT-838 has this:
> {code:java}Task :generateSwaggerCodeFineract
> 12:52:44.707 [Thread-0] WARN  i.s.c.v.g.java.AbstractJavaCodegen - New 
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.722 [Thread-0] WARN  i.s.c.v.g.java.AbstractJavaCodegen - New 
> (reserved word) cannot be used as model name. Renamed to ModelNew
> <-> 33% EXECUTING [10s]> :generateSwaggerCodeFineractodel name. 
> Renamed to ModelNew
> 12:52:44.733 [Thread-0] WARN  i.s.c.v.g.java.AbstractJavaCodegen - New 
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.742 [Thread-0] WARN  i.s.c.v.g.java.AbstractJavaCodegen - New 
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.748 [Thread-0] WARN  i.s.c.v.g.java.AbstractJavaCodegen - New 
> (reserved word) cannot be used as model name. Renamed to ModelNew{code}
> I'm not sure what this means, and how easy it would be to address this? 
> [~Grandolf49] would you happen to know, or be willing to look into this, and 
> either raise a PR to addresss it, or document your findings here?
> [~Manthan] [~ptuomola] FYI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven

2020-08-03 Thread Chinmay Kulkarni (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169813#comment-17169813
 ] 

Chinmay Kulkarni commented on FINERACT-1101:


Actually, the generated code is expected to be built using *mvn*. The command 
*./gradlew build* in the generated code is used for building the library for 
Android. If you view *build.gradle* file in the generated code, you'll see the 
Android configuration there.

_"Using *{{../../gradlew build}}* instead of 
{{build/swagger-code-fineract/gradlew}} to use "our" (Fineract's) Gradle 
Wrapper instead of the one Swagger Client generated seems to be a workaround."_ 
I tried this locally and it seems to build the jar library correctly. Sure, 
this is a workaround but less likely to crack.

There is one more issue which I would like to mention here. Using *mvn clean 
package* to build the generated code DOES NOT work with Java 11. I tried to 
locate why this is happening. It turns out the generated code is using 
*org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar* which throws an 
error with Java 11.
{code:java}
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  04:18 min
[INFO] Finished at: 2020-08-03T13:29:34+05:30
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (attach-javadocs) on 
project client: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules 
but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in 
the unnamed module.
[ERROR] 
[ERROR] Command line was: /usr/lib/jvm/java-11-openjdk-amd64/bin/javadoc 
@options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/home/grandolf49/Desktop/GSoC 
20 @ The Mifos 
Initiative/grandolf-fineract/build/swagger-code-fineract/target/apidocs' dir.
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{code}
[https://stackoverflow.com/questions/58836862/jdk-11-and-javadoc] 

[https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8212233]

It builds successfully with Java 8. It also builds successfully with 
*maven-javadoc-plugin:3.2.0* and Java 11 but we manually have to edit the 
javadoc version which is not a solution.

So here is what we can do for now:
 # Update the Readme.md with instructions to use Fineract's Gradle Wrapper 
instead of generated code's gradle wrapper to build the library.
 # Figure out a way to ensure that the "Generated Code" can always be built 
with the Fineract's Gradle Wrapper.

I'll also file a request to [Swagger 
Codegen|https://github.com/swagger-api/swagger-codegen] to include a maven 
wrapper in the generated code and also ask them to update the maven-javadoc 
version to 3.2.0. If swagger codegen is updated with these changes, then 
everything will be good since we can simply use the maven wrapper thereafter.

 

[~vorburger] what are your thoughts on proceeding with this?

> Swagger CodeGen Test Build using Gradle instead of Maven
> 
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191] 
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've 
> noticed that the Swagger Client Code Generation seems  to be built using 
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the 
> use of Gradle. This seems inconsistent, and requiring Fineract developers to 
> have Maven installed just for this may be unnecessary? 
> [~Grandolf49] was there a particular reason why you chose to build the client 
> using Maven instead of Gradle on Travis in your PR? If none, would you be 
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven 
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven 
> artifacts in addition to Gradle to the Travis CI configuration, to make it a 
> bit faster.
> [~Manthan] [~ptuomola] FYI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-838) Swagger generated client libraries

2020-08-03 Thread Chinmay Kulkarni (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169747#comment-17169747
 ] 

Chinmay Kulkarni commented on FINERACT-838:
---

Sounds great [~vorburger]!
I will start working on FINERACT-1100  FINERACT-1101 and FINERACT-1102 
I think we should continue the discussion on these respective threads!

> Swagger generated client libraries
> --
>
> Key: FINERACT-838
> URL: https://issues.apache.org/jira/browse/FINERACT-838
> Project: Apache Fineract
>  Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
> Fix For: 1.4.0
>
>
> In the review discussion of the first Swagger PR 
> https://github.com/apache/fineract/pull/629 (which got superseded by 
> https://github.com/apache/fineract/pull/695), this came up:
> {quote}The other plugin org.hidetake.swagger.generator is used to generate 
> code from the openAPI spec file using swagger-codegen. So this does not 
> generate response.json. It rather uses response.json to generate client 
> code.{quote}
> and {quote} think i had explained the usage of this in my gist 
> https://gist.github.com/kangbreder/034f47e2e8015cee10b48b7c5f1b8df1, 
> generating client libraries and language-specific SDKs in languages such as 
> java and angular from swagger specification file. This was part of the goals 
> of the project listed in 
> https://mifosforge.jira.com/wiki/spaces/RES/pages/812810251/Google+Summer+of+Code+2019+Ideas.{quote}
> Having (Swagger automatically generate!) client libraries in Java (and even 
> other languages?!) seems like a cool idea. It's also something that perhaps 
> needs a bit more investigation than only adding the respective Gradle plugin. 
>  If we actually do do this, after having done all of the work in the other 
> Sub Tasks, then I think we would have to include sample code in the repo 
> building against the generated client libraries to test and illustrate their 
> usage.  We would also have to publish those client libraries, e.g. as 
> downloadable JAR from the release page (or later even made available on Maven 
> central). It would perhaps be clearest if there was another directory in the 
> Fineract source tree, next to and outside of not inside, the 
> fineract-provider (which is the "server") for this purpose.
> [~kangbreder] [~awasum] [~sanyam] ([~sanyam96] ?) FYI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)