[jira] [Commented] (FINERACT-1103) Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
[
https://issues.apache.org/jira/browse/FINERACT-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184940#comment-17184940
]
Yemdjih Kaze Nasser commented on FINERACT-1103:
---
Dropping that is fine cause the column exists on the other side of the
relationship.
> Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
> --
>
> Key: FINERACT-1103
> URL: https://issues.apache.org/jira/browse/FINERACT-1103
> Project: Apache Fineract
> Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.IntegrityException:
> Descriptor Exceptions:
> -
>
> Exception [EclipseLink-93] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: The table [m_organisation_creditbureau] is not present
> in this descriptor.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)])
>
> Exception [EclipseLink-41] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: A non-read-only mapping must be defined for the
> sequence number field.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)]){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-849) Migrate Fineract ORM from OpenJPA to EclipseLink
[ https://issues.apache.org/jira/browse/FINERACT-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184862#comment-17184862 ] Michael Vorburger commented on FINERACT-849: https://cwiki.apache.org/confluence/display/COMDEV/2020/07/28/Fineract+1.x+-+ORM+Migration+from+OpenJPA+to+EclipseLink > Migrate Fineract ORM from OpenJPA to EclipseLink > > > Key: FINERACT-849 > URL: https://issues.apache.org/jira/browse/FINERACT-849 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Ed Cable >Assignee: Yemdjih Kaze Nasser >Priority: Major > Labels: gsoc2020, hard, mentor, technical > Fix For: 1.5.0 > > > In line with the rationale for choosing EclipseLink as the ORM replacement > for Hibernate in FineractCN, we have broad consensus across the community to > swap out OpenJPA with EclipseLink. > OpenJPA seems to have reached its end of life with community activity > withering and the trade-offs between Hibernate and EclipseLink are much > lower. We also have community members who are migrating Fineract 1.x to > PostGreSQL and would benefit from the increased performance with EclipseLink. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-734) Credit Bureau Integration Phase 3
[ https://issues.apache.org/jira/browse/FINERACT-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-734: --- Fix Version/s: 1.5.0 > Credit Bureau Integration Phase 3 > - > > Key: FINERACT-734 > URL: https://issues.apache.org/jira/browse/FINERACT-734 > Project: Apache Fineract > Issue Type: Improvement > Components: Loan >Reporter: Nikhil Pawar >Assignee: Rahul Pawar >Priority: Major > Fix For: 1.5.0 > > > This Jira summarizes the work done for credit bureau integration Project. > Following were the prerequisites which were required for Credit Bureau > module, which have been implemented: > 1) Address Module > 2) Family Members module > > The idea was to allow the users to map different loans with different credit > bureaus and develop a generic framework which handles the request(to credit > bureau) and response (from credit bureau). > The mapping module which would enable mapping of credit bureau to loans also > has been developed and has screen support in UI. > What is required to be done: > Framework is to be developed, which would use the mapping (from mapping > module) and make request to required credit bureau. There are many ways to > achieve this : > One can use this mapping and form object using factory pattern. > Interface Request > implementation: > CBRequest1 , CBRequest2 > based on the mapping , we can set properties in the implementation and form > request. > > Similarly, we would need to have response module. Ideally this should be a > asynchronous service, which makes a request and then wait for response to > come in. However, this is an ideal scenario. It completely depends on the > credit bureaus architecture. Based on my experience, it is mostly an API > based model wherein you make a request to REST API and response comes in. So > in this case, we would have to develop request response as tightly coupled > modules, we make request, we get response and we parse it all in one flow. > [https://nikpawar89.github.io/] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1103) Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
[
https://issues.apache.org/jira/browse/FINERACT-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184861#comment-17184861
]
Michael Vorburger commented on FINERACT-1103:
-
[~xurror] I've noticed that you removed some @OneToMany
List in
https://github.com/apache/fineract/pull/1230/files .. shouldn't a clean up like
that lead to a SQL migration script dropping some column or join table kind of
thing?
> Resolve org.eclipse.persistence.exceptions.EntityManagerSetupException
> --
>
> Key: FINERACT-1103
> URL: https://issues.apache.org/jira/browse/FINERACT-1103
> Project: Apache Fineract
> Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Blocker
> Fix For: 1.4.0
>
>
> {code:java}
> Caused by: org.eclipse.persistence.exceptions.IntegrityException:
> Descriptor Exceptions:
> -
>
> Exception [EclipseLink-93] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: The table [m_organisation_creditbureau] is not present
> in this descriptor.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)])
>
> Exception [EclipseLink-41] (Eclipse Persistence Services -
> 2.7.7.v20200504-69f2c2b80d):
> org.eclipse.persistence.exceptions.DescriptorException
> Exception Description: A non-read-only mapping must be defined for the
> sequence number field.
> Descriptor:
> RelationalDescriptor(org.apache.fineract.infrastructure.creditbureau.domain.CreditBureau
> --> [DatabaseTable(m_creditbureau)]){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (FINERACT-746) Add/update swagger document for commands api's
[ https://issues.apache.org/jira/browse/FINERACT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger closed FINERACT-746. -- Resolution: Duplicate > Add/update swagger document for commands api's > -- > > Key: FINERACT-746 > URL: https://issues.apache.org/jira/browse/FINERACT-746 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > Fix For: 1.4.0 > > > Add documentation for remaining api's of commands module. > Update/correct existing documentation of commands module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-984) Postgres support
[ https://issues.apache.org/jira/browse/FINERACT-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184860#comment-17184860 ] Petri Tuomola commented on FINERACT-984: [~edcable] if they have already done the work, and are happy to share that with the community, then that would be great! > Postgres support > > > Key: FINERACT-984 > URL: https://issues.apache.org/jira/browse/FINERACT-984 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Michael Vorburger >Priority: Major > > [~ptuomola] in FINERACT-982 brought up if Fineract (non-CN) has looked at > Postgres support? > I'm not sure what the effort is, but someone motivated sure could try it out. > The Postgres JDBC driver is BSD licenses, which is fine for the ASF. > Personally I'd probably suggest "instead" not "in addition" to MySQL - but > that requires a data migration tool. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (FINERACT-746) Add/update swagger document for commands api's
[ https://issues.apache.org/jira/browse/FINERACT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reopened FINERACT-746: > Add/update swagger document for commands api's > -- > > Key: FINERACT-746 > URL: https://issues.apache.org/jira/browse/FINERACT-746 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Rahul Goel >Priority: Minor > Labels: fineract-swagger-doc > Fix For: 1.4.0 > > > Add documentation for remaining api's of commands module. > Update/correct existing documentation of commands module. > > Reference : Goal 3 : FINERACT-733 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-894) Scheduler Jobs Issue
[ https://issues.apache.org/jira/browse/FINERACT-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-894: --- Fix Version/s: (was: 1.1.0) > Scheduler Jobs Issue > > > Key: FINERACT-894 > URL: https://issues.apache.org/jira/browse/FINERACT-894 > Project: Apache Fineract > Issue Type: Bug > Components: Job Scheduler >Reporter: bharath gowda >Assignee: Nazeer Shaik >Priority: Critical > Attachments: Local Build Succes.png, Traivs Failure.png > > > Following Scheduler Jobs are failing for the below mentioned scenario > 1.Execute standing instruction Job > 2.Pay Due Saving charge > > Scenario: > if there is a single savings account with insufficient balance, then Job is > failing and not processing its tasks for rest of the loans as well in the > system. > > Expected behavior :Jobs should successfully execute it's task for all the > accounts and show the error message of accounts for which there was > insufficient amount. > > Steps to Reproduce > :For "Pay Due Saving charge" Job > 1.Create a Basic Savings account with deposit amount 1000 and add a monthly > charge of 5000. > 2.Create second savings account with deposit amount 1000 and add a monthly > charge of 500. > > then execute the "Pay Due Saving charge" Job, system should actually post the > charge for second saving account and through the error message for first > savings account. but system is not posting the charge for any of the loans. > > :For "Execute standing instruction Job" Job > 1.For client A - create a savings account with 100 balance, create a loan > with EMI of 1000 and add a standing instruction for the client to transfer > money from savings account to loan account on duedate. > > 2.For client B - create a savings account with 1000 balance, create a loan > with EMI of 1000 and add a standing instruction for the client to transfer > money from savings account to loan account on duedate. > then execute the "Execute standing instruction Job" Job, system should > actually post the transactions from savings to loan for client B and fail for > client A(due to insufficient fund) but as of the job is failing for both > clients. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-942) Make Checkstyle detect bad logging anti-patterns (and fix problems found)
[ https://issues.apache.org/jira/browse/FINERACT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-942. Resolution: Fixed > Make Checkstyle detect bad logging anti-patterns (and fix problems found) > - > > Key: FINERACT-942 > URL: https://issues.apache.org/jira/browse/FINERACT-942 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.4.0 > > > A particularly useful part of FINERACT-821, helping to detect real errors in > Fineract and not just formating, would be to enable the following in > fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that > this finds: > 1. RegexpSinglelineJava / printStackTrace > 2. IllegalCatch, IllegalThrows, MutableException, > AvoidHidingCauseExceptionCheck > 3. > [EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock] > Nota bene that we already have FINERACT-696, but this is complementary to > that. > One thing this should detect is e.g. the bad wrong emtpy > catch(MessagingException e) in EmailMessageJobEmailServiceImpl. > It may lead to more of FINERACT-932, which would be a Good Thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-942) Make Checkstyle detect bad logging anti-patterns (and fix problems found)
[ https://issues.apache.org/jira/browse/FINERACT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-942: --- Fix Version/s: (was: 1.5.0) 1.4.0 > Make Checkstyle detect bad logging anti-patterns (and fix problems found) > - > > Key: FINERACT-942 > URL: https://issues.apache.org/jira/browse/FINERACT-942 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.4.0 > > > A particularly useful part of FINERACT-821, helping to detect real errors in > Fineract and not just formating, would be to enable the following in > fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that > this finds: > 1. RegexpSinglelineJava / printStackTrace > 2. IllegalCatch, IllegalThrows, MutableException, > AvoidHidingCauseExceptionCheck > 3. > [EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock] > Nota bene that we already have FINERACT-696, but this is complementary to > that. > One thing this should detect is e.g. the bad wrong emtpy > catch(MessagingException e) in EmailMessageJobEmailServiceImpl. > It may lead to more of FINERACT-932, which would be a Good Thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1131) Add Checkstyle IllegalCatch
[ https://issues.apache.org/jira/browse/FINERACT-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1131: Fix Version/s: 1.5.0 > Add Checkstyle IllegalCatch > --- > > Key: FINERACT-1131 > URL: https://issues.apache.org/jira/browse/FINERACT-1131 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Minor > Fix For: 1.5.0 > > > Following up on FINERACT-942 for [~Manthan] to add > TypeParameterUnusedInFormals some time, if interested (so that we can close > FINERACT-942 for 1.4.0 now). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-942) Make Checkstyle detect bad logging anti-patterns (and fix problems found)
[ https://issues.apache.org/jira/browse/FINERACT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184845#comment-17184845 ] Michael Vorburger commented on FINERACT-942: FINERACT-1131 created re. IllegalCatch and resolving this for 1.4.0! > Make Checkstyle detect bad logging anti-patterns (and fix problems found) > - > > Key: FINERACT-942 > URL: https://issues.apache.org/jira/browse/FINERACT-942 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.5.0 > > > A particularly useful part of FINERACT-821, helping to detect real errors in > Fineract and not just formating, would be to enable the following in > fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that > this finds: > 1. RegexpSinglelineJava / printStackTrace > 2. IllegalCatch, IllegalThrows, MutableException, > AvoidHidingCauseExceptionCheck > 3. > [EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock] > Nota bene that we already have FINERACT-696, but this is complementary to > that. > One thing this should detect is e.g. the bad wrong emtpy > catch(MessagingException e) in EmailMessageJobEmailServiceImpl. > It may lead to more of FINERACT-932, which would be a Good Thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1131) Add Checkstyle IllegalCatch
Michael Vorburger created FINERACT-1131: --- Summary: Add Checkstyle IllegalCatch Key: FINERACT-1131 URL: https://issues.apache.org/jira/browse/FINERACT-1131 Project: Apache Fineract Issue Type: Improvement Reporter: Michael Vorburger Assignee: Manthan Surkar Following up on FINERACT-942 for [~Manthan] to add TypeParameterUnusedInFormals some time, if interested (so that we can close FINERACT-942 for 1.4.0 now). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-822. Resolution: Fixed > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Fix For: 1.4.0 > > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-822: --- Fix Version/s: (was: 1.5.0) 1.4.0 > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Fix For: 1.4.0 > > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184843#comment-17184843 ] Michael Vorburger commented on FINERACT-822: Similarly to e.g. FINERACT-733 et al, I think it's "unfair" to set Fix Version 1.5.0 for this. As (much!! wow, BIG THANKS [~Percy Ashu]) has gone into 1.4.0, let me change Fix Version back from 1.5.0 to 1.4.0, and close this as Resolved; FINERACT-1130 created for possible future follow-up re. TypeParameterUnusedInFormals. > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Fix For: 1.5.0 > > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1130) Add ErrorProne's TypeParameterUnusedInFormals
[ https://issues.apache.org/jira/browse/FINERACT-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1130: Priority: Minor (was: Major) > Add ErrorProne's TypeParameterUnusedInFormals > - > > Key: FINERACT-1130 > URL: https://issues.apache.org/jira/browse/FINERACT-1130 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Minor > Fix For: 1.5.0 > > > Following up on FINERACT-822 for [~Percy Ashu] to add > TypeParameterUnusedInFormals some time, if interested (so that we can close > FINERACT-822 for 1.4.0). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1130) Add ErrorProne's TypeParameterUnusedInFormals
Michael Vorburger created FINERACT-1130: --- Summary: Add ErrorProne's TypeParameterUnusedInFormals Key: FINERACT-1130 URL: https://issues.apache.org/jira/browse/FINERACT-1130 Project: Apache Fineract Issue Type: Improvement Reporter: Michael Vorburger Following up on FINERACT-822 for [~Percy Ashu] to add TypeParameterUnusedInFormals some time, if interested (so that we can close FINERACT-822 for 1.4.0). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1130) Add ErrorProne's TypeParameterUnusedInFormals
[ https://issues.apache.org/jira/browse/FINERACT-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-1130: --- Assignee: Percy Ashu > Add ErrorProne's TypeParameterUnusedInFormals > - > > Key: FINERACT-1130 > URL: https://issues.apache.org/jira/browse/FINERACT-1130 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > > Following up on FINERACT-822 for [~Percy Ashu] to add > TypeParameterUnusedInFormals some time, if interested (so that we can close > FINERACT-822 for 1.4.0). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1130) Add ErrorProne's TypeParameterUnusedInFormals
[ https://issues.apache.org/jira/browse/FINERACT-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1130: Fix Version/s: 1.5.0 > Add ErrorProne's TypeParameterUnusedInFormals > - > > Key: FINERACT-1130 > URL: https://issues.apache.org/jira/browse/FINERACT-1130 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Percy Ashu >Priority: Major > Fix For: 1.5.0 > > > Following up on FINERACT-822 for [~Percy Ashu] to add > TypeParameterUnusedInFormals some time, if interested (so that we can close > FINERACT-822 for 1.4.0). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-723) Integration tests fail when the default tenant has a different time-zone than the system(s) running the application and database servers
[
https://issues.apache.org/jira/browse/FINERACT-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-723:
---
Fix Version/s: (was: 1.5.0)
> Integration tests fail when the default tenant has a different time-zone than
> the system(s) running the application and database servers
>
>
> Key: FINERACT-723
> URL: https://issues.apache.org/jira/browse/FINERACT-723
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.1.0, 1.2.0, 1.3.0
>Reporter: Vishwas Babu A J
>Priority: Critical
> Labels: GSOC, GSoC, gsoc, gsoc2019, gsoc2020
>
> Each tenant in Fineract has its timezone configured in the `tenants` table
> under the `fineractplatform-tenants` schema and the application should
> consider the same while carrying out any date/time related operations. This
> does not seem to be done consistently in the application and intermittent
> errors can be seen when the Application (tomcat) and database servers (MySQL)
> are run on systems with different timezones than that of the tenant.
> Ex: Set the System timezone to "PDT". The default demo tenant is set to
> "Asia/Kolkata" and integration tests run on the same would fail
> intermittently.
> Fixing the same would involve
> * Ensuring that all dates created in the API / service layers are done in a
> tenant sensitive fashion by utilizing the methods present in the class
> org.apache.fineract.infrastructure.core.service.DateUtils.
> * Ensure database operations do not use MySQL date functions. Ex:
> {code:java}
> @Override
> public Collection
> retrieveChargesWithAnnualFeeDue() {
> final String sql = "select " + this.chargeDueMapper.schema() + "
> where sac.charge_due_date is not null and sac.charge_time_enum = ? "
> + " and sac.charge_due_date <= NOW() and sa.status_enum = ? ";
> return this.jdbcTemplate.query(sql, this.chargeDueMapper, new
> Object[] {ChargeTimeType.ANNUAL_FEE.getValue(),
> SavingsAccountStatusType.ACTIVE.getValue()});
> }{code}
> in
> org.apache.fineract.portfolio.savings.service.SavingsAccountChargeReadPlatformServiceImpl
> would cause issues with Timezones. We should be using something along the
> lines of
> {code:java}
> @Override
> public Collection
> retrieveChargesWithAnnualFeeDue() {
> String currentdate = formatter.print(DateUtils.getLocalDateOfTenant());
> final String sql = "select " + this.chargeDueMapper.schema() + " where
> sac.charge_due_date is not null and sac.charge_time_enum = ? and
> sac.charge_due_date <= ? and sa.status_enum ? ";
>
> return this.jdbcTemplate.query(sql, this.chargeDueMapper, new Object[]
> {currentdate, ChargeTimeType.ANNUAL_FEE.getValue(),
> SavingsAccountStatusType.ACTIVE.getValue()});
> }{code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1120) Two Factor Auth Filter Type Cast Error
[
https://issues.apache.org/jira/browse/FINERACT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1120:
Fix Version/s: (was: 1.5.0)
> Two Factor Auth Filter Type Cast Error
> --
>
> Key: FINERACT-1120
> URL: https://issues.apache.org/jira/browse/FINERACT-1120
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Saransh Sharma
>Priority: Major
>
> Error :
> java.lang.ClassCastException: class java.lang.String cannot be cast to class
> org.springframework.security.authentication.AnonymousAuthenticationToken
> {code:java}
> // AppUser user = (AppUser) authentication.getPrincipal();
> {code}
> This line has some type casting error exception when running the two factor
> mode.
> To enable two factor mode you need to run with -Psecurity=twofactor
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-935) StaffNotFoundException at StaffRepositoryWrapper
[
https://issues.apache.org/jira/browse/FINERACT-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-935:
---
Fix Version/s: (was: 1.5.0)
> StaffNotFoundException at StaffRepositoryWrapper
>
>
> Key: FINERACT-935
> URL: https://issues.apache.org/jira/browse/FINERACT-935
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Major
>
> See FINERACT-932 for general background, and determine if this error log can
> and should be "fixed", or if this represents a condition that shouldn't be
> logged as an error (or conclude that this is a totally valid error log that
> is useful, any why):
> {code}org.apache.fineract.organisation.staff.exception.StaffNotFoundException
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.lambda$findByOfficeHierarchyWithNotFoundDetection$1(StaffRepositoryWrapper.java:54)
> at java.util.Optional.orElseThrow(Optional.java:290)
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.findByOfficeHierarchyWithNotFoundDetection(StaffRepositoryWrapper.java:54)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:248)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke(){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1095) Remove direct sqlSearch support from /clients and all other APIs [Security & Performance]
[
https://issues.apache.org/jira/browse/FINERACT-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-1095:
---
Assignee: Manthan Surkar
> Remove direct sqlSearch support from /clients and all other APIs [Security &
> Performance]
> -
>
> Key: FINERACT-1095
> URL: https://issues.apache.org/jira/browse/FINERACT-1095
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Manthan Surkar
>Priority: Major
> Fix For: 1.5.0
>
>
> While code reviewing PRs from [~Manthan] such as
> [https://github.com/apache/fineract/pull/1171/files] and
> [https://github.com/apache/fineract/pull/1123/files] re. FINERACT-854, I've
> learnt about Fineract's support for an {{sqlSearch}} parameter on a number of
> its APIs, such as {{/clients}} (and others).
> According to
> [https://demo.fineract.dev/fineract-provider/api-docs/apiLive.htm] :
> {quote}_sqlSearch
> String optional
> Use an sql fragment valid for the underlying client schema to filter
> results. e.g. display_name like %K%
> {quote}
> [https://github.com/apache/fineract/search?p=2=sqlSearch_q=sqlSearch]
> shows all current occurrences. There are a number, but not THAT many either.
> (By far not every API supports this, only a handful.)
> This can be used e.g. like this:
> [https://demo.fineract.dev/fineract-provider/api/v1/clients?paged=true=c.account_no=3=default]
> To me, this is an egregious violation of "layering architecture". Basically,
> the REST API gives you direct SQL database access! You apparently have to
> know the exact name of not the SQL table but the alias used in the respective
> internally hard-coded query (note the use of {{c.}} in the example above, NOT
> {{m_client}}), and the internal SQL column name (note the use of
> {{account_no}}, NOT {{accountNo}}). There is no real documentation how to use
> this, and even if there were, in my tests I've noticed its fairly easy to
> provoke _500 Internal Server Errors_ when using {{sqlSearch}} with a slightly
> wrong syntax.
> From a security point of view, it's not quite as bad as it looks, because
> there is code with heuristics to "validate" the {{sqlSearch}} and prevent SQL
> Injections. But that could have holes (I don't want to know!), so... this
> still isn't great, at all, IMHO.
> From a performance point of view, permitting clients to run arbitrary queries
> isn't great either. You can't really reliable offer performance guarantees,
> or offer tuning with indices, if at the end of the day the wide open API just
> lets a client "query whatever they want" anyway.
> Use of {{sqlSearch}} by (public) API clients isn't that hard to find. I did
> some digging, and:
> * The new web-app UI doesn't use sqlSearch (or not yet), see
> [https://github.com/openMF/web-app/search?q=sqlSearch_q=sqlSearch]
> * The old community-app UI does use sqlSearch, see
> [https://github.com/openMF/community-app/search?p=1=sqlSearch_q=sqlSearch].
> But only in 2 very specific places, for Loans' {{l.loan_status_id in
> (100,200)}} and Clients' {{c.status_enum=100}}. This was apparently
> introduced by [~vishwasbabu] in
> [https://github.com/openMF/community-app/pull/1582|https://github.com/openMF/community-app/pull/1582/files]
> for [MIFOSX-2712.|https://mifosforge.jira.com/browse/MIFOSX-2712.] It's
> noteworthy that the Find on
> [https://cui.fineract.dev/.../clients|https://cui.fineract.dev/?baseApiUrl=https://demo.fineract.dev=default#/clients]
> does NOT use {{sqlSearch}} but the [/search
> API|https://demo.fineract.dev/fineract-provider/api-docs/apiLive.htm#search]
> * other repos on openMF, such as Mobile Apps & Co, don't realy seem to
> actively use {{sqlSearch}}, looking at
> [https://github.com/search?p=7=org%3AopenMF+sqlSearch=Code]
> Other than that, I don't know if anyone actively using {{sqlSearch}} would
> have any major objections to... just simply altogether removing this
> entirely? Folks may of course be using this in their own client UIs, but...
> they really shouldn't, this is a "bad" API. If you are missing a query
> facility, just contribute to the upstream project and raise a pull request to
> add whatever query option you are missing to whatever Fineract API (such as
> e.g. by status for Loans and Clients).
> Let's further discuss on the developer mailing list on thread "Use of
> sqlSearch argument in Groups/Clients List" if anyone wants to strongly defend
> {{sqlSearch}}. If not, let's just completely remove it. We do have to first
> replace the small current use in the community-app.
> PS: Nota bene that this issue isn't stating that a REST API with query
> capabilities is bad per se. The point here is that
[jira] [Updated] (FINERACT-1031) CLONE - Advanced accounting for fees not working
[ https://issues.apache.org/jira/browse/FINERACT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1031: Fix Version/s: (was: 1.5.0) > CLONE - Advanced accounting for fees not working > - > > Key: FINERACT-1031 > URL: https://issues.apache.org/jira/browse/FINERACT-1031 > Project: Apache Fineract > Issue Type: Bug > Components: Accounting, Loan >Affects Versions: 1.1.0 >Reporter: bharath gowda >Priority: Major > Labels: gsoc, p1 > Attachments: 1.png, 2.png, 3.png, image-2020-06-14-22-19-54-702.png > > > //Resurfaced Issue // > Deepak's description in mailing list: > > I was to map the different accounting GLs for different Fees. I mapped the > GLs to the respective fees. PFA the screenshot. But still in accounting, the > entry has gone to the single GL > https: demo.openmf.org > username: mifos > password: password > > Loan ID: depk02980 > Product Name: deepak -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1057) Running -Psecurity=oauth leads to memory leak issue
[ https://issues.apache.org/jira/browse/FINERACT-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1057: Fix Version/s: (was: 1.5.0) > Running -Psecurity=oauth leads to memory leak issue > > > Key: FINERACT-1057 > URL: https://issues.apache.org/jira/browse/FINERACT-1057 > Project: Apache Fineract > Issue Type: Bug >Reporter: Saransh Sharma >Priority: Major > > When running -Psecurity=oauth > JAX_API thrown hikari data pool memory leak issue > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-936) PlatformApiDataValidationException at ClientDataValidator
[
https://issues.apache.org/jira/browse/FINERACT-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-936:
---
Fix Version/s: (was: 1.5.0)
> PlatformApiDataValidationException at ClientDataValidator
> -
>
> Key: FINERACT-936
> URL: https://issues.apache.org/jira/browse/FINERACT-936
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Priority: Major
>
> See FINERACT-932 for general background, and determine if this error log can
> and should be "fixed", or if this represents a condition that shouldn't be
> logged as an error (or conclude that this is a totally valid error log that
> is useful, any why):
> {code}
> org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException
> at
> org.apache.fineract.portfolio.client.data.ClientDataValidator.throwExceptionIfValidationWarningsExist(ClientDataValidator.java:584)
> at
> org.apache.fineract.portfolio.client.data.ClientDataValidator.validateForCreate(ClientDataValidator.java:231)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:224)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke(){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-934) DatatableEntryRequiredException at EntityDatatableChecksWritePlatformServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-934:
---
Fix Version/s: (was: 1.5.0)
> DatatableEntryRequiredException at
> EntityDatatableChecksWritePlatformServiceImpl
>
>
> Key: FINERACT-934
> URL: https://issues.apache.org/jira/browse/FINERACT-934
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Priority: Major
>
> See FINERACT-932 for general background, and determine if this error log can
> and should be "fixed", or if this represents a condition that shouldn't be
> logged as an error (or conclude that this is a totally valid error log that
> is useful, any why):
> {code}org.apache.fineract.infrastructure.dataqueries.exception.DatatableEntryRequiredException
> at
> org.apache.fineract.infrastructure.dataqueries.service.EntityDatatableChecksWritePlatformServiceImpl.runTheCheck(EntityDatatableChecksWritePlatformServiceImpl.java:171)
> at
> org.apache.fineract.infrastructure.dataqueries.service.EntityDatatableChecksWritePlatformServiceImpl$$FastClassBySpringCGLIB$$6ff37.invoke()
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:685)
> at
> org.apache.fineract.infrastructure.dataqueries.service.EntityDatatableChecksWritePlatformServiceImpl$$EnhancerBySpringCGLIB$$26a5be4e.runTheCheck()
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:344)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke()
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:769)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:99)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$EnhancerBySpringCGLIB$$b47f0026.createClient()
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler.processCommand(CreateClientCommandHandler.java:45)
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler$$FastClassBySpringCGLIB$$6bce1ca9.invoke()
> at
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:769)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:99)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
> at
> org.apache.fineract.portfolio.client.handler.CreateClientCommandHandler$$EnhancerBySpringCGLIB$$d8180de4.processCommand()
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.processAndLogCommand(SynchronousCommandProcessingService.java:82)
> at
>
[jira] [Updated] (FINERACT-1012) Spring Security OAuth 2.x to Spring Security 5.2.x
[
https://issues.apache.org/jira/browse/FINERACT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1012:
Affects Version/s: (was: 1.5.0)
1.4.0
> Spring Security OAuth 2.x to Spring Security 5.2.x
> --
>
> Key: FINERACT-1012
> URL: https://issues.apache.org/jira/browse/FINERACT-1012
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Saransh Sharma
>Priority: Critical
> Labels: beginner
> Fix For: 1.5.0
>
>
> The bump of spring-security-oauth2 from 2.3.6.RELEASE to 2.4.1.RELEASE in
> https://github.com/apache/fineract/pull/863 as part of FINERACT-963
> introduced usage of {{@Deprecated}} code, which we are trying to avoid (and
> which since FINERACT-959 we're intentionally making the build fail).
> I'm going to use a {{@SuppressWarnings("deprecation")}} to be able to do the
> upgrade anyway, because upgrading a security related library to its latest
> version seems like a sensible thing to do, but we really should remove the
> suppression and switch to using Spring's newer APIs.
> https://github.com/spring-projects/spring-security/wiki/OAuth-2.0-Migration-Guide
> affects {{UserDetailsApiResource}} and
> {{TwoFactorAuthenticationFilter.createUpdatedAuthentication()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-932) Parent Issue for Error Logs seeing during "normal" usage (e.g. on fineract.dev)
[ https://issues.apache.org/jira/browse/FINERACT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-932: --- Fix Version/s: (was: 1.5.0) > Parent Issue for Error Logs seeing during "normal" usage (e.g. on > fineract.dev) > --- > > Key: FINERACT-932 > URL: https://issues.apache.org/jira/browse/FINERACT-932 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Michael Vorburger >Assignee: Michael Vorburger >Priority: Blocker > > I'm seeing a number of exceptions in the logs of > [https://www.fineract.dev|https://www.fineract.dev/], and at least some if > not most of them, to me, seem like things that probably should not be logged > as errors. > IMHO, a log.error() should only be used to indicate something "broken" (e.g. > can't connect to a database), but not, typically, for something like a > missing field problem in an incoming JSON? That's "normal", and already > signaled to th e client through an expected response. An "operator" can't > typically "do something" about those kinds of errors. > We can also think of some special cases, e.g. the log.error we currently for > FINERACT-726, which may be useful to help people more easily see that > widespread problem, during transitioning. But perhaps log warn or even info > instead of error would be more appropriate than error for such things? > Perhaps what I'm outlining here should be documented on the README in a > (succinct) "Log Policy" kind of section? > I'll create dedicated linked issues for each such exception I'm seeing, for > analysis by others interested. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-891) ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)
[
https://issues.apache.org/jira/browse/FINERACT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-891:
---
Fix Version/s: (was: 1.5.0)
> ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH
> >= 22)
> --
>
> Key: FINERACT-891
> URL: https://issues.apache.org/jira/browse/FINERACT-891
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Trivial
>
> while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed
> that in it has x2 Dead Code due to {{if (Calendar.DAY_OF_MONTH >= 22)}} ...
> that will always be false. I'm guessing that has was meant to check ... I'm
> not sure, presumably the transactionDate? That doesn't really make much sense
> either, as that's hard-coded to {{transactionDate.set(Calendar.DAY_OF_MONTH,
> 22);}} just 2 lines above.
> Someone who better understands what that test does should probably review it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-891) ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)
[
https://issues.apache.org/jira/browse/FINERACT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-891:
---
Labels: beginner (was: )
> ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH
> >= 22)
> --
>
> Key: FINERACT-891
> URL: https://issues.apache.org/jira/browse/FINERACT-891
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Trivial
> Labels: beginner
>
> while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed
> that in it has x2 Dead Code due to {{if (Calendar.DAY_OF_MONTH >= 22)}} ...
> that will always be false. I'm guessing that has was meant to check ... I'm
> not sure, presumably the transactionDate? That doesn't really make much sense
> either, as that's hard-coded to {{transactionDate.set(Calendar.DAY_OF_MONTH,
> 22);}} just 2 lines above.
> Someone who better understands what that test does should probably review it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-931) Test and Document Spring "hot" reloading for development
[ https://issues.apache.org/jira/browse/FINERACT-931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-931: --- Labels: beginner technical (was: technical) > Test and Document Spring "hot" reloading for development > > > Key: FINERACT-931 > URL: https://issues.apache.org/jira/browse/FINERACT-931 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Critical > Labels: beginner, technical > Fix For: 1.5.0 > > > FINERACT-730 unlocks the Spring Framework's "hot" reloading for development. > We should test that, and document it in the README. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-931) Test and Document Spring "hot" reloading for development
[ https://issues.apache.org/jira/browse/FINERACT-931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-931: --- Fix Version/s: (was: 1.5.0) > Test and Document Spring "hot" reloading for development > > > Key: FINERACT-931 > URL: https://issues.apache.org/jira/browse/FINERACT-931 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Critical > Labels: beginner, technical > > FINERACT-730 unlocks the Spring Framework's "hot" reloading for development. > We should test that, and document it in the README. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-821) Enable and enforce (!) Checkstyle in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-821. Resolution: Fixed > Enable and enforce (!) Checkstyle in Fineract > - > > Key: FINERACT-821 > URL: https://issues.apache.org/jira/browse/FINERACT-821 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > as suggested in FINERACT-712, we really should enable Checkstyle in Fineract. > My past experience in such matters, confirmed by FINERACT-702, is that these > things only ever work and have a lasting effect if you bulk fix all > violations and switch on enforcement. If you only report, it's mostly useless. > As for specific Checkstyle rules, I have spent a fair amount of time in a > past life on a project (which I'm currently no longer actively invoved in) to > refine a what I believe to be "good" Checkstyle rule set, we could reuse this > for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-821) Enable and enforce (!) Checkstyle in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184832#comment-17184832 ] Michael Vorburger commented on FINERACT-821: [~aleks] similar to FINERACT-733, let's close this for 1.4.0 instead of keeping it open for 1.5.0; MUCH work happened here, and this should show up on 1.4.0 Release Notes. [~Manthan] if you had planned any more more re. this, please create separate new JIRA issues, and link them as Related to this one. > Enable and enforce (!) Checkstyle in Fineract > - > > Key: FINERACT-821 > URL: https://issues.apache.org/jira/browse/FINERACT-821 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.5.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > as suggested in FINERACT-712, we really should enable Checkstyle in Fineract. > My past experience in such matters, confirmed by FINERACT-702, is that these > things only ever work and have a lasting effect if you bulk fix all > violations and switch on enforcement. If you only report, it's mostly useless. > As for specific Checkstyle rules, I have spent a fair amount of time in a > past life on a project (which I'm currently no longer actively invoved in) to > refine a what I believe to be "good" Checkstyle rule set, we could reuse this > for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-821) Enable and enforce (!) Checkstyle in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-821: --- Fix Version/s: (was: 1.5.0) 1.4.0 > Enable and enforce (!) Checkstyle in Fineract > - > > Key: FINERACT-821 > URL: https://issues.apache.org/jira/browse/FINERACT-821 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > as suggested in FINERACT-712, we really should enable Checkstyle in Fineract. > My past experience in such matters, confirmed by FINERACT-702, is that these > things only ever work and have a lasting effect if you bulk fix all > violations and switch on enforcement. If you only report, it's mostly useless. > As for specific Checkstyle rules, I have spent a fair amount of time in a > past life on a project (which I'm currently no longer actively invoved in) to > refine a what I believe to be "good" Checkstyle rule set, we could reuse this > for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-733) Swagger Documentation for Fineract API's
[ https://issues.apache.org/jira/browse/FINERACT-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184828#comment-17184828 ] Michael Vorburger commented on FINERACT-733: [~aleks] let's see the Fix Version of this back to 1.4.0, and consider it resolved - as (much!!) work on this topic went into that release. I've moved all open pending sub-tasks to separate JIRA issues, and linked them as Related To here. That way, they can each be independently scheduled for future releases. (You can apply the same pattern for other issues.) > Swagger Documentation for Fineract API's > > > Key: FINERACT-733 > URL: https://issues.apache.org/jira/browse/FINERACT-733 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Assignee: Michael Vorburger >Priority: Major > Labels: gsoc2019 > Fix For: 1.5.0 > > Attachments: Screen Shot 2019-03-17 at 3.59.23 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > The original documentation for Fineract is at > [https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm.] This > documentation was handcrafted to meet the following goals > # Provide a detailed overview of the API design and common options (under > "Overview" section of the top Navbar at > [https://demo.openmf.org/api-docs/apiLive.htm|https://demo.openmf.org/api-docs/apiLive.htm#loans]) > # Help consumers to easily visualize related API's to quickly determine the > scope of functionality supported by the system ( Ex: links to all loan > related API's consolidated under the "Loan" section of the navbar) > # For each entity in the system, provide a meaningful description of what > the entity represents in the real world (Ex: > [https://demo.openmf.org/api-docs/apiLive.htm#glaccounts] ) > # For common fields associated with an entity, provide a meaningful > description of what they represent and how they are to be used (Ex: > [https://demo.openmf.org/api-docs/apiLive.htm#loans] , see the description > and detailed explanation of fields like transactionProcessingStrategyId ) > # Provide a detailed overview of the functionality supported by each API > call (especially when their usage is not obvious, see the detailed > documentation for Batch API's at > [https://demo.openmf.org/api-docs/apiLive.htm#batch_api] ) > # Provide examples of sample requests and responses for each API call > However, this documentation suffered a major drawback, i.e all of it was > handwritten and was difficult for new committers to add to and maintain. It > was also preferable that users be allowed to try out all API's from the > documentation itself, which wasn't an option. > The newly added Swagger documentation aims to address these concerns. The > current status of the same and the work needed to meet the goals of the > original documentation is described below > > *Goal 1* > The swagger docs rely on the existing API docs through hyperlinks for the > entire overview section. To make the swagger docs the single source of truth > for API documentation, the existing docs need to be deprecated. For doing the > same, this entire section needs to be copied over to the swagger UI (and well > formatted) and all references to the older docs removed. ** > *Goal 2* > All API's are currently listed in a random order and someone new to the > system cannot comprehend relationships between them. The home page needs to > be improved with either a sidebar or a navbar (similar to the one in the > existing documentation) which groups together related API's and provides > hyperlinks to their swagger documentation > *Goal 3* > While entity descriptions seem to be present in the codebase (Ex: > https://github.com/apache/fineract/blob/201cbf82f67f7a623b8c38bf9465f4af79791c20/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountsApiResource.java#L76), > they aren't reflected in the generated documentation. This is likely because > the description field is deprecated, see discussion at > [https://github.com/swagger-api/swagger-core/issues/1476.] > It would be nice if this description was well formatted too. > *Goal 4* > Taking [https://demo.openmf.org/api-docs/apiLive.htm#loans] as an example, > the details and descriptions of fields like "transactionProcessingStrategyId" > are not carried over. Without this information, an API consumer would not > understand what each of these (non-obvious) fields mean and how they are to > be used. > *Goal 5* > The amount of information present for an API like > [https://demo.openmf.org/api-docs/apiLive.htm#batch_api] is significantly > more than that of the equivalent API in Swagger (detailed description, > possible errors, command strategies supported
[jira] [Resolved] (FINERACT-733) Swagger Documentation for Fineract API's
[ https://issues.apache.org/jira/browse/FINERACT-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-733. Resolution: Fixed > Swagger Documentation for Fineract API's > > > Key: FINERACT-733 > URL: https://issues.apache.org/jira/browse/FINERACT-733 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Assignee: Michael Vorburger >Priority: Major > Labels: gsoc2019 > Fix For: 1.4.0 > > Attachments: Screen Shot 2019-03-17 at 3.59.23 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > The original documentation for Fineract is at > [https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm.] This > documentation was handcrafted to meet the following goals > # Provide a detailed overview of the API design and common options (under > "Overview" section of the top Navbar at > [https://demo.openmf.org/api-docs/apiLive.htm|https://demo.openmf.org/api-docs/apiLive.htm#loans]) > # Help consumers to easily visualize related API's to quickly determine the > scope of functionality supported by the system ( Ex: links to all loan > related API's consolidated under the "Loan" section of the navbar) > # For each entity in the system, provide a meaningful description of what > the entity represents in the real world (Ex: > [https://demo.openmf.org/api-docs/apiLive.htm#glaccounts] ) > # For common fields associated with an entity, provide a meaningful > description of what they represent and how they are to be used (Ex: > [https://demo.openmf.org/api-docs/apiLive.htm#loans] , see the description > and detailed explanation of fields like transactionProcessingStrategyId ) > # Provide a detailed overview of the functionality supported by each API > call (especially when their usage is not obvious, see the detailed > documentation for Batch API's at > [https://demo.openmf.org/api-docs/apiLive.htm#batch_api] ) > # Provide examples of sample requests and responses for each API call > However, this documentation suffered a major drawback, i.e all of it was > handwritten and was difficult for new committers to add to and maintain. It > was also preferable that users be allowed to try out all API's from the > documentation itself, which wasn't an option. > The newly added Swagger documentation aims to address these concerns. The > current status of the same and the work needed to meet the goals of the > original documentation is described below > > *Goal 1* > The swagger docs rely on the existing API docs through hyperlinks for the > entire overview section. To make the swagger docs the single source of truth > for API documentation, the existing docs need to be deprecated. For doing the > same, this entire section needs to be copied over to the swagger UI (and well > formatted) and all references to the older docs removed. ** > *Goal 2* > All API's are currently listed in a random order and someone new to the > system cannot comprehend relationships between them. The home page needs to > be improved with either a sidebar or a navbar (similar to the one in the > existing documentation) which groups together related API's and provides > hyperlinks to their swagger documentation > *Goal 3* > While entity descriptions seem to be present in the codebase (Ex: > https://github.com/apache/fineract/blob/201cbf82f67f7a623b8c38bf9465f4af79791c20/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountsApiResource.java#L76), > they aren't reflected in the generated documentation. This is likely because > the description field is deprecated, see discussion at > [https://github.com/swagger-api/swagger-core/issues/1476.] > It would be nice if this description was well formatted too. > *Goal 4* > Taking [https://demo.openmf.org/api-docs/apiLive.htm#loans] as an example, > the details and descriptions of fields like "transactionProcessingStrategyId" > are not carried over. Without this information, an API consumer would not > understand what each of these (non-obvious) fields mean and how they are to > be used. > *Goal 5* > The amount of information present for an API like > [https://demo.openmf.org/api-docs/apiLive.htm#batch_api] is significantly > more than that of the equivalent API in Swagger (detailed description, > possible errors, command strategies supported etc). We would need to go > through each API to ensure that all information is migrated. > Here's a screenshot of another commonly used API for updating loan statuses > from swagger docs. > !Screen Shot 2019-03-17 at 3.59.23 AM.png|width=807,height=519! > Issues here > * Details of actual commands supported (approve, reject) are missing > * Lack of formatting makes it hard to
[jira] [Updated] (FINERACT-733) Swagger Documentation for Fineract API's
[ https://issues.apache.org/jira/browse/FINERACT-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-733: --- Fix Version/s: (was: 1.5.0) 1.4.0 > Swagger Documentation for Fineract API's > > > Key: FINERACT-733 > URL: https://issues.apache.org/jira/browse/FINERACT-733 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Assignee: Michael Vorburger >Priority: Major > Labels: gsoc2019 > Fix For: 1.4.0 > > Attachments: Screen Shot 2019-03-17 at 3.59.23 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > > The original documentation for Fineract is at > [https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm.] This > documentation was handcrafted to meet the following goals > # Provide a detailed overview of the API design and common options (under > "Overview" section of the top Navbar at > [https://demo.openmf.org/api-docs/apiLive.htm|https://demo.openmf.org/api-docs/apiLive.htm#loans]) > # Help consumers to easily visualize related API's to quickly determine the > scope of functionality supported by the system ( Ex: links to all loan > related API's consolidated under the "Loan" section of the navbar) > # For each entity in the system, provide a meaningful description of what > the entity represents in the real world (Ex: > [https://demo.openmf.org/api-docs/apiLive.htm#glaccounts] ) > # For common fields associated with an entity, provide a meaningful > description of what they represent and how they are to be used (Ex: > [https://demo.openmf.org/api-docs/apiLive.htm#loans] , see the description > and detailed explanation of fields like transactionProcessingStrategyId ) > # Provide a detailed overview of the functionality supported by each API > call (especially when their usage is not obvious, see the detailed > documentation for Batch API's at > [https://demo.openmf.org/api-docs/apiLive.htm#batch_api] ) > # Provide examples of sample requests and responses for each API call > However, this documentation suffered a major drawback, i.e all of it was > handwritten and was difficult for new committers to add to and maintain. It > was also preferable that users be allowed to try out all API's from the > documentation itself, which wasn't an option. > The newly added Swagger documentation aims to address these concerns. The > current status of the same and the work needed to meet the goals of the > original documentation is described below > > *Goal 1* > The swagger docs rely on the existing API docs through hyperlinks for the > entire overview section. To make the swagger docs the single source of truth > for API documentation, the existing docs need to be deprecated. For doing the > same, this entire section needs to be copied over to the swagger UI (and well > formatted) and all references to the older docs removed. ** > *Goal 2* > All API's are currently listed in a random order and someone new to the > system cannot comprehend relationships between them. The home page needs to > be improved with either a sidebar or a navbar (similar to the one in the > existing documentation) which groups together related API's and provides > hyperlinks to their swagger documentation > *Goal 3* > While entity descriptions seem to be present in the codebase (Ex: > https://github.com/apache/fineract/blob/201cbf82f67f7a623b8c38bf9465f4af79791c20/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/api/SavingsAccountsApiResource.java#L76), > they aren't reflected in the generated documentation. This is likely because > the description field is deprecated, see discussion at > [https://github.com/swagger-api/swagger-core/issues/1476.] > It would be nice if this description was well formatted too. > *Goal 4* > Taking [https://demo.openmf.org/api-docs/apiLive.htm#loans] as an example, > the details and descriptions of fields like "transactionProcessingStrategyId" > are not carried over. Without this information, an API consumer would not > understand what each of these (non-obvious) fields mean and how they are to > be used. > *Goal 5* > The amount of information present for an API like > [https://demo.openmf.org/api-docs/apiLive.htm#batch_api] is significantly > more than that of the equivalent API in Swagger (detailed description, > possible errors, command strategies supported etc). We would need to go > through each API to ensure that all information is migrated. > Here's a screenshot of another commonly used API for updating loan statuses > from swagger docs. > !Screen Shot 2019-03-17 at 3.59.23 AM.png|width=807,height=519! > Issues here > * Details of actual commands supported (approve, reject) are missing > *
[jira] [Updated] (FINERACT-826) Migrate to java.time from Joda API
[
https://issues.apache.org/jira/browse/FINERACT-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-826:
---
Summary: Migrate to java.time from Joda API (was:
org.apache.fineract.infrastructure.core.service.DateUtils has un-used line, and
should use java.time instead of Joda API )
> Migrate to java.time from Joda API
> --
>
> Key: FINERACT-826
> URL: https://issues.apache.org/jira/browse/FINERACT-826
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Percy Ashu
>Priority: Major
> Labels: technical
> Fix For: 1.5.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> [http://mail-archives.apache.org/mod_mbox/fineract-dev/201907.mbox/%3ccalix4ib1d32zskzn87kureosbwscjmo9dhgnoqbwydyui-c...@mail.gmail.com%3e,]
> and the original previous and the follow up replies on that thread Subject
> "Questions about my approach to find problems with tenant time zones, and
> about the instance values of SQL migration files.", related to FINERACT-723?
> I think, point out that
> {{org.apache.fineract.infrastructure.core.service.DateUtils}} could do with a
> closer look and fixes, specifically:
> {quote}That DateUtils class is interesting.. do we really need to mix the old
> java.util.Date API and the org.joda.time Time API ? FYI Joda Time has been
> integrated into Java 8 as java.time. So if someone was up for taking up work
> related to cleaning that up, that could be useful IMHO (so converge
> everything to java.time, and eventually remove the Joda dependency, and
> introduce an enforced check via Checkstle or SpotBugs to forbid
> java.util.Date).
>
> The null management in DateUtils is pretty interesting as well. So is this
> per tenant TZ guaranteed to always be in the DB? What does the DB schema say
> - required, never NULL? Does the Java code ensure it's never null? I'm asking
> these questions because something like that getLocalDateTimeOfTenant(),
> despite its name, seems to be actually be written to EITHER give us a "local"
> time based on the tenant, or, if that's null, it just falls back to what l
> suspect (not verified) is dependent on the OS / JVM TZ - that's scary.
> Perhaps it's not a problem in reality, if every tenant is guaranteed to
> always have a TZ, but if someone could double check this, and if so remove
> those null check and system dependent fallbacks, then IMHO that would make
> that utility code clearer.
>
> BTW line 45 in DateUtils seems completely useless, agreed? Would you like to
> raise a PR proposing to ditch that?
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1102) Swagger Codegen Client JAR should be available on a Maven repo
[ https://issues.apache.org/jira/browse/FINERACT-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1102: Parent: (was: FINERACT-733) Issue Type: Improvement (was: Sub-task) > Swagger Codegen Client JAR should be available on a Maven repo > -- > > Key: FINERACT-1102 > URL: https://issues.apache.org/jira/browse/FINERACT-1102 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Chinmay Kulkarni >Priority: Major > > FINERACT-838 contributed Swagger Codegen Client generation. > In order for the JAR built from that to actually be easily usable, we should > "distribute" it... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1101:
Fix Version/s: (was: 1.5.0)
1.4.0
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.4.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1101:
Parent: (was: FINERACT-733)
Issue Type: Improvement (was: Sub-task)
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.5.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1100) Swagger CodeGen WARN i.s.c.v.g.java.AbstractJavaCodegen - New (reserved word) cannot be used as model name. Renamed to ModelNew
[
https://issues.apache.org/jira/browse/FINERACT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1100:
Parent: (was: FINERACT-733)
Issue Type: Bug (was: Sub-task)
> Swagger CodeGen WARN i.s.c.v.g.java.AbstractJavaCodegen - New (reserved
> word) cannot be used as model name. Renamed to ModelNew
>
>
> Key: FINERACT-1100
> URL: https://issues.apache.org/jira/browse/FINERACT-1100
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
>
> [https://travis-ci.org/github/apache/fineract/builds/714158191] for
> [https://github.com/apache/fineract/pull/1228] for FINERACT-838 has this:
> {code:java}Task :generateSwaggerCodeFineract
> 12:52:44.707 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.722 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> <-> 33% EXECUTING [10s]> :generateSwaggerCodeFineractodel name.
> Renamed to ModelNew
> 12:52:44.733 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.742 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.748 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew{code}
> I'm not sure what this means, and how easy it would be to address this?
> [~Grandolf49] would you happen to know, or be willing to look into this, and
> either raise a PR to addresss it, or document your findings here?
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-742) Swagger guide for new api's
[ https://issues.apache.org/jira/browse/FINERACT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-742: --- Parent: (was: FINERACT-733) Issue Type: Improvement (was: Sub-task) > Swagger guide for new api's > > > Key: FINERACT-742 > URL: https://issues.apache.org/jira/browse/FINERACT-742 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Rahul Goel >Assignee: Manthan Surkar >Priority: Minor > Labels: fineract-swagger-doc > > Create swagger documentation guide for developers to apply swagger > annotations on fineract apis. > Going forward, whenever new api will be created, it's swagger document can be > created along with api. > For reference : https://goo.gl/8RMMhN -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1100) Swagger CodeGen WARN i.s.c.v.g.java.AbstractJavaCodegen - New (reserved word) cannot be used as model name. Renamed to ModelNew
[
https://issues.apache.org/jira/browse/FINERACT-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1100:
Priority: Minor (was: Major)
> Swagger CodeGen WARN i.s.c.v.g.java.AbstractJavaCodegen - New (reserved
> word) cannot be used as model name. Renamed to ModelNew
>
>
> Key: FINERACT-1100
> URL: https://issues.apache.org/jira/browse/FINERACT-1100
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> [https://travis-ci.org/github/apache/fineract/builds/714158191] for
> [https://github.com/apache/fineract/pull/1228] for FINERACT-838 has this:
> {code:java}Task :generateSwaggerCodeFineract
> 12:52:44.707 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.722 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> <-> 33% EXECUTING [10s]> :generateSwaggerCodeFineractodel name.
> Renamed to ModelNew
> 12:52:44.733 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.742 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew
> 12:52:44.748 [Thread-0] WARN i.s.c.v.g.java.AbstractJavaCodegen - New
> (reserved word) cannot be used as model name. Renamed to ModelNew{code}
> I'm not sure what this means, and how easy it would be to address this?
> [~Grandolf49] would you happen to know, or be willing to look into this, and
> either raise a PR to addresss it, or document your findings here?
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-741) Improving Swagger UI to group related APIs together instead of random order
[ https://issues.apache.org/jira/browse/FINERACT-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-741: --- Parent: (was: FINERACT-733) Issue Type: Improvement (was: Sub-task) > Improving Swagger UI to group related APIs together instead of random order > --- > > Key: FINERACT-741 > URL: https://issues.apache.org/jira/browse/FINERACT-741 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Rahul Goel >Assignee: Manthan Surkar >Priority: Minor > Labels: fineract-swagger-doc > > All API's are currently listed in a random order and someone new to the > system cannot comprehend relationships between them. The home page needs to > be improved with either a sidebar or a navbar (similar to the one in the > existing documentation) which groups together related API's and provides > hyperlinks to their swagger documentation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1046) Remove most API doc from apiLive.htm (keep it only to explain things like error handling etc.)
[ https://issues.apache.org/jira/browse/FINERACT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1046: Parent: (was: FINERACT-733) Issue Type: Improvement (was: Sub-task) > Remove most API doc from apiLive.htm (keep it only to explain things like > error handling etc.) > -- > > Key: FINERACT-1046 > URL: https://issues.apache.org/jira/browse/FINERACT-1046 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > > The goal of the Swagger work should be to eventually be able to remove most > API doc from http://localhost:8080/fineract-provider/api-docs/apiLive.htm and > have the majority of what one can learn from apiLive.htm today be instead > available on http://localhost:8080/fineract-provider/swagger-ui/index.html > I guess we'll (eventually) either completely remove apiLive.htm, or (more > likely) keep a minumal remnant of it around to only explain general things > like authentication, error handling etc. and then link to /swagger-ui/ from > it. > [~ptuomola] and [~Manthan] agreed? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-834) Minor quick win: Please raise very small PR documenting Swagger use on README
[ https://issues.apache.org/jira/browse/FINERACT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-834: --- Parent: (was: FINERACT-733) Issue Type: Improvement (was: Sub-task) > Minor quick win: Please raise very small PR documenting Swagger use on README > - > > Key: FINERACT-834 > URL: https://issues.apache.org/jira/browse/FINERACT-834 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > > Based on some of the discussion in > https://github.com/apache/fineract/pull/629 (which got superseded by > https://github.com/apache/fineract/pull/695), I think it would be very useful > to have a short line (or a or two paragraph, max) in > https://github.com/apache/fineract/blob/develop/README.md#apache-fineract-platform-api > which simply explains how one actually may currently use the Swagger UI, as > it currently is. > I will just be completely honest and admit that personally I do not actually > know how! ;-) Is there a special URL one has to access? Does one need to > locally install anything? > [~kangbreder] would you like to do this? Please do raise 1 small PR with ONLY > this README change. > [~awasum] [~sanyam] ([~sanyam96] ?) FYI -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-834) Minor quick win: Please raise very small PR documenting Swagger use on README
[ https://issues.apache.org/jira/browse/FINERACT-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-834: --- Priority: Trivial (was: Major) > Minor quick win: Please raise very small PR documenting Swagger use on README > - > > Key: FINERACT-834 > URL: https://issues.apache.org/jira/browse/FINERACT-834 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Trivial > > Based on some of the discussion in > https://github.com/apache/fineract/pull/629 (which got superseded by > https://github.com/apache/fineract/pull/695), I think it would be very useful > to have a short line (or a or two paragraph, max) in > https://github.com/apache/fineract/blob/develop/README.md#apache-fineract-platform-api > which simply explains how one actually may currently use the Swagger UI, as > it currently is. > I will just be completely honest and admit that personally I do not actually > know how! ;-) Is there a special URL one has to access? Does one need to > locally install anything? > [~kangbreder] would you like to do this? Please do raise 1 small PR with ONLY > this README change. > [~awasum] [~sanyam] ([~sanyam96] ?) FYI -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FINERACT-1048) SchedulerJob executeAndAwait predicate returns false with successful transaction
[ https://issues.apache.org/jira/browse/FINERACT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger closed FINERACT-1048. --- Fix Version/s: (was: 1.5.0) Resolution: Cannot Reproduce I don't see any PRs associated to this issue, so instead of closing it with Resolution: Fixed for Version: 1.5.0, it should use another Resolution such as probably Cannot Reproduce in this case, and not have a Fix Version at all. > SchedulerJob executeAndAwait predicate returns false with successful > transaction > > > Key: FINERACT-1048 > URL: https://issues.apache.org/jira/browse/FINERACT-1048 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Major > > Schedularjob acting crazy again. Time execution time comparison is faulty in > tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (FINERACT-1048) SchedulerJob executeAndAwait predicate returns false with successful transaction
[ https://issues.apache.org/jira/browse/FINERACT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reopened FINERACT-1048: - > SchedulerJob executeAndAwait predicate returns false with successful > transaction > > > Key: FINERACT-1048 > URL: https://issues.apache.org/jira/browse/FINERACT-1048 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Major > Fix For: 1.5.0 > > > Schedularjob acting crazy again. Time execution time comparison is faulty in > tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-426) Filter to optionally compress response with gzip
[
https://issues.apache.org/jira/browse/FINERACT-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184814#comment-17184814
]
Michael Vorburger commented on FINERACT-426:
> [~vorburger] : The second link is the right account.
[~avikganguly010] you should raise an INFRA ticket to have ASF staff deactivate
your old [~avikg], to avoid future confusion when we want to tag you.
> Filter to optionally compress response with gzip
>
>
> Key: FINERACT-426
> URL: https://issues.apache.org/jira/browse/FINERACT-426
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Avik Ganguly
>Assignee: Avik Ganguly
>Priority: Minor
> Labels: easyfix, gsoc, newbie, p2, performance
> Fix For: 1.3.0
>
>
> Accept a query parameter like isCompressionRequired. If this query param is
> present, compress the response using gzip. This will ensure less bandwidth
> usage if field apps are using mobile data.
> Sample Code for response filter :-
> Inside filter method :-
> if
> (request.getRequestHeaders().getFirst(HttpHeaders.ACCEPT_ENCODING).contains("gzip"))
> {
>
> response.getHttpHeaders().add(HttpHeaders.CONTENT_ENCODING, "gzip");
> response.setContainerResponseWriter(
> new
> Adapter(response.getContainerResponseWriter()));
> }
> private static final class Adapter implements ContainerResponseWriter {
> private final ContainerResponseWriter crw;
> private GZIPOutputStream gos;
> Adapter(ContainerResponseWriter crw) {
> this.crw = crw;
> }
>
> public OutputStream writeStatusAndHeaders(long contentLength,
> ContainerResponse response) throws IOException {
>gos = new GZIPOutputStream(crw.writeStatusAndHeaders(-1,
> response));
>return gos;
> }
> public void finish() throws IOException {
> gos.finish();
> crw.finish();
> }
> }
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-838) Swagger generated client libraries
[
https://issues.apache.org/jira/browse/FINERACT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184812#comment-17184812
]
Michael Vorburger commented on FINERACT-838:
Sure, sounds goods to me; let's set it to resolved, and change the Fix Version
back to 1.4.0, because it's actually there already. You can always improve it
further in 1.5.0 in future issues & PRs.
> Swagger generated client libraries
> --
>
> Key: FINERACT-838
> URL: https://issues.apache.org/jira/browse/FINERACT-838
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
> Fix For: 1.5.0
>
>
> In the review discussion of the first Swagger PR
> https://github.com/apache/fineract/pull/629 (which got superseded by
> https://github.com/apache/fineract/pull/695), this came up:
> {quote}The other plugin org.hidetake.swagger.generator is used to generate
> code from the openAPI spec file using swagger-codegen. So this does not
> generate response.json. It rather uses response.json to generate client
> code.{quote}
> and {quote} think i had explained the usage of this in my gist
> https://gist.github.com/kangbreder/034f47e2e8015cee10b48b7c5f1b8df1,
> generating client libraries and language-specific SDKs in languages such as
> java and angular from swagger specification file. This was part of the goals
> of the project listed in
> https://mifosforge.jira.com/wiki/spaces/RES/pages/812810251/Google+Summer+of+Code+2019+Ideas.{quote}
> Having (Swagger automatically generate!) client libraries in Java (and even
> other languages?!) seems like a cool idea. It's also something that perhaps
> needs a bit more investigation than only adding the respective Gradle plugin.
> If we actually do do this, after having done all of the work in the other
> Sub Tasks, then I think we would have to include sample code in the repo
> building against the generated client libraries to test and illustrate their
> usage. We would also have to publish those client libraries, e.g. as
> downloadable JAR from the release page (or later even made available on Maven
> central). It would perhaps be clearest if there was another directory in the
> Fineract source tree, next to and outside of not inside, the
> fineract-provider (which is the "server") for this purpose.
> [~kangbreder] [~awasum] [~sanyam] ([~sanyam96] ?) FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-838) Swagger generated client libraries
[
https://issues.apache.org/jira/browse/FINERACT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger resolved FINERACT-838.
Resolution: Fixed
> Swagger generated client libraries
> --
>
> Key: FINERACT-838
> URL: https://issues.apache.org/jira/browse/FINERACT-838
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
> Fix For: 1.4.0
>
>
> In the review discussion of the first Swagger PR
> https://github.com/apache/fineract/pull/629 (which got superseded by
> https://github.com/apache/fineract/pull/695), this came up:
> {quote}The other plugin org.hidetake.swagger.generator is used to generate
> code from the openAPI spec file using swagger-codegen. So this does not
> generate response.json. It rather uses response.json to generate client
> code.{quote}
> and {quote} think i had explained the usage of this in my gist
> https://gist.github.com/kangbreder/034f47e2e8015cee10b48b7c5f1b8df1,
> generating client libraries and language-specific SDKs in languages such as
> java and angular from swagger specification file. This was part of the goals
> of the project listed in
> https://mifosforge.jira.com/wiki/spaces/RES/pages/812810251/Google+Summer+of+Code+2019+Ideas.{quote}
> Having (Swagger automatically generate!) client libraries in Java (and even
> other languages?!) seems like a cool idea. It's also something that perhaps
> needs a bit more investigation than only adding the respective Gradle plugin.
> If we actually do do this, after having done all of the work in the other
> Sub Tasks, then I think we would have to include sample code in the repo
> building against the generated client libraries to test and illustrate their
> usage. We would also have to publish those client libraries, e.g. as
> downloadable JAR from the release page (or later even made available on Maven
> central). It would perhaps be clearest if there was another directory in the
> Fineract source tree, next to and outside of not inside, the
> fineract-provider (which is the "server") for this purpose.
> [~kangbreder] [~awasum] [~sanyam] ([~sanyam96] ?) FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-838) Swagger generated client libraries
[
https://issues.apache.org/jira/browse/FINERACT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-838:
---
Fix Version/s: (was: 1.5.0)
1.4.0
> Swagger generated client libraries
> --
>
> Key: FINERACT-838
> URL: https://issues.apache.org/jira/browse/FINERACT-838
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Major
> Fix For: 1.4.0
>
>
> In the review discussion of the first Swagger PR
> https://github.com/apache/fineract/pull/629 (which got superseded by
> https://github.com/apache/fineract/pull/695), this came up:
> {quote}The other plugin org.hidetake.swagger.generator is used to generate
> code from the openAPI spec file using swagger-codegen. So this does not
> generate response.json. It rather uses response.json to generate client
> code.{quote}
> and {quote} think i had explained the usage of this in my gist
> https://gist.github.com/kangbreder/034f47e2e8015cee10b48b7c5f1b8df1,
> generating client libraries and language-specific SDKs in languages such as
> java and angular from swagger specification file. This was part of the goals
> of the project listed in
> https://mifosforge.jira.com/wiki/spaces/RES/pages/812810251/Google+Summer+of+Code+2019+Ideas.{quote}
> Having (Swagger automatically generate!) client libraries in Java (and even
> other languages?!) seems like a cool idea. It's also something that perhaps
> needs a bit more investigation than only adding the respective Gradle plugin.
> If we actually do do this, after having done all of the work in the other
> Sub Tasks, then I think we would have to include sample code in the repo
> building against the generated client libraries to test and illustrate their
> usage. We would also have to publish those client libraries, e.g. as
> downloadable JAR from the release page (or later even made available on Maven
> central). It would perhaps be clearest if there was another directory in the
> Fineract source tree, next to and outside of not inside, the
> fineract-provider (which is the "server") for this purpose.
> [~kangbreder] [~awasum] [~sanyam] ([~sanyam96] ?) FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1001) Enable and Enforce PMD on Fineract
[ https://issues.apache.org/jira/browse/FINERACT-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-1001: --- Assignee: (was: Awasum Yannick) > Enable and Enforce PMD on Fineract > -- > > Key: FINERACT-1001 > URL: https://issues.apache.org/jira/browse/FINERACT-1001 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Awasum Yannick >Priority: Minor > Fix For: 1.5.0 > > Attachments: main.html > > > Enable and Enforce PMD ( [https://pmd.github.io/ )|https://pmd.github.io/] on > Fineract. Make PMD fail until violations are fixed just like we do for > Spotbug, checkstyle etc. See previous work here: > [https://github.com/apache/fineract/pull/295] > See where PMD was commented out because it was not use: > [https://github.com/apache/fineract/pull/612] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-873) Release Apache Fineract v1.4.0
[ https://issues.apache.org/jira/browse/FINERACT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-873: --- Fix Version/s: (was: 1.5.0) 1.4.0 > Release Apache Fineract v1.4.0 > -- > > Key: FINERACT-873 > URL: https://issues.apache.org/jira/browse/FINERACT-873 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.4.0 > > > Our mailing list occasionally has people posting questions about the next > (1.4.0) release. > It appears that the process to follow [is documented on the > Wiki|https://cwiki.apache.org/confluence/x/DRwIB]. That page is however > currently marked "(Draft)" (in the page's title), and may be outdated. This > JIRA issue includes any work required to make that page an easy to follow > obvious process for this (1.4.0) and future releases. I'll make a start with > some edits today, but likely more edits are needed by others who are going to > work on this. I've also found it more by chance only, let's link it from the > README? I'll raise a PR. > Note that as I'm creating this issue, there is also a 1.4.0 related both > branch and even tag. It was created 2 months ago, and does not match current > JIRA issues for 1.4.0, and as far as I remember (please comment here if this > is wrong!) there was never a vote approving it, and it's not available on > http://fineract.apache.org. I therefore propose that we start over. > I'll also create some sub and/or linked JIRA tasks to this topic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-873) Release Apache Fineract v1.4.0
[ https://issues.apache.org/jira/browse/FINERACT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-873: -- Assignee: Aleksandar Vidakovic (was: Michael Vorburger) > Release Apache Fineract v1.4.0 > -- > > Key: FINERACT-873 > URL: https://issues.apache.org/jira/browse/FINERACT-873 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.5.0 > > > Our mailing list occasionally has people posting questions about the next > (1.4.0) release. > It appears that the process to follow [is documented on the > Wiki|https://cwiki.apache.org/confluence/x/DRwIB]. That page is however > currently marked "(Draft)" (in the page's title), and may be outdated. This > JIRA issue includes any work required to make that page an easy to follow > obvious process for this (1.4.0) and future releases. I'll make a start with > some edits today, but likely more edits are needed by others who are going to > work on this. I've also found it more by chance only, let's link it from the > README? I'll raise a PR. > Note that as I'm creating this issue, there is also a 1.4.0 related both > branch and even tag. It was created 2 months ago, and does not match current > JIRA issues for 1.4.0, and as far as I remember (please comment here if this > is wrong!) there was never a vote approving it, and it's not available on > http://fineract.apache.org. I therefore propose that we start over. > I'll also create some sub and/or linked JIRA tasks to this topic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-873) Release Apache Fineract v1.4.0
[ https://issues.apache.org/jira/browse/FINERACT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-873: -- Assignee: Michael Vorburger (was: Aleksandar Vidakovic) > Release Apache Fineract v1.4.0 > -- > > Key: FINERACT-873 > URL: https://issues.apache.org/jira/browse/FINERACT-873 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Michael Vorburger >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.5.0 > > > Our mailing list occasionally has people posting questions about the next > (1.4.0) release. > It appears that the process to follow [is documented on the > Wiki|https://cwiki.apache.org/confluence/x/DRwIB]. That page is however > currently marked "(Draft)" (in the page's title), and may be outdated. This > JIRA issue includes any work required to make that page an easy to follow > obvious process for this (1.4.0) and future releases. I'll make a start with > some edits today, but likely more edits are needed by others who are going to > work on this. I've also found it more by chance only, let's link it from the > README? I'll raise a PR. > Note that as I'm creating this issue, there is also a 1.4.0 related both > branch and even tag. It was created 2 months ago, and does not match current > JIRA issues for 1.4.0, and as far as I remember (please comment here if this > is wrong!) there was never a vote approving it, and it's not available on > http://fineract.apache.org. I therefore propose that we start over. > I'll also create some sub and/or linked JIRA tasks to this topic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1089) Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in InterestRateChartReadPlatformServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-1089:
---
Assignee: Percy Ashu
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in
> InterestRateChartReadPlatformServiceImpl
> --
>
> Key: FINERACT-1089
> URL: https://issues.apache.org/jira/browse/FINERACT-1089
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Percy Ashu
>Priority: Blocker
> Fix For: 1.5.0
>
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev, this seems to be a similar problem to that was
> previously fixed in FINERACT-995 and FINERACT-1061:
> {noformat}
> org.springframework.dao.TransientDataAccessResourceException:
> PreparedStatementCallback; SQL [select irc.id as ircId, irc.name as ircName,
> irc.description as ircDescription,irc.from_date as ircFromDate, irc.end_date
> as ircEndDate, irc.is_primary_grouping_by_amount as
> isPrimaryGroupingByAmount, ircd.id as ircdId, ircd.description as
> ircdDescription, ircd.period_type_enum ircdPeriodTypeId, ircd.from_period as
> ircdFromPeriod, ircd.to_period as ircdToPeriod, ircd.amount_range_from as
> ircdAmountRangeFrom, ircd.amount_range_to as ircdAmountRangeTo,
> ircd.annual_interest_rate as ircdAnnualInterestRate, curr.code as
> currencyCode, curr.name as currencyName, curr.internationalized_name_code as
> currencyNameCode, curr.display_symbol as currencyDisplaySymbol,
> curr.decimal_places as currencyDigits, curr.currency_multiplesof as
> inMultiplesOf, sp.id as savingsProductId, sp.name as savingsProductName,
> iri.id as iriId, iri.entiry_type as entityType, iri.attribute_name as
> attributeName , iri.condition_type as conditionType, iri.attribute_value as
> attributeValue, iri.incentive_type as incentiveType, iri.amount as amount,
> code.code_value as attributeValueDesc from m_interest_rate_chart irc left
> join m_interest_rate_slab ircd on irc.id=ircd.interest_rate_chart_id left
> join m_interest_incentives iri on iri.interest_rate_slab_id = ircd.id left
> join m_code_value code on code.id = iri.attribute_value left join m_currency
> curr on ircd.currency_code= curr.code left join
> m_deposit_product_interest_rate_chart dpirc on
> irc.id=dpirc.interest_rate_chart_id left join m_savings_product sp on
> sp.id=dpirc.deposit_product_id where sp.id = ? order by irc.id, CASE WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_from WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_to END,ircd.from_period,
> ircd.to_period,CASE WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_from WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_to END]; Operation not allowed for a result set of type
> ResultSet.TYPE_FORWARD_ONLY.; nested exception is java.sql.SQLException:
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
> at
> org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate
> (SQLStateSQLExceptionTranslator.java:110)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:72)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at org.springframework.jdbc.core.JdbcTemplate.translateException
> (JdbcTemplate.java:1443)
> at org.springframework.jdbc.core.JdbcTemplate.execute
> (JdbcTemplate.java:633)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:669)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:700)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:718)
> at
> org.apache.fineract.portfolio.interestratechart.service.InterestRateChartReadPlatformServiceImpl.retrieveAllWithSlabs
> (InterestRateChartReadPlatformServiceImpl.java:102)
> Caused by: java.sql.SQLException: Operation not allowed for a result set of
> type ResultSet.TYPE_FORWARD_ONLY.
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:129)
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:97)
> at
> com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException
> (SQLExceptionsMapping.java:122)
> at com.mysql.cj.jdbc.result.ResultSetImpl.previous
> (ResultSetImpl.java:1806)
>
[jira] [Reopened] (FINERACT-1094) Pentaho Reports are needed a number of MifosX users need them back
[ https://issues.apache.org/jira/browse/FINERACT-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reopened FINERACT-1094: - > Pentaho Reports are needed a number of MifosX users need them back > -- > > Key: FINERACT-1094 > URL: https://issues.apache.org/jira/browse/FINERACT-1094 > Project: Apache Fineract > Issue Type: Wish >Affects Versions: 1.4.0 >Reporter: Francis Guchie >Priority: Major > > Fineract project stopped pentaho support due license issues. > MifosX users who depends on pentaho reports need this functionality. > read more here [https://github.com/bharathcgowda/Fineract/pull/2] > a number of changes have to be done and i believe this can be done by the > users but it would be nice to leave the pentaho report functionality active -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FINERACT-1094) Pentaho Reports are needed a number of MifosX users need them back
[ https://issues.apache.org/jira/browse/FINERACT-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger closed FINERACT-1094. --- Resolution: Won't Do > Pentaho Reports are needed a number of MifosX users need them back > -- > > Key: FINERACT-1094 > URL: https://issues.apache.org/jira/browse/FINERACT-1094 > Project: Apache Fineract > Issue Type: Wish >Affects Versions: 1.4.0 >Reporter: Francis Guchie >Priority: Major > > Fineract project stopped pentaho support due license issues. > MifosX users who depends on pentaho reports need this functionality. > read more here [https://github.com/bharathcgowda/Fineract/pull/2] > a number of changes have to be done and i believe this can be done by the > users but it would be nice to leave the pentaho report functionality active -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-942) Make Checkstyle detect bad logging anti-patterns (and fix problems found)
[ https://issues.apache.org/jira/browse/FINERACT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184807#comment-17184807 ] Michael Vorburger commented on FINERACT-942: Oh wait I didn't actually read the previous comments here, and kind of forgot where we left this off... perhaps the best thing to do here for clarity would be to change the Fix Version of this to 1.4.0 and close it, and open a issue for 1.5.0 specifically for the (only) remaining IllegalCatch? > Make Checkstyle detect bad logging anti-patterns (and fix problems found) > - > > Key: FINERACT-942 > URL: https://issues.apache.org/jira/browse/FINERACT-942 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.5.0 > > > A particularly useful part of FINERACT-821, helping to detect real errors in > Fineract and not just formating, would be to enable the following in > fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that > this finds: > 1. RegexpSinglelineJava / printStackTrace > 2. IllegalCatch, IllegalThrows, MutableException, > AvoidHidingCauseExceptionCheck > 3. > [EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock] > Nota bene that we already have FINERACT-696, but this is complementary to > that. > One thing this should detect is e.g. the bad wrong emtpy > catch(MessagingException e) in EmailMessageJobEmailServiceImpl. > It may lead to more of FINERACT-932, which would be a Good Thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-942) Make Checkstyle detect bad logging anti-patterns (and fix problems found)
[ https://issues.apache.org/jira/browse/FINERACT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184805#comment-17184805 ] Michael Vorburger commented on FINERACT-942: I would strongly support changing the Fix Version of this back from 1.5.0 to 1.4.0, IFF you can raise the PR for the missing 1 checkstyle ASAP, for both develop, and then cherry-pick backport it to 1.4.0 still. > Make Checkstyle detect bad logging anti-patterns (and fix problems found) > - > > Key: FINERACT-942 > URL: https://issues.apache.org/jira/browse/FINERACT-942 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Manthan Surkar >Priority: Major > Fix For: 1.5.0 > > > A particularly useful part of FINERACT-821, helping to detect real errors in > Fineract and not just formating, would be to enable the following in > fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that > this finds: > 1. RegexpSinglelineJava / printStackTrace > 2. IllegalCatch, IllegalThrows, MutableException, > AvoidHidingCauseExceptionCheck > 3. > [EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock] > Nota bene that we already have FINERACT-696, but this is complementary to > that. > One thing this should detect is e.g. the bad wrong emtpy > catch(MessagingException e) in EmailMessageJobEmailServiceImpl. > It may lead to more of FINERACT-932, which would be a Good Thing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1115) Not possible to start tomcat if root password is not "mysql"
[ https://issues.apache.org/jira/browse/FINERACT-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1115: Fix Version/s: (was: 1.3.0) (was: 1.2.0) (was: 1.1.0) (was: 1.0.0) > Not possible to start tomcat if root password is not "mysql" > > > Key: FINERACT-1115 > URL: https://issues.apache.org/jira/browse/FINERACT-1115 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Affects Versions: 1.4.0 >Reporter: Francis Guchie >Priority: Critical > Labels: beginner > > After a successfull installation following steps here > [https://mifosforge.jira.com/wiki/spaces/docs/pages/74711072/Mifos+X+Installation+on+Linux+-+Ubuntu+Server] > , it was possible to change the suggested root password for MySQL. > But for the latest build, if you change the root password from "mysql" to > something else, when you start tomcat, you will get errors. This looks like > the root password (the suggested one) is hard coded in some files of the > fineract -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1115) Not possible to start tomcat if root password is not "mysql"
[ https://issues.apache.org/jira/browse/FINERACT-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-1115: --- Assignee: Francis Guchie > Not possible to start tomcat if root password is not "mysql" > > > Key: FINERACT-1115 > URL: https://issues.apache.org/jira/browse/FINERACT-1115 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Affects Versions: 1.4.0 >Reporter: Francis Guchie >Assignee: Francis Guchie >Priority: Critical > Labels: beginner > > After a successfull installation following steps here > [https://mifosforge.jira.com/wiki/spaces/docs/pages/74711072/Mifos+X+Installation+on+Linux+-+Ubuntu+Server] > , it was possible to change the suggested root password for MySQL. > But for the latest build, if you change the root password from "mysql" to > something else, when you start tomcat, you will get errors. This looks like > the root password (the suggested one) is hard coded in some files of the > fineract -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1115) Not possible to start tomcat if root password is not "mysql"
[ https://issues.apache.org/jira/browse/FINERACT-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184803#comment-17184803 ] Michael Vorburger commented on FINERACT-1115: - [~francisguchie] FYI the Fix Version field in Jira is to say where this issue is fixed; it should be the same or a later version than the Affects Version, not earlier versions. Let's assign this issue to you for your trying and reverting this. > Not possible to start tomcat if root password is not "mysql" > > > Key: FINERACT-1115 > URL: https://issues.apache.org/jira/browse/FINERACT-1115 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Affects Versions: 1.4.0 >Reporter: Francis Guchie >Priority: Critical > Labels: beginner > Fix For: 1.0.0, 1.1.0, 1.2.0, 1.3.0 > > > After a successfull installation following steps here > [https://mifosforge.jira.com/wiki/spaces/docs/pages/74711072/Mifos+X+Installation+on+Linux+-+Ubuntu+Server] > , it was possible to change the suggested root password for MySQL. > But for the latest build, if you change the root password from "mysql" to > something else, when you start tomcat, you will get errors. This looks like > the root password (the suggested one) is hard coded in some files of the > fineract -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-748) Fixing typos in SPM API
[ https://issues.apache.org/jira/browse/FINERACT-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-748. Resolution: Fixed > Fixing typos in SPM API > --- > > Key: FINERACT-748 > URL: https://issues.apache.org/jira/browse/FINERACT-748 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Apoorva M K >Priority: Trivial > Labels: beginner, technical > Fix For: 1.4.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-748) Fixing typos in SPM API
[ https://issues.apache.org/jira/browse/FINERACT-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184802#comment-17184802 ] Michael Vorburger commented on FINERACT-748: Yeah, looks like it - let's clsoe this as Resolved for 1.4.0 > Fixing typos in SPM API > --- > > Key: FINERACT-748 > URL: https://issues.apache.org/jira/browse/FINERACT-748 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Apoorva M K >Priority: Trivial > Labels: beginner, technical > Fix For: 1.4.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FINERACT-748) Fixing typos in SPM API
[ https://issues.apache.org/jira/browse/FINERACT-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184802#comment-17184802 ] Michael Vorburger edited comment on FINERACT-748 at 8/26/20, 12:15 AM: --- Yeah, looks like it - let's close this as Resolved Fixed for 1.4.0 [~awasum]in obvious cases like this, I would just go ahead and do it, not consensus build... ;) was (Author: vorburger): Yeah, looks like it - let's clsoe this as Resolved for 1.4.0 > Fixing typos in SPM API > --- > > Key: FINERACT-748 > URL: https://issues.apache.org/jira/browse/FINERACT-748 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Apoorva M K >Priority: Trivial > Labels: beginner, technical > Fix For: 1.4.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1128) Travis build fails with connection refused
[
https://issues.apache.org/jira/browse/FINERACT-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184800#comment-17184800
]
Michael Vorburger commented on FINERACT-1128:
-
> One possible solution could be to switch from http to curl and then use
> curl's facility for retries - i.e. try the connection 5 times with 30 second
> breaks between retries to see if the container comes up.
SGTM; very happy to peer review and merge a PR around this, if want to put
something together. No objections at all (far from it) to switch from
[https://httpie.org|https://httpie.org/] to good ol' {{curl}}.
> Travis build fails with connection refused
> --
>
> Key: FINERACT-1128
> URL: https://issues.apache.org/jira/browse/FINERACT-1128
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Petri Tuomola
>Priority: Major
>
> Travis build often fails with the following error when trying to check that
> the Docker container has come up as expected:
> http: error: ConnectionError: HTTPSConnectionPool(host='localhost',
> port=8443): Max retries exceeded with url: /fineract-provider/actuator/health
> (Caused by NewConnectionError(' object at 0x7fd6051a9c18>: Failed to establish a new connection: [Errno 111]
> Connection refused',)) while doing GET request to URL:
> [https://localhost:8443/fineract-provider/actuator/health]
> Retrying the build works so this is an issue with infra rather than code -
> may just be due to the Docker container taking longer than expected in coming
> up?
> One possible solution could be to switch from http to curl and then use
> curl's facility for retries - i.e. try the connection 5 times with 30 second
> breaks between retries to see if the container comes up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-873) Release Apache Fineract v1.4.0
[ https://issues.apache.org/jira/browse/FINERACT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184791#comment-17184791 ] Michael Vorburger commented on FINERACT-873: I've (easily) been able to create a (just test) [https://dist.apache.org/repos/dist/dev/fineract/1.4.0/] and [improved the release page how to|https://cwiki.apache.org/confluence/pages/diffpages.action?pageId=67640333=158873651]. > Release Apache Fineract v1.4.0 > -- > > Key: FINERACT-873 > URL: https://issues.apache.org/jira/browse/FINERACT-873 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.5.0 > > > Our mailing list occasionally has people posting questions about the next > (1.4.0) release. > It appears that the process to follow [is documented on the > Wiki|https://cwiki.apache.org/confluence/x/DRwIB]. That page is however > currently marked "(Draft)" (in the page's title), and may be outdated. This > JIRA issue includes any work required to make that page an easy to follow > obvious process for this (1.4.0) and future releases. I'll make a start with > some edits today, but likely more edits are needed by others who are going to > work on this. I've also found it more by chance only, let's link it from the > README? I'll raise a PR. > Note that as I'm creating this issue, there is also a 1.4.0 related both > branch and even tag. It was created 2 months ago, and does not match current > JIRA issues for 1.4.0, and as far as I remember (please comment here if this > is wrong!) there was never a vote approving it, and it's not available on > http://fineract.apache.org. I therefore propose that we start over. > I'll also create some sub and/or linked JIRA tasks to this topic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[
https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184780#comment-17184780
]
Michael Vorburger commented on FINERACT-1129:
-
Re. the client JAR, probably just following
[https://github.com/apache/fineract/#apache-fineract-platform-api] =>
[https://github.com/apache/fineract/blob/develop/docs/developers/swagger/client.md]
will get you there? But I would love [~Grandolf49] to chime in and work with
you here. Note that he just changed it in
[https://github.com/apache/fineract/pull/1271], which he hasn't proposed to
backport to 1.4.0, yet. That's if he's interested in getting the Swagger Client
JAR shipped in the upcoming 1.4.0 release distribution already. It's an
assumption I just boldly made, but haven't actually verified with him... :P if
that's a little premature, and the client JAR isn't really ready for
distribution just yet, then no stress at all, let's skip it for 1.4.0, and
[~Grandolf49] can add it later through a follow-up PR extending the new Gradle
task, for a future 1.5.0?
I've actually pulled your branch already, looking at
[https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1129],
and can provide some feedback before you raise your PR already, if that's OK
with you:
First of all, this is very cool! I've compared the previous
apache-fineract-1.3.0-binary and a new apache-fineract-1.4.0-binary built
through this, and they look similar enough, to me. Have noticed how you're
including {{licenses/}} which is great and actually required by ASF AFAIK, so
looks like that was missed in the past.
One important point: It currently only builds the
{{apache-fineract-$releaseVersion-binary.tar.gz}} - will you make it build
those {{apache-fineract-*-src.tar.gz}} we need on
[https://fineract.apache.org/#downloads] as well?
Smaller feedback on the new Gradle task name - do you want to drop the
{{fineract}} prefix just in your {{fineractRelease}} Gradle task name? It's
e.g. just {{./gradlew build}} and not fineract* for everything else after all,
so how about just "release", or (even better IMHO, if that works) just
"distribution", in line with this using the distribution Gradle plugin and
producing {{build/distributions/}}.
Lastly, let's "document" this by adding a line to
[https://github.com/apache/fineract/blob/develop/README.md#releasing] about it
as well, while we're at it? I guess just _"(...) available on
[http://fineract.apache.org|http://fineract.apache.org/], from
`{{build/distributions/}}` after running `{{./gradlew fineractRelease}}`."_ (or
{{distribution}} instead of {{fineractRelease}}, if you rename it) is what this
boils down to?
If I can provide a very minor more general feedback, your Commit Message should
include this JIRA id, so e.g. "Add release task to Gradle (FINERACT-1129)"
instead of just "Add release task".
[~ptuomola] this will do the most important part of FINERACT-876! :D
> Gradle task to create release package
> -
>
> Key: FINERACT-1129
> URL: https://issues.apache.org/jira/browse/FINERACT-1129
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Build
>Affects Versions: 1.4.0
>Reporter: Aleksandar Vidakovic
>Assignee: Aleksandar Vidakovic
>Priority: Minor
> Fix For: 1.4.0
>
>
> Add Gradle task to create release package with following artifacts:
> * WAR
> * server JAR
> * client JAR
> * README
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184774#comment-17184774 ] Aleksandar Vidakovic commented on FINERACT-1129: FYI... currently the following files are included in the release distribution (compared that with last 1.3.0 release): * fineract-provider.jar * fineract-provider.war * LICENSE * NOTICE * README.md Additionally I've included all licenses from the binary dependencies; I saw this in the WAR task and thought can't hurt to add those too. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-876) Automate Fineract release process
[ https://issues.apache.org/jira/browse/FINERACT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184773#comment-17184773 ] Michael Vorburger commented on FINERACT-876: I agree, re. above. FINERACT-1129 is (about to) contribute the most important parts. > Automate Fineract release process > - > > Key: FINERACT-876 > URL: https://issues.apache.org/jira/browse/FINERACT-876 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > > While I was making some minor edits to improve our [How to Release Apache > Fineract|https://cwiki.apache.org/confluence/x/DRwIB] page on the Wiki for a > possible upcoming Fineract 1.4.0 release in FINERACT-873, I was wondering if > much of what is listed on that page, like all the git operations, email > sending, verification, GPG stuff, even Wiki page creation (Confluence has a > REST API...) could not just be fully automated and scripted... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184759#comment-17184759 ] Aleksandar Vidakovic commented on FINERACT-1129: See first draft here: [https://github.com/vidakovic/fineract/blob/feature/FINERACT-1129/fineract-provider/build.gradle#L847] [~vorburger] Have almost all the requirements as we spoke; the only thing left is how to add the generated client. At the moment only sources are generated and no JAR file. Any idea how to proceed with this? > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1129) Gradle task to create release package
[ https://issues.apache.org/jira/browse/FINERACT-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184731#comment-17184731 ] Aleksandar Vidakovic commented on FINERACT-1129: I think we can throw in GPG signing too. > Gradle task to create release package > - > > Key: FINERACT-1129 > URL: https://issues.apache.org/jira/browse/FINERACT-1129 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Aleksandar Vidakovic >Assignee: Aleksandar Vidakovic >Priority: Minor > Fix For: 1.4.0 > > > Add Gradle task to create release package with following artifacts: > * WAR > * server JAR > * client JAR > * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1129) Gradle task to create release package
Aleksandar Vidakovic created FINERACT-1129: -- Summary: Gradle task to create release package Key: FINERACT-1129 URL: https://issues.apache.org/jira/browse/FINERACT-1129 Project: Apache Fineract Issue Type: Improvement Components: Build Affects Versions: 1.4.0 Reporter: Aleksandar Vidakovic Assignee: Aleksandar Vidakovic Fix For: 1.4.0 Add Gradle task to create release package with following artifacts: * WAR * server JAR * client JAR * README -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1125) Integrate Alternative Reporting tool for Fineract 1.x without Apache License violations
[ https://issues.apache.org/jira/browse/FINERACT-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184149#comment-17184149 ] James Dailey commented on FINERACT-1125: [~francisguchie] - Good to have your ideas on this! Thank you. As background, when the Mifos Initiative contributed the code to Apache, we were surprised to find out that we could not port over the Pentaho Reports due to the licensing issues. I think a simple set of reporting interfaces, specifically a set of APIs or connectors (that expand from where the Pentaho approach leaves off), is a particularly useful area of work for release 1.5. These connectors could allow for a System Integrator (SI) to use the basic reporting infra but then to expand it. As with all open source, the idea is to create enough of a starting point - in the commons - to allow for others to build on top of it. By doing just the minimum, the project enables a virtuous cycle of contribution. That is the ideal. Could you take part of this on? First, your research is a great place to start. So... If you were to evaluate the above options: Metabase Seal Report BIRT KNIME How would each of these score (on a scale of 1 to 5) on the following:? * Component exists as a "plug in" with few required integration changes and is thus more easily maintained * Component can deployed to be highly scalable - e.g. doesn't impact I/O on the core deployment * Component allows for additional customization or can be "built on top of" for extensibility *Could you say?* Early on in the Mifos project we built a BIRT reporting engine. At the time it was the best open source option out there. It seems to have to staying power. ;) > Integrate Alternative Reporting tool for Fineract 1.x without Apache License > violations > --- > > Key: FINERACT-1125 > URL: https://issues.apache.org/jira/browse/FINERACT-1125 > Project: Apache Fineract > Issue Type: Improvement > Components: Build >Affects Versions: 1.4.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard > > read here [https://github.com/apache/fineract/pull/1262] > and > [https://www.apache.org/legal/resolved.html#category-x] > and > [https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License] > We need a reporting support that will not have licensing violations > for example the following > h1. BIRT > [https://www.eclipse.org/birt/about/] their license details are > [https://en.wikipedia.org/wiki/Eclipse_Public_License] > h1. KNIME > [|https://www.knime.com/downloads/full-license] > [https://www.knime.com/knime-report-designer > |https://www.knime.com/knime-report-designer]their licence details are > [https://www.knime.com/downloads/full-license] > h1. METABASE > [https://www.metabase.com/] and their license is > [https://www.metabase.com/license/] > h1. SEAL REPORT > [https://sealreport.org/] and their License is > [https://sealreport.org/#lineRequirements] > [https://www.spagobi.org/] and their license is > [https://www.spagobi.org/communities/license/] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1101:
Fix Version/s: 1.5.0
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.5.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1101) Swagger CodeGen Test Build using Gradle instead of Maven
[
https://issues.apache.org/jira/browse/FINERACT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184133#comment-17184133
]
Michael Vorburger commented on FINERACT-1101:
-
[~Grandolf49]looks like you're on this now with
[https://github.com/apache/fineract/pull/1271]. Do you want that for 1.5.0 or
1.4.0 still?
> Swagger CodeGen Test Build using Gradle instead of Maven
>
>
> Key: FINERACT-1101
> URL: https://issues.apache.org/jira/browse/FINERACT-1101
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Chinmay Kulkarni
>Priority: Minor
> Fix For: 1.5.0
>
>
> Looking at [https://travis-ci.org/github/apache/fineract/builds/714158191]
> for [https://github.com/apache/fineract/pull/1228] for FINERACT-838, I've
> noticed that the Swagger Client Code Generation seems to be built using
> Maven {{mvn}}... but on {{docs/developers/swagger/client.md}} we document the
> use of Gradle. This seems inconsistent, and requiring Fineract developers to
> have Maven installed just for this may be unnecessary?
> [~Grandolf49] was there a particular reason why you chose to build the client
> using Maven instead of Gradle on Travis in your PR? If none, would you be
> willing to raise a PR to change that?
> If that is not possible, the Travis CI should should at least use the Maven
> Wrapper {{./mvnw}} instead of {{mvn}}. And we should add Caching of Maven
> artifacts in addition to Gradle to the Travis CI configuration, to make it a
> bit faster.
> [~Manthan] [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1120) Two Factor Auth Filter Type Cast Error
[
https://issues.apache.org/jira/browse/FINERACT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184126#comment-17184126
]
James Dailey commented on FINERACT-1120:
Is the business requirement here to require Two Factor Authentication? Or is
it to enable the potential use of 2F?
> Two Factor Auth Filter Type Cast Error
> --
>
> Key: FINERACT-1120
> URL: https://issues.apache.org/jira/browse/FINERACT-1120
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Saransh Sharma
>Priority: Major
> Fix For: 1.5.0
>
>
> Error :
> java.lang.ClassCastException: class java.lang.String cannot be cast to class
> org.springframework.security.authentication.AnonymousAuthenticationToken
> {code:java}
> // AppUser user = (AppUser) authentication.getPrincipal();
> {code}
> This line has some type casting error exception when running the two factor
> mode.
> To enable two factor mode you need to run with -Psecurity=twofactor
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-757) Client list retrieval returns emtpy result when using search parameter
[ https://issues.apache.org/jira/browse/FINERACT-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184124#comment-17184124 ] Michael Vorburger commented on FINERACT-757: Oh yes, indeed [https://github.com/apache/fineract/commit/82568d93bf8234e377dc197b3b3d91bf558a2a45] shows that this IS on develop (and thus 1.4.0)... all good, sorry for the confusion! > Client list retrieval returns emtpy result when using search parameter > -- > > Key: FINERACT-757 > URL: https://issues.apache.org/jira/browse/FINERACT-757 > Project: Apache Fineract > Issue Type: Bug > Components: Client >Reporter: Angel Cajas >Assignee: Santosh Math >Priority: Critical > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Client list retrieval while using search parameters returns an empty result. > While testing /clients endpoint to search clients using search parameters > such as firstName, secondName or externalId the search gave no results. > Apparently in the past queries that required given paramaters were built > concatenating strings and sqlInjection validation was needed and the function > sqlEncodeString in the class ApiParametersHelper was used for this reason. > The function validated if parameters contained sqlInjection but also appended > quotation marks to the the given parameter, however parameters are being > passed as an object array instead of being appended to the query string so > this validation isn't needed anymore as it's done by the sqlTemplate class > used to run the query. > For example: Calling the sqlEncodeString modified the searchParam "Joe" to > "'Joe'" adding quotation marks and since there are no clients with quotation > marks in their name no clients were found and the result was empty. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1128) Travis build fails with connection refused
Petri Tuomola created FINERACT-1128:
---
Summary: Travis build fails with connection refused
Key: FINERACT-1128
URL: https://issues.apache.org/jira/browse/FINERACT-1128
Project: Apache Fineract
Issue Type: Bug
Reporter: Petri Tuomola
Travis build often fails with the following error when trying to check that the
Docker container has come up as expected:
http: error: ConnectionError: HTTPSConnectionPool(host='localhost', port=8443):
Max retries exceeded with url: /fineract-provider/actuator/health (Caused by
NewConnectionError(': Failed to establish a new connection: [Errno 111] Connection
refused',)) while doing GET request to URL:
[https://localhost:8443/fineract-provider/actuator/health]
Retrying the build works so this is an issue with infra rather than code - may
just be due to the Docker container taking longer than expected in coming up?
One possible solution could be to switch from http to curl and then use curl's
facility for retries - i.e. try the connection 5 times with 30 second breaks
between retries to see if the container comes up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
