[jira] [Resolved] (FINERACT-1200) OpenJPA logging to slf4j
[
https://issues.apache.org/jira/browse/FINERACT-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Awasum Yannick resolved FINERACT-1200.
--
Resolution: Fixed
Resolving to fixed as PR: [https://github.com/apache/fineract/pull/1393] has
been merged.
> OpenJPA logging to slf4j
>
>
> Key: FINERACT-1200
> URL: https://issues.apache.org/jira/browse/FINERACT-1200
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Major
> Fix For: 1.5.0
>
>
> FINERACT-1168 raises that, among others, OpenJPA currently logs directly to
> STDOUT should be routed to slf4j.. while I've noticed the related myself, I
> have not seen any (run time, not build time) output from OpenJPA -
> [~ptuomola] do you have any specific example of what you meant?
> Either way, this should be possible simply by setting {{openjpa.Log}} to
> {{slf4j}} "somewhere", according to
> https://openjpa.apache.org/builds/3.1.2/apache-openjpa/docs/index.html#ref_guide_logging_slf4j.
> Where is the "appropriate" place to set such properties?
> Of course, if we do FINERACT-849, then this becomes a moot point.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic updated FINERACT-1188: --- Affects Version/s: (was: 1.4.0) > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.5.0 > > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic updated FINERACT-1188: --- Fix Version/s: 1.5.0 > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.5.0 > > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic updated FINERACT-1188: --- Affects Version/s: 1.4.0 > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Affects Versions: 1.4.0 >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.5.0 > > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic resolved FINERACT-1188. Resolution: Fixed > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > Fix For: 1.5.0 > > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212801#comment-17212801 ] Aleksandar Vidakovic commented on FINERACT-1188: Alright, this looks much better. Full build with all artifacts is working, Eclipse project import works including immediate Gradle build execution and source directories are shown in Eclipse only under fineract-provider (as expected, because it's the only Java module); in my previous attempt source folders appeared both in the root project "fineract" and "fineract-provider" which was wrong. The Docker build is also working which I think was the in my previous attempt to run the final health tests successfully in Travis. Would be great if you guys could have a look at this, the diff is a lot easier to review this time. Thanks again. > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[
https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212752#comment-17212752
]
Aleksandar Vidakovic commented on FINERACT-1188:
[~ptuomola] [~vorburger]
Well, can't live in a world where I'm losing against a Gradle task ;) ... as I
said above there was an issue with the clean task, but the source of this is
not exactly what I described. I thought that the root project and
fineract-provider are somehow competing against each other. Turns out: the
shell script execution of the Gradle setup inside the build folder that was
created by the Swagger code generator is messing things up. I tried all kinds
of tricks to twist the clean task's arm, but I was doing it in the wrong place!
Turning off the code generator and not executing the generated Gradle file...
makes everything work. I got a hint about this issue when Spotless suddenly
showed rule violations in that generated code; just needed to exclude all
"build" folders; strange thing is why it worked before, because I think it
shouldn't have... single module or not doesn't really matter... the build
folder was not excluded before so Spotless should have complained, but it
didn't.
Another potential issue: having two buildscript sections doesn't seem to be a
good idea, so I moved it to the root build.gradle file. I think that was also
the reason why source folders would show up in Eclipse both in the root project
("fineract") and the child module ("fineract-provider"). Will test this again.
Anyway... looks like there's progress... only 3 files changed so far... should
be a lot easier to review too.
FYI
> README and other files are not covered by Spotless
> --
>
> Key: FINERACT-1188
> URL: https://issues.apache.org/jira/browse/FINERACT-1188
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Aleksandar Vidakovic
>Priority: Major
>
> Would it be possible to extract JUST the work related to make README and
> other files are covered by Spotless from
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]
> and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and
> keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client,
> fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial
> formatting changes itself which Spotbugs made once you change the layout, but
> without any build change - just send them first, separately - get that out of
> the way?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandar Vidakovic closed FINERACT-1186. -- Fix Version/s: 1.5.0 Resolution: Fixed See [~francisguchie] 's comments for the solution. > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > Fix For: 1.5.0 > > Attachments: image-2020-10-12-18-31-01-132.png > > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (FINERACT-1188) README and other files are not covered by Spotless
[
https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandar Vidakovic reopened FINERACT-1188:
Tried to do this from scratch, because the existing PR created too many
conflicts on rebase. There is still an issue remaining on integrationTest
("connection refused", not sure if that is related to my changes, but locally
the Docker container is running just fine).
The new approach reveals even more issues with the plugin configs; moving just
Spotless to the top-level didn't work as expected.
Concentrating on other stuff in the meanwhile until I get a better idea how a
step by step implementation approach to cleanup build.gradle can work.
> README and other files are not covered by Spotless
> --
>
> Key: FINERACT-1188
> URL: https://issues.apache.org/jira/browse/FINERACT-1188
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Aleksandar Vidakovic
>Priority: Major
>
> Would it be possible to extract JUST the work related to make README and
> other files are covered by Spotless from
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]
> and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and
> keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client,
> fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial
> formatting changes itself which Spotbugs made once you change the layout, but
> without any build change - just send them first, separately - get that out of
> the way?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212612#comment-17212612 ] Francis Guchie commented on FINERACT-1186: -- This issue can ought to be closed > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > Attachments: image-2020-10-12-18-31-01-132.png > > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212611#comment-17212611 ] Francis Guchie commented on FINERACT-1186: -- [~vorburger] said running with -Pfineract.release (this is what i will test next time.) I had to stop a java process on the windows PC before making another successful build because as [~aleks] rightfully said there seemed to be another gradle process running in the background Hope this helps someone like [~ikimbrah] > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > Attachments: image-2020-10-12-18-31-01-132.png > > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212604#comment-17212604 ] Aleksandar Vidakovic commented on FINERACT-1186: [~francisguchie] Good to hear you are unstuck and thanks for the description; might help others who run into the same situation. > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > Attachments: image-2020-10-12-18-31-01-132.png > > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212602#comment-17212602 ] Aleksandar Vidakovic commented on FINERACT-1188: [~vorburger] Ok... I am currently trying this out from scratch with a brand new branch... and there are a couple of issues here: Having the build folder artificially set inside the project root (including twisting various plugins to point to that build folder) just doesn't work with multi-module (no idea why this was set like this anyway; the defaults usually work very well and I see no reason why a fineract-provider/build in the original code wouldn't have worked) So, the top-level is also a project (a simple one, but still); the "clean" task creates a concurrency issue, because child projects (fineract-provider) run their clean tasks in parallel. This is important, because plugins like the Swagger file generator "think" they've already created all necessary files (they did), but are unaware that the root project deleted the contents of the build folder (and all generated artifacts). I thought the solution for that is to just leave every module's build folder to itself (i.e. "fineract-provider/build" etc.), but there are still things failing... and I have a feeling it's because we have parts that are defined at root level and also in the build.gradle; I'm not talking about duplication (removed already), I get the impression that either this is done properly for everything (that can be defined on the top level) or we can chase these Heisenbugs for longer. Not sure how to proceed here best, but this micro-step approach is a bit debug intensive. If you want to give this a shot yourself then please go ahead; can't exclude that I'm missing something (maybe simple) here, but for now I will leave this aside and maybe have later a fresh start hopefully with another idea how to do this step by step. > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212591#comment-17212591 ] Francis Guchie commented on FINERACT-1186: -- I think we we can close this issue > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > Attachments: image-2020-10-12-18-31-01-132.png > > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Guchie updated FINERACT-1186: - Attachment: image-2020-10-12-18-31-01-132.png > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > Attachments: image-2020-10-12-18-31-01-132.png > > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212589#comment-17212589 ] Francis Guchie commented on FINERACT-1186: -- [~aleks], [~vorburger] [~awasum] i managed to reproduce this error as you can see below, the windows have their own minds we need to make them understand after a successful build, i had a failed build - and when i checked the swagger-code-fineract folder was being big headed to go away. Please see image below BUILD SUCCESSFUL in 11m 14s 41 actionable tasks: 38 executed, 3 up-to-date $ ./gradlew clean bootWar > Task :fineract-provider:clean FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':fineract-provider:clean'. > java.io.IOException: Unable to delete directory 'D:\0a\fineract\build' Failed to delete some children. This might happen because a process has files open or has its working directory set in the target directory. - D:\0a\fineract\build\swagger-code-fineract !image-2020-10-12-18-31-01-132.png! > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > Attachments: image-2020-10-12-18-31-01-132.png > > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1186) Failing to Build latest code
[ https://issues.apache.org/jira/browse/FINERACT-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212480#comment-17212480 ] Francis Guchie commented on FINERACT-1186: -- [~aleks] and [~awasum] Picked up the latest develop branch and the build was successful - And I cannot reproduce the error above. This issues should be closed i think this is a windows specific issue like [~vorburger] says > Failing to Build latest code > > > Key: FINERACT-1186 > URL: https://issues.apache.org/jira/browse/FINERACT-1186 > Project: Apache Fineract > Issue Type: New Feature > Components: Build >Affects Versions: 1.4.0, 1.5.0 >Reporter: Francis Guchie >Priority: Major > Labels: hard_to_verify, windows > > > Task :buildSwaggerCodeFineract > Starting a Gradle Daemon (subsequent builds will be faster) > > Task :clean UP-TO-DATE > > Task :compileJava > Note: > D:\0a\fineract\build\swagger-code-fineract\src\main\java\org\apache\fineract\client\ApiClient.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > > Task :processResources NO-SOURCE > > Task :classes > > Task :jar > > Task :assemble > > Task :compileTestJava > > Task :processTestResources NO-SOURCE > > Task :testClasses > > Task :test > > Task :check > > Task :build > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6/userguide/command_line_interface.html#sec:command_line_warnings > BUILD SUCCESSFUL in 55s > 5 actionable tasks: 4 executed, 1 up-to-date > > Task :srcDistTar FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':srcDistTar'. > > Could not add file > > 'D:\0a\fineract\fineract-provider\.gradle\6.6.1\executionHistory\executionHistory.lock' > > to TAR > > 'D:\0a\fineract\build\distributions\apache-fineract-1.4.0-src-release-1.4.0-661-g43fdde5-dirty.tar.gz'. > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. Run with --scan to get full insights. > * Get more help at https://help.gradle.org > Deprecated Gradle features were used in this build, making it incompatible > with Gradle 7.0. > Use '--warning-mode all' to show the individual deprecation warnings. > See > https://docs.gradle.org/6.6.1/userguide/command_line_interface.html#sec:command_line_warnings > BUILD FAILED in 6m 20s > 25 actionable tasks: 25 executed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1193) activeMq error log at startup, while not a strict requirement ?
[ https://issues.apache.org/jira/browse/FINERACT-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212342#comment-17212342 ] Vincent FUCHS commented on FINERACT-1193: - done. [https://github.com/apache/fineract/pull/1395] is green. Feel free to update my change in the doc if required > activeMq error log at startup, while not a strict requirement ? > > > Key: FINERACT-1193 > URL: https://issues.apache.org/jira/browse/FINERACT-1193 > Project: Apache Fineract > Issue Type: Improvement > Components: System >Affects Versions: 1.4.0 >Reporter: Vincent FUCHS >Priority: Minor > > Hi, > When starting Fineract according to the documentation, I get an error in the > logs regarding ActiveMQ not being available. But the application starts > nonetheless. > > The documentation doesn't mention the need for a messaging system (unlike th > enedd for mySql DB) - I guess it's optional ? > > Then, shouldn't MessagingConfiguration be enabled only when a certain Spring > profile is applied at startup ? This would avoid loading messaging related > Spring beans, and getting a puzzling error message at startup. > > If somebody can confirm the approach to take, I can try to "fix" this. > > Thanks > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1178) Allow usage of SQL connection parameters
[
https://issues.apache.org/jira/browse/FINERACT-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212232#comment-17212232
]
Cedric Khin commented on FINERACT-1178:
---
Thank you for your reply, your presentation is indeed interesting !
I will check the issue, thanks for linking it.
> Allow usage of SQL connection parameters
>
>
> Key: FINERACT-1178
> URL: https://issues.apache.org/jira/browse/FINERACT-1178
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Database
>Reporter: Cedric Khin
>Assignee: Cedric Khin
>Priority: Minor
> Fix For: 1.5.0
>
>
> By allowing the usage of connection parameters in the SQL connection string,
> we can pass useful parameters for i.e. Google Cloud SQL connection (using
> [https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory] for
> example), that would look like this :
> {code:java}
> jdbc:mysql://google:/?cloudSqlInstance==com.google.cloud.sql.mysql.SocketFactory{code}
> Currently it isn't possible to properly add connection parameters (except
> through an ugly hack in JDBCDriverConfig.constructProtocol()).
> As far as I know, using a connection string with the aforementioned Cloud SQL
> JDBC Socket Factory is the only way I found to connect to Cloud SQL. Outside
> of using Cloud SQL, I believe this feature may be useful for some people that
> need to inject some parameters to their connection string to the database.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINCN-112) Update compile and target SDK versions of the app
[ https://issues.apache.org/jira/browse/FINCN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212215#comment-17212215 ] Mariia Podorvanova commented on FINCN-112: -- Hi I am Maria, an applicant for the Outreachy internship Dec 2020 program. I am interested in the "Update and Upgrade Fineract CN" project. The issue said "Android SDK version 27 must be changed to 28", but the project's SDK version was already 28. I have changed it to 29 and created a [pull request|https://github.com/apache/fineract-cn-mobile/pull/113] for this task. > Update compile and target SDK versions of the app > - > > Key: FINCN-112 > URL: https://issues.apache.org/jira/browse/FINCN-112 > Project: Fineract Cloud Native > Issue Type: Improvement > Components: fineract-cn-mobile > Environment: Ubuntu 18.04.1 > Android Studio 3.2.1 >Reporter: Dundi Raja Vamsi Reddy >Priority: Minor > Labels: Gradle, SDK, beginner > > *Summary:* > The compileSdkVersion and targetSdkVersion which are set to versions 27 and > 27, respectively, must be changed to 28( Android Pie) as the latest Android > APIs must be used to make use of the latest features. > There will be no issue and will not break any compatibility with older > versions as minSdkVersion remains same -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINCN-193) bring fineract-cn-interoperation up to date with other micro services
[ https://issues.apache.org/jira/browse/FINCN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser updated FINCN-193: -- Labels: outreachy2020 (was: ) > bring fineract-cn-interoperation up to date with other micro services > - > > Key: FINCN-193 > URL: https://issues.apache.org/jira/browse/FINCN-193 > Project: Fineract Cloud Native > Issue Type: Sub-task >Reporter: Juhan Aasaru >Priority: Major > Labels: outreachy2020 > > fineract-cn-interoperation is missing changes that have been applied to other > micro services. These are: > # build with Travis-ci and add artifacts to artifactory > # switch MariaDB to Postgres > # switch Hibernate to EclipseLink > # create d multi-stage-docker build > # update gradle to 4.10.3 > # [FINCN-183 send our full url to > eureka|https://github.com/apache/fineract-cn-notifications/commit/67ae16ad8cda91bcf392d48ba362de8c4a9dd09c] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINCN-186) Research upgrading to Java 11
[ https://issues.apache.org/jira/browse/FINCN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser updated FINCN-186: -- Labels: outreachy2020 (was: ) > Research upgrading to Java 11 > - > > Key: FINCN-186 > URL: https://issues.apache.org/jira/browse/FINCN-186 > Project: Fineract Cloud Native > Issue Type: Improvement >Reporter: Juhan Aasaru >Priority: Major > Labels: outreachy2020 > > Fineract-CN works on Java 8 and eventually the support will be discontinued. > Next Long Term Support (LTS) version is Java 11. > Also we could benefit from the module system introduced by Java 9 - running > apps on module system would require less memory (since we don't need all the > modules of Java). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINCN-240) Use a bot to automate dependency updates
Yemdjih Kaze Nasser created FINCN-240: - Summary: Use a bot to automate dependency updates Key: FINCN-240 URL: https://issues.apache.org/jira/browse/FINCN-240 Project: Fineract Cloud Native Issue Type: Sub-task Reporter: Yemdjih Kaze Nasser To save a lot of time and make sure that packages are updated frequently, it would be good to have a bot such as renovate bot (as we have in Fineract 1.x) or any other bot handle this so the they can just be reviewed and merged when needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINCN-172) Upgrade all fineract-cn-* apps to latest Spring Boot / Spring Framework
[ https://issues.apache.org/jira/browse/FINCN-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser reassigned FINCN-172: - Assignee: (was: Saransh Sharma) > Upgrade all fineract-cn-* apps to latest Spring Boot / Spring Framework > --- > > Key: FINCN-172 > URL: https://issues.apache.org/jira/browse/FINCN-172 > Project: Fineract Cloud Native > Issue Type: Improvement >Reporter: Juhan Aasaru >Priority: Major > Labels: outreachy2020 > Time Spent: 0.5h > Remaining Estimate: 0h > > Proposed by [~Kwesi] : > 1. Upgrading Fineract CN from Spring Boot 1.4.1 to 2.1.+ > 2. Upgrading Fineract CN from Spring Framework from 4.3.3 to 5.1.+ > > This should be done in the same time to all fineract-cn-* applications > (similar to https://issues.apache.org/jira/browse/FINCN-170 ) - so one would > create pull requests for all apps and once the work is accepted all pull > requests would be merged together. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINCN-172) Upgrade all fineract-cn-* apps to latest Spring Boot / Spring Framework
[ https://issues.apache.org/jira/browse/FINCN-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser updated FINCN-172: -- Labels: outreachy2020 (was: ) > Upgrade all fineract-cn-* apps to latest Spring Boot / Spring Framework > --- > > Key: FINCN-172 > URL: https://issues.apache.org/jira/browse/FINCN-172 > Project: Fineract Cloud Native > Issue Type: Improvement >Reporter: Juhan Aasaru >Assignee: Saransh Sharma >Priority: Major > Labels: outreachy2020 > Time Spent: 0.5h > Remaining Estimate: 0h > > Proposed by [~Kwesi] : > 1. Upgrading Fineract CN from Spring Boot 1.4.1 to 2.1.+ > 2. Upgrading Fineract CN from Spring Framework from 4.3.3 to 5.1.+ > > This should be done in the same time to all fineract-cn-* applications > (similar to https://issues.apache.org/jira/browse/FINCN-170 ) - so one would > create pull requests for all apps and once the work is accepted all pull > requests would be merged together. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINCN-110) Place `google()` repository as the first priority repository
[
https://issues.apache.org/jira/browse/FINCN-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yemdjih Kaze Nasser updated FINCN-110:
--
Labels: Gradle beginner outreachy2020 (was: Gradle beginner)
> Place `google()` repository as the first priority repository
>
>
> Key: FINCN-110
> URL: https://issues.apache.org/jira/browse/FINCN-110
> Project: Fineract Cloud Native
> Issue Type: Improvement
> Components: fineract-cn-mobile
> Environment: Ubuntu 18.04.1
> Android Studio 3.2.1
>Reporter: Dundi Raja Vamsi Reddy
>Priority: Minor
> Labels: Gradle, beginner, outreachy2020
>
> In project level build. gradle file jcenter() repository have first priority
> than google() repository. My idea is to Place {{google()}} repository as the
> first priority repository to avoid such errors in the future like
> *Failed to resolve: multidex-instrumentation*
> Here is the link to check to solve this error
> [https://stackoverflow.com/questions/45608362/android-studio-3-0-beta-1-failed-to-resolve-com-android-supportmultidex1-0-2|https://github.com/amahi/android/issues/here]
> In our project
> [here|https://github.com/apache/fineract-cn-mobile/blob/development/build.gradle#L20]
> google must be placed as a first priority.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINCN-60) Update Readme
[ https://issues.apache.org/jira/browse/FINCN-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser updated FINCN-60: - Labels: outreachy2020 (was: ) > Update Readme > - > > Key: FINCN-60 > URL: https://issues.apache.org/jira/browse/FINCN-60 > Project: Fineract Cloud Native > Issue Type: Improvement > Components: fineract-cn-mobile >Reporter: Dilpreet Singh >Priority: Minor > Labels: outreachy2020 > > ReadMe.md does not have proper infromation.Actually for a begginer to start > with it is very difficult to understand the project. So it is requirede to > update readme file > Steps to reproduce: > will gather the required and additional information from Various Sources and > write it in readme in a proper manner > provide link to dummy login id > paste screenshot for app -- This message was sent by Atlassian Jira (v8.3.4#803005)
