[jira] [Assigned] (FINERACT-935) StaffNotFoundException at StaffRepositoryWrapper
[
https://issues.apache.org/jira/browse/FINERACT-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benura Abeywardena reassigned FINERACT-935:
---
Assignee: Benura Abeywardena
> StaffNotFoundException at StaffRepositoryWrapper
>
>
> Key: FINERACT-935
> URL: https://issues.apache.org/jira/browse/FINERACT-935
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Benura Abeywardena
>Priority: Major
>
> See FINERACT-932 for general background, and determine if this error log can
> and should be "fixed", or if this represents a condition that shouldn't be
> logged as an error (or conclude that this is a totally valid error log that
> is useful, any why):
> {code}org.apache.fineract.organisation.staff.exception.StaffNotFoundException
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.lambda$findByOfficeHierarchyWithNotFoundDetection$1(StaffRepositoryWrapper.java:54)
> at java.util.Optional.orElseThrow(Optional.java:290)
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.findByOfficeHierarchyWithNotFoundDetection(StaffRepositoryWrapper.java:54)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:248)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke(){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-935) StaffNotFoundException at StaffRepositoryWrapper
[
https://issues.apache.org/jira/browse/FINERACT-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270819#comment-17270819
]
Benura Abeywardena commented on FINERACT-935:
-
[~vorburger] I would like to work on this
> StaffNotFoundException at StaffRepositoryWrapper
>
>
> Key: FINERACT-935
> URL: https://issues.apache.org/jira/browse/FINERACT-935
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Major
>
> See FINERACT-932 for general background, and determine if this error log can
> and should be "fixed", or if this represents a condition that shouldn't be
> logged as an error (or conclude that this is a totally valid error log that
> is useful, any why):
> {code}org.apache.fineract.organisation.staff.exception.StaffNotFoundException
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.lambda$findByOfficeHierarchyWithNotFoundDetection$1(StaffRepositoryWrapper.java:54)
> at java.util.Optional.orElseThrow(Optional.java:290)
> at
> org.apache.fineract.organisation.staff.domain.StaffRepositoryWrapper.findByOfficeHierarchyWithNotFoundDetection(StaffRepositoryWrapper.java:54)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient(ClientWritePlatformServiceJpaRepositoryImpl.java:248)
> at
> org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$71ca1b7f.invoke(){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1293) SchedulerJobsTestResults testInterestTransferForSavings() and testExecuteStandingInstructionsJobOutcome() fail when run locally, but pass on Travis CI
[
https://issues.apache.org/jira/browse/FINERACT-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270803#comment-17270803
]
Petri Tuomola commented on FINERACT-1293:
-
Hi
Every time I've looked at these issues, they've been all related to interest
calculation. And when something goes wrong, it usually affects multiple tests:
so when there's something funny going on with number of days in month, or
initial date vs test date vs interest date, it usually affects multiple
products and hence multiple tests.
The fundamental issue here is that we calculate the expected interest
differently in the test and in the real code. The real code is much more
correct/accurate, the test code is a crude approximation - hence often gets it
wrong in corner cases. But if we used the real code in both cases then it would
be of course meaningless as a test: we'd test the same code against itself.
The only two options to fix this "properly" are:
# Continue improving the test code as we see corner cases. This is very
wasteful as we are basically rebuilding the same logic into the test as we
already have in the real code.
# Remove any dependency on the test code to "today" and instead use absolute
dates.
The reason the tests currently break is because many of the dates are
calculated related to "TODAY" - i.e. "start a loan 4 months ago and then see
what the balance is today". The problem comes when the date "4 months ago" is
somehow different than what was expected when the test was written - e.g. it's
in a different year, or there's a leap day, or there's a month end very close
to either start or end date, or is a weekend/non-banking day, or one of the
intermediate dates when you then move forward from it for 1 month at at time is
an non-banking day etc".
If, instead of building dates related to "today" we would always use a
fixed/absolute date as a start/disbursement date etc then these problems would
go away - the relationships between the dates would always be the same.
But that will require rewriting all the tests and recalculating the expected
values. Still time better spent than continuously enhancing / debugging the
test login imho.
Note that I'm commenting based on investigation of the other test failures that
I've looked at. I haven't investigated this particular one, so it is very
possible that this is about something else...
> SchedulerJobsTestResults testInterestTransferForSavings() and
> testExecuteStandingInstructionsJobOutcome() fail when run locally, but pass
> on Travis CI
> --
>
> Key: FINERACT-1293
> URL: https://issues.apache.org/jira/browse/FINERACT-1293
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Major
>
> While locally investigating FINERACT-924, I've found that the problem from
> that issue (the testApplyAnnualFeeForSavingsJobOutcome()) WORKED locally for
> me, but instead 2 other tests locally consistently failed on me, even though
> they do seem to always pass on Travis CI, namely:
> {noformat}
> org.opentest4j.AssertionFailedError: Verifying opening Balance ==> expected:
> <10.0> but was: <100918.32>
> at
> org.apache.fineract.integrationtests.SchedulerJobsTestResults.testInterestTransferForSavings(SchedulerJobsTestResults.java:897){noformat}
> and:
> {noformat}
> org.opentest4j.AssertionFailedError: Verifying From Savings Balance after
> Successful completion of Scheduler Job ==> expected: <500.0> but was: <1000.0>
> at
> org.apache.fineract.integrationtests.SchedulerJobsTestResults.testExecuteStandingInstructionsJobOutcome(SchedulerJobsTestResults.java:659){noformat}
> This already came up back in FINERACT-857, where I had suspected that
> _"perhaps these individual test methods are not as isolated from each other
> as they should be"_.
> Or maybe that has something to do with the {{export TZ=Asia/Kolkata}} in
> [https://github.com/apache/fineract/blob/develop/.travis.yml#L55] ?
> [~ptuomola] (or perhaps [~aleks]) I don't suppose you happen to know more
> about this?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1285) Upload Credit Report to ThitsaWorks CB
[ https://issues.apache.org/jira/browse/FINERACT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270782#comment-17270782 ] Michael Vorburger commented on FINERACT-1285: - With https://github.com/apache/fineract/pull/1567 just merged, should this JIRA be Resolved, now? > Upload Credit Report to ThitsaWorks CB > -- > > Key: FINERACT-1285 > URL: https://issues.apache.org/jira/browse/FINERACT-1285 > Project: Apache Fineract > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Rahul Pawar >Assignee: Rahul Pawar >Priority: Major > Fix For: 1.5.0 > > > It is a feature that will be used to upload the Credit Reports(.csv files) to > ThitsaWorks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1285) Upload Credit Report to ThitsaWorks CB
[ https://issues.apache.org/jira/browse/FINERACT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1285: Fix Version/s: 1.5.0 > Upload Credit Report to ThitsaWorks CB > -- > > Key: FINERACT-1285 > URL: https://issues.apache.org/jira/browse/FINERACT-1285 > Project: Apache Fineract > Issue Type: New Feature >Affects Versions: 1.5.0 >Reporter: Rahul Pawar >Assignee: Rahul Pawar >Priority: Major > Fix For: 1.5.0 > > > It is a feature that will be used to upload the Credit Reports(.csv files) to > ThitsaWorks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1304) CI/CD (currently Travis) should test Kubernetes scripts
[ https://issues.apache.org/jira/browse/FINERACT-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benura Abeywardena reassigned FINERACT-1304: Assignee: Benura Abeywardena > CI/CD (currently Travis) should test Kubernetes scripts > --- > > Key: FINERACT-1304 > URL: https://issues.apache.org/jira/browse/FINERACT-1304 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Benura Abeywardena >Priority: Major > Labels: kubernetes, technical > > While I was reviewing recent contributions from [~BLasan] which improve this > project's Kubernetes YAML descriptors, I did those reviews "blindly" - I > actually cannot be 100% sure they really work - the code reviews are based on > (my understanding and a level of) "implicit trust". > In a perfect world, of course, it could be nice if our CI/CD (currently > Travis) would test it! > I haven't looked into how difficult or not this may be. If it's easy e.g. to > just use minikube in Travis builds, then this may not be that difficult. The > goal essentially would be just to script > https://github.com/apache/fineract#instructions-to-run-on-kubernetes in > https://github.com/apache/fineract/blob/develop/.travis.yml, and then run the > same curl on the actuator which we already do for the docker compose. > Something to keep in mind is that this should not massively slow down PR > build times; they are already very long. > [~BLasan] if that is something that interests you, feel free to take this > issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1304) CI/CD (currently Travis) should test Kubernetes scripts
[ https://issues.apache.org/jira/browse/FINERACT-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270675#comment-17270675 ] Benura Abeywardena commented on FINERACT-1304: -- [~vorburger] would like to on this issue sir. > CI/CD (currently Travis) should test Kubernetes scripts > --- > > Key: FINERACT-1304 > URL: https://issues.apache.org/jira/browse/FINERACT-1304 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > Labels: kubernetes, technical > > While I was reviewing recent contributions from [~BLasan] which improve this > project's Kubernetes YAML descriptors, I did those reviews "blindly" - I > actually cannot be 100% sure they really work - the code reviews are based on > (my understanding and a level of) "implicit trust". > In a perfect world, of course, it could be nice if our CI/CD (currently > Travis) would test it! > I haven't looked into how difficult or not this may be. If it's easy e.g. to > just use minikube in Travis builds, then this may not be that difficult. The > goal essentially would be just to script > https://github.com/apache/fineract#instructions-to-run-on-kubernetes in > https://github.com/apache/fineract/blob/develop/.travis.yml, and then run the > same curl on the actuator which we already do for the docker compose. > Something to keep in mind is that this should not massively slow down PR > build times; they are already very long. > [~BLasan] if that is something that interests you, feel free to take this > issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1304) CI/CD (currently Travis) should test Kubernetes scripts
Michael Vorburger created FINERACT-1304: --- Summary: CI/CD (currently Travis) should test Kubernetes scripts Key: FINERACT-1304 URL: https://issues.apache.org/jira/browse/FINERACT-1304 Project: Apache Fineract Issue Type: Improvement Reporter: Michael Vorburger While I was reviewing recent contributions from [~BLasan] which improve this project's Kubernetes YAML descriptors, I did those reviews "blindly" - I actually cannot be 100% sure they really work - the code reviews are based on (my understanding and a level of) "implicit trust". In a perfect world, of course, it could be nice if our CI/CD (currently Travis) would test it! I haven't looked into how difficult or not this may be. If it's easy e.g. to just use minikube in Travis builds, then this may not be that difficult. The goal essentially would be just to script https://github.com/apache/fineract#instructions-to-run-on-kubernetes in https://github.com/apache/fineract/blob/develop/.travis.yml, and then run the same curl on the actuator which we already do for the docker compose. Something to keep in mind is that this should not massively slow down PR build times; they are already very long. [~BLasan] if that is something that interests you, feel free to take this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-990) Kubernetes set-up for development
[ https://issues.apache.org/jira/browse/FINERACT-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270669#comment-17270669 ] Michael Vorburger commented on FINERACT-990: [~BLasan] given your apparent interest in Kubernetes for Fineract, perhaps this issue is something that could interest you. > Kubernetes set-up for development > - > > Key: FINERACT-990 > URL: https://issues.apache.org/jira/browse/FINERACT-990 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Petri Tuomola >Priority: Minor > Labels: kubernetes, technical > > The current Kubernetes scripts are not ideal for development purposes - the > following three improvements could be made: > * The script line in kubectl-startup to create a password does not work on > MacOS (tr does not like the data it gets from urandom) > * Kubernetes configuration was pulling in the latest apache/fineract image > rather than using the one built by our docker-compose build > * The MySQL password passed in during the initial run of Kubernetes seems to > be getting stored on the PersistentVolume /mnt/data. Since we generate a new > password every time we run kubectl-startup whereas the data on the volume is > retained, at least for me this meant only the first startup worked. After > that all the startups failed, as Fineract is not able to login to MySQL > These can be fixed with: > * kubectl create secret generic fineract-tenants-db-secret > --from-literal=username=root --from-literal=password=$(head /dev/urandom | > *env LC_C TYPE=C* tr -dc A-Za-z0-9 | head -c 16) to get the password > generation to work on MacOS > * Changing the image label to be the same across docker-compose.yml and > fineract-server-deployment.yml > * Added persistentVolumeReclaimPolicy: Recycle to the PersistentVolume spec > in fineractmysql-deployment.yml. This way the volume gets wiped after each > shutdown, allowing the new password to be used for MySQL. Of course also the > data gets wiped, so a better option would probably be to keep the generated > secret and reuse it from one startup to next. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-882) Include UI in Fineract Kubernetes example deployment descriptor
[ https://issues.apache.org/jira/browse/FINERACT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270668#comment-17270668 ] Michael Vorburger commented on FINERACT-882: [~BLasan] given your apparent interest in Kubernetes for Fineract, perhaps this issue is something that could interest you. > Include UI in Fineract Kubernetes example deployment descriptor > --- > > Key: FINERACT-882 > URL: https://issues.apache.org/jira/browse/FINERACT-882 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Michael Vorburger >Priority: Trivial > Labels: UI, kubernetes, technical > > The Kubernetes deployment contributed in FINERACT-783 runs the Apache > Fineract back-end (based on Fineract's Docker Compose set-up). > What would be really neat, for both the Kubernetes as well as the Docker > Compose set ups, would be if they would include a UI for Fineract as well! > We should probably start with the (old) > https://github.com/openMF/community-app/ and later add the (new) > https://github.com/openMF/web-app/. > The idea would be to build these UIs in Docker containers, and include them > in the Kubernetes deployment / Docker Compose YAMLs. The UI should obviously > be pre-configured to "just work" for the back-end, so there may be some work > to change the URL the UI uses by default to talk to the REST services. > There was some related work which would likely need to be completed as part > of this issue: > * https://github.com/openMF/community-app/issues/3106 > * https://github.com/openMF/community-app/pull/3107 > * https://github.com/openMF/community-app/issues/3112 > FYI [~xurror], [~awasum], [~angeh] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1296) Needs to add Liveliness & Readiness Probes for fineract server deployment
[ https://issues.apache.org/jira/browse/FINERACT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270666#comment-17270666 ] Michael Vorburger commented on FINERACT-1296: - > Michael VorburgerSir what do you think about this? [~BLasan] I typically prefer and find it more productive to just review proposed code changes in PRs than discussing ideas in JIRA issues :) You are great. We appreciate your contributions. So just GO FOR IT! > Needs to add Liveliness & Readiness Probes for fineract server deployment > - > > Key: FINERACT-1296 > URL: https://issues.apache.org/jira/browse/FINERACT-1296 > Project: Apache Fineract > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Benura Abeywardena >Assignee: Benura Abeywardena >Priority: Minor > Fix For: 1.5.0 > > > It's better to add liveliness & readiness probes for fineract container in > order to avoid manual restarting of a container if it gets failed and to > determine when the container will be available for accepting traffic -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1294) Error in volume mounting in mysql 5.7 container
[ https://issues.apache.org/jira/browse/FINERACT-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-1294. - Resolution: Fixed [~BLasan] I'm Resolving this, given that I've just Merged the Fix. You can Resolve JIRA issues yourself as well in the future, AFTER the related PR have been merged! :P > Error in volume mounting in mysql 5.7 container > --- > > Key: FINERACT-1294 > URL: https://issues.apache.org/jira/browse/FINERACT-1294 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.4.0 > Environment: Kubectl Client Version - 1.20.1 > Kubectl Server Version - 1.19.2 > OS - Ubuntu 20.04 > Minikube Version - 1.14.2 >Reporter: Benura Abeywardena >Assignee: Benura Abeywardena >Priority: Blocker > Fix For: 1.5.0 > > > Needs to change the liveness probe exec command to avoid printing "Access > Denied" issue on Logs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (FINERACT-1292) Needs to add ReadinessProbe for MySql pod
[ https://issues.apache.org/jira/browse/FINERACT-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reopened FINERACT-1292: - > Needs to add ReadinessProbe for MySql pod > - > > Key: FINERACT-1292 > URL: https://issues.apache.org/jira/browse/FINERACT-1292 > Project: Apache Fineract > Issue Type: Task >Affects Versions: 1.4.0 >Reporter: Benura Abeywardena >Assignee: Benura Abeywardena >Priority: Minor > Fix For: 1.5.0 > > > In mysql deployment it's better to add ReadinessProbe which tells when the > container will be available for accepting traffic. This can be achieved by > using a command like `mysqladmin ping -u -p` to check whether > a mysql user has been properly created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1292) Needs to add ReadinessProbe for MySql pod
[ https://issues.apache.org/jira/browse/FINERACT-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270663#comment-17270663 ] Michael Vorburger commented on FINERACT-1292: - [~BLasan] I'm confused why you have set this issue to Status: Resolved, Resolution: Implemented already? You should do that AFTER the PR for the issue, in this case https://github.com/apache/fineract/pull/1572, has been merged, not before... :D > Needs to add ReadinessProbe for MySql pod > - > > Key: FINERACT-1292 > URL: https://issues.apache.org/jira/browse/FINERACT-1292 > Project: Apache Fineract > Issue Type: Task >Affects Versions: 1.4.0 >Reporter: Benura Abeywardena >Assignee: Benura Abeywardena >Priority: Minor > Fix For: 1.5.0 > > > In mysql deployment it's better to add ReadinessProbe which tells when the > container will be available for accepting traffic. This can be achieved by > using a command like `mysqladmin ping -u -p` to check whether > a mysql user has been properly created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1295) Log only WARN & ERR but not INFO anymore
[ https://issues.apache.org/jira/browse/FINERACT-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270661#comment-17270661 ] Michael Vorburger commented on FINERACT-1295: - https://lists.apache.org/thread.html/r9e3de9996a7f9f1bd49615b5a7d44f6c8daeca5cbccdac2967233bbd%40%3Cdev.fineract.apache.org%3E > Log only WARN & ERR but not INFO anymore > - > > Key: FINERACT-1295 > URL: https://issues.apache.org/jira/browse/FINERACT-1295 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.5.0 > > > https://github.com/apache/fineract/pull/1495 proposes to log only WARN & ERR > but not INFO anymore. > Let's use this issue either to have a Release Note about that change if we do > agree to merge it, or to capture the conclusion of a discussion leading to a > decision for it not to be merged. > I'll post a thread to the dev mailing list about it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1075) Error Prone: Enable JdkObsolete Check
[ https://issues.apache.org/jira/browse/FINERACT-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-1075. - Resolution: Fixed > Error Prone: Enable JdkObsolete Check > -- > > Key: FINERACT-1075 > URL: https://issues.apache.org/jira/browse/FINERACT-1075 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Awasum Yannick >Assignee: Michael Vorburger >Priority: Major > Labels: beginner, technical > Fix For: 1.5.0 > > > Enable Error Prone check for [https://errorprone.info/bugpattern/JdkObsolete] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1297) Upgrade Google ErrorProne code quality scanner tool from 2.4.0 to 2.5.1
[ https://issues.apache.org/jira/browse/FINERACT-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-1297. - Resolution: Fixed > Upgrade Google ErrorProne code quality scanner tool from 2.4.0 to 2.5.1 > --- > > Key: FINERACT-1297 > URL: https://issues.apache.org/jira/browse/FINERACT-1297 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.5.0 > > > https://github.com/apache/fineract/pull/1574 > https://github.com/google/error-prone/releases > The 2.5.1 was a minor one, but check out all the amazing new checks in 2.5.0! -- This message was sent by Atlassian Jira (v8.3.4#803005)
