[jira] [Resolved] (FINERACT-1302) Add days in year at loan level
[ https://issues.apache.org/jira/browse/FINERACT-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-1302. - Resolution: Fixed > Add days in year at loan level > -- > > Key: FINERACT-1302 > URL: https://issues.apache.org/jira/browse/FINERACT-1302 > Project: Apache Fineract > Issue Type: Improvement > Components: Loan >Affects Versions: 1.4.0 >Reporter: David Yahalomi >Assignee: David Yahalomi >Priority: Minor > Fix For: 1.5.0 > > > At the moment, days in year configuration is not supported at the loan level > so this parameter can only be adjusted at the product level. > Adding that parameter will allow greater flexibility to organizations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1302) Add days in year at loan level
[ https://issues.apache.org/jira/browse/FINERACT-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger updated FINERACT-1302: Fix Version/s: 1.5.0 > Add days in year at loan level > -- > > Key: FINERACT-1302 > URL: https://issues.apache.org/jira/browse/FINERACT-1302 > Project: Apache Fineract > Issue Type: Improvement > Components: Loan >Affects Versions: 1.4.0 >Reporter: David Yahalomi >Assignee: David Yahalomi >Priority: Minor > Fix For: 1.5.0 > > > At the moment, days in year configuration is not supported at the loan level > so this parameter can only be adjusted at the product level. > Adding that parameter will allow greater flexibility to organizations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1306) Reporting meta-data entry not found - All reports modules
[
https://issues.apache.org/jira/browse/FINERACT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-1306:
---
Assignee: Rahul Pawar (was: Michael Vorburger)
> Reporting meta-data entry not found - All reports modules
> -
>
> Key: FINERACT-1306
> URL: https://issues.apache.org/jira/browse/FINERACT-1306
> Project: Apache Fineract
> Issue Type: Bug
> Components: Reports
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Assignee: Rahul Pawar
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: image-2021-01-27-09-41-45-780.png
>
>
> [https://ipaddress/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true|https://diprom.biz/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true]
> One gets the response payload below
> {
> "developerMessage": "The requested resource is not available.",
> "httpStatusCode": "404",
> "defaultUserMessage": "The requested resource is not available.",
> "userMessageGlobalisationCode": "error.msg.resource.not.found",
> "errors": [
> {
> "developerMessage": "Reporting meta-data entry not found.",
> "defaultUserMessage": "Reporting meta-data entry not found.",
> "userMessageGlobalisationCode": "error.msg.report.name.not.found",
> "parameterName": "id",
> "value": null,
> "args": [
> { "value": "Report Name: reportCategoryList" }
> ]
> }
> ]
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1306) Reporting meta-data entry not found - All reports modules
[
https://issues.apache.org/jira/browse/FINERACT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280663#comment-17280663
]
Michael Vorburger commented on FINERACT-1306:
-
> Michael Vorburger, the module got broken, due to changes made in this commit:
> https://github.com/apache/fineract/commit/b96061613b2987af14af1723ca362f9868ad5b0b
> , I reverted these changes locally and this module worked fine.
[~rrpawar] are you sure? I've just {{git revert
b96061613b2987af14af1723ca362f9868ad5b0b}} as well, and my IT
https://github.com/apache/fineract/compare/develop...vorburger:FINERACT-1306
still fails, in exactly the same way.
Unless you can "prove" ;) otherwise, I would argue that this is "working as
intended" (WAI) & just fine - I don't see the problem. Do you?
> Reporting meta-data entry not found - All reports modules
> -
>
> Key: FINERACT-1306
> URL: https://issues.apache.org/jira/browse/FINERACT-1306
> Project: Apache Fineract
> Issue Type: Bug
> Components: Reports
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: image-2021-01-27-09-41-45-780.png
>
>
> [https://ipaddress/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true|https://diprom.biz/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true]
> One gets the response payload below
> {
> "developerMessage": "The requested resource is not available.",
> "httpStatusCode": "404",
> "defaultUserMessage": "The requested resource is not available.",
> "userMessageGlobalisationCode": "error.msg.resource.not.found",
> "errors": [
> {
> "developerMessage": "Reporting meta-data entry not found.",
> "defaultUserMessage": "Reporting meta-data entry not found.",
> "userMessageGlobalisationCode": "error.msg.report.name.not.found",
> "parameterName": "id",
> "value": null,
> "args": [
> { "value": "Report Name: reportCategoryList" }
> ]
> }
> ]
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1306) Reporting meta-data entry not found - All reports modules
[
https://issues.apache.org/jira/browse/FINERACT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280661#comment-17280661
]
Michael Vorburger commented on FINERACT-1306:
-
[~francisguchie] and [~rrpawar] I've debugged this, using
https://github.com/apache/fineract/compare/develop...vorburger:FINERACT-1306,
and ... I'm not sure yet that I agree it's a regression :D
So it fails when
org.apache.fineract.infrastructure.dataqueries.api.RunreportsApiResource.runReport()
calls
org.apache.fineract.infrastructure.dataqueries.service.ReadReportingServiceImpl.getReportType()
and that fails by throwing ReportNotFoundException, when it runs "{{SELECT
ifnull(report_type,'') as report_type FROM `stretchy_report` where report_name
= 'reportCategoryList' and self_service_user_report = ?}}" (respectively the
"wrapped" {{select x.* from (SELECT ifnull(report_type,'') as report_type FROM
`stretchy_report` where report_name = 'reportCategoryList' and
self_service_user_report = ?) x}}) which returns no results, because indeed in
the {{stretchy_report}} table there is no report named {{reportCategoryList}}.
So the error "just" means that /runreports could not find a report named
"reportCategoryList". Is that not the expected behavior?
We can try to revert that commit and debug how it behaved before, to understand
the difference and what needs to change.
> Reporting meta-data entry not found - All reports modules
> -
>
> Key: FINERACT-1306
> URL: https://issues.apache.org/jira/browse/FINERACT-1306
> Project: Apache Fineract
> Issue Type: Bug
> Components: Reports
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: image-2021-01-27-09-41-45-780.png
>
>
> [https://ipaddress/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true|https://diprom.biz/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true]
> One gets the response payload below
> {
> "developerMessage": "The requested resource is not available.",
> "httpStatusCode": "404",
> "defaultUserMessage": "The requested resource is not available.",
> "userMessageGlobalisationCode": "error.msg.resource.not.found",
> "errors": [
> {
> "developerMessage": "Reporting meta-data entry not found.",
> "defaultUserMessage": "Reporting meta-data entry not found.",
> "userMessageGlobalisationCode": "error.msg.report.name.not.found",
> "parameterName": "id",
> "value": null,
> "args": [
> { "value": "Report Name: reportCategoryList" }
> ]
> }
> ]
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1311) SavingsAccount getClosedOnDate nullpointer
[ https://issues.apache.org/jira/browse/FINERACT-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-1311. - Resolution: Fixed > SavingsAccount getClosedOnDate nullpointer > -- > > Key: FINERACT-1311 > URL: https://issues.apache.org/jira/browse/FINERACT-1311 > Project: Apache Fineract > Issue Type: Bug > Components: Savings >Affects Versions: 1.4.0 >Reporter: Zoltán Nébli >Assignee: Zoltán Nébli >Priority: Major > Fix For: 1.5.0 > > > SavingsAccount getClosedOnDate method call results in a nullpointer exception > when the closedOnDate attribute is not set - however an account which is not > closed should have a null value for this field. > pull request already pushed: > https://github.com/apache/fineract/pull/1601 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1311) SavingsAccount getClosedOnDate nullpointer
[ https://issues.apache.org/jira/browse/FINERACT-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280653#comment-17280653 ] Michael Vorburger commented on FINERACT-1311: - [~ezolnbl] thank you for your contribution (PR, above) to Fineract! This earns you the right to the Contributor role on the FINERACT project on the ASF JIRA! You can now assign issues to yourself etc. > SavingsAccount getClosedOnDate nullpointer > -- > > Key: FINERACT-1311 > URL: https://issues.apache.org/jira/browse/FINERACT-1311 > Project: Apache Fineract > Issue Type: Bug > Components: Savings >Affects Versions: 1.4.0 >Reporter: Zoltán Nébli >Assignee: Zoltán Nébli >Priority: Major > Fix For: 1.5.0 > > > SavingsAccount getClosedOnDate method call results in a nullpointer exception > when the closedOnDate attribute is not set - however an account which is not > closed should have a null value for this field. > pull request already pushed: > https://github.com/apache/fineract/pull/1601 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1311) SavingsAccount getClosedOnDate nullpointer
[ https://issues.apache.org/jira/browse/FINERACT-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger reassigned FINERACT-1311: --- Assignee: Zoltán Nébli > SavingsAccount getClosedOnDate nullpointer > -- > > Key: FINERACT-1311 > URL: https://issues.apache.org/jira/browse/FINERACT-1311 > Project: Apache Fineract > Issue Type: Bug > Components: Savings >Affects Versions: 1.4.0 >Reporter: Zoltán Nébli >Assignee: Zoltán Nébli >Priority: Major > Fix For: 1.5.0 > > > SavingsAccount getClosedOnDate method call results in a nullpointer exception > when the closedOnDate attribute is not set - however an account which is not > closed should have a null value for this field. > pull request already pushed: > https://github.com/apache/fineract/pull/1601 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1177) Alt. distro? Spring Boot JAR is not great for "dropping in" Plugins
[
https://issues.apache.org/jira/browse/FINERACT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280588#comment-17280588
]
Aleksandar Vidakovic commented on FINERACT-1177:
[~vorburger] I should be able to put a PR with this together... have the bits
and pieces still laying around from our last discussion.
> Alt. distro? Spring Boot JAR is not great for "dropping in" Plugins
> ---
>
> Key: FINERACT-1177
> URL: https://issues.apache.org/jira/browse/FINERACT-1177
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.5.0
>
>
> While I was working on FINERACT-1127, I've realized that the Spring Boot JAR
> distribution is not great for us to open up Fineract to allow adding plugins
> to it...
> I've "solved" this in
> https://github.com/vorburger/fineract-pentaho/blob/develop/run by "unpacking"
> our 'official' JAR distro, and then dropping the plugin into that.
> The reason why we have to do like that is because
> https://github.com/vorburger/fineract-pentaho/compare/broken_no-unpack_Fineract-SpringBoot-JAR
> cannot work - that leads to {{NoClassDefFoundError ... Caused by:
> java.lang.ClassNotFoundException:}} when Java's (not Spring Boot's...)
> classloader was loading PentahoReportingProcessServiceImpl, it could not find
> ReportingProcessService - because that is hidden inside /BOOT-INF/classes/
> where Spring Boot's special classloader will grab it from - but Java's can't
> find it.
> But it made me wonder... why are we distributing Fineract (only) as a Spring
> Boot magic JAR Why is Spring Boot not creating a "simple" good ol' uberJAR?
> Could / should we change that?
> Reading
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html,
> I don't immediately see an option to change that. Do you?
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#packaging-executable-configuring-unpacking
> or
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#packaging-layered-jars
> look like it's adding more magic, instead of less... ;-) Would perhaps
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#reacting-to-other-plugins-application
> be more suitable for us, if we want to "open up" Fineract to let people
> easily add plugins to it? Or should we have
> https://docs.gradle.org/current/userguide/application_plugin.html based ZIP
> as an ADDITIONAL 3rd distribution (besides the JAR and WAR, which we could
> keep), instead of replacing the regular Spring Boot JAR?
> Or is this a total non-issue, we can simply document how future plugins can
> be installed, like my {{run}} script does? Could cause confusion.
> [~ptuomola] [~aleks] do you perhaps have any thoughts about this?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1306) Reporting meta-data entry not found - All reports modules
[
https://issues.apache.org/jira/browse/FINERACT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-1306:
---
Assignee: Michael Vorburger
> Reporting meta-data entry not found - All reports modules
> -
>
> Key: FINERACT-1306
> URL: https://issues.apache.org/jira/browse/FINERACT-1306
> Project: Apache Fineract
> Issue Type: Bug
> Components: Reports
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: image-2021-01-27-09-41-45-780.png
>
>
> [https://ipaddress/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true|https://diprom.biz/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true]
> One gets the response payload below
> {
> "developerMessage": "The requested resource is not available.",
> "httpStatusCode": "404",
> "defaultUserMessage": "The requested resource is not available.",
> "userMessageGlobalisationCode": "error.msg.resource.not.found",
> "errors": [
> {
> "developerMessage": "Reporting meta-data entry not found.",
> "defaultUserMessage": "Reporting meta-data entry not found.",
> "userMessageGlobalisationCode": "error.msg.report.name.not.found",
> "parameterName": "id",
> "value": null,
> "args": [
> { "value": "Report Name: reportCategoryList" }
> ]
> }
> ]
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1012) Spring Security OAuth 2.x to Spring Security 5.2.x
[
https://issues.apache.org/jira/browse/FINERACT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280546#comment-17280546
]
Benura Abeywardena commented on FINERACT-1012:
--
[~vorburger] Thanks for the response sir :)
> Spring Security OAuth 2.x to Spring Security 5.2.x
> --
>
> Key: FINERACT-1012
> URL: https://issues.apache.org/jira/browse/FINERACT-1012
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Priority: Critical
> Labels: beginner
> Fix For: 1.5.0
>
>
> The bump of spring-security-oauth2 from 2.3.6.RELEASE to 2.4.1.RELEASE in
> https://github.com/apache/fineract/pull/863 as part of FINERACT-963
> introduced usage of {{@Deprecated}} code, which we are trying to avoid (and
> which since FINERACT-959 we're intentionally making the build fail).
> I'm going to use a {{@SuppressWarnings("deprecation")}} to be able to do the
> upgrade anyway, because upgrading a security related library to its latest
> version seems like a sensible thing to do, but we really should remove the
> suppression and switch to using Spring's newer APIs.
> https://github.com/spring-projects/spring-security/wiki/OAuth-2.0-Migration-Guide
> affects {{UserDetailsApiResource}} and
> {{TwoFactorAuthenticationFilter.createUpdatedAuthentication()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1012) Spring Security OAuth 2.x to Spring Security 5.2.x
[
https://issues.apache.org/jira/browse/FINERACT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benura Abeywardena reassigned FINERACT-1012:
Assignee: Benura Abeywardena
> Spring Security OAuth 2.x to Spring Security 5.2.x
> --
>
> Key: FINERACT-1012
> URL: https://issues.apache.org/jira/browse/FINERACT-1012
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Benura Abeywardena
>Priority: Critical
> Labels: beginner
> Fix For: 1.5.0
>
>
> The bump of spring-security-oauth2 from 2.3.6.RELEASE to 2.4.1.RELEASE in
> https://github.com/apache/fineract/pull/863 as part of FINERACT-963
> introduced usage of {{@Deprecated}} code, which we are trying to avoid (and
> which since FINERACT-959 we're intentionally making the build fail).
> I'm going to use a {{@SuppressWarnings("deprecation")}} to be able to do the
> upgrade anyway, because upgrading a security related library to its latest
> version seems like a sensible thing to do, but we really should remove the
> suppression and switch to using Spring's newer APIs.
> https://github.com/spring-projects/spring-security/wiki/OAuth-2.0-Migration-Guide
> affects {{UserDetailsApiResource}} and
> {{TwoFactorAuthenticationFilter.createUpdatedAuthentication()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1306) Reporting meta-data entry not found - All reports modules
[
https://issues.apache.org/jira/browse/FINERACT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280545#comment-17280545
]
Michael Vorburger commented on FINERACT-1306:
-
Oh! See https://github.com/apache/fineract/pull/1368 and FINERACT-1173, but
wait, I'm confused, are we saying that:
A. Pentaho reports don't work? That's known, and they didn't work before
FINERACT-1173 either, the goal was just to provide better errors
B. Non-Pentaho CSV (?) reports don't work?
The
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/ReportsTest.java
was supposed to detect regressions.. any solution for this here should include
updating that test.
> Reporting meta-data entry not found - All reports modules
> -
>
> Key: FINERACT-1306
> URL: https://issues.apache.org/jira/browse/FINERACT-1306
> Project: Apache Fineract
> Issue Type: Bug
> Components: Reports
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: image-2021-01-27-09-41-45-780.png
>
>
> [https://ipaddress/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true|https://diprom.biz/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund&genericResultSet=false¶meterType=true]
> One gets the response payload below
> {
> "developerMessage": "The requested resource is not available.",
> "httpStatusCode": "404",
> "defaultUserMessage": "The requested resource is not available.",
> "userMessageGlobalisationCode": "error.msg.resource.not.found",
> "errors": [
> {
> "developerMessage": "Reporting meta-data entry not found.",
> "defaultUserMessage": "Reporting meta-data entry not found.",
> "userMessageGlobalisationCode": "error.msg.report.name.not.found",
> "parameterName": "id",
> "value": null,
> "args": [
> { "value": "Report Name: reportCategoryList" }
> ]
> }
> ]
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1177) Alt. distro? Spring Boot JAR is not great for "dropping in" Plugins
[
https://issues.apache.org/jira/browse/FINERACT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280542#comment-17280542
]
Michael Vorburger commented on FINERACT-1177:
-
[~aleks] this would be cool to have for 1.5.0 IMHO. If you have any free cycles
and interest (which I do currently do not), please feel free to "take" this
issue from me and go ahead with a PR.
> Alt. distro? Spring Boot JAR is not great for "dropping in" Plugins
> ---
>
> Key: FINERACT-1177
> URL: https://issues.apache.org/jira/browse/FINERACT-1177
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.5.0
>
>
> While I was working on FINERACT-1127, I've realized that the Spring Boot JAR
> distribution is not great for us to open up Fineract to allow adding plugins
> to it...
> I've "solved" this in
> https://github.com/vorburger/fineract-pentaho/blob/develop/run by "unpacking"
> our 'official' JAR distro, and then dropping the plugin into that.
> The reason why we have to do like that is because
> https://github.com/vorburger/fineract-pentaho/compare/broken_no-unpack_Fineract-SpringBoot-JAR
> cannot work - that leads to {{NoClassDefFoundError ... Caused by:
> java.lang.ClassNotFoundException:}} when Java's (not Spring Boot's...)
> classloader was loading PentahoReportingProcessServiceImpl, it could not find
> ReportingProcessService - because that is hidden inside /BOOT-INF/classes/
> where Spring Boot's special classloader will grab it from - but Java's can't
> find it.
> But it made me wonder... why are we distributing Fineract (only) as a Spring
> Boot magic JAR Why is Spring Boot not creating a "simple" good ol' uberJAR?
> Could / should we change that?
> Reading
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html,
> I don't immediately see an option to change that. Do you?
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#packaging-executable-configuring-unpacking
> or
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#packaging-layered-jars
> look like it's adding more magic, instead of less... ;-) Would perhaps
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#reacting-to-other-plugins-application
> be more suitable for us, if we want to "open up" Fineract to let people
> easily add plugins to it? Or should we have
> https://docs.gradle.org/current/userguide/application_plugin.html based ZIP
> as an ADDITIONAL 3rd distribution (besides the JAR and WAR, which we could
> keep), instead of replacing the regular Spring Boot JAR?
> Or is this a total non-issue, we can simply document how future plugins can
> be installed, like my {{run}} script does? Could cause confusion.
> [~ptuomola] [~aleks] do you perhaps have any thoughts about this?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1012) Spring Security OAuth 2.x to Spring Security 5.2.x
[
https://issues.apache.org/jira/browse/FINERACT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280537#comment-17280537
]
Michael Vorburger commented on FINERACT-1012:
-
[~BLasan] you are very welcome to take this issue!
> Spring Security OAuth 2.x to Spring Security 5.2.x
> --
>
> Key: FINERACT-1012
> URL: https://issues.apache.org/jira/browse/FINERACT-1012
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Priority: Critical
> Labels: beginner
> Fix For: 1.5.0
>
>
> The bump of spring-security-oauth2 from 2.3.6.RELEASE to 2.4.1.RELEASE in
> https://github.com/apache/fineract/pull/863 as part of FINERACT-963
> introduced usage of {{@Deprecated}} code, which we are trying to avoid (and
> which since FINERACT-959 we're intentionally making the build fail).
> I'm going to use a {{@SuppressWarnings("deprecation")}} to be able to do the
> upgrade anyway, because upgrading a security related library to its latest
> version seems like a sensible thing to do, but we really should remove the
> suppression and switch to using Spring's newer APIs.
> https://github.com/spring-projects/spring-security/wiki/OAuth-2.0-Migration-Guide
> affects {{UserDetailsApiResource}} and
> {{TwoFactorAuthenticationFilter.createUpdatedAuthentication()}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-980) bootRun broken due to FlywayDbUpgradeRequiredException: MySQL upgrade required: MySQL 0.1 is outdated and no longer supported by Flyway. Flyway currently supports MySQL
[
https://issues.apache.org/jira/browse/FINERACT-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-980:
---
Fix Version/s: (was: 1.5.0)
> bootRun broken due to FlywayDbUpgradeRequiredException: MySQL upgrade
> required: MySQL 0.1 is outdated and no longer supported by Flyway. Flyway
> currently supports MySQL 5.1 and newer.
> ---
>
> Key: FINERACT-980
> URL: https://issues.apache.org/jira/browse/FINERACT-980
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Blocker
>
> I'just pulled the latest develop and upon running {{./gradlew bootRun}} hit
> this:
> {noformat}10:46:06.914 [main] INFO
> o.s.b.a.l.ConditionEvaluationReportLoggingListener -
> Error starting ApplicationContext. To display the conditions report re-run
> your application with 'debug' enabled.
> 10:46:06.919 [main] ERROR o.s.boot.SpringApplication - Application run failed
> org.springframework.context.ApplicationContextException: Unable to start web
> server; nested exception is
> org.springframework.boot.web.server.WebServerException: Unable to start
> embedded Tomcat
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:156)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:544)
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141)
> at
> org.springframework.boot.SpringApplication.refresh(SpringApplication.java:747)
> at
> org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:315)
> at
> org.springframework.boot.builder.SpringApplicationBuilder.run(SpringApplicationBuilder.java:140)
> at
> org.apache.fineract.ServerApplication.main(ServerApplication.java:63)
> Caused by: org.springframework.boot.web.server.WebServerException: Unable to
> start embedded Tomcat
> at
> org.springframework.boot.web.embedded.tomcat.TomcatWebServer.initialize(TomcatWebServer.java:125)
> at
> org.springframework.boot.web.embedded.tomcat.TomcatWebServer.(TomcatWebServer.java:87)
> at
> org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getTomcatWebServer(TomcatServletWebServerFactory.java:437)
> at
> org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getWebServer(TomcatServletWebServerFactory.java:191)
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:180)
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:153)
> ... 7 common frames omitted
> Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException:
> Error creating bean with name
> 'org.apache.fineract.infrastructure.core.boot.WebXmlConfiguration':
> Unsatisfied dependency expressed through field
> 'basicAuthenticationProcessingFilter'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'basicAuthenticationProcessingFilter' defined in file
> [/home/vorburger/Mifos/fineract/build/classes/java/main/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'org.springframework.security.authenticationManager':
> Cannot resolve reference to bean 'customAuthenticationProvider' while setting
> constructor argument with key [0]; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'customAuthenticationProvider' defined in URL
> [file:/home/vorburger/Mifos/fineract/build/classes/java/main/META-INF/spring/securityContext.xml]:
> Cannot resolve reference to bean 'userDetailsService' while setting bean
> property 'userDetailsService'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'userDetailsService': Unsatisfied dependency
> expressed through field 'platformUserRepository'; nested exception is
> org.springframework
[jira] [Updated] (FINERACT-764) Run Integration Tests using Spring Boot IT support instead of on Tomcat started separately by gradle-tomcat-plugin
[
https://issues.apache.org/jira/browse/FINERACT-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-764:
---
Fix Version/s: (was: 1.5.0)
> Run Integration Tests using Spring Boot IT support instead of on Tomcat
> started separately by gradle-tomcat-plugin
> --
>
> Key: FINERACT-764
> URL: https://issues.apache.org/jira/browse/FINERACT-764
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>
> https://github.com/apache/fineract/pull/525 for FINERACT-700 struggles to get
> "./gradlew integrationTest" working under an up-to-date Gradle version, due
> to the gradle-tomcat-plugin failing to start Tomcat. The problem can also be
> seen (on that PR, as it stands right now) via {{./gradlew tomcatrunwar}}.
> https://github.com/bmuschko/gradle-tomcat-plugin mentions that its author "I
> don't have much time to contribute anymore. In practice this means far less
> activity, responsiveness on issues and new releases from my end."
> What we IMHO really should do instead is to ditch our use of
> gradle-tomcat-plugin and just use Spring Boot's very nice built-in support
> for Integration Test, see here:
> *
> https://docs.spring.io/spring-boot/docs/2.1.5.RELEASE/reference/htmlsingle/#boot-features-testing-spring-applications
> * https://www.baeldung.com/spring-boot-testing (see 7. Integration Testing
> with @SpringBootTest)
> * https://reflectoring.io/spring-boot-test/
> I wouldn't have time for this, but perhaps someone would like to pick this up?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1201) Remove copy/paste between FileSystemContentRepository and S3ContentRepository
[
https://issues.apache.org/jira/browse/FINERACT-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1201:
Fix Version/s: (was: 1.5.0)
> Remove copy/paste between FileSystemContentRepository and S3ContentRepository
> -
>
> Key: FINERACT-1201
> URL: https://issues.apache.org/jira/browse/FINERACT-1201
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>
> While looking into FINERACT-955, I have found that a lot of the code between
> the {{FileSystemContentRepository}} and the {{S3ContentRepository}} appear to
> very similar.. historically most likely copy/pasted from one to the other.
> There are also some subtle differences e.g. {{FileSystemContentRepository}}
> does not seem to invoke
> {{ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(),
> fileName);}} like {{S3ContentRepository}}. I suspect that probably was not
> intentional?
> Before implementing FINERACT-955, I'll attempt to remove this copy/paste and
> unify those two implementations of {{ContentRepository}}.
> I'll do this in 2 steps: 1. just move some lines, and add some missig lines,
> to make them "look" more similar; 2. actually merge their code by refactoring
> into a common abstract super classes or utilities for composition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-955) ContentRepository for Google Cloud Storage
[
https://issues.apache.org/jira/browse/FINERACT-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-955:
---
Fix Version/s: (was: 1.5.0)
> ContentRepository for Google Cloud Storage
> --
>
> Key: FINERACT-955
> URL: https://issues.apache.org/jira/browse/FINERACT-955
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Labels: beginner
>
> Similarly to S3ContentRepository, a {{ContentRepository}} for Google Cloud
> Storage (GCS) could be useful, for FINERACT-786, and I would use it on
> https://www.fineract.dev.
> It may actually even be possible to use the S3 API, but a GCS native
> implementation is probably smoother and easier to use. One thing in
> particular I'm hoping for is that it could pick up the required
> authentication when running on GCloud automatically from some service account
> environment variables which as far as I know are present there; it would be
> nice, if possible, if there was no need, or as little as possible, need for
> additional configuration parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1224) NullPointerException at Base64$Encoder.encode() in ImagesApiResource
[
https://issues.apache.org/jira/browse/FINERACT-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1224:
Priority: Critical (was: Blocker)
> NullPointerException at Base64$Encoder.encode() in ImagesApiResource
>
>
> Key: FINERACT-1224
> URL: https://issues.apache.org/jira/browse/FINERACT-1224
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Critical
> Labels: beginner, technical
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> https://www.fineract.dev:
> {noformat} java.lang.NullPointerException: null
> at java.util.Base64$Encoder.encode (Base64.java:264)
> at java.util.Base64$Encoder.encodeToString (Base64.java:318)
> at
> org.apache.fineract.infrastructure.documentmanagement.api.ImagesApiResource.retrieveImage
> (ImagesApiResource.java:144){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1224) NullPointerException at Base64$Encoder.encode() in ImagesApiResource
[
https://issues.apache.org/jira/browse/FINERACT-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1224:
Fix Version/s: (was: 1.5.0)
> NullPointerException at Base64$Encoder.encode() in ImagesApiResource
>
>
> Key: FINERACT-1224
> URL: https://issues.apache.org/jira/browse/FINERACT-1224
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Blocker
> Labels: beginner, technical
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> https://www.fineract.dev:
> {noformat} java.lang.NullPointerException: null
> at java.util.Base64$Encoder.encode (Base64.java:264)
> at java.util.Base64$Encoder.encodeToString (Base64.java:318)
> at
> org.apache.fineract.infrastructure.documentmanagement.api.ImagesApiResource.retrieveImage
> (ImagesApiResource.java:144){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1224) NullPointerException at Base64$Encoder.encode() in ImagesApiResource
[
https://issues.apache.org/jira/browse/FINERACT-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1224:
Labels: beginner technical (was: )
> NullPointerException at Base64$Encoder.encode() in ImagesApiResource
>
>
> Key: FINERACT-1224
> URL: https://issues.apache.org/jira/browse/FINERACT-1224
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Blocker
> Labels: beginner, technical
> Fix For: 1.5.0
>
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> https://www.fineract.dev:
> {noformat} java.lang.NullPointerException: null
> at java.util.Base64$Encoder.encode (Base64.java:264)
> at java.util.Base64$Encoder.encodeToString (Base64.java:318)
> at
> org.apache.fineract.infrastructure.documentmanagement.api.ImagesApiResource.retrieveImage
> (ImagesApiResource.java:144){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1224) NullPointerException at Base64$Encoder.encode() in ImagesApiResource
[
https://issues.apache.org/jira/browse/FINERACT-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-1224:
---
Assignee: (was: Michael Vorburger)
> NullPointerException at Base64$Encoder.encode() in ImagesApiResource
>
>
> Key: FINERACT-1224
> URL: https://issues.apache.org/jira/browse/FINERACT-1224
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Blocker
> Labels: beginner, technical
>
> See FINERACT-932 for general background; I'm currently seeing this in logs of
> https://www.fineract.dev:
> {noformat} java.lang.NullPointerException: null
> at java.util.Base64$Encoder.encode (Base64.java:264)
> at java.util.Base64$Encoder.encodeToString (Base64.java:318)
> at
> org.apache.fineract.infrastructure.documentmanagement.api.ImagesApiResource.retrieveImage
> (ImagesApiResource.java:144){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1245) Error Prone Bug Pattern JavaTimeDefaultTimeZone should be Error not just Warning
[
https://issues.apache.org/jira/browse/FINERACT-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280515#comment-17280515
]
Michael Vorburger commented on FINERACT-1245:
-
[~aleks] I still think we should best not customize (=fork) those templates;
longer term that will be a maintenance headache IMHO. Perhaps this could be
fixed "upstream" in the template?
BTW this isn't something I would let block the 1.5.0 release - you can just
remove the Fix Version and Blocked Issue Link (for me, unless YOU want to fix
it for 1.5.0).
> Error Prone Bug Pattern JavaTimeDefaultTimeZone should be Error not just
> Warning
>
>
> Key: FINERACT-1245
> URL: https://issues.apache.org/jira/browse/FINERACT-1245
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Aleksandar Vidakovic
>Priority: Minor
> Fix For: 1.5.0
>
>
> This should be configured to be an Error, not just a Warning, and the
> occurrence fixed:
> {noformat}> Task :fineract-client:compileTestJava
>
> /home/vorburger/dev/Mifos/fineract/fineract-client/src/test/java/org/apache/fineract/integrationtests/newstyle/OfficeTest.java:40:
> warning: [JavaTimeDefaultTimeZone] LocalDate.now() is not allowed because it
> silently uses the system default time-zone. You must pass an explicit
> time-zone (e.g., ZoneId.of("America/Los_Angeles")) to this method.
>
>
> .openingDate(LocalDate.now()).dateFormat(dateFormat()).locale("en_US"))).getOfficeId()).isGreaterThan(0);
>
> ^
>
> (see https://errorprone.info/bugpattern/JavaTimeDefaultTimeZone)
>
> Did you mean
> '.openingDate(LocalDate.now(ZoneId.systemDefault())).dateFormat(dateFormat()).locale("en_US"))).getOfficeId()).isGreaterThan(0);'?
>
>
> 1 warning{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1269) JsonSyntaxException: MalformedJsonException: at SynchronousCommandProcessingService.publishEvent
[
https://issues.apache.org/jira/browse/FINERACT-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1269:
Labels: beginner technical (was: )
> JsonSyntaxException: MalformedJsonException: at
> SynchronousCommandProcessingService.publishEvent
>
>
> Key: FINERACT-1269
> URL: https://issues.apache.org/jira/browse/FINERACT-1269
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Critical
> Labels: beginner, technical
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev:
> {code:java}com.google.gson.JsonSyntaxException:
> com.google.gson.stream.MalformedJsonException: Unterminated object at line 1
> column 55 path $.
> at com.google.gson.Gson.fromJson (Gson.java:947)
> at com.google.gson.Gson.fromJson (Gson.java:897)
> at com.google.gson.Gson.fromJson (Gson.java:846)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishEvent
> (SynchronousCommandProcessingService.java:273)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishErrorEvent
> (SynchronousCommandProcessingService.java:236)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.processAndLogCommand
> (SynchronousCommandProcessingService.java:98)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$FastClassBySpringCGLIB$$ec92d53f.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint
> (CglibAopProxy.java:771)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:163)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction
> (TransactionAspectSupport.java:367)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke
> (TransactionInterceptor.java:118)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:691)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$EnhancerBySpringCGLIB$$3f40ed52.processAndLogCommand
> ()
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl.logCommandSource
> (PortfolioCommandSourceWritePlatformServiceImpl.java:99)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$FastClassBySpringCGLIB$$31c15082.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:687)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$EnhancerBySpringCGLIB$$97e600fb.logCommandSource
> ()
> at
> org.apache.fineract.organisation.office.api.OfficesApiResource.createOffice
> (OfficesApiResource.java:162){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1269) JsonSyntaxException: MalformedJsonException: at SynchronousCommandProcessingService.publishEvent
[
https://issues.apache.org/jira/browse/FINERACT-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-1269:
---
Assignee: (was: Michael Vorburger)
> JsonSyntaxException: MalformedJsonException: at
> SynchronousCommandProcessingService.publishEvent
>
>
> Key: FINERACT-1269
> URL: https://issues.apache.org/jira/browse/FINERACT-1269
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Michael Vorburger
>Priority: Critical
> Labels: beginner, technical
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev:
> {code:java}com.google.gson.JsonSyntaxException:
> com.google.gson.stream.MalformedJsonException: Unterminated object at line 1
> column 55 path $.
> at com.google.gson.Gson.fromJson (Gson.java:947)
> at com.google.gson.Gson.fromJson (Gson.java:897)
> at com.google.gson.Gson.fromJson (Gson.java:846)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishEvent
> (SynchronousCommandProcessingService.java:273)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishErrorEvent
> (SynchronousCommandProcessingService.java:236)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.processAndLogCommand
> (SynchronousCommandProcessingService.java:98)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$FastClassBySpringCGLIB$$ec92d53f.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint
> (CglibAopProxy.java:771)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:163)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction
> (TransactionAspectSupport.java:367)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke
> (TransactionInterceptor.java:118)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:691)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$EnhancerBySpringCGLIB$$3f40ed52.processAndLogCommand
> ()
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl.logCommandSource
> (PortfolioCommandSourceWritePlatformServiceImpl.java:99)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$FastClassBySpringCGLIB$$31c15082.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:687)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$EnhancerBySpringCGLIB$$97e600fb.logCommandSource
> ()
> at
> org.apache.fineract.organisation.office.api.OfficesApiResource.createOffice
> (OfficesApiResource.java:162){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1269) JsonSyntaxException: MalformedJsonException: at SynchronousCommandProcessingService.publishEvent
[
https://issues.apache.org/jira/browse/FINERACT-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1269:
Priority: Critical (was: Blocker)
> JsonSyntaxException: MalformedJsonException: at
> SynchronousCommandProcessingService.publishEvent
>
>
> Key: FINERACT-1269
> URL: https://issues.apache.org/jira/browse/FINERACT-1269
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Critical
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev:
> {code:java}com.google.gson.JsonSyntaxException:
> com.google.gson.stream.MalformedJsonException: Unterminated object at line 1
> column 55 path $.
> at com.google.gson.Gson.fromJson (Gson.java:947)
> at com.google.gson.Gson.fromJson (Gson.java:897)
> at com.google.gson.Gson.fromJson (Gson.java:846)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishEvent
> (SynchronousCommandProcessingService.java:273)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishErrorEvent
> (SynchronousCommandProcessingService.java:236)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.processAndLogCommand
> (SynchronousCommandProcessingService.java:98)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$FastClassBySpringCGLIB$$ec92d53f.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint
> (CglibAopProxy.java:771)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:163)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction
> (TransactionAspectSupport.java:367)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke
> (TransactionInterceptor.java:118)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:691)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$EnhancerBySpringCGLIB$$3f40ed52.processAndLogCommand
> ()
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl.logCommandSource
> (PortfolioCommandSourceWritePlatformServiceImpl.java:99)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$FastClassBySpringCGLIB$$31c15082.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:687)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$EnhancerBySpringCGLIB$$97e600fb.logCommandSource
> ()
> at
> org.apache.fineract.organisation.office.api.OfficesApiResource.createOffice
> (OfficesApiResource.java:162){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1269) JsonSyntaxException: MalformedJsonException: at SynchronousCommandProcessingService.publishEvent
[
https://issues.apache.org/jira/browse/FINERACT-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1269:
Fix Version/s: (was: 1.5.0)
> JsonSyntaxException: MalformedJsonException: at
> SynchronousCommandProcessingService.publishEvent
>
>
> Key: FINERACT-1269
> URL: https://issues.apache.org/jira/browse/FINERACT-1269
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Blocker
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev:
> {code:java}com.google.gson.JsonSyntaxException:
> com.google.gson.stream.MalformedJsonException: Unterminated object at line 1
> column 55 path $.
> at com.google.gson.Gson.fromJson (Gson.java:947)
> at com.google.gson.Gson.fromJson (Gson.java:897)
> at com.google.gson.Gson.fromJson (Gson.java:846)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishEvent
> (SynchronousCommandProcessingService.java:273)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.publishErrorEvent
> (SynchronousCommandProcessingService.java:236)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService.processAndLogCommand
> (SynchronousCommandProcessingService.java:98)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$FastClassBySpringCGLIB$$ec92d53f.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint
> (CglibAopProxy.java:771)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:163)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction
> (TransactionAspectSupport.java:367)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke
> (TransactionInterceptor.java:118)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed
> (ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed
> (CglibAopProxy.java:749)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:691)
> at
> org.apache.fineract.commands.service.SynchronousCommandProcessingService$$EnhancerBySpringCGLIB$$3f40ed52.processAndLogCommand
> ()
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl.logCommandSource
> (PortfolioCommandSourceWritePlatformServiceImpl.java:99)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$FastClassBySpringCGLIB$$31c15082.invoke
> ()
> at org.springframework.cglib.proxy.MethodProxy.invoke
> (MethodProxy.java:218)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept
> (CglibAopProxy.java:687)
> at
> org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$EnhancerBySpringCGLIB$$97e600fb.logCommandSource
> ()
> at
> org.apache.fineract.organisation.office.api.OfficesApiResource.createOffice
> (OfficesApiResource.java:162){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1307) Loan Ideal disbursement to calculation cause to wrong interest rate
[
https://issues.apache.org/jira/browse/FINERACT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280503#comment-17280503
]
Michael Vorburger commented on FINERACT-1307:
-
[~eitan-fr] thank you for contributing to Apache Fineract! I've just granted
you the Contributor role on JIRA, you can now assign issues to yourself etc.
([~awasum] you [can do
this|https://issues.apache.org/jira/plugins/servlet/project-config/FINERACT/roles]
as well!)
> Loan Ideal disbursement to calculation cause to wrong interest rate
>
>
> Key: FINERACT-1307
> URL: https://issues.apache.org/jira/browse/FINERACT-1307
> Project: Apache Fineract
> Issue Type: Bug
> Components: Loan
>Reporter: eitan frailich
>Assignee: eitan frailich
>Priority: Minor
> Fix For: 1.5.0
>
> Attachments: image-2021-02-02-16-43-07-381.png
>
>
> *ISSUE*
> My issue/bug happens when I am setting "First repayment on" field I get a
> repayment schedule with a wrong interest rate for the first installment.
> Example: When I set "First repayment on" to 01/02/21 and expected
> disbursement is 27/1/21(Frist image) then I get the wrong interest.The first
> installment interest is 21,232.88$ (second Image) - calculated for the entire
> month (31 days) instead of 5 days (the time from the disbursement to the
> first repayment), the right interest should be 3424.75$.
> *After debugging:*
> In AbstractLoanScheduleGenerator there is a function
> {{calculateInterestStartDateForPeriod}} - it uses the {{idealDisbursment}}
> for setting the interest start date for the first installment, The
> {{idealDisbursment}} is calculated by
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} which does
> [{{firstRepaymentDate}} - 1 repayment Period Frequency] aka, for 01/02/21
> with months as repyment frequency it will return 01/01/21.
> So when we dont set the "First repayment on" the {{idealDisbursment}} will be
> the expected disbursement date because the first repayment is always
> {{expectedDisbursment}}+1. But if we set the "First repayment on" we get the
> wrong value for the {{idealDisbursment}} - in my example we got 01/0/21 and
> this is why the first installment interest was calculated for an entire month
> instead of 5 days.
> *Is it a bug or not?*
> I am not sure why {{idealDisbursementDateBasedOnFirstRepaymentDate}} exists,
> the simple solution is to do idealDisbursment=expectedDisbursmentDate.I
> tried it locally and looks like it works, I will be happy to make a PR, but
> want to make sure indeed that the
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} is redundant.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1307) Loan Ideal disbursement to calculation cause to wrong interest rate
[
https://issues.apache.org/jira/browse/FINERACT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger reassigned FINERACT-1307:
---
Assignee: eitan frailich
> Loan Ideal disbursement to calculation cause to wrong interest rate
>
>
> Key: FINERACT-1307
> URL: https://issues.apache.org/jira/browse/FINERACT-1307
> Project: Apache Fineract
> Issue Type: Bug
> Components: Loan
>Reporter: eitan frailich
>Assignee: eitan frailich
>Priority: Minor
> Attachments: image-2021-02-02-16-43-07-381.png
>
>
> *ISSUE*
> My issue/bug happens when I am setting "First repayment on" field I get a
> repayment schedule with a wrong interest rate for the first installment.
> Example: When I set "First repayment on" to 01/02/21 and expected
> disbursement is 27/1/21(Frist image) then I get the wrong interest.The first
> installment interest is 21,232.88$ (second Image) - calculated for the entire
> month (31 days) instead of 5 days (the time from the disbursement to the
> first repayment), the right interest should be 3424.75$.
> *After debugging:*
> In AbstractLoanScheduleGenerator there is a function
> {{calculateInterestStartDateForPeriod}} - it uses the {{idealDisbursment}}
> for setting the interest start date for the first installment, The
> {{idealDisbursment}} is calculated by
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} which does
> [{{firstRepaymentDate}} - 1 repayment Period Frequency] aka, for 01/02/21
> with months as repyment frequency it will return 01/01/21.
> So when we dont set the "First repayment on" the {{idealDisbursment}} will be
> the expected disbursement date because the first repayment is always
> {{expectedDisbursment}}+1. But if we set the "First repayment on" we get the
> wrong value for the {{idealDisbursment}} - in my example we got 01/0/21 and
> this is why the first installment interest was calculated for an entire month
> instead of 5 days.
> *Is it a bug or not?*
> I am not sure why {{idealDisbursementDateBasedOnFirstRepaymentDate}} exists,
> the simple solution is to do idealDisbursment=expectedDisbursmentDate.I
> tried it locally and looks like it works, I will be happy to make a PR, but
> want to make sure indeed that the
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} is redundant.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1307) Loan Ideal disbursement to calculation cause to wrong interest rate
[
https://issues.apache.org/jira/browse/FINERACT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1307:
Fix Version/s: 1.5.0
> Loan Ideal disbursement to calculation cause to wrong interest rate
>
>
> Key: FINERACT-1307
> URL: https://issues.apache.org/jira/browse/FINERACT-1307
> Project: Apache Fineract
> Issue Type: Bug
> Components: Loan
>Reporter: eitan frailich
>Assignee: eitan frailich
>Priority: Minor
> Fix For: 1.5.0
>
> Attachments: image-2021-02-02-16-43-07-381.png
>
>
> *ISSUE*
> My issue/bug happens when I am setting "First repayment on" field I get a
> repayment schedule with a wrong interest rate for the first installment.
> Example: When I set "First repayment on" to 01/02/21 and expected
> disbursement is 27/1/21(Frist image) then I get the wrong interest.The first
> installment interest is 21,232.88$ (second Image) - calculated for the entire
> month (31 days) instead of 5 days (the time from the disbursement to the
> first repayment), the right interest should be 3424.75$.
> *After debugging:*
> In AbstractLoanScheduleGenerator there is a function
> {{calculateInterestStartDateForPeriod}} - it uses the {{idealDisbursment}}
> for setting the interest start date for the first installment, The
> {{idealDisbursment}} is calculated by
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} which does
> [{{firstRepaymentDate}} - 1 repayment Period Frequency] aka, for 01/02/21
> with months as repyment frequency it will return 01/01/21.
> So when we dont set the "First repayment on" the {{idealDisbursment}} will be
> the expected disbursement date because the first repayment is always
> {{expectedDisbursment}}+1. But if we set the "First repayment on" we get the
> wrong value for the {{idealDisbursment}} - in my example we got 01/0/21 and
> this is why the first installment interest was calculated for an entire month
> instead of 5 days.
> *Is it a bug or not?*
> I am not sure why {{idealDisbursementDateBasedOnFirstRepaymentDate}} exists,
> the simple solution is to do idealDisbursment=expectedDisbursmentDate.I
> tried it locally and looks like it works, I will be happy to make a PR, but
> want to make sure indeed that the
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} is redundant.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1295) Log only WARN & ERR but not INFO anymore
[ https://issues.apache.org/jira/browse/FINERACT-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Vorburger resolved FINERACT-1295. - Resolution: Fixed > Log only WARN & ERR but not INFO anymore > - > > Key: FINERACT-1295 > URL: https://issues.apache.org/jira/browse/FINERACT-1295 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.5.0 > > > https://github.com/apache/fineract/pull/1495 proposes to log only WARN & ERR > but not INFO anymore. > Let's use this issue either to have a Release Note about that change if we do > agree to merge it, or to capture the conclusion of a discussion leading to a > decision for it not to be merged. > I'll post a thread to the dev mailing list about it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1295) Log only WARN & ERR but not INFO anymore
[ https://issues.apache.org/jira/browse/FINERACT-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280499#comment-17280499 ] Michael Vorburger commented on FINERACT-1295: - PR merged, as nobody objected to it on the mailing list (above). > Log only WARN & ERR but not INFO anymore > - > > Key: FINERACT-1295 > URL: https://issues.apache.org/jira/browse/FINERACT-1295 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.5.0 > > > https://github.com/apache/fineract/pull/1495 proposes to log only WARN & ERR > but not INFO anymore. > Let's use this issue either to have a Release Note about that change if we do > agree to merge it, or to capture the conclusion of a discussion leading to a > decision for it not to be merged. > I'll post a thread to the dev mailing list about it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1222) SDK Swagger Client Java API DefaultApi should disappear and operations go to other Api interfaces
[
https://issues.apache.org/jira/browse/FINERACT-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280437#comment-17280437
]
Benura Abeywardena commented on FINERACT-1222:
--
[~vorburger] I would like to take up this issue
> SDK Swagger Client Java API DefaultApi should disappear and operations go to
> other Api interfaces
> -
>
> Key: FINERACT-1222
> URL: https://issues.apache.org/jira/browse/FINERACT-1222
> Project: Apache Fineract
> Issue Type: Bug
> Components: SDK
>Reporter: Michael Vorburger
>Priority: Critical
> Labels: beginner
>
> I've just noticed {{org.apache.fineract.client.services.DefaultApi}}
> containing a lot (like a 100?) of methods from {{accountsTemplate()}} to
> {{validate()}} which all look like they should belong into one of the other
> existing {{*Api}} interfaces.
> Not sure why this happens - some Swagger annotation missing?
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan] any idea?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FINERACT-1222) SDK Swagger Client Java API DefaultApi should disappear and operations go to other Api interfaces
[
https://issues.apache.org/jira/browse/FINERACT-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benura Abeywardena reassigned FINERACT-1222:
Assignee: Benura Abeywardena
> SDK Swagger Client Java API DefaultApi should disappear and operations go to
> other Api interfaces
> -
>
> Key: FINERACT-1222
> URL: https://issues.apache.org/jira/browse/FINERACT-1222
> Project: Apache Fineract
> Issue Type: Bug
> Components: SDK
>Reporter: Michael Vorburger
>Assignee: Benura Abeywardena
>Priority: Critical
> Labels: beginner
>
> I've just noticed {{org.apache.fineract.client.services.DefaultApi}}
> containing a lot (like a 100?) of methods from {{accountsTemplate()}} to
> {{validate()}} which all look like they should belong into one of the other
> existing {{*Api}} interfaces.
> Not sure why this happens - some Swagger annotation missing?
> [~aleks] [~ChinmayKulkarni] [~ptuomola] [~manthan] any idea?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
