[jira] [Assigned] (FINERACT-1177) Alt. distro? Spring Boot JAR is not great for "dropping in" Plugins

2021-02-08 Thread Aleksandar Vidakovic (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksandar Vidakovic reassigned FINERACT-1177:
--

Assignee: Aleksandar Vidakovic  (was: Michael Vorburger)

> Alt. distro? Spring Boot JAR is not great for "dropping in" Plugins
> ---
>
> Key: FINERACT-1177
> URL: https://issues.apache.org/jira/browse/FINERACT-1177
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Aleksandar Vidakovic
>Priority: Major
> Fix For: 1.5.0
>
>
> While I was working on FINERACT-1127, I've realized that the Spring Boot JAR 
> distribution is not great for us to open up Fineract to allow adding plugins 
> to it... 
> I've "solved" this in 
> https://github.com/vorburger/fineract-pentaho/blob/develop/run by "unpacking" 
> our 'official' JAR distro, and then dropping the plugin into that.
> The reason why we have to do like that is because 
> https://github.com/vorburger/fineract-pentaho/compare/broken_no-unpack_Fineract-SpringBoot-JAR
>  cannot work - that leads to {{NoClassDefFoundError ... Caused by: 
> java.lang.ClassNotFoundException:}} when Java's (not Spring Boot's...) 
> classloader was loading PentahoReportingProcessServiceImpl, it could not find 
> ReportingProcessService - because that is hidden inside /BOOT-INF/classes/ 
> where Spring Boot's special classloader will grab it from - but Java's can't 
> find it.
> But it made me wonder... why are we distributing Fineract (only) as a Spring 
> Boot magic JAR  Why is Spring Boot not creating a "simple" good ol' uberJAR?  
> Could / should we change that?
> Reading 
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html, 
> I don't immediately see an option to change that.  Do you?  
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#packaging-executable-configuring-unpacking
>  or 
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#packaging-layered-jars
>  look like it's adding more magic, instead of less... ;-) Would perhaps 
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#reacting-to-other-plugins-application
>  be more suitable for us, if we want to "open up" Fineract to let people 
> easily add plugins to it? Or should we have 
> https://docs.gradle.org/current/userguide/application_plugin.html based ZIP 
> as an ADDITIONAL 3rd distribution (besides the JAR and WAR, which we could 
> keep), instead of replacing the regular Spring Boot JAR?
> Or is this a total non-issue, we can simply document how future plugins can 
> be installed, like my {{run}} script does? Could cause confusion.
> [~ptuomola] [~aleks] do you perhaps have any thoughts about this?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FINERACT-849) Migrate Fineract ORM from OpenJPA to EclipseLink

2021-02-08 Thread Yemdjih Kaze Nasser (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yemdjih Kaze Nasser updated FINERACT-849:
-
Fix Version/s: (was: 1.5.0)

> Migrate Fineract ORM from OpenJPA to EclipseLink
> 
>
> Key: FINERACT-849
> URL: https://issues.apache.org/jira/browse/FINERACT-849
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Ed Cable
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
>  Labels: gsoc2020, hard, mentor, technical
>
> In line with the rationale for choosing EclipseLink as the ORM replacement 
> for Hibernate in FineractCN, we have broad consensus across the community to 
> swap out OpenJPA with EclipseLink.
> OpenJPA seems to have reached its end of life with community activity 
> withering and the trade-offs between Hibernate and EclipseLink are much 
> lower. We also have community members who are migrating Fineract 1.x to 
> PostGreSQL and would benefit from the increased performance with EclipseLink. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (FINERACT-1291) Wrong disbursement date for loans and transaction date for savings account

2021-02-08 Thread Anu Omotayo (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Omotayo resolved FINERACT-1291.
---
Fix Version/s: 1.4.0
   Resolution: Feedback Received

Issue was sorted out based on feedback received from the group

> Wrong disbursement date for loans and transaction date for savings account
> --
>
> Key: FINERACT-1291
> URL: https://issues.apache.org/jira/browse/FINERACT-1291
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan, Savings
>Affects Versions: 1.4.0
>Reporter: Anu Omotayo
>Assignee: Benura Abeywardena
>Priority: Blocker
> Fix For: 1.4.0, 1.2.0
>
> Attachments: Mifos loan Disbursal Date Issue.png
>
>
> We noticed that the submitted, approval and disbursal date were different 
> from the chosen date. We selected the current date which is 7th January 2021 
> for submission, approval and disbursement, however, after submission, 
> approval and disbursement, the date for the following changes in the account 
> detail of the client to 6th January. This was tested on the link shared as 
> well, we got the same result. 
> [https://openmf.github.io/community-app/?baseApiUrl=https%3A%2F%2Fdemo.fineract.dev=default]
>  
> We encountered the same issue for deposit and withdrawal transactions on 
> savings accounts. It seems the system is doing Transaction date - 1 (T - 1) 
> for all transactions. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FINERACT-1309) Back Dated Transactions

2021-02-08 Thread Francis Guchie (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francis Guchie closed FINERACT-1309.

Resolution: Resolved

https://issues.apache.org/jira/browse/FINERACT-1291

> Back Dated Transactions
> ---
>
> Key: FINERACT-1309
> URL: https://issues.apache.org/jira/browse/FINERACT-1309
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan, Savings
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Priority: Major
>
> When a user makes a transaction on a particular date, the created date is the 
> correct timestamp yet the created or transaction or submitted on dates are 
> set a day before 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1309) Back Dated Transactions

2021-02-08 Thread Francis Guchie (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281184#comment-17281184
 ] 

Francis Guchie commented on FINERACT-1309:
--

Thanks to [~anmotayo] i followed steps take in FINERACT-1291

> Back Dated Transactions
> ---
>
> Key: FINERACT-1309
> URL: https://issues.apache.org/jira/browse/FINERACT-1309
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan, Savings
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Priority: Major
>
> When a user makes a transaction on a particular date, the created date is the 
> correct timestamp yet the created or transaction or submitted on dates are 
> set a day before 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1309) Back Dated Transactions

2021-02-08 Thread Francis Guchie (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281182#comment-17281182
 ] 

Francis Guchie commented on FINERACT-1309:
--

Issue
Our servers timezone is Time zone: Etc/UTC (UTC, +) while we set our 
timezone in the database to fineract_tenants.tenants.timezone_id = 
'Asia/Kolkata'. All our transaction dates were T - 1. 

 

Solution
We changed fineract_tenants.tenants.timezone_id = 'Africa/Freetown' which is 
the same with our server time zone Etc/UTC (UTC, +) and the issue stopped.

 

> Back Dated Transactions
> ---
>
> Key: FINERACT-1309
> URL: https://issues.apache.org/jira/browse/FINERACT-1309
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan, Savings
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Priority: Major
>
> When a user makes a transaction on a particular date, the created date is the 
> correct timestamp yet the created or transaction or submitted on dates are 
> set a day before 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1307) Loan Ideal disbursement to calculation cause to wrong interest rate

2021-02-08 Thread eitan frailich (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281161#comment-17281161
 ] 

eitan frailich commented on FINERACT-1307:
--

[~bgowda] Hi
Check out the [PR|https://github.com/apache/fineract/pull/1562] I have attached 
images to it.

I understand your workaround but still, this seems like a bug to me. 
Because if you dont set the configuration as you said you will have a 
wrong-buggy interest calculation.

> Loan Ideal disbursement to calculation cause to wrong interest rate 
> 
>
> Key: FINERACT-1307
> URL: https://issues.apache.org/jira/browse/FINERACT-1307
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: eitan frailich
>Assignee: eitan frailich
>Priority: Minor
> Fix For: 1.5.0
>
> Attachments: image-2021-02-02-16-43-07-381.png
>
>
> *ISSUE*
> My issue/bug happens when I am setting "First repayment on" field I get a 
> repayment schedule with a wrong interest rate for the first installment.
> Example: When I set "First repayment on" to 01/02/21 and expected 
> disbursement is 27/1/21(Frist image) then I get the wrong interest.The first 
> installment interest is 21,232.88$ (second Image) - calculated for the entire 
> month (31 days) instead of 5 days (the time from the disbursement to the 
> first repayment), the right interest should be 3424.75$.
> *After debugging:*
> In AbstractLoanScheduleGenerator there is a function 
> {{calculateInterestStartDateForPeriod}} - it uses the {{idealDisbursment}} 
> for setting the interest start date for the first installment, The 
> {{idealDisbursment}} is calculated by 
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} which does 
> [{{firstRepaymentDate}} - 1 repayment Period Frequency] aka, for 01/02/21 
> with months as repyment frequency it will return 01/01/21.
> So when we dont set the "First repayment on" the {{idealDisbursment}} will be 
> the expected disbursement date because the first repayment is always 
> {{expectedDisbursment}}+1. But if we set the  "First repayment on" we get the 
> wrong value for the {{idealDisbursment}} - in my example we got 01/0/21 and 
> this is why the first installment interest was calculated for an entire month 
> instead of  5 days.
> *Is it a bug or not?*
> I am not sure why {{idealDisbursementDateBasedOnFirstRepaymentDate}} exists, 
> the simple solution is to do  idealDisbursment=expectedDisbursmentDate.I 
> tried it locally and looks like it works, I will be happy to make a PR, but 
> want to make sure indeed that the 
> {{idealDisbursementDateBasedOnFirstRepaymentDate}} is redundant.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1313) Holiday functianality not working

2021-02-08 Thread Aleksandar Vidakovic (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksandar Vidakovic reassigned FINERACT-1313:
--

Assignee: Frank Nkuyahaga

> Holiday functianality not working
> -
>
> Key: FINERACT-1313
> URL: https://issues.apache.org/jira/browse/FINERACT-1313
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Organization
>Affects Versions: 1.4.0
>Reporter: bharath gowda
>Assignee: Frank Nkuyahaga
>Priority: Critical
> Fix For: 1.5.0
>
>
> holiday set is not rescheduling the installments of both existing loans(even 
> after scheduler job runs successfully ) and new loans created
>  
> To reproduce
>  
> 1. Create and activate a holiday
> 2. Create/approve/disburse a loan in such a way the installment falls on the 
> created holiday date.
>  * expected behavior- the system should have rescheduled the installment as 
> per the holiday configured, but it doesn't.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1306) Reporting meta-data entry not found - All reports modules

2021-02-08 Thread Francis Guchie (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280984#comment-17280984
 ] 

Francis Guchie commented on FINERACT-1306:
--

[~vorburger]

Every time i make changes to the fineract i delete the folder 
(fineract-Provider) since i use tomcat to launch and test and in production
*sudo rm -r /usr/share/tomcat9/webapps/fineract-provider* 
this goes for both windows PC and Linux (Ubuntu)

*i found out the hardway that if i dont , some changes made in fineract will 
not be reflected.*

Me too i removed your commit {{b96061613b2987af14af1723ca362f9868ad5b0b}}  and 
all is working fine  

> Reporting meta-data entry not found - All reports modules
> -
>
> Key: FINERACT-1306
> URL: https://issues.apache.org/jira/browse/FINERACT-1306
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Reports
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Assignee: Rahul Pawar
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: image-2021-01-27-09-41-45-780.png
>
>
> [https://ipaddress/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund=false=true|https://diprom.biz/fineract-provider/api/v1/runreports/reportCategoryList?R_reportCategory=Fund=false=true]
> One gets the response payload below 
> {
>  "developerMessage": "The requested resource is not available.",
>  "httpStatusCode": "404",
>  "defaultUserMessage": "The requested resource is not available.",
>  "userMessageGlobalisationCode": "error.msg.resource.not.found",
>  "errors": [
>  {
>  "developerMessage": "Reporting meta-data entry not found.",
>  "defaultUserMessage": "Reporting meta-data entry not found.",
>  "userMessageGlobalisationCode": "error.msg.report.name.not.found",
>  "parameterName": "id",
>  "value": null,
>  "args": [
> { "value": "Report Name: reportCategoryList" }
> ]
>  }
>  ]
>  }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FINERACT-1309) Back Dated Transactions

2021-02-08 Thread bharath gowda (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280954#comment-17280954
 ] 

bharath gowda edited comment on FINERACT-1309 at 2/8/21, 11:25 AM:
---

Hi Team,

I have tested the same and was not able to reproduce it either on any type of 
financial transaction.

[~francisguchie]

Could you please check fineract_tenants.tenants.timezone_id is set properly as 
per your time zone,

I feel the issue could be because this parameter could not be in sync,

FINERACT-1291 was affected because of the same issue.

 


was (Author: bgowda):
Hi Team,

I have tested the same and was not able to reproduce it either on any type of 
financial transaction.

Could you please check fineract_tenants.tenants.timezone_id is set properly as 
per your time zone,

I feel the issue could be because this parameter could not be in sync,

FINERACT-1291 was affected because of the same issue.

 

> Back Dated Transactions
> ---
>
> Key: FINERACT-1309
> URL: https://issues.apache.org/jira/browse/FINERACT-1309
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan, Savings
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Priority: Major
>
> When a user makes a transaction on a particular date, the created date is the 
> correct timestamp yet the created or transaction or submitted on dates are 
> set a day before 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1309) Back Dated Transactions

2021-02-08 Thread bharath gowda (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280954#comment-17280954
 ] 

bharath gowda commented on FINERACT-1309:
-

Hi Team,

I have tested the same and was not able to reproduce it either on any type of 
financial transaction.

Could you please check fineract_tenants.tenants.timezone_id is set properly as 
per your time zone,

I feel the issue could be because this parameter could not be in sync,

FINERACT-1291 was affected because of the same issue.

 

> Back Dated Transactions
> ---
>
> Key: FINERACT-1309
> URL: https://issues.apache.org/jira/browse/FINERACT-1309
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan, Savings
>Affects Versions: 1.5.0
>Reporter: Francis Guchie
>Priority: Major
>
> When a user makes a transaction on a particular date, the created date is the 
> correct timestamp yet the created or transaction or submitted on dates are 
> set a day before 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1291) Wrong disbursement date for loans and transaction date for savings account

2021-02-08 Thread bharath gowda (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280949#comment-17280949
 ] 

bharath gowda commented on FINERACT-1291:
-

Hi, [~anmotayo] Thank you for the details, I would have classified this as a 
Bug only if you had set the fineract_tenants.tenants.timezone_id = 
'Europe/London' and still faced the issue. 

Setting timezone right is one of the mandatory steps in Mifos configuration. 
and works perfectly fine for organizations which operate in one timezone.

However, this issue raised is valid in the case of a global-level organization 
where they work across timezones, which is a separate scenario where all the 
aspects should be analyzed and enhanced to support the same, this could be a 
part of enhancement related to that.

> Wrong disbursement date for loans and transaction date for savings account
> --
>
> Key: FINERACT-1291
> URL: https://issues.apache.org/jira/browse/FINERACT-1291
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan, Savings
>Affects Versions: 1.4.0
>Reporter: Anu Omotayo
>Assignee: Benura Abeywardena
>Priority: Blocker
> Fix For: 1.2.0
>
> Attachments: Mifos loan Disbursal Date Issue.png
>
>
> We noticed that the submitted, approval and disbursal date were different 
> from the chosen date. We selected the current date which is 7th January 2021 
> for submission, approval and disbursement, however, after submission, 
> approval and disbursement, the date for the following changes in the account 
> detail of the client to 6th January. This was tested on the link shared as 
> well, we got the same result. 
> [https://openmf.github.io/community-app/?baseApiUrl=https%3A%2F%2Fdemo.fineract.dev=default]
>  
> We encountered the same issue for deposit and withdrawal transactions on 
> savings accounts. It seems the system is doing Transaction date - 1 (T - 1) 
> for all transactions. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)