[jira] [Updated] (FINERACT-1366) invalid fields in PostClientsClientIdRequest in clientsApiResourceSwagger

2021-08-06 Thread Danish Jamal (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Danish Jamal updated FINERACT-1366:
---
Description: 
Expected body payload while activating the client:
{code:java}
{  
"activationDate": "02 August 2021", 
"dateFormat": "dd  ", 
"locale": "en"
}
{code}
Payload model (PostClientsClientIdRequest):
{code:java}
@Schema(description = "PostClientsClientIdRequest")
public static final class PostClientsClientIdRequest {

private PostClientsClientIdRequest() {}

@Schema(example = "We cannot accept transfers of clients having loans with 
less than 1 repayment left")
public String note;
}
{code}
the  PostClientsClientIdRequest must define the required field in order to 
generate the valid client.
Also officeId field is missing in the returned response while activating a 
client.
{code:java}
// defined in swagger resource class
@Schema(description = "PostClientsClientIdResponse")
public static final class PostClientsClientIdResponse {

private PostClientsClientIdResponse() {}

@Schema(example = "2")
public Integer clientId;
@Schema(example = "2")
public Integer resourceId;
}


// actual json returned
{
  "officeId": 2,
  "clientId": 6,
  "resourceId": 6
}{code}

  was:
Expected body payload while activating the client:
{code:java}
{  
"activationDate": "02 August 2021", 
"dateFormat": "dd  ", 
"locale": "en"
}
{code}
Payload model (PostClientsClientIdRequest):
{code:java}
@Schema(description = "PostClientsClientIdRequest")
public static final class PostClientsClientIdRequest {

private PostClientsClientIdRequest() {}

@Schema(example = "We cannot accept transfers of clients having loans with 
less than 1 repayment left")
public String note;
}
{code}
the  PostClientsClientIdRequest must define the required field in order to 
generate the valid client.


> invalid fields in PostClientsClientIdRequest in clientsApiResourceSwagger
> -
>
> Key: FINERACT-1366
> URL: https://issues.apache.org/jira/browse/FINERACT-1366
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Danish Jamal
>Assignee: Danish Jamal
>Priority: Major
>
> Expected body payload while activating the client:
> {code:java}
> {  
> "activationDate": "02 August 2021", 
> "dateFormat": "dd  ", 
> "locale": "en"
> }
> {code}
> Payload model (PostClientsClientIdRequest):
> {code:java}
> @Schema(description = "PostClientsClientIdRequest")
> public static final class PostClientsClientIdRequest {
> private PostClientsClientIdRequest() {}
> @Schema(example = "We cannot accept transfers of clients having loans 
> with less than 1 repayment left")
> public String note;
> }
> {code}
> the  PostClientsClientIdRequest must define the required field in order to 
> generate the valid client.
> Also officeId field is missing in the returned response while activating a 
> client.
> {code:java}
> // defined in swagger resource class
> @Schema(description = "PostClientsClientIdResponse")
> public static final class PostClientsClientIdResponse {
> private PostClientsClientIdResponse() {}
> @Schema(example = "2")
> public Integer clientId;
> @Schema(example = "2")
> public Integer resourceId;
> }
> // actual json returned
> {
>   "officeId": 2,
>   "clientId": 6,
>   "resourceId": 6
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1366) invalid fields in PostClientsClientIdRequest in clientsApiResourceSwagger

2021-08-06 Thread Danish Jamal (Jira)
Danish Jamal created FINERACT-1366:
--

 Summary: invalid fields in PostClientsClientIdRequest in 
clientsApiResourceSwagger
 Key: FINERACT-1366
 URL: https://issues.apache.org/jira/browse/FINERACT-1366
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Danish Jamal
Assignee: Danish Jamal


Expected body payload while activating the client:
{code:java}
{  
"activationDate": "02 August 2021", 
"dateFormat": "dd  ", 
"locale": "en"
}
{code}
Payload model (PostClientsClientIdRequest):
{code:java}
@Schema(description = "PostClientsClientIdRequest")
public static final class PostClientsClientIdRequest {

private PostClientsClientIdRequest() {}

@Schema(example = "We cannot accept transfers of clients having loans with 
less than 1 repayment left")
public String note;
}
{code}
the  PostClientsClientIdRequest must define the required field in order to 
generate the valid client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINERACT-1365) invalid swagger annotations in DatatablesApiResource for posting datatable

2021-08-06 Thread Danish Jamal (Jira)
Danish Jamal created FINERACT-1365:
--

 Summary: invalid swagger annotations in DatatablesApiResource for 
posting datatable
 Key: FINERACT-1365
 URL: https://issues.apache.org/jira/browse/FINERACT-1365
 Project: Apache Fineract
  Issue Type: Bug
Reporter: Danish Jamal
Assignee: Danish Jamal
 Attachments: Screenshot 2021-08-06 at 10.22.06 PM.png, Screenshot 
2021-08-06 at 10.22.17 PM.png

DatatablesApiResourceSwagger.java has invalid body fields while posting the new 
datable.
Checkout the difference in fields in below attached screenshots.
This issue is mainly due to invalid swagger resource file. Hence the doc 
mentioned in the older html is correct and the 
DatatablesApiResourceSwagger.java must be modified to meet the actual api body 
expectations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1364) Missmatch datatype in groups field of client model "GetClientsClientIdResponse"

2021-08-06 Thread Danish Jamal (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Danish Jamal reassigned FINERACT-1364:
--

Assignee: Danish Jamal

> Missmatch datatype in groups field of client model 
> "GetClientsClientIdResponse"
> ---
>
> Key: FINERACT-1364
> URL: https://issues.apache.org/jira/browse/FINERACT-1364
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Danish Jamal
>Assignee: Danish Jamal
>Priority: Major
> Attachments: Screenshot 2021-07-28 at 2.28.17 PM.png, Screenshot 
> 2021-07-28 at 2.30.33 PM.png
>
>
> The generated Fineract-client model "*GetClientsClientIdResponse"* has 
> invalid group fields. The model class expects List as groups find but 
> backend send the below Object for endpoint clients/\{clientId}. 
> {
>  "id": 13,
>  "accountNo": "00013",
>  "name": "Test"
>  }
> Checkout the below screenshots for model expectations and backend response.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINERACT-1364) Missmatch datatype in groups field of client model "GetClientsClientIdResponse"

2021-08-06 Thread Danish Jamal (Jira)


[ 
https://issues.apache.org/jira/browse/FINERACT-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394894#comment-17394894
 ] 

Danish Jamal commented on FINERACT-1364:


[~Grandolf49] and [~edcable] please take a look.

> Missmatch datatype in groups field of client model 
> "GetClientsClientIdResponse"
> ---
>
> Key: FINERACT-1364
> URL: https://issues.apache.org/jira/browse/FINERACT-1364
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Danish Jamal
>Assignee: Danish Jamal
>Priority: Major
> Attachments: Screenshot 2021-07-28 at 2.28.17 PM.png, Screenshot 
> 2021-07-28 at 2.30.33 PM.png
>
>
> The generated Fineract-client model "*GetClientsClientIdResponse"* has 
> invalid group fields. The model class expects List as groups find but 
> backend send the below Object for endpoint clients/\{clientId}. 
> {
>  "id": 13,
>  "accountNo": "00013",
>  "name": "Test"
>  }
> Checkout the below screenshots for model expectations and backend response.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FINCN-337) Artifactory environment values changed to variables

2021-08-06 Thread Victor Romero (Jira)
Victor Romero created FINCN-337:
---

 Summary: Artifactory environment values changed to variables
 Key: FINCN-337
 URL: https://issues.apache.org/jira/browse/FINCN-337
 Project: Fineract Cloud Native
  Issue Type: Improvement
Reporter: Victor Romero


The Artifactory parameters set in the Gradle files must be set to variables in 
order to be more flexible about contributions and also to fit the 
specific/local Artifactory repositories

 

A fix has been sent 

[https://github.com/apache/fineract-cn-provisioner/pull/18]

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FINERACT-1363) Datatables field missing in PostClientsRequest in generated Fineract-client sd

2021-08-06 Thread Danish Jamal (Jira)


 [ 
https://issues.apache.org/jira/browse/FINERACT-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Danish Jamal reassigned FINERACT-1363:
--

Assignee: Danish Jamal

> Datatables field missing in PostClientsRequest in generated Fineract-client sd
> --
>
> Key: FINERACT-1363
> URL: https://issues.apache.org/jira/browse/FINERACT-1363
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Danish Jamal
>Assignee: Danish Jamal
>Priority: Major
> Attachments: s3.png, ss1.png, ss2.png
>
>
> In ss1 I tried to create client using the fields as mentioned in Swagger doc/ 
> generated model(PostClientsRequest class), checkout the ss2 there is no field 
> for datatables expected in body.But for testing purpose I tried including the 
> {{"datatables"}}  field in body (check ss3) and it worked. 
> Hence API expects user to pass "database" fields while creating new client, 
> but the field is missing in the body payload class (PostClientsRequest).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FINCN-252) Machine Learning Scorecard for Credit Risk Assessment Phase 4

2021-08-06 Thread Yemdjih Kaze Nasser (Jira)


[ 
https://issues.apache.org/jira/browse/FINCN-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17394554#comment-17394554
 ] 

Yemdjih Kaze Nasser commented on FINCN-252:
---

Thanks for creating the repository, will push the changes there ASAP.

> Machine Learning Scorecard for Credit Risk Assessment Phase 4
> -
>
> Key: FINCN-252
> URL: https://issues.apache.org/jira/browse/FINCN-252
> Project: Fineract Cloud Native
>  Issue Type: Improvement
>Reporter: Ed Cable
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
>  Labels: gsoc2021, mentor
>
> h2. Mentors
>  * Lalit Mohan S
>  * [~Fintecheando]
> h2. Overview & Objectives
> Financial Organizations using Mifos/Fineract are depending on external 
> agencies or their past experiences for evaluating credit scoring and 
> identification of potential NPAs. Though information from external agencies 
> is required, financial organizations can have an internal scorecard for 
> evaluating loans so that preventive/proactive actions can be done along with 
> external agencies reports. In industry, organizations are using rule based, 
> Statistical and Machine learning methods for credit scoring, predicting 
> potential NPAs, fraud detection and other activities. This project aims to 
> implement a scorecard based on statistical and ML methods for credit scoring 
> and identification of potential NPAs.
> h2. Description
> The approach should factor and improve last year's GSOC work 
> ([https://gist.github.com/SupreethSudhakaranMenon/a20251271adb341f949dbfeb035191f7])
>  on Features/Characteristics, Criteria and evaluation (link). The design and 
> implementation of the screens should follow Mifos Application standards. 
> Should implement statistical and ML methods with explainability on decision 
> making. Should also be extensible for adding other functionalities such as 
> fraud detection, cross-sell and up-sell, etc.
> h2. Helpful Skills
> JAVA, Integrating Backend Service, MIFOS X, Apache Fineract, AngularJS, ORM, 
> ML, Statistical Methods, Django
> h2. Impact
> Streamlined Operations, Better RISK Management, Automated Response Mechanism
> h2. Other Resources
> 2019 Progress: 
> [https://gist.github.com/SupreethSudhakaranMenon/a20251271adb341f949dbfeb035191f7]
> [https://gist.github.com/lalitsanagavarapu]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)