[jira] [Commented] (FINERACT-1571) Read/write/batch separation
[ https://issues.apache.org/jira/browse/FINERACT-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519918#comment-17519918 ] Petri Tuomola commented on FINERACT-1571: - Hi [~arnold] - great idea. I'm assuming that initially the instances would share the same database and would only consist of the application instance - correct? And then as second step we could create a separate read-only replica database for the read instances, whilst keeping the write / batch instances pointing at the "master" database? I'm assuming the first step would be to start classifying / declaring APIs to be read-only vs write, so that it's clear which APIs can be called on the read instance. I'm assuming this is pretty straightforward in most cases, though I think we do need to confirm that the read APIs do not have any "side effects". For example, I seem to recall that there was some code for creating an audit trail that logged which APIs were called - we should think about how that should work on read instances. Similarly I think some of the report / template read APIs might actually create temp directories / files on the server. This may or may not be a problem on a read instance... Anyway - fully agree with the idea, and think this would be a great step forward... > Read/write/batch separation > --- > > Key: FINERACT-1571 > URL: https://issues.apache.org/jira/browse/FINERACT-1571 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Arnold Galovics >Assignee: Arnold Galovics >Priority: Major > > The goal of this ticket is to introduce the notion of 3 different instance > types for Fineract: > * Read instance > * Write instance > * Batch instance > Each instance type comes with different restrictions. The specifics can be > found in the table below. > || ||*Read instance*||*Write instance*||*Batch instance*|| > |*Using only read-only DB connection*|Yes|No|No| > |*Batch jobs are automatically scheduled or startable via API*|No|No|Yes| > |*Can receive events (business events, hook template events)*|No|Yes|No| > |*Can send events (business events, hook template events)*|No|Yes|Yes| > |*Read APIs supported*|Yes|Yes|No| > |*Write APIs supported*|No|Yes|No| > |*Batch job APIs supported*|No|No|Yes| > |*Liquibase migration initiated upon startup*|No|Yes|No| > This will help scaling Fineract's individual parts for highly-available and > high-throughput systems. > Also, this will make it possible to utilize read-replica databases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1482) Docker Hub Build broke with switch from Dockerfile to JIB
[ https://issues.apache.org/jira/browse/FINERACT-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487645#comment-17487645 ] Petri Tuomola commented on FINERACT-1482: - Until now I think we've only pushed the develop branch builds. Not quite sure how that works as I haven't found any code / scripts that actually does it, but if I look on Docker Hub the latest image has been there. Going forward I think we should definitely push the releases, but it would be nice to push also the latest develop branch build. Re the credentials: [~vorburger] in line with your earlier comment, would you be able to make the Docker Hub credentials available as GitHub Secrets? > Docker Hub Build broke with switch from Dockerfile to JIB > - > > Key: FINERACT-1482 > URL: https://issues.apache.org/jira/browse/FINERACT-1482 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Affects Versions: 1.6.0 >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Blocker > Fix For: 1.6.0 > > > https://github.com/apache/fineract/commits/develop shows a lot of ugly red > crosses since recently. > I've had a look at why that is so, and one issue (together with another one > re. Sonar) is _ci/dockercloud-stage — Your image failed to build_. > I originally had set this up, see FINERACT-760 (and have access to the Docker > Hub Build Logs). > This is an impact of https://github.com/apache/fineract/pull/2009 for > FINERACT-1469, just like > https://github.com/vorburger/www.fineract.dev/issues/11. > I'm not going to be able to further look much into this myself, but perhaps > [~aleks] you would be interested in researching how this could be fixed? > If we cannot fix it (whether just time wise, or for some technical reasons), > then I would propose that we remove > https://hub.docker.com/repository/docker/apache/fineract/general. That may > warrant some discussion on the mailing list though - last time I looked at > the numbers (for ApacheCon) this container had HUGE (!) numbers of downloads. > A possible alternative could be to open up the container I'm anyway building > on https://www.fineract.dev and distribute that one instead? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1483) Fix the top few issues which Sonar has identified, and then enable enforcement of Sonar?
[ https://issues.apache.org/jira/browse/FINERACT-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471117#comment-17471117 ] Petri Tuomola commented on FINERACT-1483: - Actually that's just the bugs and vulnerabilities in the code modified in the last 29 days... If you look at the tab for all code, the full number is something like 250+ and 33+. Still agree with your point that we should fix these and also make the check prevent new ones from being introduced. But fixing all of these will take a bit more time... > Fix the top few issues which Sonar has identified, and then enable > enforcement of Sonar? > > > Key: FINERACT-1483 > URL: https://issues.apache.org/jira/browse/FINERACT-1483 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Blocker > > https://sonarcloud.io/summary/new_code?branch=develop=apache_fineract is > interesting. > While its 499 "Code Smells" would be a lot of work to trawl through, > those 4 Bugs and 2 Security Hotspots it identified should just be hours (or a > day or two) of work, not days or weeks. > After someone has contributed fixes for those issues, then we could probably > enable enforcement and make every Pull Request instead of only the master > branch run a Sonar test, and fail the PRs if they introduce regressions? (It > appears that currenlty Sonar only runs on the devel branch, which is not > ideal IMHO.) > FYI [~ptuomola] and [~Fintecheando] ([~victorromero] [~vromero]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1480) Swagger UI is broken
[
https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470660#comment-17470660
]
Petri Tuomola commented on FINERACT-1480:
-
This seems to now work after the latest change
> Swagger UI is broken
>
>
> Key: FINERACT-1480
> URL: https://issues.apache.org/jira/browse/FINERACT-1480
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
> Fix For: 1.6.0
>
>
> While testing https://github.com/vorburger/www.fineract.dev/issues/11 and
> following the first links mentioned on https://www.fineract.dev, namely
> https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as
> https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have
> noticed that the Swagger YAML and thus UI has recently been broken.
> It's curious that the
> https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java
> did not catch this regression. It would be nice if this were addressed as
> part of fixing this. Would it perhaps suffice to add a {{GET
> /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}})
> to that test? Or is it a (Docker) Container Image specific regression?
> [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding
> a solution for this interests you, or you want to point anyone at this issue.
> (I won't be working on this, I'm just filing issues for what I find in the
> Fineract.dev logs.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FINERACT-1480) Swagger UI is broken
[
https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470657#comment-17470657
]
Petri Tuomola commented on FINERACT-1480:
-
Hi [~vorburger] - in this case I needed to make the same change 4 times: once
for WAR, another one for bootRun, another one for bootJar and finally one for
Docker. Out of these, the only one that is tested by our integration tests is
the WAR file.
I think this may be a bit of an outlier, as normally you could just make one
change that would update all the 4 distribution modes - but in this case I
could not think of any way of doing so. However, this is definitely not the
only case where we've ended up with different functionality / issues between
JAR vs Docker vs...
Given this, I think we should have a bit of a think re what are the "officially
supported" distribution artefacts and then ensure we have full testing coverage
for them. Rather than developing 4 different sets of integration tests covering
these 4 different distribution modes, perhaps we could drop the support for
some of these - and then run the full set of integration tests against the
remaining ones...
> Swagger UI is broken
>
>
> Key: FINERACT-1480
> URL: https://issues.apache.org/jira/browse/FINERACT-1480
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
> Fix For: 1.6.0
>
>
> While testing https://github.com/vorburger/www.fineract.dev/issues/11 and
> following the first links mentioned on https://www.fineract.dev, namely
> https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as
> https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have
> noticed that the Swagger YAML and thus UI has recently been broken.
> It's curious that the
> https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java
> did not catch this regression. It would be nice if this were addressed as
> part of fixing this. Would it perhaps suffice to add a {{GET
> /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}})
> to that test? Or is it a (Docker) Container Image specific regression?
> [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding
> a solution for this interests you, or you want to point anyone at this issue.
> (I won't be working on this, I'm just filing issues for what I find in the
> Fineract.dev logs.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (FINERACT-1198) Gradle incremental build is broken
[ https://issues.apache.org/jira/browse/FINERACT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1198. - Fix Version/s: 1.6.0 Resolution: Fixed > Gradle incremental build is broken > -- > > Key: FINERACT-1198 > URL: https://issues.apache.org/jira/browse/FINERACT-1198 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Blocker > Fix For: 1.6.0 > > > One of the reasons why Gradle is (supposedly) so much cooler than e.g. Maven > is that it can be really support and support very fast "incremental" builds > (only rebuild what has changed). > I have the impression that doesn't really work in Fineract, and suppose > that's not really Gradle's (core) fault, but some plugin which screws this > up? OpenJPA Enhancer, SpotBugs... presumably they all have to "play along" > for this to work perfectly? > My Gradle foo isn't (nearly) good enough to know if it would be possible to > "fix" this, and how hard this may be, but filing an issue is perhaps a start > for getting input from people more knowledgeable about this. > [~aleks] and/or [~ptuomola] perhaps you have ideas about this. > [~aalmiray] as per chat during ApacheCon, not sure if this is the kind of > thing you may enjoy helping with? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1482) Docker Hub Build broke with switch from Dockerfile to JIB
[ https://issues.apache.org/jira/browse/FINERACT-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470590#comment-17470590 ] Petri Tuomola commented on FINERACT-1482: - Thanks [~vorburger] - I was actually wondering how the Docker Hub build worked, as I could not find any code for this. We are anyway building a Docker image as part of the build script in Github... maybe we could just add a step of pushing this to Docker Hub? That would then ideally also mean that when we build a release build, we could similarly push the corresponding image to Docker Hub and tag that accordingly... which I think would be a great addition. > Docker Hub Build broke with switch from Dockerfile to JIB > - > > Key: FINERACT-1482 > URL: https://issues.apache.org/jira/browse/FINERACT-1482 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Affects Versions: 1.6.0 >Reporter: Michael Vorburger >Priority: Blocker > Fix For: 1.6.0 > > > https://github.com/apache/fineract/commits/develop shows a lot of ugly red > crosses since recently. > I've had a look at why that is so, and one issue (together with another one > re. Sonar) is _ci/dockercloud-stage — Your image failed to build_. > I originally had set this up, see FINERACT-760 (and have access to the Docker > Hub Build Logs). > This is an impact of https://github.com/apache/fineract/pull/2009 for > FINERACT-1469, just like > https://github.com/vorburger/www.fineract.dev/issues/11. > I'm not going to be able to further look much into this myself, but perhaps > [~aleks] you would be interested in researching how this could be fixed? > If we cannot fix it (whether just time wise, or for some technical reasons), > then I would propose that we remove > https://hub.docker.com/repository/docker/apache/fineract/general. That may > warrant some discussion on the mailing list though - last time I looked at > the numbers (for ApacheCon) this container had HUGE (!) numbers of downloads. > A possible alternative could be to open up the container I'm anyway building > on https://www.fineract.dev and distribute that one instead? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1480) Swagger UI is broken (because fineract.yaml moved?)
[
https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470556#comment-17470556
]
Petri Tuomola commented on FINERACT-1480:
-
Ok - let me check. It works for me locally so can try to find out what's
different on Fineract.dev
> Swagger UI is broken (because fineract.yaml moved?)
> ---
>
> Key: FINERACT-1480
> URL: https://issues.apache.org/jira/browse/FINERACT-1480
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
> Fix For: 1.6.0
>
>
> While testing https://github.com/vorburger/www.fineract.dev/issues/11 and
> following the first links mentioned on https://www.fineract.dev, namely
> https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as
> https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have
> noticed that the Swagger YAML and thus UI has recently been broken.
> It's curious that the
> https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java
> did not catch this regression. It would be nice if this were addressed as
> part of fixing this. Would it perhaps suffice to add a {{GET
> /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}})
> to that test? Or is it a (Docker) Container Image specific regression?
> [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding
> a solution for this interests you, or you want to point anyone at this issue.
> (I won't be working on this, I'm just filing issues for what I find in the
> Fineract.dev logs.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (FINERACT-1480) Swagger UI is broken (because fineract.yaml moved?)
[
https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1480.
-
Fix Version/s: 1.6.0
Resolution: Fixed
> Swagger UI is broken (because fineract.yaml moved?)
> ---
>
> Key: FINERACT-1480
> URL: https://issues.apache.org/jira/browse/FINERACT-1480
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
> Fix For: 1.6.0
>
>
> While testing https://github.com/vorburger/www.fineract.dev/issues/11 and
> following the first links mentioned on https://www.fineract.dev, namely
> https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as
> https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have
> noticed that the Swagger YAML and thus UI has recently been broken.
> It's curious that the
> https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java
> did not catch this regression. It would be nice if this were addressed as
> part of fixing this. Would it perhaps suffice to add a {{GET
> /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}})
> to that test? Or is it a (Docker) Container Image specific regression?
> [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding
> a solution for this interests you, or you want to point anyone at this issue.
> (I won't be working on this, I'm just filing issues for what I find in the
> Fineract.dev logs.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FINERACT-1480) Swagger UI is broken (because fineract.yaml moved?)
[
https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469043#comment-17469043
]
Petri Tuomola commented on FINERACT-1480:
-
I think I must have broken this with my incremental compilation PR... Will fix
later today
> Swagger UI is broken (because fineract.yaml moved?)
> ---
>
> Key: FINERACT-1480
> URL: https://issues.apache.org/jira/browse/FINERACT-1480
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
>
> While testing https://github.com/vorburger/www.fineract.dev/issues/11 and
> following the first links mentioned on https://www.fineract.dev, namely
> https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as
> https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have
> noticed that the Swagger YAML and thus UI has recently been broken.
> It's curious that the
> https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java
> did not catch this regression. It would be nice if this were addressed as
> part of fixing this. Would it perhaps suffice to add a {{GET
> /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}})
> to that test? Or is it a (Docker) Container Image specific regression?
> [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding
> a solution for this interests you, or you want to point anyone at this issue.
> (I won't be working on this, I'm just filing issues for what I find in the
> Fineract.dev logs.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (FINERACT-1480) Swagger UI is broken (because fineract.yaml moved?)
[
https://issues.apache.org/jira/browse/FINERACT-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-1480:
---
Assignee: Petri Tuomola
> Swagger UI is broken (because fineract.yaml moved?)
> ---
>
> Key: FINERACT-1480
> URL: https://issues.apache.org/jira/browse/FINERACT-1480
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
>
> While testing https://github.com/vorburger/www.fineract.dev/issues/11 and
> following the first links mentioned on https://www.fineract.dev, namely
> https://demo.fineract.dev/fineract-provider/swagger-ui/index.html (as well as
> https://demo.fineract.dev/fineract-provider/swagger-ui/fineract.yaml) I have
> noticed that the Swagger YAML and thus UI has recently been broken.
> It's curious that the
> https://github.com/apache/fineract/blob/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/SwaggeruiTest.java
> did not catch this regression. It would be nice if this were addressed as
> part of fixing this. Would it perhaps suffice to add a {{GET
> /fineract-provider/swagger-ui/fineract.yaml}} (in addition to {{index.html}})
> to that test? Or is it a (Docker) Container Image specific regression?
> [~ptuomola] or [~aleks] or maybe [~Manthan] perhaps digging into and finding
> a solution for this interests you, or you want to point anyone at this issue.
> (I won't be working on this, I'm just filing issues for what I find in the
> Fineract.dev logs.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FINERACT-1474) Remove hard-coded constant from ThitsaworksCreditBureauTest
[
https://issues.apache.org/jira/browse/FINERACT-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467713#comment-17467713
]
Petri Tuomola commented on FINERACT-1474:
-
Hmm... to me it just looks like test data being used to mock the server
response and to verify the mocked response.
So the string "testResult" contains the hardcoded response from the server -
this is being injected with Mockito to
ThitsaWorksCreditBureauIntegrationWritePlatformServiceImpl so that when someone
calls okHttpConnectionMethod they get this response.
Then in the test the values extracted by
ThitsaWorksCreditBureauIntegrationWritePlatformServiceImpl from that mock
response are compared with the known constants e.g. subscriptionID to confirm
the extraction routine works well.
So I don't think there's anything harmful here. assuming the IDs contained in
the mock response are not real ones. And I doubt they are, given the instance
is given as "qa-mmc..." and the institution as "Demo 1".
If we want to be certain we could always just modify them by modifying the
string testResult as well as the constants - it should not matter what they are
as long as they are a) the same and b) syntactically correct.
> Remove hard-coded constant from ThitsaworksCreditBureauTest
> ---
>
> Key: FINERACT-1474
> URL: https://issues.apache.org/jira/browse/FINERACT-1474
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Blocker
>
> https://www.gitguardian.com is telling me that it thinks that the constant
> {{subscriptionKey}} (and probably others there such as {{subscriptionId}}) in
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/ThitsaworksCreditBureauTest.java
> is Not a Great Idea.
> I'm not sure what that's for, and won't have the time to look into it, but it
> does seem curious, so I thought I would at least file this issue.
> [~petri.tuom...@gmail.com] ([~ptuomola]) and [~aleks] ([~avidakovic]
> [~vidakovic]) and [~awasum] FYI.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FINERACT-1198) Gradle incremental build is broken
[ https://issues.apache.org/jira/browse/FINERACT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467546#comment-17467546 ] Petri Tuomola commented on FINERACT-1198: - So as I assumed, splitting the enhanced / JPA files to a different project did not work - there is too much business logic mixed in. However, I found a way to run the enhancer without triggering a full rebuild. The key is to run it as doLast() of the compileJava task, not as a separate task. If it's separate task then compileJava will think its outputs have been changed - but this does not happen if it's part of the same task. Unfortunately running enhance as a separate task is hardcoded into the OpenJPA plug-in, so I had to ditch that and write custom code into our build.gradle to run the enhancer. The good news is that this now works. The only task that is now running as "full build" is spotlessJava which - for some reason - always thinks it's input parameter "steps" has changed, and this triggers a rebuild. Something to investigate... Another possible improvements: * Enhance currently runs for all domain class files, not just for the ones modified. This is not really a problem as it takes only a second or so, but it would be of course nice just to run it for the modified ones. * I'm pretty sure my "custom enhance" task has broken Eclipse enhance task. Next will need to see how to get that working again. > Gradle incremental build is broken > -- > > Key: FINERACT-1198 > URL: https://issues.apache.org/jira/browse/FINERACT-1198 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Blocker > > One of the reasons why Gradle is (supposedly) so much cooler than e.g. Maven > is that it can be really support and support very fast "incremental" builds > (only rebuild what has changed). > I have the impression that doesn't really work in Fineract, and suppose > that's not really Gradle's (core) fault, but some plugin which screws this > up? OpenJPA Enhancer, SpotBugs... presumably they all have to "play along" > for this to work perfectly? > My Gradle foo isn't (nearly) good enough to know if it would be possible to > "fix" this, and how hard this may be, but filing an issue is perhaps a start > for getting input from people more knowledgeable about this. > [~aleks] and/or [~ptuomola] perhaps you have ideas about this. > [~aalmiray] as per chat during ApacheCon, not sure if this is the kind of > thing you may enjoy helping with? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1198) Gradle incremental build is broken
[ https://issues.apache.org/jira/browse/FINERACT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467063#comment-17467063 ] Petri Tuomola commented on FINERACT-1198: - [~aleks] [~vorburger] I think the biggest culprit for this is the OpenJPA bytecode enhancement. What seems to happen is: 1. Enhance takes the classes output from compileJava and changes them 2. Because of #1, next time when we run compileJava it sees its outputs have changed and goes for a full rebuild 3. Because of #2, enhance sees its inputs have changed and changes the classes again Etc etc My first thought was that if we could make OpenJPA plug-in support incremental builds, then perhaps that would help with this issue. But I've just tried it by adding the incremental build support to OpenJPA plug-in and unfortunately it did not help: even if only a handful of classes are modified, compileJava thinks it needs to do a full rebuild. I suppose that's because of the dependencies between classes (i.e. everything depends on the domain classes, so if they have changed then everything will get rebuilt). So that approach did not get us anywhere... What I'd like to do now is to see what happens if we separate the OpenJPA enhanced domain classes to a separate Gradle project / JAR file? That way only that JAR file would get rebuilt every time after enhancement, not the whole Fineract. I know this is not the separation that would make most sense in terms of making the whole application modular. But if that allows majority (i.e. non-database changing) to be done as incremental builds, then that would be great! What I'm worried about is whether the domain classes can be segregated cleanly it might be that too much business logic has crept in here to make that possible. But I'll have a look. > Gradle incremental build is broken > -- > > Key: FINERACT-1198 > URL: https://issues.apache.org/jira/browse/FINERACT-1198 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Blocker > > One of the reasons why Gradle is (supposedly) so much cooler than e.g. Maven > is that it can be really support and support very fast "incremental" builds > (only rebuild what has changed). > I have the impression that doesn't really work in Fineract, and suppose > that's not really Gradle's (core) fault, but some plugin which screws this > up? OpenJPA Enhancer, SpotBugs... presumably they all have to "play along" > for this to work perfectly? > My Gradle foo isn't (nearly) good enough to know if it would be possible to > "fix" this, and how hard this may be, but filing an issue is perhaps a start > for getting input from people more knowledgeable about this. > [~aleks] and/or [~ptuomola] perhaps you have ideas about this. > [~aalmiray] as per chat during ApacheCon, not sure if this is the kind of > thing you may enjoy helping with? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1198) Gradle incremental build is broken
[ https://issues.apache.org/jira/browse/FINERACT-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1198: --- Assignee: Petri Tuomola > Gradle incremental build is broken > -- > > Key: FINERACT-1198 > URL: https://issues.apache.org/jira/browse/FINERACT-1198 > Project: Apache Fineract > Issue Type: Bug > Components: Build >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Blocker > > One of the reasons why Gradle is (supposedly) so much cooler than e.g. Maven > is that it can be really support and support very fast "incremental" builds > (only rebuild what has changed). > I have the impression that doesn't really work in Fineract, and suppose > that's not really Gradle's (core) fault, but some plugin which screws this > up? OpenJPA Enhancer, SpotBugs... presumably they all have to "play along" > for this to work perfectly? > My Gradle foo isn't (nearly) good enough to know if it would be possible to > "fix" this, and how hard this may be, but filing an issue is perhaps a start > for getting input from people more knowledgeable about this. > [~aleks] and/or [~ptuomola] perhaps you have ideas about this. > [~aalmiray] as per chat during ApacheCon, not sure if this is the kind of > thing you may enjoy helping with? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1391) Customizable Account Number Preferences
[ https://issues.apache.org/jira/browse/FINERACT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1391. - Resolution: Fixed > Customizable Account Number Preferences > --- > > Key: FINERACT-1391 > URL: https://issues.apache.org/jira/browse/FINERACT-1391 > Project: Apache Fineract > Issue Type: Improvement > Components: Savings >Reporter: Francis Guchie >Assignee: Rahul Pawar >Priority: Major > Fix For: 1.6.0 > > Attachments: image-2021-08-26-20-20-24-111.png, > image-2021-08-26-20-23-36-531.png > > > As a user i would like to set an account prefix that is neither > SAVINGS_PRODUCT_SHORT_NAME > nor OFFICE_NAME, These 2 are limited to the fact the short name can not be > the same. > Secondly, this prefix, I would like it to be a part of the number of digits > that make the account number not an addition to the existing length of the > account number length > Image one the Setting of the preference should be like below > !image-2021-08-26-20-20-24-111.png! > > And after this is set i want to see something like this below > !image-2021-08-26-20-23-36-531.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FINERACT-1441) Enhance charges payments so that the user can select a payment type like Cash or Bank
[ https://issues.apache.org/jira/browse/FINERACT-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1441: Fix Version/s: (was: 1.5.1) > Enhance charges payments so that the user can select a payment type like Cash > or Bank > - > > Key: FINERACT-1441 > URL: https://issues.apache.org/jira/browse/FINERACT-1441 > Project: Apache Fineract > Issue Type: Improvement > Components: Charges >Affects Versions: 1.5.0 >Reporter: Kigenyi Wilfred >Priority: Minor > Labels: patch > > Currently there is no way for a user to specify the source of funds when > settling (paying) a charge for a client. This means that if the cashier > received cash to pay a charge, he/she will have more cash than the system > reports. In order to resolve to we should provide for a payment method when a > client is settling a charge. This will make the solution more self contained > and accurate -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FINERACT-1384) Installment rounding of Interest amount
[ https://issues.apache.org/jira/browse/FINERACT-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1384: Fix Version/s: (was: 1.5.1) > Installment rounding of Interest amount > --- > > Key: FINERACT-1384 > URL: https://issues.apache.org/jira/browse/FINERACT-1384 > Project: Apache Fineract > Issue Type: New Feature > Components: Loan >Affects Versions: 1.5.0 >Reporter: bharath gowda >Priority: Major > Attachments: image-2021-08-16-19-17-41-919.png, interest rounding > method.xlsx > > > Current loan repayment schedule, the system has an option to round off an > installment amount (in multiples of) which rounds of the principal amount. > > But few prospects in the Uganda region do the installment rounding with the > interest rounding method. > We have to enhance the application to support interest amount rounding. > there can be a selection to round principal or interest when the rounding is > defined at the loan product level. > > have attached sample excel and screenshot for reference > !image-2021-08-16-19-17-41-919.png! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Reopened] (FINERACT-1325) Solution for using Pentaho in latest build
[ https://issues.apache.org/jira/browse/FINERACT-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reopened FINERACT-1325: - > Solution for using Pentaho in latest build > --- > > Key: FINERACT-1325 > URL: https://issues.apache.org/jira/browse/FINERACT-1325 > Project: Apache Fineract > Issue Type: Improvement > Components: Reports >Affects Versions: 1.4.0, 1.5.0, 1.6.0 >Reporter: Francis Guchie >Priority: Major > Fix For: 1.5.1 > > > Pentaho no longer ships with the latest build of Fineract (Non-CN) > following the conversions on > https://issues.apache.org/jira/browse/FINERACT-1127 > https://issues.apache.org/jira/browse/FINERACT-1125 > and > https://issues.apache.org/jira/browse/FINERACT-1094 > [~vorburger] created a new repo below with clear instructions on how to test > this Pentaho module as a separate entity read here ==> > [https://github.com/vorburger/fineract-pentaho] > All will work fine as long as one is not using the drizzle driver and after > seeing comments on https://issues.apache.org/jira/browse/FINERACT-982 > A trial with the mysql: java driver / connector (cj) would solve this > challenge -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1325) Solution for using Pentaho in latest build
[ https://issues.apache.org/jira/browse/FINERACT-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1325. - Fix Version/s: 1.6.0 (was: 1.5.1) Resolution: Fixed > Solution for using Pentaho in latest build > --- > > Key: FINERACT-1325 > URL: https://issues.apache.org/jira/browse/FINERACT-1325 > Project: Apache Fineract > Issue Type: Improvement > Components: Reports >Affects Versions: 1.4.0, 1.5.0, 1.6.0 >Reporter: Francis Guchie >Priority: Major > Fix For: 1.6.0 > > > Pentaho no longer ships with the latest build of Fineract (Non-CN) > following the conversions on > https://issues.apache.org/jira/browse/FINERACT-1127 > https://issues.apache.org/jira/browse/FINERACT-1125 > and > https://issues.apache.org/jira/browse/FINERACT-1094 > [~vorburger] created a new repo below with clear instructions on how to test > this Pentaho module as a separate entity read here ==> > [https://github.com/vorburger/fineract-pentaho] > All will work fine as long as one is not using the drizzle driver and after > seeing comments on https://issues.apache.org/jira/browse/FINERACT-982 > A trial with the mysql: java driver / connector (cj) would solve this > challenge -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FINERACT-1464) Downgrade Docker image back to Java 11
[ https://issues.apache.org/jira/browse/FINERACT-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1464: Fix Version/s: 1.6.0 > Downgrade Docker image back to Java 11 > -- > > Key: FINERACT-1464 > URL: https://issues.apache.org/jira/browse/FINERACT-1464 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1464) Downgrade Docker image back to Java 11
[ https://issues.apache.org/jira/browse/FINERACT-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1464: --- Assignee: Petri Tuomola > Downgrade Docker image back to Java 11 > -- > > Key: FINERACT-1464 > URL: https://issues.apache.org/jira/browse/FINERACT-1464 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FINERACT-1464) Downgrade Docker image back to Java 11
Petri Tuomola created FINERACT-1464: --- Summary: Downgrade Docker image back to Java 11 Key: FINERACT-1464 URL: https://issues.apache.org/jira/browse/FINERACT-1464 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1457) Fineract no longer works with MySQL 5.7 due to Flyway v8 upgrade
[
https://issues.apache.org/jira/browse/FINERACT-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-1457:
---
Assignee: Petri Tuomola
> Fineract no longer works with MySQL 5.7 due to Flyway v8 upgrade
>
>
> Key: FINERACT-1457
> URL: https://issues.apache.org/jira/browse/FINERACT-1457
> Project: Apache Fineract
> Issue Type: Bug
> Components: Database
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Critical
> Fix For: 1.6.0
>
>
> https://www.fineract.dev is failing to upgrade to the latest bleeding edge
> Fineract code from master branch, see
> https://github.com/vorburger/www.fineract.dev/issues/8:
> {noformat}
> 2021-12-29 18:54:47.772 ERROR 10 --- [ main]
> o.s.b.web.embedded.tomcat.TomcatStarter : Error starting Tomcat context.
> Exception: org.springframework.beans.factory.UnsatisfiedDependencyException.
> Message: Error creating bean with name 'securityConfig': Unsatisfied
> dependency expressed through field 'userDetailsService'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'userDetailsService': Unsatisfied dependency
> expressed through field 'platformUserRepository'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'appUserRepository' defined in
> org.apache.fineract.useradministration.domain.AppUserRepository defined in
> @EnableJpaRepositories declared on PersistenceConfig: Cannot create inner
> bean '(inner bean)#4ab90d01' of type
> [org.springframework.orm.jpa.SharedEntityManagerCreator] while setting bean
> property 'entityManager'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name '(inner bean)#4ab90d01': Cannot resolve reference to bean
> 'entityManagerFactory' while setting constructor argument; nested exception
> is org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'tenantDatabaseUpgradeService': Invocation of init method
> failed; nested exception is
> org.flywaydb.core.internal.license.FlywayEditionUpgradeRequiredException:
> Flyway Teams Edition or MySQL upgrade required: MySQL 5.7 is no longer
> supported by Flyway Community Edition, but still supported by Flyway Teams
> Edition.
> (...)
> Caused by:
> org.flywaydb.core.internal.license.FlywayEditionUpgradeRequiredException:
> Flyway Teams Edition or MySQL upgrade required: MySQL 5.7 is no longer
> supported by Flyway Community Edition, but still supported by Flyway Teams
> Edition.
> at
> org.flywaydb.core.internal.database.base.Database.ensureDatabaseNotOlderThanOtherwiseRecommendUpgradeToFlywayEdition(Database.java:126)
> at
> org.flywaydb.core.internal.database.mysql.MySQLDatabase.ensureSupported(MySQLDatabase.java:252)
> at org.flywaydb.core.FlywayExecutor.execute(FlywayExecutor.java:188)
> at org.flywaydb.core.Flyway.repair(Flyway.java:335)
> at
> org.apache.fineract.infrastructure.core.service.TenantDatabaseUpgradeService.upgradeTenantDB(TenantDatabaseUpgradeService.java:118)
> at
> org.apache.fineract.infrastructure.core.service.TenantDatabaseUpgradeService.upgradeAllTenants(TenantDatabaseUpgradeService.java:63)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleElement.invoke(InitDestroyAnnotationBeanPostProcessor.java:389)
> at
> org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleMetadata.invokeInitMethods(InitDestroyAnnotationBeanPostProcessor.java:333)
> at
> org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:157)
> ... 108 common frames omitted{noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FINERACT-1457) Fineract no longer works with MySQL 5.7 due to Flyway v8 upgrade
[
https://issues.apache.org/jira/browse/FINERACT-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466608#comment-17466608
]
Petri Tuomola commented on FINERACT-1457:
-
I'll fix the Kubernetes YAML.
The problem with sticking to Flyway 5.x is that it does not support MariaDB
10.6. So then we would have the problem the other way around: it would not be
possible to use new/up-to-date versions of the database, and everyone would be
forced to use MySQL 5.7 or an equally old version of MariaDB. So we would be
stuck on both out of date version of database as well as Flyway, and no way to
remain up-to-date.
In my view the right solution would be to ask people to upgrade their database
from MySQL 5.7 to MariaDB 10.6 after which the latest version of Fineract
should just work. The upgrade from MySQL to MariaDB should hopefully be an easy
process: [https://mariadb.com/kb/en/upgrading-from-mysql-to-mariadb/]
> Fineract no longer works with MySQL 5.7 due to Flyway v8 upgrade
>
>
> Key: FINERACT-1457
> URL: https://issues.apache.org/jira/browse/FINERACT-1457
> Project: Apache Fineract
> Issue Type: Bug
> Components: Database
>Affects Versions: 1.6.0
>Reporter: Michael Vorburger
>Priority: Critical
> Fix For: 1.6.0
>
>
> https://www.fineract.dev is failing to upgrade to the latest bleeding edge
> Fineract code from master branch, see
> https://github.com/vorburger/www.fineract.dev/issues/8:
> {noformat}
> 2021-12-29 18:54:47.772 ERROR 10 --- [ main]
> o.s.b.web.embedded.tomcat.TomcatStarter : Error starting Tomcat context.
> Exception: org.springframework.beans.factory.UnsatisfiedDependencyException.
> Message: Error creating bean with name 'securityConfig': Unsatisfied
> dependency expressed through field 'userDetailsService'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'userDetailsService': Unsatisfied dependency
> expressed through field 'platformUserRepository'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'appUserRepository' defined in
> org.apache.fineract.useradministration.domain.AppUserRepository defined in
> @EnableJpaRepositories declared on PersistenceConfig: Cannot create inner
> bean '(inner bean)#4ab90d01' of type
> [org.springframework.orm.jpa.SharedEntityManagerCreator] while setting bean
> property 'entityManager'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name '(inner bean)#4ab90d01': Cannot resolve reference to bean
> 'entityManagerFactory' while setting constructor argument; nested exception
> is org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'tenantDatabaseUpgradeService': Invocation of init method
> failed; nested exception is
> org.flywaydb.core.internal.license.FlywayEditionUpgradeRequiredException:
> Flyway Teams Edition or MySQL upgrade required: MySQL 5.7 is no longer
> supported by Flyway Community Edition, but still supported by Flyway Teams
> Edition.
> (...)
> Caused by:
> org.flywaydb.core.internal.license.FlywayEditionUpgradeRequiredException:
> Flyway Teams Edition or MySQL upgrade required: MySQL 5.7 is no longer
> supported by Flyway Community Edition, but still supported by Flyway Teams
> Edition.
> at
> org.flywaydb.core.internal.database.base.Database.ensureDatabaseNotOlderThanOtherwiseRecommendUpgradeToFlywayEdition(Database.java:126)
> at
> org.flywaydb.core.internal.database.mysql.MySQLDatabase.ensureSupported(MySQLDatabase.java:252)
> at org.flywaydb.core.FlywayExecutor.execute(FlywayExecutor.java:188)
> at org.flywaydb.core.Flyway.repair(Flyway.java:335)
> at
> org.apache.fineract.infrastructure.core.service.TenantDatabaseUpgradeService.upgradeTenantDB(TenantDatabaseUpgradeService.java:118)
> at
> org.apache.fineract.infrastructure.core.service.TenantDatabaseUpgradeService.upgradeAllTenants(TenantDatabaseUpgradeService.java:63)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleElement.invoke(InitDestroyAnnotationBeanPostProcessor.java:389)
> at
>
[jira] [Resolved] (FINERACT-1261) support for external Oauth provider
[ https://issues.apache.org/jira/browse/FINERACT-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1261. - Resolution: Fixed > support for external Oauth provider > > > Key: FINERACT-1261 > URL: https://issues.apache.org/jira/browse/FINERACT-1261 > Project: Apache Fineract > Issue Type: Improvement > Components: Security >Affects Versions: 1.4.0 >Reporter: Vincent FUCHS >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > Hi, > > I was looking at the couple of tickets open around OAuth2 support, mostly > https://issues.apache.org/jira/browse/FINERACT-1142 (and its related issues) > and https://issues.apache.org/jira/browse/FINERACT-1012 , and from what I > understand, we currently have no way to configure an external OAuth provider. > Is that correct ? > > A typical Oauth flow is to authenticate against a standard provider, using > the provider login page and get an OAuth token and be redirected, then use > that token in all the requests. The security layer then checks the token > validity for all incoming requests. > > Spring has fairly standard support for this : > [https://spring.io/guides/tutorials/spring-boot-oauth2/] > > Is it something that works but is not documented ? or is it sure that it > doesn't currently work ? > (I would assume that once https://issues.apache.org/jira/browse/FINERACT-1012 > is completed, it will just be a matter of providing the right Spring > properties values) > > Thanks > > -- > Vincent > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FINERACT-1352) OAuth Bad credentials error
[
https://issues.apache.org/jira/browse/FINERACT-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola updated FINERACT-1352:
Fix Version/s: 1.6.0
> OAuth Bad credentials error
> ---
>
> Key: FINERACT-1352
> URL: https://issues.apache.org/jira/browse/FINERACT-1352
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.3.0
>Reporter: David LEVY
>Assignee: Petri Tuomola
>Priority: Major
> Fix For: 1.6.0
>
>
> Hi,
> I am experience different instabilities with Fineract oAuth2
> Some of the code I use is legacy and not documented so I am not 100% sure the
> root cause is Fineract itself, but I didn't find any discussion on it on
> google, so I try here
>
> For all the accounts and all requests I got last week for a few hours this
> generic error message " Bad credentials"
>
> 1634699948 [http-bio-443-exec-7] INFO o.s.s.o.p.endpoint.TokenEndpoint -
> Handling error: InvalidGrantException, Bad credentials
> It seems to be a Spring Security error message, but I can't figure out why.
> The MySQL logs I have show valid results to the queries
> Is there a better way to debug ?
> I thought about adding more verbosity in logs :
>
> {{}}
> {{}}{{}}{{}}
>
> For which package I should override the level ?
> thanks !
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (FINERACT-1143) Add Test Coverage for OAuth Support
[ https://issues.apache.org/jira/browse/FINERACT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1143. - Resolution: Fixed > Add Test Coverage for OAuth Support > --- > > Key: FINERACT-1143 > URL: https://issues.apache.org/jira/browse/FINERACT-1143 > Project: Apache Fineract > Issue Type: Test > Components: Security >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > This project, apparently, has support for OAuth. It, also apparently, is > currently broken. > Once we have documentation about how this works (see FINERACT-xxx), and > somehow looked more into why it's currently broken and how to fix it, we > should ensure future non-regression by adding test coverage for it. > As far as I understand, it won't be possible to simply create another > "normal" integration test for this - because OAuth support is activated by a > build time property (in how it's currently implemented). Therefore, this is > probably more something someone would want to add to > https://github.com/apache/fineract/blob/develop/.travis.yml? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1352) OAuth Bad credentials error
[
https://issues.apache.org/jira/browse/FINERACT-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1352.
-
Resolution: Fixed
> OAuth Bad credentials error
> ---
>
> Key: FINERACT-1352
> URL: https://issues.apache.org/jira/browse/FINERACT-1352
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.3.0
>Reporter: David LEVY
>Assignee: Petri Tuomola
>Priority: Major
>
> Hi,
> I am experience different instabilities with Fineract oAuth2
> Some of the code I use is legacy and not documented so I am not 100% sure the
> root cause is Fineract itself, but I didn't find any discussion on it on
> google, so I try here
>
> For all the accounts and all requests I got last week for a few hours this
> generic error message " Bad credentials"
>
> 1634699948 [http-bio-443-exec-7] INFO o.s.s.o.p.endpoint.TokenEndpoint -
> Handling error: InvalidGrantException, Bad credentials
> It seems to be a Spring Security error message, but I can't figure out why.
> The MySQL logs I have show valid results to the queries
> Is there a better way to debug ?
> I thought about adding more verbosity in logs :
>
> {{}}
> {{}}{{}}{{}}
>
> For which package I should override the level ?
> thanks !
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (FINERACT-1282) Health actuator gives 404 when in oauth mode
[ https://issues.apache.org/jira/browse/FINERACT-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1282. - Resolution: Fixed > Health actuator gives 404 when in oauth mode > > > Key: FINERACT-1282 > URL: https://issues.apache.org/jira/browse/FINERACT-1282 > Project: Apache Fineract > Issue Type: Bug > Components: Security >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > As reported on the Dev mailing list, when you start Fineract in the oauth > mode, the health actuator URL does not work - it returns 404 instead. > This seems to be related to the TenantAwareTenantIdentifiedFilter: > If you look at securityContext, you can see that > TenantAwareTenantIdentifierFilter is only applied in the “oauth” profile. It > doesn’t get used in the basicauth scenario. > > I think there are actually two different issues here: > > 1. TenantAwareTenantIdentifierFilter rejects the request to /actuator/health > because it has no tenant identifier in it. But even if we work around this by > adding a check for the specific path /fineract-provider/actuator/health and > bypassing the check, we hit the next issue > > 2. In oauth profile, Spring does not register DispatcherServlet as it thinks > it has already been registered. So even if the filter is bypassed, you end up > with 404 because there is no DispatcherServlet to route the call to the > Spring Actuator. > > I think the 2nd problem is because one of the filters used for oauth gets > registered as a servlet filter - this seems to be default behaviour of > Spring. See here for example: > > "One last thing: In case you are using a custom authentication filter (e.g. > for token based authentication) you might have to take care that you don't > register your filter as a Servlet Filter as well. You can influence that by > configuring a method returning a FilterRegistrationBean and accepting an > instance of your Filter. just create a new FilterRegistrationBean for your > filter and set enabled to false.” from > [http://blog.florian-hopf.de/2017/08/spring-security.html] > > But oauth / Spring Security is not my area of expertise, so would be great if > someone with more knowledge could comment (and ideally, provide a fix)… > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1012) Spring Security OAuth 2.x to Spring Security 5.2.x
[
https://issues.apache.org/jira/browse/FINERACT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1012.
-
Resolution: Fixed
> Spring Security OAuth 2.x to Spring Security 5.2.x
> --
>
> Key: FINERACT-1012
> URL: https://issues.apache.org/jira/browse/FINERACT-1012
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Critical
> Labels: beginner
> Fix For: 1.6.0
>
>
> The bump of spring-security-oauth2 from 2.3.6.RELEASE to 2.4.1.RELEASE in
> https://github.com/apache/fineract/pull/863 as part of FINERACT-963
> introduced usage of {{@Deprecated}} code, which we are trying to avoid (and
> which since FINERACT-959 we're intentionally making the build fail).
> I'm going to use a {{@SuppressWarnings("deprecation")}} to be able to do the
> upgrade anyway, because upgrading a security related library to its latest
> version seems like a sensible thing to do, but we really should remove the
> suppression and switch to using Spring's newer APIs.
> https://github.com/spring-projects/spring-security/wiki/OAuth-2.0-Migration-Guide
> affects {{UserDetailsApiResource}} and
> {{TwoFactorAuthenticationFilter.createUpdatedAuthentication()}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FINERACT-1453) Renovatebot does not seem to be working anymore
[ https://issues.apache.org/jira/browse/FINERACT-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465581#comment-17465581 ] Petri Tuomola commented on FINERACT-1453: - [~vorburger] would you know how to start debugging this? I don't think I have the correct rights to view the dashboard or repository logs for RenovateBot on their site - at least I can't see anything when I try. If I recall correctly, you worked with them to set this up. Would you be able to check what's wrong or grant me the required rights to view this? > Renovatebot does not seem to be working anymore > --- > > Key: FINERACT-1453 > URL: https://issues.apache.org/jira/browse/FINERACT-1453 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Priority: Major > > We haven't had any pull requests from RenovateBot since early November, and > in the mean time there are definitely new versions of many of the libraries. > Perhaps something has changed in the config that has stopped this from > working? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FINERACT-1453) Renovatebot does not seem to be working anymore
Petri Tuomola created FINERACT-1453: --- Summary: Renovatebot does not seem to be working anymore Key: FINERACT-1453 URL: https://issues.apache.org/jira/browse/FINERACT-1453 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola We haven't had any pull requests from RenovateBot since early November, and in the mean time there are definitely new versions of many of the libraries. Perhaps something has changed in the config that has stopped this from working? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1033) Fineract OAuth Token Change Bug
[ https://issues.apache.org/jira/browse/FINERACT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17465508#comment-17465508 ] Petri Tuomola commented on FINERACT-1033: - Spring Security 5.6 separates the authentication server from the resource server. Going forward, Fineract will act as the resource server and any 3rd party authentication server can be used to issue tokens. As Fineract will no longer be issuing access tokens, the described issue will no longer happen. > Fineract OAuth Token Change Bug > --- > > Key: FINERACT-1033 > URL: https://issues.apache.org/jira/browse/FINERACT-1033 > Project: Apache Fineract > Issue Type: Bug > Components: Security >Reporter: Saransh Sharma >Priority: Major > > Fineract OAuth previously sent UUID values limited to 0-9, a-f, and dash for > tokens. It recently changed to using a base-64 encoded value for tokens. This > seems to work fine in many cases. > Previous token example: > "access_token": "a6c25cb8-7e73-446e-a49b-e9e54c3f26ee" > Current token example: > "access_token": "2VaGUd8Y25fCC1gBpGLZnfoC52s=" > However, if the base-64 encoded value contains a + (plus sign) authentication > fails. Fineract generates and sends the value to the community app with the + > in the token value. The community app returns the token value with the + > included. Fineract looks up the value in the database but replaces the + with > a space before doing so. > In the example attached, Fineract provides an access token of > 4JdlsEQzpa3gsM7CbH5mFxTy+FU= > The community app uses the full token value with the + to request access. > Fineract responds denying access with this message: Invalid access token: > 4JdlsEQzpa3gsM7CbH5mFxTy FU= > > Please review the attached file for detailed information and logs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FINERACT-1282) Health actuator gives 404 when in oauth mode
[ https://issues.apache.org/jira/browse/FINERACT-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1282: Fix Version/s: 1.6.0 > Health actuator gives 404 when in oauth mode > > > Key: FINERACT-1282 > URL: https://issues.apache.org/jira/browse/FINERACT-1282 > Project: Apache Fineract > Issue Type: Bug > Components: Security >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > As reported on the Dev mailing list, when you start Fineract in the oauth > mode, the health actuator URL does not work - it returns 404 instead. > This seems to be related to the TenantAwareTenantIdentifiedFilter: > If you look at securityContext, you can see that > TenantAwareTenantIdentifierFilter is only applied in the “oauth” profile. It > doesn’t get used in the basicauth scenario. > > I think there are actually two different issues here: > > 1. TenantAwareTenantIdentifierFilter rejects the request to /actuator/health > because it has no tenant identifier in it. But even if we work around this by > adding a check for the specific path /fineract-provider/actuator/health and > bypassing the check, we hit the next issue > > 2. In oauth profile, Spring does not register DispatcherServlet as it thinks > it has already been registered. So even if the filter is bypassed, you end up > with 404 because there is no DispatcherServlet to route the call to the > Spring Actuator. > > I think the 2nd problem is because one of the filters used for oauth gets > registered as a servlet filter - this seems to be default behaviour of > Spring. See here for example: > > "One last thing: In case you are using a custom authentication filter (e.g. > for token based authentication) you might have to take care that you don't > register your filter as a Servlet Filter as well. You can influence that by > configuring a method returning a FilterRegistrationBean and accepting an > instance of your Filter. just create a new FilterRegistrationBean for your > filter and set enabled to false.” from > [http://blog.florian-hopf.de/2017/08/spring-security.html] > > But oauth / Spring Security is not my area of expertise, so would be great if > someone with more knowledge could comment (and ideally, provide a fix)… > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-982) Completely ditch use of Drizzle JDBC Driver after all
[ https://issues.apache.org/jira/browse/FINERACT-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-982. Resolution: Fixed > Completely ditch use of Drizzle JDBC Driver after all > - > > Key: FINERACT-982 > URL: https://issues.apache.org/jira/browse/FINERACT-982 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Blocker > Labels: scalability > Fix For: 1.6.0 > > > Fineract's use of the un-maintained Drizzle JDBC driver continues to cause > confusion and pains like FINERACT-980, and note e.g. the proposed removal of > the alternative MySQL JDBC driver in > [https://github.com/apache/fineract/pull/887.] > Some of the background to this is recorded e.g. in FINCN-26, FINERACT-761 and > LEGAL-462. > LEGAL-462 has clarified that the Fineract ZIP distribution must include > Drizzle and cannot distribute the MariaDB or MySQL JDBC clients. We CAN, and > currently (given the confusion in FINERACT-980 apparently do?!) use it for > tests. > What if to reduce variability we just removed that old Drizzle JDBC driver > after all? We could run our tests using (preferably) the very well maintained > MariaDB JDBC driver client (the actual DB server is a totally separate > discussion, see FINERACT-896). We would (have to) distribute the ZIP for > download without a JDBC driver, and just some documentation inviting users to > DL and add one. > But the exact situation about distributing in a Docker container image isn't > clear, to me... > FYI [~awasum], [~ptuomola], [~xurror] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FINERACT-1452) Flag to disable changing of password of an account
Petri Tuomola created FINERACT-1452: --- Summary: Flag to disable changing of password of an account Key: FINERACT-1452 URL: https://issues.apache.org/jira/browse/FINERACT-1452 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola Assignee: Petri Tuomola Fix For: 1.6.0 On fineract.dev, people keep changing the password of the mifos account and hence making the demo server unusable. We need to implement a simple flag that, when set, makes it impossible to change a particular user's password. This should of course used only for training / demo instances, not in real world use. Also this flag can only be set directly in the database: making it editable through API / user interface would make the whole flag meaningless. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-980) bootRun broken due to FlywayDbUpgradeRequiredException: MySQL upgrade required: MySQL 0.1 is outdated and no longer supported by Flyway. Flyway currently supports MySQ
[
https://issues.apache.org/jira/browse/FINERACT-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-980.
Fix Version/s: 1.6.0
Resolution: Fixed
This should no longer be an issue as we've ditched Drizzle and are using a
MariaDB version supported by Flyway
> bootRun broken due to FlywayDbUpgradeRequiredException: MySQL upgrade
> required: MySQL 0.1 is outdated and no longer supported by Flyway. Flyway
> currently supports MySQL 5.1 and newer.
> ---
>
> Key: FINERACT-980
> URL: https://issues.apache.org/jira/browse/FINERACT-980
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Blocker
> Fix For: 1.6.0
>
>
> I'just pulled the latest develop and upon running {{./gradlew bootRun}} hit
> this:
> {noformat}10:46:06.914 [main] INFO
> o.s.b.a.l.ConditionEvaluationReportLoggingListener -
> Error starting ApplicationContext. To display the conditions report re-run
> your application with 'debug' enabled.
> 10:46:06.919 [main] ERROR o.s.boot.SpringApplication - Application run failed
> org.springframework.context.ApplicationContextException: Unable to start web
> server; nested exception is
> org.springframework.boot.web.server.WebServerException: Unable to start
> embedded Tomcat
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:156)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:544)
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141)
> at
> org.springframework.boot.SpringApplication.refresh(SpringApplication.java:747)
> at
> org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397)
> at
> org.springframework.boot.SpringApplication.run(SpringApplication.java:315)
> at
> org.springframework.boot.builder.SpringApplicationBuilder.run(SpringApplicationBuilder.java:140)
> at
> org.apache.fineract.ServerApplication.main(ServerApplication.java:63)
> Caused by: org.springframework.boot.web.server.WebServerException: Unable to
> start embedded Tomcat
> at
> org.springframework.boot.web.embedded.tomcat.TomcatWebServer.initialize(TomcatWebServer.java:125)
> at
> org.springframework.boot.web.embedded.tomcat.TomcatWebServer.(TomcatWebServer.java:87)
> at
> org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getTomcatWebServer(TomcatServletWebServerFactory.java:437)
> at
> org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getWebServer(TomcatServletWebServerFactory.java:191)
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:180)
> at
> org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:153)
> ... 7 common frames omitted
> Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException:
> Error creating bean with name
> 'org.apache.fineract.infrastructure.core.boot.WebXmlConfiguration':
> Unsatisfied dependency expressed through field
> 'basicAuthenticationProcessingFilter'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'basicAuthenticationProcessingFilter' defined in file
> [/home/vorburger/Mifos/fineract/build/classes/java/main/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'org.springframework.security.authenticationManager':
> Cannot resolve reference to bean 'customAuthenticationProvider' while setting
> constructor argument with key [0]; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'customAuthenticationProvider' defined in URL
> [file:/home/vorburger/Mifos/fineract/build/classes/java/main/META-INF/spring/securityContext.xml]:
> Cannot resolve reference to bean 'userDetailsService' while setting bean
> property 'userDetailsService'; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating
[jira] [Resolved] (FINERACT-896) User MariaDB instead of / in addition to MySQL
[ https://issues.apache.org/jira/browse/FINERACT-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-896. Fix Version/s: 1.6.0 Assignee: Petri Tuomola Resolution: Fixed We are now using MariaDB, but MySQL also continues to work > User MariaDB instead of / in addition to MySQL > -- > > Key: FINERACT-896 > URL: https://issues.apache.org/jira/browse/FINERACT-896 > Project: Apache Fineract > Issue Type: New Feature > Components: Database >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > I think it would nice if Fineract support MariaDB (see > [https://mariadb.org)|https://mariadb.org)/] instead of, or in addition to > and not only MySQL. > MariaDB is a community fork of MySQL (now maintained mostly by Oracle) by > most of the people who originally built MySQL before it was acquired by > Oracle. > Hopefully our use of the (very old...) Drizzle JDBC driver doesn't cause any > issues for this. Otherwise we could use FINERACT-762, or (better) > https://downloads.mariadb.org/connector-java/+releases/. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1143) Add Test Coverage for OAuth Support
[ https://issues.apache.org/jira/browse/FINERACT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1143: --- Assignee: Petri Tuomola > Add Test Coverage for OAuth Support > --- > > Key: FINERACT-1143 > URL: https://issues.apache.org/jira/browse/FINERACT-1143 > Project: Apache Fineract > Issue Type: Test > Components: Security >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > This project, apparently, has support for OAuth. It, also apparently, is > currently broken. > Once we have documentation about how this works (see FINERACT-xxx), and > somehow looked more into why it's currently broken and how to fix it, we > should ensure future non-regression by adding test coverage for it. > As far as I understand, it won't be possible to simply create another > "normal" integration test for this - because OAuth support is activated by a > build time property (in how it's currently implemented). Therefore, this is > probably more something someone would want to add to > https://github.com/apache/fineract/blob/develop/.travis.yml? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1335) Integration Test Email Sending features
[ https://issues.apache.org/jira/browse/FINERACT-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1335. - Resolution: Fixed The twofactor authentication is now being tested in the integration test > Integration Test Email Sending features > --- > > Key: FINERACT-1335 > URL: https://issues.apache.org/jira/browse/FINERACT-1335 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > Finearact has a number of features which send emails. > They are currently not tested - the goal here would be to add integration > test coverage for those feature. > https://greenmail-mail-test.github.io/greenmail/ to me seems like a great > tool to do this! > FINERACT-1070 and FINERACT-1270 have some context. > [~BLasan] [~francisguchie] [~ptuomola] interested in taking this? ;) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FINERACT-1438) mifos web-app demo credentials are invalid
[
https://issues.apache.org/jira/browse/FINERACT-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17464913#comment-17464913
]
Petri Tuomola commented on FINERACT-1438:
-
Hi - unfortunately someone has changed the credentials on fineract.dev. We'll
need to implement a feature to stop people changing the password.
> mifos web-app demo credentials are invalid
> --
>
> Key: FINERACT-1438
> URL: https://issues.apache.org/jira/browse/FINERACT-1438
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Ismael OUEDRAOGO
>Priority: Minor
>
> When I load the web app at this URL: https://openmf.github.io/web-app/
> I get this errror: "Http failure response for
> https://openmf.github.io/assets/translations/en-US.json: 404 OK"
> and the proposed credentials(mifos/password) from fineract.dev are not
> working:
> ??Open the [Community App
> UI|https://openmf.github.io/community-app?baseApiUrl=https://demo.fineract.dev=default]
> (older, but more complete; see
> [github.com/openMF/community-app|https://github.com/openMF/community-app]) or
> [the Web App UI|https://openmf.github.io/web-app/] (newer, see
> [github.com/openMF/web-app|https://github.com/openMF/web-app/]) and login
> with e.g. *{_}mifos/password{_}.*??
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (FINERACT-1432) Drop down on Client Documents
[ https://issues.apache.org/jira/browse/FINERACT-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1432: Fix Version/s: 1.6.0 > Drop down on Client Documents > - > > Key: FINERACT-1432 > URL: https://issues.apache.org/jira/browse/FINERACT-1432 > Project: Apache Fineract > Issue Type: New Feature >Reporter: Francis Guchie >Assignee: Rahul Pawar >Priority: Major > Fix For: 1.6.0 > > Attachments: 1432-ClientDropdown.jpeg, CustomerDoc_CodeValue.PNG > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1419) Add fineract-ui to K8S deployment
[ https://issues.apache.org/jira/browse/FINERACT-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1419. - Resolution: Fixed > Add fineract-ui to K8S deployment > - > > Key: FINERACT-1419 > URL: https://issues.apache.org/jira/browse/FINERACT-1419 > Project: Apache Fineract > Issue Type: Task >Reporter: Ohad Z >Assignee: Victor Romero >Priority: Major > Fix For: 1.6.0 > > > I'm trying to run Fineract on K8S cluster but UI yaml is missing > Please add to the following link UI deployment: > [https://github.com/apache/fineract/tree/develop/kubernetes] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1419) Add fineract-ui to K8S deployment
[ https://issues.apache.org/jira/browse/FINERACT-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1419: --- Fix Version/s: 1.6.0 Assignee: Victor Romero > Add fineract-ui to K8S deployment > - > > Key: FINERACT-1419 > URL: https://issues.apache.org/jira/browse/FINERACT-1419 > Project: Apache Fineract > Issue Type: Task >Reporter: Ohad Z >Assignee: Victor Romero >Priority: Major > Fix For: 1.6.0 > > > I'm trying to run Fineract on K8S cluster but UI yaml is missing > Please add to the following link UI deployment: > [https://github.com/apache/fineract/tree/develop/kubernetes] > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FINERACT-1391) Customizable Account Number Preferences
[ https://issues.apache.org/jira/browse/FINERACT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1391: Fix Version/s: 1.6.0 Affects Version/s: (was: 1.0.0) (was: 1.1.0) (was: 1.2.0) (was: 1.3.0) (was: 1.4.0) (was: 1.5.0) > Customizable Account Number Preferences > --- > > Key: FINERACT-1391 > URL: https://issues.apache.org/jira/browse/FINERACT-1391 > Project: Apache Fineract > Issue Type: Improvement > Components: Savings >Reporter: Francis Guchie >Assignee: Rahul Pawar >Priority: Major > Fix For: 1.6.0 > > Attachments: image-2021-08-26-20-20-24-111.png, > image-2021-08-26-20-23-36-531.png > > > As a user i would like to set an account prefix that is neither > SAVINGS_PRODUCT_SHORT_NAME > nor OFFICE_NAME, These 2 are limited to the fact the short name can not be > the same. > Secondly, this prefix, I would like it to be a part of the number of digits > that make the account number not an addition to the existing length of the > account number length > Image one the Setting of the preference should be like below > !image-2021-08-26-20-20-24-111.png! > > And after this is set i want to see something like this below > !image-2021-08-26-20-23-36-531.png! > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1423) http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / DELETE)
[ https://issues.apache.org/jira/browse/FINERACT-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1423. - Resolution: Won't Fix I think this works as expected. If you go for a http request, it forwards you to https. However forward is only a HTTP GET, so therefore whatever method you called, it gets translated to GET. The only options we would have is: * Disable HTTP altogether (i.e. don't even do a forward) * Allow HTTP for all verbs But I don't think either of those would be much better than what we have today. > http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / > DELETE) > > > Key: FINERACT-1423 > URL: https://issues.apache.org/jira/browse/FINERACT-1423 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > If you access any API using method POST / PUT / DELETE but with http (not > HTTPS), Fineract responds as if you had done a GET. > So PUT /fineract-provider/api/v1/offices/2 is actually actioned as GET > /fineract-provider/api/v1/offices/2 when done with http > If you change to https, everything works well. > This means that HTTP endpoint is pretty much dead for all practical purposes. > To avoid confusion, my suggestion would be that we disable this and just > reject any call to HTTP, rather than responding with the incorrect response. > HTTP is anyway insecure and should not be used. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1159) Broken links on download page for older releases
[ https://issues.apache.org/jira/browse/FINERACT-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1159. - Resolution: Fixed Updated links on the web site > Broken links on download page for older releases > > > Key: FINERACT-1159 > URL: https://issues.apache.org/jira/browse/FINERACT-1159 > Project: Apache Fineract > Issue Type: Bug >Reporter: Sebb >Assignee: Petri Tuomola >Priority: Major > > The links for releases 1.2.0 and earlier are all broken. > Please either remove or fix them to point to the archive server. > Also release 1.0.0 has .sha hashes but the link texts say 'sha512'. > Assuming these are fixed to point to the archive server they needs to be fixed -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1013) Validation of boolean input values not working
[ https://issues.apache.org/jira/browse/FINERACT-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1013: --- Assignee: (was: Petri Tuomola) > Validation of boolean input values not working > -- > > Key: FINERACT-1013 > URL: https://issues.apache.org/jira/browse/FINERACT-1013 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Priority: Major > > There's a method validateForBooleanValue which is used in a lot of places to > check that an input is a valid boolean. > The problem is that, in all the cases where it is used, the value to be > checked is retrieved from the input JSON with extractBooleanNamed() - which > always returns a valid boolean value, even if the string provided is not a > valid boolean. > So the validation code should be changed to retrieve the boolean inputs as > Strings, and then using trueOrFalseRequired() validator to confirm that the > String is a valid boolean value. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1261) support for external Oauth provider
[ https://issues.apache.org/jira/browse/FINERACT-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1261: --- Assignee: Petri Tuomola (was: Aleksandar Vidakovic) > support for external Oauth provider > > > Key: FINERACT-1261 > URL: https://issues.apache.org/jira/browse/FINERACT-1261 > Project: Apache Fineract > Issue Type: Improvement > Components: Security >Affects Versions: 1.4.0 >Reporter: Vincent FUCHS >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > Hi, > > I was looking at the couple of tickets open around OAuth2 support, mostly > https://issues.apache.org/jira/browse/FINERACT-1142 (and its related issues) > and https://issues.apache.org/jira/browse/FINERACT-1012 , and from what I > understand, we currently have no way to configure an external OAuth provider. > Is that correct ? > > A typical Oauth flow is to authenticate against a standard provider, using > the provider login page and get an OAuth token and be redirected, then use > that token in all the requests. The security layer then checks the token > validity for all incoming requests. > > Spring has fairly standard support for this : > [https://spring.io/guides/tutorials/spring-boot-oauth2/] > > Is it something that works but is not documented ? or is it sure that it > doesn't currently work ? > (I would assume that once https://issues.apache.org/jira/browse/FINERACT-1012 > is completed, it will just be a matter of providing the right Spring > properties values) > > Thanks > > -- > Vincent > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1423) http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / DELETE)
[ https://issues.apache.org/jira/browse/FINERACT-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1423: --- Assignee: Petri Tuomola > http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / > DELETE) > > > Key: FINERACT-1423 > URL: https://issues.apache.org/jira/browse/FINERACT-1423 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > If you access any API using method POST / PUT / DELETE but with http (not > HTTPS), Fineract responds as if you had done a GET. > So PUT /fineract-provider/api/v1/offices/2 is actually actioned as GET > /fineract-provider/api/v1/offices/2 when done with http > If you change to https, everything works well. > This means that HTTP endpoint is pretty much dead for all practical purposes. > To avoid confusion, my suggestion would be that we disable this and just > reject any call to HTTP, rather than responding with the incorrect response. > HTTP is anyway insecure and should not be used. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-921) Upgrade Jersey library from 1.x to 2.30.1 or later
[ https://issues.apache.org/jira/browse/FINERACT-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-921. Fix Version/s: 1.6.0 Resolution: Fixed > Upgrade Jersey library from 1.x to 2.30.1 or later > -- > > Key: FINERACT-921 > URL: https://issues.apache.org/jira/browse/FINERACT-921 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > https://eclipse-ee4j.github.io/jersey/ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-921) Upgrade Jersey library from 1.x to 2.30.1 or later
[ https://issues.apache.org/jira/browse/FINERACT-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-921: -- Assignee: Petri Tuomola > Upgrade Jersey library from 1.x to 2.30.1 or later > -- > > Key: FINERACT-921 > URL: https://issues.apache.org/jira/browse/FINERACT-921 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Petri Tuomola >Priority: Major > > https://eclipse-ee4j.github.io/jersey/ -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-1012) Spring Security OAuth 2.x to Spring Security 5.2.x
[
https://issues.apache.org/jira/browse/FINERACT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-1012:
---
Assignee: Petri Tuomola (was: Benura Abeywardena)
> Spring Security OAuth 2.x to Spring Security 5.2.x
> --
>
> Key: FINERACT-1012
> URL: https://issues.apache.org/jira/browse/FINERACT-1012
> Project: Apache Fineract
> Issue Type: Bug
> Components: Security
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Critical
> Labels: beginner
> Fix For: 1.6.0
>
>
> The bump of spring-security-oauth2 from 2.3.6.RELEASE to 2.4.1.RELEASE in
> https://github.com/apache/fineract/pull/863 as part of FINERACT-963
> introduced usage of {{@Deprecated}} code, which we are trying to avoid (and
> which since FINERACT-959 we're intentionally making the build fail).
> I'm going to use a {{@SuppressWarnings("deprecation")}} to be able to do the
> upgrade anyway, because upgrading a security related library to its latest
> version seems like a sensible thing to do, but we really should remove the
> suppression and switch to using Spring's newer APIs.
> https://github.com/spring-projects/spring-security/wiki/OAuth-2.0-Migration-Guide
> affects {{UserDetailsApiResource}} and
> {{TwoFactorAuthenticationFilter.createUpdatedAuthentication()}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (FINERACT-1089) Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in InterestRateChartReadPlatformServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-1089:
---
Assignee: Petri Tuomola (was: Benura Abeywardena)
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY in
> InterestRateChartReadPlatformServiceImpl
> --
>
> Key: FINERACT-1089
> URL: https://issues.apache.org/jira/browse/FINERACT-1089
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
> Fix For: 1.6.0
>
>
> See FINERACT-932 for general background; I've found this in logs of
> https://www.fineract.dev, this seems to be a similar problem to that was
> previously fixed in FINERACT-995 and FINERACT-1061:
> {noformat}
> org.springframework.dao.TransientDataAccessResourceException:
> PreparedStatementCallback; SQL [select irc.id as ircId, irc.name as ircName,
> irc.description as ircDescription,irc.from_date as ircFromDate, irc.end_date
> as ircEndDate, irc.is_primary_grouping_by_amount as
> isPrimaryGroupingByAmount, ircd.id as ircdId, ircd.description as
> ircdDescription, ircd.period_type_enum ircdPeriodTypeId, ircd.from_period as
> ircdFromPeriod, ircd.to_period as ircdToPeriod, ircd.amount_range_from as
> ircdAmountRangeFrom, ircd.amount_range_to as ircdAmountRangeTo,
> ircd.annual_interest_rate as ircdAnnualInterestRate, curr.code as
> currencyCode, curr.name as currencyName, curr.internationalized_name_code as
> currencyNameCode, curr.display_symbol as currencyDisplaySymbol,
> curr.decimal_places as currencyDigits, curr.currency_multiplesof as
> inMultiplesOf, sp.id as savingsProductId, sp.name as savingsProductName,
> iri.id as iriId, iri.entiry_type as entityType, iri.attribute_name as
> attributeName , iri.condition_type as conditionType, iri.attribute_value as
> attributeValue, iri.incentive_type as incentiveType, iri.amount as amount,
> code.code_value as attributeValueDesc from m_interest_rate_chart irc left
> join m_interest_rate_slab ircd on irc.id=ircd.interest_rate_chart_id left
> join m_interest_incentives iri on iri.interest_rate_slab_id = ircd.id left
> join m_code_value code on code.id = iri.attribute_value left join m_currency
> curr on ircd.currency_code= curr.code left join
> m_deposit_product_interest_rate_chart dpirc on
> irc.id=dpirc.interest_rate_chart_id left join m_savings_product sp on
> sp.id=dpirc.deposit_product_id where sp.id = ? order by irc.id, CASE WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_from WHEN
> isPrimaryGroupingByAmount then ircd.amount_range_to END,ircd.from_period,
> ircd.to_period,CASE WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_from WHEN !isPrimaryGroupingByAmount then
> ircd.amount_range_to END]; Operation not allowed for a result set of type
> ResultSet.TYPE_FORWARD_ONLY.; nested exception is java.sql.SQLException:
> Operation not allowed for a result set of type ResultSet.TYPE_FORWARD_ONLY.
> at
> org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate
> (SQLStateSQLExceptionTranslator.java:110)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:72)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at
> org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate
> (AbstractFallbackSQLExceptionTranslator.java:81)
> at org.springframework.jdbc.core.JdbcTemplate.translateException
> (JdbcTemplate.java:1443)
> at org.springframework.jdbc.core.JdbcTemplate.execute
> (JdbcTemplate.java:633)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:669)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:700)
> at org.springframework.jdbc.core.JdbcTemplate.query
> (JdbcTemplate.java:718)
> at
> org.apache.fineract.portfolio.interestratechart.service.InterestRateChartReadPlatformServiceImpl.retrieveAllWithSlabs
> (InterestRateChartReadPlatformServiceImpl.java:102)
> Caused by: java.sql.SQLException: Operation not allowed for a result set of
> type ResultSet.TYPE_FORWARD_ONLY.
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:129)
> at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException
> (SQLError.java:97)
> at
> com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException
> (SQLExceptionsMapping.java:122)
> at com.mysql.cj.jdbc.result.ResultSetImpl.previous
>
[jira] [Assigned] (FINERACT-1282) Health actuator gives 404 when in oauth mode
[ https://issues.apache.org/jira/browse/FINERACT-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1282: --- Assignee: Petri Tuomola > Health actuator gives 404 when in oauth mode > > > Key: FINERACT-1282 > URL: https://issues.apache.org/jira/browse/FINERACT-1282 > Project: Apache Fineract > Issue Type: Bug > Components: Security >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > As reported on the Dev mailing list, when you start Fineract in the oauth > mode, the health actuator URL does not work - it returns 404 instead. > This seems to be related to the TenantAwareTenantIdentifiedFilter: > If you look at securityContext, you can see that > TenantAwareTenantIdentifierFilter is only applied in the “oauth” profile. It > doesn’t get used in the basicauth scenario. > > I think there are actually two different issues here: > > 1. TenantAwareTenantIdentifierFilter rejects the request to /actuator/health > because it has no tenant identifier in it. But even if we work around this by > adding a check for the specific path /fineract-provider/actuator/health and > bypassing the check, we hit the next issue > > 2. In oauth profile, Spring does not register DispatcherServlet as it thinks > it has already been registered. So even if the filter is bypassed, you end up > with 404 because there is no DispatcherServlet to route the call to the > Spring Actuator. > > I think the 2nd problem is because one of the filters used for oauth gets > registered as a servlet filter - this seems to be default behaviour of > Spring. See here for example: > > "One last thing: In case you are using a custom authentication filter (e.g. > for token based authentication) you might have to take care that you don't > register your filter as a Servlet Filter as well. You can influence that by > configuring a method returning a FilterRegistrationBean and accepting an > instance of your Filter. just create a new FilterRegistrationBean for your > filter and set enabled to false.” from > [http://blog.florian-hopf.de/2017/08/spring-security.html] > > But oauth / Spring Security is not my area of expertise, so would be great if > someone with more knowledge could comment (and ideally, provide a fix)… > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FINERACT-890) Custom slf4j integrated logger for the (optional!) MySQL JDBC driver support in Fineract
[
https://issues.apache.org/jira/browse/FINERACT-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-890:
--
Assignee: Petri Tuomola
> Custom slf4j integrated logger for the (optional!) MySQL JDBC driver support
> in Fineract
>
>
> Key: FINERACT-890
> URL: https://issues.apache.org/jira/browse/FINERACT-890
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Major
> Labels: scalability, technical
>
> While working on FINERACT-762, I've stumbled upon:
> {code}Caused by:
> com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to
> initialize pool: Unable to load class for logger
> 'com.mysql.jdbc.log.StandardLogger'
> at
> com.zaxxer.hikari.pool.HikariPool.throwPoolInitializationException(HikariPool.java:589)
> at com.zaxxer.hikari.pool.HikariPool.checkFailFast(HikariPool.java:575)
> at com.zaxxer.hikari.pool.HikariPool.(HikariPool.java:115)
> at com.zaxxer.hikari.HikariDataSource.(HikariDataSource.java:81)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:203)
> ... 161 more
> Caused by: java.sql.SQLException: Unable to load class for logger
> 'com.mysql.jdbc.log.StandardLogger'
> at
> com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
> at
> com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
> at
> com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
> at
> com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
> at
> com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
> at
> com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:85)
> at com.mysql.cj.jdbc.ConnectionImpl.(ConnectionImpl.java:452)
> at com.mysql.cj.jdbc.ConnectionImpl.getInstance(ConnectionImpl.java:246)
> at
> com.mysql.cj.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:197)
> at
> com.zaxxer.hikari.util.DriverDataSource.getConnection(DriverDataSource.java:138)
> at com.zaxxer.hikari.pool.PoolBase.newConnection(PoolBase.java:354)
> at com.zaxxer.hikari.pool.PoolBase.newPoolEntry(PoolBase.java:202)
> at
> com.zaxxer.hikari.pool.HikariPool.createPoolEntry(HikariPool.java:473)
> at com.zaxxer.hikari.pool.HikariPool.checkFailFast(HikariPool.java:554)
> ... 168 more
> Caused by: com.mysql.cj.exceptions.WrongArgumentException: Unable to load
> class for logger 'com.mysql.jdbc.log.StandardLogger'
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:61)
> at
> com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:105)
> at com.mysql.cj.log.LogFactory.getLogger(LogFactory.java:77)
> at com.mysql.cj.CoreSession.(CoreSession.java:95)
> at com.mysql.cj.NativeSession.(NativeSession.java:131)
> at com.mysql.cj.jdbc.ConnectionImpl.(ConnectionImpl.java:402)
> ... 175 more
> Caused by: java.lang.ClassNotFoundException:
> com.mysql.cj.log.com.mysql.jdbc.log.StandardLogger
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at com.mysql.cj.log.LogFactory.getLogger(LogFactory.java:70)
> ... 178 more{code}
> This seems to be due to us setting the Hikari DataSource logger property to
> com.mysql.jdbc.log.StandardLogger, in both
> org.apache.fineract.infrastructure.core.service.TomcatJdbcDataSourcePerTenantService
> and META-INF/spring/hikariDataSource.xml.
> That classname seems to be wrong (outdated?), at least for the latest
> mysql-connector-java version
[jira] [Assigned] (FINERACT-1159) Broken links on download page for older releases
[ https://issues.apache.org/jira/browse/FINERACT-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1159: --- Assignee: Petri Tuomola > Broken links on download page for older releases > > > Key: FINERACT-1159 > URL: https://issues.apache.org/jira/browse/FINERACT-1159 > Project: Apache Fineract > Issue Type: Bug >Reporter: Sebb >Assignee: Petri Tuomola >Priority: Major > > The links for releases 1.2.0 and earlier are all broken. > Please either remove or fix them to point to the archive server. > Also release 1.0.0 has .sha hashes but the link texts say 'sha512'. > Assuming these are fixed to point to the archive server they needs to be fixed -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1408) Add a unix shell to the Fineract Docker image
[
https://issues.apache.org/jira/browse/FINERACT-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1408.
-
Fix Version/s: 1.6.0
Resolution: Fixed
> Add a unix shell to the Fineract Docker image
> -
>
> Key: FINERACT-1408
> URL: https://issues.apache.org/jira/browse/FINERACT-1408
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Kristof Jozsa
>Priority: Minor
> Fix For: 1.6.0
>
>
> The current fineract Dockerfile uses {{gcr.io/distroless/java:11}} as the
> base image, which does not seem to have {{bash}} or any other usable shell.
> Having no shell makes it really hard to debug anything _inside_ the docker
> image - eg. I'm putting together a Kubernetes configuration with Configmap
> exporting environment variables, and it's about impossible to see what's
> going on inside the container without a shell.
> Please consider adding a shell, or using a docker base image which has one
> already (eg. the official {{openjdk:11}} image could work just fine).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (FINERACT-1435) Jersey 2 upgrade works with bootRun and Tomcat, but not for bootJar
[ https://issues.apache.org/jira/browse/FINERACT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola closed FINERACT-1435. --- Fix Version/s: 1.6.0 Resolution: Fixed > Jersey 2 upgrade works with bootRun and Tomcat, but not for bootJar > --- > > Key: FINERACT-1435 > URL: https://issues.apache.org/jira/browse/FINERACT-1435 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > After upgrade to Jersey 2, running Fineract works through ./gradlew bootRun > or by deploying it to embedded Tomcat. > However ./gradlew bootJar and running the resulting JAR file does not work - > this is because of an issue with Jersey 2 classloader, which cannot find the > resource classes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FINERACT-1433) Simplify Fineract Spring Boot configuration
[ https://issues.apache.org/jira/browse/FINERACT-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1433. - Fix Version/s: 1.6.0 Resolution: Fixed > Simplify Fineract Spring Boot configuration > --- > > Key: FINERACT-1433 > URL: https://issues.apache.org/jira/browse/FINERACT-1433 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > As discussed on the dev mailing list, there's an opportunity to simplify the > Fineract Spring Boot configuration by e.g. getting rid of some of the XML > files and replacing them with programmatic configuration, or relying on the > defaults. Similarly we can avoid managing multiple copies of the same > property files and instead use templating to populate the changed values. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FINERACT-1435) Jersey 2 upgrade works with bootRun and Tomcat, but not for bootJar
[ https://issues.apache.org/jira/browse/FINERACT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1435: Description: After upgrade to Jersey 2, running Fineract works through ./gradlew bootRun or by deploying it to embedded Tomcat. However ./gradlew bootJar and running the resulting JAR file does not work - this is because of an issue with Jersey 2 classloader, which cannot find the resource classes. > Jersey 2 upgrade works with bootRun and Tomcat, but not for bootJar > --- > > Key: FINERACT-1435 > URL: https://issues.apache.org/jira/browse/FINERACT-1435 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > After upgrade to Jersey 2, running Fineract works through ./gradlew bootRun > or by deploying it to embedded Tomcat. > However ./gradlew bootJar and running the resulting JAR file does not work - > this is because of an issue with Jersey 2 classloader, which cannot find the > resource classes. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FINERACT-1435) Jersey 2 upgrade works with bootRun and Tomcat, but not for bootJar
Petri Tuomola created FINERACT-1435: --- Summary: Jersey 2 upgrade works with bootRun and Tomcat, but not for bootJar Key: FINERACT-1435 URL: https://issues.apache.org/jira/browse/FINERACT-1435 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola Assignee: Petri Tuomola -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FINERACT-1434) Convert integration tests to be using the generated client
Petri Tuomola created FINERACT-1434: --- Summary: Convert integration tests to be using the generated client Key: FINERACT-1434 URL: https://issues.apache.org/jira/browse/FINERACT-1434 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola As discussed on the dev mailing list, we should convert all the integration tests to be using the generated client code rather than using RESTassured libraries - that way they will test the generated client, ensure the correctness of the interface, and also should be easier to write. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1433) Simplify Fineract Spring Boot configuration
Petri Tuomola created FINERACT-1433: --- Summary: Simplify Fineract Spring Boot configuration Key: FINERACT-1433 URL: https://issues.apache.org/jira/browse/FINERACT-1433 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola Assignee: Petri Tuomola As discussed on the dev mailing list, there's an opportunity to simplify the Fineract Spring Boot configuration by e.g. getting rid of some of the XML files and replacing them with programmatic configuration, or relying on the defaults. Similarly we can avoid managing multiple copies of the same property files and instead use templating to populate the changed values. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1421) Eclipse build / debug no longer works
[ https://issues.apache.org/jira/browse/FINERACT-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1421. - Resolution: Fixed > Eclipse build / debug no longer works > - > > Key: FINERACT-1421 > URL: https://issues.apache.org/jira/browse/FINERACT-1421 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > As highlighted [by jedl...@gmail.com|mailto:by%c2%a0jedl...@gmail.com] on the > dev list, the Eclipse build / debug no longer works after the project was > restructured and the Gradle Eclipse plugin was no longer used. > To fix, I'll submit a PR that reverts the Gradle Eclipse configuration back > to what it was before the project restructure. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1418) Upgrade to Jersey 2
[ https://issues.apache.org/jira/browse/FINERACT-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1418. - Fix Version/s: 1.6.0 Assignee: Petri Tuomola Resolution: Fixed > Upgrade to Jersey 2 > --- > > Key: FINERACT-1418 > URL: https://issues.apache.org/jira/browse/FINERACT-1418 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1353) Debugging Fineract in Eclipse does not work
[ https://issues.apache.org/jira/browse/FINERACT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1353. - Fix Version/s: 1.6.0 Assignee: Petri Tuomola Resolution: Duplicate > Debugging Fineract in Eclipse does not work > --- > > Key: FINERACT-1353 > URL: https://issues.apache.org/jira/browse/FINERACT-1353 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > Moving to Gradle Eclipse plug-in has broken debugging of Fineract in Eclipse > This is because Gradle builds (and enhances) the classes to a different path > than Eclipse, and hence the Eclipse classes are never enhanced by OpenJPA. > One way to fix would be to reapply the changes made in order to allow the > Gradle task for enhancement to be used in Eclipse again: > https://github.com/apache/fineract/commit/e295bef7434fede4659abd0a60457289b8e2a0d7 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1423) http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / DELETE)
[ https://issues.apache.org/jira/browse/FINERACT-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439587#comment-17439587 ] Petri Tuomola commented on FINERACT-1423: - This is because of the redirect to HTTPS, which does not seem to retain the HTTP method. Either we should fix this, or disable HTTP altogether. > http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / > DELETE) > > > Key: FINERACT-1423 > URL: https://issues.apache.org/jira/browse/FINERACT-1423 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Petri Tuomola >Priority: Major > > If you access any API using method POST / PUT / DELETE but with http (not > HTTPS), Fineract responds as if you had done a GET. > So PUT /fineract-provider/api/v1/offices/2 is actually actioned as GET > /fineract-provider/api/v1/offices/2 when done with http > If you change to https, everything works well. > This means that HTTP endpoint is pretty much dead for all practical purposes. > To avoid confusion, my suggestion would be that we disable this and just > reject any call to HTTP, rather than responding with the incorrect response. > HTTP is anyway insecure and should not be used. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1423) http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / DELETE)
[ https://issues.apache.org/jira/browse/FINERACT-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reassigned FINERACT-1423: --- Assignee: (was: Petri Tuomola) > http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / > DELETE) > > > Key: FINERACT-1423 > URL: https://issues.apache.org/jira/browse/FINERACT-1423 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Petri Tuomola >Priority: Major > > If you access any API using method POST / PUT / DELETE but with http (not > HTTPS), Fineract responds as if you had done a GET. > So PUT /fineract-provider/api/v1/offices/2 is actually actioned as GET > /fineract-provider/api/v1/offices/2 when done with http > If you change to https, everything works well. > This means that HTTP endpoint is pretty much dead for all practical purposes. > To avoid confusion, my suggestion would be that we disable this and just > reject any call to HTTP, rather than responding with the incorrect response. > HTTP is anyway insecure and should not be used. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1428) Switch from Travis to another CI tool
[ https://issues.apache.org/jira/browse/FINERACT-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1428. - Fix Version/s: 1.6.0 Assignee: Petri Tuomola Resolution: Fixed > Switch from Travis to another CI tool > - > > Key: FINERACT-1428 > URL: https://issues.apache.org/jira/browse/FINERACT-1428 > Project: Apache Fineract > Issue Type: Bug >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > Fix For: 1.6.0 > > > The delays in Travis builds have grown to several hours, and on many cases > Travis does not trigger at all as some Apache account limit is reached. > I raised an issue re this with the Apache Infra team. Their response was: > "Our Travis CI capacity is very limited and we will not be increasing that > limit in the foreseeable future. If you are not happy with it, we suggest you > switch to GitHub Actions or our Jenkins/BuildBot CI instead." > Given this, we should explore to change to Github Actions instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1362) compilation issue
[ https://issues.apache.org/jira/browse/FINERACT-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1362. - Fix Version/s: 1.6.0 Assignee: Petri Tuomola Resolution: Duplicate > compilation issue > - > > Key: FINERACT-1362 > URL: https://issues.apache.org/jira/browse/FINERACT-1362 > Project: Apache Fineract > Issue Type: Bug > Components: Build, Migration Scripts >Affects Versions: 1.5.0 >Reporter: steven espinoza >Assignee: Petri Tuomola >Priority: Critical > Fix For: 1.6.0 > > Attachments: logFieneract > > > I am trying to compile the software, but I get the following errors (attached > log). I followed all the readme instructions and tried in different ways. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1362) compilation issue
[ https://issues.apache.org/jira/browse/FINERACT-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17439586#comment-17439586 ] Petri Tuomola commented on FINERACT-1362: - Hi - the key message below is this: Caused by: org.apache.openjpa.util.MetaDataException: The type "class org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom" has not been enhanced. That means you have not ran the OpenJPA enhance task for the classes, so the server can't start. How are you running this? If with Gradle, then ./gradle bootRun should do this automatically. If Eclipse, then there was a problem with Eclipse build where enhance was not getting ran automatically. This should now be fixed in the latest development branch (see linked issue) > compilation issue > - > > Key: FINERACT-1362 > URL: https://issues.apache.org/jira/browse/FINERACT-1362 > Project: Apache Fineract > Issue Type: Bug > Components: Build, Migration Scripts >Affects Versions: 1.5.0 >Reporter: steven espinoza >Priority: Critical > Attachments: logFieneract > > > I am trying to compile the software, but I get the following errors (attached > log). I followed all the readme instructions and tried in different ways. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-1157) UnsupportedOperationException at InteropServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola reassigned FINERACT-1157:
---
Assignee: Petri Tuomola (was: Wandji Collins)
> UnsupportedOperationException at InteropServiceImpl
> ---
>
> Key: FINERACT-1157
> URL: https://issues.apache.org/jira/browse/FINERACT-1157
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
> Labels: beginner
> Fix For: 1.6.0
>
>
> See FINERACT-932 for general background, and fix this problem by making it
> return an appropriate HTTP 4xx client validation error instead of an internal
> server UnsupportedOperationException:
> {code} java.lang.UnsupportedOperationException: Account not found for
> identifier ACCOUNT_ID/00013
> at
> org.apache.fineract.interoperation.service.InteropServiceImpl.getAccountByIdentifier
> (InteropServiceImpl.java:179)
> at
> org.apache.fineract.interoperation.service.InteropServiceImpl$$FastClassBySpringCGLIB$$275e2ef6.invoke
> () {code}
> [~edcable] do you know who may be interested in fixing bugs in InterOp?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1157) UnsupportedOperationException at InteropServiceImpl
[
https://issues.apache.org/jira/browse/FINERACT-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1157.
-
Resolution: Fixed
I had to fix this as part of porting to Jersey 2. Interop error handling is now
aligned with the rest of Fineract.
> UnsupportedOperationException at InteropServiceImpl
> ---
>
> Key: FINERACT-1157
> URL: https://issues.apache.org/jira/browse/FINERACT-1157
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Michael Vorburger
>Assignee: Petri Tuomola
>Priority: Blocker
> Labels: beginner
> Fix For: 1.6.0
>
>
> See FINERACT-932 for general background, and fix this problem by making it
> return an appropriate HTTP 4xx client validation error instead of an internal
> server UnsupportedOperationException:
> {code} java.lang.UnsupportedOperationException: Account not found for
> identifier ACCOUNT_ID/00013
> at
> org.apache.fineract.interoperation.service.InteropServiceImpl.getAccountByIdentifier
> (InteropServiceImpl.java:179)
> at
> org.apache.fineract.interoperation.service.InteropServiceImpl$$FastClassBySpringCGLIB$$275e2ef6.invoke
> () {code}
> [~edcable] do you know who may be interested in fixing bugs in InterOp?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FINERACT-1428) Switch from Travis to another CI tool
Petri Tuomola created FINERACT-1428: --- Summary: Switch from Travis to another CI tool Key: FINERACT-1428 URL: https://issues.apache.org/jira/browse/FINERACT-1428 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola The delays in Travis builds have grown to several hours, and on many cases Travis does not trigger at all as some Apache account limit is reached. I raised an issue re this with the Apache Infra team. Their response was: "Our Travis CI capacity is very limited and we will not be increasing that limit in the foreseeable future. If you are not happy with it, we suggest you switch to GitHub Actions or our Jenkins/BuildBot CI instead." Given this, we should explore to change to Github Actions instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1426) Use relative path for Swagger-UI API server
[ https://issues.apache.org/jira/browse/FINERACT-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1426. - Fix Version/s: 1.6.0 Resolution: Fixed > Use relative path for Swagger-UI API server > --- > > Key: FINERACT-1426 > URL: https://issues.apache.org/jira/browse/FINERACT-1426 > Project: Apache Fineract > Issue Type: Improvement > Components: Deployment >Reporter: Phong >Priority: Trivial > Fix For: 1.6.0 > > > Currently the server list in swagger UI has a hardcoded URL for server API > ([https://localhost:8443/fineract-provider/api/v1).] [Swagger-UI support > using relative path for > servers|https://swagger.io/docs/specification/api-host-and-base-path/], > allowing for user to use the Swagger-UI for testing if the server is hosted > elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1423) http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / DELETE)
[ https://issues.apache.org/jira/browse/FINERACT-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1423: Description: If you access any API using method POST / PUT / DELETE but with http (not HTTPS), Fineract responds as if you had done a GET. So PUT /fineract-provider/api/v1/offices/2 is actually actioned as GET /fineract-provider/api/v1/offices/2 when done with http If you change to https, everything works well. This means that HTTP endpoint is pretty much dead for all practical purposes. To avoid confusion, my suggestion would be that we disable this and just reject any call to HTTP, rather than responding with the incorrect response. HTTP is anyway insecure and should not be used. > http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / > DELETE) > > > Key: FINERACT-1423 > URL: https://issues.apache.org/jira/browse/FINERACT-1423 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Petri Tuomola >Assignee: Petri Tuomola >Priority: Major > > If you access any API using method POST / PUT / DELETE but with http (not > HTTPS), Fineract responds as if you had done a GET. > So PUT /fineract-provider/api/v1/offices/2 is actually actioned as GET > /fineract-provider/api/v1/offices/2 when done with http > If you change to https, everything works well. > This means that HTTP endpoint is pretty much dead for all practical purposes. > To avoid confusion, my suggestion would be that we disable this and just > reject any call to HTTP, rather than responding with the incorrect response. > HTTP is anyway insecure and should not be used. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1423) http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / DELETE)
Petri Tuomola created FINERACT-1423: --- Summary: http (i.e. non-SSL) only responds with GET to any requests (POST / PUT / DELETE) Key: FINERACT-1423 URL: https://issues.apache.org/jira/browse/FINERACT-1423 Project: Apache Fineract Issue Type: Bug Affects Versions: 1.5.0 Reporter: Petri Tuomola Assignee: Petri Tuomola -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1421) Eclipse build / debug no longer works
Petri Tuomola created FINERACT-1421: --- Summary: Eclipse build / debug no longer works Key: FINERACT-1421 URL: https://issues.apache.org/jira/browse/FINERACT-1421 Project: Apache Fineract Issue Type: Bug Affects Versions: 1.5.0 Reporter: Petri Tuomola Assignee: Petri Tuomola Fix For: 1.6.0 As highlighted [by jedl...@gmail.com|mailto:by%c2%a0jedl...@gmail.com] on the dev list, the Eclipse build / debug no longer works after the project was restructured and the Gradle Eclipse plugin was no longer used. To fix, I'll submit a PR that reverts the Gradle Eclipse configuration back to what it was before the project restructure. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FINERACT-1418) Upgrade to Jersey 2
Petri Tuomola created FINERACT-1418: --- Summary: Upgrade to Jersey 2 Key: FINERACT-1418 URL: https://issues.apache.org/jira/browse/FINERACT-1418 Project: Apache Fineract Issue Type: Bug Reporter: Petri Tuomola -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1408) Add a unix shell to the Fineract Docker image
[
https://issues.apache.org/jira/browse/FINERACT-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434221#comment-17434221
]
Petri Tuomola commented on FINERACT-1408:
-
Hi - yes, with the latest PR we are now back to using base images with a
distro. The previous move to distroless was done to improve security and make
the images smaller. But I'm assuming that no one is using the Fineract
prepackaged images in a production system anyway, so having the basic tools
included is probably a sensible choice.
> Add a unix shell to the Fineract Docker image
> -
>
> Key: FINERACT-1408
> URL: https://issues.apache.org/jira/browse/FINERACT-1408
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Kristof Jozsa
>Priority: Minor
>
> The current fineract Dockerfile uses {{gcr.io/distroless/java:11}} as the
> base image, which does not seem to have {{bash}} or any other usable shell.
> Having no shell makes it really hard to debug anything _inside_ the docker
> image - eg. I'm putting together a Kubernetes configuration with Configmap
> exporting environment variables, and it's about impossible to see what's
> going on inside the container without a shell.
> Please consider adding a shell, or using a docker base image which has one
> already (eg. the official {{openjdk:11}} image could work just fine).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1399) Tag /Tag Id is mandatory in Bulk Import for chart of account
[ https://issues.apache.org/jira/browse/FINERACT-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1399: Fix Version/s: 1.6.0 > Tag /Tag Id is mandatory in Bulk Import for chart of account > > > Key: FINERACT-1399 > URL: https://issues.apache.org/jira/browse/FINERACT-1399 > Project: Apache Fineract > Issue Type: Bug > Components: Accounting >Affects Versions: 1.5.0 >Reporter: Manoj Mohanan >Assignee: Manoj Mohanan >Priority: Minor > Fix For: 1.6.0 > > > While doing Bulk import for chart of accounts, the Tag / Tag Id are mandatory > where as these are not mandatory for creating chart of account. > Expected result: Tag/ Tag Id should not be mandatory for bulk import. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (FINERACT-1273) Trigger Based Client Email Notifications
[ https://issues.apache.org/jira/browse/FINERACT-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola reopened FINERACT-1273: - > Trigger Based Client Email Notifications > > > Key: FINERACT-1273 > URL: https://issues.apache.org/jira/browse/FINERACT-1273 > Project: Apache Fineract > Issue Type: New Feature > Components: Organization >Affects Versions: 1.5.1 >Reporter: Javier Borkenztain >Assignee: Adonay Porras >Priority: Major > Fix For: 1.5.1 > > > An SMTP/Email Account configuration is needed for the core; it can be added > in the System External Services section. > Then an Email Campaign option can be created within the Organization section. > This should have a Trigger option to define when the campaign will be sent. > Also, the body of the email should be a Rich Text Editor so parameters can be > included if needed. > Eventually, more specific trigger options can be developed so we could define > things like “Send email X days after the installment due date”. > For this, an email parameter should be included in the client creation form. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FINERACT-1273) Trigger Based Client Email Notifications
[ https://issues.apache.org/jira/browse/FINERACT-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola updated FINERACT-1273: Fix Version/s: (was: 1.5.1) 1.6.0 > Trigger Based Client Email Notifications > > > Key: FINERACT-1273 > URL: https://issues.apache.org/jira/browse/FINERACT-1273 > Project: Apache Fineract > Issue Type: New Feature > Components: Organization >Affects Versions: 1.5.1 >Reporter: Javier Borkenztain >Assignee: Adonay Porras >Priority: Major > Fix For: 1.6.0 > > > An SMTP/Email Account configuration is needed for the core; it can be added > in the System External Services section. > Then an Email Campaign option can be created within the Organization section. > This should have a Trigger option to define when the campaign will be sent. > Also, the body of the email should be a Rich Text Editor so parameters can be > included if needed. > Eventually, more specific trigger options can be developed so we could define > things like “Send email X days after the installment due date”. > For this, an email parameter should be included in the client creation form. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1316) Interest calculation going wrong for advance/late payments
[ https://issues.apache.org/jira/browse/FINERACT-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1316. - Resolution: Fixed > Interest calculation going wrong for advance/late payments > -- > > Key: FINERACT-1316 > URL: https://issues.apache.org/jira/browse/FINERACT-1316 > Project: Apache Fineract > Issue Type: Bug > Components: Loan >Affects Versions: 1.4.0 >Reporter: bharath gowda >Assignee: Avik Ganguly >Priority: Critical > Fix For: 1.6.0 > > Attachments: 22.png, product config.png > > > for a loan product with daily interest calculation, when an > advance/late/partial repayments are made, interest calculation is going > wrong, which is resulting in 3 major issues > > # repayment schedule payment allocation is going wrong > # The next prepayment interest calculation is wrong > # The interest of all the subsequent installments is calculating wrong > because of the wrong principal balance. > To reproduce, create a loan product with interest calculation set to > daily(check attachment for complete product configuration) > create->disburse a loan with the loan product > do a early repayment to the loan and check the calculation > refer attachment for the sample > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1345) Fix runreports
[ https://issues.apache.org/jira/browse/FINERACT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1345. - Fix Version/s: 1.6.0 Resolution: Fixed > Fix runreports > -- > > Key: FINERACT-1345 > URL: https://issues.apache.org/jira/browse/FINERACT-1345 > Project: Apache Fineract > Issue Type: Bug >Reporter: Joseph Makara >Assignee: Joseph Makara >Priority: Major > Fix For: 1.6.0 > > > Proper fix for jiras FINERACT-1338 FINERACT-1336 and FINERACT-1306 > attempting to > add the following report parameters to stretchy reports table > * ReportCategoryList, > * FullReportList and > * FullParameterList -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1314) Client Familiy Details Edit not working from client view screen
[
https://issues.apache.org/jira/browse/FINERACT-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1314.
-
Fix Version/s: 1.6.0
Resolution: Fixed
> Client Familiy Details Edit not working from client view screen
> ---
>
> Key: FINERACT-1314
> URL: https://issues.apache.org/jira/browse/FINERACT-1314
> Project: Apache Fineract
> Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: bharath gowda
>Assignee: Benura Abeywardena
>Priority: Minor
> Fix For: 1.6.0
>
>
> Edit option of client family details is not working.
>
> To reproduce,
> # Add family details to the client(do not add profession, gender, and
> marital status)
> # Edit the family details and change any field.
> The system will not accept and the error is not handled in the system
> In the Inspect mode, the system is throwing an internal exception for
> "profession, marital and gender status_cv_id " even though these parameters
> are not mandatory
>
> Expected behavior, the system should allow to Edit the family details, even
> when profession, marital and gender fields are not entered.
>
> Exception example is below
> Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: Cannot add or
> upda
> te a child row: a foreign key constraint fails
> (`fineract_default`.`m_family_mem
> bers`, CONSTRAINT `FK_m_family_members_profession_m_code_value` FOREIGN KEY
> (`pr
> ofession_cv_id`) REFERENCES `m_code_value` (`id`)) {prepstmnt 1120209371
> UPDATE
> m_family_members SET age = ?, firstname = ?, gender_cv_id = ?,
> marital_status_cv
> _id = ?, profession_cv_id = ? WHERE id = ?} [code=1452, state=23000]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1031) Advanced accounting for fees not working
[ https://issues.apache.org/jira/browse/FINERACT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1031. - Resolution: Fixed > Advanced accounting for fees not working > - > > Key: FINERACT-1031 > URL: https://issues.apache.org/jira/browse/FINERACT-1031 > Project: Apache Fineract > Issue Type: Bug > Components: Accounting, Loan >Affects Versions: 1.1.0, 1.3.0 >Reporter: bharath gowda >Assignee: Benura Abeywardena >Priority: Major > Labels: gsoc, p1 > Fix For: 1.6.0 > > Attachments: 1.png, 2.png, 3.png, image-2020-06-14-22-19-54-702.png > > > //Resurfaced Issue // > Deepak's description in mailing list: > > I was to map the different accounting GLs for different Fees. I mapped the > GLs to the respective fees. PFA the screenshot. But still in accounting, the > entry has gone to the single GL > https: demo.openmf.org > username: mifos > password: password > > Loan ID: depk02980 > Product Name: deepak -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1357) Collateral Management Module
[ https://issues.apache.org/jira/browse/FINERACT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1357. - Fix Version/s: 1.6.0 Resolution: Fixed > Collateral Management Module > > > Key: FINERACT-1357 > URL: https://issues.apache.org/jira/browse/FINERACT-1357 > Project: Apache Fineract > Issue Type: New Feature > Components: Client, Loan >Reporter: Benura Abeywardena >Assignee: Benura Abeywardena >Priority: Major > Fix For: 1.6.0 > > > Collateral Management module allows to manage collateral details in product, > client & loan levels. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-592) Undo a charge waive
[ https://issues.apache.org/jira/browse/FINERACT-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-592. Resolution: Fixed > Undo a charge waive > --- > > Key: FINERACT-592 > URL: https://issues.apache.org/jira/browse/FINERACT-592 > Project: Apache Fineract > Issue Type: Improvement > Components: Loan >Affects Versions: 1.5.0 >Reporter: Jan Antonie Peens >Assignee: Benura Abeywardena >Priority: Minor > Labels: confirm, gsoc, p2 > Fix For: 1.6.0 > > Attachments: image-2021-04-06-20-06-08-917.png > > > Reverse a charge waiver. > We have gotten the situation were a charge was waived by accident and we > would therefore like to undo the mistake. > Would such a feature be possible? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-493) Repayment method by Post Dated Checks
[ https://issues.apache.org/jira/browse/FINERACT-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-493. Resolution: Fixed > Repayment method by Post Dated Checks > - > > Key: FINERACT-493 > URL: https://issues.apache.org/jira/browse/FINERACT-493 > Project: Apache Fineract > Issue Type: New Feature > Components: Loan >Reporter: Justine Nam >Assignee: Benura Abeywardena >Priority: Major > Labels: feature, gsoc, p2 > Fix For: 1.6.0 > > > Repayment by Post Dated Checks > In Current updated MifosX, there is no convenient features for Post dated > checks Repayment. > Our company normally require Post Dated Checks to the client as repayment > method when their loan is approved. > If the term is 6 month, we asked them to provide 6 pcs Post Dated Checks for > repayment. > So, If it's possiblewhen we create the loan application for > individuals, make one more optional procedures to encode(input) the Post > Dated Checks details during Disburse Loan application > Normally, Check numbers are increased by 1... > example) > Name of BankDue Date Account No. Check No. Amount > Citi Bank 1/1/2017 230016 *11 1000 > Citi Bank 1/2/2017 230016*12 1000 > Citi Bank 1/3/2017 230016 *13 1000 > Citi Bank 1/4/2017 230016 *14 1000 > Citi Bank 1/5/2017 230016 *15 1000 > Citi Bank 1/6/2017230016*16 1000 > So, When we input the Postdated checks details. > 1. It should automatically generate the rows based on the term(get this data > from Loan application) > - if the term is 6 months, it should generate 6 rows for encoding of Checks > Info. > 2. For Check No. field, when we input first check No. , it should > automatically generate Check no. increased by 1 > 3. This data table is linked with Repayment Schedule. > When we see the repayment schedule , Check No. must be showed (If that data > is encoded) > 4. when we see the collection sheet, those information(like check no, bank > name) will automatically appear and can be edited as well...Also, It can be > cleared(make payment) in Collection Sheet > In current MifosX system, we need to encode one by one whenever there is > due-payment. > Collection Sheet -> Add payment detail -> input the Check detail. > If we have a few post dated checks, it's ok .But If there are many checks > to encode the datails for checks.this is time consuming works. > I hope someone work on this matter.. > thank you -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1277) Hook for Message gateway
[ https://issues.apache.org/jira/browse/FINERACT-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1277. - Fix Version/s: 1.6.0 Resolution: Fixed > Hook for Message gateway > > > Key: FINERACT-1277 > URL: https://issues.apache.org/jira/browse/FINERACT-1277 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Manoj Mohanan >Priority: Minor > Fix For: 1.6.0 > > > Add Event based hook support for message gateway. > Message-gateway is available in external services for specific cases, but it > is not available to configure event based. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1366) invalid fields in PostClientsClientIdRequest in clientsApiResourceSwagger
[
https://issues.apache.org/jira/browse/FINERACT-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1366.
-
Fix Version/s: (was: 1.5.0)
1.6.0
Resolution: Fixed
> invalid fields in PostClientsClientIdRequest in clientsApiResourceSwagger
> -
>
> Key: FINERACT-1366
> URL: https://issues.apache.org/jira/browse/FINERACT-1366
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Danish Jamal
>Assignee: Danish Jamal
>Priority: Major
> Labels: client, gsoc2021, swagger
> Fix For: 1.6.0
>
>
> Expected body payload while activating the client:
> {code:java}
> {
> "activationDate": "02 August 2021",
> "dateFormat": "dd ",
> "locale": "en"
> }
> {code}
> Payload model (PostClientsClientIdRequest):
> {code:java}
> @Schema(description = "PostClientsClientIdRequest")
> public static final class PostClientsClientIdRequest {
> private PostClientsClientIdRequest() {}
> @Schema(example = "We cannot accept transfers of clients having loans
> with less than 1 repayment left")
> public String note;
> }
> {code}
> the PostClientsClientIdRequest must define the required field in order to
> generate the valid client.
> Also officeId field is missing in the returned response while activating a
> client.
> {code:java}
> // defined in swagger resource class
> @Schema(description = "PostClientsClientIdResponse")
> public static final class PostClientsClientIdResponse {
> private PostClientsClientIdResponse() {}
> @Schema(example = "2")
> public Integer clientId;
> @Schema(example = "2")
> public Integer resourceId;
> }
> // actual json returned
> {
> "officeId": 2,
> "clientId": 6,
> "resourceId": 6
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1364) Missmatch datatype in groups field of client model "GetClientsClientIdResponse"
[
https://issues.apache.org/jira/browse/FINERACT-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1364.
-
Fix Version/s: (was: 1.5.0)
1.6.0
Resolution: Fixed
> Missmatch datatype in groups field of client model
> "GetClientsClientIdResponse"
> ---
>
> Key: FINERACT-1364
> URL: https://issues.apache.org/jira/browse/FINERACT-1364
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Danish Jamal
>Assignee: Danish Jamal
>Priority: Major
> Labels: client, groups, gsoc2021, swagger
> Fix For: 1.6.0
>
> Attachments: Screenshot 2021-07-28 at 2.28.17 PM.png, Screenshot
> 2021-07-28 at 2.30.33 PM.png
>
>
> The generated Fineract-client model "*GetClientsClientIdResponse"* has
> invalid group fields. The model class expects List as groups find but
> backend send the below Object for endpoint clients/\{clientId}.
> {
> "id": 13,
> "accountNo": "00013",
> "name": "Test"
> }
> Checkout the below screenshots for model expectations and backend response.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1365) invalid swagger annotations in DatatablesApiResource for posting datatable
[ https://issues.apache.org/jira/browse/FINERACT-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1365. - Fix Version/s: (was: 1.5.0) 1.6.0 Resolution: Fixed > invalid swagger annotations in DatatablesApiResource for posting datatable > -- > > Key: FINERACT-1365 > URL: https://issues.apache.org/jira/browse/FINERACT-1365 > Project: Apache Fineract > Issue Type: Bug >Reporter: Danish Jamal >Assignee: Danish Jamal >Priority: Major > Labels: datatable, gsoc2021, swagger > Fix For: 1.6.0 > > Attachments: Screenshot 2021-08-06 at 10.22.06 PM.png, Screenshot > 2021-08-06 at 10.22.17 PM.png > > > DatatablesApiResourceSwagger.java has invalid body fields while posting the > new datable. > Checkout the difference in fields in below attached screenshots. > This issue is mainly due to invalid swagger resource file. Hence the doc > mentioned in the older html is correct and the > DatatablesApiResourceSwagger.java must be modified to meet the actual api > body expectations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1363) Datatables field missing in PostClientsRequest in generated Fineract-client sd
[
https://issues.apache.org/jira/browse/FINERACT-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Petri Tuomola resolved FINERACT-1363.
-
Fix Version/s: (was: 1.5.0)
1.6.0
Resolution: Fixed
> Datatables field missing in PostClientsRequest in generated Fineract-client sd
> --
>
> Key: FINERACT-1363
> URL: https://issues.apache.org/jira/browse/FINERACT-1363
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Danish Jamal
>Assignee: Danish Jamal
>Priority: Major
> Labels: client, datatable, gsoc2021, swagger
> Fix For: 1.6.0
>
> Attachments: s3.png, ss1.png, ss2.png
>
>
> In ss1 I tried to create client using the fields as mentioned in Swagger doc/
> generated model(PostClientsRequest class), checkout the ss2 there is no field
> for datatables expected in body.But for testing purpose I tried including the
> {{"datatables"}} field in body (check ss3) and it worked.
> Hence API expects user to pass "datatables" fields while creating new client,
> but the field is missing in the body payload class (PostClientsRequest).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (FINERACT-1369) invalid body payload in basic authentication swagger resource and generated client
[ https://issues.apache.org/jira/browse/FINERACT-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1369. - Fix Version/s: (was: 1.5.0) 1.6.0 Resolution: Fixed > invalid body payload in basic authentication swagger resource and generated > client > -- > > Key: FINERACT-1369 > URL: https://issues.apache.org/jira/browse/FINERACT-1369 > Project: Apache Fineract > Issue Type: Bug >Reporter: Danish Jamal >Assignee: Danish Jamal >Priority: Major > Labels: authentication, gsoc2021, swagger > Fix For: 1.6.0 > > > Http basic authentication expects body payload with username and password but > instead in AthenticationApiResource, string is expected as body payload. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1370) invalid response schema defined in SearchApiResource
[ https://issues.apache.org/jira/browse/FINERACT-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1370. - Fix Version/s: (was: 1.5.0) 1.6.0 Resolution: Fixed > invalid response schema defined in SearchApiResource > > > Key: FINERACT-1370 > URL: https://issues.apache.org/jira/browse/FINERACT-1370 > Project: Apache Fineract > Issue Type: Bug >Reporter: Danish Jamal >Assignee: Danish Jamal >Priority: Major > Labels: gsoc2021, search, swagger > Fix For: 1.6.0 > > > While making a /search or search/advance request a list of GetSearchResponse > and PostAdhocQuerySearchResponse objects must be returned respectively bit > instead a object is returned causing the generated client to crash while > parsing the response. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (FINERACT-1383) savings accounts transaction api missing in FineractClient
[ https://issues.apache.org/jira/browse/FINERACT-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petri Tuomola resolved FINERACT-1383. - Fix Version/s: (was: 1.5.0) 1.6.0 Resolution: Fixed > savings accounts transaction api missing in FineractClient > -- > > Key: FINERACT-1383 > URL: https://issues.apache.org/jira/browse/FINERACT-1383 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.5.0 >Reporter: Danish Jamal >Assignee: Danish Jamal >Priority: Major > Labels: fineract-client-sdk, gsoc2021 > Fix For: 1.6.0 > > > The > [SavingsAccountTransactionsApi.java|https://github.com/openMF/fineract-client/blob/master/src/main/java/org/apache/fineract/client/services/SavingsAccountTransactionsApi.java] > service is generated but the > c[FineractClient.java|https://github.com/openMF/fineract-client/blob/master/src/main/java/org/apache/fineract/client/util/FineractClient.java] > class doesn't provide the access to the service neither it creates the > retrofit service. > We can also find the savingsAccountsTransaction related documentation in > [swagger.|https://localhost:8443/fineract-provider/swagger-ui/index.html#/Savings%20Account%20Transactions/retrieveOne_23] > As the FineractClient file is defined externally it might be possible that > [SavingsAccountTransactionsApi|https://github.com/openMF/fineract-client/blob/master/src/main/java/org/apache/fineract/client/services/SavingsAccountTransactionsApi.java] > is forgotten. -- This message was sent by Atlassian Jira (v8.3.4#803005)
