[jira] [Commented] (FINERACT-821) Enable and enforce (!) Checkstyle in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071560#comment-17071560 ] Yemdjih Kaze Nasser commented on FINERACT-821: -- I'll pick from where you left. > Enable and enforce (!) Checkstyle in Fineract > - > > Key: FINERACT-821 > URL: https://issues.apache.org/jira/browse/FINERACT-821 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Priority: Major > Fix For: 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > as suggested in FINERACT-712, we really should enable Checkstyle in Fineract. > My past experience in such matters, confirmed by FINERACT-702, is that these > things only ever work and have a lasting effect if you bulk fix all > violations and switch on enforcement. If you only report, it's mostly useless. > As for specific Checkstyle rules, I have spent a fair amount of time in a > past life on a project (which I'm currently no longer actively invoved in) to > refine a what I believe to be "good" Checkstyle rule set, we could reuse this > for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-822) Enable and enforce (!) Google's Error Prone quality check tool in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser reassigned FINERACT-822: Assignee: Yemdjih Kaze Nasser > Enable and enforce (!) Google's Error Prone quality check tool in Fineract > -- > > Key: FINERACT-822 > URL: https://issues.apache.org/jira/browse/FINERACT-822 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Yemdjih Kaze Nasser >Priority: Major > > As tracked in overall FINERACT-712, similarly to SpotBugs (FINERACT-702), PMD > and Checkstyle (FINERACT-821), I would suggest that we also enable and > enforce Error Prone quality check tool in Fineract to catch any obvious > programming error bugs. > Error Prone is extensively used inside Google private code base, has been > open sourced, and is meanwhile popular in many open source projects as well > (see other Apache projects' use). More information is available on > [https://errorprone.info|https://errorprone.info/] and > [https://github.com/google/error-prone]. > I have spent a fair amount of time in a past life on a project (which I'm > currently no longer actively invoved in) to refine a what I believe to be > "good" Error Prone rule set, we could reuse this for Fineract (it's EPL > licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/infrautils/blob/master/common/parent/pom.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-804) Use OkHTTP v3 instead of 2.0.0
[ https://issues.apache.org/jira/browse/FINERACT-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser reassigned FINERACT-804: Assignee: Yemdjih Kaze Nasser > Use OkHTTP v3 instead of 2.0.0 > -- > > Key: FINERACT-804 > URL: https://issues.apache.org/jira/browse/FINERACT-804 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Yemdjih Kaze Nasser >Priority: Major > > This came up during (the review of) FINERACT-797: > [The Spring Boot > BOM|https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-dependencies/pom.xml] > uses OkHTTP v3, whereas Fineract currently has a fixed 2.0.0. > The goal of this issue would be to drop the version number of OkHTTP in > Fineract's Gradle dependencies list, so that we simply inherit whichever > (latest) one our use of Spring Boot BOM, introduced in FINERACT-797, gives us. > It's possible that the change from OkHTTP v2 to v3 requires some code changes > (not checked). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-807) Use underscore instead of dash in tenants and default tenant database names
[ https://issues.apache.org/jira/browse/FINERACT-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yemdjih Kaze Nasser reassigned FINERACT-807: Assignee: Yemdjih Kaze Nasser (was: Michael Vorburger) > Use underscore instead of dash in tenants and default tenant database names > --- > > Key: FINERACT-807 > URL: https://issues.apache.org/jira/browse/FINERACT-807 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Yemdjih Kaze Nasser >Priority: Major > Labels: beginner, newbie, starer > Fix For: 1.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The Fineract tenants and tenant database names by default are currently > mifosplatform-tenants and mifostenant-default respectively. > The Google Cloud Platform console for managed MySQL (Cloud SQL) prevents > creating MySQL databases containing dashes; the UI says Database name: Needs > to follow [the MySQL identifier > rules|https://dev.mysql.com/doc/refman/5.7/en/identifiers.html]. > While this limitation appears to only be enforced in the Google Cloud UI > (it's still possible to create databases containing '-' dashes using the > gcloud CLI), the linked doc does seem to suggest to use only underscores. > To make this simpler, and comply with mySQL doc recommendation, let's change > mifosplatform-tenants to fineract_tenants and mifostenant-default to > fineract_default. (The change from mifosplatform to fineract is just because > this seems a good opportunity to make that change, and because it's probably > less and not more confusing to change the entire name, and not just a dash to > and underscore.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yemdjih Kaze Nasser reassigned FINERACT-783:
Assignee: Yemdjih Kaze Nasser
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-696) use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
[
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068818#comment-17068818
]
Yemdjih Kaze Nasser commented on FINERACT-696:
--
I've tried assigning myself to issues but it does not work. Not sure why that
happens
> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> ---
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Build
>Reporter: Michael Vorburger
>Priority: Major
> Labels: beginner, starter
> Time Spent: 40m
> Remaining Estimate: 0h
>
> While code reviewing [https://github.com/apache/fineract/pull/464], I came
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but
> just an automated build failure. This is possible using SpotBugs (not
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible
> successor) and [https://github.com/KengoTODA/findbugs-slf4j/] (for this
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but
> using findbugs-slf4j for Fineract would have value even before that's
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just
> waiting to have issues to working on (I'm joking) - so I was wondering if
> perhaps you knew of anyone who would be willing to work on this one?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-850) Random Failing Integration Test
[
https://issues.apache.org/jira/browse/FINERACT-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yemdjih Kaze Nasser updated FINERACT-850:
-
Description:
Lately integration tests have been failing randomly sometimes due deadlocks,
duplicate values and slow queries.
{code:java}
06:22:42.570 [http-bio-8443-exec-26] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:43.166 [http-bio-8443-exec-64] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@7135e406:
Duplicate entry '6SKY' for key 'sp_unq_short_name'
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@a41a8cf:
Column 'savings_product_id' cannot be null
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@65f9b2da:
Column 'deposit_product_id' cannot be null
> Task :integrationTest
org.apache.fineract.integrationtests.FixedDepositTest >
testFixedDepositAccountWithPeriodAndAmountInterestRateChart_AMOUNT_VARIATION
FAILED
java.lang.AssertionError at FixedDepositTest.java:2463
06:22:45.417 [http-bio-8443-exec-45] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:46.614 [http-bio-8443-exec-15] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:47.043 [http-bio-8443-exec-3] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:47.616 [http-bio-8443-exec-48] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:47.983 [http-bio-8443-exec-29] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@26731e64:
Duplicate entry 'fund-N3OXT' for key 'fund_externalid_org'
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@499016fd:
Duplicate entry 'CUW16D852W' for key 'fund_name_org'
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@49b0b95:
Duplicate entry '1570-MSISDN' for key 'uk_interop_identifier_account'
The RuntimeException could not be mapped to a response, re-throwing to the HTTP
container
org.springframework.dao.DataIntegrityViolationException: The transaction has
been rolled back. See the nested exceptions for details on the errors that
occurred.; nested exception is
org.apache.openjpa.persistence.EntityExistsException: The transaction has been
rolled back. See the nested exceptions for details on the errors that occurred.
FailedObject:
org.apache.fineract.interoperation.domain.InteropIdentifier@5a24c38c
at
org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:400)
at
org.springframework.orm.jpa.DefaultJpaDialect.translateExceptionIfPossible(DefaultJpaDialect.java:128)
at
org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:538)
at
org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:744)
at
org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:712)
at
org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:631)
at
org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:385)
at
org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:99)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
at
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
at
org.apache.fineract.commands.service.SynchronousCommandProcessingService$$EnhancerBySpringCGLIB$$a5dc283b.processAndLogCommand()
at
org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl.logCommandSource(PortfolioCommandSourceWritePlatformServiceImpl.java:96)
at
org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$FastClassBySpringCGLIB$$31c15082.invoke()
at
org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterc
[jira] [Issue Comment Deleted] (FINERACT-850) Random Failing Integration Test
[
https://issues.apache.org/jira/browse/FINERACT-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yemdjih Kaze Nasser updated FINERACT-850:
-
Comment: was deleted
(was: It would really be nice if someone/anyone can investigate this problem.)
> Random Failing Integration Test
> ---
>
> Key: FINERACT-850
> URL: https://issues.apache.org/jira/browse/FINERACT-850
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Yemdjih Kaze Nasser
>Priority: Major
>
> Lately integration tests have been failing randomly sometimes due deadlocks,
> duplicate values and slow queries.
> {code:java}
> 06:22:42.570 [http-bio-8443-exec-26] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:43.166 [http-bio-8443-exec-64] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@7135e406:
> Duplicate entry '6SKY' for key 'sp_unq_short_name'
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@a41a8cf:
> Column 'savings_product_id' cannot be null
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@65f9b2da:
> Column 'deposit_product_id' cannot be null
> > Task :integrationTest
> org.apache.fineract.integrationtests.FixedDepositTest >
> testFixedDepositAccountWithPeriodAndAmountInterestRateChart_AMOUNT_VARIATION
> FAILED
> java.lang.AssertionError at FixedDepositTest.java:2463
> 06:22:45.417 [http-bio-8443-exec-45] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:46.614 [http-bio-8443-exec-15] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:47.043 [http-bio-8443-exec-3] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:47.616 [http-bio-8443-exec-48] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:47.983 [http-bio-8443-exec-29] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@26731e64:
> Duplicate entry 'fund-N3OXT' for key 'fund_externalid_org'
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@499016fd:
> Duplicate entry 'CUW16D852W' for key 'fund_name_org'
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@49b0b95:
> Duplicate entry '1570-MSISDN' for key 'uk_interop_identifier_account'
> The RuntimeException could not be mapped to a response, re-throwing to the
> HTTP container
> org.springframework.dao.DataIntegrityViolationException: The transaction has
> been rolled back. See the nested exceptions for details on the errors that
> occurred.; nested exception is
>
> org.apache.openjpa.persistence.EntityExistsException: The transaction has
> been rolled back. See the nested exceptions for details on the errors that
> occurred.
> FailedObject:
> org.apache.fineract.interoperation.domain.InteropIdentifier@5a24c38c
> at
> org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:400)
> at
> org.springframework.orm.jpa.DefaultJpaDialect.translateExceptionIfPossible(DefaultJpaDialect.java:128)
> at
> org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:538)
> at
> org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:744)
> at
> org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:712)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:631)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:385)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:99)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
> at
> org.apache.fineract.commands.serv
[jira] [Commented] (FINERACT-850) Random Failing Integration Test
[
https://issues.apache.org/jira/browse/FINERACT-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052375#comment-17052375
]
Yemdjih Kaze Nasser commented on FINERACT-850:
--
It would really be nice if someone/anyone can investigate this problem.
> Random Failing Integration Test
> ---
>
> Key: FINERACT-850
> URL: https://issues.apache.org/jira/browse/FINERACT-850
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Yemdjih Kaze Nasser
>Priority: Major
>
> Lately integration tests have been failing randomly sometimes due deadlocks,
> duplicate values and slow queries.
> {code:java}
> 06:22:42.570 [http-bio-8443-exec-26] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:43.166 [http-bio-8443-exec-64] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@7135e406:
> Duplicate entry '6SKY' for key 'sp_unq_short_name'
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@a41a8cf:
> Column 'savings_product_id' cannot be null
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@65f9b2da:
> Column 'deposit_product_id' cannot be null
> > Task :integrationTest
> org.apache.fineract.integrationtests.FixedDepositTest >
> testFixedDepositAccountWithPeriodAndAmountInterestRateChart_AMOUNT_VARIATION
> FAILED
> java.lang.AssertionError at FixedDepositTest.java:2463
> 06:22:45.417 [http-bio-8443-exec-45] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:46.614 [http-bio-8443-exec-15] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:47.043 [http-bio-8443-exec-3] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:47.616 [http-bio-8443-exec-48] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> 06:22:47.983 [http-bio-8443-exec-29] DEBUG
> o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is
> not configured
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@26731e64:
> Duplicate entry 'fund-N3OXT' for key 'fund_externalid_org'
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@499016fd:
> Duplicate entry 'CUW16D852W' for key 'fund_name_org'
> Could not execute query
> org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@49b0b95:
> Duplicate entry '1570-MSISDN' for key 'uk_interop_identifier_account'
> The RuntimeException could not be mapped to a response, re-throwing to the
> HTTP container
> org.springframework.dao.DataIntegrityViolationException: The transaction has
> been rolled back. See the nested exceptions for details on the errors that
> occurred.; nested exception is
>
> org.apache.openjpa.persistence.EntityExistsException: The transaction has
> been rolled back. See the nested exceptions for details on the errors that
> occurred.
> FailedObject:
> org.apache.fineract.interoperation.domain.InteropIdentifier@5a24c38c
> at
> org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:400)
> at
> org.springframework.orm.jpa.DefaultJpaDialect.translateExceptionIfPossible(DefaultJpaDialect.java:128)
> at
> org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:538)
> at
> org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:744)
> at
> org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:712)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:631)
> at
> org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:385)
> at
> org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:99)
> at
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
> at
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
> at
> org.apac
[jira] [Created] (FINERACT-850) Random Failing Integration Test
Yemdjih Kaze Nasser created FINERACT-850:
Summary: Random Failing Integration Test
Key: FINERACT-850
URL: https://issues.apache.org/jira/browse/FINERACT-850
Project: Apache Fineract
Issue Type: Bug
Reporter: Yemdjih Kaze Nasser
Lately integration tests have been failing randomly sometimes due deadlocks,
duplicate values and slow queries.
{code:java}
06:22:42.570 [http-bio-8443-exec-26] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:43.166 [http-bio-8443-exec-64] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@7135e406:
Duplicate entry '6SKY' for key 'sp_unq_short_name'
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@a41a8cf:
Column 'savings_product_id' cannot be null
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@65f9b2da:
Column 'deposit_product_id' cannot be null
> Task :integrationTest
org.apache.fineract.integrationtests.FixedDepositTest >
testFixedDepositAccountWithPeriodAndAmountInterestRateChart_AMOUNT_VARIATION
FAILED
java.lang.AssertionError at FixedDepositTest.java:2463
06:22:45.417 [http-bio-8443-exec-45] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:46.614 [http-bio-8443-exec-15] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:47.043 [http-bio-8443-exec-3] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:47.616 [http-bio-8443-exec-48] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
06:22:47.983 [http-bio-8443-exec-29] DEBUG
o.a.f.p.a.s.AccountAssociationsReadPlatformServiceImpl - Linking account is not
configured
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@26731e64:
Duplicate entry 'fund-N3OXT' for key 'fund_externalid_org'
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@499016fd:
Duplicate entry 'CUW16D852W' for key 'fund_name_org'
Could not execute query
org.drizzle.jdbc.internal.common.query.DrizzleParameterizedQuery@49b0b95:
Duplicate entry '1570-MSISDN' for key 'uk_interop_identifier_account'
The RuntimeException could not be mapped to a response, re-throwing to the HTTP
container
org.springframework.dao.DataIntegrityViolationException: The transaction has
been rolled back. See the nested exceptions for details on the errors that
occurred.; nested exception is
org.apache.openjpa.persistence.EntityExistsException: The transaction has been
rolled back. See the nested exceptions for details on the errors that occurred.
FailedObject:
org.apache.fineract.interoperation.domain.InteropIdentifier@5a24c38c
at
org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:400)
at
org.springframework.orm.jpa.DefaultJpaDialect.translateExceptionIfPossible(DefaultJpaDialect.java:128)
at
org.springframework.orm.jpa.JpaTransactionManager.doCommit(JpaTransactionManager.java:538)
at
org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:744)
at
org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:712)
at
org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:631)
at
org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:385)
at
org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:99)
at
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:747)
at
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
at
org.apache.fineract.commands.service.SynchronousCommandProcessingService$$EnhancerBySpringCGLIB$$a5dc283b.processAndLogCommand()
at
org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl.logCommandSource(PortfolioCommandSourceWritePlatformServiceImpl.java:96)
at
org.apache.fineract.commands.service.PortfolioCommandSourceWritePlatformServiceImpl$$FastClassBySpringCGLIB$$31c15082.invoke()
at
org.springframework.cglib.pr
[jira] [Created] (FINERACT-845) Integrate community app in docker build
Yemdjih Kaze Nasser created FINERACT-845: Summary: Integrate community app in docker build Key: FINERACT-845 URL: https://issues.apache.org/jira/browse/FINERACT-845 Project: Apache Fineract Issue Type: Improvement Components: Build Reporter: Yemdjih Kaze Nasser As suggested by [~vorburger], it would be really awesome if our docker deployment runs with the UI all out of the box. We do actually have the container already, see https://github.com/openMF/community-app/issues/3112, but someone still needs to add it to https://github.com/apache/fineract/blob/develop/docker-compose.yml and have it correctly configured. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-821) Enable and enforce (!) Checkstyle in Fineract
[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013860#comment-17013860 ] Yemdjih Kaze Nasser commented on FINERACT-821: -- Sure, I'm up for this > Enable and enforce (!) Checkstyle in Fineract > - > > Key: FINERACT-821 > URL: https://issues.apache.org/jira/browse/FINERACT-821 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Michael Vorburger >Assignee: Michael Vorburger >Priority: Major > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > as suggested in FINERACT-712, we really should enable Checkstyle in Fineract. > My past experience in such matters, confirmed by FINERACT-702, is that these > things only ever work and have a lasting effect if you bulk fix all > violations and switch on enforcement. If you only report, it's mostly useless. > As for specific Checkstyle rules, I have spent a fair amount of time in a > past life on a project (which I'm currently no longer actively invoved in) to > refine a what I believe to be "good" Checkstyle rule set, we could reuse this > for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-796) Use Hikari instead of Tomcat Connection Pool
[
https://issues.apache.org/jira/browse/FINERACT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985333#comment-16985333
]
Yemdjih Kaze Nasser commented on FINERACT-796:
--
I will check on this and make a pull request
> Use Hikari instead of Tomcat Connection Pool
>
>
> Key: FINERACT-796
> URL: https://issues.apache.org/jira/browse/FINERACT-796
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
>
> In [https://github.com/apache/fineract/pull/642] for FINERACT-724, ivan333m
> said:
> {quote}New version of spring-boot-starter-data-jpa uses HikariCP as default
> connection pool instead of tomcat-jdbc. So I need to add this dependency.
> Also I have excluded HikariCP in the latest commit.{quote}
> Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc
> default to HikariCP, and that e.g.
> https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database
> explicitly states:
> {quote}We prefer HikariCP for its performance and concurrency. If HikariCP is
> available, we always choose it. Otherwise, if the Tomcat pooling DataSource
> is available, we use it.{quote}
> I think we should eventually replace our use of the Tomcat JDBC Connection
> Pool with Hikari.
> I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a
> pre-req. to it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-797) Use Spring Boot BOM to avoid maintaining version numbers in dependencies.gradle
[
https://issues.apache.org/jira/browse/FINERACT-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985234#comment-16985234
]
Yemdjih Kaze Nasser commented on FINERACT-797:
--
Made a pull request for this.
> Use Spring Boot BOM to avoid maintaining version numbers in
> dependencies.gradle
> ---
>
> Key: FINERACT-797
> URL: https://issues.apache.org/jira/browse/FINERACT-797
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Michael Vorburger
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://github.com/apache/fineract/pull/642 for FINERACT-724, ivan333m and
> I discussed:
> {quote}In an ideal world, in a future PR, it would be really really cool if
> we could just avoid having to repeat using fixed version, and could use the
> implicit versions via Spring BOM dependency management, see
> https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#managing-dependencies
> ...{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976098#comment-16976098
]
Yemdjih Kaze Nasser commented on FINERACT-783:
--
[~vorburger] please can you review https://github.com/apache/fineract/pull/651
I ran into some issues.
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956150#comment-16956150
]
Yemdjih Kaze Nasser commented on FINERACT-783:
--
I have explored building deployments configuration files for both mysql and
fineract instance.
Fineract servicing does not run properly, still trying to figure that out.
Also, creating databases still need to be done manually. Still haven't figured
that out.
II was thinking maybe I should make a PR of what I.ve implemented to get better
guidance with this
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Priority: Major
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-783) Fineract on Kubernetes
[
https://issues.apache.org/jira/browse/FINERACT-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951654#comment-16951654
]
Yemdjih Kaze Nasser commented on FINERACT-783:
--
I would like to take this one
> Fineract on Kubernetes
> --
>
> Key: FINERACT-783
> URL: https://issues.apache.org/jira/browse/FINERACT-783
> Project: Apache Fineract
> Issue Type: New Feature
>Reporter: Michael Vorburger
>Priority: Major
>
> It would IMHO be useful if Fineract had a ready to roll out of the box
> working Kubernetes YAML, equivalent to [the
> docker-compose.yml|https://github.com/apache/fineract/blob/develop/docker-compose.yml].
> IMHO this should include the UI - req. this work going on in parallel:
> * https://github.com/openMF/community-app/issues/3106
> * https://github.com/openMF/community-app/pull/3107
> * https://github.com/openMF/community-app/issues/3112
>
> Let us focus on making it super easy for getting it up and running locally on
> [minikube|https://kubernetes.io/docs/setup/learning-environment/minikube/],
> first. Then we could look into running the same on a public cloud, such as
> GCP or Azure.
> Ideally, I imaging the README having a section proposing to simply:
> {noformat}minikube start
> kubectl apply -f mifos.yaml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
