[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1
[ https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146530#comment-17146530 ] Yemdjih Kaze Nasser commented on FINERACT-1022: --- Thanks [~ptuomola] for going ahead and dealing with this. That's really awesome. > Update ehcache: 2.10.6 to current 3.8.1 > --- > > Key: FINERACT-1022 > URL: https://issues.apache.org/jira/browse/FINERACT-1022 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Fix For: 1.4.0 > > > Update artifactory and version number -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1
[ https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146499#comment-17146499 ] Michael Vorburger commented on FINERACT-1022: - [~ptuomola] cool! Thanks, you're awesome... :D re. above, one could imagine have a Logback appender with a ring buffer keeping recent error logs, and a REST API to check if any... but that's a bit out there, and probably not really "worth it" today, for this project - we've got bigger fish to fry here? ;) Still just wanted to throw this out. [~kaze] would you like to review and (manually, I guess?) test https://github.com/apache/fineract/pull/1115 about this, and merge it if it's OK for you, and then close this issue? > Update ehcache: 2.10.6 to current 3.8.1 > --- > > Key: FINERACT-1022 > URL: https://issues.apache.org/jira/browse/FINERACT-1022 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Fix For: 1.4.0 > > > Update artifactory and version number -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1
[ https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146282#comment-17146282 ] Petri Tuomola commented on FINERACT-1022: - I've sent a PR that should fix this - looks like it required changes to a number of configuration files and also to dependencies. Also checked on the integrationTests for this: there's a test that turns on caching and turns it off. Unfortunately from client side it's not easy to see if that actually has had any effect. I've added a log error message to log if cache is turned on which has not been populated/configured - so going forward we should at least see an error in the logs. Ideally of course would be good to have the test fail if the cache is not configured / working - but not sure how to best achieve this from client side... > Update ehcache: 2.10.6 to current 3.8.1 > --- > > Key: FINERACT-1022 > URL: https://issues.apache.org/jira/browse/FINERACT-1022 > Project: Apache Fineract > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Fix For: 1.4.0 > > > Update artifactory and version number -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1
[ https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135605#comment-17135605 ] Michael Vorburger commented on FINERACT-1022: - > I suggest you revert this. I've resumed my work on EclipseLink but I'll > return to this later and redo the implementation with proper tests. https://github.com/apache/fineract/pull/1050 unfortunately no longer easily cleany reverts. Could we ask you to raise a PR to revert? (Or fix, if easier.) [~awasum] FYI > Update ehcache: 2.10.6 to current 3.8.1 > --- > > Key: FINERACT-1022 > URL: https://issues.apache.org/jira/browse/FINERACT-1022 > Project: Apache Fineract > Issue Type: Sub-task >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Fix For: 1.4.0 > > > Update artifactory and version number -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1
[ https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135455#comment-17135455 ] Yemdjih Kaze Nasser commented on FINERACT-1022: --- I suggest you revert this. I've resumed my work on EclipseLink but I'll return to this later and redo the implementation with proper tests. > Update ehcache: 2.10.6 to current 3.8.1 > --- > > Key: FINERACT-1022 > URL: https://issues.apache.org/jira/browse/FINERACT-1022 > Project: Apache Fineract > Issue Type: Sub-task >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Blocker > Fix For: 1.4.0 > > > Update artifactory and version number -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1
[ https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135109#comment-17135109 ] Michael Vorburger commented on FINERACT-1022: - [~ptuomola] and [~kaze] really sorry I've merged [https://github.com/apache/fineract/pull/1050] BEFORE I've read this here. What is concerning is that we appear to have 0 test coverage for the caching support in Fineract? That's not great, of course. I know relatively little about the details of that feature (I do remember it was built as part of GSOC in the past). Perhaps this issue is a natural opportunity to add test coverage (which should currently fail, based on above), and perhaps some basic Doc about it e.g. to the README? Even as little as that it exists, is disabled by default (apparently?), and a beginning of how to enable and configure it? Until then, shall we reverting that PR, if we fear that we completely broke the caching? Marking this Blocker until we've resolved this (either way). [~awasum] FYI. > Update ehcache: 2.10.6 to current 3.8.1 > --- > > Key: FINERACT-1022 > URL: https://issues.apache.org/jira/browse/FINERACT-1022 > Project: Apache Fineract > Issue Type: Sub-task >Affects Versions: 1.4.0 >Reporter: Yemdjih Kaze Nasser >Assignee: Yemdjih Kaze Nasser >Priority: Major > Fix For: 1.4.0 > > > Update artifactory and version number -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1022) Update ehcache: 2.10.6 to current 3.8.1
[
https://issues.apache.org/jira/browse/FINERACT-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134938#comment-17134938
]
Petri Tuomola commented on FINERACT-1022:
-
[~kaze] [~vorburger] - after this change merged in, I don't think the
ehcache.xml is valid. Looking at the documentation, it looks like the format
has changed, and at least Eclipse complains that our file is not compatible
with the new schema:
Invalid content was found starting with element 'defaultCache'. One of
'\{"http://www.ehcache.org/v3":service,
"http://www.ehcache.org/v3":default-serializers,
"http://www.ehcache.org/v3":default-copiers,
"http://www.ehcache.org/v3":persistence,
"http://www.ehcache.org/v3":thread-pools,
"http://www.ehcache.org/v3":event-dispatch,
"http://www.ehcache.org/v3":write-behind,
"http://www.ehcache.org/v3":heap-store, "http://www.ehcache.org/v3":disk-store,
"http://www.ehcache.org/v3":cache, "http://www.ehcache.org/v3":cache-template}'
is expected.
Attribute 'eternal' is not allowed to appear in element 'cache'.
Attribute 'maxEntriesLocalHeap' is not allowed to appear in element 'cache'.
Attribute 'name' is not allowed to appear in element 'cache'.
Attribute 'overflowToDisk' is not allowed to appear in element 'cache'.
Attribute 'alias' must appear on element 'cache'.
> Update ehcache: 2.10.6 to current 3.8.1
> ---
>
> Key: FINERACT-1022
> URL: https://issues.apache.org/jira/browse/FINERACT-1022
> Project: Apache Fineract
> Issue Type: Sub-task
>Affects Versions: 1.4.0
>Reporter: Yemdjih Kaze Nasser
>Assignee: Yemdjih Kaze Nasser
>Priority: Major
>
> Update artifactory and version number
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
