[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212801#comment-17212801 ] Aleksandar Vidakovic commented on FINERACT-1188: Alright, this looks much better. Full build with all artifacts is working, Eclipse project import works including immediate Gradle build execution and source directories are shown in Eclipse only under fineract-provider (as expected, because it's the only Java module); in my previous attempt source folders appeared both in the root project "fineract" and "fineract-provider" which was wrong. The Docker build is also working which I think was the in my previous attempt to run the final health tests successfully in Travis. Would be great if you guys could have a look at this, the diff is a lot easier to review this time. Thanks again. > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[
https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212752#comment-17212752
]
Aleksandar Vidakovic commented on FINERACT-1188:
[~ptuomola] [~vorburger]
Well, can't live in a world where I'm losing against a Gradle task ;) ... as I
said above there was an issue with the clean task, but the source of this is
not exactly what I described. I thought that the root project and
fineract-provider are somehow competing against each other. Turns out: the
shell script execution of the Gradle setup inside the build folder that was
created by the Swagger code generator is messing things up. I tried all kinds
of tricks to twist the clean task's arm, but I was doing it in the wrong place!
Turning off the code generator and not executing the generated Gradle file...
makes everything work. I got a hint about this issue when Spotless suddenly
showed rule violations in that generated code; just needed to exclude all
"build" folders; strange thing is why it worked before, because I think it
shouldn't have... single module or not doesn't really matter... the build
folder was not excluded before so Spotless should have complained, but it
didn't.
Another potential issue: having two buildscript sections doesn't seem to be a
good idea, so I moved it to the root build.gradle file. I think that was also
the reason why source folders would show up in Eclipse both in the root project
("fineract") and the child module ("fineract-provider"). Will test this again.
Anyway... looks like there's progress... only 3 files changed so far... should
be a lot easier to review too.
FYI
> README and other files are not covered by Spotless
> --
>
> Key: FINERACT-1188
> URL: https://issues.apache.org/jira/browse/FINERACT-1188
> Project: Apache Fineract
> Issue Type: Sub-task
>Reporter: Michael Vorburger
>Assignee: Aleksandar Vidakovic
>Priority: Major
>
> Would it be possible to extract JUST the work related to make README and
> other files are covered by Spotless from
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]
> and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and
> keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client,
> fineract-doc - is that possible?
> You could perhaps before that even make a PR #0 with JUST the trivial
> formatting changes itself which Spotbugs made once you change the layout, but
> without any build change - just send them first, separately - get that out of
> the way?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212602#comment-17212602 ] Aleksandar Vidakovic commented on FINERACT-1188: [~vorburger] Ok... I am currently trying this out from scratch with a brand new branch... and there are a couple of issues here: Having the build folder artificially set inside the project root (including twisting various plugins to point to that build folder) just doesn't work with multi-module (no idea why this was set like this anyway; the defaults usually work very well and I see no reason why a fineract-provider/build in the original code wouldn't have worked) So, the top-level is also a project (a simple one, but still); the "clean" task creates a concurrency issue, because child projects (fineract-provider) run their clean tasks in parallel. This is important, because plugins like the Swagger file generator "think" they've already created all necessary files (they did), but are unaware that the root project deleted the contents of the build folder (and all generated artifacts). I thought the solution for that is to just leave every module's build folder to itself (i.e. "fineract-provider/build" etc.), but there are still things failing... and I have a feeling it's because we have parts that are defined at root level and also in the build.gradle; I'm not talking about duplication (removed already), I get the impression that either this is done properly for everything (that can be defined on the top level) or we can chase these Heisenbugs for longer. Not sure how to proceed here best, but this micro-step approach is a bit debug intensive. If you want to give this a shot yourself then please go ahead; can't exclude that I'm missing something (maybe simple) here, but for now I will leave this aside and maybe have later a fresh start hopefully with another idea how to do this step by step. > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211383#comment-17211383 ] Aleksandar Vidakovic commented on FINERACT-1188: [~vorburger] Ok, here we go. PR is on the way and should be easy to review. The real changes are very minimal. You can build the project now both from the root folder and from fineract-provider. This means that nothing has changed for the devs while technically this is already a multi module project with only one module (when using the build.gradle in the root folder). > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1188) README and other files are not covered by Spotless
[ https://issues.apache.org/jira/browse/FINERACT-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211277#comment-17211277 ] Aleksandar Vidakovic commented on FINERACT-1188: [~vorburger] thanks for creating the sub-tasks. Ok, I see now how you intend to do this... fineract-provider would not be a module in this first step. Excellent. > README and other files are not covered by Spotless > -- > > Key: FINERACT-1188 > URL: https://issues.apache.org/jira/browse/FINERACT-1188 > Project: Apache Fineract > Issue Type: Sub-task >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > Would it be possible to extract JUST the work related to make README and > other files are covered by Spotless from > [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171] > and make that a PR #1? So JUST a small Gradle at the root for Spotbugs, and > keep fineract-provider as-is, not (yet) adding fineract-api, fineract-client, > fineract-doc - is that possible? > You could perhaps before that even make a PR #0 with JUST the trivial > formatting changes itself which Spotbugs made once you change the layout, but > without any build change - just send them first, separately - get that out of > the way? -- This message was sent by Atlassian Jira (v8.3.4#803005)
