[jira] [Commented] (FINERACT-1250) AuditIntegrationTest > auditShouldbeCreated() FAILED org.opentest4j.AssertionFailedError: More than one audit created ==> expected: <1> but was: <2>
[ https://issues.apache.org/jira/browse/FINERACT-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224520#comment-17224520 ] Michael Vorburger commented on FINERACT-1250: - > don't need these two commands anymore and could later merge them into one https://github.com/apache/fineract/pull/1489 > AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > --- > > Key: FINERACT-1250 > URL: https://issues.apache.org/jira/browse/FINERACT-1250 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Assignee: Aleksandar Vidakovic >Priority: Major > > https://travis-ci.org/github/apache/fineract/builds/740577217 for > https://github.com/apache/fineract/pull/1465 for FINERACT-1209 failed with: > {noformat}AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) > at > org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:542) > at > org.apache.fineract.integrationtests.common.AuditHelper.verifyOneAuditOnly(AuditHelper.java:74) > at > org.apache.fineract.integrationtests.AuditIntegrationTest.auditShouldbeCreated(AuditIntegrationTest.java:82){noformat} > This seems to be a new problem. I'm not sure if or it could be related to the > move of the tests in FINERACT-1209... but perhaps they e.g. run in a > different order now, so there is 1 Audit entry more? > [~aleks] is this something you would like to look into? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1250) AuditIntegrationTest > auditShouldbeCreated() FAILED org.opentest4j.AssertionFailedError: More than one audit created ==> expected: <1> but was: <2>
[ https://issues.apache.org/jira/browse/FINERACT-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224351#comment-17224351 ] Aleksandar Vidakovic commented on FINERACT-1250: [~vorburger] I think I found it... the problem was the Travis command line. There are 2 Gradle commands executed; the first is - I think - supposed to check that all rules (RAT, Spotless, license headers etc.) are applied and the second one was executing the integration test. Now that the integration tests are in their own module and are just defined as "normal" tests they get actually executed twice, because the first Gradle command also executes all unit tests (which includes the integration-tests module). I think I've fixed this by adding a "-x test" to the first command, just to keep the change as minimal as possible. But I'm sure we don't need these two commands anymore and could later merge them into one. Just FYI. > AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > --- > > Key: FINERACT-1250 > URL: https://issues.apache.org/jira/browse/FINERACT-1250 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > > https://travis-ci.org/github/apache/fineract/builds/740577217 for > https://github.com/apache/fineract/pull/1465 for FINERACT-1209 failed with: > {noformat}AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) > at > org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:542) > at > org.apache.fineract.integrationtests.common.AuditHelper.verifyOneAuditOnly(AuditHelper.java:74) > at > org.apache.fineract.integrationtests.AuditIntegrationTest.auditShouldbeCreated(AuditIntegrationTest.java:82){noformat} > This seems to be a new problem. I'm not sure if or it could be related to the > move of the tests in FINERACT-1209... but perhaps they e.g. run in a > different order now, so there is 1 Audit entry more? > [~aleks] is this something you would like to look into? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1250) AuditIntegrationTest > auditShouldbeCreated() FAILED org.opentest4j.AssertionFailedError: More than one audit created ==> expected: <1> but was: <2>
[ https://issues.apache.org/jira/browse/FINERACT-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224277#comment-17224277 ] Michael Vorburger commented on FINERACT-1250: - > I'll close and re-open it to get a 2nd build [~aleks] FYI https://travis-ci.org/github/apache/fineract/builds/740585929 also failed in the same test, so this is definitely not just flaky but broken in https://github.com/apache/fineract/pull/1465... > AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > --- > > Key: FINERACT-1250 > URL: https://issues.apache.org/jira/browse/FINERACT-1250 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > > https://travis-ci.org/github/apache/fineract/builds/740577217 for > https://github.com/apache/fineract/pull/1465 for FINERACT-1209 failed with: > {noformat}AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) > at > org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:542) > at > org.apache.fineract.integrationtests.common.AuditHelper.verifyOneAuditOnly(AuditHelper.java:74) > at > org.apache.fineract.integrationtests.AuditIntegrationTest.auditShouldbeCreated(AuditIntegrationTest.java:82){noformat} > This seems to be a new problem. I'm not sure if or it could be related to the > move of the tests in FINERACT-1209... but perhaps they e.g. run in a > different order now, so there is 1 Audit entry more? > [~aleks] is this something you would like to look into? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-1250) AuditIntegrationTest > auditShouldbeCreated() FAILED org.opentest4j.AssertionFailedError: More than one audit created ==> expected: <1> but was: <2>
[ https://issues.apache.org/jira/browse/FINERACT-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224249#comment-17224249 ] Michael Vorburger commented on FINERACT-1250: - > I'm not sure if or it could be related to the move FYI why I think it's actually related to the PR is because a trivial other change like https://github.com/apache/fineract/pull/1484 actually had a green build (see https://travis-ci.org/github/apache/fineract/builds/740541274) where all ITs passed. So unless it's just "flaky", this does seem to be caused by that PR.. I'll close and re-open it to get a 2nd build, but I suspect we'll see it still fail in the same way. > AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > --- > > Key: FINERACT-1250 > URL: https://issues.apache.org/jira/browse/FINERACT-1250 > Project: Apache Fineract > Issue Type: Bug >Reporter: Michael Vorburger >Priority: Major > > https://travis-ci.org/github/apache/fineract/builds/740577217 for > https://github.com/apache/fineract/pull/1465 for FINERACT-1209 failed with: > {noformat}AuditIntegrationTest > auditShouldbeCreated() FAILED > org.opentest4j.AssertionFailedError: More than one audit created ==> > expected: <1> but was: <2> > at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) > at > org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62) > at > org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150) > at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:542) > at > org.apache.fineract.integrationtests.common.AuditHelper.verifyOneAuditOnly(AuditHelper.java:74) > at > org.apache.fineract.integrationtests.AuditIntegrationTest.auditShouldbeCreated(AuditIntegrationTest.java:82){noformat} > This seems to be a new problem. I'm not sure if or it could be related to the > move of the tests in FINERACT-1209... but perhaps they e.g. run in a > different order now, so there is 1 Audit entry more? > [~aleks] is this something you would like to look into? -- This message was sent by Atlassian Jira (v8.3.4#803005)