[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111600#comment-17111600 ] Michael Vorburger commented on FINERACT-713: FINERACT-985 to measure integration test code coverage would be required first for more here. > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. Once the packages with low > code coverage have been identified, we could take the help of [~santoshmath] > to collect manual test cases covering these packages and go about automating > the same. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[
https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103547#comment-17103547
]
Michael Vorburger commented on FINERACT-713:
My personal view is that our priorities on this overall topic should be, in
order:
1. fix all EXISTING tests which we had to ignore, and close all issues around
FINERACT-850
2. carefully evaluate where adding more coverage adds most value - there's a
lot of code, covering some of it is more useful than other
3. figure out FINERACT-949 before copy/pasting ugly existing ITs
4. write new integration tests to drive up coverage, prioritized by step 2.
5. improve performance of existing sequential tests. Make a list of test
runtimes, analyze slowness causes. Some have sleeps, fix that by replacing with
Availability.
6. parallelize unrelated tests
The reason why 5./6. are at the end are because, for me, currently (with some
ignored, yes), {{./gradlew integrationTest}} now runs in just a few minutes,
far from the 23 minutes reported above.
> Improve code-coverage to at-least 50% and reduce execution time
> ---
>
> Key: FINERACT-713
> URL: https://issues.apache.org/jira/browse/FINERACT-713
> Project: Apache Fineract
> Issue Type: Improvement
>Reporter: Vishwas Babu A J
>Priority: Major
> Labels: gsoc2019
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> While Fineract has integration tests, they currently cover very limited
> scenarios and code coverage is very low.
> Enable gradle plugins to report the current code coverage and add new
> Integration tests to ensure that code coverage, esp in critical packages like
> loans, savings, and accounting is at-least 50%. Once the packages with low
> code coverage have been identified, we could take the help of [~santoshmath]
> to collect manual test cases covering these packages and go about automating
> the same.
> Also, the existing tests are run sequentially and take around 23 minutes to
> complete on [https://travis-ci.org/apache/fineract.] Along with improving
> code coverage, we would also have to determine which tests can be run in
> parallel and enable parallelization to ensure the total time taken is still
> reasonable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081689#comment-17081689 ] Awasum Yannick commented on FINERACT-713: - Key point in the description: the need to parallelize unrelated tests so they run abit faster. > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. Once the packages with low > code coverage have been identified, we could take the help of [~santoshmath] > to collect manual test cases covering these packages and go about automating > the same. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081687#comment-17081687 ] Awasum Yannick commented on FINERACT-713: - [~vorburger], then I can go ahead and close that issue. > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. Once the packages with low > code coverage have been identified, we could take the help of [~santoshmath] > to collect manual test cases covering these packages and go about automating > the same. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069475#comment-17069475 ] Michael Vorburger commented on FINERACT-713: To anyone reading along here ntoe that first sub-task FINERACT-725 to add Jacoco is now done. > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. Once the packages with low > code coverage have been identified, we could take the help of [~santoshmath] > to collect manual test cases covering these packages and go about automating > the same. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786385#comment-16786385 ] Anushka Shukla commented on FINERACT-713: - [~vishwasbabu] Thanks a lot! > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786332#comment-16786332 ] Vishwas Babu A J commented on FINERACT-713: --- [~anushkashukla] sure ! maybe you can get started with https://issues.apache.org/jira/browse/FINERACT-725 . Let us know what help you need. The best way to reach all developers working on Fineract would be on https://lists.apache.org/list.html?d...@fineract.apache.org > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FINERACT-713) Improve code-coverage to at-least 50% and reduce execution time
[ https://issues.apache.org/jira/browse/FINERACT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786027#comment-16786027 ] Anushka Shukla commented on FINERACT-713: - Hey! I am Anushka Shukla, an applicant of outreachy. I am a beginner, however, I want to contribute to this issue. Can someone help me. > Improve code-coverage to at-least 50% and reduce execution time > --- > > Key: FINERACT-713 > URL: https://issues.apache.org/jira/browse/FINERACT-713 > Project: Apache Fineract > Issue Type: Improvement >Reporter: Vishwas Babu A J >Priority: Major > Labels: gsoc2019 > Original Estimate: 336h > Remaining Estimate: 336h > > While Fineract has integration tests, they currently cover very limited > scenarios and code coverage is very low. > Enable gradle plugins to report the current code coverage and add new > Integration tests to ensure that code coverage, esp in critical packages like > loans, savings, and accounting is at-least 50%. > Also, the existing tests are run sequentially and take around 23 minutes to > complete on [https://travis-ci.org/apache/fineract.] Along with improving > code coverage, we would also have to determine which tests can be run in > parallel and enable parallelization to ensure the total time taken is still > reasonable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
