[jira] [Updated] (FINERACT-1201) Remove copy/paste between FileSystemContentRepository and S3ContentRepository
[
https://issues.apache.org/jira/browse/FINERACT-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandar Vidakovic updated FINERACT-1201:
---
Fix Version/s: 3.0.0
> Remove copy/paste between FileSystemContentRepository and S3ContentRepository
> -
>
> Key: FINERACT-1201
> URL: https://issues.apache.org/jira/browse/FINERACT-1201
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 3.0.0
>
>
> While looking into FINERACT-955, I have found that a lot of the code between
> the {{FileSystemContentRepository}} and the {{S3ContentRepository}} appear to
> very similar.. historically most likely copy/pasted from one to the other.
> There are also some subtle differences e.g. {{FileSystemContentRepository}}
> does not seem to invoke
> {{ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(),
> fileName);}} like {{S3ContentRepository}}. I suspect that probably was not
> intentional?
> Before implementing FINERACT-955, I'll attempt to remove this copy/paste and
> unify those two implementations of {{ContentRepository}}.
> I'll do this in 2 steps: 1. just move some lines, and add some missig lines,
> to make them "look" more similar; 2. actually merge their code by refactoring
> into a common abstract super classes or utilities for composition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (FINERACT-1201) Remove copy/paste between FileSystemContentRepository and S3ContentRepository
[
https://issues.apache.org/jira/browse/FINERACT-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1201:
Fix Version/s: (was: 1.5.0)
> Remove copy/paste between FileSystemContentRepository and S3ContentRepository
> -
>
> Key: FINERACT-1201
> URL: https://issues.apache.org/jira/browse/FINERACT-1201
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
>
> While looking into FINERACT-955, I have found that a lot of the code between
> the {{FileSystemContentRepository}} and the {{S3ContentRepository}} appear to
> very similar.. historically most likely copy/pasted from one to the other.
> There are also some subtle differences e.g. {{FileSystemContentRepository}}
> does not seem to invoke
> {{ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(),
> fileName);}} like {{S3ContentRepository}}. I suspect that probably was not
> intentional?
> Before implementing FINERACT-955, I'll attempt to remove this copy/paste and
> unify those two implementations of {{ContentRepository}}.
> I'll do this in 2 steps: 1. just move some lines, and add some missig lines,
> to make them "look" more similar; 2. actually merge their code by refactoring
> into a common abstract super classes or utilities for composition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-1201) Remove copy/paste between FileSystemContentRepository and S3ContentRepository
[
https://issues.apache.org/jira/browse/FINERACT-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1201:
Description:
While looking into FINERACT-955, I have found that a lot of the code between
the {{FileSystemContentRepository}} and the {{S3ContentRepository}} appear to
very similar.. historically most likely copy/pasted from one to the other.
There are also some subtle differences e.g. {{FileSystemContentRepository}}
does not seem to invoke
{{ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(),
fileName);}} like {{S3ContentRepository}}. I suspect that probably was not
intentional?
Before implementing FINERACT-955, I'll attempt to remove this copy/paste and
unify those two implementations of {{ContentRepository}}.
I'll do this in 2 steps: 1. just move some lines, and add some missig lines, to
make them "look" more similar; 2. actually merge their code by refactoring into
a common abstract super classes or utilities for composition.
was:
While looking into FINERACT-955, I have found that a lot of the code between
the {{FileSystemContentRepository}} and the {{S3ContentRepository}} appear to
very similar.. historically most likely copy/pasted from one to the other.
There are also some subtle differences e.g. {{FileSystemContentRepository}}
does not seem to invoke
{{ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(),
fileName);}} like {{S3ContentRepository}}. I suspect that probably was not
intentional?
Before implementing FINERACT-955, I'll attempt to remove this copy/paste and
unify those two implementations of {{ContentRepository}}.
I'll do this in 2 steps: 1. just move some lines, and add some missig lines, to
make them "look" more similar; 2. actually merge their merge by refactoring
into a common abstract super class.
> Remove copy/paste between FileSystemContentRepository and S3ContentRepository
> -
>
> Key: FINERACT-1201
> URL: https://issues.apache.org/jira/browse/FINERACT-1201
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.5.0
>
>
> While looking into FINERACT-955, I have found that a lot of the code between
> the {{FileSystemContentRepository}} and the {{S3ContentRepository}} appear to
> very similar.. historically most likely copy/pasted from one to the other.
> There are also some subtle differences e.g. {{FileSystemContentRepository}}
> does not seem to invoke
> {{ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(),
> fileName);}} like {{S3ContentRepository}}. I suspect that probably was not
> intentional?
> Before implementing FINERACT-955, I'll attempt to remove this copy/paste and
> unify those two implementations of {{ContentRepository}}.
> I'll do this in 2 steps: 1. just move some lines, and add some missig lines,
> to make them "look" more similar; 2. actually merge their code by refactoring
> into a common abstract super classes or utilities for composition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
