[jira] [Updated] (FINERACT-891) ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)
[
https://issues.apache.org/jira/browse/FINERACT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-891:
---
Fix Version/s: (was: 1.5.0)
> ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH
> >= 22)
> --
>
> Key: FINERACT-891
> URL: https://issues.apache.org/jira/browse/FINERACT-891
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Trivial
>
> while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed
> that in it has x2 Dead Code due to {{if (Calendar.DAY_OF_MONTH >= 22)}} ...
> that will always be false. I'm guessing that has was meant to check ... I'm
> not sure, presumably the transactionDate? That doesn't really make much sense
> either, as that's hard-coded to {{transactionDate.set(Calendar.DAY_OF_MONTH,
> 22);}} just 2 lines above.
> Someone who better understands what that test does should probably review it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-891) ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)
[
https://issues.apache.org/jira/browse/FINERACT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-891:
---
Labels: beginner (was: )
> ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH
> >= 22)
> --
>
> Key: FINERACT-891
> URL: https://issues.apache.org/jira/browse/FINERACT-891
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Trivial
> Labels: beginner
>
> while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed
> that in it has x2 Dead Code due to {{if (Calendar.DAY_OF_MONTH >= 22)}} ...
> that will always be false. I'm guessing that has was meant to check ... I'm
> not sure, presumably the transactionDate? That doesn't really make much sense
> either, as that's hard-coded to {{transactionDate.set(Calendar.DAY_OF_MONTH,
> 22);}} just 2 lines above.
> Someone who better understands what that test does should probably review it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-891) ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)
[
https://issues.apache.org/jira/browse/FINERACT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandar Vidakovic updated FINERACT-891:
--
Fix Version/s: (was: 1.4.0)
1.5.0
> ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH
> >= 22)
> --
>
> Key: FINERACT-891
> URL: https://issues.apache.org/jira/browse/FINERACT-891
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Priority: Trivial
> Fix For: 1.5.0
>
>
> while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed
> that in it has x2 Dead Code due to {{if (Calendar.DAY_OF_MONTH >= 22)}} ...
> that will always be false. I'm guessing that has was meant to check ... I'm
> not sure, presumably the transactionDate? That doesn't really make much sense
> either, as that's hard-coded to {{transactionDate.set(Calendar.DAY_OF_MONTH,
> 22);}} just 2 lines above.
> Someone who better understands what that test does should probably review it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-891) ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)
[
https://issues.apache.org/jira/browse/FINERACT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-891:
---
Priority: Trivial (was: Major)
> ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH
> >= 22)
> --
>
> Key: FINERACT-891
> URL: https://issues.apache.org/jira/browse/FINERACT-891
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Trivial
> Fix For: 1.4.0
>
>
> while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed
> that in it has x2 Dead Code due to {{if (Calendar.DAY_OF_MONTH >= 22)}} ...
> that will always be false. I'm guessing that has was meant to check ... I'm
> not sure, presumably the transactionDate? That doesn't really make much sense
> either, as that's hard-coded to {{transactionDate.set(Calendar.DAY_OF_MONTH,
> 22);}} just 2 lines above.
> Someone who better understands what that test does should probably review it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FINERACT-891) ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH >= 22)
[
https://issues.apache.org/jira/browse/FINERACT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-891:
---
Fix Version/s: 1.4.0
> ClientSavingsIntegrationTest has Dead Code due to if (Calendar.DAY_OF_MONTH
> >= 22)
> --
>
> Key: FINERACT-891
> URL: https://issues.apache.org/jira/browse/FINERACT-891
> Project: Apache Fineract
> Issue Type: Bug
>Reporter: Michael Vorburger
>Assignee: Michael Vorburger
>Priority: Major
> Fix For: 1.4.0
>
>
> while staring at ClientSavingsIntegrationTest for FINERACT-852, I noticed
> that in it has x2 Dead Code due to {{if (Calendar.DAY_OF_MONTH >= 22)}} ...
> that will always be false. I'm guessing that has was meant to check ... I'm
> not sure, presumably the transactionDate? That doesn't really make much sense
> either, as that's hard-coded to {{transactionDate.set(Calendar.DAY_OF_MONTH,
> 22);}} just 2 lines above.
> Someone who better understands what that test does should probably review it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
