[GitHub] flink pull request #2877: [FLINK-5141] Implement Flip6LocalStreamEnvironment...

[ifndef-SleePy]

GitHub user ifndef-SleePy opened a pull request:

https://github.com/apache/flink/pull/2877

[FLINK-5141] Implement Flip6LocalStreamEnvironment to run new mini cluster 
in flip-6 branch

Implement a StreamEnvironment to run flip-6 mini cluster. According to 
Till's suggestion, I named it Flip6LocalStreamEnvironment for this moment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alibaba/flink jira-5141

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2877.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2877


commit 1ed9ea9a929d1000e46687912b23b715931bb384
Author: biao.liub 
Date:   2016-11-23T09:02:11Z

[FLINK-5141] Implement MiniClusterStreamEnvironment for new mini
cluster.

commit cca637ea1a3bee82802dbd237c7fc4b8d4bdee84
Author: biao.liub 
Date:   2016-11-24T10:38:50Z

[FLINK-5141] Rename MiniClusterStreamEnvironment to 
Flip6LocalStreamEnvironment.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-5141) Implement Flip6LocalStreamEnvironment to run new mini cluster in flip-6 branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701245#comment-15701245
 ] 

ASF GitHub Bot commented on FLINK-5141:
---

GitHub user ifndef-SleePy opened a pull request:

https://github.com/apache/flink/pull/2877

[FLINK-5141] Implement Flip6LocalStreamEnvironment to run new mini cluster 
in flip-6 branch

Implement a StreamEnvironment to run flip-6 mini cluster. According to 
Till's suggestion, I named it Flip6LocalStreamEnvironment for this moment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alibaba/flink jira-5141

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2877.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2877


commit 1ed9ea9a929d1000e46687912b23b715931bb384
Author: biao.liub 
Date:   2016-11-23T09:02:11Z

[FLINK-5141] Implement MiniClusterStreamEnvironment for new mini
cluster.

commit cca637ea1a3bee82802dbd237c7fc4b8d4bdee84
Author: biao.liub 
Date:   2016-11-24T10:38:50Z

[FLINK-5141] Rename MiniClusterStreamEnvironment to 
Flip6LocalStreamEnvironment.




> Implement Flip6LocalStreamEnvironment to run new mini cluster in flip-6 branch
> --
>
> Key: FLINK-5141
> URL: https://issues.apache.org/jira/browse/FLINK-5141
> Project: Flink
>  Issue Type: Task
>  Components: Cluster Management
> Environment: FLIP-6 feature branch
>Reporter: Biao Liu
>Assignee: Biao Liu
>Priority: Minor
>
> MiniCluster need a new data stream environment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FLINK-5141) Implement Flip6LocalStreamEnvironment to run new mini cluster in flip-6 branch

[Biao Liu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-5141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Liu updated FLINK-5141:

Summary: Implement Flip6LocalStreamEnvironment to run new mini cluster in 
flip-6 branch  (was: Implement MiniClusterStreamEnvironment to run new mini 
cluster in flip-6 branch)

> Implement Flip6LocalStreamEnvironment to run new mini cluster in flip-6 branch
> --
>
> Key: FLINK-5141
> URL: https://issues.apache.org/jira/browse/FLINK-5141
> Project: Flink
>  Issue Type: Task
>  Components: Cluster Management
> Environment: FLIP-6 feature branch
>Reporter: Biao Liu
>Assignee: Biao Liu
>Priority: Minor
>
> MiniCluster need a new data stream environment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5166) TextInputFormatTest.testNestedFileRead

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699759#comment-15699759
 ] 

ASF GitHub Bot commented on FLINK-5166:
---

Github user shijinkui commented on the issue:

https://github.com/apache/flink/pull/2876
  
> The test should be changed to use more specific folder names including a 
random component. If the directory we are trying to create already exists we 
should not delete everything there (since we can't guarantee that we created 
those files), but instead try a different directory.

@zentol That's file. Also delete the tmp dir when exist.


> TextInputFormatTest.testNestedFileRead
> --
>
> Key: FLINK-5166
> URL: https://issues.apache.org/jira/browse/FLINK-5166
> Project: Flink
>  Issue Type: Bug
>  Components: Batch Connectors and Input/Output Formats, Tests
>Reporter: shijinkui
>
> `mvn clean package -P \!scala-2.11,scala-2.11  -U`
> Failed tests:
>   TextInputFormatTest.testNestedFileRead:140 Test erroneous
> Tests run: 846, Failures: 1, Errors: 0, Skipped: 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] flink issue #2876: [FLINK-5166] TextInputFormatTest.testNestedFileRead

[shijinkui]

Github user shijinkui commented on the issue:

https://github.com/apache/flink/pull/2876
  
> The test should be changed to use more specific folder names including a 
random component. If the directory we are trying to create already exists we 
should not delete everything there (since we can't guarantee that we created 
those files), but instead try a different directory.

@zentol That's file. Also delete the tmp dir when exist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2843: FLINK-4798] CEPITCase.testSimpleKeyedPatternCEP te...

[zentol]

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2843#discussion_r89689538
  
--- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
@@ -361,17 +351,18 @@ public String select(Map pattern) {
}
);
 
-   result.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE);
+   result.addSink(resultSink);
--- End diff --

How about using `DataStreamUtils#collect()` here? Then we wouldn't need to 
move that sink class around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-4798) CEPITCase.testSimpleKeyedPatternCEP test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699643#comment-15699643
 ] 

ASF GitHub Bot commented on FLINK-4798:
---

Github user zentol commented on a diff in the pull request:

https://github.com/apache/flink/pull/2843#discussion_r89689538
  
--- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
@@ -361,17 +351,18 @@ public String select(Map pattern) {
}
);
 
-   result.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE);
+   result.addSink(resultSink);
--- End diff --

How about using `DataStreamUtils#collect()` here? Then we wouldn't need to 
move that sink class around.


> CEPITCase.testSimpleKeyedPatternCEP test failure
> 
>
> Key: FLINK-4798
> URL: https://issues.apache.org/jira/browse/FLINK-4798
> Project: Flink
>  Issue Type: Bug
>  Components: CEP
>Affects Versions: 1.2.0
>Reporter: Robert Metzger
>Assignee: Boris Osipov
>  Labels: test-stability
>
> {code}
> ---
>  T E S T S
> ---
> Running org.apache.flink.cep.CEPITCase
> Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.627 sec <<< 
> FAILURE! - in org.apache.flink.cep.CEPITCase
> testSimpleKeyedPatternCEP(org.apache.flink.cep.CEPITCase)  Time elapsed: 
> 0.312 sec  <<< FAILURE!
> java.lang.AssertionError: Different number of lines in expected and obtained 
> result. expected:<3> but was:<1>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:645)
>   at 
> org.apache.flink.test.util.TestBaseUtils.compareResultsByLinesInMemory(TestBaseUtils.java:316)
>   at 
> org.apache.flink.test.util.TestBaseUtils.compareResultsByLinesInMemory(TestBaseUtils.java:302)
>   at org.apache.flink.cep.CEPITCase.after(CEPITCase.java:61)
> {code}
> in https://api.travis-ci.org/jobs/166676733/log.txt?deansi=true



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] flink pull request #2845: [FLINK-5096] Make the RollingSink rescalable.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2845


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-5096) Make the RollingSink rescalable.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699567#comment-15699567
 ] 

ASF GitHub Bot commented on FLINK-5096:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2845


> Make the RollingSink rescalable.
> 
>
> Key: FLINK-5096
> URL: https://issues.apache.org/jira/browse/FLINK-5096
> Project: Flink
>  Issue Type: Improvement
>  Components: filesystem-connector
>Reporter: Kostas Kloudas
>Assignee: Kostas Kloudas
> Fix For: 1.2.0
>
>
> Integrate the RollingSink with the new state abstractions so that its 
> parallelism can change after restoring from a savepoint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-5112) Remove unused accumulator code from ArchivedExecutionJobVertex

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699569#comment-15699569
 ] 

ASF GitHub Bot commented on FLINK-5112:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2846


> Remove unused accumulator code from ArchivedExecutionJobVertex
> --
>
> Key: FLINK-5112
> URL: https://issues.apache.org/jira/browse/FLINK-5112
> Project: Flink
>  Issue Type: Bug
>  Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{ArchivedExecutionJobVertex}} computes upon creation the value for the 
> accumulators of the associated {{ExecutionVertices}}. This value is, however, 
> nowhere stored. This indicates that it is a legacy artifact and I propose to 
> remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] flink pull request #2852: Fix misprint in condition

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2852


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (FLINK-5112) Remove unused accumulator code from ArchivedExecutionJobVertex

[Chesnay Schepler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chesnay Schepler closed FLINK-5112.
---
Resolution: Fixed

Fixed in 2eacfba280d80434b61e0bd0c840b158923b416d

> Remove unused accumulator code from ArchivedExecutionJobVertex
> --
>
> Key: FLINK-5112
> URL: https://issues.apache.org/jira/browse/FLINK-5112
> Project: Flink
>  Issue Type: Bug
>  Components: Distributed Coordination
>Affects Versions: 1.2.0
>Reporter: Till Rohrmann
>Assignee: Till Rohrmann
>Priority: Minor
> Fix For: 1.2.0
>
>
> The {{ArchivedExecutionJobVertex}} computes upon creation the value for the 
> accumulators of the associated {{ExecutionVertices}}. This value is, however, 
> nowhere stored. This indicates that it is a legacy artifact and I propose to 
> remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] flink pull request #2846: [FLINK-5112] [ExecutionGraph] Remove unused accumu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2846


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (FLINK-4741) WebRuntimeMonitor does not shut down all of it's threads (EventLoopGroups) on exit.

[Chesnay Schepler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chesnay Schepler closed FLINK-4741.
---
   Resolution: Fixed
Fix Version/s: 1.2.0

Fixed in 333da3ac8f8b05c3e3194ba0b376300b403bc2c8

> WebRuntimeMonitor does not shut down all of it's threads (EventLoopGroups) on 
> exit.
> ---
>
> Key: FLINK-4741
> URL: https://issues.apache.org/jira/browse/FLINK-4741
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Affects Versions: 1.1.2
>Reporter: Joseph Sims
>Assignee: Roman Maier
>Priority: Minor
> Fix For: 1.2.0
>
>
> WebRuntimeMonitor does not shutdown correctly, causing the overall 
> application to hang on shutdown. It shuts down bootstrap.group 
> (EventLoopGroup) but not the bootstrap.childGroup (EventLoopGroup).
> If WebRuntimeMonitor is not used (local.start-webserver=false), this problem 
> does not occur.
> Class: WebRuntimeMonitor
> method: stop()
> Line: ~387
> Called:
> bootstrap.group().shutdownGracefully()
> Not called:
> bootstrap.childGroup().shutdownGracefully()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] flink pull request #2862: [FLINK-4741] Fix for the proper shutdown the Serve...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2862


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (FLINK-4741) WebRuntimeMonitor does not shut down all of it's threads (EventLoopGroups) on exit.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699568#comment-15699568
 ] 

ASF GitHub Bot commented on FLINK-4741:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/2862


> WebRuntimeMonitor does not shut down all of it's threads (EventLoopGroups) on 
> exit.
> ---
>
> Key: FLINK-4741
> URL: https://issues.apache.org/jira/browse/FLINK-4741
> Project: Flink
>  Issue Type: Bug
>  Components: Webfrontend
>Affects Versions: 1.1.2
>Reporter: Joseph Sims
>Assignee: Roman Maier
>Priority: Minor
> Fix For: 1.2.0
>
>
> WebRuntimeMonitor does not shutdown correctly, causing the overall 
> application to hang on shutdown. It shuts down bootstrap.group 
> (EventLoopGroup) but not the bootstrap.childGroup (EventLoopGroup).
> If WebRuntimeMonitor is not used (local.start-webserver=false), this problem 
> does not occur.
> Class: WebRuntimeMonitor
> method: stop()
> Line: ~387
> Called:
> bootstrap.group().shutdownGracefully()
> Not called:
> bootstrap.childGroup().shutdownGracefully()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (FLINK-5096) Make the RollingSink rescalable.

[Chesnay Schepler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FLINK-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chesnay Schepler closed FLINK-5096.
---
Resolution: Fixed

Implemented in e2b93f69cea0c8a8d05591285cb9c2f4dc64c619

> Make the RollingSink rescalable.
> 
>
> Key: FLINK-5096
> URL: https://issues.apache.org/jira/browse/FLINK-5096
> Project: Flink
>  Issue Type: Improvement
>  Components: filesystem-connector
>Reporter: Kostas Kloudas
>Assignee: Kostas Kloudas
> Fix For: 1.2.0
>
>
> Integrate the RollingSink with the new state abstractions so that its 
> parallelism can change after restoring from a savepoint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)