[jira] [Commented] (FLINK-5426) Clean up the Flink Machine Learning library
[
https://issues.apache.org/jira/browse/FLINK-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15808074#comment-15808074
]
ASF GitHub Bot commented on FLINK-5426:
---
GitHub user Fokko opened a pull request:
https://github.com/apache/flink/pull/3081
[FLINK-5426] Clean up the Flink Machine Learning library
Hi guys,
I would like to contribute to the Flink ML library. I took the liberty to
clean up some of the code and improve the scaladoc. Beside that I've
implemented #3077 to get more familiar with the Flink API and I would love to
contribute more in the future, in particular the machine learning library.
If you have any questions, please let me know. Let me know if improvements
to the ML library are appreciated in general.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fokko/flink fd-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3081
commit 013b22d7bcaf48c8e96983295fcc455faf0aa94b
Author: Fokko Driesprong
Date: 2017-01-06T20:34:53Z
Removed duplicate tests, inproved scaladoc and naming, removed typo's in
scaladoc, introduced and improved use of constants, improved test-case naming.
> Clean up the Flink Machine Learning library
> ---
>
> Key: FLINK-5426
> URL: https://issues.apache.org/jira/browse/FLINK-5426
> Project: Flink
> Issue Type: Improvement
> Components: Machine Learning Library
>Reporter: Fokko Driesprong
>
> Hi Guys,
> I would like to clean up the Machine Learning library. A lot of the code in
> the ML Library does not conform to the original contribution guide. For
> example:
> Duplicate tests, different names, but exactly the same testcase:
> https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/DenseVectorSuite.scala#L148
> https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/DenseVectorSuite.scala#L164
> Lot of multi-line tests-cases:
> https://github.com/Fokko/flink/blob/master/flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/DenseVectorSuite.scala
> Mis-use of constants:
> https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseMatrix.scala#L58
> Please allow me to clean this up, and I'm looking forward to contribute more
> code, especially to the ML part. I've have been a contributor to Apache Spark
> and am happy to extend the codebase with new distributed algorithms and make
> the codebase more mature.
> Cheers, Fokko
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] flink pull request #3081: [FLINK-5426] Clean up the Flink Machine Learning l...
GitHub user Fokko opened a pull request:
https://github.com/apache/flink/pull/3081
[FLINK-5426] Clean up the Flink Machine Learning library
Hi guys,
I would like to contribute to the Flink ML library. I took the liberty to
clean up some of the code and improve the scaladoc. Beside that I've
implemented #3077 to get more familiar with the Flink API and I would love to
contribute more in the future, in particular the machine learning library.
If you have any questions, please let me know. Let me know if improvements
to the ML library are appreciated in general.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fokko/flink fd-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3081
commit 013b22d7bcaf48c8e96983295fcc455faf0aa94b
Author: Fokko Driesprong
Date: 2017-01-06T20:34:53Z
Removed duplicate tests, inproved scaladoc and naming, removed typo's in
scaladoc, introduced and improved use of constants, improved test-case naming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Created] (FLINK-5426) Clean up the Flink Machine Learning library
Fokko Driesprong created FLINK-5426: --- Summary: Clean up the Flink Machine Learning library Key: FLINK-5426 URL: https://issues.apache.org/jira/browse/FLINK-5426 Project: Flink Issue Type: Improvement Components: Machine Learning Library Reporter: Fokko Driesprong Hi Guys, I would like to clean up the Machine Learning library. A lot of the code in the ML Library does not conform to the original contribution guide. For example: Duplicate tests, different names, but exactly the same testcase: https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/DenseVectorSuite.scala#L148 https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/DenseVectorSuite.scala#L164 Lot of multi-line tests-cases: https://github.com/Fokko/flink/blob/master/flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/math/DenseVectorSuite.scala Mis-use of constants: https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/DenseMatrix.scala#L58 Please allow me to clean this up, and I'm looking forward to contribute more code, especially to the ML part. I've have been a contributor to Apache Spark and am happy to extend the codebase with new distributed algorithms and make the codebase more mature. Cheers, Fokko -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4692) Add tumbling group-windows for batch tables
[ https://issues.apache.org/jira/browse/FLINK-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807587#comment-15807587 ] ASF GitHub Bot commented on FLINK-4692: --- Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2938 Hi @twalthr , I have tested and the batch and stream queries return the same result in my machine. The `org.apache.flink.api.scala.stream.table.AggregationsITCase#testEventTimeTumblingWindow` and `org.apache.flink.api.scala.batch.table.AggregationsITCase#testEventTimeTumblingGroupWindowOverTime` have different result because of the different input data. If change batch input data to the same stream input data, they will return the same result. Is that the issue you confusing ? BTW, I have rebased the code and fixed the conflicts. > Add tumbling group-windows for batch tables > --- > > Key: FLINK-4692 > URL: https://issues.apache.org/jira/browse/FLINK-4692 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL >Reporter: Timo Walther >Assignee: Jark Wu > > Add Tumble group-windows for batch tables as described in > [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations]. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] flink issue #2938: [FLINK-4692] [tableApi] Add tumbling group-windows for ba...
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2938 Hi @twalthr , I have tested and the batch and stream queries return the same result in my machine. The `org.apache.flink.api.scala.stream.table.AggregationsITCase#testEventTimeTumblingWindow` and `org.apache.flink.api.scala.batch.table.AggregationsITCase#testEventTimeTumblingGroupWindowOverTime` have different result because of the different input data. If change batch input data to the same stream input data, they will return the same result. Is that the issue you confusing ? BTW, I have rebased the code and fixed the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-4920) Add a Scala Function Gauge
[
https://issues.apache.org/jira/browse/FLINK-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807485#comment-15807485
]
ASF GitHub Bot commented on FLINK-4920:
---
GitHub user heytitle opened a pull request:
https://github.com/apache/flink/pull/3080
[FLINK-4920] Add a Scala Function Gauge
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build [](https://travis-ci.org/heytitle/flink)
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/heytitle/flink scala-gauge
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3080
commit 1a464e2b74930c63aada3dbae40b74822ccea89c
Author: heytitle
Date: 2016-12-27T22:21:19Z
[FLINK-4920] Introduce Scala Function Gauge
commit aa9b7bb435e97687a8d69820579bddf41b1b29a4
Author: heytitle
Date: 2017-01-07T10:30:40Z
[FLINK-4920] Update gauge document
> Add a Scala Function Gauge
> --
>
> Key: FLINK-4920
> URL: https://issues.apache.org/jira/browse/FLINK-4920
> Project: Flink
> Issue Type: Improvement
> Components: Metrics, Scala API
>Reporter: Stephan Ewen
>Assignee: Pattarawat Chormai
> Labels: easyfix, starter
>
> A useful metrics utility for the Scala API would be to add a Gauge that
> obtains its value by calling a Scala Function0.
> That way, one can add Gauges in Scala programs using Scala lambda notation or
> function references.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] flink pull request #3080: [FLINK-4920] Add a Scala Function Gauge
GitHub user heytitle opened a pull request:
https://github.com/apache/flink/pull/3080
[FLINK-4920] Add a Scala Function Gauge
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build [](https://travis-ci.org/heytitle/flink)
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/heytitle/flink scala-gauge
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3080
commit 1a464e2b74930c63aada3dbae40b74822ccea89c
Author: heytitle
Date: 2016-12-27T22:21:19Z
[FLINK-4920] Introduce Scala Function Gauge
commit aa9b7bb435e97687a8d69820579bddf41b1b29a4
Author: heytitle
Date: 2017-01-07T10:30:40Z
[FLINK-4920] Update gauge document
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
