[jira] [Commented] (FLINK-8756) Support ClusterClient.getAccumulators() in RestClusterClient
[ https://issues.apache.org/jira/browse/FLINK-8756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375922#comment-16375922 ] ASF GitHub Bot commented on FLINK-8756: --- Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5573 HI @tillrohrmann and @aljoscha , who would review this PR? Thanks! > Support ClusterClient.getAccumulators() in RestClusterClient > > > Key: FLINK-8756 > URL: https://issues.apache.org/jira/browse/FLINK-8756 > Project: Flink > Issue Type: Improvement > Components: Client >Affects Versions: 1.5.0 >Reporter: Aljoscha Krettek >Assignee: vinoyang >Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink issue #5573: [FLINK-8756][Client] Support ClusterClient.getAccumulator...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/5573 HI @tillrohrmann and @aljoscha , who would review this PR? Thanks! ---
[jira] [Commented] (FLINK-8690) Update logical rule set to generate FlinkLogicalAggregate explicitly allow distinct agg on DataStream
[ https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375920#comment-16375920 ] Hequn Cheng commented on FLINK-8690: Hi, currently, {{FlinkLogicalWindowAggregate}} doesn't support distinct aggregate either. Distinct aggregates are filtered in \{{LogicalWindowAggregateRule}}, so this issue should also take it into consideration. > Update logical rule set to generate FlinkLogicalAggregate explicitly allow > distinct agg on DataStream > - > > Key: FLINK-8690 > URL: https://issues.apache.org/jira/browse/FLINK-8690 > Project: Flink > Issue Type: Sub-task >Reporter: Rong Rong >Assignee: Rong Rong >Priority: Major > > **Currently, *FlinkLogicalAggregate* does not allow distinct aggregate. > We are proposing to reuse distinct aggregate codegen work designed for > *FlinkLogicalOverAggregate* / *FlinkLogicalWindowAggregate*, to support > unbounded distinct aggregation on datastream as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FLINK-8661) Replace Collections.EMPTY_MAP with Collections.emptyMap()
[ https://issues.apache.org/jira/browse/FLINK-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8661: -- Description: The use of Collections.EMPTY_SET and Collections.EMPTY_MAP often causes unchecked assignment and it should be replaced with Collections.emptySet() and Collections.emptyMap() . (was: The use of Collections.EMPTY_SET and Collections.EMPTY_MAP often causes unchecked assignment and it should be replaced with Collections.emptySet() and Collections.emptyMap()) > Replace Collections.EMPTY_MAP with Collections.emptyMap() > - > > Key: FLINK-8661 > URL: https://issues.apache.org/jira/browse/FLINK-8661 > Project: Flink > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > > The use of Collections.EMPTY_SET and Collections.EMPTY_MAP often causes > unchecked assignment and it should be replaced with Collections.emptySet() > and Collections.emptyMap() . -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock
[ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8687: -- Description: Currently MaterializedCollectStreamResult#retrievePage checks page range and calls snapshot.subList() without holding resultLock. {{resultLock}} should be taken. was: Currently MaterializedCollectStreamResult#retrievePage checks page range and calls snapshot.subList() without holding resultLock. resultLock should be taken. > MaterializedCollectStreamResult#retrievePage should take resultLock > --- > > Key: FLINK-8687 > URL: https://issues.apache.org/jira/browse/FLINK-8687 > Project: Flink > Issue Type: Bug >Reporter: Ted Yu >Priority: Minor > > Currently MaterializedCollectStreamResult#retrievePage checks page range and > calls snapshot.subList() without holding resultLock. > {{resultLock}} should be taken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8660) Enable the user to provide custom HAServices implementation
[ https://issues.apache.org/jira/browse/FLINK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375750#comment-16375750 ] ASF GitHub Bot commented on FLINK-8660: --- Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5530 You could rebase on the latest master and force push to retrigger the build. > Enable the user to provide custom HAServices implementation > > > Key: FLINK-8660 > URL: https://issues.apache.org/jira/browse/FLINK-8660 > Project: Flink > Issue Type: Improvement > Components: Cluster Management, Configuration, Distributed > Coordination >Affects Versions: 1.4.0, 1.5.0 >Reporter: Krzysztof Białek >Priority: Major > Fix For: 1.6.0 > > > At the moment Flink uses ZooKeeper as HA backend. > The goal of this improvement is to make Flink supporting more HA backends, > also maintained as independent projects. > The following changes are required to achieve it: > # Add {{HighAvailabilityServicesFactory}} interface > # Add new option {{HighAvailabilityMode.CUSTOM}} > # Add new configuration property {{high-availability.factoryClass}} > # Use the factory in {{HighAvailabilityServicesUtils}} to instantiate > {{HighAvailabilityServices}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5530 You could rebase on the latest master and force push to retrigger the build. ---
[jira] [Closed] (FLINK-8746) Support rescaling of jobs which are not fully running
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8746. Resolution: Fixed Fixed via 662ed3df5270befae92af3f59ed28e0cfea4e55d > Support rescaling of jobs which are not fully running > - > > Key: FLINK-8746 > URL: https://issues.apache.org/jira/browse/FLINK-8746 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > We should support the rescaling of jobs which are only partially running. > Currently, this fails because rescaling requires to take a savepoint. We can > solve the problem by falling back to the latest rescaling savepoint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8746) Support rescaling of jobs which are not fully running
[ https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375711#comment-16375711 ] ASF GitHub Bot commented on FLINK-8746: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5560 > Support rescaling of jobs which are not fully running > - > > Key: FLINK-8746 > URL: https://issues.apache.org/jira/browse/FLINK-8746 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > We should support the rescaling of jobs which are only partially running. > Currently, this fails because rescaling requires to take a savepoint. We can > solve the problem by falling back to the latest rescaling savepoint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8748) Cancel slot requests for alternatively completed slots in SlotPool
[ https://issues.apache.org/jira/browse/FLINK-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375712#comment-16375712 ] ASF GitHub Bot commented on FLINK-8748: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5561 > Cancel slot requests for alternatively completed slots in SlotPool > -- > > Key: FLINK-8748 > URL: https://issues.apache.org/jira/browse/FLINK-8748 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > The {{SlotPool}} can complete slot requests with other allocated slots. In > that case it should cancel the original slot request sent to the > {{ResourceManager}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8749) Release slots when scheduling operation is canceled in ExecutionGraph
[ https://issues.apache.org/jira/browse/FLINK-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375713#comment-16375713 ] ASF GitHub Bot commented on FLINK-8749: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5562 > Release slots when scheduling operation is canceled in ExecutionGraph > - > > Key: FLINK-8749 > URL: https://issues.apache.org/jira/browse/FLINK-8749 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to quickly release slots, we should explicitly return them to the > {{SlotProvider}} if the scheduling operation is cancelled in the > {{ExecutionGraph}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (FLINK-8138) Race in TaskAsyncCallTest leads to test time out
[ https://issues.apache.org/jira/browse/FLINK-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8138. -- Resolution: Fixed Fixed via 28c2616b80d4c87229c9e74caf53006776408713 > Race in TaskAsyncCallTest leads to test time out > > > Key: FLINK-8138 > URL: https://issues.apache.org/jira/browse/FLINK-8138 > Project: Flink > Issue Type: Bug > Components: Tests >Affects Versions: 1.5.0 >Reporter: Ufuk Celebi >Assignee: Till Rohrmann >Priority: Critical > Labels: test-stability > Fix For: 1.5.0 > > Attachments: log.txt > > > {{TaskAsyncCallTest#testSetsUserCodeClassLoader}} times out with a stack > trace on Travis on a personal branch with unrelated changes on top of 1.4.0 > RC 0. > I've attached the Travis output to this issue. The main thread is stuck in > {code} > "main" #1 prio=5 os_prio=0 tid=0x7ff59000a000 nid=0xb9b in Object.wait() > [0x7ff598965000] >java.lang.Thread.State: WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > - waiting on <0x833994c8> (a java.lang.Object) > at java.lang.Object.wait(Object.java:502) > at > org.apache.flink.core.testutils.OneShotLatch.await(OneShotLatch.java:56) > - locked <0x833994c8> (a java.lang.Object) > at > org.apache.flink.runtime.taskmanager.TaskAsyncCallTest.testSetsUserCodeClassLoader(TaskAsyncCallTest.java:201) > {code} > There are no other Flink related threads alive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5561: [FLINK-8748] [flip6] Cancel slot allocations for a...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5561 ---
[GitHub] flink pull request #5560: [FLINK-8746] [flip6] Rescale partially running job...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5560 ---
[GitHub] flink pull request #5562: [FLINK-8749] [flip6] Release slots when scheduling...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5562 ---
[jira] [Closed] (FLINK-8749) Release slots when scheduling operation is canceled in ExecutionGraph
[ https://issues.apache.org/jira/browse/FLINK-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8749. Resolution: Fixed Fixed via 3969170f5c2dba5ab76bed617648531b1e9aa435 > Release slots when scheduling operation is canceled in ExecutionGraph > - > > Key: FLINK-8749 > URL: https://issues.apache.org/jira/browse/FLINK-8749 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to quickly release slots, we should explicitly return them to the > {{SlotProvider}} if the scheduling operation is cancelled in the > {{ExecutionGraph}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-8748) Cancel slot requests for alternatively completed slots in SlotPool
[ https://issues.apache.org/jira/browse/FLINK-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8748. Resolution: Fixed Fixed via 107c8e04be86e9fd893a5c9e0f9c528d1453c3de > Cancel slot requests for alternatively completed slots in SlotPool > -- > > Key: FLINK-8748 > URL: https://issues.apache.org/jira/browse/FLINK-8748 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > The {{SlotPool}} can complete slot requests with other allocated slots. In > that case it should cancel the original slot request sent to the > {{ResourceManager}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #:
Github user kbialek commented on the pull request: https://github.com/apache/flink/commit/13bb32ef891428fe9e0e14b6ecc525f15c52c40a#commitcomment-27763936 This change broke my flink-consul implementation. That is not a big deal, however I wonder if it wouldn't break ZK recovery. As far as I understood the code in ZooKeeperCompletedCheckpointStore.recover() it compares two Lists of CompletedCheckpoints (line 201). When there is no equals() defined in CompletedCheckpoint class those comparision will never succeed. ---
[jira] [Commented] (FLINK-8775) Make shut down of MiniCluster non blocking
[ https://issues.apache.org/jira/browse/FLINK-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375617#comment-16375617 ] ASF GitHub Bot commented on FLINK-8775: --- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5576 [FLINK-8775] [flip6] Non blocking MiniCluster shut down ## What is the purpose of the change Shuts down the `MiniCluster` in a non blocking fashion. ## Verifying this change - Tested manually by setting the number of `ActorSystem` threads to 1. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink nonBlockingMiniCluster Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5576.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5576 commit 4a0735b1a9c60658b00b6e63bfef94e655260f13 Author: Till RohrmannDate: 2018-02-24T14:39:31Z [FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. commit 833c1cff09910516e23e2009d974f73a48d5fd27 Author: Till Rohrmann Date: 2018-02-24T15:24:25Z [FLINK-8774] [flip6] Make shut down of ResourceManagerRunner non blocking commit 35d17d3012cfd834b91ef0689499034913366419 Author: Till Rohrmann Date: 2018-02-24T15:20:58Z [FLINK-8775] [flip6] Non blocking MiniCluster shut down > Make shut down of MiniCluster non blocking > -- > > Key: FLINK-8775 > URL: https://issues.apache.org/jira/browse/FLINK-8775 > Project: Flink > Issue Type: Improvement > Components: Tests >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > Make the shut down of the {{MiniCluster}} non blocking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5576: [FLINK-8775] [flip6] Non blocking MiniCluster shut...
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5576 [FLINK-8775] [flip6] Non blocking MiniCluster shut down ## What is the purpose of the change Shuts down the `MiniCluster` in a non blocking fashion. ## Verifying this change - Tested manually by setting the number of `ActorSystem` threads to 1. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink nonBlockingMiniCluster Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5576.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5576 commit 4a0735b1a9c60658b00b6e63bfef94e655260f13 Author: Till RohrmannDate: 2018-02-24T14:39:31Z [FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. commit 833c1cff09910516e23e2009d974f73a48d5fd27 Author: Till Rohrmann Date: 2018-02-24T15:24:25Z [FLINK-8774] [flip6] Make shut down of ResourceManagerRunner non blocking commit 35d17d3012cfd834b91ef0689499034913366419 Author: Till Rohrmann Date: 2018-02-24T15:20:58Z [FLINK-8775] [flip6] Non blocking MiniCluster shut down ---
[jira] [Created] (FLINK-8775) Make shut down of MiniCluster non blocking
Till Rohrmann created FLINK-8775: Summary: Make shut down of MiniCluster non blocking Key: FLINK-8775 URL: https://issues.apache.org/jira/browse/FLINK-8775 Project: Flink Issue Type: Improvement Components: Tests Affects Versions: 1.5.0 Reporter: Till Rohrmann Assignee: Till Rohrmann Fix For: 1.5.0 Make the shut down of the {{MiniCluster}} non blocking. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (FLINK-8774) Make shut down of ResourceManagerRunner non blocking
Till Rohrmann created FLINK-8774: Summary: Make shut down of ResourceManagerRunner non blocking Key: FLINK-8774 URL: https://issues.apache.org/jira/browse/FLINK-8774 Project: Flink Issue Type: Improvement Components: Distributed Coordination Affects Versions: 1.5.0 Reporter: Till Rohrmann Assignee: Till Rohrmann Fix For: 1.5.0 Make the shut down of the {{ResourceManagerRunner}} non blocking. This will allow to shut down the {{MiniCluster}} in a non blocking fashion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...
Github user kbialek commented on the issue: https://github.com/apache/flink/pull/5530 Looks like build process was terminated by kernel. Can someone retrigger it? ---
[jira] [Commented] (FLINK-8660) Enable the user to provide custom HAServices implementation
[ https://issues.apache.org/jira/browse/FLINK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375607#comment-16375607 ] ASF GitHub Bot commented on FLINK-8660: --- Github user kbialek commented on the issue: https://github.com/apache/flink/pull/5530 Looks like build process was terminated by kernel. Can someone retrigger it? > Enable the user to provide custom HAServices implementation > > > Key: FLINK-8660 > URL: https://issues.apache.org/jira/browse/FLINK-8660 > Project: Flink > Issue Type: Improvement > Components: Cluster Management, Configuration, Distributed > Coordination >Affects Versions: 1.4.0, 1.5.0 >Reporter: Krzysztof Białek >Priority: Major > Fix For: 1.6.0 > > > At the moment Flink uses ZooKeeper as HA backend. > The goal of this improvement is to make Flink supporting more HA backends, > also maintained as independent projects. > The following changes are required to achieve it: > # Add {{HighAvailabilityServicesFactory}} interface > # Add new option {{HighAvailabilityMode.CUSTOM}} > # Add new configuration property {{high-availability.factoryClass}} > # Use the factory in {{HighAvailabilityServicesUtils}} to instantiate > {{HighAvailabilityServices}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8773) Make shut down of JobManagerRunner non blocking
[ https://issues.apache.org/jira/browse/FLINK-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375592#comment-16375592 ] ASF GitHub Bot commented on FLINK-8773: --- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5575 [FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking ## What is the purpose of the change The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink nonBlockingJobManagerRunner Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5575.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5575 commit 4a0735b1a9c60658b00b6e63bfef94e655260f13 Author: Till RohrmannDate: 2018-02-24T14:39:31Z [FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. > Make shut down of JobManagerRunner non blocking > --- > > Key: FLINK-8773 > URL: https://issues.apache.org/jira/browse/FLINK-8773 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > For a better shut down behaviour, the {{JobManagerRunner}} should be shut > down in a non blocking fashion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5575: [FLINK-8773] [flip6] Make JobManagerRunner shut do...
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5575 [FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking ## What is the purpose of the change The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink nonBlockingJobManagerRunner Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5575.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5575 commit 4a0735b1a9c60658b00b6e63bfef94e655260f13 Author: Till RohrmannDate: 2018-02-24T14:39:31Z [FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. ---
[jira] [Created] (FLINK-8773) Make shut down of JobManagerRunner non blocking
Till Rohrmann created FLINK-8773: Summary: Make shut down of JobManagerRunner non blocking Key: FLINK-8773 URL: https://issues.apache.org/jira/browse/FLINK-8773 Project: Flink Issue Type: Improvement Components: Distributed Coordination Affects Versions: 1.5.0 Reporter: Till Rohrmann Assignee: Till Rohrmann Fix For: 1.5.0 For a better shut down behaviour, the {{JobManagerRunner}} should be shut down in a non blocking fashion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8772) FlinkKafkaConsumerBase partitions discover missing a log parameter
[ https://issues.apache.org/jira/browse/FLINK-8772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375579#comment-16375579 ] ASF GitHub Bot commented on FLINK-8772: --- GitHub user Matrix42 opened a pull request: https://github.com/apache/flink/pull/5574 [FLINK-8772][kafka] fix missing log parameter ## Brief change log fix FlinkKafkaConsumerBase missing log parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/Matrix42/flink kafka-connector Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5574 commit 8bc5ee108c3223526ed1d0ceff032a7b63698520 Author: Matrix42 <934336389@...> Date: 2018-02-24T13:52:44Z [FLINK-8772][kafka] fix missing log parameter > FlinkKafkaConsumerBase partitions discover missing a log parameter > -- > > Key: FLINK-8772 > URL: https://issues.apache.org/jira/browse/FLINK-8772 > Project: Flink > Issue Type: Bug > Components: Kafka Connector >Affects Versions: 1.4.0 >Reporter: Matrix42 >Priority: Trivial > Fix For: 1.4.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5574: [FLINK-8772][kafka] fix missing log parameter
GitHub user Matrix42 opened a pull request: https://github.com/apache/flink/pull/5574 [FLINK-8772][kafka] fix missing log parameter ## Brief change log fix FlinkKafkaConsumerBase missing log parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/Matrix42/flink kafka-connector Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5574 commit 8bc5ee108c3223526ed1d0ceff032a7b63698520 Author: Matrix42 <934336389@...> Date: 2018-02-24T13:52:44Z [FLINK-8772][kafka] fix missing log parameter ---
[jira] [Created] (FLINK-8772) FlinkKafkaConsumerBase partitions discover missing a log parameter
Matrix42 created FLINK-8772: --- Summary: FlinkKafkaConsumerBase partitions discover missing a log parameter Key: FLINK-8772 URL: https://issues.apache.org/jira/browse/FLINK-8772 Project: Flink Issue Type: Bug Components: Kafka Connector Affects Versions: 1.4.0 Reporter: Matrix42 Fix For: 1.4.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8660) Enable the user to provide custom HAServices implementation
[ https://issues.apache.org/jira/browse/FLINK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375562#comment-16375562 ] ASF GitHub Bot commented on FLINK-8660: --- Github user kbialek commented on the issue: https://github.com/apache/flink/pull/5530 Now uses high-availability configuration property can be set either to none, zookeeper or FQN of factory class > Enable the user to provide custom HAServices implementation > > > Key: FLINK-8660 > URL: https://issues.apache.org/jira/browse/FLINK-8660 > Project: Flink > Issue Type: Improvement > Components: Cluster Management, Configuration, Distributed > Coordination >Affects Versions: 1.4.0, 1.5.0 >Reporter: Krzysztof Białek >Priority: Major > Fix For: 1.6.0 > > > At the moment Flink uses ZooKeeper as HA backend. > The goal of this improvement is to make Flink supporting more HA backends, > also maintained as independent projects. > The following changes are required to achieve it: > # Add {{HighAvailabilityServicesFactory}} interface > # Add new option {{HighAvailabilityMode.CUSTOM}} > # Add new configuration property {{high-availability.factoryClass}} > # Use the factory in {{HighAvailabilityServicesUtils}} to instantiate > {{HighAvailabilityServices}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink issue #5530: [FLINK-8660] Enable the user to provide custom HAServices...
Github user kbialek commented on the issue: https://github.com/apache/flink/pull/5530 Now uses high-availability configuration property can be set either to none, zookeeper or FQN of factory class ---
[jira] [Commented] (FLINK-8660) Enable the user to provide custom HAServices implementation
[ https://issues.apache.org/jira/browse/FLINK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375561#comment-16375561 ] ASF GitHub Bot commented on FLINK-8660: --- GitHub user kbialek reopened a pull request: https://github.com/apache/flink/pull/5530 [FLINK-8660] Enable the user to provide custom HAServices implementation ## What is the purpose of the change This pull request makes it possible to use alternative (to ZK) HA backend implementation ## Brief change log * Added HighAvailabilityServicesFactory interface * Added new option HighAvailabilityMode.CUSTOM * Added new configuration property high-availability.factoryClass * HighAvailabilityServicesUtils uses configured factory to instantiate HighAvailabilityServices * Updated docs ## Verifying this change This change added tests and can be verified as follows: * Added new test class HighAvailabilityServicesUtilsTest * Updated test class HighAvailabilityModeTest * Manually verified by using own HA backend implementation ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes, if this feature is used, otherwise no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? docs and JavaDocs You can merge this pull request into a Git repository by running: $ git pull https://github.com/kbialek/flink FLINK-8660 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5530 commit 494bb2f7175bb174ed2a7139495af05891012498 Author: Krzysztof BiałekDate: 2018-02-17T15:11:50Z Implemented commit 077102571ae58987fafbf00ba536f1512c700e1b Author: Krzysztof Białek Date: 2018-02-17T16:45:47Z Create BlobStorage for any HA backend commit 57e52b70700dc1b3a4f05113ae6aa594112eead7 Author: Krzysztof Białek Date: 2018-02-17T16:46:02Z HighAvailabilityServicesFactory may throw exceptions commit 9a08884ee05f8a8bf8e03b7fdd3b6d148530c40b Author: Krzysztof Białek Date: 2018-02-19T21:12:59Z Docs commit 0afc341077347e32669330ea66d8518d9a3133ef Author: zentol Date: 2018-02-07T08:52:23Z [FLINK-8574][travis] Add timestamp to logging messages This closes #5419. commit e2f1650ea251ab7a7f6090cda819e2e2481ffdf5 Author: zentol Date: 2018-02-13T09:31:31Z [FLINK-8621][prometheus][tests] Remove endpointIsUnavailableAfterReporterIsClosed() The test is inherently unstable as it will always fail if any other server is started on the port between the closing of the reporter and the polling of metrics. This closes #5473. commit 2db296973ec2aa648246279a2e55cca87432f829 Author: zentol Date: 2018-02-13T09:33:03Z [hotfix][prometheus] Document internal usage of CollectorRegistry.defaultRegistry It appeared as if the HTTPServer wasn't actually doing anything, but it internally accessed the singleton registry that we also access to register metrics. commit 6fb2c89f7cfa5b3d05c683777b76d257db4770c5 Author: zentol Date: 2018-02-13T09:33:31Z [hotfix][prometheus][tests] Add utility for generating port ranges commit 7441b16a4eeb10633aca4b9c89629ee92a182092 Author: Aljoscha Krettek Date: 2018-02-14T13:48:22Z [FLINK-8600] Allow disabling truncate() check in BucketingSink The test was failing when using PrestoS3FileSystem because it doesn't use an absolute/qualified path. commit 9f5e835e845901fd1183b390c510851c2ca17b03 Author: Till Rohrmann Date: 2018-02-19T11:00:08Z [FLINK-8698] [flip6] Use Flip6LocalStreamEnvironment instead of LocalStreamEnvironment commit 9b135941c5295af4db074aa50d5bb881a6a52feb Author: Till Rohrmann Date: 2018-02-19T11:41:41Z [FLINK-8698] [flip6] Let LocalExecutor use Flip-6 MiniCluster This closes #5524. commit 4596c656c79829e2c73aee252ce13c0cb5bc9b7a Author: Till Rohrmann Date: 2018-02-20T08:00:31Z [FLINK-8709] [tests] Harden SlotPoolRpcTest.testCancelSlotAllocationWithoutResourceManager commit 2d9db7204d3c4b012600416038679941241f1088 Author: zentol
[GitHub] flink pull request #5530: [FLINK-8660] Enable the user to provide custom HAS...
GitHub user kbialek reopened a pull request: https://github.com/apache/flink/pull/5530 [FLINK-8660] Enable the user to provide custom HAServices implementation ## What is the purpose of the change This pull request makes it possible to use alternative (to ZK) HA backend implementation ## Brief change log * Added HighAvailabilityServicesFactory interface * Added new option HighAvailabilityMode.CUSTOM * Added new configuration property high-availability.factoryClass * HighAvailabilityServicesUtils uses configured factory to instantiate HighAvailabilityServices * Updated docs ## Verifying this change This change added tests and can be verified as follows: * Added new test class HighAvailabilityServicesUtilsTest * Updated test class HighAvailabilityModeTest * Manually verified by using own HA backend implementation ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes, if this feature is used, otherwise no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? docs and JavaDocs You can merge this pull request into a Git repository by running: $ git pull https://github.com/kbialek/flink FLINK-8660 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5530.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5530 commit 494bb2f7175bb174ed2a7139495af05891012498 Author: Krzysztof BiaÅekDate: 2018-02-17T15:11:50Z Implemented commit 077102571ae58987fafbf00ba536f1512c700e1b Author: Krzysztof BiaÅek Date: 2018-02-17T16:45:47Z Create BlobStorage for any HA backend commit 57e52b70700dc1b3a4f05113ae6aa594112eead7 Author: Krzysztof BiaÅek Date: 2018-02-17T16:46:02Z HighAvailabilityServicesFactory may throw exceptions commit 9a08884ee05f8a8bf8e03b7fdd3b6d148530c40b Author: Krzysztof BiaÅek Date: 2018-02-19T21:12:59Z Docs commit 0afc341077347e32669330ea66d8518d9a3133ef Author: zentol Date: 2018-02-07T08:52:23Z [FLINK-8574][travis] Add timestamp to logging messages This closes #5419. commit e2f1650ea251ab7a7f6090cda819e2e2481ffdf5 Author: zentol Date: 2018-02-13T09:31:31Z [FLINK-8621][prometheus][tests] Remove endpointIsUnavailableAfterReporterIsClosed() The test is inherently unstable as it will always fail if any other server is started on the port between the closing of the reporter and the polling of metrics. This closes #5473. commit 2db296973ec2aa648246279a2e55cca87432f829 Author: zentol Date: 2018-02-13T09:33:03Z [hotfix][prometheus] Document internal usage of CollectorRegistry.defaultRegistry It appeared as if the HTTPServer wasn't actually doing anything, but it internally accessed the singleton registry that we also access to register metrics. commit 6fb2c89f7cfa5b3d05c683777b76d257db4770c5 Author: zentol Date: 2018-02-13T09:33:31Z [hotfix][prometheus][tests] Add utility for generating port ranges commit 7441b16a4eeb10633aca4b9c89629ee92a182092 Author: Aljoscha Krettek Date: 2018-02-14T13:48:22Z [FLINK-8600] Allow disabling truncate() check in BucketingSink The test was failing when using PrestoS3FileSystem because it doesn't use an absolute/qualified path. commit 9f5e835e845901fd1183b390c510851c2ca17b03 Author: Till Rohrmann Date: 2018-02-19T11:00:08Z [FLINK-8698] [flip6] Use Flip6LocalStreamEnvironment instead of LocalStreamEnvironment commit 9b135941c5295af4db074aa50d5bb881a6a52feb Author: Till Rohrmann Date: 2018-02-19T11:41:41Z [FLINK-8698] [flip6] Let LocalExecutor use Flip-6 MiniCluster This closes #5524. commit 4596c656c79829e2c73aee252ce13c0cb5bc9b7a Author: Till Rohrmann Date: 2018-02-20T08:00:31Z [FLINK-8709] [tests] Harden SlotPoolRpcTest.testCancelSlotAllocationWithoutResourceManager commit 2d9db7204d3c4b012600416038679941241f1088 Author: zentol Date: 2018-02-20T16:31:05Z [hotfix][docs] Update configuration docs commit f75b763a40dcb6a1b1b06a7312d5ee7b67f19a5c Author: Krzysztof BiaÅek Date: 2018-02-21T21:44:30Z Use ha mode config property
[jira] [Updated] (FLINK-8769) Quickstart job execution in IDE logs contain several exceptions
[ https://issues.apache.org/jira/browse/FLINK-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8769: Summary: Quickstart job execution in IDE logs contain several exceptions (was: Quickstart job submission logs contain several exceptions) > Quickstart job execution in IDE logs contain several exceptions > --- > > Key: FLINK-8769 > URL: https://issues.apache.org/jira/browse/FLINK-8769 > Project: Flink > Issue Type: Bug > Components: Local Runtime >Affects Versions: 1.5.0 >Reporter: Chesnay Schepler >Priority: Blocker > Fix For: 1.5.0 > > > While checking out [the PR for > FLINK-8761|https://github.com/apache/flink/pull/5569] and running a job in > the IDE several exceptions are being logged. The job still runs properly > though. > {code:java} > ... > 14:19:52,546 INFO org.apache.flink.runtime.dispatcher.DispatcherRestEndpoint >- Failed to load web based job submission extension. > org.apache.flink.util.FlinkException: Could not load web submission extension. > at > org.apache.flink.runtime.webmonitor.WebMonitorUtils.loadWebSubmissionExtension(WebMonitorUtils.java:252) > at > org.apache.flink.runtime.dispatcher.DispatcherRestEndpoint.initializeHandlers(DispatcherRestEndpoint.java:111) > at > org.apache.flink.runtime.rest.RestServerEndpoint.start(RestServerEndpoint.java:124) > at > org.apache.flink.runtime.minicluster.MiniCluster.start(MiniCluster.java:320) > at > org.apache.flink.client.LocalExecutor.createJobExecutorService(LocalExecutor.java:144) > at org.apache.flink.client.LocalExecutor.start(LocalExecutor.java:118) > at > org.apache.flink.client.LocalExecutor.executePlan(LocalExecutor.java:212) > at > org.apache.flink.api.java.LocalEnvironment.execute(LocalEnvironment.java:91) > at > org.apache.flink.api.java.ExecutionEnvironment.execute(ExecutionEnvironment.java:815) > at org.apache.flink.api.java.DataSet.collect(DataSet.java:413) > at org.apache.flink.api.java.DataSet.print(DataSet.java:1652) > at iqst.BatchJob.main(BatchJob.java:39) > Caused by: java.lang.reflect.InvocationTargetException > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:423) > at > org.apache.flink.runtime.webmonitor.WebMonitorUtils.loadWebSubmissionExtension(WebMonitorUtils.java:243) > ... 11 more > Caused by: org.apache.flink.util.ConfigurationException: Config parameter > 'Key: 'jobmanager.rpc.address' , default: null (deprecated keys: [])' is > missing (hostname/address of JobManager to connect to). > at > org.apache.flink.runtime.highavailability.HighAvailabilityServicesUtils.getJobManagerAddress(HighAvailabilityServicesUtils.java:137) > at > org.apache.flink.runtime.highavailability.HighAvailabilityServicesUtils.createHighAvailabilityServices(HighAvailabilityServicesUtils.java:79) > at > org.apache.flink.client.program.ClusterClient.(ClusterClient.java:148) > at > org.apache.flink.client.program.rest.RestClusterClient.(RestClusterClient.java:144) > at > org.apache.flink.client.program.rest.RestClusterClient.(RestClusterClient.java:135) > at > org.apache.flink.runtime.webmonitor.WebSubmissionExtension.(WebSubmissionExtension.java:61) > ... 16 more > 14:19:53,140 INFO org.apache.flink.runtime.dispatcher.DispatcherRestEndpoint >- Rest endpoint listening at 127.0.0.1:64908 > ... > 14:19:56,546 INFO org.apache.flink.runtime.taskexecutor.TaskExecutor >- Close ResourceManager connection b8a2cff59ba07813067a64ebaf7d7889. > org.apache.flink.util.FlinkException: New ResourceManager leader found under: > null(null) > at > org.apache.flink.runtime.taskexecutor.TaskExecutor.notifyOfNewResourceManagerLeader(TaskExecutor.java:853) > at > org.apache.flink.runtime.taskexecutor.TaskExecutor.access$900(TaskExecutor.java:127) > at > org.apache.flink.runtime.taskexecutor.TaskExecutor$ResourceManagerLeaderListener.lambda$notifyLeaderAddress$0(TaskExecutor.java:1359) > at > org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRunAsync(AkkaRpcActor.java:292) > at > org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleMessage(AkkaRpcActor.java:147) > at > org.apache.flink.runtime.rpc.akka.AkkaRpcActor.lambda$onReceive$0(AkkaRpcActor.java:129) > at > akka.actor.ActorCell$$anonfun$become$1.applyOrElse(ActorCell.scala:544) > at
[jira] [Closed] (FLINK-8678) Make AkkaRpcService#stopService non-blocking
[ https://issues.apache.org/jira/browse/FLINK-8678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8678. Resolution: Fixed Fixed via c27e2a77005db355da9e72656af8b0df8b1dfe75 > Make AkkaRpcService#stopService non-blocking > > > Key: FLINK-8678 > URL: https://issues.apache.org/jira/browse/FLINK-8678 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to properly shut down the {{AkkaRpcService}} in a non-blocking > fashion, we have to change the implementation of the > {{AkkaRpcService#stopService}}. This would give us the benefit to enable > non-blocking shut down of the components owning the {{AkkaRpcService}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-8664) Change termination future type of RpcEndpoint to Void
[ https://issues.apache.org/jira/browse/FLINK-8664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8664. Resolution: Fixed Fixed via c131546eaadd07baf950bd6a44d07ee42d109e4c > Change termination future type of RpcEndpoint to Void > - > > Key: FLINK-8664 > URL: https://issues.apache.org/jira/browse/FLINK-8664 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > In order to align the termination futures of {{RpcService}} and > {{RpcEndpoint}} we should change the future value type of the > {{RcpEnpoint#getTerminationFuture()}} to {{Void}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-8670) Make MetricRegistryImpl#shutdown non blocking
[ https://issues.apache.org/jira/browse/FLINK-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8670. Resolution: Fixed Fixed via e29ec0fbd2cb03a42b98142f63ce73b97dc2e915 > Make MetricRegistryImpl#shutdown non blocking > -- > > Key: FLINK-8670 > URL: https://issues.apache.org/jira/browse/FLINK-8670 > Project: Flink > Issue Type: Improvement > Components: Metrics >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to better shut down multiple components concurrently, we should make > all shutdown operation non-blocking if possible. This also includes the > {{MetricRegistryImpl}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-8665) Allow RpcEndpoint#postStop to complete asynchronously
[ https://issues.apache.org/jira/browse/FLINK-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8665. Resolution: Fixed Fixed via d9b28e817351eb2eb6b4cdd9597061713d9160e8 > Allow RpcEndpoint#postStop to complete asynchronously > - > > Key: FLINK-8665 > URL: https://issues.apache.org/jira/browse/FLINK-8665 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > Every {{RpcEndpoint}} should have the possibility to trigger asynchronous > clean up operations in its {{RpcEndpoint#postStop}} method. In order to do > that the {{postStop}} method should return a {{CompletableFuture}} > which is completed once all post stop actions have finished. The > {{RpcEndpoint#terminationFuture}} will only be completed afterwards. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-8666) Use AkkaUtils#testDispatcherConfig in MiniCluster
[ https://issues.apache.org/jira/browse/FLINK-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8666. Resolution: Fixed Fixed via 65081ac72d18f610db210c5fe030805141a9b2e5 > Use AkkaUtils#testDispatcherConfig in MiniCluster > - > > Key: FLINK-8666 > URL: https://issues.apache.org/jira/browse/FLINK-8666 > Project: Flink > Issue Type: Improvement > Components: Tests >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > By using the {{AkkaUtils#testDispatcherConfig}} for the {{AkkaRpcServices}} > used by the {{MiniCluster}}, we can drastically reduce the number of started > threads. This will improve the resource foot print of the {{MiniCluster}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (FLINK-8677) Make ClusterEntrypoint shut down non-blocking
[ https://issues.apache.org/jira/browse/FLINK-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8677. Resolution: Fixed Fixed via fba655af1a4a543f01eecf222826a0821e6e1c17 > Make ClusterEntrypoint shut down non-blocking > - > > Key: FLINK-8677 > URL: https://issues.apache.org/jira/browse/FLINK-8677 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > Make the {{ClusterEntrypoint}} shut down method non blocking. That way we > don't have to use the common Fork-Join-Pool to shutDownAndTerminate the > cluster entrypoint when the Dispatcher terminates. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8666) Use AkkaUtils#testDispatcherConfig in MiniCluster
[ https://issues.apache.org/jira/browse/FLINK-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375516#comment-16375516 ] ASF GitHub Bot commented on FLINK-8666: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5499 > Use AkkaUtils#testDispatcherConfig in MiniCluster > - > > Key: FLINK-8666 > URL: https://issues.apache.org/jira/browse/FLINK-8666 > Project: Flink > Issue Type: Improvement > Components: Tests >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > By using the {{AkkaUtils#testDispatcherConfig}} for the {{AkkaRpcServices}} > used by the {{MiniCluster}}, we can drastically reduce the number of started > threads. This will improve the resource foot print of the {{MiniCluster}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8664) Change termination future type of RpcEndpoint to Void
[ https://issues.apache.org/jira/browse/FLINK-8664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375515#comment-16375515 ] ASF GitHub Bot commented on FLINK-8664: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5496 > Change termination future type of RpcEndpoint to Void > - > > Key: FLINK-8664 > URL: https://issues.apache.org/jira/browse/FLINK-8664 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > In order to align the termination futures of {{RpcService}} and > {{RpcEndpoint}} we should change the future value type of the > {{RcpEnpoint#getTerminationFuture()}} to {{Void}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5517: [FLINK-8678] [flip6] Make RpcService shut down non...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5517 ---
[jira] [Commented] (FLINK-8677) Make ClusterEntrypoint shut down non-blocking
[ https://issues.apache.org/jira/browse/FLINK-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375510#comment-16375510 ] ASF GitHub Bot commented on FLINK-8677: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5512 > Make ClusterEntrypoint shut down non-blocking > - > > Key: FLINK-8677 > URL: https://issues.apache.org/jira/browse/FLINK-8677 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > Make the {{ClusterEntrypoint}} shut down method non blocking. That way we > don't have to use the common Fork-Join-Pool to shutDownAndTerminate the > cluster entrypoint when the Dispatcher terminates. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5499: [FLINK-8666] [test] Use testDispatcherConfig in Mi...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5499 ---
[jira] [Commented] (FLINK-8670) Make MetricRegistryImpl#shutdown non blocking
[ https://issues.apache.org/jira/browse/FLINK-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375513#comment-16375513 ] ASF GitHub Bot commented on FLINK-8670: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5504 > Make MetricRegistryImpl#shutdown non blocking > -- > > Key: FLINK-8670 > URL: https://issues.apache.org/jira/browse/FLINK-8670 > Project: Flink > Issue Type: Improvement > Components: Metrics >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to better shut down multiple components concurrently, we should make > all shutdown operation non-blocking if possible. This also includes the > {{MetricRegistryImpl}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8678) Make AkkaRpcService#stopService non-blocking
[ https://issues.apache.org/jira/browse/FLINK-8678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375512#comment-16375512 ] ASF GitHub Bot commented on FLINK-8678: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5517 > Make AkkaRpcService#stopService non-blocking > > > Key: FLINK-8678 > URL: https://issues.apache.org/jira/browse/FLINK-8678 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to properly shut down the {{AkkaRpcService}} in a non-blocking > fashion, we have to change the implementation of the > {{AkkaRpcService#stopService}}. This would give us the benefit to enable > non-blocking shut down of the components owning the {{AkkaRpcService}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8665) Allow RpcEndpoint#postStop to complete asynchronously
[ https://issues.apache.org/jira/browse/FLINK-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375514#comment-16375514 ] ASF GitHub Bot commented on FLINK-8665: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5498 > Allow RpcEndpoint#postStop to complete asynchronously > - > > Key: FLINK-8665 > URL: https://issues.apache.org/jira/browse/FLINK-8665 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination >Affects Versions: 1.5.0 >Reporter: Till Rohrmann >Assignee: Till Rohrmann >Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > Every {{RpcEndpoint}} should have the possibility to trigger asynchronous > clean up operations in its {{RpcEndpoint#postStop}} method. In order to do > that the {{postStop}} method should return a {{CompletableFuture}} > which is completed once all post stop actions have finished. The > {{RpcEndpoint#terminationFuture}} will only be completed afterwards. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5498: [FLINK-8665] [rest] Let RpcEndpoint#postStop retur...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5498 ---
[GitHub] flink pull request #5512: [FLINK-8677] [flip6] Make ClusterEntrypoint shut d...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5512 ---
[GitHub] flink pull request #5504: [FLINK-8670] Make MetricRegistryImpl#shutdown non ...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5504 ---
[GitHub] flink pull request #5496: [FLINK-8664] [rest] Change RpcEndpoint#Termination...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5496 ---
[GitHub] flink issue #5327: [FLINK-8428] [table] Implement stream-stream non-window l...
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 hi, @twalthr Look forward to your review, thanks :-) ---
[jira] [Commented] (FLINK-8428) Implement stream-stream non-window left outer join
[ https://issues.apache.org/jira/browse/FLINK-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375497#comment-16375497 ] ASF GitHub Bot commented on FLINK-8428: --- Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5327 hi, @twalthr Look forward to your review, thanks :-) > Implement stream-stream non-window left outer join > -- > > Key: FLINK-8428 > URL: https://issues.apache.org/jira/browse/FLINK-8428 > Project: Flink > Issue Type: Sub-task > Components: Table API SQL >Reporter: Hequn Cheng >Assignee: Hequn Cheng >Priority: Major > > Implement stream-stream non-window left outer join for sql/table-api. A > simple design doc can be found > [here|https://docs.google.com/document/d/1u7bJHeEBP_hFhi8Jm4oT3FqQDOm2pJDqCtq1U1WMHDo/edit?usp=sharing] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-7756) RocksDB state backend Checkpointing (Async and Incremental) is not working with CEP.
[ https://issues.apache.org/jira/browse/FLINK-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375447#comment-16375447 ] tarun razdan commented on FLINK-7756: - [~aljoscha] Here is the link to the minimal example for your reference: [Flink_CEP_Example|https://github.com/tarunrazdan/Flink_CEP_Example] Put in the kafka url and path to the hdfs for saving checkpoints. Building Jar: {code:java} $ export SBT_OPTS="-Xmx2G -XX:+UseConcMarkSweepGC -XX:+CMSClassUnloadingEnabled -XX:MaxPermSize=2G -Xss2M -Duser.timezone=GMT" $ sbt clean assembly {code} Command to submit Job to yarn: {code:java} $ /opt/flink/bin/flink run -yn 1 -ys 1 -ynm 'cep-example' -ytm 1 -yst -p 1 -d -m yarn-cluster cep_example/target/scala-2.11/CEPSample-assembly-0.1.jar {code} About the setup: 1. HDP-2.6.2.0 (2.6.2.0-205) 2. YARN 3. Kafka 4. Kerberos > RocksDB state backend Checkpointing (Async and Incremental) is not working > with CEP. > - > > Key: FLINK-7756 > URL: https://issues.apache.org/jira/browse/FLINK-7756 > Project: Flink > Issue Type: Sub-task > Components: CEP, State Backends, Checkpointing, Streaming >Affects Versions: 1.4.0, 1.3.2 > Environment: Flink 1.3.2, Yarn, HDFS, RocksDB backend >Reporter: Shashank Agarwal >Assignee: Aljoscha Krettek >Priority: Blocker > Fix For: 1.5.0, 1.4.1 > > Attachments: jobmanager.log, jobmanager_without_cassandra.log, > taskmanager.log, taskmanager_without_cassandra.log > > > When i try to use RocksDBStateBackend on my staging cluster (which is using > HDFS as file system) it crashes. But When i use FsStateBackend on staging > (which is using HDFS as file system) it is working fine. > On local with local file system it's working fine in both cases. > Please check attached logs. I have around 20-25 tasks in my app. > {code:java} > 2017-09-29 14:21:31,639 INFO > org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink - No state > to restore for the BucketingSink (taskIdx=0). > 2017-09-29 14:21:31,640 INFO > org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackend - > Initializing RocksDB keyed state backend from snapshot. > 2017-09-29 14:21:32,020 INFO > org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink - No state > to restore for the BucketingSink (taskIdx=1). > 2017-09-29 14:21:32,022 INFO > org.apache.flink.contrib.streaming.state.RocksDBKeyedStateBackend - > Initializing RocksDB keyed state backend from snapshot. > 2017-09-29 14:21:32,078 INFO com.datastax.driver.core.NettyUtil > - Found Netty's native epoll transport in the classpath, using > it > 2017-09-29 14:21:34,177 INFO org.apache.flink.runtime.taskmanager.Task > - Attempting to fail task externally Co-Flat Map (1/2) > (b879f192c4e8aae6671cdafb3a24c00a). > 2017-09-29 14:21:34,177 INFO org.apache.flink.runtime.taskmanager.Task > - Attempting to fail task externally Map (2/2) > (1ea5aef6ccc7031edc6b37da2912d90b). > 2017-09-29 14:21:34,178 INFO org.apache.flink.runtime.taskmanager.Task > - Attempting to fail task externally Co-Flat Map (2/2) > (4bac8e764c67520d418a4c755be23d4d). > 2017-09-29 14:21:34,178 INFO org.apache.flink.runtime.taskmanager.Task > - Co-Flat Map (1/2) (b879f192c4e8aae6671cdafb3a24c00a) switched > from RUNNING to FAILED. > AsynchronousException{java.lang.Exception: Could not materialize checkpoint 2 > for operator Co-Flat Map (1/2).} > at > org.apache.flink.streaming.runtime.tasks.StreamTask$AsyncCheckpointRunnable.run(StreamTask.java:970) > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > Caused by: java.lang.Exception: Could not materialize checkpoint 2 for > operator Co-Flat Map (1/2). > ... 6 more > Caused by: java.util.concurrent.ExecutionException: > java.lang.IllegalStateException > at java.util.concurrent.FutureTask.report(FutureTask.java:122) > at java.util.concurrent.FutureTask.get(FutureTask.java:192) > at > org.apache.flink.util.FutureUtil.runIfNotDoneAndGet(FutureUtil.java:43) > at > org.apache.flink.streaming.runtime.tasks.StreamTask$AsyncCheckpointRunnable.run(StreamTask.java:897) > ... 5 more > Suppressed: java.lang.Exception: Could not properly cancel managed > keyed state future. > at >
[jira] [Assigned] (FLINK-7836) specifying node label for flink job to run on yarn
[ https://issues.apache.org/jira/browse/FLINK-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-7836: --- Assignee: vinoyang > specifying node label for flink job to run on yarn > -- > > Key: FLINK-7836 > URL: https://issues.apache.org/jira/browse/FLINK-7836 > Project: Flink > Issue Type: New Feature > Components: Client >Affects Versions: 1.3.2 >Reporter: zhaibaba >Assignee: vinoyang >Priority: Major > > flink client cannot specify node label for flink job to run on yarn -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-8761) Various improvements to the Quickstarts
[ https://issues.apache.org/jira/browse/FLINK-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375407#comment-16375407 ] ASF GitHub Bot commented on FLINK-8761: --- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170415569 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License. - - - - org.apache.flink - flink-core - ${flink.version} - + org.apache.flink flink-java ${flink.version} + provided - org.apache.flink - flink-clients_${scala.binary.version} + flink-streaming-java_${scala.binary.version} ${flink.version} + provided + + + + > Key: FLINK-8761 > URL: https://issues.apache.org/jira/browse/FLINK-8761 > Project: Flink > Issue Type: Improvement > Components: Quickstarts >Reporter: Stephan Ewen >Assignee: Stephan Ewen >Priority: Major > Fix For: 1.5.0 > > > Various improvements to the Quickstarts to give a smoother out of the box > experience. > Broken down into the subtasks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170415569 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License. - - - - org.apache.flink - flink-core - ${flink.version} - + org.apache.flink flink-java ${flink.version} + provided - org.apache.flink - flink-clients_${scala.binary.version} + flink-streaming-java_${scala.binary.version} ${flink.version} + provided + + + +
[jira] [Commented] (FLINK-8761) Various improvements to the Quickstarts
[ https://issues.apache.org/jira/browse/FLINK-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375395#comment-16375395 ] ASF GitHub Bot commented on FLINK-8761: --- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170415181 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License. - - - - org.apache.flink - flink-core - ${flink.version} - + org.apache.flink flink-java ${flink.version} + provided - org.apache.flink - flink-clients_${scala.binary.version} + flink-streaming-java_${scala.binary.version} ${flink.version} + provided + + + + > Key: FLINK-8761 > URL: https://issues.apache.org/jira/browse/FLINK-8761 > Project: Flink > Issue Type: Improvement > Components: Quickstarts >Reporter: Stephan Ewen >Assignee: Stephan Ewen >Priority: Major > Fix For: 1.5.0 > > > Various improvements to the Quickstarts to give a smoother out of the box > experience. > Broken down into the subtasks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] flink pull request #5569: [FLINK-8761] [quickstarts] Big improvements to the...
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5569#discussion_r170415181 --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml --- @@ -50,181 +51,113 @@ under the License. - - - - org.apache.flink - flink-core - ${flink.version} - + org.apache.flink flink-java ${flink.version} + provided - org.apache.flink - flink-clients_${scala.binary.version} + flink-streaming-java_${scala.binary.version} ${flink.version} + provided + + + +