date:20181101

[GitHub] yxu-valleytider commented on a change in pull request #6968: [FLINK-4582] [kinesis] Consuming data from DynamoDB streams to flink

2018-11-01 Thread GitBox

yxu-valleytider commented on a change in pull request #6968: [FLINK-4582] 
[kinesis] Consuming data from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r229956874
 
 

 ##
 File path: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
 ##
 @@ -73,7 +73,7 @@
private static final Logger LOG = 
LoggerFactory.getLogger(KinesisProxy.class);
 
/** The actual Kinesis client from the AWS SDK that we will be using to 
make calls. */
-   private final AmazonKinesis kinesisClient;
+   protected final AmazonKinesis kinesisClient;
 
 Review comment:
   It is used inside `DynamodbStreamsProxy` to [execute the `describeStream` 
call](https://github.com/apache/flink/blob/918eb652a6fa865652b464e742c5f5b6c08c5be6/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/dynamodbstreams/proxy/DynamodbStreamsProxy.java#L197).
  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yxu-valleytider commented on a change in pull request #6968: [FLINK-4582] [kinesis] Consuming data from DynamoDB streams to flink

2018-11-01 Thread GitBox

yxu-valleytider commented on a change in pull request #6968: [FLINK-4582] 
[kinesis] Consuming data from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r229958032
 
 

 ##
 File path: 
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/dynamodbstreams/model/DynamodbStreamsShardHandleTest.java
 ##
 @@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.dynamodbstreams.model;
+
+import org.junit.Test;
+
+import static 
org.apache.flink.streaming.connectors.dynamodbstreams.model.DynamodbStreamsShardHandle.SHARDID_PREFIX;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Shard handle unit tests.
+ */
+public class DynamodbStreamsShardHandleTest {
+   @Test
+   public void testIsValidShardId() {
+   // normal form
+   String shardId = "shardId-0001536805703746-69688cb1";
+   assertEquals(true, 
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+   // short form
+   shardId = "shardId-0001536805703746";
+   assertEquals(true, 
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+   // long form
+   shardId = 
"shardId-0001536805703746-69688cb1aljkwerijfl8228sl12a123akfla";
+   assertEquals(true, 
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+   // invalid with wrong prefix
+   shardId = "sId-0001536805703746-69688cb1";
+   assertEquals(false, 
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+   // invalid with non-digits
+   shardId = "shardId-000153680570aabb-69688cb1";
+   assertEquals(false, 
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+   // invalid with shardId too long
+   shardId = 
"shardId-0001536805703746-69688cb1aljkwerijfl8228sl12a123akfla";
+   assertEquals(false, 
DynamodbStreamsShardHandle.isValidShardId(shardId));
+   }
+
+   @Test
+   public void testCompareShardId() {
+   final int numShardIds = 10;
+   final int shardIdDigitLen = 20;
+   final String zeros = "";  // twenty '0' 
chars
+   String shardIdValid = "shardId-0001536805703746-69688cb1";
+   String shardIdInvalid = "shardId-000153680570aabb-69688cb1";
+
+   assertEquals(0, 
DynamodbStreamsShardHandle.compareShardIds(shardIdValid, shardIdValid));
+
+   // comparison of invalid shardIds should yield exception
+   try {
+   
DynamodbStreamsShardHandle.compareShardIds(shardIdValid, shardIdInvalid);
+   fail("invalid shard Id" + shardIdInvalid + " should 
trigger exception");
+   } catch (IllegalArgumentException e) {
+   // ignore
+   }
+   try {
+   
DynamodbStreamsShardHandle.compareShardIds(shardIdInvalid, shardIdValid);
+   fail("invalid shard Id" + shardIdInvalid + " should 
trigger exception");
+   } catch (IllegalArgumentException e) {
+   // ignore
 
 Review comment:
   yes `// expected` clarifies more.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yxu-valleytider commented on a change in pull request #6968: [FLINK-4582] [kinesis] Consuming data from DynamoDB streams to flink

2018-11-01 Thread GitBox

yxu-valleytider commented on a change in pull request #6968: [FLINK-4582]
[kinesis] Consuming data from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r229956951

##
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/dynamodbstreams/FlinkDynamodbStreamsConsumer.java
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.dynamodbstreams;

Review comment:
Hmm, both the `dynamodbstreams` and `kinesis` modules are under the parent
module `org.apache.flink.streaming.connectors`. This is also consistent with
the directory structure.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

1 2 3 4 >

1 - 100 of 387 matches

Mail list logo