[GitHub] stevenzwu commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-19 Thread GitBox
stevenzwu commented on a change in pull request #6615: [FLINK-8354] 
[flink-connectors] Add ability to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#discussion_r249265860
 
 

 ##
 File path: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/KeyedDeserializationSchema.java
 ##
 @@ -32,6 +34,49 @@
  */
 @PublicEvolving
 public interface KeyedDeserializationSchema extends Serializable, 
ResultTypeQueryable {
+   /**
+* Kafka record to be deserialized.
+* Record consists of key,value pair, topic name, partition offset, 
headers and a timestamp (if available)
+*/
+   interface Record {
 
 Review comment:
   I would echo @aljoscha 's comment regarding using `ConsumerRecord` from 
kafka directly. this `KeyedDeserializationSchema` is for kafka consumer only. 
there isn't much benefit of defining another Flink interface.
   
   just to give a counter point. I am also interested in exposing the 
`timestamp` field from `ConsumerRecord`. now we need to expand this interface.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] stevenzwu commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-19 Thread GitBox
stevenzwu commented on a change in pull request #6615: [FLINK-8354] 
[flink-connectors] Add ability to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#discussion_r249265860
 
 

 ##
 File path: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/KeyedDeserializationSchema.java
 ##
 @@ -32,6 +34,49 @@
  */
 @PublicEvolving
 public interface KeyedDeserializationSchema extends Serializable, 
ResultTypeQueryable {
+   /**
+* Kafka record to be deserialized.
+* Record consists of key,value pair, topic name, partition offset, 
headers and a timestamp (if available)
+*/
+   interface Record {
 
 Review comment:
   I am wondering if we should just use `ConsumerRecord` from kafka directly. 
this `KeyedDeserializationSchema` is for kafka consumer only. there isn't much 
benefit of defining another Flink interface.
   
   just to give a counter point. I am also interested in the `timestamp` field 
from `ConsumerRecord`. now we need to expand this interface.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] stevenzwu commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability to access and provider Kafka headers

2019-01-19 Thread GitBox
stevenzwu commented on a change in pull request #6615: [FLINK-8354] 
[flink-connectors] Add ability to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#discussion_r249265860
 
 

 ##
 File path: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/KeyedDeserializationSchema.java
 ##
 @@ -32,6 +34,49 @@
  */
 @PublicEvolving
 public interface KeyedDeserializationSchema extends Serializable, 
ResultTypeQueryable {
+   /**
+* Kafka record to be deserialized.
+* Record consists of key,value pair, topic name, partition offset, 
headers and a timestamp (if available)
+*/
+   interface Record {
 
 Review comment:
   I am wondering if we should just use ConsumerRecord from kafka directly. 
this `KeyedDeserializationSchema` is for kafka consumer only. there isn't much 
benefit of defining another Flink interface.
   
   just to give a counter point. I am also interested in the `timestamp` 
fields. now we need to expand this interface.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (FLINK-11366) Check and port TaskManagerMetricsTest to new code base if necessary

2019-01-19 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-11366:
---
Labels: pull-request-available  (was: )

> Check and port TaskManagerMetricsTest to new code base if necessary
> ---
>
> Key: FLINK-11366
> URL: https://issues.apache.org/jira/browse/FLINK-11366
> Project: Flink
>  Issue Type: Sub-task
>  Components: Tests
>Reporter: Till Rohrmann
>Assignee: Yun Tang
>Priority: Major
>  Labels: pull-request-available
>
> Check and port {{TaskManagerMetricsTest}} to new code base if necessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] Myasuka opened a new pull request #7544: [FLINK-11366][tests] Port TaskManagerMetricsTest to new code base

2019-01-19 Thread GitBox
Myasuka opened a new pull request #7544: [FLINK-11366][tests] Port 
TaskManagerMetricsTest to new code base
URL: https://github.com/apache/flink/pull/7544
 
 
   
   ## What is the purpose of the change
   Port `TaskManagerMetricsTest` to new code base.
   
   ## Brief change log
   
 - Move `TaskManagerMetricsTest`'s test to 
`TaskExecutorTest#testHeartbeatTimeoutWithResourceManager`
   
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   
 - Verify taskmanager's metrics registry was not shutdown due to the 
disconnect to RM
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (FLINK-11336) Flink HA didn't remove ZK metadata

2019-01-19 Thread shengjk1 (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747322#comment-16747322
 ] 

shengjk1 commented on FLINK-11336:
--

1.No matter what form stop flink, such  as cancel,failed with no further 
retries,kill, metadata not be deleted.

2.when cancel,failed with no further retries,kill,manually deleting metadata 
has no effect on newly launched programs even if there has a savepoint

this is my observed behavior

> Flink HA didn't remove ZK metadata
> --
>
> Key: FLINK-11336
> URL: https://issues.apache.org/jira/browse/FLINK-11336
> Project: Flink
>  Issue Type: Improvement
>Reporter: shengjk1
>Priority: Major
> Attachments: image-2019-01-15-19-42-21-902.png
>
>
> Flink HA didn't remove ZK metadata
> such as 
> go to zk cli  : ls /flinkone
> !image-2019-01-15-19-42-21-902.png!
>  
> i suggest we should delete this metadata when the application  cancel or 
> throw exception



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] anil477 commented on issue #6301: [FLINK-9794] [jdbc] JDBCOutputFormat does not consider idle connection and multithreads synchronization

2019-01-19 Thread GitBox
anil477 commented on issue #6301: [FLINK-9794] [jdbc] JDBCOutputFormat does not 
consider idle connection and multithreads synchronization
URL: https://github.com/apache/flink/pull/6301#issuecomment-455801153
 
 
   @yanghua @walterddr @sihuazhou This PR has been dormant for a while now. If 
it's waiting for other changes like using a Connection Poll implementation, I 
would like to take up the task. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (FLINK-11256) Referencing StreamNode objects directly in StreamEdge causes the sizes of JobGraph and TDD to become unnecessarily large

2019-01-19 Thread sunjincheng (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

sunjincheng closed FLINK-11256.
---
   Resolution: Fixed
Fix Version/s: 1.8.0

Fixed in master: a7eb845e812ab0355854d3cf26843179a5a8b597

> Referencing StreamNode objects directly in StreamEdge causes the sizes of 
> JobGraph and TDD to become unnecessarily large
> 
>
> Key: FLINK-11256
> URL: https://issues.apache.org/jira/browse/FLINK-11256
> Project: Flink
>  Issue Type: Bug
>  Components: Streaming
>Affects Versions: 1.7.0, 1.7.1
>Reporter: Haibo Suen
>Assignee: Haibo Suen
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When a job graph is generated from StreamGraph, StreamEdge(s) on the stream 
> graph are serialized to StreamConfig and stored into the job graph. After 
> that, the serialized bytes will be included in the TDD and distributed to TM. 
> Because StreamEdge directly reference to StreamNode objects including 
> sourceVertex and targetVertex, these objects are also written transitively on 
> serializing StreamEdge. But these StreamNode objects are not needed in JM and 
> Task. For a large size topology, this will causes JobGraph/TDD to become much 
> larger than that actually need, and more likely to occur rpc timeout when 
> transmitted.
> In StreamEdge, only the ID of StreamNode should be stored to avoid this 
> situation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] asfgit closed pull request #7403: [FLINK-11256] Replace the reference of StreamNode object with ID in S…

2019-01-19 Thread GitBox
asfgit closed pull request #7403: [FLINK-11256] Replace the reference of 
StreamNode object with ID in S…
URL: https://github.com/apache/flink/pull/7403
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] EugeneYushin commented on a change in pull request #6760: [FLINK-10422] Follow AWS specs in Kinesis Consumer

2019-01-19 Thread GitBox
EugeneYushin commented on a change in pull request #6760: [FLINK-10422] Follow 
AWS specs in Kinesis Consumer
URL: https://github.com/apache/flink/pull/6760#discussion_r249241807
 
 

 ##
 File path: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
 ##
 @@ -454,18 +453,6 @@ private ListShardsResult listShards(String streamName, 
@Nullable String startSha
}
}
}
-   // Kinesalite (mock implementation of Kinesis) does not 
correctly exclude shards before
 
 Review comment:
   @tweise thx for a feedback
   I've opened another PR for lytf fork: 
https://github.com/lyft/kinesalite/pull/4
   And pinged one more time contributors in original repo.
   
   Will keep you posted.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Closed] (FLINK-10342) Kafka duplicate topic consumption when topic name is changed

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi closed FLINK-10342.
---
Resolution: Fixed

> Kafka duplicate topic consumption when topic name is changed
> 
>
> Key: FLINK-10342
> URL: https://issues.apache.org/jira/browse/FLINK-10342
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Assignee: Oleksandr Nitavskyi
>Priority: Minor
>
> In case of topic name is simply renamed for a KafkaConsumer Flink starts to 
> consume from old and a new topic in the same time which can lead to 
> unexpected behavior.
> Here is the PR with reproduce: https://github.com/apache/flink/pull/6691
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (FLINK-10342) Kafka duplicate topic consumption when topic name is changed

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi reopened FLINK-10342:
-

> Kafka duplicate topic consumption when topic name is changed
> 
>
> Key: FLINK-10342
> URL: https://issues.apache.org/jira/browse/FLINK-10342
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Assignee: Oleksandr Nitavskyi
>Priority: Minor
>
> In case of topic name is simply renamed for a KafkaConsumer Flink starts to 
> consume from old and a new topic in the same time which can lead to 
> unexpected behavior.
> Here is the PR with reproduce: https://github.com/apache/flink/pull/6691
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (FLINK-10342) Kafka duplicate topic consumption when topic name is changed

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi closed FLINK-10342.
---
Resolution: Won't Fix

> Kafka duplicate topic consumption when topic name is changed
> 
>
> Key: FLINK-10342
> URL: https://issues.apache.org/jira/browse/FLINK-10342
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Assignee: Oleksandr Nitavskyi
>Priority: Minor
>
> In case of topic name is simply renamed for a KafkaConsumer Flink starts to 
> consume from old and a new topic in the same time which can lead to 
> unexpected behavior.
> Here is the PR with reproduce: https://github.com/apache/flink/pull/6691
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (FLINK-11396) MetricStore creates significant GC pressure

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


[ 
https://issues.apache.org/jira/browse/FLINK-11396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746997#comment-16746997
 ] 

Oleksandr Nitavskyi commented on FLINK-11396:
-

On GC tuning side, G1 ergonomic concluded we need to have a small Young Memory 
Pool (because short living object are created only during UI usage, which is 
rare), so alternative solution would be to set Yound Memory Pool size via 
parameters or use ParallelGC.

> MetricStore creates significant GC pressure
> ---
>
> Key: FLINK-11396
> URL: https://issues.apache.org/jira/browse/FLINK-11396
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: GC_parallel_flink_job_manager.log, g1.txt, gc_example.txt
>
>
> On Flink version 1.6.x we observe a significant increase of the latency in 
> UI. 
> After performance profiling, we have concluded that during UI rendering 
> back-end spends 50% of the time on GC pauses, which means that Flink 1.6.x is 
> not friendly with G1 GC ergonomics configurations. 
> On Flink side, MetricStore creates a huge amount of short living objects for 
> our job, which provokes a lot of Young GC pauses for a non-small job, with 
> around 50 operators and 120 parallelisms. 
> Samples of GC logs are in attach.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11396) MetricStore creates significant GC pressure

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11396:

Attachment: GC_parallel_flink_job_manager.log
g1.txt
gc_example.txt

> MetricStore creates significant GC pressure
> ---
>
> Key: FLINK-11396
> URL: https://issues.apache.org/jira/browse/FLINK-11396
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: GC_parallel_flink_job_manager.log, g1.txt, gc_example.txt
>
>
> On Flink version 1.6.x we observe a significant increase of the latency in 
> UI. 
> After performance profiling, we have concluded that during UI rendering 
> back-end spends 50% of the time on GC pauses, which means that Flink 1.6.x is 
> not friendly with G1 GC ergonomics configurations. 
> On Flink side, MetricStore creates a huge amount of short living objects for 
> our job, which provokes a lot of Young GC pauses for a non-small job, with 
> around 50 operators and 120 parallelisms. 
> Samples of GC logs are in attach.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (FLINK-11396) MetricStore creates significant GC pressure

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)
Oleksandr Nitavskyi created FLINK-11396:
---

 Summary: MetricStore creates significant GC pressure
 Key: FLINK-11396
 URL: https://issues.apache.org/jira/browse/FLINK-11396
 Project: Flink
  Issue Type: Bug
Reporter: Oleksandr Nitavskyi


On Flink version 1.6.x we observe a significant increase of the latency in UI. 

After performance profiling, we have concluded that during UI rendering 
back-end spends 50% of the time on GC pauses, which means that Flink 1.6.x is 
not friendly with G1 GC ergonomics configurations. 

On Flink side, MetricStore creates a huge amount of short living objects for 
our job, which provokes a lot of Young GC pauses for a non-small job, with 
around 50 operators and 120 parallelisms. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11396) MetricStore creates significant GC pressure

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11396:

Description: 
On Flink version 1.6.x we observe a significant increase of the latency in UI. 

After performance profiling, we have concluded that during UI rendering 
back-end spends 50% of the time on GC pauses, which means that Flink 1.6.x is 
not friendly with G1 GC ergonomics configurations. 

On Flink side, MetricStore creates a huge amount of short living objects for 
our job, which provokes a lot of Young GC pauses for a non-small job, with 
around 50 operators and 120 parallelisms. 

Samples of GC logs are in attach.

  was:
On Flink version 1.6.x we observe a significant increase of the latency in UI. 

After performance profiling, we have concluded that during UI rendering 
back-end spends 50% of the time on GC pauses, which means that Flink 1.6.x is 
not friendly with G1 GC ergonomics configurations. 

On Flink side, MetricStore creates a huge amount of short living objects for 
our job, which provokes a lot of Young GC pauses for a non-small job, with 
around 50 operators and 120 parallelisms. 


> MetricStore creates significant GC pressure
> ---
>
> Key: FLINK-11396
> URL: https://issues.apache.org/jira/browse/FLINK-11396
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
>
> On Flink version 1.6.x we observe a significant increase of the latency in 
> UI. 
> After performance profiling, we have concluded that during UI rendering 
> back-end spends 50% of the time on GC pauses, which means that Flink 1.6.x is 
> not friendly with G1 GC ergonomics configurations. 
> On Flink side, MetricStore creates a huge amount of short living objects for 
> our job, which provokes a lot of Young GC pauses for a non-small job, with 
> around 50 operators and 120 parallelisms. 
> Samples of GC logs are in attach.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11394) Job UI is not rendered in case of slow back-end

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11394:

Description: 
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=600,width=800! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!

  was:
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=250,width=450! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!


> Job UI is not rendered in case of slow back-end
> ---
>
> Key: FLINK-11394
> URL: https://issues.apache.org/jira/browse/FLINK-11394
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: image-2019-01-18-19-53-17-358.png, 
> image-2019-01-18-19-53-42-565.png, image-2019-01-18-19-54-36-964.png
>
>
> In case back-end requests for the job state take longer than 
> _web.refresh-interval_ Job UI is not rendered correctly.
> Request to back-end is made:
>  !image-2019-01-18-19-53-17-358.png|height=600,width=800! 
> In case one of refresh calls take more than _web.refresh-interval_ next 
> requests are made.
> !image-2019-01-18-19-53-42-565.png|height=250,width=250!
> The correct answer has been received on the UI side, but nothing has been 
> rendered.
>  !image-2019-01-18-19-54-36-964.png|height=250,width=250!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11394) Job UI is not rendered in case of slow back-end

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11394:

Description: 
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=400,width=800! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=400,width=800! 

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=400,width=800! 

  was:
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=400,width=800! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!


> Job UI is not rendered in case of slow back-end
> ---
>
> Key: FLINK-11394
> URL: https://issues.apache.org/jira/browse/FLINK-11394
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: image-2019-01-18-19-53-17-358.png, 
> image-2019-01-18-19-53-42-565.png, image-2019-01-18-19-54-36-964.png
>
>
> In case back-end requests for the job state take longer than 
> _web.refresh-interval_ Job UI is not rendered correctly.
> Request to back-end is made:
>  !image-2019-01-18-19-53-17-358.png|height=400,width=800! 
> In case one of refresh calls take more than _web.refresh-interval_ next 
> requests are made.
> !image-2019-01-18-19-53-42-565.png|height=400,width=800! 
> The correct answer has been received on the UI side, but nothing has been 
> rendered.
>  !image-2019-01-18-19-54-36-964.png|height=400,width=800! 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11394) Job UI is not rendered in case of slow back-end

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11394:

Description: 
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=400,width=800! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!

  was:
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=500,width=800! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!


> Job UI is not rendered in case of slow back-end
> ---
>
> Key: FLINK-11394
> URL: https://issues.apache.org/jira/browse/FLINK-11394
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: image-2019-01-18-19-53-17-358.png, 
> image-2019-01-18-19-53-42-565.png, image-2019-01-18-19-54-36-964.png
>
>
> In case back-end requests for the job state take longer than 
> _web.refresh-interval_ Job UI is not rendered correctly.
> Request to back-end is made:
>  !image-2019-01-18-19-53-17-358.png|height=400,width=800! 
> In case one of refresh calls take more than _web.refresh-interval_ next 
> requests are made.
> !image-2019-01-18-19-53-42-565.png|height=250,width=250!
> The correct answer has been received on the UI side, but nothing has been 
> rendered.
>  !image-2019-01-18-19-54-36-964.png|height=250,width=250!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11394) Job UI is not rendered in case of slow back-end

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11394:

Description: 
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=500,width=800! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!

  was:
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=600,width=800! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!


> Job UI is not rendered in case of slow back-end
> ---
>
> Key: FLINK-11394
> URL: https://issues.apache.org/jira/browse/FLINK-11394
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: image-2019-01-18-19-53-17-358.png, 
> image-2019-01-18-19-53-42-565.png, image-2019-01-18-19-54-36-964.png
>
>
> In case back-end requests for the job state take longer than 
> _web.refresh-interval_ Job UI is not rendered correctly.
> Request to back-end is made:
>  !image-2019-01-18-19-53-17-358.png|height=500,width=800! 
> In case one of refresh calls take more than _web.refresh-interval_ next 
> requests are made.
> !image-2019-01-18-19-53-42-565.png|height=250,width=250!
> The correct answer has been received on the UI side, but nothing has been 
> rendered.
>  !image-2019-01-18-19-54-36-964.png|height=250,width=250!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11394) Job UI is not rendered in case of slow back-end

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11394:

Description: 
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=250,width=450! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!

  was:
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=250,width=250! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!


> Job UI is not rendered in case of slow back-end
> ---
>
> Key: FLINK-11394
> URL: https://issues.apache.org/jira/browse/FLINK-11394
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: image-2019-01-18-19-53-17-358.png, 
> image-2019-01-18-19-53-42-565.png, image-2019-01-18-19-54-36-964.png
>
>
> In case back-end requests for the job state take longer than 
> _web.refresh-interval_ Job UI is not rendered correctly.
> Request to back-end is made:
>  !image-2019-01-18-19-53-17-358.png|height=250,width=450! 
> In case one of refresh calls take more than _web.refresh-interval_ next 
> requests are made.
> !image-2019-01-18-19-53-42-565.png|height=250,width=250!
> The correct answer has been received on the UI side, but nothing has been 
> rendered.
>  !image-2019-01-18-19-54-36-964.png|height=250,width=250!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (FLINK-11394) Job UI is not rendered in case of slow back-end

2019-01-19 Thread Oleksandr Nitavskyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/FLINK-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Nitavskyi updated FLINK-11394:

Description: 
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png|height=250,width=250! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png|height=250,width=250!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png|height=250,width=250!

  was:
In case back-end requests for the job state take longer than 
_web.refresh-interval_ Job UI is not rendered correctly.

Request to back-end is made:
 !image-2019-01-18-19-53-17-358.png! 

In case one of refresh calls take more than _web.refresh-interval_ next 
requests are made.

!image-2019-01-18-19-53-42-565.png!

The correct answer has been received on the UI side, but nothing has been 
rendered.

 !image-2019-01-18-19-54-36-964.png! 


> Job UI is not rendered in case of slow back-end
> ---
>
> Key: FLINK-11394
> URL: https://issues.apache.org/jira/browse/FLINK-11394
> Project: Flink
>  Issue Type: Bug
>Reporter: Oleksandr Nitavskyi
>Priority: Major
> Attachments: image-2019-01-18-19-53-17-358.png, 
> image-2019-01-18-19-53-42-565.png, image-2019-01-18-19-54-36-964.png
>
>
> In case back-end requests for the job state take longer than 
> _web.refresh-interval_ Job UI is not rendered correctly.
> Request to back-end is made:
>  !image-2019-01-18-19-53-17-358.png|height=250,width=250! 
> In case one of refresh calls take more than _web.refresh-interval_ next 
> requests are made.
> !image-2019-01-18-19-53-42-565.png|height=250,width=250!
> The correct answer has been received on the UI side, but nothing has been 
> rendered.
>  !image-2019-01-18-19-54-36-964.png|height=250,width=250!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] 123avi commented on issue #7418: FLINK-11053 Documentation - update scala sample code for bucketing sink according

2019-01-19 Thread GitBox
123avi commented on issue #7418: FLINK-11053 Documentation - update scala 
sample code for bucketing sink according
URL: https://github.com/apache/flink/pull/7418#issuecomment-455762397
 
 
   @hequn8128 any other modifications needed or this PR can be approved ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services