[jira] [Commented] (FLINK-12818) Improve stability of twoInputMapSink benchmark
[
https://issues.apache.org/jira/browse/FLINK-12818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913989#comment-16913989
]
Haibo Sun commented on FLINK-12818:
---
{quote}Alternatively until this is confirmed as a production code issue, we can
just try to live with this benchmark instability and relay on long term trends.
{quote}
+1. I think we can adopt this way first.
{quote}I think if we want to investigate this further, we would need to print
compiled byte code and try to understand the difference.
{quote}
I agree. I'll try when I have time.
> Improve stability of twoInputMapSink benchmark
> --
>
> Key: FLINK-12818
> URL: https://issues.apache.org/jira/browse/FLINK-12818
> Project: Flink
> Issue Type: Sub-task
> Components: Benchmarks
>Reporter: Piotr Nowojski
>Priority: Critical
> Attachments: RecordWriter-emit.png
>
>
> The {{twoInputMapSink}} benchmark is very unstable over time:
> http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=twoInputMapSink&env=2&revs=200&equid=off&quarts=on&extr=on
> It should be fixed, otherwise the benchmark can not be used.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] lirui-apache commented on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition …
lirui-apache commented on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition … URL: https://github.com/apache/flink/pull/9502#issuecomment-524194414 PR updated to get unquoted partition values in `RichSqlInsert`, so that we don't have to do it in HiveTableSink. @danny0405 better if you can also take a look. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey
flinkbot edited a comment on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey URL: https://github.com/apache/flink/pull/9517#issuecomment-524187390 ## CI report: * cdbd732fd99f2d2b5ad3cac2d119ef201079aafa : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124323759) * 19d2487dac6bcdd9308ab9948d610b3b3edf5b8f : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124325244) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator
flinkbot edited a comment on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator URL: https://github.com/apache/flink/pull/9516#issuecomment-524185347 ## CI report: * bde14e569d1d3c7ada5054bcf1acea1c8b41bc2d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124323122) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition …
flinkbot edited a comment on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition … URL: https://github.com/apache/flink/pull/9502#issuecomment-523778174 ## CI report: * 22278924cd49e4fab6eabb9bf4f6ec8310894808 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124170593) * 5ad14b3392b439f2b63b9fb079bf5546c874607d : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124325231) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey
flinkbot edited a comment on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey URL: https://github.com/apache/flink/pull/9517#issuecomment-524187390 ## CI report: * cdbd732fd99f2d2b5ad3cac2d119ef201079aafa : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124323759) * 19d2487dac6bcdd9308ab9948d610b3b3edf5b8f : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition …
flinkbot edited a comment on issue #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition … URL: https://github.com/apache/flink/pull/9502#issuecomment-523778174 ## CI report: * 22278924cd49e4fab6eabb9bf4f6ec8310894808 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124170593) * 5ad14b3392b439f2b63b9fb079bf5546c874607d : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-13365) Add documentation for reusing upstream operations when multi-sink is applied
[ https://issues.apache.org/jira/browse/FLINK-13365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-13365. --- Assignee: (was: Jing Zhang) Resolution: Fixed This has been introduced in FLINK-13354. > Add documentation for reusing upstream operations when multi-sink is applied > > > Key: FLINK-13365 > URL: https://issues.apache.org/jira/browse/FLINK-13365 > Project: Flink > Issue Type: Sub-task > Components: Documentation, Table SQL / Planner >Reporter: Jark Wu >Priority: Major > Fix For: 1.9.1 > > > Add documentation for reuse upstream operations when multi-sink > - “Performance Tuning / Multi-Sink Optimization”: How to avoid executing > common operators repeatedly if there are multiple TableSinks in a job. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition
flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition URL: https://github.com/apache/flink/pull/9416#issuecomment-520285701 ## CI report: * dbf749f0d0c3167265287b182dd1ea7b4aed84c1 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122738631) * 141896dbe8372442f95f7b6425b23a7cbb4cb624 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/122757944) * df40969ada1c232fb00e6aea33f9a1c88b07855c : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124324441) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-13364) Add documentation for setting resources in blink planner
[ https://issues.apache.org/jira/browse/FLINK-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-13364. --- Resolution: Fixed This has been introduced in FLINK-13119. > Add documentation for setting resources in blink planner > > > Key: FLINK-13364 > URL: https://issues.apache.org/jira/browse/FLINK-13364 > Project: Flink > Issue Type: Sub-task > Components: Documentation, Table SQL / Planner >Reporter: Jark Wu >Assignee: xupingyong >Priority: Major > Fix For: 1.9.1 > > > Add documentation for setting resources. > - “Performance Tuning / Resource Setting”: how to set resources in blink > planner, explain the configs and how they work together. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (FLINK-13105) Add documentation for blink planner's built-in functions
[ https://issues.apache.org/jira/browse/FLINK-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13105. - Resolution: Fixed master: c2b30d6a0c0c36ee85cf91c2b129302dea59ac70 1.9.1: 60c92bd77103651860e6d99d133aaffb463de11d > Add documentation for blink planner's built-in functions > > > Key: FLINK-13105 > URL: https://issues.apache.org/jira/browse/FLINK-13105 > Project: Flink > Issue Type: Sub-task > Components: Documentation, Table SQL / Planner >Reporter: Zhenghua Gao >Assignee: Zhenghua Gao >Priority: Critical > Labels: pull-request-available > Fix For: 1.9.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Blink planner intros some built-in functions which need to be documented. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey
flinkbot edited a comment on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey URL: https://github.com/apache/flink/pull/9517#issuecomment-524187390 ## CI report: * cdbd732fd99f2d2b5ad3cac2d119ef201079aafa : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124323759) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition
flinkbot edited a comment on issue #9416: [FLINK-13646][build system] Add basic ARM CI job definition URL: https://github.com/apache/flink/pull/9416#issuecomment-520285701 ## CI report: * dbf749f0d0c3167265287b182dd1ea7b4aed84c1 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122738631) * 141896dbe8372442f95f7b6425b23a7cbb4cb624 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/122757944) * df40969ada1c232fb00e6aea33f9a1c88b07855c : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] asfgit closed pull request #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
asfgit closed pull request #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions URL: https://github.com/apache/flink/pull/9002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey
flinkbot commented on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey URL: https://github.com/apache/flink/pull/9517#issuecomment-524187390 ## CI report: * cdbd732fd99f2d2b5ad3cac2d119ef201079aafa : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator
flinkbot edited a comment on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator URL: https://github.com/apache/flink/pull/9516#issuecomment-524185347 ## CI report: * bde14e569d1d3c7ada5054bcf1acea1c8b41bc2d : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124323122) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey
flinkbot commented on issue #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey URL: https://github.com/apache/flink/pull/9517#issuecomment-524185771 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit cdbd732fd99f2d2b5ad3cac2d119ef201079aafa (Fri Aug 23 06:09:22 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13779) PrometheusPushGatewayReporter support push metrics with groupingKey
[ https://issues.apache.org/jira/browse/FLINK-13779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13779: --- Labels: pull-request-available (was: ) > PrometheusPushGatewayReporter support push metrics with groupingKey > --- > > Key: FLINK-13779 > URL: https://issues.apache.org/jira/browse/FLINK-13779 > Project: Flink > Issue Type: New Feature > Components: Runtime / Metrics >Reporter: Kaibo Zhou >Assignee: Kaibo Zhou >Priority: Minor > Labels: pull-request-available > > The Prometheus push gateway java SDK support send metrics with _groupingKey_, > see > [doc|https://prometheus.github.io/client_java/io/prometheus/client/exporter/PushGateway.html#push-io.prometheus.client.CollectorRegistry-java.lang.String-java.util.Map-]. > > This feature will make it convenient for users to identify, group or filter > their metrics by defining _groupingKey (optional)_. The user does not need to > configure this by default, and the default behavior remains the same. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot commented on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator
flinkbot commented on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator URL: https://github.com/apache/flink/pull/9516#issuecomment-524185347 ## CI report: * bde14e569d1d3c7ada5054bcf1acea1c8b41bc2d : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] kaibozhou opened a new pull request #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey
kaibozhou opened a new pull request #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey URL: https://github.com/apache/flink/pull/9517 ## What is the purpose of the change The pushgateway already support send metrics with [groupingKey](https://prometheus.github.io/client_java/io/prometheus/client/exporter/PushGateway.html#push-io.prometheus.client.CollectorRegistry-java.lang.String-java.util.Map-), PrometheusPushGatewayReporter can support push metrics with groupingKey, which will be convenient for users to identify, group or filter their metrics. ## Brief change log - *parser groupingKey from user's config: k1=v1,k2=v2 to Map* - *Use PushGateway Java SDK to push with groupingKey* - *Use PushGateway Java SDK to delete with groupingKey** ## Verifying this change Run *PrometheusPushGatewayReporterTest* to verify the groupingKey config. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (docs will auto generated) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator
flinkbot commented on issue #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator URL: https://github.com/apache/flink/pull/9516#issuecomment-524185018 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit bde14e569d1d3c7ada5054bcf1acea1c8b41bc2d (Fri Aug 23 06:05:58 UTC 2019) **Warnings:** * **1 pom.xml files were touched**: Check for build and licensing issues. * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13815).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] carp84 opened a new pull request #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator
carp84 opened a new pull request #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator URL: https://github.com/apache/flink/pull/9516 ## What is the purpose of the change Adding allocators for off-heap byte buffer allocation, which is required by storing state on disk. ## Brief change log Mainly introduces two types of buffer allocators: `DirectBucketAllocator` and `PowerTwoBucketAllocator`. The former is for relatively big data, and the latter is a simple buddy-like allocator for small data. Also assures java 9+ compatibility referring to Hadoop's [CleanerUtil](https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/CleanerUtil.java). ## Verifying this change This change added tests under `org.apache.flink.runtime.state.heap.space` package. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (docs) - Added a design doc for `PowerTwoBucketAllocator` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13815) Implement the SpaceAllocator
[
https://issues.apache.org/jira/browse/FLINK-13815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-13815:
---
Labels: pull-request-available (was: )
> Implement the SpaceAllocator
>
>
> Key: FLINK-13815
> URL: https://issues.apache.org/jira/browse/FLINK-13815
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / State Backends
>Reporter: Yu Li
>Priority: Major
> Labels: pull-request-available
>
> As described in the design doc, we need a {{SpaceAllocator}} to allocate
> space on off-heap/disk to store the spilled key-group data.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-7151) Add a function SQL DDL
[
https://issues.apache.org/jira/browse/FLINK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913959#comment-16913959
]
Zhenqiu Huang commented on FLINK-7151:
--
[~phoenixjiangnan] As it is already in AthenaX. We would like to contribute
back. I will work with Shuyi on this. Thanks
> Add a function SQL DDL
> --
>
> Key: FLINK-7151
> URL: https://issues.apache.org/jira/browse/FLINK-7151
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: yuemeng
>Assignee: Shuyi Chen
>Priority: Critical
> Fix For: 1.10.0
>
>
> Based on create temporary function and table.we can register a udf,udaf,udtf
> use sql:
> {code}
> CREATE FUNCTION [IF NOT EXISTS] [catalog_name.db_name.]function_name AS
> class_name;
> DROP FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name;
> ALTER FUNCTION [IF EXISTS] [catalog_name.db_name.]function_name RENAME TO
> new_name;
> {code}
> {code}
> CREATE function 'TOPK' AS
> 'com..aggregate.udaf.distinctUdaf.topk.ITopKUDAF';
> INSERT INTO db_sink SELECT id, TOPK(price, 5, 'DESC') FROM kafka_source GROUP
> BY id;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
flinkbot edited a comment on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions URL: https://github.com/apache/flink/pull/9002#issuecomment-513721231 ## CI report: * 40477a632625f9cb7ebce8ed4488a99b7b4f5093 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119984603) * 64ad34dd196a8941ff9f92dd0b389a22796650f8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123663046) * c9a49c38c20a47954412605ac151416eb1f3bea6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123673855) * f6079350661e096dea2505aaaf29466aeee53ce4 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124054282) * 6dc82ded39c33867d6d3de364aa1aa3d5a654ddd : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124068158) * 32730d0b0f4ebc1d1c5ff2f677d6d46a1dc36273 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124317952) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode
flinkbot edited a comment on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#issuecomment-524181331 ## CI report: * 512499aae1ab33c5ae96c8a2100016e40d83b654 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124321949) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #7631: [FLINK-11391][shuffle] Introduce PartitionShuffleDescriptor and ShuffleDeploymentDescriptor
flinkbot edited a comment on issue #7631: [FLINK-11391][shuffle] Introduce PartitionShuffleDescriptor and ShuffleDeploymentDescriptor URL: https://github.com/apache/flink/pull/7631#issuecomment-524181162 ## CI report: * 48e3aacae9724023140ea5d4fc8007a1550477b1 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124321935) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode
flinkbot commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#issuecomment-524181331 ## CI report: * 512499aae1ab33c5ae96c8a2100016e40d83b654 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #7631: [FLINK-11391][shuffle] Introduce PartitionShuffleDescriptor and ShuffleDeploymentDescriptor
flinkbot commented on issue #7631: [FLINK-11391][shuffle] Introduce PartitionShuffleDescriptor and ShuffleDeploymentDescriptor URL: https://github.com/apache/flink/pull/7631#issuecomment-524181162 ## CI report: * 48e3aacae9724023140ea5d4fc8007a1550477b1 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] pnowojski commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode
pnowojski commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#issuecomment-524180337 @zhijiangW do we want to revisit this one? I came across this, when I was looking for this code in the master branch (I was sure that it has been merged) while checking out things for: > [DISCUSS] Enhance Support for Multicast Communication Pattern This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] pnowojski commented on issue #7631: [FLINK-11391][shuffle] Introduce PartitionShuffleDescriptor and ShuffleDeploymentDescriptor
pnowojski commented on issue #7631: [FLINK-11391][shuffle] Introduce PartitionShuffleDescriptor and ShuffleDeploymentDescriptor URL: https://github.com/apache/flink/pull/7631#issuecomment-524179915 @azagrebin @zhijiangW is this PR still valid? Or was it subsumed by something else? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] pnowojski commented on issue #7037: [FLINK-10790][network] Refactor StreamPartitioner implementations into runtime module
pnowojski commented on issue #7037: [FLINK-10790][network] Refactor StreamPartitioner implementations into runtime module URL: https://github.com/apache/flink/pull/7037#issuecomment-524179740 I'm closing this PR @zhijiangW for now. If you will want to re-open it, please feel free to do so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] pnowojski closed pull request #7037: [FLINK-10790][network] Refactor StreamPartitioner implementations into runtime module
pnowojski closed pull request #7037: [FLINK-10790][network] Refactor StreamPartitioner implementations into runtime module URL: https://github.com/apache/flink/pull/7037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (FLINK-13025) Elasticsearch 7.x support
[ https://issues.apache.org/jira/browse/FLINK-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913944#comment-16913944 ] Dongwon Kim edited comment on FLINK-13025 at 8/23/19 5:25 AM: -- [1] says flink-connector-elasticsearch6_2.11 can be used with Elasticsearch 6 and later versions as shown in the last row of the table, which implies that it can support Elasticsearch 7.x but we failed. Therefore, [1] needs to be updated accordingly: "6 and later versions" -> "6" [1] https://ci.apache.org/projects/flink/flink-docs-stable/dev/connectors/elasticsearch.html#elasticsearch-connector was (Author: eastcirclek): [1] says flink-connector-elasticsearch6_2.11 can be used "6 and later versions" as shown in the last row of the table in [1], which implies that it can support Elasticsearch 7.x but we failed. Therefore, [1] needs to be updated accordingly: "6 and later versions" -> "6" [1] https://ci.apache.org/projects/flink/flink-docs-stable/dev/connectors/elasticsearch.html#elasticsearch-connector > Elasticsearch 7.x support > - > > Key: FLINK-13025 > URL: https://issues.apache.org/jira/browse/FLINK-13025 > Project: Flink > Issue Type: New Feature > Components: Connectors / ElasticSearch >Affects Versions: 1.8.0 >Reporter: Keegan Standifer >Priority: Major > > Elasticsearch 7.0.0 was released in April of 2019: > [https://www.elastic.co/blog/elasticsearch-7-0-0-released] > The latest elasticsearch connector is > [flink-connector-elasticsearch6|https://github.com/apache/flink/tree/master/flink-connectors/flink-connector-elasticsearch6] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-13025) Elasticsearch 7.x support
[ https://issues.apache.org/jira/browse/FLINK-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913944#comment-16913944 ] Dongwon Kim commented on FLINK-13025: - [1] says flink-connector-elasticsearch6_2.11 can be used "6 and later versions" as shown in the last row of the table in [1], which implies that it can support Elasticsearch 7.x but we failed. Therefore, [1] needs to be updated accordingly: "6 and later versions" -> "6" [1] https://ci.apache.org/projects/flink/flink-docs-stable/dev/connectors/elasticsearch.html#elasticsearch-connector > Elasticsearch 7.x support > - > > Key: FLINK-13025 > URL: https://issues.apache.org/jira/browse/FLINK-13025 > Project: Flink > Issue Type: New Feature > Components: Connectors / ElasticSearch >Affects Versions: 1.8.0 >Reporter: Keegan Standifer >Priority: Major > > Elasticsearch 7.0.0 was released in April of 2019: > [https://www.elastic.co/blog/elasticsearch-7-0-0-released] > The latest elasticsearch connector is > [flink-connector-elasticsearch6|https://github.com/apache/flink/tree/master/flink-connectors/flink-connector-elasticsearch6] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r316976697
##
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
##
@@ -69,6 +74,7 @@ public void testPerJobMode() throws Exception {
runTest(() -> {
Configuration configuration = new Configuration();
configuration.setString(AkkaOptions.ASK_TIMEOUT, "30
s");
+
configuration.setString(YarnConfigOptions.FILE_REPLICATION, "5");
Review comment:
Sure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r316976653
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##
@@ -746,6 +746,17 @@ public ApplicationReport startAppMaster(
// ship list that enables reuse of resources for task manager
containers
StringBuilder envShipFileList = new StringBuilder();
+ int fileReplication =
yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY,
DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+ if
(flinkConfiguration.contains(YarnConfigOptions.FILE_REPLICATION)) {
+ try {
+ final String replication =
flinkConfiguration.getString(YarnConfigOptions.FILE_REPLICATION);
Review comment:
ConfigOption is not nullable. Per your last suggestion, if the
FILE_REPLICATION is not set, then we will use the default value.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
flinkbot edited a comment on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions URL: https://github.com/apache/flink/pull/9002#issuecomment-513721231 ## CI report: * 40477a632625f9cb7ebce8ed4488a99b7b4f5093 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119984603) * 64ad34dd196a8941ff9f92dd0b389a22796650f8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123663046) * c9a49c38c20a47954412605ac151416eb1f3bea6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123673855) * f6079350661e096dea2505aaaf29466aeee53ce4 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124054282) * 6dc82ded39c33867d6d3de364aa1aa3d5a654ddd : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124068158) * 32730d0b0f4ebc1d1c5ff2f677d6d46a1dc36273 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124317952) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
flinkbot edited a comment on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions URL: https://github.com/apache/flink/pull/9002#issuecomment-513721231 ## CI report: * 40477a632625f9cb7ebce8ed4488a99b7b4f5093 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119984603) * 64ad34dd196a8941ff9f92dd0b389a22796650f8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123663046) * c9a49c38c20a47954412605ac151416eb1f3bea6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123673855) * f6079350661e096dea2505aaaf29466aeee53ce4 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124054282) * 6dc82ded39c33867d6d3de364aa1aa3d5a654ddd : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124068158) * 32730d0b0f4ebc1d1c5ff2f677d6d46a1dc36273 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] docete commented on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
docete commented on issue #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions URL: https://github.com/apache/flink/pull/9002#issuecomment-524167790 @wuchong Thanks for your comments and LGTM for your changes expect for parameters of STR_TO_MAP. I have fixed that. Please have a look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
docete commented on a change in pull request #9002: [FLINK-13105][table][doc]
Add documentation for blink planner's built-in functions
URL: https://github.com/apache/flink/pull/9002#discussion_r316965281
##
File path: docs/dev/table/functions.md
##
@@ -1466,6 +1466,18 @@ TRUNCATE(numeric1, integer2)
E.g. truncate(42.345, 2) to 42.34. and
truncate(42.345) to 42.0.
+
+
+
+{% highlight text %}
+PI()
+{% endhighlight %}
+
+
+ Returns a value that is closer than any other values to pi.
Review comment:
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase
flinkbot edited a comment on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase URL: https://github.com/apache/flink/pull/9515#issuecomment-524154431 ## CI report: * b6645c0abcbbe6a94586916772b15bea15818d95 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124313513) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (FLINK-13354) Add documentation for how to use blink planner
[ https://issues.apache.org/jira/browse/FLINK-13354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13354. - Resolution: Fixed master: 57bb00a19f296312b3c06599901f4ef529d2feaf 1.9.1: 1dce49445263cca3733c3923c129c7c3c1f9b581 > Add documentation for how to use blink planner > -- > > Key: FLINK-13354 > URL: https://issues.apache.org/jira/browse/FLINK-13354 > Project: Flink > Issue Type: Sub-task > Components: Documentation, Table SQL / Planner >Reporter: Jark Wu >Assignee: godfrey he >Priority: Critical > Labels: pull-request-available > Fix For: 1.9.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Add documentation for how to use different planner > - “Overview”: add pom dependency > - “Concepts & Common API”: add description about how to use different > planner in code -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] asfgit closed pull request #9362: [FLINK-13354] [docs] Add documentation for how to use blink planner
asfgit closed pull request #9362: [FLINK-13354] [docs] Add documentation for how to use blink planner URL: https://github.com/apache/flink/pull/9362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wuchong commented on issue #9362: [FLINK-13354] [docs] Add documentation for how to use blink planner
wuchong commented on issue #9362: [FLINK-13354] [docs] Add documentation for how to use blink planner URL: https://github.com/apache/flink/pull/9362#issuecomment-524160913 I will merge this PR first to make users can know how to use blink planner for the release. We can improve the content in following PRs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) * 57a5ab12b5cfca106a2352892d2334f83273d86c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124300218) * 694ad929be390ad0a37406b499f8e8ba68346399 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124310900) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] hequn8128 closed pull request #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase
hequn8128 closed pull request #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase URL: https://github.com/apache/flink/pull/9515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13740) TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913889#comment-16913889
]
Hequn Cheng commented on FLINK-13740:
-
The hotfix(b6645c0abcbbe6a94586916772b15bea15818d95) has been merged into the
master.
> TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
> ---
>
> Key: FLINK-13740
> URL: https://issues.apache.org/jira/browse/FLINK-13740
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The {{TableAggregateITCase.testNonkeyedFlatAggregate}} failed on Travis with
> {code}
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase.testNonkeyedFlatAggregate(TableAggregateITCase.scala:93)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.com/v3/job/225551182/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] docete commented on a change in pull request #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
docete commented on a change in pull request #9002: [FLINK-13105][table][doc]
Add documentation for blink planner's built-in functions
URL: https://github.com/apache/flink/pull/9002#discussion_r316963583
##
File path: docs/dev/table/functions.md
##
@@ -1466,6 +1466,18 @@ TRUNCATE(numeric1, integer2)
E.g. truncate(42.345, 2) to 42.34. and
truncate(42.345) to 42.0.
+
+
+
+{% highlight text %}
+PI()
+{% endhighlight %}
+
+
+ Returns a value that is closer than any other values to pi.
+ Only supported in blink planner. Only supported in SQL api.
Review comment:
OK.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] docete commented on a change in pull request #9002: [FLINK-13105][table][doc] Add documentation for blink planner's built-in functions
docete commented on a change in pull request #9002: [FLINK-13105][table][doc]
Add documentation for blink planner's built-in functions
URL: https://github.com/apache/flink/pull/9002#discussion_r316963527
##
File path: docs/dev/table/functions.md
##
@@ -2689,6 +2701,177 @@ TO_BASE64(string)
E.g., TO_BASE64('hello world') returns
"aGVsbG8gd29ybGQ=".
+
+
+
+{% highlight text %}
+ASCII(string)
+{% endhighlight %}
+
+
+Returns the numeric value of the first character of string.
Returns NULL if string is NULL.
+Only supported in blink planner. Only supported in SQL api.
+E.g., ascii('abc') returns 97, and
ascii(CAST(NULL AS VARCHAR)) returns NULL.
+
+
+
+
+
+{% highlight text %}
+CHR(integer)
+{% endhighlight %}
+
+
+Returns the ASCII character having the binary equivalent to
integer. If integer is larger than 255 the result is equivalent
to chr(bitand(integer,256). Returns NULL if integer is NULL.
Review comment:
Make sense, will fix it soon.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase
flinkbot edited a comment on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase URL: https://github.com/apache/flink/pull/9515#issuecomment-524154431 ## CI report: * b6645c0abcbbe6a94586916772b15bea15818d95 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124313513) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #9504: [FLINK-13799][web]: fix error message web submit is disables in the c…
vthinkxie commented on a change in pull request #9504: [FLINK-13799][web]: fix
error message web submit is disables in the c…
URL: https://github.com/apache/flink/pull/9504#discussion_r316959338
##
File path: flink-runtime-web/web-dashboard/src/app/app.interceptor.ts
##
@@ -32,7 +32,7 @@ export class AppInterceptor implements HttpInterceptor {
* Error response from below url should be ignored
*/
const ignoreErrorUrlEndsList = ['checkpoints/config', 'checkpoints'];
-const ignoreErrorMessage = ['File not found.'];
+const ignoreErrorMessage = ['File not found.', 'Unable to load requested
file /jars.'];
Review comment:
the upload button in the submit page is already hidden when getting the
error message, so the user could not use the submit page in the case.
I think we should wait for the proper solution if not hurry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Closed] (FLINK-13772) GroupWindowTableAggregateITCase tests fail on Travis
[
https://issues.apache.org/jira/browse/FLINK-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hequn Cheng closed FLINK-13772.
---
Resolution: Fixed
> GroupWindowTableAggregateITCase tests fail on Travis
>
>
> Key: FLINK-13772
> URL: https://issues.apache.org/jira/browse/FLINK-13772
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The
> {{GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane}}
> fails on Travis:
> {code}
> 05:21:41.532 [ERROR] Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 14.039 s <<< FAILURE! - in
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase
> 05:21:41.532 [ERROR]
> testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane[StateBackend=HEAP](org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase)
> Time elapsed: 0.573 s <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane(GroupWindowTableAggregateITCase.scala:301)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.org/v3/job/573615974/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (FLINK-13772) GroupWindowTableAggregateITCase tests fail on Travis
[
https://issues.apache.org/jira/browse/FLINK-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913849#comment-16913849
]
Hequn Cheng edited comment on FLINK-13772 at 8/23/19 3:03 AM:
--
As discussed in FLINK-13740. The serializer logic contains a bug which leads to
the test failure in TableAggregate tests.
I will open a hotfix to ignore the tests for the time being. We can recover the
tests once the bug is fixed in blink-planner.
was (Author: hequn8128):
Same problem as in FLINK-13740
> GroupWindowTableAggregateITCase tests fail on Travis
>
>
> Key: FLINK-13772
> URL: https://issues.apache.org/jira/browse/FLINK-13772
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The
> {{GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane}}
> fails on Travis:
> {code}
> 05:21:41.532 [ERROR] Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 14.039 s <<< FAILURE! - in
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase
> 05:21:41.532 [ERROR]
> testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane[StateBackend=HEAP](org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase)
> Time elapsed: 0.573 s <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane(GroupWindowTableAggregateITCase.scala:301)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.org/v3/job/573615974/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot commented on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase
flinkbot commented on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase URL: https://github.com/apache/flink/pull/9515#issuecomment-524154431 ## CI report: * b6645c0abcbbe6a94586916772b15bea15818d95 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #9504: [FLINK-13799][web]: fix error message web submit is disables in the c…
vthinkxie commented on a change in pull request #9504: [FLINK-13799][web]: fix
error message web submit is disables in the c…
URL: https://github.com/apache/flink/pull/9504#discussion_r316959338
##
File path: flink-runtime-web/web-dashboard/src/app/app.interceptor.ts
##
@@ -32,7 +32,7 @@ export class AppInterceptor implements HttpInterceptor {
* Error response from below url should be ignored
*/
const ignoreErrorUrlEndsList = ['checkpoints/config', 'checkpoints'];
-const ignoreErrorMessage = ['File not found.'];
+const ignoreErrorMessage = ['File not found.', 'Unable to load requested
file /jars.'];
Review comment:
the upload button in the submit page is already hidden when getting the
error message, so the user could not use the submit page in the case.
I think we should wait for the proper solution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase
flinkbot commented on issue #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase URL: https://github.com/apache/flink/pull/9515#issuecomment-524153818 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit b6645c0abcbbe6a94586916772b15bea15818d95 (Fri Aug 23 03:00:10 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] hequn8128 opened a new pull request #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase
hequn8128 opened a new pull request #9515: [hotfix][table-blink] Ignore tests in GroupWindowTableAggregateITCase and TableAggregateITCase URL: https://github.com/apache/flink/pull/9515 ## What is the purpose of the change As discussed in [FLINK-13740](https://issues.apache.org/jira/browse/FLINK-13740). The serializer logic contains a bug which leads to the test failure in TableAggregate tests. This pr tries to ignore the tests in TableAggregate and recover it once the bug is fixed in blink-planner. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution
flinkbot edited a comment on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-523364967 ## CI report: * b383982c0f9353b799ba85ca2635cd9b5f3e24a8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124020443) * dec3458bf0f82c673cbcc9b686f590a83062 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124183689) * f97118b164679e2f771ab242c57dcbcff8d51053 : PENDING [Build](TBD) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution
TisonKun commented on issue #9497: [FLINK-13794][client] Remove unused logic of printStatusDuringExecution URL: https://github.com/apache/flink/pull/9497#issuecomment-524150322 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9488: [hotfix][docs] Update local setup tutorials to fit new log messages
TisonKun commented on issue #9488: [hotfix][docs] Update local setup tutorials to fit new log messages URL: https://github.com/apache/flink/pull/9488#issuecomment-524150272 @rmetzger could you help merge this hotfix? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9510: [FLINK-13807][tests] Read file with UTF-8 charset in TestBaseUtils.getResultReader
TisonKun commented on issue #9510: [FLINK-13807][tests] Read file with UTF-8 charset in TestBaseUtils.getResultReader URL: https://github.com/apache/flink/pull/9510#issuecomment-524149924 @zentol travis fails on a known issue [FLINK-13769](https://issues.apache.org/jira/browse/FLINK-13769). Shall we retest this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) * 57a5ab12b5cfca106a2352892d2334f83273d86c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124300218) * 694ad929be390ad0a37406b499f8e8ba68346399 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124310900) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13750) Separate HA services between client-/ and server-side
[
https://issues.apache.org/jira/browse/FLINK-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913856#comment-16913856
]
TisonKun commented on FLINK-13750:
--
Hi [~till.rohrmann][~Zentol], I sent a pull request GH-9509 follow our
discussion above. Please give it a look :- )
Besides, here I'd like to start a new sub-topic, shall we expose "leaderInfo"
to client? The only usage I see is to log in {{FlinkYarnSessionCli}} and
extract dispatcher host:port in {{FlinkShell}} under YARN scenario. I think of
an alternative instead of expose "leaderInfo" to client. Or we just design to
expose it here.
> Separate HA services between client-/ and server-side
> -
>
> Key: FLINK-13750
> URL: https://issues.apache.org/jira/browse/FLINK-13750
> Project: Flink
> Issue Type: Improvement
> Components: Command Line Client, Runtime / Coordination
>Reporter: Chesnay Schepler
>Assignee: TisonKun
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, we use the same {{HighAvailabilityServices}} on the client and
> server. However, the client does not need several of the features that the
> services currently provide (access to the blobstore or checkpoint metadata).
> Additionally, due to how these services are setup they also require the
> client to have access to the blob storage, despite it never actually being
> used, which can cause issues, like FLINK-13500.
> [~Tison] Would be be interested in this issue?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) * 57a5ab12b5cfca106a2352892d2334f83273d86c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124300218) * 694ad929be390ad0a37406b499f8e8ba68346399 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-13822) TableAggregateITCase.testGroupByFlatAggregate test failure: IllegalStateException: Concurrent access to KryoSerializer.
[
https://issues.apache.org/jira/browse/FLINK-13822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu closed FLINK-13822.
---
Resolution: Duplicate
> TableAggregateITCase.testGroupByFlatAggregate test failure:
> IllegalStateException: Concurrent access to KryoSerializer.
> ---
>
> Key: FLINK-13822
> URL: https://issues.apache.org/jira/browse/FLINK-13822
> Project: Flink
> Issue Type: Bug
>Reporter: Alex
>Priority: Major
>
> {code}
> [ERROR]
> testGroupByFlatAggregate[StateBackend=HEAP](org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase)
> Time elapsed: 0.643 s <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase.testGroupByFlatAggregate(TableAggregateITCase.scala:59)
> Caused by: java.lang.IllegalStateException: Concurrent access to
> KryoSerializer. Thread 1: GroupTableAggregate -> Calc(select=[b AS category,
> f0 AS v1, f1 AS v2]) -> SinkConversionToTuple2 (1/4) , Thread 2:
> AsyncOperations-thread-1
> {code}
> CI log: https://api.travis-ci.com/v3/job/227362742/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-13740) TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913853#comment-16913853
]
Jark Wu commented on FLINK-13740:
-
Agree with you [~hequn8128]. Let's ignore the tests first. And discuss the
solution under this Jira issue.
> TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
> ---
>
> Key: FLINK-13740
> URL: https://issues.apache.org/jira/browse/FLINK-13740
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The {{TableAggregateITCase.testNonkeyedFlatAggregate}} failed on Travis with
> {code}
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase.testNonkeyedFlatAggregate(TableAggregateITCase.scala:93)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.com/v3/job/225551182/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (FLINK-13790) Support -q option with a sql query statement as input
[ https://issues.apache.org/jira/browse/FLINK-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-13790: - Summary: Support -q option with a sql query statement as input (was: Support -e option with a sql script file as input) > Support -q option with a sql query statement as input > - > > Key: FLINK-13790 > URL: https://issues.apache.org/jira/browse/FLINK-13790 > Project: Flink > Issue Type: Sub-task > Components: Command Line Client >Reporter: Bowen Li >Assignee: Zhenghua Gao >Priority: Major > Fix For: 1.10.0 > > > We expect user to run SQL directly on the command line. Something like: > sql-client embedded -e "query in string", which will execute the given query > without entering interactive mode > This is related to FLINK-12828. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13790) Support -q option with a sql query statement as input
[ https://issues.apache.org/jira/browse/FLINK-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-13790: - Description: We expect user to run SQL directly on the command line. Something like: sql-client embedded -q "query in string", which will execute the given query without entering interactive mode This is related to FLINK-12828. was: We expect user to run SQL directly on the command line. Something like: sql-client embedded -e "query in string", which will execute the given query without entering interactive mode This is related to FLINK-12828. > Support -q option with a sql query statement as input > - > > Key: FLINK-13790 > URL: https://issues.apache.org/jira/browse/FLINK-13790 > Project: Flink > Issue Type: Sub-task > Components: Command Line Client >Reporter: Bowen Li >Assignee: Zhenghua Gao >Priority: Major > Fix For: 1.10.0 > > > We expect user to run SQL directly on the command line. Something like: > sql-client embedded -q "query in string", which will execute the given query > without entering interactive mode > This is related to FLINK-12828. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (FLINK-13772) GroupWindowTableAggregateITCase tests fail on Travis
[
https://issues.apache.org/jira/browse/FLINK-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913849#comment-16913849
]
Hequn Cheng commented on FLINK-13772:
-
Same problem as in FLINK-13740
> GroupWindowTableAggregateITCase tests fail on Travis
>
>
> Key: FLINK-13772
> URL: https://issues.apache.org/jira/browse/FLINK-13772
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The
> {{GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane}}
> fails on Travis:
> {code}
> 05:21:41.532 [ERROR] Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 14.039 s <<< FAILURE! - in
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase
> 05:21:41.532 [ERROR]
> testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane[StateBackend=HEAP](org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase)
> Time elapsed: 0.573 s <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane(GroupWindowTableAggregateITCase.scala:301)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.org/v3/job/573615974/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-13740) TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
[
https://issues.apache.org/jira/browse/FLINK-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913845#comment-16913845
]
Hequn Cheng commented on FLINK-13740:
-
Hi, [~jark] [~lzljs3620320] the same problem is reported by another jira
FLINK-13822. Would be great if you can take another look and fix it.
Another option is ignoring the test case for the time being if you find fixing
the problem in blink planner needs more time to discuss. (I can do it if it is
true.)
Thanks, Hequn
> TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
> ---
>
> Key: FLINK-13740
> URL: https://issues.apache.org/jira/browse/FLINK-13740
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The {{TableAggregateITCase.testNonkeyedFlatAggregate}} failed on Travis with
> {code}
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase.testNonkeyedFlatAggregate(TableAggregateITCase.scala:93)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.com/v3/job/225551182/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) * 57a5ab12b5cfca106a2352892d2334f83273d86c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124300218) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph
flinkbot edited a comment on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph URL: https://github.com/apache/flink/pull/9514#issuecomment-52458 ## CI report: * 6092a6154f8275957d306c9d04b780ccd374b5d9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124258242) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) * 57a5ab12b5cfca106a2352892d2334f83273d86c : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124300218) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9476: [FLINK-13764][task, metrics] Pass the counter of numRecordsIn into the constructor of StreamInputProcessor
flinkbot edited a comment on issue #9476: [FLINK-13764][task, metrics] Pass the counter of numRecordsIn into the constructor of StreamInputProcessor URL: https://github.com/apache/flink/pull/9476#issuecomment-522355867 ## CI report: * df58cd55f5ca284e412ebbfc35c336e4f012974c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123646651) * 870e9199aa5afbbdea0bccffcb2fa4c2fa26ec8f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124293088) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) * 57a5ab12b5cfca106a2352892d2334f83273d86c : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #9512: [FLINK-13819][coordination] Introduce State for RpcEndpoint
TisonKun commented on a change in pull request #9512:
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r316920238
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##
@@ -137,18 +153,26 @@ public final void start() {
* @throws Exception indicating that the rpc endpoint could not be
started. If an exception occurs,
* then the rpc endpoint will automatically terminate.
*/
- public void onStart() throws Exception {}
+ public final void doStart() throws Exception {
Review comment:
Make sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext
flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-522374042 ## CI report: * 1530600eaf36324966f343c277437e48c2416dc2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123653758) * 8d08aaa1fedf7338ef3de48991e841f9baf7018b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123700944) * 9791697c559fa39cd9f7a1c574420d62a1193545 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124210361) * fbd14e2320371a3cd6615deee0498d477644b954 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124297960) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph
flinkbot edited a comment on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph URL: https://github.com/apache/flink/pull/9514#issuecomment-52458 ## CI report: * 6092a6154f8275957d306c9d04b780ccd374b5d9 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124258242) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext
flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-522374042 ## CI report: * 1530600eaf36324966f343c277437e48c2416dc2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123653758) * 8d08aaa1fedf7338ef3de48991e841f9baf7018b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123700944) * 9791697c559fa39cd9f7a1c574420d62a1193545 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124210361) * fbd14e2320371a3cd6615deee0498d477644b954 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124297960) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext
flinkbot edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-522374042 ## CI report: * 1530600eaf36324966f343c277437e48c2416dc2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123653758) * 8d08aaa1fedf7338ef3de48991e841f9baf7018b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123700944) * 9791697c559fa39cd9f7a1c574420d62a1193545 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124210361) * fbd14e2320371a3cd6615deee0498d477644b954 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph
TisonKun commented on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph URL: https://github.com/apache/flink/pull/9514#issuecomment-524105211 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
TisonKun commented on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-524105145 @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9476: [FLINK-13764][task, metrics] Pass the counter of numRecordsIn into the constructor of StreamInputProcessor
flinkbot edited a comment on issue #9476: [FLINK-13764][task, metrics] Pass the counter of numRecordsIn into the constructor of StreamInputProcessor URL: https://github.com/apache/flink/pull/9476#issuecomment-522355867 ## CI report: * df58cd55f5ca284e412ebbfc35c336e4f012974c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123646651) * 870e9199aa5afbbdea0bccffcb2fa4c2fa26ec8f : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/124293088) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9476: [FLINK-13764][task, metrics] Pass the counter of numRecordsIn into the constructor of StreamInputProcessor
flinkbot edited a comment on issue #9476: [FLINK-13764][task, metrics] Pass the counter of numRecordsIn into the constructor of StreamInputProcessor URL: https://github.com/apache/flink/pull/9476#issuecomment-522355867 ## CI report: * df58cd55f5ca284e412ebbfc35c336e4f012974c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123646651) * 870e9199aa5afbbdea0bccffcb2fa4c2fa26ec8f : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph
flinkbot edited a comment on issue #9514: [FLINK-13573][coordination] Merge SubmittedJobGraph into JobGraph URL: https://github.com/apache/flink/pull/9514#issuecomment-52458 ## CI report: * 6092a6154f8275957d306c9d04b780ccd374b5d9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124258242) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (FLINK-11241) Enhance TableEnvironment to connect to a catalog via a descriptor
[
https://issues.apache.org/jira/browse/FLINK-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eron Wright reassigned FLINK-11241:
Assignee: (was: Eron Wright )
> Enhance TableEnvironment to connect to a catalog via a descriptor
> -
>
> Key: FLINK-11241
> URL: https://issues.apache.org/jira/browse/FLINK-11241
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: Eron Wright
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Given FLINK-11240, extend {{TableEnvironment}} to connect to an external
> catalog via an {{ExternalCatalogDescriptor}}. Consider extending the
> existing {{connect()}} method.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (FLINK-11238) Enhance SQL-Client to recursively list tables
[
https://issues.apache.org/jira/browse/FLINK-11238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eron Wright reassigned FLINK-11238:
Assignee: (was: Eron Wright )
> Enhance SQL-Client to recursively list tables
> -
>
> Key: FLINK-11238
> URL: https://issues.apache.org/jira/browse/FLINK-11238
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Client
>Reporter: Eron Wright
>Priority: Major
>
> The SQL Client provides a {{SHOW TABLES}} command. Tables that are added
> via an external catalog should be listed (presently, only the root schema is
> listed).
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [flink] flinkbot edited a comment on issue #8175: [FLINK-9787]Change ExecutionConfig#getGlobalJobParameters to return a…
flinkbot edited a comment on issue #8175: [FLINK-9787]Change ExecutionConfig#getGlobalJobParameters to return a… URL: https://github.com/apache/flink/pull/8175#issuecomment-523993728 ## CI report: * fe71dc563e7d69da189c9d74f84f34fa60486121 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124256028) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9507: [travis][hotfix] Travis scripts refactoring
flinkbot edited a comment on issue #9507: [travis][hotfix] Travis scripts refactoring URL: https://github.com/apache/flink/pull/9507#issuecomment-523838542 ## CI report: * f95391f21b1fcad234145f13746822decc1bbe8c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124195773) * fbf6d25c4d580a5a63b26df6435d691d0bc9fff5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124235043) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services
flinkbot edited a comment on issue #9509: [FLINK-13750][client] Separate client/cluster-side high-availability services URL: https://github.com/apache/flink/pull/9509#issuecomment-523852882 ## CI report: * a5a0a74cb3e2bef0cd7352a6cb8e7697cbd79f75 : UNKNOWN * bde5de0cc669dec593e090e5425f39d56c220830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124201954) * 63ab3d431bf8256dfb071574e013f0e878e40cef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124203053) * fe6f2ab1d566100cd63941e890e2d34947ea43b8 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124205327) * ccb85242c0c0a5f2fec18f7d67dd5293e9ad2dce : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/124238221) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] xuefuz commented on a change in pull request #9502: [FLINK-13814][hive] HiveTableSink should strip quotes from partition …
xuefuz commented on a change in pull request #9502: [FLINK-13814][hive]
HiveTableSink should strip quotes from partition …
URL: https://github.com/apache/flink/pull/9502#discussion_r316821021
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSink.java
##
@@ -170,7 +171,7 @@ public void setStaticPartition(Map
partitionSpec) {
staticPartitionSpec = new LinkedHashMap<>();
for (String partitionCol : getPartitionFieldNames()) {
if (partitionSpec.containsKey(partitionCol)) {
- staticPartitionSpec.put(partitionCol,
partitionSpec.get(partitionCol));
+ staticPartitionSpec.put(partitionCol,
PlanUtils.stripQuotes(partitionSpec.get(partitionCol)));
Review comment:
Just curious, partitionSpec is a map of strings, and the value should
probably have been unquoted before getting here. I'm wondering if the fix
should be at a lower level than here. Otherwise, similar fix will be needed
wherever such partition spec is used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (FLINK-13814) HiveTableSink should strip quotes from partition values
[ https://issues.apache.org/jira/browse/FLINK-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-13814: - Fix Version/s: 1.9.1 > HiveTableSink should strip quotes from partition values > --- > > Key: FLINK-13814 > URL: https://issues.apache.org/jira/browse/FLINK-13814 > Project: Flink > Issue Type: Bug > Components: Connectors / Hive >Affects Versions: 1.9.0 >Reporter: Rui Li >Assignee: Rui Li >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0, 1.9.1 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13814) HiveTableSink should strip quotes from partition values
[ https://issues.apache.org/jira/browse/FLINK-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-13814: - Affects Version/s: 1.9.0 > HiveTableSink should strip quotes from partition values > --- > > Key: FLINK-13814 > URL: https://issues.apache.org/jira/browse/FLINK-13814 > Project: Flink > Issue Type: Bug > Components: Connectors / Hive >Affects Versions: 1.9.0 >Reporter: Rui Li >Assignee: Rui Li >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (FLINK-13814) HiveTableSink should strip quotes from partition values
[ https://issues.apache.org/jira/browse/FLINK-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-13814: Assignee: Rui Li > HiveTableSink should strip quotes from partition values > --- > > Key: FLINK-13814 > URL: https://issues.apache.org/jira/browse/FLINK-13814 > Project: Flink > Issue Type: Bug > Components: Connectors / Hive >Reporter: Rui Li >Assignee: Rui Li >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (FLINK-13814) HiveTableSink should strip quotes from partition values
[ https://issues.apache.org/jira/browse/FLINK-13814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-13814: - Fix Version/s: 1.10.0 > HiveTableSink should strip quotes from partition values > --- > > Key: FLINK-13814 > URL: https://issues.apache.org/jira/browse/FLINK-13814 > Project: Flink > Issue Type: Bug > Components: Connectors / Hive >Reporter: Rui Li >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [flink] bowenli86 edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code
bowenli86 edited a comment on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-523667337 cc @zentol @tzulitai @tweise This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-13772) GroupWindowTableAggregateITCase tests fail on Travis
[
https://issues.apache.org/jira/browse/FLINK-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex updated FLINK-13772:
-
Summary: GroupWindowTableAggregateITCase tests fail on Travis (was:
GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane)
> GroupWindowTableAggregateITCase tests fail on Travis
>
>
> Key: FLINK-13772
> URL: https://issues.apache.org/jira/browse/FLINK-13772
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.0
>Reporter: Till Rohrmann
>Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0
>
>
> The
> {{GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane}}
> fails on Travis:
> {code}
> 05:21:41.532 [ERROR] Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 14.039 s <<< FAILURE! - in
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase
> 05:21:41.532 [ERROR]
> testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane[StateBackend=HEAP](org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase)
> Time elapsed: 0.573 s <<< ERROR!
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.GroupWindowTableAggregateITCase.testEventTimeSlidingGroupWindowOverTimeNonOverlappingSplitPane(GroupWindowTableAggregateITCase.scala:301)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.org/v3/job/573615974/log.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
