[jira] [Commented] (FLINK-14201) SQL supports redis sink connector
[ https://issues.apache.org/jira/browse/FLINK-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937431#comment-16937431 ] Yangze Guo commented on FLINK-14201: Thanks for the feedback [~alfredlu]. AFAIK, Flink does not support redis sink yet. > SQL supports redis sink connector > - > > Key: FLINK-14201 > URL: https://issues.apache.org/jira/browse/FLINK-14201 > Project: Flink > Issue Type: Wish > Components: Connectors / Common >Reporter: Zijie Lu >Priority: Minor > > Can SQL supports the connector type of redis? I think in many cases we need > to store the result in the redis. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…
flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#issuecomment-527387437 ## CI report: * 1bd21c6cd2d430b9827b903e80f31c55bcb04750 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125569862) * 1b9269f48bd6b55ddd0f21faabbd648c706003a2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/127308001) * 3aefd7f602bbe0cc421f834d403a823d1c5a6c6c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129036484) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126350641) * cc515180d99fa35b482c61c2e264e77760e55dc5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126354591) * b8341665cb9b8bf3559d93ea74715ddac3ca67b2 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127617990) * 462a8cf7286f63afcfb5cecbce37df232d3f8ec4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127623432) * 51397b3c71d8dd4549eba379b2b873d2e523e268 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127625943) * 60e035ab71050b367fcf5411953a75a8a3b32a75 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127672092) * 978c0723caaf584fe91b59cc9aabbd77815907c8 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129038982) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python f
flinkbot edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python function execution URL: https://github.com/apache/flink/pull/9748#issuecomment-534087366 ## CI report: * dd50b7a2af07a87280b2e358d31d0ad9345ad8c4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128743957) * abaf8ebcbd17e79ae92f9e66ed96772262919370 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/129035121) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
flinkbot edited a comment on issue #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#issuecomment-532984287 ## CI report: * f2b7710f65f478342de389c8e099799287ddf3f9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128285030) * 19872fd562f606e9738f5b5a77f7a1d3e93a39b9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128302786) * 211f984c5380d61cf78f94e8ddcb4576f5c3f751 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128442800) * ed7ead402b73f1d5958f13c050dcda4b22dbe40a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128451919) * 33e4d2ef7f0db97a5fad81b5ef4542a299f805e6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453915) * 2f413575dd750406c2dfe2f04b93283ca629fbc9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128456492) * 367beca92524d27a0fdbc918e8c080bb7957be3a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/129033648) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
flinkbot edited a comment on issue #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-511684151 ## CI report: * 6a7ca58b4a04f6dce250045e021702e67e82b893 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119421914) * 4d38a8df0d59734c4b2386689a2f17b9f2b44b12 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119441376) * 9c14836f8639e98d58cf7bb32e38b938b3843994 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/119577044) * 76186776c5620598a19234245bbd05dfdfb1c62c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/120113740) * 628ca7b316ad3968c90192a47a84dd01f26e2578 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/122381349) * d204a725ff3c8a046cbd1b84e34d9e3ae8aafeac : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123620485) * 143efadbdb6c4681569d5b412a175edfb1633b85 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123637809) * b78b64a82ed2a9a92886095ec42f06d5082ad830 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/123671219) * 5145a0b9d6b320456bb971d96b9cc47707c8fd28 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125476639) * 0d4d944c28c59ca1caa6c453c347ec786b40d245 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125762588) * 91552c3804f5e96cc573e6ed48756f2b54c037d4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125844084) * fbf6d2850b6aa7c303981e6f5b24b0da0956b820 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126086321) * 45282a2139ec3c7196ba10b6fb829b0ec275 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126350641) * cc515180d99fa35b482c61c2e264e77760e55dc5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/126354591) * b8341665cb9b8bf3559d93ea74715ddac3ca67b2 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127617990) * 462a8cf7286f63afcfb5cecbce37df232d3f8ec4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127623432) * 51397b3c71d8dd4549eba379b2b873d2e523e268 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127625943) * 60e035ab71050b367fcf5411953a75a8a3b32a75 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/127672092) * 978c0723caaf584fe91b59cc9aabbd77815907c8 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM
flinkbot edited a comment on issue #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM URL: https://github.com/apache/flink/pull/9765#issuecomment-534839485 ## CI report: * 67210a4c8e0fc74c15091faee8096d7c44e9fe49 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/129033631) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (FLINK-14201) SQL supports redis sink connector
Zijie Lu created FLINK-14201: Summary: SQL supports redis sink connector Key: FLINK-14201 URL: https://issues.apache.org/jira/browse/FLINK-14201 Project: Flink Issue Type: Wish Components: Connectors / Common Reporter: Zijie Lu Can SQL supports the connector type of redis? I think in many cases we need to store the result in the redis. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r316978992
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##
@@ -747,6 +747,17 @@ public ApplicationReport startAppMaster(
// ship list that enables reuse of resources for task manager
containers
StringBuilder envShipFileList = new StringBuilder();
+ int fileReplication =
yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY,
DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+ if
(flinkConfiguration.contains(YarnConfigOptions.FILE_REPLICATION)) {
+ try {
+ final String replication =
flinkConfiguration.getString(YarnConfigOptions.FILE_REPLICATION);
+ fileReplication = Integer.parseInt(replication);
+ } catch (NumberFormatException e) {
+ throw new RuntimeException(
+ "The yarn configuration
yarn.file-replication has to be a positive integer", e);
+ }
+ }
Review comment:
As S3, hdfs are both possible storage layer for resources, there is no
replication concept for s3. If I use integer config, I need to set a default
value for it. As hdfs usually use 3 replica for its files, but the value is not
meaningful for S3. Thus, I feel it is better to use String. How do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r327931437
##
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##
@@ -204,6 +217,36 @@ public static void
populateYarnSecureConfigurations(Configuration conf, String p
conf.set("hadoop.security.auth_to_local", "RULE:[1:$1]
RULE:[2:$1]");
}
+ public static void populateHDFSSecureConfigurations(Configuration conf,
String principal, String keytab)
Review comment:
It is to make the main code path can be also used for secured test cases
also.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#discussion_r327931310 ## File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ## @@ -121,6 +127,7 @@ // workaround for annoying InterruptedException logging: // https://issues.apache.org/jira/browse/YARN-1022 "java.lang.InterruptedException", + "java.net.ConnectException: Connection refused", Review comment: Agree. updated accordingly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r327931275
##
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOSecuredITCase.java
##
@@ -106,7 +106,7 @@ public static void teardownSecureCluster() {
SecureTestEnvironment.cleanup();
}
- @Test(timeout = 6) // timeout after a minute.
+ @Test(timeout = 6) // timeout after two minute.
Review comment:
Good catch. Reverted the change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#discussion_r327931833 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java ## @@ -745,6 +745,17 @@ public ApplicationReport startAppMaster( // ship list that enables reuse of resources for task manager containers StringBuilder envShipFileList = new StringBuilder(); + int fileReplication = yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY, DFSConfigKeys.DFS_REPLICATION_DEFAULT); Review comment: Good point out. It required integration with share cache client. I think it is probably out of the scope of the problem that the PR want to resolve. But we definitely can bring a further discussion. https://hadoop.apache.org/docs/r3.1.1/hadoop-yarn/hadoop-yarn-site/SharedCache.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r327932732
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##
@@ -188,6 +188,17 @@
.defaultValue("")
.withDescription("A comma-separated list of tags to apply to
the Flink YARN application.");
+ /**
+* Yarn session client uploads flink jar and user libs to file system
(hdfs/s3) as local resource for yarn
+* application context. The replication number changes the how many
replica of each of these files in hdfs/s3.
+* It is useful to accelerate this container bootstrap time, when a
Flink application needs more one hundred
+* of containers.
+*/
+ public static final ConfigOption FILE_REPLICATION =
+ key("yarn.file-replication")
Review comment:
Updated accordingly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343] [flink-yarn] add file replication config for yarn configuration
HuangZhenQiu commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r327932221
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##
@@ -746,6 +746,17 @@ public ApplicationReport startAppMaster(
// ship list that enables reuse of resources for task manager
containers
StringBuilder envShipFileList = new StringBuilder();
+ int fileReplication =
yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY,
DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+ if
(flinkConfiguration.contains(YarnConfigOptions.FILE_REPLICATION)) {
+ try {
+ final String replication =
flinkConfiguration.getString(YarnConfigOptions.FILE_REPLICATION);
Review comment:
@tillrohrmann Agee. I use -1 as default value. If the value is not
configured, we will use the default value in hadoop configuration.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…
flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#issuecomment-527387437 ## CI report: * 1bd21c6cd2d430b9827b903e80f31c55bcb04750 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125569862) * 1b9269f48bd6b55ddd0f21faabbd648c706003a2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/127308001) * 3aefd7f602bbe0cc421f834d403a823d1c5a6c6c : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129036484) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server.
flinkbot edited a comment on issue #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server. URL: https://github.com/apache/flink/pull/9750#issuecomment-534370339 ## CI report: * 9ea7a2157e67850fe26c893969108694d2525284 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128847690) * e84a6157904a34ea20af4e2e144cf8418fd72892 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/129033619) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy…
flinkbot edited a comment on issue #8912: [FLINK-12709] [runtime] Implement new generation restart strategy loader which also respects legacy… URL: https://github.com/apache/flink/pull/8912#issuecomment-527387437 ## CI report: * 1bd21c6cd2d430b9827b903e80f31c55bcb04750 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/125569862) * 1b9269f48bd6b55ddd0f21faabbd648c706003a2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/127308001) * 3aefd7f602bbe0cc421f834d403a823d1c5a6c6c : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9301: [FLINK-13469][state] Ensure resource used by StateMapSnapshot will be released if snapshot fails
flinkbot edited a comment on issue #9301: [FLINK-13469][state] Ensure resource used by StateMapSnapshot will be released if snapshot fails URL: https://github.com/apache/flink/pull/9301#issuecomment-516855887 ## CI report: * dae038f150dbe42e451e9a42f5a6a060b162a5ef : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/121418159) * d2cc6e90933e7ede2310a7e3198c58be4e3b62c8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/121534859) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python f
flinkbot edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python function execution URL: https://github.com/apache/flink/pull/9748#issuecomment-534087366 ## CI report: * dd50b7a2af07a87280b2e358d31d0ad9345ad8c4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128743957) * abaf8ebcbd17e79ae92f9e66ed96772262919370 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129035121) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] carp84 commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState
carp84 commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-534844656 What's more, I think we should split the `StateBackendTestBase. testMapState` case to explicitly test each `MapState` operation interface, but this is out of the scope for this PR/JIRA and worth a dedicated one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli…
flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-522106295 ## CI report: * 78654e8f80aa0b1a01654e7684f4610eb1d3aff4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123548600) * f4a0f59543372d85e7fd1dc5156ba6f165737a03 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128536515) * 1a81936bf11ca32e564f00e2deb7391126fce03e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128774076) * 080cf9b0ba518d437f5725c82d5335dcb15cf6e3 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/129032390) * 3e0c2432445da61828ceff3f6b17aad1ac095d58 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129033658) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
flinkbot edited a comment on issue #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#issuecomment-532984287 ## CI report: * f2b7710f65f478342de389c8e099799287ddf3f9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128285030) * 19872fd562f606e9738f5b5a77f7a1d3e93a39b9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128302786) * 211f984c5380d61cf78f94e8ddcb4576f5c3f751 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128442800) * ed7ead402b73f1d5958f13c050dcda4b22dbe40a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128451919) * 33e4d2ef7f0db97a5fad81b5ef4542a299f805e6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453915) * 2f413575dd750406c2dfe2f04b93283ca629fbc9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128456492) * 367beca92524d27a0fdbc918e8c080bb7957be3a : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129033648) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support
flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#issuecomment-533110106 ## CI report: * d9c1dd529ef235649909d067cc78099179656e62 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128334151) * 603db694488096f1491b5ccb068d9e783636a8c8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128375005) * 9bc5949275f7997eadd03e2ec1fe8937ee2e689f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453921) * 53bfd624b1258c5f1c269952d155f2c981476769 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128462077) * 566cbfff4439557cb6cdd767db501f8c49e5caf6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128467326) * bbae03349addd55bb69328c64f07209b7aa3190e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128751101) * 2fbb1182ce21d38b3c0cec43e41d52d911385bba : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128845470) * a89047bd806a050101b3ce8220534ab7df9700af : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128862483) * 5e0a6ffe3b7818d6526c47a995f10aaf92ec5d5d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128910685) * bfeeca49661520bd3241a37200be18804f9cfe23 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129026485) * 3ba6a2740dc6925e8e7190acec7b373c91d8bc5d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129029964) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] carp84 commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState
carp84 commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-534844195 > There have been some tests for `MapState.isEmpty` in `StateBackendTestBase.testMapState`, do you actually mean other tests for `MapState.isEmpty` could be ignored？ @carp84 I meant to add an explicit `testMapStateIsEmpty` case like `testListStateAddNull` in `StateBackendTestBase` instead of squeezing everything in `testMapState`. Similarly, add an explicit `testIsEmpty` method in `ImmutableMapStateTest` instead of scattered statements in existing cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM
flinkbot edited a comment on issue #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM URL: https://github.com/apache/flink/pull/9765#issuecomment-534839485 ## CI report: * 67210a4c8e0fc74c15091faee8096d7c44e9fe49 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129033631) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese
flinkbot edited a comment on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese URL: https://github.com/apache/flink/pull/9764#issuecomment-534832110 ## CI report: * 936857429eb4fa0e47440e142a688ac1505d85ec : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129031125) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server.
flinkbot edited a comment on issue #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server. URL: https://github.com/apache/flink/pull/9750#issuecomment-534370339 ## CI report: * 9ea7a2157e67850fe26c893969108694d2525284 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128847690) * e84a6157904a34ea20af4e2e144cf8418fd72892 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129033619) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] dianfu commented on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python function e
dianfu commented on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python function execution URL: https://github.com/apache/flink/pull/9748#issuecomment-534842612 @sunjincheng121 I have updated the PR and have addressed your comments with just one exception. Regarding to the filter part as I found that it's a big optimization and deserve a separate rule. The functionality of PythonScalarFunctionSplitRule which is introduced in this PR focuses on separating the Python UDFs from the Java UDFs mixed in a Calc node. For the filter optimization, we need introduce a new rule which is responsible for splitting a Calc node into two Calc nodes if it contains condition and the projection contains Python UDFs. The generated bottom Calc contains the filter part and the top Calc contains the projection part. Does it make sense to you? If yes, I will create a follow up ticket for this optimization. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python f
flinkbot edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python function execution URL: https://github.com/apache/flink/pull/9748#issuecomment-534087366 ## CI report: * dd50b7a2af07a87280b2e358d31d0ad9345ad8c4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128743957) * abaf8ebcbd17e79ae92f9e66ed96772262919370 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli…
flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-522106295 ## CI report: * 78654e8f80aa0b1a01654e7684f4610eb1d3aff4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123548600) * f4a0f59543372d85e7fd1dc5156ba6f165737a03 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128536515) * 1a81936bf11ca32e564f00e2deb7391126fce03e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128774076) * 080cf9b0ba518d437f5725c82d5335dcb15cf6e3 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129032390) * 3e0c2432445da61828ceff3f6b17aad1ac095d58 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (FLINK-14179) Wrong description of SqlCommand.SHOW_FUNCTIONS
[
https://issues.apache.org/jira/browse/FLINK-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Canbin Zheng resolved FLINK-14179.
--
Resolution: Fixed
> Wrong description of SqlCommand.SHOW_FUNCTIONS
> --
>
> Key: FLINK-14179
> URL: https://issues.apache.org/jira/browse/FLINK-14179
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Client
>Affects Versions: 1.9.0
>Reporter: Canbin Zheng
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Attachments: image-2019-09-24-10-59-26-286.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently '*SHOW FUNCTIONS*' lists not only user-defined functions, but also
> system-defined ones, the description {color:#172b4d}*'Shows all registered
> user-defined functions.'* not correctly depicts this functionality. I think
> we can change the description to '*Shows all system-defined and user-defined
> functions.*'{color}
>
> {color:#172b4d}!image-2019-09-24-10-59-26-286.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
flinkbot edited a comment on issue #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#issuecomment-532984287 ## CI report: * f2b7710f65f478342de389c8e099799287ddf3f9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128285030) * 19872fd562f606e9738f5b5a77f7a1d3e93a39b9 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128302786) * 211f984c5380d61cf78f94e8ddcb4576f5c3f751 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128442800) * ed7ead402b73f1d5958f13c050dcda4b22dbe40a : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128451919) * 33e4d2ef7f0db97a5fad81b5ef4542a299f805e6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453915) * 2f413575dd750406c2dfe2f04b93283ca629fbc9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128456492) * 367beca92524d27a0fdbc918e8c080bb7957be3a : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM
flinkbot commented on issue #9765: [FLINK-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM URL: https://github.com/apache/flink/pull/9765#issuecomment-534839485 ## CI report: * 67210a4c8e0fc74c15091faee8096d7c44e9fe49 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese
flinkbot edited a comment on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763#issuecomment-534828530 ## CI report: * 301e466b5a04494d5e5b3ed0531024227c32e8fc : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129029951) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server.
flinkbot edited a comment on issue #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server. URL: https://github.com/apache/flink/pull/9750#issuecomment-534370339 ## CI report: * 9ea7a2157e67850fe26c893969108694d2525284 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128847690) * e84a6157904a34ea20af4e2e144cf8418fd72892 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wsry commented on a change in pull request #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server.
wsry commented on a change in pull request #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server. URL: https://github.com/apache/flink/pull/9750#discussion_r327920270 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java ## @@ -113,6 +115,15 @@ public RestServerEndpoint(RestServerEndpointConfiguration configuration) throws this.responseHeaders = configuration.getResponseHeaders(); terminationFuture = new CompletableFuture<>(); + + // the clean up of temp files when jvm exits is handled by org.apache.flink.util.ShutdownHookUtil; thus, + // it's no need to register those files (post chunks and upload file chunks) to java.io.DeleteOnExitHook + // which may lead to memory leak. + DiskAttribute.deleteOnExitTemporaryFile = false; + DiskFileUpload.deleteOnExitTemporaryFile = false; + + // share the same directory with file upload for post chunks storage. + DiskAttribute.baseDirectory = uploadDir.normalize().toAbsolutePath().toString(); Review comment: I have updated the pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9765: [Flink-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM
flinkbot commented on issue #9765: [Flink-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM URL: https://github.com/apache/flink/pull/9765#issuecomment-534837781 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 67210a4c8e0fc74c15091faee8096d7c44e9fe49 (Wed Sep 25 03:41:33 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-14126).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wangxiyuan opened a new pull request #9765: [Flink-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM
wangxiyuan opened a new pull request #9765: [Flink-14126][test] Disable Xpack.ml for elasticsearch 6.0+ on ARM URL: https://github.com/apache/flink/pull/9765 ## What is the purpose of the change Elasticsearch Xpack Machine Learning function is enabled by default if the version is >=6.0. But This feature doesn't support ARM arch. So that in some e2e tests, Elasticsearch is failed to start. We should disable ML feature in this case on ARM. ## Brief change log Add a case check that if the platform is aarch64 and Elasticsearch is 6.0+ version, disble xpack.ml feature. ## Verifying this change This change is already covered by existing tests, it will be ran in e2e tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli…
flinkbot edited a comment on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-522106295 ## CI report: * 78654e8f80aa0b1a01654e7684f4610eb1d3aff4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/123548600) * f4a0f59543372d85e7fd1dc5156ba6f165737a03 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128536515) * 1a81936bf11ca32e564f00e2deb7391126fce03e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128774076) * 080cf9b0ba518d437f5725c82d5335dcb15cf6e3 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-9749) Rework Bucketing Sink
[
https://issues.apache.org/jira/browse/FLINK-9749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937374#comment-16937374
]
Shimin Yang commented on FLINK-9749:
Hi [~kkl0u], that would be nice. One more question is about hadoop 2.6 support,
I think we actually don't need truncate method if we use
OnCheckpointRollingPolicy.
> Rework Bucketing Sink
> -
>
> Key: FLINK-9749
> URL: https://issues.apache.org/jira/browse/FLINK-9749
> Project: Flink
> Issue Type: New Feature
> Components: Connectors / FileSystem
>Reporter: Stephan Ewen
>Assignee: Kostas Kloudas
>Priority: Major
>
> The BucketingSink has a series of deficits at the moment.
> Due to the long list of issues, I would suggest to add a new
> StreamingFileSink with a new and cleaner design
> h3. Encoders, Parquet, ORC
> - It only efficiently supports row-wise data formats (avro, jso, sequence
> files.
> - Efforts to add (columnar) compression for blocks of data is inefficient,
> because blocks cannot span checkpoints due to persistence-on-checkpoint.
> - The encoders are part of the \{{flink-connector-filesystem project}},
> rather than in orthogonal formats projects. This blows up the dependencies of
> the \{{flink-connector-filesystem project}} project. As an example, the
> rolling file sink has dependencies on Hadoop and Avro, which messes up
> dependency management.
> h3. Use of FileSystems
> - The BucketingSink works only on Hadoop's FileSystem abstraction not
> support Flink's own FileSystem abstraction and cannot work with the packaged
> S3, maprfs, and swift file systems
> - The sink hence needs Hadoop as a dependency
> - The sink relies on "trying out" whether truncation works, which requires
> write access to the users working directory
> - The sink relies on enumerating and counting files, rather than maintaining
> its own state, making less efficient
> h3. Correctness and Efficiency on S3
> - The BucketingSink relies on strong consistency in the file enumeration,
> hence may work incorrectly on S3.
> - The BucketingSink relies on persisting streams at intermediate points.
> This is not working properly on S3, hence there may be data loss on S3.
> h3. .valid-length companion file
> - The valid length file makes it hard for consumers of the data and should
> be dropped
> We track this design in a series of sub issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] Rishi55 commented on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli…
Rishi55 commented on issue #9468: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak when elasticsearch6 rest high level cli… URL: https://github.com/apache/flink/pull/9468#issuecomment-534836750 Hi @tzulitai, I modified my changes according to your suggestions. Please review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9542: [FLINK-13873][metrics] Change the column family as tags for influxdb …
flinkbot edited a comment on issue #9542: [FLINK-13873][metrics] Change the column family as tags for influxdb … URL: https://github.com/apache/flink/pull/9542#issuecomment-525276537 ## CI report: * e8636926351f3d406962dcadba275e20e49aff39 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124736151) * d23ea97e8419bbacea0698b3ba82a459d940cf38 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/128606376) * 05977cd49eb306d768668be4e8cb31034343df02 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128606947) * 057d453e5e00656bcfcb87d1d69172f614b2d11f : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/128681895) * 5001042b5fc5202da14c06e2d21faf1427f50a66 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128683546) * 3a1e39e889daf0fca82c54982911ded35df6cb77 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128692102) * 2745a3cb02e601a1a26360e9d6b3f0af5428c66a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/129027621) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese
flinkbot edited a comment on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese URL: https://github.com/apache/flink/pull/9764#issuecomment-534832110 ## CI report: * 936857429eb4fa0e47440e142a688ac1505d85ec : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129031125) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wsry commented on a change in pull request #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server.
wsry commented on a change in pull request #9750: [FLINK-14139][rest]Fix potential memory leak problem of rest server. URL: https://github.com/apache/flink/pull/9750#discussion_r327918636 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java ## @@ -113,6 +115,15 @@ public RestServerEndpoint(RestServerEndpointConfiguration configuration) throws this.responseHeaders = configuration.getResponseHeaders(); terminationFuture = new CompletableFuture<>(); + + // the clean up of temp files when jvm exits is handled by org.apache.flink.util.ShutdownHookUtil; thus, + // it's no need to register those files (post chunks and upload file chunks) to java.io.DeleteOnExitHook + // which may lead to memory leak. + DiskAttribute.deleteOnExitTemporaryFile = false; + DiskFileUpload.deleteOnExitTemporaryFile = false; + + // share the same directory with file upload for post chunks storage. + DiskAttribute.baseDirectory = uploadDir.normalize().toAbsolutePath().toString(); Review comment: You are right. The DiskAttribute and DiskFileUpload is only used by FileUploadHandler. I will move these settings into the constructor of the FileUploadHandler and update the pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14200) Temporal Table Function Joins do not work on Tables (only TableSources) on the query side
[
https://issues.apache.org/jira/browse/FLINK-14200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu updated FLINK-14200:
Fix Version/s: 1.9.1
> Temporal Table Function Joins do not work on Tables (only TableSources) on
> the query side
> -
>
> Key: FLINK-14200
> URL: https://issues.apache.org/jira/browse/FLINK-14200
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
> Environment: Java 8, Scala 2.11, Flink 1.9
>Reporter: Benoît Paris
>Priority: Major
> Fix For: 1.9.1
>
> Attachments:
> temporal-table-function-query-side-as-not-table-source.zip
>
>
> This only affects the Blink planner. The legacy planner works fine.
> With Orders as a TableSource, and Orders2 as a Table with the same content:
> {code:java}
> tEnv.registerTableSource("Orders", new FooSource(new String[] {"o_currency",
> "o_amount", "o_proctime"}));
> Table orders2 = tEnv.sqlQuery("SELECT * FROM Orders");
> tEnv.registerTable("Orders2", orders2);{code}
> This works (TableSource on the query side):
> {code:java}
> SELECT
> o_amount * r_amount AS amount
> FROM Orders
> , LATERAL TABLE (Rates(o_proctime))
> WHERE r_currency = o_currency{code}
> While this does not (Table on the query side):
> {code:java}
> SELECT
> o_amount * r_amount AS amount
> FROM Orders2
> , LATERAL TABLE (Rates(o_proctime))
> WHERE r_currency = o_currency{code}
> Throwing an NPE in FlinkRelBuilder, called from
> LogicalCorrelateToJoinFromTemporalTableFunctionRule. Attached is Java code
> for reproduction, along with the full log and stacktrace, and a pom.xml.
> EDIT: This may not be Table vs TableSource, maybe more a projection or a
> decorrelate issue? Don't know how the planner works well enough to
> characterize it better.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #9744: [FLINK-13515][test] Fix ClassLoaderITCase fails on Java 11
flinkbot edited a comment on issue #9744: [FLINK-13515][test] Fix ClassLoaderITCase fails on Java 11 URL: https://github.com/apache/flink/pull/9744#issuecomment-533988291 ## CI report: * 8210403a33cf3a6908980378fae9ee8d567afdb1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128698798) * 50ef5004d73bc2e677a1fe84dc8cd2a6fb355ced : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/129028745) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14200) Temporal Table Function Joins do not work on Tables (only TableSources) on the query side
[
https://issues.apache.org/jira/browse/FLINK-14200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937367#comment-16937367
]
Jark Wu commented on FLINK-14200:
-
Hi [~BenoitParis], thanks for reporting this. I think this is a bug.
> Temporal Table Function Joins do not work on Tables (only TableSources) on
> the query side
> -
>
> Key: FLINK-14200
> URL: https://issues.apache.org/jira/browse/FLINK-14200
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.9.0
> Environment: Java 8, Scala 2.11, Flink 1.9
>Reporter: Benoît Paris
>Priority: Major
> Fix For: 1.9.1
>
> Attachments:
> temporal-table-function-query-side-as-not-table-source.zip
>
>
> This only affects the Blink planner. The legacy planner works fine.
> With Orders as a TableSource, and Orders2 as a Table with the same content:
> {code:java}
> tEnv.registerTableSource("Orders", new FooSource(new String[] {"o_currency",
> "o_amount", "o_proctime"}));
> Table orders2 = tEnv.sqlQuery("SELECT * FROM Orders");
> tEnv.registerTable("Orders2", orders2);{code}
> This works (TableSource on the query side):
> {code:java}
> SELECT
> o_amount * r_amount AS amount
> FROM Orders
> , LATERAL TABLE (Rates(o_proctime))
> WHERE r_currency = o_currency{code}
> While this does not (Table on the query side):
> {code:java}
> SELECT
> o_amount * r_amount AS amount
> FROM Orders2
> , LATERAL TABLE (Rates(o_proctime))
> WHERE r_currency = o_currency{code}
> Throwing an NPE in FlinkRelBuilder, called from
> LogicalCorrelateToJoinFromTemporalTableFunctionRule. Attached is Java code
> for reproduction, along with the full log and stacktrace, and a pom.xml.
> EDIT: This may not be Table vs TableSource, maybe more a projection or a
> decorrelate issue? Don't know how the planner works well enough to
> characterize it better.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327917799
##
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/ExtendedSqlCollectionTypeNameSpec.java
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.type;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlCollectionTypeNameSpec;
+import org.apache.calcite.sql.SqlTypeNameSpec;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.calcite.sql.validate.SqlValidator;
+import org.apache.calcite.util.Litmus;
+import org.apache.calcite.util.Util;
+
+/**
+ * A extended sql type name specification of collection type,
+ * different with {@link SqlCollectionTypeNameSpec},
+ * we support NULL or NOT NULL suffix for the element type name(this syntax
+ * does not belong to standard SQL).
+ */
+public class ExtendedSqlCollectionTypeNameSpec extends
SqlCollectionTypeNameSpec {
Review comment:
Sure, i have added a package-info file and address this info.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327917280 ## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/join/ShuffledHashJoinTest.xml ## @@ -19,57 +19,60 @@ limitations under the License. + + + Review comment: Sure, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327917230 ## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRuleTest.xml ## @@ -1,435 +0,0 @@ - - - Review comment: Add them back. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327917159
##
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/ExtendedSqlBuiltinTypeNameSpec.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.type;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlUserDefinedTypeNameSpec;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.calcite.sql.validate.SqlValidator;
+
+import java.util.Locale;
+
+/**
+ * A sql type name specification of extended builtin data type, this is
different with
+ * the normal user defined data type, because there is no need to register
them into
+ * the catalog when deriving the data type.
+ */
+public class ExtendedSqlBuiltinTypeNameSpec extends SqlUserDefinedTypeNameSpec
{
Review comment:
I agree, have renamed `ExtendedSqlBuiltinTypeNameSpec` to
`ExtendedSqlBasicTypeNameSpec` and make it extend `SqlBasicTypeNameSpec`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support
flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#issuecomment-533110106 ## CI report: * d9c1dd529ef235649909d067cc78099179656e62 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128334151) * 603db694488096f1491b5ccb068d9e783636a8c8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128375005) * 9bc5949275f7997eadd03e2ec1fe8937ee2e689f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453921) * 53bfd624b1258c5f1c269952d155f2c981476769 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128462077) * 566cbfff4439557cb6cdd767db501f8c49e5caf6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128467326) * bbae03349addd55bb69328c64f07209b7aa3190e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128751101) * 2fbb1182ce21d38b3c0cec43e41d52d911385bba : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128845470) * a89047bd806a050101b3ce8220534ab7df9700af : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128862483) * 5e0a6ffe3b7818d6526c47a995f10aaf92ec5d5d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128910685) * bfeeca49661520bd3241a37200be18804f9cfe23 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129026485) * 3ba6a2740dc6925e8e7190acec7b373c91d8bc5d : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129029964) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese
flinkbot edited a comment on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763#issuecomment-534828530 ## CI report: * 301e466b5a04494d5e5b3ed0531024227c32e8fc : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129029951) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese
flinkbot commented on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese URL: https://github.com/apache/flink/pull/9764#issuecomment-534832110 ## CI report: * 936857429eb4fa0e47440e142a688ac1505d85ec : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0
flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0 URL: https://github.com/apache/flink/pull/9751#issuecomment-534387866 ## CI report: * 5b73b3d6319447fd2d81b48183d9f22012133a6b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128853990) * 9e0f8dbc4abc0caa82a66dd4b250d2716debb709 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128866590) * 47fc6a0206ce150cc62d5038a288e1534db0f79b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128877814) * 5ca23fc651a91a0f1e097eed533d8804c2ec9235 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128971343) * 36e98a73fd1c05a9e74e71944b96b834a1f86894 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129028758) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #9761: [FLINK-14031][examples][table]Added the blink planner dependency and …
KurtYoung commented on a change in pull request #9761:
[FLINK-14031][examples][table]Added the blink planner dependency and …
URL: https://github.com/apache/flink/pull/9761#discussion_r327914514
##
File path:
flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/StreamSQLExample.java
##
@@ -42,9 +47,24 @@
public static void main(String[] args) throws Exception {
+ final ParameterTool params = ParameterTool.fromArgs(args);
+ String planner = params.has("planner") ? params.get("planner")
: "flink";
+
// set up execution environment
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
- StreamTableEnvironment tEnv =
StreamTableEnvironment.create(env);
+ StreamTableEnvironment tEnv;
+ if (Objects.equals(planner, "blink")) { // use blink planner in
streaming mode
+ EnvironmentSettings settings =
EnvironmentSettings.newInstance()
+ .useBlinkPlanner()
+ .inStreamingMode()
+ .build();
+ tEnv = StreamTableEnvironment.create(env, settings);
+ } else if (Objects.equals(planner, "flink")){ // use flink
planner in streaming mode
+ tEnv = StreamTableEnvironment.create(env);
+ } else {
+ System.err.println("The planner is incorrect. Please
use --planner to specify planner type.");
Review comment:
Could you explain it more clearly in this error message that you have use
either `flink` planner or `blink` planner?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #9761: [FLINK-14031][examples][table]Added the blink planner dependency and …
KurtYoung commented on a change in pull request #9761:
[FLINK-14031][examples][table]Added the blink planner dependency and …
URL: https://github.com/apache/flink/pull/9761#discussion_r327914357
##
File path:
flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/StreamSQLExample.java
##
@@ -42,9 +47,24 @@
public static void main(String[] args) throws Exception {
+ final ParameterTool params = ParameterTool.fromArgs(args);
+ String planner = params.has("planner") ? params.get("planner")
: "flink";
+
// set up execution environment
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
- StreamTableEnvironment tEnv =
StreamTableEnvironment.create(env);
+ StreamTableEnvironment tEnv;
+ if (Objects.equals(planner, "blink")) { // use blink planner in
streaming mode
+ EnvironmentSettings settings =
EnvironmentSettings.newInstance()
+ .useBlinkPlanner()
+ .inStreamingMode()
+ .build();
+ tEnv = StreamTableEnvironment.create(env, settings);
+ } else if (Objects.equals(planner, "flink")){ // use flink
planner in streaming mode
Review comment:
nit: space before `{`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #9761: [FLINK-14031][examples][table]Added the blink planner dependency and …
KurtYoung commented on a change in pull request #9761:
[FLINK-14031][examples][table]Added the blink planner dependency and …
URL: https://github.com/apache/flink/pull/9761#discussion_r327914739
##
File path:
flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/StreamSQLExample.java
##
@@ -42,9 +47,24 @@
public static void main(String[] args) throws Exception {
+ final ParameterTool params = ParameterTool.fromArgs(args);
+ String planner = params.has("planner") ? params.get("planner")
: "flink";
+
// set up execution environment
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
- StreamTableEnvironment tEnv =
StreamTableEnvironment.create(env);
+ StreamTableEnvironment tEnv;
+ if (Objects.equals(planner, "blink")) { // use blink planner in
streaming mode
+ EnvironmentSettings settings =
EnvironmentSettings.newInstance()
+ .useBlinkPlanner()
+ .inStreamingMode()
+ .build();
+ tEnv = StreamTableEnvironment.create(env, settings);
+ } else if (Objects.equals(planner, "flink")){ // use flink
planner in streaming mode
+ tEnv = StreamTableEnvironment.create(env);
+ } else {
+ System.err.println("The planner is incorrect. Please
use --planner to specify planner type.");
Review comment:
The user will not have such knowledge when they are trying the examples
without looking into the codes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (FLINK-12939) Translate "Apache Kafka Connector" page into Chinese
[ https://issues.apache.org/jira/browse/FLINK-12939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937356#comment-16937356 ] Jeff Yang commented on FLINK-12939: --- Here is the [PR|https://github.com/apache/flink/pull/9764], Thanks. > Translate "Apache Kafka Connector" page into Chinese > > > Key: FLINK-12939 > URL: https://issues.apache.org/jira/browse/FLINK-12939 > Project: Flink > Issue Type: Sub-task > Components: chinese-translation, Documentation >Reporter: Jark Wu >Assignee: Jeff Yang >Priority: Minor > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Translate the page > "https://ci.apache.org/projects/flink/flink-docs-master/dev/connectors/kafka.html; > into Chinese. > The doc located in "flink/docs/dev/connectors/kafka.zh.md" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese
flinkbot commented on issue #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese URL: https://github.com/apache/flink/pull/9764#issuecomment-534830699 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 936857429eb4fa0e47440e142a688ac1505d85ec (Wed Sep 25 03:02:40 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] yangjf2019 opened a new pull request #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese
yangjf2019 opened a new pull request #9764: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into Chinese URL: https://github.com/apache/flink/pull/9764 ## What is the purpose of the change *Translate "Apache Kafka Connector" page into Chinese* ## Brief change log - *I modified the kafka.zh.md file .* ## Verifying this change *I have verified the changes by starting the build script in preview mode.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): ( no ) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no ) - The serializers: ( no ) - The runtime per-record code paths (performance sensitive): ( no ) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no ) - The S3 file system connector: ( no ) ## Documentation - Does this pull request introduce a new feature? ( no ) - If yes, how is the feature documented? ( not documented ) Hi, @wuchong @TisonKun ,I replace a new account, so open a new PR, but the content of file is not change, here is the old [PR](https://github.com/apache/flink/pull/9414) . Please Take A Look . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support
flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#issuecomment-533110106 ## CI report: * d9c1dd529ef235649909d067cc78099179656e62 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128334151) * 603db694488096f1491b5ccb068d9e783636a8c8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128375005) * 9bc5949275f7997eadd03e2ec1fe8937ee2e689f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453921) * 53bfd624b1258c5f1c269952d155f2c981476769 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128462077) * 566cbfff4439557cb6cdd767db501f8c49e5caf6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128467326) * bbae03349addd55bb69328c64f07209b7aa3190e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128751101) * 2fbb1182ce21d38b3c0cec43e41d52d911385bba : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128845470) * a89047bd806a050101b3ce8220534ab7df9700af : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128862483) * 5e0a6ffe3b7818d6526c47a995f10aaf92ec5d5d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128910685) * bfeeca49661520bd3241a37200be18804f9cfe23 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129026485) * 3ba6a2740dc6925e8e7190acec7b373c91d8bc5d : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327908022
##
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##
@@ -375,210 +387,83 @@ SqlDrop SqlDropView(Span s, boolean replace) :
}
}
-SqlIdentifier FlinkCollectionsTypeName() :
-{
-}
-{
-LOOKAHEAD(2)
- {
-return new SqlIdentifier(SqlTypeName.MULTISET.name(), getPos());
-}
-|
- {
-return new SqlIdentifier(SqlTypeName.ARRAY.name(), getPos());
-}
-}
-
-SqlIdentifier FlinkTypeName() :
+SqlTypeNameSpec SqlUserDefinedTypeName() :
{
-final SqlTypeName sqlTypeName;
-final SqlIdentifier typeName;
-final Span s = Span.of();
+final String typeName;
}
{
(
-<#-- additional types are included here -->
-<#-- make custom data types in front of Calcite core data types -->
-<#list parser.flinkDataTypeParserMethods as method>
-<#if (method?index > 0)>
-|
-
-LOOKAHEAD(2)
-typeName = ${method}
-
+ { typeName = token.image; }
|
-LOOKAHEAD(2)
-sqlTypeName = SqlTypeName(s) {
-typeName = new SqlIdentifier(sqlTypeName.name(), s.end(this));
-}
-|
-LOOKAHEAD(2)
-typeName = FlinkCollectionsTypeName()
-|
-typeName = CompoundIdentifier() {
-throw new ParseException("UDT in DDL is not supported yet.");
-}
+ { typeName = token.image; }
)
{
-return typeName;
+return new ExtendedSqlBuiltinTypeNameSpec(token.image, getPos());
}
}
-/**
-* Parse a Flink data type with nullable options, NULL -> nullable, NOT NULL ->
not nullable.
-* Default to be nullable.
+/*
+* Parses collection type name that does not belong to standard SQL, i.e.
ARRAYINT NOT NULL.
*/
-SqlDataTypeSpec FlinkDataType() :
+SqlTypeNameSpec ExtendedCollectionsTypeName() :
Review comment:
Thanks, i have renamed `ExtendedCollectionsTypeName2` to
`CustomizedCollectionsTypeName`.
The `ExtendedCollectionsTypeName` supports NULL/NOT NULL options compared to
Calcite core `CollectionsTypeName`, i.e. "INT NOT NULL ARRAY", i have addressed
this in the comments.
The `CustomizedCollectionsTypeName` is totally customized by Flink, whose
syntax does not belong to standard SQL, i.e. "ARRAYINT NOT NULL"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327908022
##
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##
@@ -375,210 +387,83 @@ SqlDrop SqlDropView(Span s, boolean replace) :
}
}
-SqlIdentifier FlinkCollectionsTypeName() :
-{
-}
-{
-LOOKAHEAD(2)
- {
-return new SqlIdentifier(SqlTypeName.MULTISET.name(), getPos());
-}
-|
- {
-return new SqlIdentifier(SqlTypeName.ARRAY.name(), getPos());
-}
-}
-
-SqlIdentifier FlinkTypeName() :
+SqlTypeNameSpec SqlUserDefinedTypeName() :
{
-final SqlTypeName sqlTypeName;
-final SqlIdentifier typeName;
-final Span s = Span.of();
+final String typeName;
}
{
(
-<#-- additional types are included here -->
-<#-- make custom data types in front of Calcite core data types -->
-<#list parser.flinkDataTypeParserMethods as method>
-<#if (method?index > 0)>
-|
-
-LOOKAHEAD(2)
-typeName = ${method}
-
+ { typeName = token.image; }
|
-LOOKAHEAD(2)
-sqlTypeName = SqlTypeName(s) {
-typeName = new SqlIdentifier(sqlTypeName.name(), s.end(this));
-}
-|
-LOOKAHEAD(2)
-typeName = FlinkCollectionsTypeName()
-|
-typeName = CompoundIdentifier() {
-throw new ParseException("UDT in DDL is not supported yet.");
-}
+ { typeName = token.image; }
)
{
-return typeName;
+return new ExtendedSqlBuiltinTypeNameSpec(token.image, getPos());
}
}
-/**
-* Parse a Flink data type with nullable options, NULL -> nullable, NOT NULL ->
not nullable.
-* Default to be nullable.
+/*
+* Parses collection type name that does not belong to standard SQL, i.e.
ARRAYINT NOT NULL.
*/
-SqlDataTypeSpec FlinkDataType() :
+SqlTypeNameSpec ExtendedCollectionsTypeName() :
Review comment:
Thanks, i have renamed `ExtendedCollectionsTypeName2` to
`CustomizedCollectionsTypeName`.
The `ExtendedCollectionsTypeName` supports NULL/NOT NULL options compared to
Calcite core `CollectionsTypeName`, i.e. "INT NOT NULL ARRAY", i have addressed
this in the comments.
The `CustomizedCollectionsTypeName` is totally customized by Flink, whose
syntax does not belong to standard SQL, i.e. "ARRAYINT NOT NULL7bt;"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] highfei2011 closed pull request #9415: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into C…
highfei2011 closed pull request #9415: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into C… URL: https://github.com/apache/flink/pull/9415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] highfei2011 commented on issue #9415: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into C…
highfei2011 commented on issue #9415: [FLINK-12939][docs-zh] Translate "Apache Kafka Connector" page into C… URL: https://github.com/apache/flink/pull/9415#issuecomment-534829104 Open a new PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] GatsbyNewton commented on issue #9761: [FLINK-14031][examples][table]Added the blink planner dependency and …
GatsbyNewton commented on issue #9761: [FLINK-14031][examples][table]Added the blink planner dependency and … URL: https://github.com/apache/flink/pull/9761#issuecomment-534828890 @KurtYoung This is a new PR. Could you please kindly help to review the code changes? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese
flinkbot commented on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763#issuecomment-534828530 ## CI report: * 301e466b5a04494d5e5b3ed0531024227c32e8fc : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0
flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0 URL: https://github.com/apache/flink/pull/9751#issuecomment-534387866 ## CI report: * 5b73b3d6319447fd2d81b48183d9f22012133a6b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128853990) * 9e0f8dbc4abc0caa82a66dd4b250d2716debb709 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128866590) * 47fc6a0206ce150cc62d5038a288e1534db0f79b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128877814) * 5ca23fc651a91a0f1e097eed533d8804c2ec9235 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128971343) * 36e98a73fd1c05a9e74e71944b96b834a1f86894 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129028758) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9744: [FLINK-13515][test] Fix ClassLoaderITCase fails on Java 11
flinkbot edited a comment on issue #9744: [FLINK-13515][test] Fix ClassLoaderITCase fails on Java 11 URL: https://github.com/apache/flink/pull/9744#issuecomment-533988291 ## CI report: * 8210403a33cf3a6908980378fae9ee8d567afdb1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128698798) * 50ef5004d73bc2e677a1fe84dc8cd2a6fb355ced : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129028745) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (FLINK-13037) Translate "Concepts -> Glossary" page into Chinese
[
https://issues.apache.org/jira/browse/FLINK-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888463#comment-16888463
]
Jeff Yang edited comment on FLINK-13037 at 9/25/19 2:46 AM:
Hi,[~jark], Please take a look this
[PR|https://github.com/apache/flink/pull/9763 ].
was (Author: highfei2...@126.com):
Hi,[~jark], Please take a look . [https://github.com/apache/flink/pull/9414]
> Translate "Concepts -> Glossary" page into Chinese
> --
>
> Key: FLINK-13037
> URL: https://issues.apache.org/jira/browse/FLINK-13037
> Project: Flink
> Issue Type: Sub-task
> Components: chinese-translation, Documentation
>Reporter: Konstantin Knauf
>Assignee: Jeff Yang
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Translate Glossary page into Chinese:
> https://ci.apache.org/projects/flink/flink-docs-master/concepts/glossary.html
> The markdown file is located in {{docs/concepts/glossary.md}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese
flinkbot commented on issue #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763#issuecomment-534827572 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 301e466b5a04494d5e5b3ed0531024227c32e8fc (Wed Sep 25 02:46:46 UTC 2019) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
KurtYoung commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327911544
##
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/ExtendedSqlBuiltinTypeNameSpec.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.type;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlUserDefinedTypeNameSpec;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.calcite.sql.validate.SqlValidator;
+
+import java.util.Locale;
+
+/**
+ * A sql type name specification of extended builtin data type, this is
different with
+ * the normal user defined data type, because there is no need to register
them into
+ * the catalog when deriving the data type.
+ */
+public class ExtendedSqlBuiltinTypeNameSpec extends SqlUserDefinedTypeNameSpec
{
Review comment:
The unparse requirement makes sense, but I think this is not sufficient to
treat them as user defined types. UDT is a really big story and involves a lots
of efforts, like you need to customize the compare logics between your types.
In this case, I think it's just a `syntax sugar`, not a user defined type.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yangjf2019 opened a new pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese
yangjf2019 opened a new pull request #9763: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chinese URL: https://github.com/apache/flink/pull/9763 ## What is the purpose of the change *Translate "Concepts -> Glossary" page into Chinese.* ## Brief change log - *I modified the glossary.zh.md file .* ## Verifying this change *I have verified the changes by starting the build script in preview mode.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): ( no ) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no ) - The serializers: ( no ) - The runtime per-record code paths (performance sensitive): ( no ) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no ) - The S3 file system connector: ( no ) ## Documentation - Does this pull request introduce a new feature? ( no ) - If yes, how is the feature documented? ( not documented ) Hi, @wuchong @TisonKun Please Take A Look . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
KurtYoung commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327911170
##
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/ExtendedSqlCollectionTypeNameSpec.java
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.type;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlCollectionTypeNameSpec;
+import org.apache.calcite.sql.SqlTypeNameSpec;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.calcite.sql.validate.SqlValidator;
+import org.apache.calcite.util.Litmus;
+import org.apache.calcite.util.Util;
+
+/**
+ * A extended sql type name specification of collection type,
+ * different with {@link SqlCollectionTypeNameSpec},
+ * we support NULL or NOT NULL suffix for the element type name(this syntax
+ * does not belong to standard SQL).
+ */
+public class ExtendedSqlCollectionTypeNameSpec extends
SqlCollectionTypeNameSpec {
Review comment:
ok, some comments will help reader to understand this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] highfei2011 closed pull request #9414: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chi…
highfei2011 closed pull request #9414: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chi… URL: https://github.com/apache/flink/pull/9414 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] highfei2011 commented on issue #9414: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chi…
highfei2011 commented on issue #9414: [FLINK-13037][docs-zh] Translate "Concepts -> Glossary" page into Chi… URL: https://github.com/apache/flink/pull/9414#issuecomment-534826349 Open a new PR . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327910279 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -290,6 +292,12 @@ private final SqlValidatorImpl.ValidationErrorFunction validationErrorFunction = new SqlValidatorImpl.ValidationErrorFunction(); + // TypeCoercion instance used for implicit type coercion. + private TypeCoercion typeCoercion; Review comment: Yes, this instance is default there, it does not bring in any overhead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327910106 ## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRuleTest.xml ## @@ -1,435 +0,0 @@ - - - Review comment: There are already some tests in Calcite, maybe we should add tests only for new added Flink rules. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327909838
##
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/ExtendedSqlCollectionTypeNameSpec.java
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.type;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlCollectionTypeNameSpec;
+import org.apache.calcite.sql.SqlTypeNameSpec;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.calcite.sql.validate.SqlValidator;
+import org.apache.calcite.util.Litmus;
+import org.apache.calcite.util.Util;
+
+/**
+ * A extended sql type name specification of collection type,
+ * different with {@link SqlCollectionTypeNameSpec},
+ * we support NULL or NOT NULL suffix for the element type name(this syntax
+ * does not belong to standard SQL).
+ */
+public class ExtendedSqlCollectionTypeNameSpec extends
SqlCollectionTypeNameSpec {
Review comment:
Because the constructor of `SqlTypeNameSpec` constructor is package scope,
previously i think Calcite's `SqlTypeNameSpec` is enough for Flink extension,
but it's not, i have fixed this in CALCITE-3360, we can move them into
`org.apache.flink.sql.parser.type` for the next Calcite version.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9542: [FLINK-13873][metrics] Change the column family as tags for influxdb …
flinkbot edited a comment on issue #9542: [FLINK-13873][metrics] Change the column family as tags for influxdb … URL: https://github.com/apache/flink/pull/9542#issuecomment-525276537 ## CI report: * e8636926351f3d406962dcadba275e20e49aff39 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124736151) * d23ea97e8419bbacea0698b3ba82a459d940cf38 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/128606376) * 05977cd49eb306d768668be4e8cb31034343df02 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128606947) * 057d453e5e00656bcfcb87d1d69172f614b2d11f : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/128681895) * 5001042b5fc5202da14c06e2d21faf1427f50a66 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128683546) * 3a1e39e889daf0fca82c54982911ded35df6cb77 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128692102) * 2745a3cb02e601a1a26360e9d6b3f0af5428c66a : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/129027621) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327909362
##
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/type/ExtendedSqlBuiltinTypeNameSpec.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser.type;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.rel.type.RelDataTypeFactory;
+import org.apache.calcite.sql.SqlUserDefinedTypeNameSpec;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.SqlTypeName;
+import org.apache.calcite.sql.validate.SqlValidator;
+
+import java.util.Locale;
+
+/**
+ * A sql type name specification of extended builtin data type, this is
different with
+ * the normal user defined data type, because there is no need to register
them into
+ * the catalog when deriving the data type.
+ */
+public class ExtendedSqlBuiltinTypeNameSpec extends SqlUserDefinedTypeNameSpec
{
Review comment:
We need this class to customize the unparse the logic, `STRING` is always
unparsed to `STRING` not `VARCHAR(INT_MAX)`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0
flinkbot edited a comment on issue #9751: [FLINK-14177] bump curator from 2.12.0 to 4.2.0 URL: https://github.com/apache/flink/pull/9751#issuecomment-534387866 ## CI report: * 5b73b3d6319447fd2d81b48183d9f22012133a6b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128853990) * 9e0f8dbc4abc0caa82a66dd4b250d2716debb709 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128866590) * 47fc6a0206ce150cc62d5038a288e1534db0f79b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128877814) * 5ca23fc651a91a0f1e097eed533d8804c2ec9235 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128971343) * 36e98a73fd1c05a9e74e71944b96b834a1f86894 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9744: [FLINK-13515][test] Fix ClassLoaderITCase fails on Java 11
flinkbot edited a comment on issue #9744: [FLINK-13515][test] Fix ClassLoaderITCase fails on Java 11 URL: https://github.com/apache/flink/pull/9744#issuecomment-533988291 ## CI report: * 8210403a33cf3a6908980378fae9ee8d567afdb1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128698798) * 50ef5004d73bc2e677a1fe84dc8cd2a6fb355ced : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327908141 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl ## @@ -644,26 +532,35 @@ void FieldNameTypeCommaList( } /** -* Parse Row type, we support both Row(name1 type1, name2 type2) and Row. -* Every item type can have suffix of `NULL` or `NOT NULL` to indicate if this type is nullable. -* i.e. Row(f0 int not null, f1 varchar null). +* Parse Row type, we support both Row(name1 type1, name2 type2) +* and Rowname1 type1, name2 type2. +* Every item type can have a suffix of `NULL` or `NOT NULL` to indicate if this type is nullable. +* i.e. Row(f0 int not null, f1 varchar null). Default is nullable. */ -SqlIdentifier SqlRowType() : +SqlTypeNameSpec ExtendedSqlRowTypeName() : Review comment: Thanks, i have added the comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656]
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r327908022
##
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##
@@ -375,210 +387,83 @@ SqlDrop SqlDropView(Span s, boolean replace) :
}
}
-SqlIdentifier FlinkCollectionsTypeName() :
-{
-}
-{
-LOOKAHEAD(2)
- {
-return new SqlIdentifier(SqlTypeName.MULTISET.name(), getPos());
-}
-|
- {
-return new SqlIdentifier(SqlTypeName.ARRAY.name(), getPos());
-}
-}
-
-SqlIdentifier FlinkTypeName() :
+SqlTypeNameSpec SqlUserDefinedTypeName() :
{
-final SqlTypeName sqlTypeName;
-final SqlIdentifier typeName;
-final Span s = Span.of();
+final String typeName;
}
{
(
-<#-- additional types are included here -->
-<#-- make custom data types in front of Calcite core data types -->
-<#list parser.flinkDataTypeParserMethods as method>
-<#if (method?index > 0)>
-|
-
-LOOKAHEAD(2)
-typeName = ${method}
-
+ { typeName = token.image; }
|
-LOOKAHEAD(2)
-sqlTypeName = SqlTypeName(s) {
-typeName = new SqlIdentifier(sqlTypeName.name(), s.end(this));
-}
-|
-LOOKAHEAD(2)
-typeName = FlinkCollectionsTypeName()
-|
-typeName = CompoundIdentifier() {
-throw new ParseException("UDT in DDL is not supported yet.");
-}
+ { typeName = token.image; }
)
{
-return typeName;
+return new ExtendedSqlBuiltinTypeNameSpec(token.image, getPos());
}
}
-/**
-* Parse a Flink data type with nullable options, NULL -> nullable, NOT NULL ->
not nullable.
-* Default to be nullable.
+/*
+* Parses collection type name that does not belong to standard SQL, i.e.
ARRAYINT NOT NULL.
*/
-SqlDataTypeSpec FlinkDataType() :
+SqlTypeNameSpec ExtendedCollectionsTypeName() :
Review comment:
Thanks, i have renamed `ExtendedCollectionsTypeName2` to
`CustomizedCollectionsTypeName`.
The `ExtendedCollectionsTypeName` supports NULL/NOT NULL options compared to
Calcite core `CollectionsTypeName`, i.e. "INT NOT NULL ARRAY", i have addressed
this in the comments.
The `CustomizedCollectionsTypeName` is totally customized by Flink, whose
syntax does not belong to standard SQL, i.e. "ARRAY"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support
flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#issuecomment-533110106 ## CI report: * d9c1dd529ef235649909d067cc78099179656e62 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128334151) * 603db694488096f1491b5ccb068d9e783636a8c8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128375005) * 9bc5949275f7997eadd03e2ec1fe8937ee2e689f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453921) * 53bfd624b1258c5f1c269952d155f2c981476769 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128462077) * 566cbfff4439557cb6cdd767db501f8c49e5caf6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128467326) * bbae03349addd55bb69328c64f07209b7aa3190e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128751101) * 2fbb1182ce21d38b3c0cec43e41d52d911385bba : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128845470) * a89047bd806a050101b3ce8220534ab7df9700af : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128862483) * 5e0a6ffe3b7818d6526c47a995f10aaf92ec5d5d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128910685) * bfeeca49661520bd3241a37200be18804f9cfe23 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/129026485) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-13836) Improve support of java.util.UUID for JDBCTypeUtil
[ https://issues.apache.org/jira/browse/FLINK-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937341#comment-16937341 ] Jark Wu commented on FLINK-13836: - Hi [~flacombe], In which case, the JDBC will receive a UUID object? > Improve support of java.util.UUID for JDBCTypeUtil > -- > > Key: FLINK-13836 > URL: https://issues.apache.org/jira/browse/FLINK-13836 > Project: Flink > Issue Type: Improvement > Components: Connectors / JDBC >Affects Versions: 1.8.0 >Reporter: François Lacombe >Priority: Major > > Currently, JDBCTypeUtil used by JDBCAppendTableSinkBuilder dones't support > UUID types with java.util.UUID in Java. > Could it be possible to handle that as to allow to write UUID directly to > postgresql please? > > java.lang.IllegalArgumentException: Unsupported type: > GenericType > at > org.apache.flink.api.java.io.jdbc.JDBCTypeUtil.typeInformationToSqlType(JDBCTypeUtil.java:91) > at > org.apache.flink.api.java.io.jdbc.JDBCAppendTableSinkBuilder.setParameterTypes(JDBCAppendTableSinkBuilder.java:103) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #9542: [FLINK-13873][metrics] Change the column family as tags for influxdb …
flinkbot edited a comment on issue #9542: [FLINK-13873][metrics] Change the column family as tags for influxdb … URL: https://github.com/apache/flink/pull/9542#issuecomment-525276537 ## CI report: * e8636926351f3d406962dcadba275e20e49aff39 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/124736151) * d23ea97e8419bbacea0698b3ba82a459d940cf38 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/128606376) * 05977cd49eb306d768668be4e8cb31034343df02 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128606947) * 057d453e5e00656bcfcb87d1d69172f614b2d11f : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/128681895) * 5001042b5fc5202da14c06e2d21faf1427f50a66 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128683546) * 3a1e39e889daf0fca82c54982911ded35df6cb77 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128692102) * 2745a3cb02e601a1a26360e9d6b3f0af5428c66a : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327905909 ## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl ## @@ -81,6 +66,33 @@ void TableColumn2(List list) : } } +/** +* Different with #DataType, we support a [ NULL | NOT NULL ] suffix syntax for both the Review comment: Sure, let me update it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0
danny0405 commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327905534 ## File path: flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd ## @@ -439,6 +424,14 @@ "SqlDropView" ] + # Binary operators tokens Review comment: This is extended from the core parser which is used for customizing the binary operator tokens, for example, in PostgreSQL, we can have a `::` token to implies `CAST` operator: `a :: INT` is equals to `CAST(a as INT)`. For Flink, we does not need this now, the parser just complains if we does not have such section. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support
flinkbot edited a comment on issue #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#issuecomment-533110106 ## CI report: * d9c1dd529ef235649909d067cc78099179656e62 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128334151) * 603db694488096f1491b5ccb068d9e783636a8c8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128375005) * 9bc5949275f7997eadd03e2ec1fe8937ee2e689f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128453921) * 53bfd624b1258c5f1c269952d155f2c981476769 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128462077) * 566cbfff4439557cb6cdd767db501f8c49e5caf6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128467326) * bbae03349addd55bb69328c64f07209b7aa3190e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128751101) * 2fbb1182ce21d38b3c0cec43e41d52d911385bba : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128845470) * a89047bd806a050101b3ce8220534ab7df9700af : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128862483) * 5e0a6ffe3b7818d6526c47a995f10aaf92ec5d5d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128910685) * bfeeca49661520bd3241a37200be18804f9cfe23 : UNKNOWN This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14159) flink rocksdb StreamCompressionDecorator not right
[
https://issues.apache.org/jira/browse/FLINK-14159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937332#comment-16937332
]
Congxian Qiu(klion26) commented on FLINK-14159:
---
[~jackylau] Yes, When we use {{SnappyStreamCompressionDecorator}} and in
FullSnapshot, we'll compress twice(Rocksdb's compression and checkpoint
compression), in incremental snapshot we'll just compress once(The rocksdb's
compression)
> flink rocksdb StreamCompressionDecorator not right
> --
>
> Key: FLINK-14159
> URL: https://issues.apache.org/jira/browse/FLINK-14159
> Project: Flink
> Issue Type: Bug
> Components: Runtime / State Backends
>Affects Versions: 1.9.0
>Reporter: jackylau
>Priority: Major
> Fix For: 1.10.0
>
>
> I think the current flink rocksdb StreamCompressionDecorator is not right
> when calling method
> getCompressionDecorator(executionConfig) ,which defalut value is false.That
> is to say, current compression is none.But I find rocksdb using
> {{options.compression}} to specify the compression to use. By default it is
> Snappy, which you can see here
> [https://github.com/facebook/rocksdb/wiki/RocksDB-Tuning-Guide]. And I use
> rocksdb tool sstdump to find it is indeed snappy compression.
> So I think it should be return SnappyStreamCompressionDecorator.INSTANCE
> rather than getCompressionDecorator( executionConfig)
> Coud i commit a PR?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-2491) Checkpointing only works if all operators/tasks are still running
[
https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937329#comment-16937329
]
Congxian Qiu(klion26) commented on FLINK-2491:
--
[~tomas.witzany] Currently, maybe State Process API[1] can help,
{{Apache Flink’s State Processor API provides powerful functionality to
reading, writing, and modifing savepoints and checkpoints using Flink’s batch
DataSet api.}}
[1][https://ci.apache.org/projects/flink/flink-docs-release-1.9/dev/libs/state_processor_api.html]
> Checkpointing only works if all operators/tasks are still running
> -
>
> Key: FLINK-2491
> URL: https://issues.apache.org/jira/browse/FLINK-2491
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 0.10.0
>Reporter: Robert Metzger
>Priority: Critical
> Attachments: fix_checkpoint_not_working_if_tasks_are_finished.patch
>
>
> While implementing a test case for the Kafka Consumer, I came across the
> following bug:
> Consider the following topology, with the operator parallelism in parentheses:
> Source (2) --> Sink (1).
> In this setup, the {{snapshotState()}} method is called on the source, but
> not on the Sink.
> The sink receives the generated data.
> only one of the two sources is generating data.
> I've implemented a test case for this, you can find it here:
> https://github.com/rmetzger/flink/blob/para_checkpoint_bug/flink-tests/src/test/java/org/apache/flink/test/checkpointing/ParallelismChangeCheckpoinedITCase.java
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] sunjincheng121 edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Py
sunjincheng121 edited a comment on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python function execution URL: https://github.com/apache/flink/pull/9748#issuecomment-534481069 Thanks a lot for your contribute @dianfu . I have gone through the PR. My main comments are below: - For the logical node, I think we don't need to create a new node for the python, instead, we can reuse the current `FlinkLogicalCalc` node. In this way, not only we can reuse most of the code, but also I think it matches the semantic that it is a Calc. - For the physical node, we can create a `DataStreamCalcBase` node and let both `DataStreamPythonCalc` and `DataStreamCalc` extend it. - For the split rule, maybe we can further split the calc a bit, i.e., don't mix java and python UDFs rather than further split them in translateToPlan. Doing all split in the split rule is more clear. - For the filter, we calculate these condition UDFs together with other UDFs and do the filter later. I think we can optimize it a bit, i.e., calculate the conditions first and then check whether to call the other UDFs. This can be easily achieved in the SplitRule. Last for the new optimization phase, I agree with the current design. Another choice is using the current logic optimization phase, but I think it would bring some side effects like a) The PythonSplitRule would conflict with the CalcMerge rules and we need to do some hack for the merge rules. b) Adding all rules in logical phase makes the time of optimization longer and longer. This is the reason that we have a lot of Rule based optimization phase in Blink. What do you think? @dianfu @twalthr :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[ https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937315#comment-16937315 ] wangxiyuan commented on FLINK-14178: Hi [~dian.fu] I have attached the debug file. You can see that from Line79079 with `Dependency-reduced POM written at: /home/zuul/flink/flink-table/flink-sql-parser/target/dependency-reduced-pom.xml`, after this line, there is an infinite loop forever. The behavior is strange and I found a similar [bug|https://www.mail-archive.com/dev@htrace.incubator.apache.org/msg00844.html] But Apache Spark uses 3.2.1 as well and it works well on ARM. It seems that this bug only in flink-sql-parser. Sorry that I'm not sure the deep reason. I'm agree that downgrading to 3.1.0 is not the best way as you mentioned. How about add a new profile section in pom.xml for ARM? It'll not break Flink's default action on X86. And in the future, some ARM specified changes can be added there as well. > maven-shade-plugin 3.2.1 doesn't work on ARM for Flink > -- > > Key: FLINK-14178 > URL: https://issues.apache.org/jira/browse/FLINK-14178 > Project: Flink > Issue Type: Sub-task > Components: Build System >Affects Versions: 2.0.0 >Reporter: wangxiyuan >Priority: Minor > Fix For: 2.0.0 > > Attachments: debug.log > > > recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the > [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e]. > While with my test locally on ARM, The Flink build process will be jammed. > After debugging, I found there is an infinite loop. > Downgrade maven-shade-plugin to 3.1.0 can solve this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-14178) maven-shade-plugin 3.2.1 doesn't work on ARM for Flink
[ https://issues.apache.org/jira/browse/FLINK-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxiyuan updated FLINK-14178: --- Attachment: debug.log > maven-shade-plugin 3.2.1 doesn't work on ARM for Flink > -- > > Key: FLINK-14178 > URL: https://issues.apache.org/jira/browse/FLINK-14178 > Project: Flink > Issue Type: Sub-task > Components: Build System >Affects Versions: 2.0.0 >Reporter: wangxiyuan >Priority: Minor > Fix For: 2.0.0 > > Attachments: debug.log > > > recently, maven-shade-plugin is bumped from 3.0.0 to 3.2.1 by the > [commit|https://github.com/apache/flink/commit/e7216eebc846a69272c21375af0f4db8009c2e3e]. > While with my test locally on ARM, The Flink build process will be jammed. > After debugging, I found there is an infinite loop. > Downgrade maven-shade-plugin to 3.1.0 can solve this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #9745: [FLINK-14070] [runtime] Use TimeUtils to parse duration configs in flink-runtime
flinkbot edited a comment on issue #9745: [FLINK-14070] [runtime] Use TimeUtils to parse duration configs in flink-runtime URL: https://github.com/apache/flink/pull/9745#issuecomment-534005398 ## CI report: * d4ab076561b7d4d88347d55a1764d2a6d57507c3 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128705798) * d64b99e2baee3feaa864a7029d71cc05bad84b58 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128711407) * cdc98122d632bfd6a5944ecf2d96ed36ad74ebb6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128866565) * b0cd94b73b53cbae0b93bbba5a88718203e0be6f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128881105) * 156dcfe58b7cf8f199875fea83ba14e7cb458a38 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128891074) * 0d518c7bca79582290b4fd2028eb7fb5febf5afb : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128965582) * 8097abd919757f15d84c61a31e69efa091bb949f : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/128980387) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9762: !IGNORE! ZK 3.5.5 shaded migration
flinkbot edited a comment on issue #9762: !IGNORE! ZK 3.5.5 shaded migration URL: https://github.com/apache/flink/pull/9762#issuecomment-534689957 ## CI report: * cefac57542dbd85a6693f6a1b7c8c90d91e85d30 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/128980426) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
