[jira] [Closed] (FLINK-16181) IfCallGen will throw NPE for primitive types in blink

2020-07-13 Thread Benchao Li (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benchao Li closed FLINK-16181.
--
Resolution: Fixed

> IfCallGen will throw NPE for primitive types in blink
> -
>
> Key: FLINK-16181
> URL: https://issues.apache.org/jira/browse/FLINK-16181
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.3, 1.10.1, 1.11.0
>Reporter: Benchao Li
>Assignee: Benchao Li
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It can be reproduced by a simple test case:
> Add below to {{ScalarOperatorsTest}}
> {code:java}
> testSqlApi("IF(true, CAST('non-numeric' AS BIGINT), 0)", "null")
> {code}
>  
> IMO, it's {{IfCallGen}}'s bug, which should judge the nullTerm of operands 
> first before assignment.
> cc [~lzljs3620320] [~jark]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-16181) IfCallGen will throw NPE for primitive types in blink

2020-07-13 Thread Benchao Li (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benchao Li updated FLINK-16181:
---
Affects Version/s: 1.9.3
   1.10.1
   1.11.0

> IfCallGen will throw NPE for primitive types in blink
> -
>
> Key: FLINK-16181
> URL: https://issues.apache.org/jira/browse/FLINK-16181
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.9.3, 1.10.1, 1.11.0
>Reporter: Benchao Li
>Assignee: Benchao Li
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It can be reproduced by a simple test case:
> Add below to {{ScalarOperatorsTest}}
> {code:java}
> testSqlApi("IF(true, CAST('non-numeric' AS BIGINT), 0)", "null")
> {code}
>  
> IMO, it's {{IfCallGen}}'s bug, which should judge the nullTerm of operands 
> first before assignment.
> cc [~lzljs3620320] [~jark]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18593) Hive bundle jar URLs are broken

2020-07-13 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-18593:


 Summary: Hive bundle jar URLs are broken
 Key: FLINK-18593
 URL: https://issues.apache.org/jira/browse/FLINK-18593
 Project: Flink
  Issue Type: New Feature
  Components: Connectors / Hive, Documentation
Affects Versions: 1.11.0
Reporter: Jingsong Lee
 Fix For: 1.11.1


we should use [https://repo.maven.apache.org/maven2/] instead



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-16181) IfCallGen will throw NPE for primitive types in blink

2020-07-13 Thread Benchao Li (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benchao Li updated FLINK-16181:
---
Fix Version/s: 1.11.1
   1.12.0

> IfCallGen will throw NPE for primitive types in blink
> -
>
> Key: FLINK-16181
> URL: https://issues.apache.org/jira/browse/FLINK-16181
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Reporter: Benchao Li
>Assignee: Benchao Li
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It can be reproduced by a simple test case:
> Add below to {{ScalarOperatorsTest}}
> {code:java}
> testSqlApi("IF(true, CAST('non-numeric' AS BIGINT), 0)", "null")
> {code}
>  
> IMO, it's {{IfCallGen}}'s bug, which should judge the nullTerm of operands 
> first before assignment.
> cc [~lzljs3620320] [~jark]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16181) IfCallGen will throw NPE for primitive types in blink

2020-07-13 Thread Benchao Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157161#comment-17157161
 ] 

Benchao Li commented on FLINK-16181:


Fixed via:

1.12.0: d677f02853ed7395730c6282cd33bb0f5bbf4bd3

1.11.1: 39b4778a3eaae81902203d558335ed4fbbd8e379

> IfCallGen will throw NPE for primitive types in blink
> -
>
> Key: FLINK-16181
> URL: https://issues.apache.org/jira/browse/FLINK-16181
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Reporter: Benchao Li
>Assignee: Benchao Li
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> It can be reproduced by a simple test case:
> Add below to {{ScalarOperatorsTest}}
> {code:java}
> testSqlApi("IF(true, CAST('non-numeric' AS BIGINT), 0)", "null")
> {code}
>  
> IMO, it's {{IfCallGen}}'s bug, which should judge the nullTerm of operands 
> first before assignment.
> cc [~lzljs3620320] [~jark]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] KarmaGYZ commented on pull request #12865: [FLINK-18264][doc] Translate External Resources page to Chinese

2020-07-13 Thread GitBox


KarmaGYZ commented on pull request #12865:
URL: https://github.com/apache/flink/pull/12865#issuecomment-657983159


   cc @xintongsong 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] libenchao closed pull request #11161: [FLINK-16181][table-planner-blink] Fix IfCallGen throw NPE when opera…

2020-07-13 Thread GitBox


libenchao closed pull request #11161:
URL: https://github.com/apache/flink/pull/11161


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] liuyongvs commented on pull request #12866: [FLINK-17425][blink-planner] supportsFilterPushDown rule in DynamicSource.

2020-07-13 Thread GitBox


liuyongvs commented on pull request #12866:
URL: https://github.com/apache/flink/pull/12866#issuecomment-657981651


   hi @godfreyhe, you can review it now. The blink planner tests passed. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12894: [BP-1.11][FLINK-18583][elasticsearch] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12894:
URL: https://github.com/apache/flink/pull/12894#issuecomment-657975576


   
   ## CI report:
   
   * 06d18e45d8c3e577d658fee182f65b78b941f556 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4484)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] libenchao commented on pull request #11161: [FLINK-16181][table-planner-blink] Fix IfCallGen throw NPE when opera…

2020-07-13 Thread GitBox


libenchao commented on pull request #11161:
URL: https://github.com/apache/flink/pull/11161#issuecomment-657981069


   the CI is passed in my AZP: 
https://dev.azure.com/libenchao/flink.benchao/_build/results?buildId=28=results
   merging.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12895: [hotfix][docs-zh] Fix invalid links in the page 'dev/table/streaming/match_recognize.zh.md'

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12895:
URL: https://github.com/apache/flink/pull/12895#issuecomment-657975620


   
   ## CI report:
   
   * cbae20b40049430d003e0c7c7313630b549b766b Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4485)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-652303680


   
   ## CI report:
   
   * ad5d5dcac846080e2e40255505dd35896a6c7a94 UNKNOWN
   * fcc745b41155021174e1d85539064421318c0cf3 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4474)
 
   * b434eaab7904576207148894fa75f8f53ed29c41 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4478)
 
   * 98dcc88fa488050b6566f181b821ef9e86f2b8d6 UNKNOWN
   * 0d5eb5381c60a85925ad4269ada844fc49709b95 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18590) Support json array explode to multi messages

2020-07-13 Thread Benchao Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157159#comment-17157159
 ] 

Benchao Li commented on FLINK-18590:


I also thought about the way how we should add this, there is two ways come 
into my head:
 1. do an implicit conversion, we can use {{JsonNode#isArray()}} to do this;
 2. do an explicit conversion, this way, we need an option.

Both ways are ok to me. I'm a little lean to #1, because it can handle both 
kinds of data at the same time. 

> Support json array explode to multi messages
> 
>
> Key: FLINK-18590
> URL: https://issues.apache.org/jira/browse/FLINK-18590
> Project: Flink
>  Issue Type: Improvement
>  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Reporter: Benchao Li
>Priority: Major
>
> Currently our {{DeserializationSchema}} has supported to emit multi messages 
> for one input record. There is some cases that the json data is not a json 
> object in top level, for example:
> {code:SQL}
> CREATE TABLE source (
>   col1 int,
>   col2 varchar
> ) WITH (
>   ...
>   'format' = 'json'
> )
> {code}
> With following data.
> {code:json}
> [
> {"col1": 1, "col2": "hello"},
> {"col1": 2, "col2": "flink"}
> ]
> {code}
> CC [~jark]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] klion26 commented on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


klion26 commented on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-657979255


   @RocMarshal thanks for the fix, I'll have a final review and give response 
asap.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] klion26 commented on a change in pull request #12665: [FLINK-17886][docs-zh] Update Chinese documentation for new Watermark…

2020-07-13 Thread GitBox


klion26 commented on a change in pull request #12665:
URL: https://github.com/apache/flink/pull/12665#discussion_r454109437



##
File path: docs/dev/event_timestamp_extractors.zh.md
##
@@ -25,83 +25,50 @@ under the License.
 * toc
 {:toc}
 
-As described in [timestamps and watermark handling]({{ site.baseurl 
}}/dev/event_timestamps_watermarks.html),
-Flink provides abstractions that allow the programmer to assign their own 
timestamps and emit their own watermarks. More specifically,
-one can do so by implementing one of the `AssignerWithPeriodicWatermarks` and 
`AssignerWithPunctuatedWatermarks` interfaces, depending
-on the use case. In a nutshell, the first will emit watermarks periodically, 
while the second does so based on some property of
-the incoming records, e.g. whenever a special element is encountered in the 
stream.
+如[生成 Watermark]({{ site.baseurl }}/zh/dev/event_timestamps_watermarks.html) 
小节中所述,Flink 提供的抽象方法可以允许用户自己去定义时间戳分配方式和 watermark 发出的方式。具体就是你可以通过实现 
`WatermarkGenerator` 接口来实现上述功能。
 
-In order to further ease the programming effort for such tasks, Flink comes 
with some pre-implemented timestamp assigners.
-This section provides a list of them. Apart from their out-of-the-box 
functionality, their implementation can serve as an example
-for custom implementations.
+为了进一步简化此类任务的编程工作,Flink 框架预设了一些时间戳分配器。本节后续内容有举例。除了开箱即用的已有实现外,其还可以作为自定义实现的示例以供参考。
 
-### **Assigners with ascending timestamps**
+## 时间戳单调递增
 
-The simplest special case for *periodic* watermark generation is the case 
where timestamps seen by a given source task
-occur in ascending order. In that case, the current timestamp can always act 
as a watermark, because no earlier timestamps will
-arrive.
+*周期性* watermark 生成方式的一个最简单特例就是你给定的数据源中数据的时间戳升序出现。在这种情况下,当前时间戳就可以充当 
watermark,因为后续到达数据的时间戳不会比当前的小。
 
-Note that it is only necessary that timestamps are ascending *per parallel 
data source task*. For example, if
-in a specific setup one Kafka partition is read by one parallel data source 
instance, then it is only necessary that
-timestamps are ascending within each Kafka partition. Flink's watermark 
merging mechanism will generate correct
-watermarks whenever parallel streams are shuffled, unioned, connected, or 
merged.
+注意:在 Flink 应用程序中,如果是并行数据源,则只要求并行数据源中的每个*单分区数据源任务*时间戳递增。例如,设置每一个并行数据源实例都只读取一个 
Kafka 分区,则时间戳只需在每个 Kafka 分区内递增即可。Flink 的 watermark 
合并机制会在并行数据流进行分发(shuffle)、联合(union)、连接(connect)或合并(merge)时生成正确的 watermark。
 
 
 
 {% highlight java %}
-DataStream stream = ...
-
-DataStream withTimestampsAndWatermarks =
-stream.assignTimestampsAndWatermarks(new 
AscendingTimestampExtractor() {
-
-@Override
-public long extractAscendingTimestamp(MyEvent element) {
-return element.getCreationTime();
-}
-});
+WatermarkStrategies
+.forMonotonousTimestamps()
+.build();
 {% endhighlight %}
 
 
 {% highlight scala %}
-val stream: DataStream[MyEvent] = ...
-
-val withTimestampsAndWatermarks = stream.assignAscendingTimestamps( 
_.getCreationTime )
+WatermarkStrategies
+  .forMonotonousTimestamps[MyType]()
+  .build()
 {% endhighlight %}
 
 
 
-### **Assigners allowing a fixed amount of lateness**
+## 数据之间存在最大固定延迟
 
-Another example of periodic watermark generation is when the watermark lags 
behind the maximum (event-time) timestamp
-seen in the stream by a fixed amount of time. This case covers scenarios where 
the maximum lateness that can be encountered in a
-stream is known in advance, e.g. when creating a custom source containing 
elements with timestamps spread within a fixed period of
-time for testing. For these cases, Flink provides the 
`BoundedOutOfOrdernessTimestampExtractor` which takes as an argument
-the `maxOutOfOrderness`, i.e. the maximum amount of time an element is allowed 
to be late before being ignored when computing the
-final result for the given window. Lateness corresponds to the result of `t - 
t_w`, where `t` is the (event-time) timestamp of an
-element, and `t_w` that of the previous watermark. If `lateness > 0` then the 
element is considered late and is, by default, ignored when computing
-the result of the job for its corresponding window. See the documentation 
about [allowed lateness]({{ site.baseurl 
}}/dev/stream/operators/windows.html#allowed-lateness)
-for more information about working with late elements.
+另一个周期性 watermark 生成的典型例子是,watermark 
滞后于数据流中最大(事件时间)时间戳一个固定的时间量。该示例可以覆盖的场景是你预先知道数据流中的数据可能遇到的最大延迟,例如,在测试场景下创建了一个自定义数据源,并且这个数据源的产生的数据的时间戳在一个固定范围之内。Flink
 针对上述场景提供了 `boundedOutfordernessWatermarks` 生成器,该生成器将 `maxOutOfOrderness` 
作为参数,该参数代表在计算给定窗口的结果时,允许元素被忽略计算之前延迟到达的最长时间。其中延迟时长就等于 `t_w - t` ,其中 `t` 
代表元素的(事件时间)时间戳,`t_w` 代表前一个 watermark 对应的(事件时间)时间戳。如果 `lateness > 
0`,则认为该元素迟到了,并且在计算相应窗口的结果时默认会被忽略。有关使用延迟元素的详细内容,请参阅有关[允许延迟]({{ 
site.baseurl}}/zh/dev/stream/operators/windows.html#allowed-lateness)的文档。

Review comment:
   链接建议使用 `{%link %}` 的形式

##
File path: docs/dev/event_time.zh.md
##
@@ -67,21 +67,18 @@ 

[GitHub] [flink] flinkbot commented on pull request #12895: [hotfix][docs-zh] Fix invalid links in the page 'dev/table/streaming/match_recognize.zh.md'

2020-07-13 Thread GitBox


flinkbot commented on pull request #12895:
URL: https://github.com/apache/flink/pull/12895#issuecomment-657975620


   
   ## CI report:
   
   * cbae20b40049430d003e0c7c7313630b549b766b UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12893: [hotfix][docs] Fix the misspelling of 'feeback' to 'feedback' in the page 'docs/dev/table/streaming/match_recognize.md'

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12893:
URL: https://github.com/apache/flink/pull/12893#issuecomment-657962895


   
   ## CI report:
   
   * 5c9153e1ca5b42f4c66d9e7205fc26607735655b Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4481)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-652303680


   
   ## CI report:
   
   * ad5d5dcac846080e2e40255505dd35896a6c7a94 UNKNOWN
   * fcc745b41155021174e1d85539064421318c0cf3 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4474)
 
   * b434eaab7904576207148894fa75f8f53ed29c41 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4478)
 
   * 98dcc88fa488050b6566f181b821ef9e86f2b8d6 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12894: [BP-1.11][FLINK-18583][elasticsearch] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


flinkbot commented on pull request #12894:
URL: https://github.com/apache/flink/pull/12894#issuecomment-657975576


   
   ## CI report:
   
   * 06d18e45d8c3e577d658fee182f65b78b941f556 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal commented on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


RocMarshal commented on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-657972803


   @klion26 
   It seems to be getting more rigorous, as you say.
   Thank you for your help.
   I made some changes and fixed some formatting issues based on your 
suggestions.
   Please take a look.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal removed a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


RocMarshal removed a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-657952807


   @klion26 
   It seems to be getting more rigorous, as you say.
   Thank you for your help. 
   I made some changes and fixed some formatting issues based on your 
suggestions.
   Please take a look.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12895: [hotfix][docs-zh] Fix invalid links in the page 'dev/table/streaming/match_recognize.zh.md'

2020-07-13 Thread GitBox


flinkbot commented on pull request #12895:
URL: https://github.com/apache/flink/pull/12895#issuecomment-657969751


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit cbae20b40049430d003e0c7c7313630b549b766b (Tue Jul 14 
05:09:30 UTC 2020)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal edited a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


RocMarshal edited a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-657952807


   @klion26 
   It seems to be getting more rigorous, as you say.
   Thank you for your help. 
   I made some changes and fixed some formatting issues based on your 
suggestions.
   Please take a look.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal opened a new pull request #12895: [hotfix][docs-zh] Fix invalid links in the page 'dev/table/streaming/match_recognize.zh.md'

2020-07-13 Thread GitBox


RocMarshal opened a new pull request #12895:
URL: https://github.com/apache/flink/pull/12895


   
   
   ## What is the purpose of the change
   
   *Fix invalid links in the page 'dev/table/streaming/match_recognize.zh.md'*
   
   
   ## Brief change log
   
 - *Fix invalid links in the page 
'dev/table/streaming/match_recognize.zh.md'*
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? not applicable



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] zjuwangg closed pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test

2020-07-13 Thread GitBox


zjuwangg closed pull request #10709:
URL: https://github.com/apache/flink/pull/10709


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] zjuwangg commented on pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test

2020-07-13 Thread GitBox


zjuwangg commented on pull request #10709:
URL: https://github.com/apache/flink/pull/10709#issuecomment-657963511


   Close this comment!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12894: [BP-1.11][FLINK-18583][elasticsearch] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


flinkbot commented on pull request #12894:
URL: https://github.com/apache/flink/pull/12894#issuecomment-657962761


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 06d18e45d8c3e577d658fee182f65b78b941f556 (Tue Jul 14 
04:43:03 UTC 2020)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12893: [hotfix][docs] Fix the misspelling of 'feeback' to 'feedback' in the page 'docs/dev/table/streaming/match_recognize.md'

2020-07-13 Thread GitBox


flinkbot commented on pull request #12893:
URL: https://github.com/apache/flink/pull/12893#issuecomment-657962895


   
   ## CI report:
   
   * 5c9153e1ca5b42f4c66d9e7205fc26607735655b UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-652303680


   
   ## CI report:
   
   * ad5d5dcac846080e2e40255505dd35896a6c7a94 UNKNOWN
   * fcc745b41155021174e1d85539064421318c0cf3 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4474)
 
   * b434eaab7904576207148894fa75f8f53ed29c41 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4478)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12891: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12891:
URL: https://github.com/apache/flink/pull/12891#issuecomment-657958349


   
   ## CI report:
   
   * d06c01540a22262960a1f9ef4cf2599b7724f324 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4479)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12892: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12892:
URL: https://github.com/apache/flink/pull/12892#issuecomment-657958406


   
   ## CI report:
   
   * b7a04712992c2390171dd427454c9a1f5b3de7b9 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4480)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-18592) StreamingFileSink fails due to truncating HDFS file failure

2020-07-13 Thread JIAN WANG (Jira)
JIAN WANG created FLINK-18592:
-

 Summary: StreamingFileSink fails due to truncating HDFS file 
failure
 Key: FLINK-18592
 URL: https://issues.apache.org/jira/browse/FLINK-18592
 Project: Flink
  Issue Type: Bug
Affects Versions: 1.10.1
Reporter: JIAN WANG


I meet the issue on flink-1.10.1. I use flink on YARN(3.0.0-cdh6.3.2) with 
StreamingFileSink. 

code part like this:

*public* *static*  StreamingFileSink build(String dir, 
BucketAssigner assigner, String prefix)

{                  return StreamingFileSink.forRowFormat(new Path(dir), new 
SimpleStringEncoder())                          
.withRollingPolicy(DefaultRollingPolicy._builder_()                             
                                               
.withRolloverInterval(TimeUnit.HOURS.toMillis(2))                               
                                              
.withInactivityInterval(TimeUnit.MINUTES.toMillis(10))                          
                                          .withMaxPartSize(1024L * 1024L * 
1024L * 50) // Max 50GB                                                         
  .build())                                  .withBucketAssigner(assigner)      
                                                                                
                     
.withOutputFileConfig(OutputFileConfig._builder_().withPartPrefix(prefix).build())
                       .build();     }

 

The error is 

java.io.IOException: Problem while truncating file: 
hdfs:///business_log/hashtag/2020-06-25/.hashtag-122-37.inprogress.8e65f69c-b5ba-4466-a844-ccc0a5a93de2

Due to this issue, it can not restart from the latest checkpoint and savepoint.

 

Currently, my workaround is that we keep latest 3 checkpoint, and if it fails, 
I manually restart from penult checkpoint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] KarmaGYZ opened a new pull request #12894: [BP-1.11][FLINK-18583][elasticsearch] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


KarmaGYZ opened a new pull request #12894:
URL: https://github.com/apache/flink/pull/12894


   
   
   ## What is the purpose of the change
   
   Fix index id in ElasticSearch6 DynamicTableSink
   
   
   ## Verifying this change
   
   This change is already covered by existing tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] KarmaGYZ commented on pull request #12894: [BP-1.11][FLINK-18583][elasticsearch] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


KarmaGYZ commented on pull request #12894:
URL: https://github.com/apache/flink/pull/12894#issuecomment-657962143


   cc @wuchong 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18590) Support json array explode to multi messages

2020-07-13 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157139#comment-17157139
 ] 

Jark Wu commented on FLINK-18590:
-

Do we need any option to indicate the json format that the input message is a 
json array in top level? 


> Support json array explode to multi messages
> 
>
> Key: FLINK-18590
> URL: https://issues.apache.org/jira/browse/FLINK-18590
> Project: Flink
>  Issue Type: Improvement
>  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Reporter: Benchao Li
>Priority: Major
>
> Currently our {{DeserializationSchema}} has supported to emit multi messages 
> for one input record. There is some cases that the json data is not a json 
> object in top level, for example:
> {code:SQL}
> CREATE TABLE source (
>   col1 int,
>   col2 varchar
> ) WITH (
>   ...
>   'format' = 'json'
> )
> {code}
> With following data.
> {code:json}
> [
> {"col1": 1, "col2": "hello"},
> {"col1": 2, "col2": "flink"}
> ]
> {code}
> CC [~jark]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-652303680


   
   ## CI report:
   
   * ad5d5dcac846080e2e40255505dd35896a6c7a94 UNKNOWN
   * fcc745b41155021174e1d85539064421318c0cf3 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4474)
 
   * b434eaab7904576207148894fa75f8f53ed29c41 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12891: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


flinkbot commented on pull request #12891:
URL: https://github.com/apache/flink/pull/12891#issuecomment-657958349


   
   ## CI report:
   
   * d06c01540a22262960a1f9ef4cf2599b7724f324 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12892: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


flinkbot commented on pull request #12892:
URL: https://github.com/apache/flink/pull/12892#issuecomment-657958406


   
   ## CI report:
   
   * b7a04712992c2390171dd427454c9a1f5b3de7b9 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12893: [hotfix][docs] Fix the misspelling of 'feeback' to 'feedback' in the page 'docs/dev/table/streaming/match_recognize.md'

2020-07-13 Thread GitBox


flinkbot commented on pull request #12893:
URL: https://github.com/apache/flink/pull/12893#issuecomment-657957307


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 5c9153e1ca5b42f4c66d9e7205fc26607735655b (Tue Jul 14 
04:20:26 UTC 2020)
   
   **Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese 
documentation or file Jira ticket.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal opened a new pull request #12893: [hotfix][docs] Fix the misspelling of 'feeback' to 'feedback' in the page 'docs/dev/table/streaming/match_recognize.md'

2020-07-13 Thread GitBox


RocMarshal opened a new pull request #12893:
URL: https://github.com/apache/flink/pull/12893


   
   
   ## What is the purpose of the change
   
   *Fix the misspelling of 'feeback' to 'feedback' in the page 
'docs/dev/table/streaming/match_recognize.md'*
   
   
   ## Brief change log
   
 - *Fix the misspelling of 'feeback' to 'feedback' in the page 
'docs/dev/table/streaming/match_recognize.md'*
   
   
   ## Verifying this change
   
   [hotfix] This change is a trivial rework / code cleanup without any test 
coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): **no**
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
 - The serializers: **no**
 - The runtime per-record code paths (performance sensitive): **no**
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
 - The S3 file system connector: **no**
   
   ## Documentation
   
 - Does this pull request introduce a new feature? **no**
 - If yes, how is the feature documented? **not applicable**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal commented on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


RocMarshal commented on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-657952807


   @klion26 
   It seems to be getting more rigorous, as you say.
   Thank you for your help. 
   And I made some changes and fixed some formatting issues based on your 
suggestions.
   Please take a look.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12892: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


flinkbot commented on pull request #12892:
URL: https://github.com/apache/flink/pull/12892#issuecomment-657951019


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit b7a04712992c2390171dd427454c9a1f5b3de7b9 (Tue Jul 14 
03:53:31 UTC 2020)
   
   **Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese 
documentation or file Jira ticket.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] zhijiangW opened a new pull request #12892: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


zhijiangW opened a new pull request #12892:
URL: https://github.com/apache/flink/pull/12892


   ## What is the purpose of the change
   
   Fix the format issue for metrics web page in link 
https://ci.apache.org/projects/flink/flink-docs-release-1.11/monitoring/metrics.html#checkpointing
   
   ## Brief change log
   
   Fix the metrics.md for adjusting the format.
   
   ## Verifying this change
   
   build the docs locally to verify the metrics web page. 
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)
 - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12891: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


flinkbot commented on pull request #12891:
URL: https://github.com/apache/flink/pull/12891#issuecomment-657950081


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit d06c01540a22262960a1f9ef4cf2599b7724f324 (Tue Jul 14 
03:49:02 UTC 2020)
   
   **Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese 
documentation or file Jira ticket.
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12890: [FLINK-18583] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12890:
URL: https://github.com/apache/flink/pull/12890#issuecomment-657944755


   
   ## CI report:
   
   * 533a66f139697c1fc29441d3d9ccff3da5c82b76 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4477)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12756: [FLINK-18296][json] add support for TIMESTAMP_WITH_LOCAL_ZONE and fix…

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12756:
URL: https://github.com/apache/flink/pull/12756#issuecomment-648131818


   
   ## CI report:
   
   * 4969b51702ffc4a17ed736f7d2d09cc7616d0a3f Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4367)
 
   * 64fb19f04de68c5592bc28fd01c8ea8569fa238b Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4371)
 
   * d666f7b7e4a4e20294d8887b2fc2bf0709f1c2ac Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4476)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-18591) Fix the format issue for metrics web page

2020-07-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-18591:
---
Labels: pull-request-available  (was: )

> Fix the format issue for metrics web page
> -
>
> Key: FLINK-18591
> URL: https://issues.apache.org/jira/browse/FLINK-18591
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Runtime / Metrics
>Affects Versions: 1.11.0
>Reporter: Zhijiang
>Assignee: Zhijiang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0, 1.12.0
>
>
> The formatting issue is shown by link 
> https://ci.apache.org/projects/flink/flink-docs-release-1.11/monitoring/metrics.html#checkpointing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] zhijiangW opened a new pull request #12891: [FLINK-18591][metrics][documentation] Fix the format issue for metrics web page

2020-07-13 Thread GitBox


zhijiangW opened a new pull request #12891:
URL: https://github.com/apache/flink/pull/12891


   ## What is the purpose of the change
   
   Fix the format issue for metrics web page
   
   ## Brief change log
   
   Fix the metrics.md for adjusting the format.
   
   ## Verifying this change
   
   build the docs locally to verify the metrics web page. 
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / **no**)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
 - The serializers: (yes / **no** / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
 - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / **no**)
 - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18540) Unnecessary retract messages when setIdleStateRetentionTime before converting dynamic table to retract stream

2020-07-13 Thread WeiqiangSun (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157130#comment-17157130
 ] 

WeiqiangSun commented on FLINK-18540:
-

It should be consider as a side effect of having a retention config.  Every 
message may cause one or two message to emit. It will make big pressure on the 
downstream operator. For example, unnecessary retract messages  may result in 
extremely high IO when sink to a database .

> Unnecessary retract messages when setIdleStateRetentionTime before converting 
> dynamic table to retract stream
> -
>
> Key: FLINK-18540
> URL: https://issues.apache.org/jira/browse/FLINK-18540
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / Planner, Table SQL / Runtime
>Affects Versions: 1.10.0
>Reporter: WeiqiangSun
>Priority: Critical
>
> Unnecessary retract messages when setIdleStateRetentionTime before converting 
> dynamic table to retract stream。  
>  
> {code:java}
> final StreamExecutionEnvironment env = 
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.setParallelism(1);
> EnvironmentSettings es = 
> EnvironmentSettings.newInstance().inStreamingMode().build();
> StreamTableEnvironment fsTableEnv = StreamTableEnvironment.create(env,es);
> DataStream ds = env.fromElements(5,4,3,2,1);
> // if do not setIdleStateRetentionTime, it will output only one message as 
> expected like '(true,5)' 
> // if do setIdleStateRetentionTime, it will output unnecessary retract 
> messages like '(false,5)/(true,5)'
> fsTableEnv.getConfig().setIdleStateRetentionTime(Time.hours(100),Time.hours(1000));
> fsTableEnv.createTemporaryView("test",ds,"id");
> Table test = fsTableEnv.sqlQuery("select max(id) from test");
> fsTableEnv.toRetractStream(test,Row.class).printToErr();
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18591) Fix the format issue for metrics web page

2020-07-13 Thread Zhijiang (Jira)
Zhijiang created FLINK-18591:


 Summary: Fix the format issue for metrics web page
 Key: FLINK-18591
 URL: https://issues.apache.org/jira/browse/FLINK-18591
 Project: Flink
  Issue Type: Bug
  Components: Documentation, Runtime / Metrics
Affects Versions: 1.11.0
Reporter: Zhijiang
Assignee: Zhijiang
 Fix For: 1.12.0, 1.11.0


The formatting issue is shown by link 
https://ci.apache.org/projects/flink/flink-docs-release-1.11/monitoring/metrics.html#checkpointing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot commented on pull request #12890: [FLINK-18583] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


flinkbot commented on pull request #12890:
URL: https://github.com/apache/flink/pull/12890#issuecomment-657944755


   
   ## CI report:
   
   * 533a66f139697c1fc29441d3d9ccff3da5c82b76 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12756: [FLINK-18296][json] add support for TIMESTAMP_WITH_LOCAL_ZONE and fix…

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12756:
URL: https://github.com/apache/flink/pull/12756#issuecomment-648131818


   
   ## CI report:
   
   * 4969b51702ffc4a17ed736f7d2d09cc7616d0a3f Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4367)
 
   * 64fb19f04de68c5592bc28fd01c8ea8569fa238b Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4371)
 
   * d666f7b7e4a4e20294d8887b2fc2bf0709f1c2ac UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12866: [FLINK-17425][blink-planner] supportsFilterPushDown rule in DynamicSource.

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12866:
URL: https://github.com/apache/flink/pull/12866#issuecomment-656576219


   
   ## CI report:
   
   * 33ee4b79adb34267e83fec40ac38ac09fb567913 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4431)
 
   * 9e4e04643e4e9ad57089577e4c8642a5e18e271f Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4475)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-652303680


   
   ## CI report:
   
   * ad5d5dcac846080e2e40255505dd35896a6c7a94 UNKNOWN
   * fcc745b41155021174e1d85539064421318c0cf3 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4474)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157122#comment-17157122
 ] 

Dian Fu commented on FLINK-18071:
-

Thanks [~becket_qin].

> CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI
> 
>
> Key: FLINK-18071
> URL: https://issues.apache.org/jira/browse/FLINK-18071
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Tests
>Affects Versions: 1.11.0
>Reporter: Robert Metzger
>Assignee: Stephan Ewen
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0, 1.11.2
>
>
> CI: 
> https://dev.azure.com/georgeryan1322/Flink/_build/results?buildId=330=logs=6e58d712-c5cc-52fb-0895-6ff7bd56c46b=f30a8e80-b2cf-535c-9952-7f521a4ae374
> {code}
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.795 
> s <<< FAILURE! - in 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase
> [ERROR] 
> test(org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase)
>   Time elapsed: 4.647 s  <<< FAILURE!
> java.lang.AssertionError: List did not contain expected sequence of 200 
> elements, but was: [152, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 
> 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 
> 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 
> 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 
> 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 
> 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 
> 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 
> 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 
> 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 
> 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 
> 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 
> 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 
> 198, 199]
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.failList(CoordinatorEventsExactlyOnceITCase.java:160)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.checkListContainsSequence(CoordinatorEventsExactlyOnceITCase.java:148)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.test(CoordinatorEventsExactlyOnceITCase.java:143)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17949) KafkaShuffleITCase.testSerDeIngestionTime:156->testRecordSerDe:388 expected:<310> but was:<0>

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157123#comment-17157123
 ] 

Dian Fu commented on FLINK-17949:
-

Another instance on 1.11:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=4465=logs=72d4811f-9f0d-5fd0-014a-0bc26b72b642=19faa67c-fc43-55af-ba4e-7519fca274b5

> KafkaShuffleITCase.testSerDeIngestionTime:156->testRecordSerDe:388 
> expected:<310> but was:<0>
> -
>
> Key: FLINK-17949
> URL: https://issues.apache.org/jira/browse/FLINK-17949
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / Kafka, Tests
>Affects Versions: 1.11.0, 1.12.0
>Reporter: Robert Metzger
>Priority: Critical
>  Labels: test-stability
> Attachments: logs-ci-kafkagelly-1590500380.zip, 
> logs-ci-kafkagelly-1590524911.zip
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=2209=logs=c5f0071e-1851-543e-9a45-9ac140befc32=684b1416-4c17-504e-d5ab-97ee44e08a20
> {code}
> 2020-05-26T13:35:19.4022562Z [ERROR] 
> testSerDeIngestionTime(org.apache.flink.streaming.connectors.kafka.shuffle.KafkaShuffleITCase)
>   Time elapsed: 5.786 s  <<< FAILURE!
> 2020-05-26T13:35:19.4023185Z java.lang.AssertionError: expected:<310> but 
> was:<0>
> 2020-05-26T13:35:19.4023498Z  at org.junit.Assert.fail(Assert.java:88)
> 2020-05-26T13:35:19.4023825Z  at 
> org.junit.Assert.failNotEquals(Assert.java:834)
> 2020-05-26T13:35:19.4024461Z  at 
> org.junit.Assert.assertEquals(Assert.java:645)
> 2020-05-26T13:35:19.4024900Z  at 
> org.junit.Assert.assertEquals(Assert.java:631)
> 2020-05-26T13:35:19.4028546Z  at 
> org.apache.flink.streaming.connectors.kafka.shuffle.KafkaShuffleITCase.testRecordSerDe(KafkaShuffleITCase.java:388)
> 2020-05-26T13:35:19.4029629Z  at 
> org.apache.flink.streaming.connectors.kafka.shuffle.KafkaShuffleITCase.testSerDeIngestionTime(KafkaShuffleITCase.java:156)
> 2020-05-26T13:35:19.4030253Z  at 
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2020-05-26T13:35:19.4030673Z  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 2020-05-26T13:35:19.4031332Z  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 2020-05-26T13:35:19.4031763Z  at 
> java.lang.reflect.Method.invoke(Method.java:498)
> 2020-05-26T13:35:19.4032155Z  at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> 2020-05-26T13:35:19.4032630Z  at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 2020-05-26T13:35:19.4033188Z  at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> 2020-05-26T13:35:19.4033638Z  at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 2020-05-26T13:35:19.4034103Z  at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 2020-05-26T13:35:19.4034593Z  at 
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
> 2020-05-26T13:35:19.4035118Z  at 
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
> 2020-05-26T13:35:19.4035570Z  at 
> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 2020-05-26T13:35:19.4035888Z  at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2020-07-13 Thread Jiangjie Qin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157121#comment-17157121
 ] 

Jiangjie Qin commented on FLINK-18071:
--

It is a known caveat and may involve some major change in JM to fix. Impact 
wise, it is not that critical. Therefore let's not block on this issue. I'll 
move it to 1.11.2.

> CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI
> 
>
> Key: FLINK-18071
> URL: https://issues.apache.org/jira/browse/FLINK-18071
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Tests
>Affects Versions: 1.11.0
>Reporter: Robert Metzger
>Assignee: Stephan Ewen
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0, 1.11.1
>
>
> CI: 
> https://dev.azure.com/georgeryan1322/Flink/_build/results?buildId=330=logs=6e58d712-c5cc-52fb-0895-6ff7bd56c46b=f30a8e80-b2cf-535c-9952-7f521a4ae374
> {code}
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.795 
> s <<< FAILURE! - in 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase
> [ERROR] 
> test(org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase)
>   Time elapsed: 4.647 s  <<< FAILURE!
> java.lang.AssertionError: List did not contain expected sequence of 200 
> elements, but was: [152, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 
> 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 
> 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 
> 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 
> 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 
> 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 
> 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 
> 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 
> 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 
> 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 
> 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 
> 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 
> 198, 199]
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.failList(CoordinatorEventsExactlyOnceITCase.java:160)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.checkListContainsSequence(CoordinatorEventsExactlyOnceITCase.java:148)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.test(CoordinatorEventsExactlyOnceITCase.java:143)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2020-07-13 Thread Jiangjie Qin (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiangjie Qin updated FLINK-18071:
-
Fix Version/s: (was: 1.11.1)
   1.11.2

> CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI
> 
>
> Key: FLINK-18071
> URL: https://issues.apache.org/jira/browse/FLINK-18071
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Tests
>Affects Versions: 1.11.0
>Reporter: Robert Metzger
>Assignee: Stephan Ewen
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0, 1.11.2
>
>
> CI: 
> https://dev.azure.com/georgeryan1322/Flink/_build/results?buildId=330=logs=6e58d712-c5cc-52fb-0895-6ff7bd56c46b=f30a8e80-b2cf-535c-9952-7f521a4ae374
> {code}
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.795 
> s <<< FAILURE! - in 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase
> [ERROR] 
> test(org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase)
>   Time elapsed: 4.647 s  <<< FAILURE!
> java.lang.AssertionError: List did not contain expected sequence of 200 
> elements, but was: [152, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 
> 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 
> 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 
> 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 
> 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 
> 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 
> 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 
> 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 
> 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 
> 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 
> 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 
> 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 
> 198, 199]
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.failList(CoordinatorEventsExactlyOnceITCase.java:160)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.checkListContainsSequence(CoordinatorEventsExactlyOnceITCase.java:148)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.test(CoordinatorEventsExactlyOnceITCase.java:143)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16947) ArtifactResolutionException: Could not transfer artifact. Entry [...] has not been leased from this pool

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157118#comment-17157118
 ] 

Dian Fu commented on FLINK-16947:
-

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=4464=logs=51fed01c-4eb0-5511-d479-ed5e8b9a7820=e5682198-9e22-5770-69f6-7551182edea8

> ArtifactResolutionException: Could not transfer artifact.  Entry [...] has 
> not been leased from this pool
> -
>
> Key: FLINK-16947
> URL: https://issues.apache.org/jira/browse/FLINK-16947
> Project: Flink
>  Issue Type: Bug
>  Components: Build System / Azure Pipelines
>Reporter: Piotr Nowojski
>Assignee: Robert Metzger
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/rmetzger/Flink/_build/results?buildId=6982=logs=c88eea3b-64a0-564d-0031-9fdcd7b8abee=1e2bbe5b-4657-50be-1f07-d84bfce5b1f5
> Build of flink-metrics-availability-test failed with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (end-to-end-tests) 
> on project flink-metrics-availability-test: Unable to generate classpath: 
> org.apache.maven.artifact.resolver.ArtifactResolutionException: Could not 
> transfer artifact org.apache.maven.surefire:surefire-grouper:jar:2.22.1 
> from/to google-maven-central 
> (https://maven-central-eu.storage-download.googleapis.com/maven2/): Entry 
> [id:13][route:{s}->https://maven-central-eu.storage-download.googleapis.com:443][state:null]
>  has not been leased from this pool
> [ERROR] org.apache.maven.surefire:surefire-grouper:jar:2.22.1
> [ERROR] 
> [ERROR] from the specified remote repositories:
> [ERROR] google-maven-central 
> (https://maven-central-eu.storage-download.googleapis.com/maven2/, 
> releases=true, snapshots=false),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots, 
> releases=false, snapshots=true)
> [ERROR] Path to dependency:
> [ERROR] 1) dummy:dummy:jar:1.0
> [ERROR] 2) org.apache.maven.surefire:surefire-junit47:jar:2.22.1
> [ERROR] 3) org.apache.maven.surefire:common-junit48:jar:2.22.1
> [ERROR] 4) org.apache.maven.surefire:surefire-grouper:jar:2.22.1
> [ERROR] -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :flink-metrics-availability-test
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16720) Maven gets stuck downloading artifacts on Azure

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157117#comment-17157117
 ] 

Dian Fu commented on FLINK-16720:
-

Another instance on master: 
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=4464=logs=af0c3dd6-ccea-53d1-d352-344c568905e4=f898bece-d8f3-5fab-10f5-eacbefdb2d1b

> Maven gets stuck downloading artifacts on Azure
> ---
>
> Key: FLINK-16720
> URL: https://issues.apache.org/jira/browse/FLINK-16720
> Project: Flink
>  Issue Type: Bug
>  Components: Build System / Azure Pipelines
>Affects Versions: 1.11.0
>Reporter: Robert Metzger
>Assignee: Robert Metzger
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.11.0
>
>
> Logs: 
> https://dev.azure.com/rmetzger/Flink/_build/results?buildId=6509=logs=fc5181b0-e452-5c8f-68de-1097947f6483=27d1d645-cbce-54e2-51c4-d8b45fe24607
> {code}
> 2020-03-23T08:43:28.4128014Z [INFO] 
> 
> 2020-03-23T08:43:28.4128557Z [INFO] Building flink-avro-confluent-registry 
> 1.11-SNAPSHOT
> 2020-03-23T08:43:28.4129129Z [INFO] 
> 
> 2020-03-23T08:48:47.6591333Z 
> ==
> 2020-03-23T08:48:47.6594540Z Maven produced no output for 300 seconds.
> 2020-03-23T08:48:47.6595164Z 
> ==
> 2020-03-23T08:48:47.6605370Z 
> ==
> 2020-03-23T08:48:47.6605803Z The following Java processes are running (JPS)
> 2020-03-23T08:48:47.6606173Z 
> ==
> 2020-03-23T08:48:47.7710037Z 920 Jps
> 2020-03-23T08:48:47.7778561Z 238 Launcher
> 2020-03-23T08:48:47.9270289Z 
> ==
> 2020-03-23T08:48:47.9270832Z Printing stack trace of Java process 967
> 2020-03-23T08:48:47.9271199Z 
> ==
> 2020-03-23T08:48:48.0165945Z 967: No such process
> 2020-03-23T08:48:48.0218260Z 
> ==
> 2020-03-23T08:48:48.0218736Z Printing stack trace of Java process 238
> 2020-03-23T08:48:48.0219075Z 
> ==
> 2020-03-23T08:48:48.3404066Z 2020-03-23 08:48:48
> 2020-03-23T08:48:48.3404828Z Full thread dump OpenJDK 64-Bit Server VM 
> (25.242-b08 mixed mode):
> 2020-03-23T08:48:48.3405064Z 
> 2020-03-23T08:48:48.3405445Z "Attach Listener" #370 daemon prio=9 os_prio=0 
> tid=0x7fe130001000 nid=0x452 waiting on condition [0x]
> 2020-03-23T08:48:48.3405868Zjava.lang.Thread.State: RUNNABLE
> 2020-03-23T08:48:48.3411202Z 
> 2020-03-23T08:48:48.3413171Z "resolver-5" #105 daemon prio=5 os_prio=0 
> tid=0x7fe1ec2ad800 nid=0x177 waiting on condition [0x7fe1872d9000]
> 2020-03-23T08:48:48.3414175Zjava.lang.Thread.State: WAITING (parking)
> 2020-03-23T08:48:48.3414560Z  at sun.misc.Unsafe.park(Native Method)
> 2020-03-23T08:48:48.3415451Z  - parking to wait for  <0x0003d5a9f828> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 2020-03-23T08:48:48.3416180Z  at 
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> 2020-03-23T08:48:48.3416825Z  at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> 2020-03-23T08:48:48.3417602Z  at 
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> 2020-03-23T08:48:48.3418250Z  at 
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
> 2020-03-23T08:48:48.3418930Z  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> 2020-03-23T08:48:48.3419900Z  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 2020-03-23T08:48:48.3420395Z  at java.lang.Thread.run(Thread.java:748)
> 2020-03-23T08:48:48.3420648Z 
> 2020-03-23T08:48:48.3421424Z "resolver-4" #104 daemon prio=5 os_prio=0 
> tid=0x7fe1ec2ad000 nid=0x176 waiting on condition [0x7fe1863dd000]
> 2020-03-23T08:48:48.3421914Zjava.lang.Thread.State: WAITING (parking)
> 2020-03-23T08:48:48.3422233Z  at sun.misc.Unsafe.park(Native Method)
> 2020-03-23T08:48:48.3422919Z  - parking to wait for  <0x0003d5a9f828> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 2020-03-23T08:48:48.3423447Z  at 
> 

[GitHub] [flink] flinkbot edited a comment on pull request #12866: [FLINK-17425][blink-planner] supportsFilterPushDown rule in DynamicSource.

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12866:
URL: https://github.com/apache/flink/pull/12866#issuecomment-656576219


   
   ## CI report:
   
   * 33ee4b79adb34267e83fec40ac38ac09fb567913 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4431)
 
   * 9e4e04643e4e9ad57089577e4c8642a5e18e271f UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12791: [FLINK-18362][FLINK-13838][yarn] Add yarn.ship-archives to support LocalResourceType.ARCHIVE

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12791:
URL: https://github.com/apache/flink/pull/12791#issuecomment-651128128


   
   ## CI report:
   
   * 7f21d2283952becdd014f38041f826072dd5bc75 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4466)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18335) NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted time outs

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157107#comment-17157107
 ] 

Dian Fu commented on FLINK-18335:
-

Another case on master: 
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=4464=logs=5c8e7682-d68f-54d1-16a2-a09310218a49=f508e270-48d6-5f1e-3138-42a17e0714f0

>  NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted time outs
> 
>
> Key: FLINK-18335
> URL: https://issues.apache.org/jira/browse/FLINK-18335
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing, Tests
>Affects Versions: 1.12.0
>Reporter: Piotr Nowojski
>Assignee: Yun Tang
>Priority: Critical
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=3582=logs=5c8e7682-d68f-54d1-16a2-a09310218a49=f508e270-48d6-5f1e-3138-42a17e0714f0
> {noformat}
> [ERROR] Errors: 
> [ERROR]   
> NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted:182->verifyAllOperatorsNotifyAborted:195->Object.wait:502->Object.wait:-2
>  » TestTimedOut
> {noformat}
> CC [~yunta]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18590) Support json array explode to multi messages

2020-07-13 Thread Benchao Li (Jira)
Benchao Li created FLINK-18590:
--

 Summary: Support json array explode to multi messages
 Key: FLINK-18590
 URL: https://issues.apache.org/jira/browse/FLINK-18590
 Project: Flink
  Issue Type: Improvement
  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
Reporter: Benchao Li


Currently our {{DeserializationSchema}} has supported to emit multi messages 
for one input record. There is some cases that the json data is not a json 
object in top level, for example:

{code:SQL}
CREATE TABLE source (
  col1 int,
  col2 varchar
) WITH (
  ...
  'format' = 'json'
)
{code}

With following data.

{code:json}
[
{"col1": 1, "col2": "hello"},
{"col1": 2, "col2": "flink"}
]
{code}

CC [~jark]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] wuchong commented on a change in pull request #12890: [FLINK-18583] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


wuchong commented on a change in pull request #12890:
URL: https://github.com/apache/flink/pull/12890#discussion_r454068637



##
File path: 
flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSinkITCase.java
##
@@ -226,25 +235,38 @@ public void testWritingDocumentsNoPrimaryKey() throws 
Exception {
.execute()
.actionGet()
.getHits();
-   if (hits.getTotalHits() < 1) {
+   if (hits.getTotalHits() < 2) {
Thread.sleep(200);
}
-   } while (hits.getTotalHits() < 1 && deadline.hasTimeLeft());
+   } while (hits.getTotalHits() < 2 && deadline.hasTimeLeft());
 
-   if (hits.getTotalHits() < 1) {
+   if (hits.getTotalHits() < 2) {
throw new AssertionError("Could not retrieve results 
from Elasticsearch.");
}
 
-   Map result = hits.getAt(0).getSourceAsMap();
-   Map expectedMap = new HashMap<>();
-   expectedMap.put("a", 1);
-   expectedMap.put("b", "00:00:12");
-   expectedMap.put("c", "ABCDE");
-   expectedMap.put("d", 12.12d);
-   expectedMap.put("e", 2);
-   expectedMap.put("f", "2003-10-20");
-   expectedMap.put("g", "2012-12-12 12:12:12");
-   assertThat(result, equalTo(expectedMap));
+   HashSet> resultSet = new HashSet<>();
+   resultSet.add(hits.getAt(0).getSourceAsMap());
+   resultSet.add(hits.getAt(1).getSourceAsMap());
+   Map expectedMap1 = new HashMap<>();
+   expectedMap1.put("a", 1);
+   expectedMap1.put("b", "00:00:12");
+   expectedMap1.put("c", "ABCDE");
+   expectedMap1.put("d", 12.12d);
+   expectedMap1.put("e", 2);
+   expectedMap1.put("f", "2003-10-20");
+   expectedMap1.put("g", "2012-12-12 12:12:12");
+   Map expectedMap2 = new HashMap<>();
+   expectedMap2.put("a", 2);
+   expectedMap2.put("b", "00:00:12");
+   expectedMap2.put("c", "FGHIJK");
+   expectedMap2.put("d", 13.13d);
+   expectedMap2.put("e", 4);
+   expectedMap2.put("f", "2003-10-20");
+   expectedMap2.put("g", "2013-12-12 13:13:13");
+   HashSet> expectedSet = new HashSet<>();
+   expectedSet.add(expectedMap1);
+   expectedSet.add(expectedMap2);
+   assertThat(resultSet, equalTo(expectedSet));

Review comment:
   Could you update the corresponding test in 
`Elasticsearch7DynamicSinkITCase`? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12890: [FLINK-18583] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


flinkbot commented on pull request #12890:
URL: https://github.com/apache/flink/pull/12890#issuecomment-657934674


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit b0c78063017af43d2d8bbc8c6655c391d5a841b5 (Tue Jul 14 
02:49:17 UTC 2020)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-18583:
---
Labels: pull-request-available  (was: )

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] KarmaGYZ opened a new pull request #12890: [FLINK-18583] Fix index id in ElasticSearch6 DynamicTableSink

2020-07-13 Thread GitBox


KarmaGYZ opened a new pull request #12890:
URL: https://github.com/apache/flink/pull/12890


   
   
   ## What is the purpose of the change
   
   Fix index id in ElasticSearch6 DynamicTableSink
   
   ## Brief change log
   
   *(for example:)*
 - *The TaskInfo is stored in the blob store on job creation time as a 
persistent artifact*
 - *Deployments RPC transmits only the blob storage reference*
 - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
 - *Added integration tests for end-to-end deployment with large payloads 
(100MB)*
 - *Extended integration test for recovery after master (JobManager) 
failure*
 - *Added test that validates that TaskInfo is transferred only once across 
recoveries*
 - *Manually verified the change by running a 4 node cluser with 2 
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one 
JobManager and two TaskManagers during the execution, verifying that recovery 
happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
 - The serializers: (yes / no / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't 
know)
 - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (FLINK-18585) Dynamic index can not work in new DynamicTableSink

2020-07-13 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu closed FLINK-18585.
---
Resolution: Fixed

Fixed in 
- master (1.12.0): 273830730c9524278576255c56c17c195f7c6bf9
- 1.11.1: 3cd2a6deb2c08e58f633669c18435d6647e84cc0

> Dynamic index can not work in new DynamicTableSink
> --
>
> Key: FLINK-18585
> URL: https://issues.apache.org/jira/browse/FLINK-18585
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.1
>Reporter: Leonard Xu
>Assignee: Leonard Xu
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.1
>
>
> because the IndexGenerator.open() was not inited properly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] wuchong merged pull request #12886: [FLINK-18585][elasticsearch] Dynamic index can not work in new DynamicTableSink

2020-07-13 Thread GitBox


wuchong merged pull request #12886:
URL: https://github.com/apache/flink/pull/12886


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong merged pull request #12885: [FLINK-18585][elasticsearch] Dynamic index can not work in new DynamicTableSink

2020-07-13 Thread GitBox


wuchong merged pull request #12885:
URL: https://github.com/apache/flink/pull/12885


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-18581) Cannot find GC cleaner with java version previous 8u202

2020-07-13 Thread Dian Fu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated FLINK-18581:

Priority: Critical  (was: Blocker)

> Cannot find GC cleaner with java version previous 8u202
> ---
>
> Key: FLINK-18581
> URL: https://issues.apache.org/jira/browse/FLINK-18581
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Affects Versions: 1.11.0
>Reporter: Xintong Song
>Priority: Critical
> Fix For: 1.12.0, 1.11.1
>
>
> {{JavaGcCleanerWrapper}} is looking for the package-private method 
> {{Reference.tryHandlePending}} using reflection. However, the method is first 
> introduced in the version 8u202. Therefore, if an older version JDK is used, 
> the method cannot be found and Flink will fail.
> See also this [ML 
> thread|http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Error-GC-Cleaner-Provider-Flink-1-11-0-td36565.html].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] twentyworld commented on a change in pull request #12237: [FLINK-17290] [chinese-translation, Documentation / Training] Transla…

2020-07-13 Thread GitBox


twentyworld commented on a change in pull request #12237:
URL: https://github.com/apache/flink/pull/12237#discussion_r454063219



##
File path: docs/learn-flink/streaming_analytics.zh.md
##
@@ -355,18 +306,15 @@ private static class MyWindowFunction extends 
ProcessWindowFunction<
 }
 {% endhighlight %}
 
-Notice that the `Iterable`
-will contain exactly one reading -- the pre-aggregated maximum computed by 
`MyReducingMax`.
+请注意 `Iterable`将只包含一个读数 -- `MyReducingMax` 计算出的预先汇总的最大值。
 
-### Late Events
+
+### 晚到的事件
 
-By default, when using event time windows, late events are dropped. There are 
two optional parts of
-the window API that give you more control over this.
+默认场景下,超过最大无序边界的事件会被删除,但是 Flink 给了我们两个选择去控制这些事件。
+
+您可以使用一种称为[旁路输出]({% link learn-flink/event_driven.zh.md %}#side-outputs) 
的机制来安排将要删除的事件收集到侧输出流中,这里是一个示例:

Review comment:
   我提了一个Jira ticket, 你有时间你看看





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157091#comment-17157091
 ] 

Dian Fu commented on FLINK-18583:
-

Thanks. I will change the priority to "Critical". Nevertheless, I think there 
are still some time to catch up with 1.11.1. :)

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Blocker
> Fix For: 1.12.0, 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Dian Fu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated FLINK-18583:

Priority: Critical  (was: Blocker)

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Critical
> Fix For: 1.12.0, 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18071) CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157087#comment-17157087
 ] 

Dian Fu commented on FLINK-18071:
-

Also cc [~jqin], could you help to confirm if this should be a blocker of 
1.11.1? [~sewen] [~jqin] [~gaoyunhaii]

> CoordinatorEventsExactlyOnceITCase.checkListContainsSequence fails on CI
> 
>
> Key: FLINK-18071
> URL: https://issues.apache.org/jira/browse/FLINK-18071
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination, Tests
>Affects Versions: 1.11.0
>Reporter: Robert Metzger
>Assignee: Stephan Ewen
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0, 1.11.1
>
>
> CI: 
> https://dev.azure.com/georgeryan1322/Flink/_build/results?buildId=330=logs=6e58d712-c5cc-52fb-0895-6ff7bd56c46b=f30a8e80-b2cf-535c-9952-7f521a4ae374
> {code}
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.795 
> s <<< FAILURE! - in 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase
> [ERROR] 
> test(org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase)
>   Time elapsed: 4.647 s  <<< FAILURE!
> java.lang.AssertionError: List did not contain expected sequence of 200 
> elements, but was: [152, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 
> 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 
> 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 
> 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 
> 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 
> 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 
> 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 
> 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 
> 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 
> 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 
> 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 
> 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 
> 198, 199]
>   at org.junit.Assert.fail(Assert.java:88)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.failList(CoordinatorEventsExactlyOnceITCase.java:160)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.checkListContainsSequence(CoordinatorEventsExactlyOnceITCase.java:148)
>   at 
> org.apache.flink.runtime.operators.coordination.CoordinatorEventsExactlyOnceITCase.test(CoordinatorEventsExactlyOnceITCase.java:143)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   
   ## CI report:
   
   * 34ee9488f1490383227b9408bed674240a1a Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447)
 
   * 05fede7e394cf0d1a7ba614d1411fa15141c3c65 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4470)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Leonard Xu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157085#comment-17157085
 ] 

Leonard Xu edited comment on FLINK-18583 at 7/14/20, 2:31 AM:
--

[~karmagyz] 
 Are you still working on this ? and I want to have a quick fix for 1.11.1 if 
you do not mind。


was (Author: leonard xu):
[~karmagyz] 
Are you still working on this, and I want to have a quick fix for 1.11.1

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Blocker
> Fix For: 1.12.0, 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Leonard Xu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157085#comment-17157085
 ] 

Leonard Xu commented on FLINK-18583:


[~karmagyz] 
Are you still working on this, and I want to have a quick fix for 1.11.1

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Blocker
> Fix For: 1.12.0, 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157084#comment-17157084
 ] 

Jark Wu commented on FLINK-18583:
-

I think this doesn't need to be a blocker, because it only affects es6. But 
AFAIK, this is promising to catch up with 1.11.1 if we will wait for 
FLINK-18573. 

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Blocker
> Fix For: 1.12.0, 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Leonard Xu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonard Xu updated FLINK-18583:
---
Fix Version/s: 1.12.0

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Blocker
> Fix For: 1.12.0, 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Leonard Xu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157082#comment-17157082
 ] 

Leonard Xu commented on FLINK-18583:


Hi, [~dian.fu] 
This issue will lead loss data when write data to Es6, I think it should be a 
blocker of 1.11.1

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Blocker
> Fix For: 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18583) The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink

2020-07-13 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157079#comment-17157079
 ] 

Dian Fu commented on FLINK-18583:
-

Hi [~jark] [~karmagyz], do you think this issue is a blocker of 1.11.1?

> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink
> 
>
> Key: FLINK-18583
> URL: https://issues.apache.org/jira/browse/FLINK-18583
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / ElasticSearch
>Affects Versions: 1.11.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Blocker
> Fix For: 1.11.1
>
>
> The _id field is incorrectly set to index in Elasticsearch6 DynamicTableSink.
> It is caused by [this 
> line|https://github.com/apache/flink/blob/0fbea46ac0271dd84fa8acd7f99f449a9a0d458c/flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java#L285]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FLINK-18440) ROW_NUMBER function: ROW/RANGE not allowed with RANK, DENSE_RANK or ROW_NUMBER functions

2020-07-13 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu closed FLINK-18440.
---
  Assignee: Danny Chen
Resolution: Fixed

Fixed in 
- master (1.12.0): 9723cb2090cff1c68e878282600fcd06c4f34125
- 1.11.1: 677021cc1ca872dd81fed8cd5e5aea834a3b5236

> ROW_NUMBER function: ROW/RANGE not allowed with RANK, DENSE_RANK or 
> ROW_NUMBER functions
> 
>
> Key: FLINK-18440
> URL: https://issues.apache.org/jira/browse/FLINK-18440
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Runtime
>Affects Versions: 1.11.0
>Reporter: LakeShen
>Assignee: Danny Chen
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.1
>
> Attachments: image-2020-06-28-18-55-43-692.png
>
>
> When I run flink sql ,the flink sql like this:
> create view test as select  name, eat ,sum(age) as cnt from test_source group 
> by  name,eat;
> create view results as select *, ROW_NUMBER() OVER (PARTITION BY name 
> ORDER BY cnt DESC) as row_num from test;
> create table sink (
> name varchar,
> eat varchar,
> cnt bigint
> )
> with(
> 'connector' = 'print'
> );
> insert into sink select name,eat , cnt from results where  row_num <= 3 ;
> The same sql code I could run success in flink 1.10, now I change the flink 
> version into flink 1.11, it throw the exception.
> Exception in thread "main" org.apache.flink.table.api.ValidationException: 
> SQL validation failed. From line 1, column 124 to line 1, column 127: 
> ROW/RANGE not allowed with RANK, DENSE_RANK or ROW_NUMBER functions
>   at 
> org.apache.flink.table.planner.calcite.FlinkPlannerImpl.org$apache$flink$table$planner$calcite$FlinkPlannerImpl$$validate(FlinkPlannerImpl.scala:146)
>   at 
> org.apache.flink.table.planner.calcite.FlinkPlannerImpl$ToRelContextImpl.expandView(FlinkPlannerImpl.scala:204)
>   at 
> org.apache.calcite.plan.ViewExpanders$1.expandView(ViewExpanders.java:52)
>   at 
> org.apache.flink.table.planner.catalog.SqlCatalogViewTable.convertToRel(SqlCatalogViewTable.java:58)
>   at 
> org.apache.flink.table.planner.plan.schema.ExpandingPreparingTable.expand(ExpandingPreparingTable.java:59)
>   at 
> org.apache.flink.table.planner.plan.schema.ExpandingPreparingTable.toRel(ExpandingPreparingTable.java:55)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.toRel(SqlToRelConverter.java:3492)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertIdentifier(SqlToRelConverter.java:2415)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2102)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2051)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:661)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:642)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:3345)
>   at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:568)
>   at 
> org.apache.flink.table.planner.calcite.FlinkPlannerImpl.org$apache$flink$table$planner$calcite$FlinkPlannerImpl$$rel(FlinkPlannerImpl.scala:164)
>   at 
> org.apache.flink.table.planner.calcite.FlinkPlannerImpl.rel(FlinkPlannerImpl.scala:151)
>   at 
> org.apache.flink.table.planner.operations.SqlToOperationConverter.toQueryOperation(SqlToOperationConverter.java:773)
>   at 
> org.apache.flink.table.planner.operations.SqlToOperationConverter.convertSqlQuery(SqlToOperationConverter.java:745)
>   at 
> org.apache.flink.table.planner.operations.SqlToOperationConverter.convert(SqlToOperationConverter.java:238)
>   at 
> org.apache.flink.table.planner.operations.SqlToOperationConverter.convertSqlInsert(SqlToOperationConverter.java:527)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #12880: [FLINK-18555][table sql/api] Make TableConfig options can be configur…

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12880:
URL: https://github.com/apache/flink/pull/12880#issuecomment-657437173


   
   ## CI report:
   
   * 34ee9488f1490383227b9408bed674240a1a Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4447)
 
   * 05fede7e394cf0d1a7ba614d1411fa15141c3c65 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12798: [FLINK-16087][docs-zh] Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12798:
URL: https://github.com/apache/flink/pull/12798#issuecomment-652303680


   
   ## CI report:
   
   * ad5d5dcac846080e2e40255505dd35896a6c7a94 UNKNOWN
   * 9e678a04b138c92d642ee96f4a6f05506644c5ac Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4456)
 
   * fcc745b41155021174e1d85539064421318c0cf3 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] leonardBang commented on pull request #12885: [FLINK-18585][elasticsearch] Dynamic index can not work in new DynamicTableSink

2020-07-13 Thread GitBox


leonardBang commented on pull request #12885:
URL: https://github.com/apache/flink/pull/12885#issuecomment-657921479


   pipeline passed in my local azure:
   https://dev.azure.com/xbjtdcq/xbjtdcq/_build/results?buildId=122=results



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong closed pull request #12868: [FLINK-18440][planner-blink] ROW_NUMBER function: ROW/RANGE not allow…

2020-07-13 Thread GitBox


wuchong closed pull request #12868:
URL: https://github.com/apache/flink/pull/12868


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (FLINK-18539) StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't use the user defined type information

2020-07-13 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156450#comment-17156450
 ] 

Jark Wu edited comment on FLINK-18539 at 7/14/20, 1:58 AM:
---

- master (1.12.0): 68d83ef7bd43fbd20f51551d7216364b41ace793
- 1.11.1: 38495e7378f6df5eead9a29448e3944f2b3ecbea
- 1.10.2: 2a3b642b1efb957f3d4f20502c40398786ab1469


was (Author: jark):
- master (1.12.0): 68d83ef7bd43fbd20f51551d7216364b41ace793
- 1.11.1: 38495e7378f6df5eead9a29448e3944f2b3ecbea
- 1.10.2: TODO

> StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't 
> use the user defined type information
> ---
>
> Key: FLINK-18539
> URL: https://issues.apache.org/jira/browse/FLINK-18539
> Project: Flink
>  Issue Type: Task
>  Components: API / DataStream
>Affects Versions: 1.11.0
>Reporter: Jark Wu
>Assignee: Jark Wu
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.10.2, 1.12.0, 1.11.1
>
>
> {code:java}
> class MySource implements SourceFunction, ResultTypeQueryable {
>  TypeInformation getProducedType() {
>return TypeExtractor.createTypeInfo(SourceFunction.class, this.getClass(), 
> 0, null, null);
>  } 
> }
> DataStream ds = tEnv.addSource(new MySource(), Types.ROW(Types.STRING))
> {code}
> The returned {{TypeInformation}} of {{MySource}} is {{GenericTypeInfo}}, not 
> the user given {{RowTypeInfo}}.
> It seems that {{StreamExecutionEnvironment#getTypeInfo}} doesn't use the user 
> given {{typeInfo}} in the highest priority. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FLINK-18539) StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't use the user defined type information

2020-07-13 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu closed FLINK-18539.
---
Resolution: Fixed

> StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't 
> use the user defined type information
> ---
>
> Key: FLINK-18539
> URL: https://issues.apache.org/jira/browse/FLINK-18539
> Project: Flink
>  Issue Type: Task
>  Components: API / DataStream
>Affects Versions: 1.11.0
>Reporter: Jark Wu
>Assignee: Jark Wu
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.10.2, 1.12.0, 1.11.1
>
>
> {code:java}
> class MySource implements SourceFunction, ResultTypeQueryable {
>  TypeInformation getProducedType() {
>return TypeExtractor.createTypeInfo(SourceFunction.class, this.getClass(), 
> 0, null, null);
>  } 
> }
> DataStream ds = tEnv.addSource(new MySource(), Types.ROW(Types.STRING))
> {code}
> The returned {{TypeInformation}} of {{MySource}} is {{GenericTypeInfo}}, not 
> the user given {{RowTypeInfo}}.
> It seems that {{StreamExecutionEnvironment#getTypeInfo}} doesn't use the user 
> given {{typeInfo}} in the highest priority. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] wuchong merged pull request #12877: [BP-1.11][FLINK-18539][datastream] Fix StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't use the user defined type info

2020-07-13 Thread GitBox


wuchong merged pull request #12877:
URL: https://github.com/apache/flink/pull/12877


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong commented on pull request #12877: [BP-1.11][FLINK-18539][datastream] Fix StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't use the user defined typ

2020-07-13 Thread GitBox


wuchong commented on pull request #12877:
URL: https://github.com/apache/flink/pull/12877#issuecomment-657920639


   Build is passed, merging...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong commented on pull request #12878: [BP-1.10][FLINK-18539][datastream] Fix StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't use the user defined typ

2020-07-13 Thread GitBox


wuchong commented on pull request #12878:
URL: https://github.com/apache/flink/pull/12878#issuecomment-657920812


   CI is passed, Merging...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (FLINK-18539) StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't use the user defined type information

2020-07-13 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156450#comment-17156450
 ] 

Jark Wu edited comment on FLINK-18539 at 7/14/20, 1:57 AM:
---

- master (1.12.0): 68d83ef7bd43fbd20f51551d7216364b41ace793
- 1.11.1: 38495e7378f6df5eead9a29448e3944f2b3ecbea
- 1.10.2: TODO


was (Author: jark):
- master (1.12.0): 68d83ef7bd43fbd20f51551d7216364b41ace793
- 1.11.1: TODO
- 1.10.2: TODO

> StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't 
> use the user defined type information
> ---
>
> Key: FLINK-18539
> URL: https://issues.apache.org/jira/browse/FLINK-18539
> Project: Flink
>  Issue Type: Task
>  Components: API / DataStream
>Affects Versions: 1.11.0
>Reporter: Jark Wu
>Assignee: Jark Wu
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.10.2, 1.12.0, 1.11.1
>
>
> {code:java}
> class MySource implements SourceFunction, ResultTypeQueryable {
>  TypeInformation getProducedType() {
>return TypeExtractor.createTypeInfo(SourceFunction.class, this.getClass(), 
> 0, null, null);
>  } 
> }
> DataStream ds = tEnv.addSource(new MySource(), Types.ROW(Types.STRING))
> {code}
> The returned {{TypeInformation}} of {{MySource}} is {{GenericTypeInfo}}, not 
> the user given {{RowTypeInfo}}.
> It seems that {{StreamExecutionEnvironment#getTypeInfo}} doesn't use the user 
> given {{typeInfo}} in the highest priority. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] wuchong merged pull request #12878: [BP-1.10][FLINK-18539][datastream] Fix StreamExecutionEnvironment#addSource(SourceFunction, TypeInformation) doesn't use the user defined type info

2020-07-13 Thread GitBox


wuchong merged pull request #12878:
URL: https://github.com/apache/flink/pull/12878


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12791: [FLINK-18362][FLINK-13838][yarn] Add yarn.ship-archives to support LocalResourceType.ARCHIVE

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12791:
URL: https://github.com/apache/flink/pull/12791#issuecomment-651128128


   
   ## CI report:
   
   * d23a042db1f84e1345e4df01d5b12fac7b91fc61 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4395)
 
   * 7f21d2283952becdd014f38041f826072dd5bc75 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4466)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12791: [FLINK-18362][FLINK-13838][yarn] Add yarn.ship-archives to support LocalResourceType.ARCHIVE

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12791:
URL: https://github.com/apache/flink/pull/12791#issuecomment-651128128


   
   ## CI report:
   
   * d23a042db1f84e1345e4df01d5b12fac7b91fc61 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4395)
 
   * 7f21d2283952becdd014f38041f826072dd5bc75 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12846: [FLINK-18448][pubsub] Update Google Cloud PubSub dependencies

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12846:
URL: https://github.com/apache/flink/pull/12846#issuecomment-654978676


   
   ## CI report:
   
   * fbd3e1559f4a80424cbade77ed3034977943bf0b Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4463)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12883: [FLINK-18573][metrics] Ensure metric reporters could be loaded via SPI

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12883:
URL: https://github.com/apache/flink/pull/12883#issuecomment-657495689


   
   ## CI report:
   
   * e1e8fc29efbc2d55a12e315b0005dde609ffe3cf Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4462)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12888: [FLINK-18588] hive ddl create table support 'if not exists'

2020-07-13 Thread GitBox


flinkbot edited a comment on pull request #12888:
URL: https://github.com/apache/flink/pull/12888#issuecomment-657641584


   
   ## CI report:
   
   * 9bd52062639bd1eacf94f88caa310cd60817599e Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4458)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   3   4   >