[jira] [Commented] (FLINK-19481) Add support for a flink native GCS FileSystem
[ https://issues.apache.org/jira/browse/FLINK-19481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1720#comment-1720 ] Yun Tang commented on FLINK-19481: -- [~baugarten], from my point of view, we could still checkpoint on Google cloud storage via [hadoop file system|https://ci.apache.org/projects/flink/flink-docs-release-1.11/ops/filesystems/#hadoop-file-system-hdfs-and-its-other-implementations] without this improvement, is that right? > Add support for a flink native GCS FileSystem > - > > Key: FLINK-19481 > URL: https://issues.apache.org/jira/browse/FLINK-19481 > Project: Flink > Issue Type: Improvement > Components: Connectors / FileSystem, FileSystems >Affects Versions: 1.12.0 >Reporter: Ben Augarten >Priority: Major > Fix For: 1.12.0 > > > Currently, GCS is supported but only by using the hadoop connector[1] > > The objective of this improvement is to add support for checkpointing to > Google Cloud Storage with the Flink File System, > > This would allow the `gs://` scheme to be used for savepointing and > checkpointing. Long term, it would be nice if we could use the GCS FileSystem > as a source and sink in flink jobs as well. > > Long term, I hope that implementing a flink native GCS FileSystem will > simplify usage of GCS because the hadoop FileSystem ends up bringing in many > unshaded dependencies. > > [1] > [https://github.com/GoogleCloudDataproc/hadoop-connectors|https://github.com/GoogleCloudDataproc/hadoop-connectors)] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] wangxlong opened a new pull request #13537: [FLINK-19478][docs-zh][python] Translate page "intro_to_table_api" into Chinese
wangxlong opened a new pull request #13537: URL: https://github.com/apache/flink/pull/13537 ## What is the purpose of the change Translate page "intro_to_table_api" into Chinese ## Brief change log Translate page "intro_to_table_api" into Chinese ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19478) Translate page 'intro_to_table_api' into Chinese
[ https://issues.apache.org/jira/browse/FLINK-19478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19478: --- Labels: pull-request-available (was: ) > Translate page 'intro_to_table_api' into Chinese > > > Key: FLINK-19478 > URL: https://issues.apache.org/jira/browse/FLINK-19478 > Project: Flink > Issue Type: Improvement > Components: chinese-translation, Documentation >Affects Versions: 1.11.0 >Reporter: hailong wang >Assignee: hailong wang >Priority: Minor > Labels: pull-request-available > Fix For: 1.12.0 > > > The page url is > [intro_to_table|https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/python/table-api-users-guide/intro_to_table_api.html] > The url is located in > /dev/python/table-api-users-guide/intro_to_table_api.zh.md -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #13537: [FLINK-19478][docs-zh][python] Translate page "intro_to_table_api" into Chinese
flinkbot commented on pull request #13537: URL: https://github.com/apache/flink/pull/13537#issuecomment-703092256 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit fbd56ff6167834a20d8ffcfd801dc2e6f3464657 (Sat Oct 03 11:59:17 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13537: [FLINK-19478][docs-zh][python] Translate page "intro_to_table_api" into Chinese
flinkbot commented on pull request #13537: URL: https://github.com/apache/flink/pull/13537#issuecomment-703094638 ## CI report: * fbd56ff6167834a20d8ffcfd801dc2e6f3464657 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13537: [FLINK-19478][docs-zh][python] Translate page "intro_to_table_api" into Chinese
flinkbot edited a comment on pull request #13537: URL: https://github.com/apache/flink/pull/13537#issuecomment-703094638 ## CI report: * fbd56ff6167834a20d8ffcfd801dc2e6f3464657 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7181) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13537: [FLINK-19478][docs-zh][python] Translate page "intro_to_table_api" into Chinese
flinkbot edited a comment on pull request #13537: URL: https://github.com/apache/flink/pull/13537#issuecomment-703094638 ## CI report: * fbd56ff6167834a20d8ffcfd801dc2e6f3464657 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7181) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19455) Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build fail by maven-enforcer-plugin
[
https://issues.apache.org/jira/browse/FLINK-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hailong wang updated FLINK-19455:
-
Issue Type: Bug (was: Improvement)
> Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build
> fail by maven-enforcer-plugin
>
>
> Key: FLINK-19455
> URL: https://issues.apache.org/jira/browse/FLINK-19455
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.11.0
>Reporter: hailong wang
>Priority: Major
> Fix For: 1.12.0, 1.11.2
>
>
> I run command 'mvn clean package' in flink-sql-connector-hive-2.3.6, and it
> failed,
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.apache.kafka:kafka_2.10:jar:0.10.2.0
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
> For root pom has a rule as follow:
> {code:java}
> bannedDependencies>
>
> *:*_2.12
> *:*_2.10
>
>
> {code}
> As for kafka_2.10 dependency is useless, So we can exclude it as follow:
> {code:java}
>
>org.apache.hive
>hive-exec
>2.3.6
>
>
> log4j
> log4j
>
>
> org.slf4j
> slf4j-log4j12
>
>
> org.pentaho
> pentaho-aggdesigner-algorithm
>
>
> org.apache.kafka
> kafka_2.10
>
>
> {code}
> It also failed in flink-docs and flink-disk module:
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.yaml:snakeyaml:jar:1.24
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-19455) Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build fail by maven-enforcer-plugin
[
https://issues.apache.org/jira/browse/FLINK-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hailong wang updated FLINK-19455:
-
Component/s: (was: Connectors / Hive)
Build System
> Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build
> fail by maven-enforcer-plugin
>
>
> Key: FLINK-19455
> URL: https://issues.apache.org/jira/browse/FLINK-19455
> Project: Flink
> Issue Type: Bug
> Components: Build System
>Affects Versions: 1.12.0
>Reporter: hailong wang
>Priority: Major
> Fix For: 1.12.0
>
>
> I run command 'mvn clean package' in flink-sql-connector-hive-2.3.6, and it
> failed,
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.apache.kafka:kafka_2.10:jar:0.10.2.0
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
> For root pom has a rule as follow:
> {code:java}
> bannedDependencies>
>
> *:*_2.12
> *:*_2.10
>
>
> {code}
> As for kafka_2.10 dependency is useless, So we can exclude it as follow:
> {code:java}
>
>org.apache.hive
>hive-exec
>2.3.6
>
>
> log4j
> log4j
>
>
> org.slf4j
> slf4j-log4j12
>
>
> org.pentaho
> pentaho-aggdesigner-algorithm
>
>
> org.apache.kafka
> kafka_2.10
>
>
> {code}
> It also failed in flink-docs and flink-disk module:
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.yaml:snakeyaml:jar:1.24
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-19455) Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build fail by maven-enforcer-plugin
[
https://issues.apache.org/jira/browse/FLINK-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hailong wang updated FLINK-19455:
-
Affects Version/s: (was: 1.11.0)
1.12.0
> Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build
> fail by maven-enforcer-plugin
>
>
> Key: FLINK-19455
> URL: https://issues.apache.org/jira/browse/FLINK-19455
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.12.0
>Reporter: hailong wang
>Priority: Major
> Fix For: 1.12.0, 1.11.2
>
>
> I run command 'mvn clean package' in flink-sql-connector-hive-2.3.6, and it
> failed,
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.apache.kafka:kafka_2.10:jar:0.10.2.0
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
> For root pom has a rule as follow:
> {code:java}
> bannedDependencies>
>
> *:*_2.12
> *:*_2.10
>
>
> {code}
> As for kafka_2.10 dependency is useless, So we can exclude it as follow:
> {code:java}
>
>org.apache.hive
>hive-exec
>2.3.6
>
>
> log4j
> log4j
>
>
> org.slf4j
> slf4j-log4j12
>
>
> org.pentaho
> pentaho-aggdesigner-algorithm
>
>
> org.apache.kafka
> kafka_2.10
>
>
> {code}
> It also failed in flink-docs and flink-disk module:
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.yaml:snakeyaml:jar:1.24
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-19455) Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build fail by maven-enforcer-plugin
[
https://issues.apache.org/jira/browse/FLINK-19455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hailong wang updated FLINK-19455:
-
Fix Version/s: (was: 1.11.2)
> Module 'flink-sql-connector-hive-2.3.6', 'flink-docs' and 'flnk-dist'build
> fail by maven-enforcer-plugin
>
>
> Key: FLINK-19455
> URL: https://issues.apache.org/jira/browse/FLINK-19455
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Hive
>Affects Versions: 1.12.0
>Reporter: hailong wang
>Priority: Major
> Fix For: 1.12.0
>
>
> I run command 'mvn clean package' in flink-sql-connector-hive-2.3.6, and it
> failed,
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.apache.kafka:kafka_2.10:jar:0.10.2.0
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
> For root pom has a rule as follow:
> {code:java}
> bannedDependencies>
>
> *:*_2.12
> *:*_2.10
>
>
> {code}
> As for kafka_2.10 dependency is useless, So we can exclude it as follow:
> {code:java}
>
>org.apache.hive
>hive-exec
>2.3.6
>
>
> log4j
> log4j
>
>
> org.slf4j
> slf4j-log4j12
>
>
> org.pentaho
> pentaho-aggdesigner-algorithm
>
>
> org.apache.kafka
> kafka_2.10
>
>
> {code}
> It also failed in flink-docs and flink-disk module:
> {code:java}
> Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with
> message:
> Found Banned Dependency: org.yaml:snakeyaml:jar:1.24
> Use 'mvn dependency:tree' to locate the source of the banned dependencies.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] zhuxiaoshang commented on pull request #13519: [FLINK-18850][Table SQL / Runtime]Add late records dropped metric for row time over windows
zhuxiaoshang commented on pull request #13519: URL: https://github.com/apache/flink/pull/13519#issuecomment-703128352 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13519: [FLINK-18850][Table SQL / Runtime]Add late records dropped metric for row time over windows
flinkbot edited a comment on pull request #13519: URL: https://github.com/apache/flink/pull/13519#issuecomment-701236311 ## CI report: * Unknown: [CANCELED](TBD) * c3ce856573d7f6b1240e97113eab4e35c705e638 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-19494) Adjust "StreamExecutionEnvironment.generateSequence()" to new API Sources
[
https://issues.apache.org/jira/browse/FLINK-19494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206787#comment-17206787
]
Stephan Ewen commented on FLINK-19494:
--
I got an offline comment from [~aljoscha] that we should probably not do that,
because the new source API is not checkpoint-compatible with the old one.
So I am leaning towards:
- deprecate the {{generateSequence()}} method.
- Add a new {{fromSequence()}} method that uses the NumberSequenceSource.
> Adjust "StreamExecutionEnvironment.generateSequence()" to new API Sources
> -
>
> Key: FLINK-19494
> URL: https://issues.apache.org/jira/browse/FLINK-19494
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Reporter: Stephan Ewen
>Priority: Major
> Fix For: 1.12.0
>
>
> The utility method {{StreamExecutionEnvironment.generateSequence(()}} should
> instantiate the new {{NumberSequenceSource}} rather than the existing
> {{StatefulSequenceSource}}.
> We should also deprecate the {{StatefulSequenceSource}} as part of this
> change, because
> - it is based on the legacy source API
> - it is not scalable, because it materializes the sequence
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (FLINK-19498) Port LocatableInputSplitAssigner to new File Source API
Stephan Ewen created FLINK-19498:
Summary: Port LocatableInputSplitAssigner to new File Source API
Key: FLINK-19498
URL: https://issues.apache.org/jira/browse/FLINK-19498
Project: Flink
Issue Type: Task
Components: Connectors / FileSystem
Reporter: Stephan Ewen
Assignee: Stephan Ewen
Fix For: 1.12.0
The new File Source API needs a locality aware input split assigner.
To preserve the experience, I suggest to port the existing
{{LocatableInputSplitAssigner}} from the {{InputFormat}} API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13519: [FLINK-18850][Table SQL / Runtime]Add late records dropped metric for row time over windows
flinkbot edited a comment on pull request #13519: URL: https://github.com/apache/flink/pull/13519#issuecomment-701236311 ## CI report: * Unknown: [CANCELED](TBD) * c3ce856573d7f6b1240e97113eab4e35c705e638 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7182) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FLINK-19499) Expose Metric Groups to Split Assigners
Stephan Ewen created FLINK-19499: Summary: Expose Metric Groups to Split Assigners Key: FLINK-19499 URL: https://issues.apache.org/jira/browse/FLINK-19499 Project: Flink Issue Type: Improvement Components: Connectors / FileSystem Reporter: Stephan Ewen Assignee: Stephan Ewen Fix For: 1.12.0 Split Assigners should have access to metric groups, so they can report metrics on assignment, like pending splits, local-, and remote assignments. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] StephanEwen opened a new pull request #13538: [FLINK-19498][Connector Files] Port LocatableInputSplitAssigner to new File Source API
StephanEwen opened a new pull request #13538: URL: https://github.com/apache/flink/pull/13538 ## What is the purpose of the change This adds the `LocalityAwareSplitAssigner` for the new File Source API. The new assigner works the exact same way as the `LocatableInputSplitAssigner` from the *InputFormat API*. This new split assigner is also the default now for the `FileSource`. The code of the `LocalityAwareSplitAssigner` is largely a copy of the code from the `LocatableInputSplitAssigner`, adjusted for the different interface methods and cleaned up (code style / checkstyle). ## Verifying this change This copies and adjusts the tests from the `LocatableInputSplitAssigner`, except for the concurrency-related tests. Those are dropped, because the new FileSplitAssigners are not concurrent. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes, but only unreleased classes** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19498) Port LocatableInputSplitAssigner to new File Source API
[
https://issues.apache.org/jira/browse/FLINK-19498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-19498:
---
Labels: pull-request-available (was: )
> Port LocatableInputSplitAssigner to new File Source API
> ---
>
> Key: FLINK-19498
> URL: https://issues.apache.org/jira/browse/FLINK-19498
> Project: Flink
> Issue Type: Task
> Components: Connectors / FileSystem
>Reporter: Stephan Ewen
>Assignee: Stephan Ewen
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> The new File Source API needs a locality aware input split assigner.
> To preserve the experience, I suggest to port the existing
> {{LocatableInputSplitAssigner}} from the {{InputFormat}} API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #13538: [FLINK-19498][Connector Files] Port LocatableInputSplitAssigner to new File Source API
flinkbot commented on pull request #13538: URL: https://github.com/apache/flink/pull/13538#issuecomment-703141087 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 5c40b1cdcf7ab70f89587d986198b5bae2c9ffe0 (Sat Oct 03 17:58:28 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13538: [FLINK-19498][Connector Files] Port LocatableInputSplitAssigner to new File Source API
flinkbot commented on pull request #13538: URL: https://github.com/apache/flink/pull/13538#issuecomment-703142651 ## CI report: * 9f410a16f7ca507643207cda41edc08d93cbce19 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13538: [FLINK-19498][Connector Files] Port LocatableInputSplitAssigner to new File Source API
flinkbot edited a comment on pull request #13538: URL: https://github.com/apache/flink/pull/13538#issuecomment-703142651 ## CI report: * 9f410a16f7ca507643207cda41edc08d93cbce19 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7183) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13519: [FLINK-18850][Table SQL / Runtime]Add late records dropped metric for row time over windows
flinkbot edited a comment on pull request #13519: URL: https://github.com/apache/flink/pull/13519#issuecomment-701236311 ## CI report: * c3ce856573d7f6b1240e97113eab4e35c705e638 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7182) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13538: [FLINK-19498][Connector Files] Port LocatableInputSplitAssigner to new File Source API
flinkbot edited a comment on pull request #13538: URL: https://github.com/apache/flink/pull/13538#issuecomment-703142651 ## CI report: * 9f410a16f7ca507643207cda41edc08d93cbce19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7183) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-19494) Adjust "StreamExecutionEnvironment.generateSequence()" to new API Sources
[
https://issues.apache.org/jira/browse/FLINK-19494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206996#comment-17206996
]
Nicholas Jiang commented on FLINK-19494:
[~sewen], I agree with your point that add a new fromSequence() method that
uses the NumberSequenceSource, which method is against the new Source API. This
behaviour is similar with the fromSource interface again the new Source API,
right? And IMO, generateSequence should not be deprecated temporarily, because
this could be deprecated together with addSource method, which based on the
legacy source API.
> Adjust "StreamExecutionEnvironment.generateSequence()" to new API Sources
> -
>
> Key: FLINK-19494
> URL: https://issues.apache.org/jira/browse/FLINK-19494
> Project: Flink
> Issue Type: Improvement
> Components: API / DataStream
>Reporter: Stephan Ewen
>Priority: Major
> Fix For: 1.12.0
>
>
> The utility method {{StreamExecutionEnvironment.generateSequence(()}} should
> instantiate the new {{NumberSequenceSource}} rather than the existing
> {{StatefulSequenceSource}}.
> We should also deprecate the {{StatefulSequenceSource}} as part of this
> change, because
> - it is based on the legacy source API
> - it is not scalable, because it materializes the sequence
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13296: [FLINK-18774][format][debezium] Support debezium-avro format
flinkbot edited a comment on pull request #13296: URL: https://github.com/apache/flink/pull/13296#issuecomment-684611193 ## CI report: * c266341c63cc4cdc28a6585a82294710fd8ebbc5 UNKNOWN * 8003ac0791570594085b8672d4d47c33fc2bbaf2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6434) * c6301b9c4f43e851a0d47972bd52880b69b720c6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
