[GitHub] [flink] flinkbot edited a comment on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
flinkbot edited a comment on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710232578 ## CI report: * 54f00eb50174658ded96de3473d452d07caaca99 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7783) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13657: [FLINK-19669][coordination] PipelinedRegionSchedulingStrategy#init ResultPartitionType blocking check use isBlocking method
flinkbot edited a comment on pull request #13657: URL: https://github.com/apache/flink/pull/13657#issuecomment-709726515 ## CI report: * 7461070175526095fd5741748f413ba4f78246d9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7781) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7731) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13622: [FLINK-19469][hbase] Exclude org.glassfish:javax.el transitive dependency from hbase-2.2 connector as it is unreliable
flinkbot edited a comment on pull request #13622: URL: https://github.com/apache/flink/pull/13622#issuecomment-708066181 ## CI report: * 428b6634795fd9eae35911cf468b96b2542b7e75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7780) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7778) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13643: [Hotfix][CheckStyle][Min] Fix DummyInputFormat class lacks Javadoc
flinkbot edited a comment on pull request #13643: URL: https://github.com/apache/flink/pull/13643#issuecomment-708870329 ## CI report: * bf793887fbcc0b4f83cc76eb0565833476da0348 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7644) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7665) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7692) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7705) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7711) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7779) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7723) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19686) Cast question for data | time |timestamp type
[
https://issues.apache.org/jira/browse/FLINK-19686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hehuiyuan updated FLINK-19686:
--
Summary: Cast question for data | time |timestamp type (was: Cast
question for data | time )
> Cast question for data | time |timestamp type
> --
>
> Key: FLINK-19686
> URL: https://issues.apache.org/jira/browse/FLINK-19686
> Project: Flink
> Issue Type: Wish
> Components: Table SQL / API
>Reporter: hehuiyuan
>Priority: Major
>
> ERROR:
> {code:java}
> java.lang.ClassCastException: java.time.LocalDate cannot be cast to
> java.sql.Datejava.lang.ClassCastException: java.time.LocalDate cannot be cast
> to java.sql.Date at
> org.apache.flink.api.common.typeutils.base.SqlDateSerializer.copy(SqlDateSerializer.java:30)
> at
> org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:93)
> at
> org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:44)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:635)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:707)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:660)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
> at
> org.apache.flink.streaming.runtime.operators.TimestampsAndPeriodicWatermarksOperator.processElement(TimestampsAndPeriodicWatermarksOperator.java:67)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
> at SinkConversion$20.processElement(Unknown Source) at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
> at StreamExecCalc$18.processElement(Unknown Source)
> //
> java.lang.ClassCastException: java.time.LocalDateTime cannot be cast to
> java.sql.Timestampjava.lang.ClassCastException: java.time.LocalDateTime
> cannot be cast to java.sql.Timestamp at
> org.apache.flink.api.common.typeutils.base.SqlTimestampSerializer.copy(SqlTimestampSerializer.java:29)
> at
> org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:93)
> at
> org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:44)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:635)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:707)
> at
> org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:660)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
> at
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
> at
> org.apache.flink.streaming.runtime.operators.TimestampsAndPeriodicWatermarksOperator.pr
[jira] [Updated] (FLINK-19686) Cast question for data | time
[
https://issues.apache.org/jira/browse/FLINK-19686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hehuiyuan updated FLINK-19686:
--
Description:
ERROR:
{code:java}
java.lang.ClassCastException: java.time.LocalDate cannot be cast to
java.sql.Datejava.lang.ClassCastException: java.time.LocalDate cannot be cast
to java.sql.Date at
org.apache.flink.api.common.typeutils.base.SqlDateSerializer.copy(SqlDateSerializer.java:30)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:93)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:44)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:635)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:707)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:660)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at
org.apache.flink.streaming.runtime.operators.TimestampsAndPeriodicWatermarksOperator.processElement(TimestampsAndPeriodicWatermarksOperator.java:67)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at SinkConversion$20.processElement(Unknown Source) at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at StreamExecCalc$18.processElement(Unknown Source)
//
java.lang.ClassCastException: java.time.LocalDateTime cannot be cast to
java.sql.Timestampjava.lang.ClassCastException: java.time.LocalDateTime cannot
be cast to java.sql.Timestamp at
org.apache.flink.api.common.typeutils.base.SqlTimestampSerializer.copy(SqlTimestampSerializer.java:29)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:93)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:44)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:635)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:707)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:660)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at
org.apache.flink.streaming.runtime.operators.TimestampsAndPeriodicWatermarksOperator.processElement(TimestampsAndPeriodicWatermarksOperator.java:67)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractS
[GitHub] [flink] flinkbot edited a comment on pull request #13670: [hotfix][docs]Fix typos in queries.zh.md
flinkbot edited a comment on pull request #13670: URL: https://github.com/apache/flink/pull/13670#issuecomment-710731909 ## CI report: * eaf3ff6217b7306a08a893ffd154047488cc57bb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7782) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19686) Cast question for data | time
[
https://issues.apache.org/jira/browse/FLINK-19686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hehuiyuan updated FLINK-19686:
--
Description:
ERROR:
{code:java}
java.lang.ClassCastException: java.time.LocalDate cannot be cast to
java.sql.Datejava.lang.ClassCastException: java.time.LocalDate cannot be cast
to java.sql.Date at
org.apache.flink.api.common.typeutils.base.SqlDateSerializer.copy(SqlDateSerializer.java:30)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:93)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:44)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:635)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:707)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:660)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at
org.apache.flink.streaming.runtime.operators.TimestampsAndPeriodicWatermarksOperator.processElement(TimestampsAndPeriodicWatermarksOperator.java:67)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at SinkConversion$20.processElement(Unknown Source) at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at StreamExecCalc$18.processElement(Unknown Source)
//--
java.lang.ClassCastException: java.time.LocalDateTime cannot be cast to
java.sql.Timestampjava.lang.ClassCastException: java.time.LocalDateTime cannot
be cast to java.sql.Timestamp at
org.apache.flink.api.common.typeutils.base.SqlTimestampSerializer.copy(SqlTimestampSerializer.java:29)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:93)
at
org.apache.flink.api.java.typeutils.runtime.RowSerializer.copy(RowSerializer.java:44)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:635)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:707)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$BroadcastingOutputCollector.collect(OperatorChain.java:660)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:705)
at
org.apache.flink.streaming.runtime.operators.TimestampsAndPeriodicWatermarksOperator.processElement(TimestampsAndPeriodicWatermarksOperator.java:67)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:637)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:612)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:592)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:727)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator$Count
[jira] [Created] (FLINK-19686) Cast question for data | time
hehuiyuan created FLINK-19686: - Summary: Cast question for data | time Key: FLINK-19686 URL: https://issues.apache.org/jira/browse/FLINK-19686 Project: Flink Issue Type: Wish Components: Table SQL / API Reporter: hehuiyuan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
flinkbot edited a comment on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710232578 ## CI report: * 9af35f28ff24e32827dd43dce1009045d0ae671f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7772) * 54f00eb50174658ded96de3473d452d07caaca99 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7783) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13670: [hotfix][docs]Fix typos in queries.zh.md
flinkbot edited a comment on pull request #13670: URL: https://github.com/apache/flink/pull/13670#issuecomment-710731909 ## CI report: * eaf3ff6217b7306a08a893ffd154047488cc57bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7782) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
flinkbot edited a comment on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710232578 ## CI report: * 9af35f28ff24e32827dd43dce1009045d0ae671f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7772) * 54f00eb50174658ded96de3473d452d07caaca99 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] caozhen1937 commented on a change in pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
caozhen1937 commented on a change in pull request #13669:
URL: https://github.com/apache/flink/pull/13669#discussion_r506785305
##
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java
##
@@ -147,7 +147,7 @@ public void eval(Object... keys) {
}
}
- for (int retry = 1; retry <= maxRetryTimes; retry++) {
+ for (int retry = 0; retry <= maxRetryTimes; retry++) {
Review comment:
Thanks for your review.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13670: [hotfix][docs]Fix typos in queries.zh.md
flinkbot commented on pull request #13670: URL: https://github.com/apache/flink/pull/13670#issuecomment-710731909 ## CI report: * eaf3ff6217b7306a08a893ffd154047488cc57bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13657: [FLINK-19669][coordination] PipelinedRegionSchedulingStrategy#init ResultPartitionType blocking check use isBlocking method
flinkbot edited a comment on pull request #13657: URL: https://github.com/apache/flink/pull/13657#issuecomment-709726515 ## CI report: * 7461070175526095fd5741748f413ba4f78246d9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7781) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7731) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13670: [hotfix][docs]Fix typos in queries.zh.md
flinkbot commented on pull request #13670: URL: https://github.com/apache/flink/pull/13670#issuecomment-710729019 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit eaf3ff6217b7306a08a893ffd154047488cc57bb (Sat Oct 17 02:22:27 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13657: [FLINK-19669][coordination] PipelinedRegionSchedulingStrategy#init ResultPartitionType blocking check use isBlocking method
flinkbot edited a comment on pull request #13657: URL: https://github.com/apache/flink/pull/13657#issuecomment-709726515 ## CI report: * 7461070175526095fd5741748f413ba4f78246d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7731) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7781) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] sunxiaoguang opened a new pull request #13670: [hotfix][docs]Fix typos in queries.zh.md
sunxiaoguang opened a new pull request #13670: URL: https://github.com/apache/flink/pull/13670 Fix some typos in queries.zh.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] Sxnan commented on pull request #13657: [FLINK-19669][coordination] PipelinedRegionSchedulingStrategy#init ResultPartitionType blocking check use isBlocking method
Sxnan commented on pull request #13657: URL: https://github.com/apache/flink/pull/13657#issuecomment-710727525 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] wangxlong commented on a change in pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
wangxlong commented on a change in pull request #13669:
URL: https://github.com/apache/flink/pull/13669#discussion_r506781235
##
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java
##
@@ -147,7 +147,7 @@ public void eval(Object... keys) {
}
}
- for (int retry = 1; retry <= maxRetryTimes; retry++) {
+ for (int retry = 0; retry <= maxRetryTimes; retry++) {
Review comment:
`sink.max-retries` configuration in `JdbcBatchingOutputFormat` is
similar with this, could you also have a change?
BTW, Commit message should contain issue id etc, following
[https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html](https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13622: [FLINK-19469][hbase] Exclude org.glassfish:javax.el transitive dependency from hbase-2.2 connector as it is unreliable
flinkbot edited a comment on pull request #13622: URL: https://github.com/apache/flink/pull/13622#issuecomment-708066181 ## CI report: * 428b6634795fd9eae35911cf468b96b2542b7e75 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7780) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7778) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] wangxlong commented on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
wangxlong commented on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710724354 Thank you for your contribution, I just left a min comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13622: [FLINK-19469][hbase] Exclude org.glassfish:javax.el transitive dependency from hbase-2.2 connector as it is unreliable
flinkbot edited a comment on pull request #13622: URL: https://github.com/apache/flink/pull/13622#issuecomment-708066181 ## CI report: * 428b6634795fd9eae35911cf468b96b2542b7e75 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7778) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7780) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #13622: [FLINK-19469][hbase] Exclude org.glassfish:javax.el transitive dependency from hbase-2.2 connector as it is unreliable
dianfu commented on pull request #13622: URL: https://github.com/apache/flink/pull/13622#issuecomment-710721955 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13643: [Hotfix][CheckStyle][Min] Fix DummyInputFormat class lacks Javadoc
flinkbot edited a comment on pull request #13643: URL: https://github.com/apache/flink/pull/13643#issuecomment-708870329 ## CI report: * bf793887fbcc0b4f83cc76eb0565833476da0348 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7644) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7665) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7692) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7705) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7711) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7779) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7723) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13643: [Hotfix][CheckStyle][Min] Fix DummyInputFormat class lacks Javadoc
flinkbot edited a comment on pull request #13643: URL: https://github.com/apache/flink/pull/13643#issuecomment-708870329 ## CI report: * bf793887fbcc0b4f83cc76eb0565833476da0348 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7644) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7665) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7692) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7705) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7723) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7711) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7779) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] wangxlong commented on pull request #13643: [Hotfix][CheckStyle][Min] Fix DummyInputFormat class lacks Javadoc
wangxlong commented on pull request #13643: URL: https://github.com/apache/flink/pull/13643#issuecomment-710713566 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
flinkbot edited a comment on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710232578 ## CI report: * 9af35f28ff24e32827dd43dce1009045d0ae671f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7772) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13622: [FLINK-19469][hbase] Exclude org.glassfish:javax.el transitive dependency from hbase-2.2 connector as it is unreliable
flinkbot edited a comment on pull request #13622: URL: https://github.com/apache/flink/pull/13622#issuecomment-708066181 ## CI report: * 116ea43b00eac6494d40cf8349a147ebf958439b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7602) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7629) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7638) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7687) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7651) * 428b6634795fd9eae35911cf468b96b2542b7e75 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7778) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13622: [FLINK-19469][hbase] Exclude org.glassfish:javax.el transitive dependency from hbase-2.2 connector as it is unreliable
flinkbot edited a comment on pull request #13622: URL: https://github.com/apache/flink/pull/13622#issuecomment-708066181 ## CI report: * 116ea43b00eac6494d40cf8349a147ebf958439b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7602) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7629) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7638) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7687) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7651) * 428b6634795fd9eae35911cf468b96b2542b7e75 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13555: [FLINK-17613][e2e][k8s] Test against multiple k8s versions
flinkbot edited a comment on pull request #13555: URL: https://github.com/apache/flink/pull/13555#issuecomment-704987370 ## CI report: * dbb8f2d60f4abd5db43d72d34352fdb2083af370 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7646) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7675) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7769) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7726) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] miklosgergely commented on pull request #13622: [FLINK-19469][hbase] Exclude org.glassfish:javax.el transitive dependency from hbase-2.2 connector as it is unreliable
miklosgergely commented on pull request #13622: URL: https://github.com/apache/flink/pull/13622#issuecomment-710565892 @dianfu I've rebased it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13667: [FLINK-19679] Deduplicate code between CheckpointBarrierUnaligner and CheckpointBarrierAligner
flinkbot edited a comment on pull request #13667: URL: https://github.com/apache/flink/pull/13667#issuecomment-710095324 ## CI report: * 5ab532006ccbfb5632b4ad60053203a5e5dea3a5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7770) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
flinkbot edited a comment on pull request #13668: URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238 ## CI report: * 0602dadb007befbb94f13c6a57ccbe29481f2a5b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] renatomariscal commented on pull request #13208: [FLINK-18676] [FileSystem] Bump s3 aws version
renatomariscal commented on pull request #13208: URL: https://github.com/apache/flink/pull/13208#issuecomment-710505069 Hi! I am affected by this issue, any chance of getting this moving @batas? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13667: [FLINK-19679] Deduplicate code between CheckpointBarrierUnaligner and CheckpointBarrierAligner
flinkbot edited a comment on pull request #13667: URL: https://github.com/apache/flink/pull/13667#issuecomment-710095324 ## CI report: * cbca395729de539e4ee0d4f76056b09b09f3c935 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7767) * 5ab532006ccbfb5632b4ad60053203a5e5dea3a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7770) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-19583) Expose the execution.runtime-mode to the users
[
https://issues.apache.org/jira/browse/FLINK-19583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas closed FLINK-19583.
--
Fix Version/s: 1.12.0
Resolution: Implemented
Merged on master with b3fd487986f3807dfc9f718c0121a0539348042d
> Expose the execution.runtime-mode to the users
> --
>
> Key: FLINK-19583
> URL: https://issues.apache.org/jira/browse/FLINK-19583
> Project: Flink
> Issue Type: Sub-task
> Components: API / DataStream
>Affects Versions: 1.12.0
>Reporter: Kostas Kloudas
>Assignee: Kostas Kloudas
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.0
>
>
> With
> [FLIP-134|https://cwiki.apache.org/confluence/display/FLINK/FLIP-134%3A+Batch+execution+for+the+DataStream+API]
> we aim to expose the config option {{execution.runtime-mode}} to the user,
> so that he/she can execute a pipeline in BATCH or STREAMING mode, as
> described in the FLIP.
> In addition, we will allow the users to set it to AUTOMATIC, in which case
> one of the BATCH or STREAMING mode is going to be picked based on the sources
> of the pipeline: BATCH if all sources are bounded, STREAMING otherwise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] kl0u closed pull request #13656: [FLINK-19583] Expose the execution.runtime-mode to users
kl0u closed pull request #13656: URL: https://github.com/apache/flink/pull/13656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13602: [FLINK-19346][coordination] Generate and put ClusterPartitionDescriptor of ClusterPartition in JobResult when job finishes
flinkbot edited a comment on pull request #13602: URL: https://github.com/apache/flink/pull/13602#issuecomment-70743 ## CI report: * 5bd17fad8f85ce110218ef2ec98912b138db03e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7763) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13492: [FLINK-19181][python] Make python processes respect the calculated managed memory fraction
flinkbot edited a comment on pull request #13492: URL: https://github.com/apache/flink/pull/13492#issuecomment-699626263 ## CI report: * af73558800083e341dcd9c89819cd00b0572696b UNKNOWN * 59af0e9ec80df5072e44576882f8659db631e424 UNKNOWN * ae3f85a1f5601225f20bd08cef1b176f692e9e84 UNKNOWN * ea5aa5217447669b700f1c645a41db57e1e01350 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7761) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7737) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-18915) FIXED_PATH(dummy Hadoop Path) with WriterImpl may cause ORC writer OOM
[
https://issues.apache.org/jira/browse/FLINK-18915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas closed FLINK-18915.
--
Resolution: Fixed
Merged on master with 3a9a93053903dfefc3fb651e47800afc00d13a9e
and on release-1.11 with 393b13cfd103896e0cb60c6c7230101bef9a956f
> FIXED_PATH(dummy Hadoop Path) with WriterImpl may cause ORC writer OOM
> --
>
> Key: FLINK-18915
> URL: https://issues.apache.org/jira/browse/FLINK-18915
> Project: Flink
> Issue Type: Bug
> Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Affects Versions: 1.11.0, 1.11.1
>Reporter: wei
>Assignee: Yun Gao
>Priority: Critical
> Labels: pull-request-available
> Fix For: 1.12.0, 1.11.3
>
>
> # OrcBulkWriterFactory
> {code:java}
> @Override
> public BulkWriter create(FSDataOutputStream out) throws IOException {
>OrcFile.WriterOptions opts = getWriterOptions();
>opts.physicalWriter(new PhysicalWriterImpl(out, opts));
>return new OrcBulkWriter<>(vectorizer, new WriterImpl(null, FIXED_PATH,
> opts));
> }{code}
>
> # MemoryManagerImpl
> {code:java}
> //
> public void addWriter(Path path, long requestedAllocation,
> Callback callback) throws IOException {
> checkOwner();
> WriterInfo oldVal = writerList.get(path);
> // this should always be null, but we handle the case where the memory
> // manager wasn't told that a writer wasn't still in use and the task
> // starts writing to the same path.
> if (oldVal == null) {
> oldVal = new WriterInfo(requestedAllocation, callback);
> writerList.put(path, oldVal);
> totalAllocation += requestedAllocation;
> } else {
> // handle a new writer that is writing to the same path
> totalAllocation += requestedAllocation - oldVal.allocation;
> oldVal.allocation = requestedAllocation;
> oldVal.callback = callback;
> }
> updateScale(true);
> }
> {code}
> SinkTask may have multi BulkWriter create, FIXED_PATH will cause overlay the
> last writer callback；Last writer's WriterImpl#checkMemory will never called;
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] kl0u closed pull request #13598: [FLINK-18915][filesystem][orc] Fix the incorrect memory management behavior by using uuid fake path for orc writer
kl0u closed pull request #13598: URL: https://github.com/apache/flink/pull/13598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-15156) Warn user if System.exit() is called in user code
[ https://issues.apache.org/jira/browse/FLINK-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215561#comment-17215561 ] Hwanju Kim commented on FLINK-15156: Robert, thanks for the comments: # Performance penalties: Good question. Although we haven't microbenchmarked its impact, we haven't heard performance regression. Actually, all of the security check is not on data path more in control path (thread control, socket accept/connect, exit, etc), I did not think it would matter. More importantly, if there is no added check, it's just a single function call with null check/return (and JDK also by default does one getSecurityManager call and null check as well). So considering that additional path is very small in control path, I think overhead should be negligible. Nonetheless, for platform provider, such security manager for sandboxing is inevitable going forward not only for exit, which is just the first usecase, even if it may cause a bit of penalties. That's ene reason to have configuration that defaults to false for general users (not platform providers). # More check points: Right. Thanks for the input. I also tried (ambitiously) to find all the places in the first place, but it was not very practical (also code addition may make patch larger) at that point so decided to add the frequently implemented path. Indeed, main() is the one where exit() is (most likely erroneously) put blindly following the same practice for general Java application. I haven't had data for the case where users put exit() in UDF though (but it may be possible if some badly written library can call it behind the scene, but I haven't seen that yet). We can further discuss about what more points are interesting. # In the case I have seen, mostly their exit is with log already (e.g., this argument is not provided, exiting) and we wanted to put the guard not terminating JVM by further messaging "you are not allowed to terminate JVM". I thought throwing exception with message is providing user with warning/debugging message without terminating JVM. Do you think some users still want their exit to be performed intentionally? I assumed that UDF or main terminating JVM is always unintended in Flink. But if exit may still be a wanted behavior in some cases, I think it makes sense to provide that option as well. > Warn user if System.exit() is called in user code > - > > Key: FLINK-15156 > URL: https://issues.apache.org/jira/browse/FLINK-15156 > Project: Flink > Issue Type: Improvement > Components: Runtime / Coordination >Reporter: Robert Metzger >Priority: Minor > Labels: starter > > It would make debugging Flink errors easier if we would intercept and log > calls to System.exit() through the SecurityManager. > A user recently had an error where the JobManager was shutting down because > of a System.exit() in the user code: > https://lists.apache.org/thread.html/b28dabcf3068d489f38399c456c80d48569fcdf74b15f8bb95d532d0%40%3Cuser.flink.apache.org%3E > If I remember correctly, we had such issues before. > I put this ticket into the "Runtime / Coordination" component, as it is > mostly about improving the usability / debuggability in that area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
flinkbot edited a comment on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710232578 ## CI report: * 9af35f28ff24e32827dd43dce1009045d0ae671f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7772) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13656: [FLINK-19583] Expose the execution.runtime-mode to users
flinkbot edited a comment on pull request #13656: URL: https://github.com/apache/flink/pull/13656#issuecomment-709561220 ## CI report: * a9c04a955b538391702fd5407f5261cdb3911ee7 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7765) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar
flinkbot edited a comment on pull request #13612: URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105 ## CI report: * a1a881b34bea5ede3b622e0d53c9728d232cb48c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-19635) HBaseConnectorITCase.testTableSourceSinkWithDDL is unstable with a result mismatch
[
https://issues.apache.org/jira/browse/FLINK-19635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215518#comment-17215518
]
Robert Metzger commented on FLINK-19635:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=7743&view=logs&j=d44f43ce-542c-597d-bf94-b0718c71e5e8&t=03dca39c-73e8-5aaf-601d-328ae5c35f20
> HBaseConnectorITCase.testTableSourceSinkWithDDL is unstable with a result
> mismatch
> --
>
> Key: FLINK-19635
> URL: https://issues.apache.org/jira/browse/FLINK-19635
> Project: Flink
> Issue Type: Bug
> Components: Connectors / HBase
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Priority: Major
> Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=7562&view=logs&j=d44f43ce-542c-597d-bf94-b0718c71e5e8&t=03dca39c-73e8-5aaf-601d-328ae5c35f20
> {code}
> 2020-10-14T04:35:36.9268975Z testTableSourceSinkWithDDL[planner =
> BLINK_PLANNER, legacy =
> false](org.apache.flink.connector.hbase2.HBaseConnectorITCase) Time elapsed:
> 3.131 sec <<< FAILURE!
> 2020-10-14T04:35:36.9276246Z java.lang.AssertionError:
> expected:<[1,10,Hello-1,100,1.01,false,Welt-1,2019-08-18T19:00,2019-08-18,19:00,12345678.0001,
>
> 2,20,Hello-2,200,2.02,true,Welt-2,2019-08-18T19:01,2019-08-18,19:01,12345678.0002,
>
> 3,30,Hello-3,300,3.03,false,Welt-3,2019-08-18T19:02,2019-08-18,19:02,12345678.0003,
>
> 4,40,null,400,4.04,true,Welt-4,2019-08-18T19:03,2019-08-18,19:03,12345678.0004,
>
> 5,50,Hello-5,500,5.05,false,Welt-5,2019-08-19T19:10,2019-08-19,19:10,12345678.0005,
>
> 6,60,Hello-6,600,6.06,true,Welt-6,2019-08-19T19:20,2019-08-19,19:20,12345678.0006,
>
> 7,70,Hello-7,700,7.07,false,Welt-7,2019-08-19T19:30,2019-08-19,19:30,12345678.0007,
>
> 8,80,null,800,8.08,true,Welt-8,2019-08-19T19:40,2019-08-19,19:40,12345678.0008]>
> but
> was:<[1,10,Hello-1,100,1.01,false,Welt-1,2019-08-18T19:00,2019-08-18,19:00,12345678.0001,
>
> 2,20,Hello-2,200,2.02,true,Welt-2,2019-08-18T19:01,2019-08-18,19:01,12345678.0002,
>
> 3,30,Hello-3,300,3.03,false,Welt-3,2019-08-18T19:02,2019-08-18,19:02,12345678.0003]>
> 2020-10-14T04:35:36.9281340Z at org.junit.Assert.fail(Assert.java:88)
> 2020-10-14T04:35:36.9282023Z at
> org.junit.Assert.failNotEquals(Assert.java:834)
> 2020-10-14T04:35:36.9328385Z at
> org.junit.Assert.assertEquals(Assert.java:118)
> 2020-10-14T04:35:36.9338939Z at
> org.junit.Assert.assertEquals(Assert.java:144)
> 2020-10-14T04:35:36.9339880Z at
> org.apache.flink.connector.hbase2.HBaseConnectorITCase.testTableSourceSinkWithDDL(HBaseConnectorITCase.java:449)
> 2020-10-14T04:35:36.9341003Z at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
flinkbot commented on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710232578 ## CI report: * 9af35f28ff24e32827dd43dce1009045d0ae671f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13625: [FLINK-19623][table-planner-blink] Introduce ExecEdge to describe information on input edges for ExecNode
flinkbot edited a comment on pull request #13625: URL: https://github.com/apache/flink/pull/13625#issuecomment-708152298 ## CI report: * 4c31824917199ca34801d2bde871c5d1f95d0cc2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7738) * f26a40dc87e7f977e84f24c5b509b60f2b083d5c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] HuangXingBo commented on pull request #13659: [FLINK-19654][python][e2e] Change Dependency of scipy Module to pytest
HuangXingBo commented on pull request #13659: URL: https://github.com/apache/flink/pull/13659#issuecomment-710215687 The time of pyflink e2e test can be optimized from 28min 15s to 26min 40s This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19685) When use HBase-Connector lookupFunction, 8 hours less to query `DATE`,`TIME`,`TIMESTAMP` data
[
https://issues.apache.org/jira/browse/FLINK-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
CaoZhen updated FLINK-19685:
Description:
from the code:
HBaseSerde#createFieldDecoder
{code:java}
case DATE:
case INTERVAL_YEAR_MONTH:
return Bytes::toInt;
case TIME_WITHOUT_TIME_ZONE:
..
return Bytes::toInt;
case TIMESTAMP_WITHOUT_TIME_ZONE:
case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
..
return createTimestampDecoder();
private static FieldDecoder createTimestampDecoder() {
return value -> {
// TODO: support higher precision
long milliseconds = Bytes.toLong(value);
return TimestampData.fromEpochMillis(milliseconds);
};
}
{code}
I think we should learn from JDBC's approach to dealing with time types.
{code:java}
case DATE:
return val -> (int) (((Date) val).toLocalDate().toEpochDay());
case TIME_WITHOUT_TIME_ZONE:
return val -> (int) (((Time) val).toLocalTime().toNanoOfDay() / 1_000_000L);
case TIMESTAMP_WITH_TIME_ZONE:
case TIMESTAMP_WITHOUT_TIME_ZONE:
return val -> TimestampData.fromTimestamp((Timestamp) val);
{code}
was:
from the code:
HBaseSerde#createFieldDecoder
{code:java}
case DATE:
case INTERVAL_YEAR_MONTH:
return Bytes::toInt;
case TIME_WITHOUT_TIME_ZONE:
..
return Bytes::toInt;
case TIMESTAMP_WITHOUT_TIME_ZONE:
case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
..
return createTimestampDecoder();
private static FieldDecoder createTimestampDecoder() {
return value -> {
// TODO: support higher precision
long milliseconds = Bytes.toLong(value);
return TimestampData.fromEpochMillis(milliseconds);
};
}
{code}
> When use HBase-Connector lookupFunction, 8 hours less to query
> `DATE`,`TIME`,`TIMESTAMP` data
> --
>
> Key: FLINK-19685
> URL: https://issues.apache.org/jira/browse/FLINK-19685
> Project: Flink
> Issue Type: Bug
> Components: Connectors / HBase
>Reporter: CaoZhen
>Priority: Major
>
> from the code:
> HBaseSerde#createFieldDecoder
> {code:java}
> case DATE:
> case INTERVAL_YEAR_MONTH:
>return Bytes::toInt;
> case TIME_WITHOUT_TIME_ZONE:
>..
>return Bytes::toInt;
> case TIMESTAMP_WITHOUT_TIME_ZONE:
> case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
>..
>return createTimestampDecoder();
> private static FieldDecoder createTimestampDecoder() {
>return value -> {
> // TODO: support higher precision
> long milliseconds = Bytes.toLong(value);
> return TimestampData.fromEpochMillis(milliseconds);
>};
> }
> {code}
>
> I think we should learn from JDBC's approach to dealing with time types.
> {code:java}
> case DATE:
> return val -> (int) (((Date) val).toLocalDate().toEpochDay());
> case TIME_WITHOUT_TIME_ZONE:
> return val -> (int) (((Time) val).toLocalTime().toNanoOfDay() /
> 1_000_000L);
> case TIMESTAMP_WITH_TIME_ZONE:
> case TIMESTAMP_WITHOUT_TIME_ZONE:
> return val -> TimestampData.fromTimestamp((Timestamp) val);
> {code}
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
flinkbot commented on pull request #13669: URL: https://github.com/apache/flink/pull/13669#issuecomment-710205228 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 9af35f28ff24e32827dd43dce1009045d0ae671f (Fri Oct 16 16:45:37 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19684).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19684) The Jdbc-connector's 'lookup.max-retries' option implementation is different from the meaning
[
https://issues.apache.org/jira/browse/FLINK-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-19684:
---
Labels: pull-request-available (was: )
> The Jdbc-connector's 'lookup.max-retries' option implementation is different
> from the meaning
> --
>
> Key: FLINK-19684
> URL: https://issues.apache.org/jira/browse/FLINK-19684
> Project: Flink
> Issue Type: Bug
> Components: Connectors / JDBC
>Reporter: CaoZhen
>Priority: Minor
> Labels: pull-request-available
>
>
> The code of 'lookup.max-retries' option :
> {code:java}
> for (int retry = 1; retry <= maxRetryTimes; retry++) {
> statement.clearParameters();
> .
> }
> {code}
> From the code, If this option is set to 0, the JDBC query will not be
> executed.
>
> From documents, the max retry times if lookup database failed. [1]
> When set to 0, there is a query, but no retry.
>
> So,the code of 'lookup.max-retries' option should be:
> {code:java}
> for (int retry = 0; retry <= maxRetryTimes; retry++) {
> statement.clearParameters();
> .
> }
> {code}
>
>
> [1]
> https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/connectors/jdbc.html#lookup-max-retries
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] caozhen1937 opened a new pull request #13669: [FLINK-19684][Connector][jdbc] Fix the Jdbc-connector's 'lookup.max-retries' option implementation
caozhen1937 opened a new pull request #13669: URL: https://github.com/apache/flink/pull/13669 ## What is the purpose of the change The Jdbc-connector's 'lookup.max-retries' option implementation is different from the meaning. ## Brief change log - *JdbcRowDataLookupFunction#eval* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency):no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
flinkbot edited a comment on pull request #13668: URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238 ## CI report: * 0602dadb007befbb94f13c6a57ccbe29481f2a5b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7771) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13667: [FLINK-19679] Deduplicate code between CheckpointBarrierUnaligner and CheckpointBarrierAligner
flinkbot edited a comment on pull request #13667: URL: https://github.com/apache/flink/pull/13667#issuecomment-710095324 ## CI report: * cbca395729de539e4ee0d4f76056b09b09f3c935 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7767) * 5ab532006ccbfb5632b4ad60053203a5e5dea3a5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7770) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13547: [FLINK-14406][runtime] Exposes managed memory usage through the REST API
flinkbot edited a comment on pull request #13547: URL: https://github.com/apache/flink/pull/13547#issuecomment-704265372 ## CI report: * 268d260399e598943726839a254f004a61f5ba66 UNKNOWN * 750fd026fc1dc7191619234901a686c6ebdf4500 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7762) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-19678) tableEnv.getConfig.setNullCheck(false) seems to break group by
[
https://issues.apache.org/jira/browse/FLINK-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215482#comment-17215482
]
Ion Alberdi commented on FLINK-19678:
-
Awesome, thanks for the update!
> tableEnv.getConfig.setNullCheck(false) seems to break group by
> --
>
> Key: FLINK-19678
> URL: https://issues.apache.org/jira/browse/FLINK-19678
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Runtime
>Affects Versions: 1.11.2
>Reporter: Ion Alberdi
>Priority: Major
>
> The program written at
> [https://gist.github.com/yetanotherion/d007fa113d97411226eaea4f20cd4c2d|https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fyetanotherion%2Fd007fa113d97411226eaea4f20cd4c2d&data=04%7C01%7Cj.alberdi%40criteo.com%7C08c520289ec4433b7b7a08d871c60180%7C2a35d8fd574d48e3927c8c398e225a01%7C1%7C1%7C637384442549853109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQGyO%2FqLQ%2FCN%2BVuQPYbmPVfKDbLxVKmWJh%2Fu9L2qTBw%3D&reserved=0]
> creates unexpected stack traces when the line
> *// triggerBug…*
> is uncommented (some lines of the stack trace are written in the gist).
> (It correctly outputs
> {code:java}
> +-+
> | c |
> +-+
> | 1 |
> | 2 |
> +-+
> {code}
> else)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-19684) The Jdbc-connector's 'lookup.max-retries' option implementation is different from the meaning
[
https://issues.apache.org/jira/browse/FLINK-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215473#comment-17215473
]
Jark Wu commented on FLINK-19684:
-
I think you are right.
> The Jdbc-connector's 'lookup.max-retries' option implementation is different
> from the meaning
> --
>
> Key: FLINK-19684
> URL: https://issues.apache.org/jira/browse/FLINK-19684
> Project: Flink
> Issue Type: Bug
> Components: Connectors / JDBC
>Reporter: CaoZhen
>Priority: Minor
>
>
> The code of 'lookup.max-retries' option :
> {code:java}
> for (int retry = 1; retry <= maxRetryTimes; retry++) {
> statement.clearParameters();
> .
> }
> {code}
> From the code, If this option is set to 0, the JDBC query will not be
> executed.
>
> From documents, the max retry times if lookup database failed. [1]
> When set to 0, there is a query, but no retry.
>
> So,the code of 'lookup.max-retries' option should be:
> {code:java}
> for (int retry = 0; retry <= maxRetryTimes; retry++) {
> statement.clearParameters();
> .
> }
> {code}
>
>
> [1]
> https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/connectors/jdbc.html#lookup-max-retries
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-19678) tableEnv.getConfig.setNullCheck(false) seems to break group by
[
https://issues.apache.org/jira/browse/FLINK-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215474#comment-17215474
]
Jark Wu commented on FLINK-19678:
-
[~yetanotherion], I think it might be in the next two releases.
> tableEnv.getConfig.setNullCheck(false) seems to break group by
> --
>
> Key: FLINK-19678
> URL: https://issues.apache.org/jira/browse/FLINK-19678
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Runtime
>Affects Versions: 1.11.2
>Reporter: Ion Alberdi
>Priority: Major
>
> The program written at
> [https://gist.github.com/yetanotherion/d007fa113d97411226eaea4f20cd4c2d|https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fyetanotherion%2Fd007fa113d97411226eaea4f20cd4c2d&data=04%7C01%7Cj.alberdi%40criteo.com%7C08c520289ec4433b7b7a08d871c60180%7C2a35d8fd574d48e3927c8c398e225a01%7C1%7C1%7C637384442549853109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQGyO%2FqLQ%2FCN%2BVuQPYbmPVfKDbLxVKmWJh%2Fu9L2qTBw%3D&reserved=0]
> creates unexpected stack traces when the line
> *// triggerBug…*
> is uncommented (some lines of the stack trace are written in the gist).
> (It correctly outputs
> {code:java}
> +-+
> | c |
> +-+
> | 1 |
> | 2 |
> +-+
> {code}
> else)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
flinkbot commented on pull request #13668: URL: https://github.com/apache/flink/pull/13668#issuecomment-710144238 ## CI report: * 0602dadb007befbb94f13c6a57ccbe29481f2a5b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13640: [FLINK-19617] Added new metric for monitoring the JVM's Metaspace memory pool usage.
flinkbot edited a comment on pull request #13640: URL: https://github.com/apache/flink/pull/13640#issuecomment-708477385 ## CI report: * e957d897105a0bff335d8db266b9bc518942eae1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7753) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-19076) Import rule to deal Temporal Join condition
[
https://issues.apache.org/jira/browse/FLINK-19076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu closed FLINK-19076.
--
Resolution: Resolved
master: cd65bbb7cc2ec2099d70375cc009215cf57afe13
> Import rule to deal Temporal Join condition
> ---
>
> Key: FLINK-19076
> URL: https://issues.apache.org/jira/browse/FLINK-19076
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
>Reporter: Leonard Xu
>Assignee: Leonard Xu
>Priority: Major
>
> Temporal join is a correlate, the right of correlate is a *Snapshot*, the
> *period* of *snapshot* comes from left table's time attribute column.
> the time attribute column may be pruned if the downstream `RelNode` did not
> reference it any more, so I need to keep the necessary condition(e.g., left
> time attribute, right primary key) for temporal join node in join condition.
> Given an example:
> {code:java}
> SELECT o.order_id, o.currency, o.amount, r.rate,r.rowtime
> FROM orders_proctime AS o JOIN
> versioned_currency
> FOR SYSTEM_TIME AS OF o.rowtime as r
> ON o.currency = r.currency{code}
> The select clause did not use `o.rowtime` and thus the column `o.rowtime`
> will be removed later, but we need the `o.rowtime` in temporal join node, so
> I keep the `o.rowtime` in temporal join condition just like[1].
> [1]
> [https://github.com/apache/flink/blob/c601cfd662c2839f8ebc81b80879ecce55a8cbaf/flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/TemporalJoinUtil.scala]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (FLINK-19073) Improve streamExecTemporalJoinRule
[ https://issues.apache.org/jira/browse/FLINK-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu closed FLINK-19073. -- Resolution: Resolved > Improve streamExecTemporalJoinRule > -- > > Key: FLINK-19073 > URL: https://issues.apache.org/jira/browse/FLINK-19073 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > > Improve streamExecTemporalJoinRule that matches a temporal join node and > converts it to [[StreamExecTemporalJoin]], > the temporal join node is a [[FlinkLogicalJoin]] whose left input is a > [[FlinkLogicalRel]] and right input is a [[FlinkLogicalSnapshot]]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19073) Improve streamExecTemporalJoinRule
[ https://issues.apache.org/jira/browse/FLINK-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215463#comment-17215463 ] Leonard Xu commented on FLINK-19073: master: cd65bbb7cc2ec2099d70375cc009215cf57afe13 > Improve streamExecTemporalJoinRule > -- > > Key: FLINK-19073 > URL: https://issues.apache.org/jira/browse/FLINK-19073 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > > Improve streamExecTemporalJoinRule that matches a temporal join node and > converts it to [[StreamExecTemporalJoin]], > the temporal join node is a [[FlinkLogicalJoin]] whose left input is a > [[FlinkLogicalRel]] and right input is a [[FlinkLogicalSnapshot]]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13555: [FLINK-17613][e2e][k8s] Test against multiple k8s versions
flinkbot edited a comment on pull request #13555: URL: https://github.com/apache/flink/pull/13555#issuecomment-704987370 ## CI report: * dbb8f2d60f4abd5db43d72d34352fdb2083af370 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7646) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7675) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7769) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7726) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
flinkbot commented on pull request #13668: URL: https://github.com/apache/flink/pull/13668#issuecomment-710118986 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 0602dadb007befbb94f13c6a57ccbe29481f2a5b (Fri Oct 16 15:34:17 UTC 2020) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] dawidwys opened a new pull request #13668: [hotfix] Log interrupted exception on debug when closing threads in ExternalSorter
dawidwys opened a new pull request #13668: URL: https://github.com/apache/flink/pull/13668 ## What is the purpose of the change Revert the behaviour of logging an InterreputedException on debug level when closing working threads in ExternalSorter. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #13625: [FLINK-19623][table-planner-blink] Introduce ExecEdge to describe information on input edges for ExecNode
godfreyhe commented on a change in pull request #13625:
URL: https://github.com/apache/flink/pull/13625#discussion_r506540225
##
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchExecCalcBase.scala
##
@@ -112,11 +111,11 @@ abstract class BatchExecCalcBase(
//~ ExecNode methods
---
- override def getDamBehavior = DamBehavior.PIPELINED
-
override def getInputNodes: util.List[ExecNode[BatchPlanner, _]] =
List(getInput.asInstanceOf[ExecNode[BatchPlanner, _]])
+ override def getInputEdges: util.List[ExecEdge] =
List(ExecEdge.builder().build())
Review comment:
create a default ExecEdge instance ?
##
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/reuse/DeadlockBreakupProcessor.scala
##
@@ -320,8 +319,9 @@ class DeadlockBreakupProcessor extends DAGProcessor {
// should exclude the reused node (at last position in path)
while (!hasFullDamNode && idx < inputPath.length - 1) {
val node = inputPath(idx)
- val nodeDamBehavior =
node.asInstanceOf[BatchExecNode[_]].getDamBehavior
- hasFullDamNode = if (nodeDamBehavior == DamBehavior.FULL_DAM) {
+ val atLeastEndInput = node.getInputEdges.forall(
+e =>
e.getDamBehavior.stricterOrEqual(ExecEdge.DamBehavior.END_INPUT))
+ hasFullDamNode = if (atLeastEndInput) {
true
} else {
node match {
Review comment:
we should avoid match specific class here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (FLINK-19685) When use HBase-Connector lookupFunction, 8 hours less to query `DATE`,`TIME`,`TIMESTAMP` data
CaoZhen created FLINK-19685:
---
Summary: When use HBase-Connector lookupFunction, 8 hours less to
query `DATE`,`TIME`,`TIMESTAMP` data
Key: FLINK-19685
URL: https://issues.apache.org/jira/browse/FLINK-19685
Project: Flink
Issue Type: Bug
Components: Connectors / HBase
Reporter: CaoZhen
from the code:
HBaseSerde#createFieldDecoder
{code:java}
case DATE:
case INTERVAL_YEAR_MONTH:
return Bytes::toInt;
case TIME_WITHOUT_TIME_ZONE:
..
return Bytes::toInt;
case TIMESTAMP_WITHOUT_TIME_ZONE:
case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
..
return createTimestampDecoder();
private static FieldDecoder createTimestampDecoder() {
return value -> {
// TODO: support higher precision
long milliseconds = Bytes.toLong(value);
return TimestampData.fromEpochMillis(milliseconds);
};
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13656: [FLINK-19583] Expose the execution.runtime-mode to users
flinkbot edited a comment on pull request #13656: URL: https://github.com/apache/flink/pull/13656#issuecomment-709561220 ## CI report: * 88de2aed84b76c5f61d285fd0a1a4f6a9dc8e388 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7759) * a9c04a955b538391702fd5407f5261cdb3911ee7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7765) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13667: [FLINK-19679] Deduplicate code between CheckpointBarrierUnaligner and CheckpointBarrierAligner
flinkbot edited a comment on pull request #13667: URL: https://github.com/apache/flink/pull/13667#issuecomment-710095324 ## CI report: * cbca395729de539e4ee0d4f76056b09b09f3c935 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7767) * 5ab532006ccbfb5632b4ad60053203a5e5dea3a5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13661: [FLINK-13553] Ignore KvStateServerHandlerTest because it is unstable
flinkbot edited a comment on pull request #13661: URL: https://github.com/apache/flink/pull/13661#issuecomment-709985753 ## CI report: * 3bac7a32fb3e0b7f0341a600de705a60c79497eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7750) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar
flinkbot edited a comment on pull request #13612: URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105 ## CI report: * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) * a1a881b34bea5ede3b622e0d53c9728d232cb48c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13555: [FLINK-17613][e2e][k8s] Test against multiple k8s versions
flinkbot edited a comment on pull request #13555: URL: https://github.com/apache/flink/pull/13555#issuecomment-704987370 ## CI report: * dbb8f2d60f4abd5db43d72d34352fdb2083af370 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7646) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7726) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7675) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7769) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-statefun] klion26 commented on pull request #131: [FLINK-18968] Translate README.md to Chinese
klion26 commented on pull request #131: URL: https://github.com/apache/flink-statefun/pull/131#issuecomment-710106615 FYI, The Translation Specification for Stateful Functions has been added to the [existing wiki](https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FLINK-19684) The Jdbc-connector's 'lookup.max-retries' option implementation is different from the meaning
CaoZhen created FLINK-19684:
---
Summary: The Jdbc-connector's 'lookup.max-retries' option
implementation is different from the meaning
Key: FLINK-19684
URL: https://issues.apache.org/jira/browse/FLINK-19684
Project: Flink
Issue Type: Bug
Components: Connectors / JDBC
Reporter: CaoZhen
The code of 'lookup.max-retries' option :
{code:java}
for (int retry = 1; retry <= maxRetryTimes; retry++) {
statement.clearParameters();
.
}
{code}
>From the code, If this option is set to 0, the JDBC query will not be executed.
>From documents, the max retry times if lookup database failed. [1]
When set to 0, there is a query, but no retry.
So,the code of 'lookup.max-retries' option should be:
{code:java}
for (int retry = 0; retry <= maxRetryTimes; retry++) {
statement.clearParameters();
.
}
{code}
[1]
https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/connectors/jdbc.html#lookup-max-retries
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] godfreyhe commented on pull request #13299: [FLINK-19072][table-planner] Import Temporal Table join rule for Stream
godfreyhe commented on pull request #13299: URL: https://github.com/apache/flink/pull/13299#issuecomment-710104081 related timeout issue: https://issues.apache.org/jira/browse/FLINK-19664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe edited a comment on pull request #13299: [FLINK-19072][table-planner] Import Temporal Table join rule for Stream
godfreyhe edited a comment on pull request #13299: URL: https://github.com/apache/flink/pull/13299#issuecomment-710104081 related timeout issue: [FLINK-19664](https://issues.apache.org/jira/browse/FLINK-19664) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-19072) Import Temporal Table join rule
[ https://issues.apache.org/jira/browse/FLINK-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215440#comment-17215440 ] godfrey he commented on FLINK-19072: master: cd65bbb7cc2ec2099d70375cc009215cf57afe13 > Import Temporal Table join rule > --- > > Key: FLINK-19072 > URL: https://issues.apache.org/jira/browse/FLINK-19072 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Labels: pull-request-available > > The initial temporal table join (FOR SYSTEM_TIME AS OF) is a Correlate, we > need rewrite it into a Join to make join condition can be pushed-down. The > join will be translated into [[StreamExecLookupJoin]] or > [[StreamExecTemporalJoin]] in physical. > Import Temporal table join rule to deal above temporal join rewrite logic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-19072) Import Temporal Table join rule
[ https://issues.apache.org/jira/browse/FLINK-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-19072. -- Resolution: Done > Import Temporal Table join rule > --- > > Key: FLINK-19072 > URL: https://issues.apache.org/jira/browse/FLINK-19072 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Reporter: Leonard Xu >Assignee: Leonard Xu >Priority: Major > Labels: pull-request-available > > The initial temporal table join (FOR SYSTEM_TIME AS OF) is a Correlate, we > need rewrite it into a Join to make join condition can be pushed-down. The > join will be translated into [[StreamExecLookupJoin]] or > [[StreamExecTemporalJoin]] in physical. > Import Temporal table join rule to deal above temporal join rewrite logic. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] godfreyhe merged pull request #13299: [FLINK-19072][table-planner] Import Temporal Table join rule for Stream
godfreyhe merged pull request #13299: URL: https://github.com/apache/flink/pull/13299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #13299: [FLINK-19072][table-planner] Import Temporal Table join rule for Stream
godfreyhe commented on pull request #13299: URL: https://github.com/apache/flink/pull/13299#issuecomment-710100723 Thanks the update, LGTM, +1 to merge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] scottxusayhi commented on pull request #13555: [FLINK-17613][e2e][k8s] Test against multiple k8s versions
scottxusayhi commented on pull request #13555: URL: https://github.com/apache/flink/pull/13555#issuecomment-710100564 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] scottxusayhi removed a comment on pull request #13555: [FLINK-17613][e2e][k8s] Test against multiple k8s versions
scottxusayhi removed a comment on pull request #13555: URL: https://github.com/apache/flink/pull/13555#issuecomment-709813178 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13667: [FLINK-19679] Deduplicate code between CheckpointBarrierUnaligner and CheckpointBarrierAligner
flinkbot commented on pull request #13667: URL: https://github.com/apache/flink/pull/13667#issuecomment-710095324 ## CI report: * cbca395729de539e4ee0d4f76056b09b09f3c935 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13656: [FLINK-19583] Expose the execution.runtime-mode to users
flinkbot edited a comment on pull request #13656: URL: https://github.com/apache/flink/pull/13656#issuecomment-709561220 ## CI report: * b28ac93e6454e96ad9179e81ff76b665ea870c81 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7748) * 88de2aed84b76c5f61d285fd0a1a4f6a9dc8e388 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7759) * a9c04a955b538391702fd5407f5261cdb3911ee7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7765) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13664: [FLINK-19673] Translate "Standalone Cluster" page into Chinese
flinkbot edited a comment on pull request #13664: URL: https://github.com/apache/flink/pull/13664#issuecomment-710017891 ## CI report: * 489b695119de6553145a9fb39efb9ce033a2f1f1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7755) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13666: [FLINK-19640] Add an IT case for bounded execution
flinkbot edited a comment on pull request #13666: URL: https://github.com/apache/flink/pull/13666#issuecomment-710083851 ## CI report: * 6c7c7a356b522b2992916c537b2f6653ddd6937f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7766) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13547: [FLINK-14406][runtime] Exposes managed memory usage through the REST API
flinkbot edited a comment on pull request #13547: URL: https://github.com/apache/flink/pull/13547#issuecomment-704265372 ## CI report: * 268d260399e598943726839a254f004a61f5ba66 UNKNOWN * 73b620c0b16e24f6b985cc0361bbe35237d194d2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7625) * 750fd026fc1dc7191619234901a686c6ebdf4500 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7762) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13614: [FLINK-19547][runtime] Clean up partial record when reconnecting for Approximate Local Recovery
flinkbot edited a comment on pull request #13614: URL: https://github.com/apache/flink/pull/13614#issuecomment-707710438 ## CI report: * f51a6098947a0967f0dadc32903bf1288fb48941 UNKNOWN * a70ae897b37437579d8aab2ba3a744553a08feea Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7746) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13602: [FLINK-19346][coordination] Generate and put ClusterPartitionDescriptor of ClusterPartition in JobResult when job finishes
flinkbot edited a comment on pull request #13602: URL: https://github.com/apache/flink/pull/13602#issuecomment-70743 ## CI report: * 936e6231bbadb1e2dfc52623af670b8a81eeb779 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7701) * 5bd17fad8f85ce110218ef2ec98912b138db03e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7763) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19678) tableEnv.getConfig.setNullCheck(false) seems to break group by
[
https://issues.apache.org/jira/browse/FLINK-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ion Alberdi updated FLINK-19678:
Description:
The program written at
[https://gist.github.com/yetanotherion/d007fa113d97411226eaea4f20cd4c2d|https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fyetanotherion%2Fd007fa113d97411226eaea4f20cd4c2d&data=04%7C01%7Cj.alberdi%40criteo.com%7C08c520289ec4433b7b7a08d871c60180%7C2a35d8fd574d48e3927c8c398e225a01%7C1%7C1%7C637384442549853109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQGyO%2FqLQ%2FCN%2BVuQPYbmPVfKDbLxVKmWJh%2Fu9L2qTBw%3D&reserved=0]
creates unexpected stack traces when the line
*// triggerBug…*
is uncommented (some lines of the stack trace are written in the gist).
(It correctly outputs
{code:java}
+-+
| c |
+-+
| 1 |
| 2 |
+-+
{code}
else)
was:
The program written at
[https://gist.github.com/yetanotherion/d007fa113d97411226eaea4f20cd4c2d|https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fyetanotherion%2Fd007fa113d97411226eaea4f20cd4c2d&data=04%7C01%7Cj.alberdi%40criteo.com%7C08c520289ec4433b7b7a08d871c60180%7C2a35d8fd574d48e3927c8c398e225a01%7C1%7C1%7C637384442549853109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQGyO%2FqLQ%2FCN%2BVuQPYbmPVfKDbLxVKmWJh%2Fu9L2qTBw%3D&reserved=0]
creates unexpected stack traces when the line
*// triggerBug…*
Is uncommented (some lines of the stack trace are written in the gist).
(It correctly outputs
{code:java}
+-+
| c |
+-+
| 1 |
| 2 |
+-+
{code}
else)
> tableEnv.getConfig.setNullCheck(false) seems to break group by
> --
>
> Key: FLINK-19678
> URL: https://issues.apache.org/jira/browse/FLINK-19678
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Runtime
>Affects Versions: 1.11.2
>Reporter: Ion Alberdi
>Priority: Major
>
> The program written at
> [https://gist.github.com/yetanotherion/d007fa113d97411226eaea4f20cd4c2d|https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fyetanotherion%2Fd007fa113d97411226eaea4f20cd4c2d&data=04%7C01%7Cj.alberdi%40criteo.com%7C08c520289ec4433b7b7a08d871c60180%7C2a35d8fd574d48e3927c8c398e225a01%7C1%7C1%7C637384442549853109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQGyO%2FqLQ%2FCN%2BVuQPYbmPVfKDbLxVKmWJh%2Fu9L2qTBw%3D&reserved=0]
> creates unexpected stack traces when the line
> *// triggerBug…*
> is uncommented (some lines of the stack trace are written in the gist).
> (It correctly outputs
> {code:java}
> +-+
> | c |
> +-+
> | 1 |
> | 2 |
> +-+
> {code}
> else)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-19678) tableEnv.getConfig.setNullCheck(false) seems to break group by
[
https://issues.apache.org/jira/browse/FLINK-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215428#comment-17215428
]
Ion Alberdi commented on FLINK-19678:
-
Thanks for the answer [~jark]! Is there an ETA for this removal?
> tableEnv.getConfig.setNullCheck(false) seems to break group by
> --
>
> Key: FLINK-19678
> URL: https://issues.apache.org/jira/browse/FLINK-19678
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Runtime
>Affects Versions: 1.11.2
>Reporter: Ion Alberdi
>Priority: Major
>
> The program written at
> [https://gist.github.com/yetanotherion/d007fa113d97411226eaea4f20cd4c2d|https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fyetanotherion%2Fd007fa113d97411226eaea4f20cd4c2d&data=04%7C01%7Cj.alberdi%40criteo.com%7C08c520289ec4433b7b7a08d871c60180%7C2a35d8fd574d48e3927c8c398e225a01%7C1%7C1%7C637384442549853109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQGyO%2FqLQ%2FCN%2BVuQPYbmPVfKDbLxVKmWJh%2Fu9L2qTBw%3D&reserved=0]
> creates unexpected stack traces when the line
> *// triggerBug…*
> Is uncommented (some lines of the stack trace are written in the gist).
> (It correctly outputs
> {code:java}
> +-+
> | c |
> +-+
> | 1 |
> | 2 |
> +-+
> {code}
> else)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FLINK-19659) Array type supports equals and not_equals operator when element types are different but castable
[
https://issues.apache.org/jira/browse/FLINK-19659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu reassigned FLINK-19659:
---
Assignee: hailong wang
> Array type supports equals and not_equals operator when element types are
> different but castable
>
>
> Key: FLINK-19659
> URL: https://issues.apache.org/jira/browse/FLINK-19659
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / Planner
>Affects Versions: 1.11.0
>Reporter: hailong wang
>Assignee: hailong wang
>Priority: Major
> Fix For: 1.12.0
>
>
> Currently, Array type supports `equals` and `not_equals` when element types
> are the same or can not be cased. For example,
> {code:java}
> Array[1] <> Array[1] -> true{code}
> {code:java}
> Array[1] <> Array[cast(x'01' as binary)] -> false
> {code}
> But for the element types which are castable, it will throw error,
> {code:java}
> org.apache.flink.table.planner.codegen.CodeGenException: Unsupported cast
> from 'ARRAY NOT NULL' to 'ARRAY NOT
> NULL'.org.apache.flink.table.planner.codegen.CodeGenException: Unsupported
> cast from 'ARRAY NOT NULL' to 'ARRAY NOT
> NULL'. at
> org.apache.flink.table.planner.codegen.calls.ScalarOperatorGens$.generateCast(ScalarOperatorGens.scala:1295)
> at
> org.apache.flink.table.planner.codegen.ExprCodeGenerator.generateCallExpression(ExprCodeGenerator.scala:703)
> at
> org.apache.flink.table.planner.codegen.ExprCodeGenerator.visitCall(ExprCodeGenerator.scala:498)
> at
> org.apache.flink.table.planner.codegen.ExprCodeGenerator.visitCall(ExprCodeGenerator.scala:55)
> at org.apache.calcite.rex.RexCall.accept(RexCall.java:288){code}
> But the result should be false or true, for example,
> {code:java}
> /Array[1] <> Array[cast(1 as bigint)] -> true
> {code}
>
> BTW, Map and MultiSet type are same as this, If it did, I am pleasure to open
> other issues to track those.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-19678) tableEnv.getConfig.setNullCheck(false) seems to break group by
[
https://issues.apache.org/jira/browse/FLINK-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215422#comment-17215422
]
Jark Wu commented on FLINK-19678:
-
{{tableEnv.getConfig.setNullCheck}} is going to be removed in the near future.
It's not safe to disable null check.
> tableEnv.getConfig.setNullCheck(false) seems to break group by
> --
>
> Key: FLINK-19678
> URL: https://issues.apache.org/jira/browse/FLINK-19678
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Runtime
>Affects Versions: 1.11.2
>Reporter: Ion Alberdi
>Priority: Major
>
> The program written at
> [https://gist.github.com/yetanotherion/d007fa113d97411226eaea4f20cd4c2d|https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2Fyetanotherion%2Fd007fa113d97411226eaea4f20cd4c2d&data=04%7C01%7Cj.alberdi%40criteo.com%7C08c520289ec4433b7b7a08d871c60180%7C2a35d8fd574d48e3927c8c398e225a01%7C1%7C1%7C637384442549853109%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vQGyO%2FqLQ%2FCN%2BVuQPYbmPVfKDbLxVKmWJh%2Fu9L2qTBw%3D&reserved=0]
> creates unexpected stack traces when the line
> *// triggerBug…*
> Is uncommented (some lines of the stack trace are written in the gist).
> (It correctly outputs
> {code:java}
> +-+
> | c |
> +-+
> | 1 |
> | 2 |
> +-+
> {code}
> else)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #13666: [FLINK-19640] Add an IT case for bounded execution
flinkbot commented on pull request #13666: URL: https://github.com/apache/flink/pull/13666#issuecomment-710083851 ## CI report: * 6c7c7a356b522b2992916c537b2f6653ddd6937f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13656: [FLINK-19583] Expose the execution.runtime-mode to users
flinkbot edited a comment on pull request #13656: URL: https://github.com/apache/flink/pull/13656#issuecomment-709561220 ## CI report: * b28ac93e6454e96ad9179e81ff76b665ea870c81 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7748) * 88de2aed84b76c5f61d285fd0a1a4f6a9dc8e388 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7759) * a9c04a955b538391702fd5407f5261cdb3911ee7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13663: [FLINK-19643][python][doc] Add Pandas UDAF Doc
flinkbot edited a comment on pull request #13663: URL: https://github.com/apache/flink/pull/13663#issuecomment-710009367 ## CI report: * 0e04b3d4c2d0299e6bfde37d80a3cc7dc58abe74 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7754) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13616: [FLINK-18570][hbase][WIP] SQLClientHBaseITCase.testHBase fails on azure
flinkbot edited a comment on pull request #13616: URL: https://github.com/apache/flink/pull/13616#issuecomment-707722760 ## CI report: * be3a69f7f525c963887a9cd0e8e293b9fe5062c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7566) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7752) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7728) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
