[GitHub] [flink] flinkbot edited a comment on pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch
flinkbot edited a comment on pull request #13760: URL: https://github.com/apache/flink/pull/13760#issuecomment-715078238 ## CI report: * 6bbd2cf570cdda1fe9ea98b93fa290ac4d497fbd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8160) * 8939025b83a01f41702926602ec1ed5abfbd98e1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8234) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch
flinkbot edited a comment on pull request #13760: URL: https://github.com/apache/flink/pull/13760#issuecomment-715078238 ## CI report: * 6bbd2cf570cdda1fe9ea98b93fa290ac4d497fbd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8160) * 8939025b83a01f41702926602ec1ed5abfbd98e1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch
godfreyhe commented on a change in pull request #13760:
URL: https://github.com/apache/flink/pull/13760#discussion_r511539298
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/output/ExceptionInMultipleInputOperatorException.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.multipleinput.output;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.streaming.api.operators.MultipleInputStreamOperator;
+import org.apache.flink.util.WrappingRuntimeException;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A special exception that signifies that the cause exception came from a
{@link MultipleInputStreamOperator}.
+ */
+@Internal
+public class ExceptionInMultipleInputOperatorException extends
WrappingRuntimeException {
Review comment:
similar to
[ExceptionInChainedOperatorException](https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/ExceptionInChainedOperatorException.java)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch
godfreyhe commented on a change in pull request #13760:
URL: https://github.com/apache/flink/pull/13760#discussion_r511539298
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/output/ExceptionInMultipleInputOperatorException.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.multipleinput.output;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.streaming.api.operators.MultipleInputStreamOperator;
+import org.apache.flink.util.WrappingRuntimeException;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A special exception that signifies that the cause exception came from a
{@link MultipleInputStreamOperator}.
+ */
+@Internal
+public class ExceptionInMultipleInputOperatorException extends
WrappingRuntimeException {
Review comment:
similar to
`[ExceptionInChainedOperatorException](https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/ExceptionInChainedOperatorException.java)`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch
godfreyhe commented on a change in pull request #13760:
URL: https://github.com/apache/flink/pull/13760#discussion_r511539108
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/FirstInputOfTwoInput.java
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.multipleinput.input;
+
+import org.apache.flink.streaming.api.operators.Input;
+import org.apache.flink.streaming.api.operators.TwoInputStreamOperator;
+import org.apache.flink.streaming.api.watermark.Watermark;
+import org.apache.flink.streaming.runtime.streamrecord.LatencyMarker;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.data.RowData;
+
+/**
+ * {@link Input} for the first input of {@link SecondInputOfTwoInput}.
+ */
+public class FirstInputOfTwoInput extends InputBase {
Review comment:
There are many classes named `TwoInputXXX`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch
godfreyhe commented on a change in pull request #13760:
URL: https://github.com/apache/flink/pull/13760#discussion_r511539068
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/InputSelectionHandler.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.multipleinput.input;
+
+import org.apache.flink.streaming.api.operators.InputSelection;
+import org.apache.flink.streaming.api.operators.MultipleInputStreamOperator;
+
+import javax.annotation.Nullable;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.SortedMap;
+import java.util.TreeMap;
+
+/**
+ * This handler is mainly used for selecting the next available input index
+ * according to read priority in {@link MultipleInputStreamOperator}.
+ *
+ * Input read order: the input with high priority (the value of read order
is lower)
+ * will be read first, the inputs with same priorities will be read fairly.
+ */
+public class InputSelectionHandler {
+ private final List inputSpecs;
+ private final int numberOfInput;
+ /**
+* All inputs ids sorted by priority.
+*/
+ private final List> sortedAvailableInputs;
+ private InputSelection inputSelection;
+
+ public InputSelectionHandler(List inputSpecs) {
+ this.inputSpecs = inputSpecs;
+ this.numberOfInput = inputSpecs.size();
+ this.sortedAvailableInputs = buildSortedAvailableInputs();
+ // read the highest priority inputs first
+ this.inputSelection =
buildInputSelection(sortedAvailableInputs.get(0));
+ }
+
+ public InputSelection getInputSelection() {
+ return inputSelection;
+ }
+
+ public void endInput(int inputId) {
+ List inputIds = sortedAvailableInputs.get(0);
+ if (!inputIds.remove(Integer.valueOf(inputId))) {
+ throw new RuntimeException("This should not happen.");
+ }
+ if (inputIds.isEmpty()) {
+ // remove the finished input
+ sortedAvailableInputs.remove(0);
+
+ if (sortedAvailableInputs.isEmpty()) {
+ // all input are finished
+ inputIds = null;
+ } else {
+ // read next one
+ inputIds = sortedAvailableInputs.get(0);
+ }
+ inputSelection = buildInputSelection(inputIds);
Review comment:
`buildInputSelection` already handles the null case
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #13760: [FLINK-19627][table-runtime] Introduce multiple input operator for batch
godfreyhe commented on a change in pull request #13760:
URL: https://github.com/apache/flink/pull/13760#discussion_r511539022
##
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/input/InputSelectionHandler.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.multipleinput.input;
+
+import org.apache.flink.streaming.api.operators.InputSelection;
+import org.apache.flink.streaming.api.operators.MultipleInputStreamOperator;
+
+import javax.annotation.Nullable;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.SortedMap;
+import java.util.TreeMap;
+
+/**
+ * This handler is mainly used for selecting the next available input index
+ * according to read priority in {@link MultipleInputStreamOperator}.
+ *
+ * Input read order: the input with high priority (the value of read order
is lower)
+ * will be read first, the inputs with same priorities will be read fairly.
+ */
+public class InputSelectionHandler {
+ private final List inputSpecs;
+ private final int numberOfInput;
+ /**
+* All inputs ids sorted by priority.
+*/
+ private final List> sortedAvailableInputs;
+ private InputSelection inputSelection;
+
+ public InputSelectionHandler(List inputSpecs) {
+ this.inputSpecs = inputSpecs;
+ this.numberOfInput = inputSpecs.size();
+ this.sortedAvailableInputs = buildSortedAvailableInputs();
+ // read the highest priority inputs first
+ this.inputSelection =
buildInputSelection(sortedAvailableInputs.get(0));
+ }
+
+ public InputSelection getInputSelection() {
+ return inputSelection;
+ }
+
+ public void endInput(int inputId) {
+ List inputIds = sortedAvailableInputs.get(0);
+ if (!inputIds.remove(Integer.valueOf(inputId))) {
+ throw new RuntimeException("This should not happen.");
+ }
+ if (inputIds.isEmpty()) {
+ // remove the finished input
+ sortedAvailableInputs.remove(0);
+
+ if (sortedAvailableInputs.isEmpty()) {
+ // all input are finished
+ inputIds = null;
+ } else {
+ // read next one
+ inputIds = sortedAvailableInputs.get(0);
+ }
+ inputSelection = buildInputSelection(inputIds);
+ }
+ }
+
+ private List> buildSortedAvailableInputs() {
+ final SortedMap>
orderedAvailableInputIds = new TreeMap<>();
+ for (InputSpec inputSpec : inputSpecs) {
+ List inputIds = orderedAvailableInputIds
+
.computeIfAbsent(inputSpec.getReadOrder(), k -> new ArrayList<>());
+ inputIds.add(inputSpec.getMultipleInputId());
+ }
+ return new ArrayList<>(orderedAvailableInputIds.values());
+ }
+
+ private InputSelection buildInputSelection(@Nullable List
inputIds) {
+ if (inputIds == null) {
+ // TODO throw exception ?
+ return InputSelection.ALL;
Review comment:
`None` is not been defined in `InputSelection`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (FLINK-19795) When TOPN handles duplicate data, it will throw an exception
jinxin created FLINK-19795: -- Summary: When TOPN handles duplicate data, it will throw an exception Key: FLINK-19795 URL: https://issues.apache.org/jira/browse/FLINK-19795 Project: Flink Issue Type: Bug Components: Table SQL / Runtime Affects Versions: 1.11.2 Reporter: jinxin When TOPN handles duplicate data, it will throw an exception : "Can not retract a non-existent record. This should never happen." -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * 25b0c065fae8c72fa607c5b6f47376ff3e6f8568 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8233) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-19794) who wrote the the documents?
[ https://issues.apache.org/jira/browse/FLINK-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth William Krugler closed FLINK-19794. --- Resolution: Not A Bug > who wrote the the documents? > > > Key: FLINK-19794 > URL: https://issues.apache.org/jira/browse/FLINK-19794 > Project: Flink > Issue Type: Test >Reporter: appleyuchi >Priority: Major > > I'm learning Flink Documents > There are > so much missing information > and so much typos > *Could you tell me who wrote the the > [documents|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > are in the mailing list?* > So I can post question to them directly,such as: > the mail title "*how to register TableAggregateFunction*" > in the mailing list. > Thanks for your help. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19794) who wrote the the documents?
[ https://issues.apache.org/jira/browse/FLINK-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220212#comment-17220212 ] Kenneth William Krugler commented on FLINK-19794: - Hi [~appleyuchi] - the right place to ask a question like this is on the [Flink user mailing list|https://flink.apache.org/community.html#mailing-lists]. But to give you the short answer, from the command line: * git clone https://github.com/apache/flink.git * cd flink * find . -name "tableApi*" * git blame ./docs/dev/table/tableApi.md will tell you, for each line in the source Markdown file (tableApi.md, in this case) used to generate the online docs, who last edited it. > who wrote the the documents? > > > Key: FLINK-19794 > URL: https://issues.apache.org/jira/browse/FLINK-19794 > Project: Flink > Issue Type: Test >Reporter: appleyuchi >Priority: Major > > I'm learning Flink Documents > There are > so much missing information > and so much typos > *Could you tell me who wrote the the > [documents|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > are in the mailing list?* > So I can post question to them directly,such as: > the mail title "*how to register TableAggregateFunction*" > in the mailing list. > Thanks for your help. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * 88a90896e0cf1c7bf27fe1aa40158c7280c5fa58 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8228) * 25b0c065fae8c72fa607c5b6f47376ff3e6f8568 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8233) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * cbc3b0ca32cfbfbf57ab34f85ae12e4f8c0ee4aa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8224) * 88a90896e0cf1c7bf27fe1aa40158c7280c5fa58 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8228) * 25b0c065fae8c72fa607c5b6f47376ff3e6f8568 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8233) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * cbc3b0ca32cfbfbf57ab34f85ae12e4f8c0ee4aa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8224) * 88a90896e0cf1c7bf27fe1aa40158c7280c5fa58 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8228) * 25b0c065fae8c72fa607c5b6f47376ff3e6f8568 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (FLINK-19696) Implement Batch committer for the new API
[ https://issues.apache.org/jira/browse/FLINK-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-19696: -- Assignee: Guowei Ma > Implement Batch committer for the new API > - > > Key: FLINK-19696 > URL: https://issues.apache.org/jira/browse/FLINK-19696 > Project: Flink > Issue Type: Sub-task > Components: API / DataStream >Reporter: Guowei Ma >Assignee: Guowei Ma >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-19696) Implement Batch committer for the new API
[ https://issues.apache.org/jira/browse/FLINK-19696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-19696. -- Fix Version/s: 1.12.0 Resolution: Implemented master: 8dba1a812c682c1d7d63f6d76b256c0b1326eb43 > Implement Batch committer for the new API > - > > Key: FLINK-19696 > URL: https://issues.apache.org/jira/browse/FLINK-19696 > Project: Flink > Issue Type: Sub-task > Components: API / DataStream >Reporter: Guowei Ma >Assignee: Guowei Ma >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] kl0u closed pull request #13703: [FLINK-19696] Add runtime batch committer operators for the new sink API
kl0u closed pull request #13703: URL: https://github.com/apache/flink/pull/13703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-19586) Implement StreamCommitterOperator for new Sink API
[ https://issues.apache.org/jira/browse/FLINK-19586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-19586. -- Fix Version/s: 1.12.0 Resolution: Implemented master: ec04072878d3b5b554089e01e0072f2760c39a40 > Implement StreamCommitterOperator for new Sink API > -- > > Key: FLINK-19586 > URL: https://issues.apache.org/jira/browse/FLINK-19586 > Project: Flink > Issue Type: Sub-task > Components: API / DataStream >Reporter: Guowei Ma >Assignee: Guowei Ma >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] kl0u closed pull request #13678: [FLINK-19586] Add stream committer operators for new Sink API
kl0u closed pull request #13678: URL: https://github.com/apache/flink/pull/13678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers
flinkbot edited a comment on pull request #13741: URL: https://github.com/apache/flink/pull/13741#issuecomment-714295796 ## CI report: * 827c2f19269d5ef5ff2ff6fb214b30dd12955b01 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8227) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * cbc3b0ca32cfbfbf57ab34f85ae12e4f8c0ee4aa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8224) * 88a90896e0cf1c7bf27fe1aa40158c7280c5fa58 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8228) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * cbc3b0ca32cfbfbf57ab34f85ae12e4f8c0ee4aa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8224) * 88a90896e0cf1c7bf27fe1aa40158c7280c5fa58 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
flinkbot edited a comment on pull request #13081: URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819 ## CI report: * c7fb5b2d797825ff3b76733529fad8508d967002 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers
flinkbot edited a comment on pull request #13741: URL: https://github.com/apache/flink/pull/13741#issuecomment-714295796 ## CI report: * eef96ff91e5f02a5f777d17cce91e860816ca15b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8226) * 827c2f19269d5ef5ff2ff6fb214b30dd12955b01 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8227) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers
flinkbot edited a comment on pull request #13741: URL: https://github.com/apache/flink/pull/13741#issuecomment-714295796 ## CI report: * 152532018780b987ea2447abd20097375457655f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8133) * eef96ff91e5f02a5f777d17cce91e860816ca15b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8226) * 827c2f19269d5ef5ff2ff6fb214b30dd12955b01 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8227) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers
flinkbot edited a comment on pull request #13741: URL: https://github.com/apache/flink/pull/13741#issuecomment-714295796 ## CI report: * 152532018780b987ea2447abd20097375457655f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8133) * eef96ff91e5f02a5f777d17cce91e860816ca15b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8226) * 827c2f19269d5ef5ff2ff6fb214b30dd12955b01 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers
flinkbot edited a comment on pull request #13741: URL: https://github.com/apache/flink/pull/13741#issuecomment-714295796 ## CI report: * 152532018780b987ea2447abd20097375457655f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8133) * eef96ff91e5f02a5f777d17cce91e860816ca15b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8226) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers
flinkbot edited a comment on pull request #13741: URL: https://github.com/apache/flink/pull/13741#issuecomment-714295796 ## CI report: * 152532018780b987ea2447abd20097375457655f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8133) * eef96ff91e5f02a5f777d17cce91e860816ca15b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (FLINK-19749) Improve documentation for "Column Operations" in Table API page
[ https://issues.apache.org/jira/browse/FLINK-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220125#comment-17220125 ] appleyuchi edited comment on FLINK-19749 at 10/24/20, 3:05 PM: --- I have three problem about "Table API page" in mailing list. They're all about *old code usage* which is written in the newest documentation. Could you help solve it? It's NOT allowed to post question in JIRA, but nobody in mailing ever answered them. I guess official developers are too busy. Thanks for your help. was (Author: appleyuchi): I have three problem about "Table API page" in mailing list. They're all about *old code usage* which is written in the newest documentation. Could you help solve it? They forbidden me to post question in JIRA, but nobody in mailing ever answered them. I guess official developers are too busy. Thanks for your help. > Improve documentation for "Column Operations" in Table API page > --- > > Key: FLINK-19749 > URL: https://issues.apache.org/jira/browse/FLINK-19749 > Project: Flink > Issue Type: Improvement > Components: Documentation, Table SQL / API >Reporter: appleyuchi >Priority: Major > Attachments: Old API examples.png > > > in this > [link|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > there's a "description": > *Performs a field add operation. Existing fields will be replaced if add > columns name is the same as the existing column name. Moreover, if the added > fields have duplicate field name, then the last one is used.* > Two point: > ①" add columns name "->" added column's name" > ②"if the added fields have duplicate field name", > what's the example that has two duplicate field name? > Could you modify them? > They're a little misleading/unclear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-19749) Improve documentation for "Column Operations" in Table API page
[ https://issues.apache.org/jira/browse/FLINK-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220125#comment-17220125 ] appleyuchi edited comment on FLINK-19749 at 10/24/20, 3:05 PM: --- I have three problem about "Table API page" in mailing list. They're all about *old code usage* which is written in *the newest documentation.* Could you help solve it? It's NOT allowed to post question in JIRA, but nobody in mailing ever answered them. I guess official developers are too busy. Thanks for your help. was (Author: appleyuchi): I have three problem about "Table API page" in mailing list. They're all about *old code usage* which is written in the newest documentation. Could you help solve it? It's NOT allowed to post question in JIRA, but nobody in mailing ever answered them. I guess official developers are too busy. Thanks for your help. > Improve documentation for "Column Operations" in Table API page > --- > > Key: FLINK-19749 > URL: https://issues.apache.org/jira/browse/FLINK-19749 > Project: Flink > Issue Type: Improvement > Components: Documentation, Table SQL / API >Reporter: appleyuchi >Priority: Major > Attachments: Old API examples.png > > > in this > [link|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > there's a "description": > *Performs a field add operation. Existing fields will be replaced if add > columns name is the same as the existing column name. Moreover, if the added > fields have duplicate field name, then the last one is used.* > Two point: > ①" add columns name "->" added column's name" > ②"if the added fields have duplicate field name", > what's the example that has two duplicate field name? > Could you modify them? > They're a little misleading/unclear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19749) Improve documentation for "Column Operations" in Table API page
[ https://issues.apache.org/jira/browse/FLINK-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220125#comment-17220125 ] appleyuchi commented on FLINK-19749: I have three problem about "Table API page" in mailing list. They're all about *old code usage* which is written in the newest documentation. Could you help solve it? They forbidden me to post question in JIRA, but nobody in mailing ever answered them. I guess official developers are too busy. Thanks for your help. > Improve documentation for "Column Operations" in Table API page > --- > > Key: FLINK-19749 > URL: https://issues.apache.org/jira/browse/FLINK-19749 > Project: Flink > Issue Type: Improvement > Components: Documentation, Table SQL / API >Reporter: appleyuchi >Priority: Major > Attachments: Old API examples.png > > > in this > [link|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > there's a "description": > *Performs a field add operation. Existing fields will be replaced if add > columns name is the same as the existing column name. Moreover, if the added > fields have duplicate field name, then the last one is used.* > Two point: > ①" add columns name "->" added column's name" > ②"if the added fields have duplicate field name", > what's the example that has two duplicate field name? > Could you modify them? > They're a little misleading/unclear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13688: [FLINK-19238] Arena block size sanity
flinkbot edited a comment on pull request #13688: URL: https://github.com/apache/flink/pull/13688#issuecomment-712121175 ## CI report: * 728efeb026459830372935d684b1e189869f26cb UNKNOWN * 7cef297fd3cb1534ca3c33ecd66dc6e73c57380d UNKNOWN * 83600840ab86ba77f2045f3eed61e2b7c86effe2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8222) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
flinkbot edited a comment on pull request #13081: URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819 ## CI report: * c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255) * c7fb5b2d797825ff3b76733529fad8508d967002 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8225) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
flinkbot edited a comment on pull request #13081: URL: https://github.com/apache/flink/pull/13081#issuecomment-669992819 ## CI report: * c40e55a11ae4f9fc5a5c31aa6963f461a7ae70d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5255) * c7fb5b2d797825ff3b76733529fad8508d967002 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
libenchao commented on pull request #13081: URL: https://github.com/apache/flink/pull/13081#issuecomment-715921192 @wuchong Sorry for the lateness. I've addressed most of your comments, could you have another look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] libenchao commented on a change in pull request #13081: [FLINK-18590][json] Support json array explode to multi messages
libenchao commented on a change in pull request #13081:
URL: https://github.com/apache/flink/pull/13081#discussion_r511467564
##
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##
@@ -130,6 +133,39 @@ public RowData deserialize(byte[] message) throws
IOException {
}
}
+ @Override
Review comment:
I agree that we should remove this method for json format. However there
are many places that still call this method. We can do this work in one
separate issue, WDYT?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (FLINK-19749) Improve documentation for "Column Operations" in Table API page
[ https://issues.apache.org/jira/browse/FLINK-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220110#comment-17220110 ] Roc Marshal edited comment on FLINK-19749 at 10/24/20, 2:13 PM: Hi, [~jark] [~appleyuchi] Is it more appropriate if the jira title is set as "Improve documentation in 'Table API' page" ? I hope to be able to fix some old code usage problems as shown in the picture[Old API examples.png] in this PR. What do you think of it ? was (Author: rocmarshal): Hi, [~jark] [~appleyuchi] Is it more appropriate if the jira title is set as 'Update expired sample code and semantics' ? I hope to be able to fix some old code usage problems as shown in the picture[Old API examples.png] in this PR. What do you think of it ? > Improve documentation for "Column Operations" in Table API page > --- > > Key: FLINK-19749 > URL: https://issues.apache.org/jira/browse/FLINK-19749 > Project: Flink > Issue Type: Improvement > Components: Documentation, Table SQL / API >Reporter: appleyuchi >Priority: Major > Attachments: Old API examples.png > > > in this > [link|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > there's a "description": > *Performs a field add operation. Existing fields will be replaced if add > columns name is the same as the existing column name. Moreover, if the added > fields have duplicate field name, then the last one is used.* > Two point: > ①" add columns name "->" added column's name" > ②"if the added fields have duplicate field name", > what's the example that has two duplicate field name? > Could you modify them? > They're a little misleading/unclear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-19749) Improve documentation for "Column Operations" in Table API page
[ https://issues.apache.org/jira/browse/FLINK-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220110#comment-17220110 ] Roc Marshal commented on FLINK-19749: - Hi, [~jark] [~appleyuchi] Is it more appropriate if the jira title is set as 'Update expired sample code and semantics' ? I hope to be able to fix some old code usage problems as shown in the picture[Old API examples.png] in this PR. What do you think of it ? > Improve documentation for "Column Operations" in Table API page > --- > > Key: FLINK-19749 > URL: https://issues.apache.org/jira/browse/FLINK-19749 > Project: Flink > Issue Type: Improvement > Components: Documentation, Table SQL / API >Reporter: appleyuchi >Priority: Major > Attachments: Old API examples.png > > > in this > [link|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > there's a "description": > *Performs a field add operation. Existing fields will be replaced if add > columns name is the same as the existing column name. Moreover, if the added > fields have duplicate field name, then the last one is used.* > Two point: > ①" add columns name "->" added column's name" > ②"if the added fields have duplicate field name", > what's the example that has two duplicate field name? > Could you modify them? > They're a little misleading/unclear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-19749) Improve documentation for "Column Operations" in Table API page
[ https://issues.apache.org/jira/browse/FLINK-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roc Marshal updated FLINK-19749: Attachment: Old API examples.png > Improve documentation for "Column Operations" in Table API page > --- > > Key: FLINK-19749 > URL: https://issues.apache.org/jira/browse/FLINK-19749 > Project: Flink > Issue Type: Improvement > Components: Documentation, Table SQL / API >Reporter: appleyuchi >Priority: Major > Attachments: Old API examples.png > > > in this > [link|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > there's a "description": > *Performs a field add operation. Existing fields will be replaced if add > columns name is the same as the existing column name. Moreover, if the added > fields have duplicate field name, then the last one is used.* > Two point: > ①" add columns name "->" added column's name" > ②"if the added fields have duplicate field name", > what's the example that has two duplicate field name? > Could you modify them? > They're a little misleading/unclear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * cbc3b0ca32cfbfbf57ab34f85ae12e4f8c0ee4aa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8224) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * 5e5340241b5811243463f96dda7455b2869cf268 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8223) * cbc3b0ca32cfbfbf57ab34f85ae12e4f8c0ee4aa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8224) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese
RocMarshal commented on pull request #13750: URL: https://github.com/apache/flink/pull/13750#issuecomment-715906722 Hi, @klion26 Could you help me to review this PR if you have free time? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * 5e5340241b5811243463f96dda7455b2869cf268 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8223) * cbc3b0ca32cfbfbf57ab34f85ae12e4f8c0ee4aa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13688: [FLINK-19238] Arena block size sanity
flinkbot edited a comment on pull request #13688: URL: https://github.com/apache/flink/pull/13688#issuecomment-712121175 ## CI report: * 728efeb026459830372935d684b1e189869f26cb UNKNOWN * 7cef297fd3cb1534ca3c33ecd66dc6e73c57380d UNKNOWN * 5fed292da3f551884829a2ccc562ec51d0ecae2a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7941) * 83600840ab86ba77f2045f3eed61e2b7c86effe2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8222) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13735: [FLINK-19533][checkpoint] Add channel state reassignment for unaligned checkpoints.
flinkbot edited a comment on pull request #13735: URL: https://github.com/apache/flink/pull/13735#issuecomment-714048414 ## CI report: * 458aee4e1d6779beb640f563c7c9b5a65e645237 UNKNOWN * 470d466cfe4455aefd5a302cedd92b57750f2c57 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8212) * 5e5340241b5811243463f96dda7455b2869cf268 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] anonymouscodeholic commented on a change in pull request #13688: [FLINK-19238] Arena block size sanity
anonymouscodeholic commented on a change in pull request #13688:
URL: https://github.com/apache/flink/pull/13688#discussion_r511387433
##
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBMemoryControllerUtilsTest.java
##
@@ -91,10 +93,33 @@ public void testCreateSharedResourcesWithExpectedCapacity()
{
long totalMemorySize = 2048L;
double writeBufferRatio = 0.5;
double highPriPoolRatio = 0.1;
-
RocksDBMemoryControllerUtils.allocateRocksDBSharedResources(totalMemorySize,
writeBufferRatio, highPriPoolRatio);
+ RocksDBSharedResources rocksDBSharedResources =
RocksDBMemoryControllerUtils.allocateRocksDBSharedResources(totalMemorySize,
writeBufferRatio, highPriPoolRatio);
long expectedCacheCapacity =
RocksDBMemoryControllerUtils.calculateActualCacheCapacity(totalMemorySize,
writeBufferRatio);
long expectedWbmCapacity =
RocksDBMemoryControllerUtils.calculateWriteBufferManagerCapacity(totalMemorySize,
writeBufferRatio);
+
assertThat(actualCacheCapacity.get(),
is(expectedCacheCapacity));
assertThat(actualWbmCapacity.get(), is(expectedWbmCapacity));
+
assertThat(rocksDBSharedResources.getWriteBufferManagerCapacity(),
is(expectedWbmCapacity));
+ }
+
+ @Test
+ public void testCalculateRocksDBDefaultArenaBlockSize() {
+ long writeBufferSize = 64 * 1024 * 1024;
+ long expectArenaBlockSize = writeBufferSize / 8;
+
assertThat(RocksDBMemoryControllerUtils.calculateRocksDBDefaultArenaBlockSize(writeBufferSize),
is(expectArenaBlockSize));
+ }
+
+ @Test
+ public void testCalculateRocksDBMutableLimit() {
+ long bufferSize = 64 * 1024 * 1024;
+ long limit = bufferSize * 7 / 8;
+
assertThat(RocksDBMemoryControllerUtils.calculateRocksDBMutableLimit(bufferSize),
is(limit));
+ }
+
+ @Test
+ public void testValidateArenaBlockSize() {
+ long arenaBlockSize = 8 * 1024 * 1024;
+
assertFalse(RocksDBMemoryControllerUtils.validateArenaBlockSize(arenaBlockSize,
(long) (arenaBlockSize * 0.5)));
+
assertTrue(RocksDBMemoryControllerUtils.validateArenaBlockSize(arenaBlockSize,
(long) (arenaBlockSize * 1.5)));
}
Review comment:
The contract for e.g. `calculateRocksDBDefaultArenaBlockSize` would be
what the JavaDoc says? What a test for `calculateRocksDBDefaultArenaBlockSize`
should do IMHO is to test that the method follows its documentation. If the
formula changes, the JavaDoc should change and thus the test method would
change too. Does this make sense?
BTW, now when I look at this closer, I think there's a minor issue. In
https://github.com/ververica/frocksdb/blob/49bc897d5d768026f1eb816d960c1f2383396ef4/db/column_family.cc#L200
there's the aligning that is missing from the method. Also the test should
check a case when alignment is needed and where it's not needed. I'll fix this
later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13688: [FLINK-19238] Arena block size sanity
flinkbot edited a comment on pull request #13688: URL: https://github.com/apache/flink/pull/13688#issuecomment-712121175 ## CI report: * 728efeb026459830372935d684b1e189869f26cb UNKNOWN * 7cef297fd3cb1534ca3c33ecd66dc6e73c57380d UNKNOWN * 5fed292da3f551884829a2ccc562ec51d0ecae2a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7941) * 83600840ab86ba77f2045f3eed61e2b7c86effe2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-19677) TaskManager takes abnormally long time to register with JobManager on Kubernetes
[ https://issues.apache.org/jira/browse/FLINK-19677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-19677. - Resolution: Fixed Fixed via 1.12.0: 8fd36be35c4cff31960de6478295742952c93d55 1.11.3: d251ce5ab43d89d3d09a3f09ecf9a33435e5d901 > TaskManager takes abnormally long time to register with JobManager on > Kubernetes > > > Key: FLINK-19677 > URL: https://issues.apache.org/jira/browse/FLINK-19677 > Project: Flink > Issue Type: Improvement > Components: Runtime / Task >Affects Versions: 1.11.0, 1.11.1, 1.11.2 >Reporter: Weike Dong >Assignee: Weike Dong >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0, 1.11.3 > > > During the registration process of TaskManager, JobManager would create a > _TaskManagerLocation_ instance, which tries to get hostname of the > TaskManager via reverse DNS lookup. > However, this always fails in Kubernetes environment, because for pods that > are not exposed by Services, their IPs cannot be resolved to domains by > coredns, and _InetAddress#getCanonicalHostName()_ would take ~5 seconds to > return, blocking the whole registration process. > Therefore Flink should provide a configuration parameter to turn off reverse > DNS lookup. Also, even when hostname is actually needed, this could be done > lazily to avoid blocking registration of other TaskManagers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] tillrohrmann commented on pull request #13774: [BP-1.11][FLINK-19677][runtime] Make JobManager lazily resolve hostname of TaskManager and provide an option to turn off reverse resolut
tillrohrmann commented on pull request #13774: URL: https://github.com/apache/flink/pull/13774#issuecomment-715888230 Manually merged via d251ce5ab43d89d3d09a3f09ecf9a33435e5d901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #13774: [BP-1.11][FLINK-19677][runtime] Make JobManager lazily resolve hostname of TaskManager and provide an option to turn off reverse resolution en
tillrohrmann closed pull request #13774: URL: https://github.com/apache/flink/pull/13774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #13706: [FLINK-19677][runtime] Make JobManager lazily resolve hostname of TaskManager and provide an option to turn off reverse resolution entirely
tillrohrmann closed pull request #13706: URL: https://github.com/apache/flink/pull/13706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-19794) who wrote the the documents?
[ https://issues.apache.org/jira/browse/FLINK-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] appleyuchi updated FLINK-19794: --- Description: I'm learning Flink Documents There are so much missing information and so much typos *Could you tell me who wrote the the [documents|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] are in the mailing list?* So I can post question to them directly,such as: the mail title "*how to register TableAggregateFunction*" in the mailing list. Thanks for your help. was: There are so much missing information and so much typos *Could you tell me who wrote the the documents are in the mailing list?* https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html So I can post question to them directly,such as: the mail title "*how to register TableAggregateFunction*" in the mailing list. Thanks for your help. > who wrote the the documents? > > > Key: FLINK-19794 > URL: https://issues.apache.org/jira/browse/FLINK-19794 > Project: Flink > Issue Type: Test >Reporter: appleyuchi >Priority: Major > > I'm learning Flink Documents > There are > so much missing information > and so much typos > *Could you tell me who wrote the the > [documents|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] > are in the mailing list?* > So I can post question to them directly,such as: > the mail title "*how to register TableAggregateFunction*" > in the mailing list. > Thanks for your help. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-19794) who wrote the the documents?
[ https://issues.apache.org/jira/browse/FLINK-19794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] appleyuchi updated FLINK-19794: --- Description: There are so much missing information and so much typos *Could you tell me who wrote the the documents are in the mailing list?* https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html So I can post question to them directly,such as: the mail title "*how to register TableAggregateFunction*" in the mailing list. Thanks for your help. was: There are so much missing information and so much typos *Could you tell me who wrote the the documents are in the mailing list?* So I can post question to them directly,such as: the mail"how to register TableAggregateFunction" in the mailing list. Thanks for your help. > who wrote the the documents? > > > Key: FLINK-19794 > URL: https://issues.apache.org/jira/browse/FLINK-19794 > Project: Flink > Issue Type: Test >Reporter: appleyuchi >Priority: Major > > There are > so much missing information > and so much typos > *Could you tell me who wrote the the documents are in the mailing list?* > https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html > So I can post question to them directly,such as: > the mail title "*how to register TableAggregateFunction*" > in the mailing list. > Thanks for your help. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-19794) who wrote the the documents?
appleyuchi created FLINK-19794: -- Summary: who wrote the the documents? Key: FLINK-19794 URL: https://issues.apache.org/jira/browse/FLINK-19794 Project: Flink Issue Type: Test Reporter: appleyuchi There are so much missing information and so much typos *Could you tell me who wrote the the documents are in the mailing list?* So I can post question to them directly,such as: the mail"how to register TableAggregateFunction" in the mailing list. Thanks for your help. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #13771: [FLINK-19789][hive] Migrate Hive connector to new table source sink interface
flinkbot edited a comment on pull request #13771: URL: https://github.com/apache/flink/pull/13771#issuecomment-715323930 ## CI report: * e5442954ffac19a92ba1f9a4620584e61acb601a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8219) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13767: [FLINK-19787][table-runtime] Migrate Filesystem connector to new table source sink interface
flinkbot edited a comment on pull request #13767: URL: https://github.com/apache/flink/pull/13767#issuecomment-715256450 ## CI report: * 11330173d2fcaeead16e067e1f7d31c50081c2e1 UNKNOWN * c532d886b68b7dd265c9056945a3cfc94e8352b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8218) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build - `@flinkbot run azure` re-run the last Azure build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
