[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
flinkbot edited a comment on pull request #17426: URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939 ## CI report: * Unknown: [CANCELED](TBD) * b3f889f3c75ca26e6e54e45694d207e529d9dd43 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
flinkbot edited a comment on pull request #16821: URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870 ## CI report: * 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN * Unknown: [CANCELED](TBD) * 30735755524707e1a408a29fc59404479b7ac5c3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24888) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Aitozi commented on pull request #17426: URL: https://github.com/apache/flink/pull/17426#issuecomment-939230211 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…
Aitozi commented on pull request #17426: URL: https://github.com/apache/flink/pull/17426#issuecomment-939230175 The failure case is related to [FLINK-24472](https://issues.apache.org/jira/browse/FLINK-24472) , rebase and run again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-24332) Support to mount a dynamically-created persistent volume claim per TaskManager
[
https://issues.apache.org/jira/browse/FLINK-24332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426497#comment-17426497
]
Yang Wang commented on FLINK-24332:
---
Yes, each {{TaskManager}} pod should get a new PVC.
It is not a problem that new launched TaskManager will receive the same PVC as
the previous one in StatefulSet. The problem is using naked pod has more
advantages than StatefulSet for TaskManager.
* Flink could delete specific naked TaskManager pod easily. And it is more
difficult to do this in StatefulSet.
* I am not sure whether Flink could work normally when we allow the
TaskManager pod could be restarted. For example, same hostname with different
IP, or TM register more than once to RM/JM.
* For fine-grained resource management, we might have various TaskManager pods
with different spec(2G, 4G, etc.).
> Support to mount a dynamically-created persistent volume claim per TaskManager
> --
>
> Key: FLINK-24332
> URL: https://issues.apache.org/jira/browse/FLINK-24332
> Project: Flink
> Issue Type: New Feature
> Components: Deployment / Kubernetes
>Reporter: Yang Wang
>Priority: Major
>
> Pod template could be used to mount a same PVC for all the TaskManagers.
> However, in many cases, users need to mount dynamically-created persistent
> volume claim for each TaskManager.
>
> Refer to
> [https://lists.apache.org/thread.html/r08ed40ee541c69a74c6d48cc315671198a1910dbd34fd731fe77da37%40%3Cuser.flink.apache.org%3E]
> for more information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
flinkbot edited a comment on pull request #16821: URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870 ## CI report: * 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN * Unknown: [CANCELED](TBD) * 30735755524707e1a408a29fc59404479b7ac5c3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-20928) KafkaSourceReaderTest.testOffsetCommitOnCheckpointComplete:189->pollUntil:270 » Timeout
[
https://issues.apache.org/jira/browse/FLINK-20928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426481#comment-17426481
]
Xintong Song commented on FLINK-20928:
--
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24881=logs=ce8f3cc3-c1ea-5281-f5eb-df9ebd24947f=918e890f-5ed9-5212-a25e-962628fb4bc5=6996
> KafkaSourceReaderTest.testOffsetCommitOnCheckpointComplete:189->pollUntil:270
> » Timeout
> ---
>
> Key: FLINK-20928
> URL: https://issues.apache.org/jira/browse/FLINK-20928
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.13.0, 1.14.0, 1.15.0
>Reporter: Robert Metzger
>Assignee: Qingsheng Ren
>Priority: Critical
> Labels: pull-request-available, test-stability
> Fix For: 1.15.0, 1.14.1
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=11861=logs=c5f0071e-1851-543e-9a45-9ac140befc32=1fb1a56f-e8b5-5a82-00a0-a2db7757b4f5
> {code}
> [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 93.992 s <<< FAILURE! - in
> org.apache.flink.connector.kafka.source.reader.KafkaSourceReaderTest
> [ERROR]
> testOffsetCommitOnCheckpointComplete(org.apache.flink.connector.kafka.source.reader.KafkaSourceReaderTest)
> Time elapsed: 60.086 s <<< ERROR!
> java.util.concurrent.TimeoutException: The offset commit did not finish
> before timeout.
> at
> org.apache.flink.core.testutils.CommonTestUtils.waitUtil(CommonTestUtils.java:210)
> at
> org.apache.flink.connector.kafka.source.reader.KafkaSourceReaderTest.pollUntil(KafkaSourceReaderTest.java:270)
> at
> org.apache.flink.connector.kafka.source.reader.KafkaSourceReaderTest.testOffsetCommitOnCheckpointComplete(KafkaSourceReaderTest.java:189)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-23493) python tests hang on Azure
[ https://issues.apache.org/jira/browse/FLINK-23493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426480#comment-17426480 ] Xintong Song commented on FLINK-23493: -- https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24881=logs=821b528f-1eed-5598-a3b4-7f748b13f261=6bb545dd-772d-5d8c-f258-f5085fba3295=23896 > python tests hang on Azure > -- > > Key: FLINK-23493 > URL: https://issues.apache.org/jira/browse/FLINK-23493 > Project: Flink > Issue Type: Bug > Components: API / Python >Affects Versions: 1.14.0, 1.13.1, 1.12.4, 1.15.0 >Reporter: Dawid Wysakowicz >Assignee: Huang Xingbo >Priority: Blocker > Labels: test-stability > Fix For: 1.15.0, 1.14.1 > > > https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=20898=logs=821b528f-1eed-5598-a3b4-7f748b13f261=4fad9527-b9a5-5015-1b70-8356e5c91490=22829 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
horacehylee commented on pull request #16821: URL: https://github.com/apache/flink/pull/16821#issuecomment-939226572 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] horacehylee commented on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
horacehylee commented on pull request #16821: URL: https://github.com/apache/flink/pull/16821#issuecomment-939226259 @xintongsong Updated the code changes, can help to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (FLINK-22096) ServerTransportErrorHandlingTest.testRemoteClose fail
[
https://issues.apache.org/jira/browse/FLINK-22096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426451#comment-17426451
]
Guowei Ma edited comment on FLINK-22096 at 10/9/21, 4:46 AM:
-
Thank [~tanyuxin] for your attention. I assign this jira to you, please feel
free to contact me if you have any questions
was (Author: maguowei):
Thank [~tanyuxin] for your attention. I will assign this jira to you, please
feel free to contact me if you have any questions
> ServerTransportErrorHandlingTest.testRemoteClose fail
> --
>
> Key: FLINK-22096
> URL: https://issues.apache.org/jira/browse/FLINK-22096
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Network
>Affects Versions: 1.13.0, 1.14.0, 1.15.0
>Reporter: Guowei Ma
>Assignee: Yuxin Tan
>Priority: Major
> Labels: test-stability
> Fix For: 1.13.3, 1.15.0, 1.14.1
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15966=logs=0da23115-68bb-5dcd-192c-bd4c8adebde1=05b74a19-4ee4-5036-c46f-ada307df6cf0=6580
> {code:java}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.415
> s <<< FAILURE! - in
> org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest
> [ERROR]
> testRemoteClose(org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest)
> Time elapsed: 1.338 s <<< ERROR!
> org.apache.flink.shaded.netty4.io.netty.channel.unix.Errors$NativeIoException:
> bind(..) failed: Address already in use
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] horacehylee commented on a change in pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
horacehylee commented on a change in pull request #16821:
URL: https://github.com/apache/flink/pull/16821#discussion_r725431881
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##
@@ -36,8 +38,13 @@
public class CoreOptions {
@Internal
-public static final String PARENT_FIRST_LOGGING_PATTERNS =
-
"org.slf4j;org.apache.log4j;org.apache.logging;org.apache.commons.logging;ch.qos.logback";
+public static final List PARENT_FIRST_LOGGING_PATTERNS =
+Arrays.asList(
+"org.slf4j",
+"org.apache.log4j",
+"org.apache.logging",
+"org.apache.commons.logging",
+"ch.qos.logback");
Review comment:
Yes it will be much nicer with `String[]`
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate
unintended side-effects of this young feature.")
-public static final ConfigOption
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+public static final ConfigOption>
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
-.defaultValue(
-"java.;org.apache.flink.;javax.annotation.;"
-+ PARENT_FIRST_LOGGING_PATTERNS)
+.asList()
+.defaultValues(
+mergeListsToArray(
+Arrays.asList(
+"java.", "org.apache.flink.",
"javax.annotation."),
+PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
-"A (semicolon-separated) list of patterns that
specifies which classes should always be"
+"A list of patterns that specifies which classes
should always be"
+ " resolved through the plugin parent
ClassLoader first. A pattern is a simple prefix that is checked "
+ " against the fully qualified class
name. This setting should generally not be modified. To add another "
+ " pattern we recommend to use
\"plugin.classloader.parent-first-patterns.additional\" instead.");
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate
unintended side-effects of this young feature.")
-public static final ConfigOption
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
-
ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
-.stringType()
-.defaultValue("")
-.withDescription(
-"A (semicolon-separated) list of patterns that
specifies which classes should always be"
-+ " resolved through the plugin parent
ClassLoader first. A pattern is a simple prefix that is checked "
-+ " against the fully qualified class
name. These patterns are appended to \""
-+
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS.key()
-+ "\".");
+public static final ConfigOption>
+PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+
ConfigOptions.key("plugin.classloader.parent-first-patterns.additional")
+.stringType()
+.asList()
+.noDefaultValue()
+.withDescription(
+"A list of patterns that specifies which
classes should always be"
Review comment:
Sure, updated the description accordingly.
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate
unintended side-effects of this young feature.")
-public static final ConfigOption
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+public static final ConfigOption>
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
-
[jira] [Created] (FLINK-24490) The sample code is wrong in Apache Kafka Connector page
JasonLee created FLINK-24490:
Summary: The sample code is wrong in Apache Kafka Connector page
Key: FLINK-24490
URL: https://issues.apache.org/jira/browse/FLINK-24490
Project: Flink
Issue Type: Bug
Components: Documentation
Affects Versions: 1.14.0
Reporter: JasonLee
Fix For: 1.14.0
There is a sample code error in the kafka sink part
{code:java}
// code placeholder
KafkaSink sink = KafkaSink.builder()
.setBootstrapServers(brokers)
.setRecordSerializer(KafkaRecordSerializationSchema.builder()
.setTopic("topic-name")
.setValueSerializationSchema(new SimpleStringSchema())
.setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
.build()
)
.build();
{code}
The correct wording should be as follows
{code:java}
// code placeholder
KafkaSink sink = KafkaSink.builder()
.setKafkaProducerConfig(properties)
.setBootstrapServers(broker)
.setRecordSerializer(KafkaRecordSerializationSchema.builder()
.setTopic(topic)
.setValueSerializationSchema(new SimpleStringSchema())
.build()
).setDeliverGuarantee(DeliveryGuarantee.EXACTLY_ONCE)
.build();
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] horacehylee commented on a change in pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
horacehylee commented on a change in pull request #16821:
URL: https://github.com/apache/flink/pull/16821#discussion_r725431848
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##
@@ -94,24 +101,39 @@
*
*/
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
-public static final ConfigOption
ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+public static final ConfigOption>
ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("classloader.parent-first-patterns.default")
-.defaultValue(
-
"java.;scala.;org.apache.flink.;com.esotericsoftware.kryo;org.apache.hadoop.;javax.annotation.;org.xml;javax.xml;org.apache.xerces;org.w3c;"
-+ PARENT_FIRST_LOGGING_PATTERNS)
+.stringType()
+.asList()
+.defaultValues(
+mergeListsToArray(
+Arrays.asList(
+"java.",
+"scala.",
+"org.apache.flink.",
+"com.esotericsoftware.kryo",
+"org.apache.hadoop.",
+"javax.annotation.",
+"org.xml",
+"javax.xml",
+"org.apache.xerces",
+"org.w3c"),
+PARENT_FIRST_LOGGING_PATTERNS))
.withDeprecatedKeys("classloader.parent-first-patterns")
.withDescription(
-"A (semicolon-separated) list of patterns that
specifies which classes should always be"
+"A list of patterns that specifies which classes
should always be"
+ " resolved through the parent
ClassLoader first. A pattern is a simple prefix that is checked against"
+ " the fully qualified class name. This
setting should generally not be modified. To add another pattern we"
+ " recommend to use
\"classloader.parent-first-patterns.additional\" instead.");
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
-public static final ConfigOption
ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
+public static final ConfigOption>
ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL =
ConfigOptions.key("classloader.parent-first-patterns.additional")
-.defaultValue("")
+.stringType()
+.asList()
+.noDefaultValue()
Review comment:
Good catch. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] horacehylee commented on a change in pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
horacehylee commented on a change in pull request #16821:
URL: https://github.com/apache/flink/pull/16821#discussion_r725431805
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##
@@ -94,24 +101,39 @@
*
*/
@Documentation.Section(Documentation.Sections.EXPERT_CLASS_LOADING)
-public static final ConfigOption
ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+public static final ConfigOption>
ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("classloader.parent-first-patterns.default")
-.defaultValue(
-
"java.;scala.;org.apache.flink.;com.esotericsoftware.kryo;org.apache.hadoop.;javax.annotation.;org.xml;javax.xml;org.apache.xerces;org.w3c;"
-+ PARENT_FIRST_LOGGING_PATTERNS)
+.stringType()
+.asList()
+.defaultValues(
+mergeListsToArray(
+Arrays.asList(
+"java.",
+"scala.",
+"org.apache.flink.",
+"com.esotericsoftware.kryo",
+"org.apache.hadoop.",
+"javax.annotation.",
+"org.xml",
+"javax.xml",
+"org.apache.xerces",
+"org.w3c"),
+PARENT_FIRST_LOGGING_PATTERNS))
.withDeprecatedKeys("classloader.parent-first-patterns")
.withDescription(
-"A (semicolon-separated) list of patterns that
specifies which classes should always be"
+"A list of patterns that specifies which classes
should always be"
Review comment:
Sure, updated the description accordingly.
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##
@@ -127,9 +149,13 @@
+ "thrown while trying to load a user code
class.");
public static String[] getParentFirstLoaderPatterns(Configuration config) {
-String base = config.getString(ALWAYS_PARENT_FIRST_LOADER_PATTERNS);
-String append =
config.getString(ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL);
-return parseParentFirstLoaderPatterns(base, append);
+List base =
+ConfigUtils.decodeListFromConfig(
+config, ALWAYS_PARENT_FIRST_LOADER_PATTERNS,
String::new);
+List append =
+ConfigUtils.decodeListFromConfig(
+config,
ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL, String::new);
Review comment:
Updated
##
File path:
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
##
@@ -151,43 +177,50 @@
@Documentation.ExcludeFromDocumentation(
"Plugin classloader list is considered an implementation detail. "
+ "Configuration only included in case to mitigate
unintended side-effects of this young feature.")
-public static final ConfigOption
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
+public static final ConfigOption>
PLUGIN_ALWAYS_PARENT_FIRST_LOADER_PATTERNS =
ConfigOptions.key("plugin.classloader.parent-first-patterns.default")
.stringType()
-.defaultValue(
-"java.;org.apache.flink.;javax.annotation.;"
-+ PARENT_FIRST_LOGGING_PATTERNS)
+.asList()
+.defaultValues(
+mergeListsToArray(
+Arrays.asList(
+"java.", "org.apache.flink.",
"javax.annotation."),
+PARENT_FIRST_LOGGING_PATTERNS))
.withDescription(
-"A (semicolon-separated) list of patterns that
specifies which classes should always be"
+"A list of patterns that specifies which classes
should always be"
Review comment:
Sure, updated the description accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16821: [FLINK-23358][core] Refactor CoreOptions parent first patterns to List options
flinkbot edited a comment on pull request #16821: URL: https://github.com/apache/flink/pull/16821#issuecomment-898859870 ## CI report: * 0d243d7d843ca55c80d85ab48f12236203d86113 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22187) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22173) * 860f7acaf90b23fbff802792749ef1bd0479a414 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-21383) Docker image does not play well together with ConfigMap based flink-conf.yamls
[
https://issues.apache.org/jira/browse/FLINK-21383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426473#comment-17426473
]
Yang Wang commented on FLINK-21383:
---
[~dmvk] I am afraid this solution might also have some side effects. For
example, if we change the flink configuration ConfigMap, they will not be
updated automatically. A possible use case is changing the log level of some
specific package.
> Docker image does not play well together with ConfigMap based flink-conf.yamls
> --
>
> Key: FLINK-21383
> URL: https://issues.apache.org/jira/browse/FLINK-21383
> Project: Flink
> Issue Type: Bug
> Components: Deployment / Kubernetes, flink-docker
>Affects Versions: 1.11.3, 1.12.1, 1.13.0
>Reporter: Till Rohrmann
>Priority: Minor
> Labels: auto-deprioritized-major, usability
>
> Flink's Docker image does not play well together with ConfigMap based
> flink-conf.yamls. The {{docker-entrypoint.sh}} script offers a few env
> variables to overwrite configuration values (e.g. {{FLINK_PROPERTIES}},
> {{JOB_MANAGER_RPC_ADDRESS}}, etc.). The problem is that the entrypoint script
> assumes that it can modify the existing {{flink-conf.yaml}}. This is not the
> case if the {{flink-conf.yaml}} is based on a {{ConfigMap}}.
> Making things worse, failures updating the {{flink-conf.yaml}} are not
> reported. Moreover, the called {{jobmanager.sh}} and {{taskmanager.sh}}
> scripts don't support to pass in dynamic configuration properties into the
> processes.
> I think the problem is that our assumption that we can modify the
> {{flink-conf.yaml}} does not always hold true. If we updated the final
> configuration from within the Flink process (dynamic properties and env
> variables), then this problem could be avoided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-24122) Add support to do clean in history server
[
https://issues.apache.org/jira/browse/FLINK-24122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zlzhang0122 updated FLINK-24122:
Description:
Now, the history server can clean history jobs by two means:
# if users have configured
{code:java}
historyserver.archive.clean-expired-jobs: true{code}
, then compare the files in hdfs over two clean interval and find the delete
and clean the local cache file.
# if users have configured the
{code:java}
historyserver.archive.retained-jobs:{code}
a positive number, then clean the oldest files in hdfs and local.
But the retained-jobs number is difficult to determine.
For example, users may want to check the history jobs yesterday while many jobs
failed today and exceed the retained-jobs number, then the history jobs of
yesterday will be delete. So what if add a configuration which contain a
retained-times that indicate the max time the history job retain?
was:
Now, the history server can clean history jobs by two means:
# if users have configured
{code:java}
historyserver.archive.clean-expired-jobs: true{code}
, then compare the files in hdfs over two clean interval and find the delete
and clean the local cache file.
# if users have configured the
{code:java}
historyserver.archive.retained-jobs{code}
a positive number, then clean the oldest files in hdfs and local.
But it can't clean the job history which was no longer in hdfs but still cached
in local filesystem and these files will store forever and can't be cleaned
unless users manually do this. Maybe we can give a option and do this clean if
the option says true.
> Add support to do clean in history server
> -
>
> Key: FLINK-24122
> URL: https://issues.apache.org/jira/browse/FLINK-24122
> Project: Flink
> Issue Type: Bug
> Components: Runtime / REST
>Affects Versions: 1.12.3, 1.13.2
>Reporter: zlzhang0122
>Priority: Minor
> Fix For: 1.14.1
>
>
> Now, the history server can clean history jobs by two means:
> # if users have configured
> {code:java}
> historyserver.archive.clean-expired-jobs: true{code}
> , then compare the files in hdfs over two clean interval and find the delete
> and clean the local cache file.
> # if users have configured the
> {code:java}
> historyserver.archive.retained-jobs:{code}
> a positive number, then clean the oldest files in hdfs and local.
> But the retained-jobs number is difficult to determine.
> For example, users may want to check the history jobs yesterday while many
> jobs failed today and exceed the retained-jobs number, then the history jobs
> of yesterday will be delete. So what if add a configuration which contain a
> retained-times that indicate the max time the history job retain?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] wuchong commented on a change in pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
wuchong commented on a change in pull request #17438:
URL: https://github.com/apache/flink/pull/17438#discussion_r725427333
##
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/AbstractCatalogTable.java
##
@@ -37,18 +39,18 @@
// Properties of the table
private final Map options;
// Comment of the table
-private final String comment;
+@Nullable private final String comment;
public AbstractCatalogTable(
-TableSchema tableSchema, Map options, String
comment) {
+TableSchema tableSchema, Map options, @Nullable
String comment) {
this(tableSchema, new ArrayList<>(), options, comment);
}
public AbstractCatalogTable(
TableSchema tableSchema,
List partitionKeys,
Map options,
-String comment) {
+@Nullable String comment) {
Review comment:
According to the Javadoc of `getComment()`, it doesn't say the return
value can be null. There is no `@Nullable` annotation on the return type as
well. The default implementation of `CatalogTable#getComment` and
`CatalogView#getComment` (`DefaultCatalogTable`, `DefaultCatalogView`) returns
empty string instead of null.
Therefore, would be better to return `comment != null ? comment : ""` in
`AbstractCatalogTable#getComment` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (FLINK-24480) EqualiserCodeGeneratorTest fails on azure
[
https://issues.apache.org/jira/browse/FLINK-24480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426472#comment-17426472
]
Xintong Song commented on FLINK-24480:
--
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24880=logs=955770d3-1fed-5a0a-3db6-0c7554c910cb=14447d61-56b4-5000-80c1-daa459247f6a=42615
> EqualiserCodeGeneratorTest fails on azure
> -
>
> Key: FLINK-24480
> URL: https://issues.apache.org/jira/browse/FLINK-24480
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.12.5, 1.13.2
>Reporter: Xintong Song
>Priority: Major
> Labels: test-stability
> Fix For: 1.12.6, 1.13.3
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24809=logs=955770d3-1fed-5a0a-3db6-0c7554c910cb=14447d61-56b4-5000-80c1-daa459247f6a=42615
> {code}
> Oct 07 01:11:46 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0,
> Time elapsed: 8.236 s <<< FAILURE! - in
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest
> Oct 07 01:11:46 [ERROR]
> testManyFields(org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest)
> Time elapsed: 8.21 s <<< FAILURE!
> Oct 07 01:11:46 java.lang.AssertionError: Expected compilation to succeed
> Oct 07 01:11:46 at org.junit.Assert.fail(Assert.java:88)
> Oct 07 01:11:46 at
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest.testManyFields(EqualiserCodeGeneratorTest.java:102)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] wuchong commented on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
wuchong commented on pull request #17438: URL: https://github.com/apache/flink/pull/17438#issuecomment-939218504 The build is failed because of wrong code format. You can [setup the code formatting plugin](https://nightlies.apache.org/flink/flink-docs-master/docs/flinkdev/ide_setup/#code-formatting), so that they can be fixed when developing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-24489) The size of entryCache in the SharedBuffer should be defined with a threshold
[ https://issues.apache.org/jira/browse/FLINK-24489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roc Marshal updated FLINK-24489: Affects Version/s: 1.11.0 1.12.0 1.13.0 1.14.0 > The size of entryCache in the SharedBuffer should be defined with a threshold > - > > Key: FLINK-24489 > URL: https://issues.apache.org/jira/browse/FLINK-24489 > Project: Flink > Issue Type: Improvement > Components: Library / CEP >Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0 >Reporter: Roc Marshal >Priority: Major > > [here|https://github.com/apache/flink/blob/c3cb886ee73b5fee23b2bccff0f5e4d45a30b3a1/flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java#L79] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-24489) The size of entryCache in the SharedBuffer should be defined with a threshold
Roc Marshal created FLINK-24489: --- Summary: The size of entryCache in the SharedBuffer should be defined with a threshold Key: FLINK-24489 URL: https://issues.apache.org/jira/browse/FLINK-24489 Project: Flink Issue Type: Improvement Components: Library / CEP Affects Versions: 1.10.0 Reporter: Roc Marshal [here|https://github.com/apache/flink/blob/c3cb886ee73b5fee23b2bccff0f5e4d45a30b3a1/flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java#L79] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24480) EqualiserCodeGeneratorTest fails on azure
[
https://issues.apache.org/jira/browse/FLINK-24480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426460#comment-17426460
]
Jark Wu commented on FLINK-24480:
-
[~airblader] could you help to have a look at this?
> EqualiserCodeGeneratorTest fails on azure
> -
>
> Key: FLINK-24480
> URL: https://issues.apache.org/jira/browse/FLINK-24480
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.12.5, 1.13.2
>Reporter: Xintong Song
>Priority: Major
> Labels: test-stability
> Fix For: 1.12.6, 1.13.3
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24809=logs=955770d3-1fed-5a0a-3db6-0c7554c910cb=14447d61-56b4-5000-80c1-daa459247f6a=42615
> {code}
> Oct 07 01:11:46 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0,
> Time elapsed: 8.236 s <<< FAILURE! - in
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest
> Oct 07 01:11:46 [ERROR]
> testManyFields(org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest)
> Time elapsed: 8.21 s <<< FAILURE!
> Oct 07 01:11:46 java.lang.AssertionError: Expected compilation to succeed
> Oct 07 01:11:46 at org.junit.Assert.fail(Assert.java:88)
> Oct 07 01:11:46 at
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest.testManyFields(EqualiserCodeGeneratorTest.java:102)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-24351) translate "JSON Function" pages into Chinese
[
https://issues.apache.org/jira/browse/FLINK-24351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426459#comment-17426459
]
Jark Wu commented on FLINK-24351:
-
[~monster#12] you need to translate {{sql_functions_zh.yml}} (it has been
partially translated).
> translate "JSON Function" pages into Chinese
> -
>
> Key: FLINK-24351
> URL: https://issues.apache.org/jira/browse/FLINK-24351
> Project: Flink
> Issue Type: Sub-task
> Components: Documentation
>Reporter: liwei li
>Assignee: ZhuoYu Chen
>Priority: Major
> Attachments: 微信图片_20211009105019.png
>
>
> translate "JSON Function" pages into Chinese,
> docs/data/sql_functions_zh.yml
>
> https://github.com/apache/flink/pull/17275#issuecomment-924536467
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-24480) EqualiserCodeGeneratorTest fails on azure
[
https://issues.apache.org/jira/browse/FLINK-24480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426457#comment-17426457
]
Xintong Song commented on FLINK-24480:
--
cc [~twalthr] [~jark]
> EqualiserCodeGeneratorTest fails on azure
> -
>
> Key: FLINK-24480
> URL: https://issues.apache.org/jira/browse/FLINK-24480
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.12.5, 1.13.2
>Reporter: Xintong Song
>Priority: Major
> Labels: test-stability
> Fix For: 1.12.6, 1.13.3
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24809=logs=955770d3-1fed-5a0a-3db6-0c7554c910cb=14447d61-56b4-5000-80c1-daa459247f6a=42615
> {code}
> Oct 07 01:11:46 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0,
> Time elapsed: 8.236 s <<< FAILURE! - in
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest
> Oct 07 01:11:46 [ERROR]
> testManyFields(org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest)
> Time elapsed: 8.21 s <<< FAILURE!
> Oct 07 01:11:46 java.lang.AssertionError: Expected compilation to succeed
> Oct 07 01:11:46 at org.junit.Assert.fail(Assert.java:88)
> Oct 07 01:11:46 at
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest.testManyFields(EqualiserCodeGeneratorTest.java:102)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FLINK-22096) ServerTransportErrorHandlingTest.testRemoteClose fail
[
https://issues.apache.org/jira/browse/FLINK-22096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guowei Ma reassigned FLINK-22096:
-
Assignee: Yuxin Tan
> ServerTransportErrorHandlingTest.testRemoteClose fail
> --
>
> Key: FLINK-22096
> URL: https://issues.apache.org/jira/browse/FLINK-22096
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Network
>Affects Versions: 1.13.0, 1.14.0, 1.15.0
>Reporter: Guowei Ma
>Assignee: Yuxin Tan
>Priority: Major
> Labels: test-stability
> Fix For: 1.13.3, 1.15.0, 1.14.1
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15966=logs=0da23115-68bb-5dcd-192c-bd4c8adebde1=05b74a19-4ee4-5036-c46f-ada307df6cf0=6580
> {code:java}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.415
> s <<< FAILURE! - in
> org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest
> [ERROR]
> testRemoteClose(org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest)
> Time elapsed: 1.338 s <<< ERROR!
> org.apache.flink.shaded.netty4.io.netty.channel.unix.Errors$NativeIoException:
> bind(..) failed: Address already in use
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-24390) Python 'build_wheels mac' fails on azure
[ https://issues.apache.org/jira/browse/FLINK-24390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426453#comment-17426453 ] Xintong Song commented on FLINK-24390: -- https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24879=logs=33dd8067-7758-552f-a1cf-a8b8ff0e44cd=789348ee-cf3e-5c4b-7c78-355970e5f360=27869 > Python 'build_wheels mac' fails on azure > > > Key: FLINK-24390 > URL: https://issues.apache.org/jira/browse/FLINK-24390 > Project: Flink > Issue Type: Bug > Components: API / Python, Build System >Affects Versions: 1.12.5 >Reporter: Xintong Song >Assignee: Dian Fu >Priority: Blocker > Labels: pull-request-available > Fix For: 1.12.6 > > > https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24547=logs=33dd8067-7758-552f-a1cf-a8b8ff0e44cd=789348ee-cf3e-5c4b-7c78-355970e5f360=17982 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24480) EqualiserCodeGeneratorTest fails on azure
[
https://issues.apache.org/jira/browse/FLINK-24480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426452#comment-17426452
]
Xintong Song commented on FLINK-24480:
--
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24879=logs=955770d3-1fed-5a0a-3db6-0c7554c910cb=14447d61-56b4-5000-80c1-daa459247f6a=42433
> EqualiserCodeGeneratorTest fails on azure
> -
>
> Key: FLINK-24480
> URL: https://issues.apache.org/jira/browse/FLINK-24480
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.12.5, 1.13.2
>Reporter: Xintong Song
>Priority: Major
> Labels: test-stability
> Fix For: 1.12.6, 1.13.3
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24809=logs=955770d3-1fed-5a0a-3db6-0c7554c910cb=14447d61-56b4-5000-80c1-daa459247f6a=42615
> {code}
> Oct 07 01:11:46 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0,
> Time elapsed: 8.236 s <<< FAILURE! - in
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest
> Oct 07 01:11:46 [ERROR]
> testManyFields(org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest)
> Time elapsed: 8.21 s <<< FAILURE!
> Oct 07 01:11:46 java.lang.AssertionError: Expected compilation to succeed
> Oct 07 01:11:46 at org.junit.Assert.fail(Assert.java:88)
> Oct 07 01:11:46 at
> org.apache.flink.table.planner.codegen.EqualiserCodeGeneratorTest.testManyFields(EqualiserCodeGeneratorTest.java:102)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-23493) python tests hang on Azure
[ https://issues.apache.org/jira/browse/FLINK-23493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426450#comment-17426450 ] Xintong Song commented on FLINK-23493: -- https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=24879=logs=821b528f-1eed-5598-a3b4-7f748b13f261=4fad9527-b9a5-5015-1b70-8356e5c91490=21965 > python tests hang on Azure > -- > > Key: FLINK-23493 > URL: https://issues.apache.org/jira/browse/FLINK-23493 > Project: Flink > Issue Type: Bug > Components: API / Python >Affects Versions: 1.14.0, 1.13.1, 1.12.4, 1.15.0 >Reporter: Dawid Wysakowicz >Assignee: Huang Xingbo >Priority: Blocker > Labels: test-stability > Fix For: 1.15.0, 1.14.1 > > > https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=20898=logs=821b528f-1eed-5598-a3b4-7f748b13f261=4fad9527-b9a5-5015-1b70-8356e5c91490=22829 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-22096) ServerTransportErrorHandlingTest.testRemoteClose fail
[
https://issues.apache.org/jira/browse/FLINK-22096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426451#comment-17426451
]
Guowei Ma commented on FLINK-22096:
---
Thank [~tanyuxin] for your attention. I will assign this jira to you, please
feel free to contact me if you have any questions
> ServerTransportErrorHandlingTest.testRemoteClose fail
> --
>
> Key: FLINK-22096
> URL: https://issues.apache.org/jira/browse/FLINK-22096
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Network
>Affects Versions: 1.13.0, 1.14.0, 1.15.0
>Reporter: Guowei Ma
>Priority: Major
> Labels: test-stability
> Fix For: 1.13.3, 1.15.0, 1.14.1
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15966=logs=0da23115-68bb-5dcd-192c-bd4c8adebde1=05b74a19-4ee4-5036-c46f-ada307df6cf0=6580
> {code:java}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.415
> s <<< FAILURE! - in
> org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest
> [ERROR]
> testRemoteClose(org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest)
> Time elapsed: 1.338 s <<< ERROR!
> org.apache.flink.shaded.netty4.io.netty.channel.unix.Errors$NativeIoException:
> bind(..) failed: Address already in use
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-24351) translate "JSON Function" pages into Chinese
[
https://issues.apache.org/jira/browse/FLINK-24351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426448#comment-17426448
]
ZhuoYu Chen commented on FLINK-24351:
-
Hi [~jark] ,{color:#33}Do I understand this correctly{color}?
!微信图片_20211009105019.png!
> translate "JSON Function" pages into Chinese
> -
>
> Key: FLINK-24351
> URL: https://issues.apache.org/jira/browse/FLINK-24351
> Project: Flink
> Issue Type: Sub-task
> Components: Documentation
>Reporter: liwei li
>Assignee: ZhuoYu Chen
>Priority: Major
> Attachments: 微信图片_20211009105019.png
>
>
> translate "JSON Function" pages into Chinese,
> docs/data/sql_functions_zh.yml
>
> https://github.com/apache/flink/pull/17275#issuecomment-924536467
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-24351) translate "JSON Function" pages into Chinese
[ https://issues.apache.org/jira/browse/FLINK-24351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhuoYu Chen updated FLINK-24351: Attachment: 微信图片_20211009105019.png > translate "JSON Function" pages into Chinese > - > > Key: FLINK-24351 > URL: https://issues.apache.org/jira/browse/FLINK-24351 > Project: Flink > Issue Type: Sub-task > Components: Documentation >Reporter: liwei li >Assignee: ZhuoYu Chen >Priority: Major > Attachments: 微信图片_20211009105019.png > > > translate "JSON Function" pages into Chinese, > docs/data/sql_functions_zh.yml > > https://github.com/apache/flink/pull/17275#issuecomment-924536467 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink-ml] yunfengzhou-hub commented on a change in pull request #14: [FLINK-8][iteration] Add per-round operator wrappers
yunfengzhou-hub commented on a change in pull request #14: URL: https://github.com/apache/flink-ml/pull/14#discussion_r725419380 ## File path: flink-ml-iteration/src/main/java/org/apache/flink/ml/iteration/operator/perrond/MultipleInputPerRoundWrapperOperator.java ## @@ -0,0 +1,131 @@ +/* Review comment: There's a typo in the name of the folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-22096) ServerTransportErrorHandlingTest.testRemoteClose fail
[
https://issues.apache.org/jira/browse/FLINK-22096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426446#comment-17426446
]
Yuxin Tan commented on FLINK-22096:
---
Hi, I want to take a look at this test issue. Could someone help assign it to
me? :D
> ServerTransportErrorHandlingTest.testRemoteClose fail
> --
>
> Key: FLINK-22096
> URL: https://issues.apache.org/jira/browse/FLINK-22096
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Network
>Affects Versions: 1.13.0, 1.14.0, 1.15.0
>Reporter: Guowei Ma
>Priority: Major
> Labels: test-stability
> Fix For: 1.13.3, 1.15.0, 1.14.1
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=15966=logs=0da23115-68bb-5dcd-192c-bd4c8adebde1=05b74a19-4ee4-5036-c46f-ada307df6cf0=6580
> {code:java}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.415
> s <<< FAILURE! - in
> org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest
> [ERROR]
> testRemoteClose(org.apache.flink.runtime.io.network.netty.ServerTransportErrorHandlingTest)
> Time elapsed: 1.338 s <<< ERROR!
> org.apache.flink.shaded.netty4.io.netty.channel.unix.Errors$NativeIoException:
> bind(..) failed: Address already in use
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (FLINK-23458) Document required number of buffers in the network stack
[
https://issues.apache.org/jira/browse/FLINK-23458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song closed FLINK-23458.
Resolution: Fixed
Chinese docs merged via:
- master (1.15): c3cb886ee73b5fee23b2bccff0f5e4d45a30b3a1
- release-1.14: 8686ee33283aa2b7cf12a93aa1c0fc76aaeba675
> Document required number of buffers in the network stack
>
>
> Key: FLINK-23458
> URL: https://issues.apache.org/jira/browse/FLINK-23458
> Project: Flink
> Issue Type: Sub-task
> Components: Documentation, Runtime / Network
>Affects Versions: 1.11.4, 1.14.0, 1.12.5, 1.13.2
>Reporter: Anton Kalashnikov
>Assignee: Anton Kalashnikov
>Priority: Critical
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Currently it seems that it's not mentioned anywhere what's the number of
> required number of buffers. And that this number is different than the
> configured number of exclusive/floating buffers. It should be mentioned in
> that both {{taskmanager.network.memory.floating-buffers-per-gate}} and
> {{taskmanager.network.memory.buffers-per-channel}} are best effort and not
> guaranteed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] xintongsong closed pull request #17435: [FLINK-23458][docs] Added the network buffer documentation along wit…
xintongsong closed pull request #17435: URL: https://github.com/apache/flink/pull/17435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-18234) Implicit type conversion in join condition
[
https://issues.apache.org/jira/browse/FLINK-18234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426438#comment-17426438
]
xuyangzhong commented on FLINK-18234:
-
I'll try to fix this bug
> Implicit type conversion in join condition
> --
>
> Key: FLINK-18234
> URL: https://issues.apache.org/jira/browse/FLINK-18234
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
>Affects Versions: 1.10.1
>Reporter: YufeiLiu
>Priority: Minor
> Labels: auto-deprioritized-major
>
> Execute sql "SELECT a1, b1 FROM A JOIN B ON a2 = b4", a2(BIGINT) b4(VARCHAR)
> will throw exception
> {code}
> org.apache.flink.table.api.TableException: VARCHAR(2147483647) and INTEGER
> does not have common type now
> at
> org.apache.flink.table.planner.plan.rules.logical.JoinConditionTypeCoerceRule$$anonfun$onMatch$1.apply(JoinConditionTypeCoerceRule.scala:76)
> at
> org.apache.flink.table.planner.plan.rules.logical.JoinConditionTypeCoerceRule$$anonfun$onMatch$1.apply(JoinConditionTypeCoerceRule.scala:65)
> at scala.collection.Iterator$class.foreach(Iterator.scala:891)
> at scala.collection.AbstractIterator.foreach(Iterator.scala:1334)
> at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
> at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
> at
> org.apache.flink.table.planner.plan.rules.logical.JoinConditionTypeCoerceRule.onMatch(JoinConditionTypeCoerceRule.scala:65)
> at
> org.apache.calcite.plan.AbstractRelOptPlanner.fireRule(AbstractRelOptPlanner.java:328)
> at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:562)
> at
> org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:427)
> at
> org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:264)
> at
> org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:127)
> at
> org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:223)
> at
> org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:210)
> at
> org.apache.flink.table.planner.plan.optimize.program.FlinkHepProgram.optimize(FlinkHepProgram.scala:69)
> {code}
> Should we do some implicit type coercion in this case? It works on old
> version, and also can use in WHERE condition like "WHERE a4 = 3"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * bdce7016a9c5b7c806b22427e5fb9836c9052842 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17442: [hotfix] Fixed Savepoint Documentation Typo
flinkbot edited a comment on pull request #17442: URL: https://github.com/apache/flink/pull/17442#issuecomment-939054254 ## CI report: * 36632b52a26b854902cb6911d7dd7c7a203031a2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24875) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-24437) Remove unhandled exception handler from CuratorFramework before closing it
[
https://issues.apache.org/jira/browse/FLINK-24437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-24437.
-
Resolution: Fixed
Fixed via
1.15.0: 43ff97396dd6c6d68cef5d8f57ff1685c6e276b4
1.14.1: a25b12552550a99c0332ae2352314b06250737e7
> Remove unhandled exception handler from CuratorFramework before closing it
> --
>
> Key: FLINK-24437
> URL: https://issues.apache.org/jira/browse/FLINK-24437
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Coordination
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Till Rohrmann
>Assignee: Aitozi
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0, 1.14.1
>
>
> With FLINK-24021 we add an unhandled exception handler to the started
> {{CuratorFramework}}. In order to avoid that shutting down the
> {{CuratorFramework}} causes triggering of this handler, we should unregister
> it before closing the {{CuratorFramework}} instance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] tillrohrmann merged pull request #17432: [BP-1.14][FLINK-24437][HA]Remove unhandled exception handler from CuratorFramework before closing it
tillrohrmann merged pull request #17432: URL: https://github.com/apache/flink/pull/17432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tillrohrmann merged pull request #17409: [FLINK-24437][HA]Remove unhandled exception handler from CuratorFrame…
tillrohrmann merged pull request #17409: URL: https://github.com/apache/flink/pull/17409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client
flinkbot edited a comment on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 37cf758d9eaf3ee1a1f6342714abd14ae8d80ea9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24871) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17442: [hotfix] Fixed Savepoint Documentation Typo
flinkbot edited a comment on pull request #17442: URL: https://github.com/apache/flink/pull/17442#issuecomment-939054254 ## CI report: * 36632b52a26b854902cb6911d7dd7c7a203031a2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24875) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17432: [BP-1.14][FLINK-24437][HA]Remove unhandled exception handler from CuratorFramework before closing it
flinkbot edited a comment on pull request #17432: URL: https://github.com/apache/flink/pull/17432#issuecomment-938518119 ## CI report: * a25b12552550a99c0332ae2352314b06250737e7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24870) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17409: [FLINK-24437][HA]Remove unhandled exception handler from CuratorFrame…
flinkbot edited a comment on pull request #17409: URL: https://github.com/apache/flink/pull/17409#issuecomment-933172900 ## CI report: * 32134dcbacd6da84b671bbdd53bbb6ad1f637060 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24869) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17442: [hotfix] Fixed Savepoint Documentation Typo
flinkbot commented on pull request #17442: URL: https://github.com/apache/flink/pull/17442#issuecomment-939054254 ## CI report: * 36632b52a26b854902cb6911d7dd7c7a203031a2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17442: [hotfix] Fixed Savepoint Documentation Typo
flinkbot commented on pull request #17442: URL: https://github.com/apache/flink/pull/17442#issuecomment-939032697 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 36632b52a26b854902cb6911d7dd7c7a203031a2 (Fri Oct 08 18:20:51 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] rionmonster opened a new pull request #17442: [hotfix] Fixed Savepoint Documentation Typo
rionmonster opened a new pull request #17442: URL: https://github.com/apache/flink/pull/17442 ## What is the purpose of the change Fixed a minor typo within the Savepoints documentation to avoid referencing a class/object that doesn't exist due to a typo. ## Brief change log Updated both Savepoint-related doc pages (context/context.zh) to reflect the change. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
flinkbot edited a comment on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * bdce7016a9c5b7c806b22427e5fb9836c9052842 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24873) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean
flinkbot edited a comment on pull request #17439: URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330 ## CI report: * b5929ea88fffdb3c019dce8034cd540ded7ac025 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-9465) Specify a separate savepoint timeout option via CLI
[ https://issues.apache.org/jira/browse/FLINK-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426306#comment-17426306 ] Feifan Wang commented on FLINK-9465: Hi [~trohrmann], thanks for introduce FLINK-15787, I very agree after reading. Finally, I will name it "savepointTimeout" in all above four place. > Specify a separate savepoint timeout option via CLI > --- > > Key: FLINK-9465 > URL: https://issues.apache.org/jira/browse/FLINK-9465 > Project: Flink > Issue Type: Improvement > Components: Runtime / Checkpointing >Affects Versions: 1.5.0 >Reporter: Truong Duc Kien >Assignee: Feifan Wang >Priority: Minor > Labels: auto-deprioritized-major, pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Savepoint can take much longer time to perform than checkpoint, especially > with incremental checkpoint enabled. This leads to a couple of troubles: > * For our job, we currently have to set the checkpoint timeout much large > than necessary, otherwise we would be unable to perform savepoint. > * During rush hour, our cluster would encounter high rate of checkpoint > timeout due to backpressure, however we're unable to migrate to a larger > configuration, because savepoint also timeout. > In my opinion, the timeout for savepoint should be configurable separately, > both in the config file and as parameter to the savepoint command. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
flinkbot commented on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938905036 ## CI report: * bdce7016a9c5b7c806b22427e5fb9836c9052842 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client
flinkbot edited a comment on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 37cf758d9eaf3ee1a1f6342714abd14ae8d80ea9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24871) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
flinkbot edited a comment on pull request #17438: URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309 ## CI report: * 82cfa4deb7c10c8214e2138aa95332bad4ade3d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-24229) [FLIP-171] DynamoDB implementation of Async Sink
[
https://issues.apache.org/jira/browse/FLINK-24229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426280#comment-17426280
]
Zichen Liu commented on FLINK-24229:
Hi [~Gusev],
Apologies for the late reply, just returned recently. Glad to see there is
demand for a DynamoDB Sink for Flink!
I have completed the implementation of the generic Async Sink and have merged
it in at FLINK-24041. However I have not yet started the implementation of the
DynamoDB sink at all. Your implementation and tests looks detailed, and I don't
think it will be much work to adapt it to use the Async Sink base.
Would you like to give this a go? I would be happy to help in the effort.
Regards
Zichen
> [FLIP-171] DynamoDB implementation of Async Sink
>
>
> Key: FLINK-24229
> URL: https://issues.apache.org/jira/browse/FLINK-24229
> Project: Flink
> Issue Type: New Feature
> Components: Connectors / Common
>Reporter: Zichen Liu
>Assignee: Zichen Liu
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> h2. Motivation
> *User stories:*
> As a Flink user, I’d like to use DynamoDB as sink for my data pipeline.
> *Scope:*
> * Implement an asynchronous sink for DynamoDB by inheriting the
> AsyncSinkBase class. The implementation can for now reside in its own module
> in flink-connectors.
> * Implement an asynchornous sink writer for DynamoDB by extending the
> AsyncSinkWriter. The implementation must deal with failed requests and retry
> them using the {{requeueFailedRequestEntry}} method. If possible, the
> implementation should batch multiple requests (PutRecordsRequestEntry
> objects) to Firehose for increased throughput. The implemented Sink Writer
> will be used by the Sink class that will be created as part of this story.
> * Java / code-level docs.
> * End to end testing: add tests that hits a real AWS instance. (How to best
> donate resources to the Flink project to allow this to happen?)
> h2. References
> More details to be found
> [https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-9465) Specify a separate savepoint timeout option via CLI
[
https://issues.apache.org/jira/browse/FLINK-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426276#comment-17426276
]
Till Rohrmann commented on FLINK-9465:
--
Hi [~Feifan Wang], sorry for my late reply. I think we should use camel case
for the parameter. I think we have agreed on this in FLINK-15787. For the CLI
we should also name it {{savepointTimeout}}.
> Specify a separate savepoint timeout option via CLI
> ---
>
> Key: FLINK-9465
> URL: https://issues.apache.org/jira/browse/FLINK-9465
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
>Affects Versions: 1.5.0
>Reporter: Truong Duc Kien
>Assignee: Feifan Wang
>Priority: Minor
> Labels: auto-deprioritized-major, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Savepoint can take much longer time to perform than checkpoint, especially
> with incremental checkpoint enabled. This leads to a couple of troubles:
> * For our job, we currently have to set the checkpoint timeout much large
> than necessary, otherwise we would be unable to perform savepoint.
> * During rush hour, our cluster would encounter high rate of checkpoint
> timeout due to backpressure, however we're unable to migrate to a larger
> configuration, because savepoint also timeout.
> In my opinion, the timeout for savepoint should be configurable separately,
> both in the config file and as parameter to the savepoint command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client
flinkbot commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938816662 ## CI report: * 37cf758d9eaf3ee1a1f6342714abd14ae8d80ea9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException
flinkbot edited a comment on pull request #17436: URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830 ## CI report: * d14a0793a2628a8c9bd778ccbee95e7419f15346 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
flinkbot edited a comment on pull request #17437: URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904 ## CI report: * fbfc14527fed6e285c2d65460cc317b10e5e2e94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17432: [BP-1.14][FLINK-24437][HA]Remove unhandled exception handler from CuratorFramework before closing it
flinkbot edited a comment on pull request #17432: URL: https://github.com/apache/flink/pull/17432#issuecomment-938518119 ## CI report: * 290a87fa7651f82792867a9c726a55d262de53ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24848) * a25b12552550a99c0332ae2352314b06250737e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24870) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17411: [FLINK-17914][hs] Keep archives if listStatus fails
flinkbot edited a comment on pull request #17411: URL: https://github.com/apache/flink/pull/17411#issuecomment-933425378 ## CI report: * 82b3677bc3eb9173a146217c1644854ede7cdd02 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24856) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17409: [FLINK-24437][HA]Remove unhandled exception handler from CuratorFrame…
flinkbot edited a comment on pull request #17409: URL: https://github.com/apache/flink/pull/17409#issuecomment-933172900 ## CI report: * 9323e4c49b91acff900ab3cbd517521fe3628dc6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24839) * 32134dcbacd6da84b671bbdd53bbb6ad1f637060 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24869) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
flinkbot commented on pull request #17441: URL: https://github.com/apache/flink/pull/17441#issuecomment-938797507 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit bdce7016a9c5b7c806b22427e5fb9836c9052842 (Fri Oct 08 16:30:19 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-24461) TableResult#print() should use internal data types
[
https://issues.apache.org/jira/browse/FLINK-24461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-24461:
---
Labels: pull-request-available (was: )
> TableResult#print() should use internal data types
> --
>
> Key: FLINK-24461
> URL: https://issues.apache.org/jira/browse/FLINK-24461
> Project: Flink
> Issue Type: Sub-task
>Reporter: Francesco Guardiani
>Assignee: Francesco Guardiani
>Priority: Major
> Labels: pull-request-available
>
> The collector used by {{TableResult#print()}} should use internal data types
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] slinkydeveloper opened a new pull request #17441: [FLINK-24461][table] PrintUtils common now accepts only internal data types
slinkydeveloper opened a new pull request #17441: URL: https://github.com/apache/flink/pull/17441 ## What is the purpose of the change This PR is part of the issue https://issues.apache.org/jira/browse/FLINK-21456 to unify the string conversion logic for the SQL data types. This PR changes the `PrintUtils` methods to make them accept only internal data types. In order to do that, several changes were required, in particular inside sql client which is mainly using external data types, but then relies heavily on `PrintUtils` for the print to screen logic. Next PRs will take care of cleaning up the logic of `PrintUtils`. ## Brief change log - Introduce `TableResultInternal` to expose an iterator for internal types, and use it in return types of `TableEnvironmentInternal` - Modified the collector sink in order to emit data using internal data types - Support both internal and external types in `CollectResultProvider` (renamed to `ResultProvider`) - Migrated most of the internal `Row` usages in common, api and sql client to `RowData`. No public API is affected. ## Verifying this change This change is already covered by tests in table common and sql client. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] lindong28 edited a comment on pull request #17342: [FLINK-20928] Fix flaky test by retrying notifyCheckpointComplete until either commit success or timeout
lindong28 edited a comment on pull request #17342: URL: https://github.com/apache/flink/pull/17342#issuecomment-938773651 @AHeise Thank you for helping review the PR. This PR just fixes a flaky test. Does this need to be backported? I am happy to create backport PRs. I have not done this before. Could you let me know which branches need to have this backport PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] lindong28 commented on pull request #17342: [FLINK-20928] Fix flaky test by retrying notifyCheckpointComplete until either commit success or timeout
lindong28 commented on pull request #17342: URL: https://github.com/apache/flink/pull/17342#issuecomment-938773651 @AHeise Thank you for helping review the PR. This PR just fixes a flaky test. Does this need to be backported? I am happy to create backport PRs. I have not done this before. Could you let me know which branches need to have this backport PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-22533) Allow creating custom metrics
[
https://issues.apache.org/jira/browse/FLINK-22533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426259#comment-17426259
]
Nicolas Ferrario commented on FLINK-22533:
--
Hi [~igal], I just tested it and it looks awesome! That's exactly what we
needed.
One more thing we would like to have is the ability to use these metrics on
StatefulFunctionModule. We have some filter logic there to ignore invalid
events before they are sent over the network to some function.
I understand that may go against Statefun's goal, and it may end up looking
like a hack, so I'd definitely understand if this proposal is rejected.
For example, this is our code (in Kotlin ), where _stats_ is a Statsd client:
{code:java}
binder.bindIngressRouter(myIngress) { message, downstream ->
if (message.isValid && message.auctionId > 0) {
downstream.forward(Identifiers.storageType,
message.auctionId.toString(), message)
} else {
stats.incrementCounter("invalid-events")
}
}
{code}
> Allow creating custom metrics
> -
>
> Key: FLINK-22533
> URL: https://issues.apache.org/jira/browse/FLINK-22533
> Project: Flink
> Issue Type: Improvement
> Components: Stateful Functions
>Reporter: Igal Shilman
>Assignee: Igal Shilman
>Priority: Minor
> Labels: auto-deprioritized-major
>
> Currently it is not possible to create custom metrics in StateFun.
> Let us consider supporting these.
>
> Mailing list thread:
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Custom-metrics-in-Stateful-Functions-td43282.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on pull request #17432: [BP-1.14][FLINK-24437][HA]Remove unhandled exception handler from CuratorFramework before closing it
flinkbot edited a comment on pull request #17432: URL: https://github.com/apache/flink/pull/17432#issuecomment-938518119 ## CI report: * 290a87fa7651f82792867a9c726a55d262de53ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24848) * a25b12552550a99c0332ae2352314b06250737e7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17409: [FLINK-24437][HA]Remove unhandled exception handler from CuratorFrame…
flinkbot edited a comment on pull request #17409: URL: https://github.com/apache/flink/pull/17409#issuecomment-933172900 ## CI report: * 9323e4c49b91acff900ab3cbd517521fe3628dc6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24839) * 32134dcbacd6da84b671bbdd53bbb6ad1f637060 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17374: [FLINK-24327][connectors/elasticsearch] Add Elasticsearch 7 sink for table API
flinkbot edited a comment on pull request #17374: URL: https://github.com/apache/flink/pull/17374#issuecomment-929172201 ## CI report: * 31611e7f965e7a9d89ee79e770b5c484221f2163 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24855) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-21383) Docker image does not play well together with ConfigMap based flink-conf.yamls
[
https://issues.apache.org/jira/browse/FLINK-21383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426252#comment-17426252
]
David Morávek commented on FLINK-21383:
---
Possible workaround is to tweak the Kubernetes deployment manifest to create a
mutable copy of the mounted ConfigMap in InitContainer. I think this may
actually not be a workaround but the correct approach. Example:
{code:java}
kind: Deployment
metadata:
name: flink-taskmanager
spec:
replicas: 2
selector:
matchLabels:
app: flink
component: taskmanager
template:
metadata:
labels:
app: flink
component: taskmanager
spec:
containers:
- name: taskmanager
image: apache/flink:1.14.0-scala_2.12-java8
env:
- name: JOB_MANAGER_RPC_ADDRESS
value: flink-jobmanager
- name: TASK_MANAGER_NUMBER_OF_TASK_SLOTS
value: "2"
args: ["taskmanager"]
ports:
- containerPort: 6122
name: rpc
- containerPort: 6125
name: query-state
livenessProbe:
tcpSocket:
port: 6122
initialDelaySeconds: 30
periodSeconds: 60
volumeMounts:
- name: flink-config-volume
mountPath: /opt/flink/conf
- name: job-artifacts-volume
mountPath: /opt/flink/usrlib
securityContext:
runAsUser:
initContainers:
- name: init-conf-directory
image: busybox:stable
command: ['sh', '-c', 'cp -L /opt/flink/conf-readonly/* /opt/flink/conf
&& chown -R : /opt/flink/conf']
volumeMounts:
- name: flink-config-volume
mountPath: /opt/flink/conf
- name: flink-config-readonly-volume
mountPath: /opt/flink/conf-readonly
volumes:
- name: flink-config-volume
emptyDir: {}
- name: flink-config-readonly-volume
configMap:
name: flink-config
items:
- key: flink-conf.yaml
path: flink-conf.yaml
- key: log4j-console.properties
path: log4j-console.properties
- name: job-artifacts-volume
hostPath:
path: /opt/usrlib
{code}
> Docker image does not play well together with ConfigMap based flink-conf.yamls
> --
>
> Key: FLINK-21383
> URL: https://issues.apache.org/jira/browse/FLINK-21383
> Project: Flink
> Issue Type: Bug
> Components: Deployment / Kubernetes, flink-docker
>Affects Versions: 1.11.3, 1.12.1, 1.13.0
>Reporter: Till Rohrmann
>Priority: Minor
> Labels: auto-deprioritized-major, usability
>
> Flink's Docker image does not play well together with ConfigMap based
> flink-conf.yamls. The {{docker-entrypoint.sh}} script offers a few env
> variables to overwrite configuration values (e.g. {{FLINK_PROPERTIES}},
> {{JOB_MANAGER_RPC_ADDRESS}}, etc.). The problem is that the entrypoint script
> assumes that it can modify the existing {{flink-conf.yaml}}. This is not the
> case if the {{flink-conf.yaml}} is based on a {{ConfigMap}}.
> Making things worse, failures updating the {{flink-conf.yaml}} are not
> reported. Moreover, the called {{jobmanager.sh}} and {{taskmanager.sh}}
> scripts don't support to pass in dynamic configuration properties into the
> processes.
> I think the problem is that our assumption that we can modify the
> {{flink-conf.yaml}} does not always hold true. If we updated the final
> configuration from within the Flink process (dynamic properties and env
> variables), then this problem could be avoided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot commented on pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client
flinkbot commented on pull request #17440: URL: https://github.com/apache/flink/pull/17440#issuecomment-938741489 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 37cf758d9eaf3ee1a1f6342714abd14ae8d80ea9 (Fri Oct 08 15:42:04 UTC 2021) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-24468) NPE when notifyNewBufferSize
[
https://issues.apache.org/jira/browse/FLINK-24468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-24468:
---
Labels: pull-request-available (was: )
> NPE when notifyNewBufferSize
>
>
> Key: FLINK-24468
> URL: https://issues.apache.org/jira/browse/FLINK-24468
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
>Affects Versions: 1.14.0
>Reporter: Anton Kalashnikov
>Assignee: Anton Kalashnikov
>Priority: Major
> Labels: pull-request-available
>
> In my opinion, we have two problem there:
> # The exception itself(see below)
> # Ignoring the exception and stopping rescheduling of the calculation of the
> buffer size.
> Of course, we need to fix this NPE and we need to think what we want to do if
> the buffer debloat fails with error.
> {noformat}
> java.lang.NullPointerException: null
> at
> org.apache.flink.runtime.io.network.netty.CreditBasedPartitionRequestClientHandler.notifyNewBufferSize(CreditBasedPartitionRequestClientHandler.java:135)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.netty.NettyPartitionRequestClient.notifyNewBufferSize(NettyPartitionRequestClient.java:203)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.notifyNewBufferSize(RemoteInputChannel.java:330)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.announceBufferSize(RemoteInputChannel.java:299)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.announceBufferSize(SingleInputGate.java:389)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.runtime.taskmanager.InputGateWithMetrics.announceBufferSize(InputGateWithMetrics.java:102)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.bufferdebloat.BufferDebloater.recalculateBufferSize(BufferDebloater.java:118)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.debloat(StreamTask.java:795)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.lambda$null$4(StreamTask.java:784)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.util.function.FunctionUtils.lambda$asCallable$5(FunctionUtils.java:126)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_282]
> at
> org.apache.flink.streaming.runtime.tasks.StreamTaskActionExecutor$1.runThrowing(StreamTaskActionExecutor.java:50)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at org.apache.flink.streaming.runtime.tasks.mailbox.Mail.run(Mail.java:90)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.processMailsNonBlocking(MailboxProcessor.java:353)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.processMail(MailboxProcessor.java:317)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:201)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:814)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:761)
> ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at
> org.apache.flink.runtime.taskmanager.Task.runWithSystemExitMonitoring(Task.java:958)
> [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at org.apache.flink.runtime.taskmanager.Task.restoreAndInvoke(Task.java:937)
> [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:754)
> [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at org.apache.flink.runtime.taskmanager.Task.run(Task.java:575)
> [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_282]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] akalash opened a new pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client
akalash opened a new pull request #17440: URL: https://github.com/apache/flink/pull/17440 ## What is the purpose of the change *This PR fixes NPE which happens when we try to use channel context inside of ClientHandler before the channel was activated* ## Brief change log - *Wait for the channel activation before creating partition request client* - *Ignore the exception during the throughput calculation in order to avoid the failure of the further calculation* ## Verifying this change This change added tests and can be verified as follows: - *Added test for CreditBasedPartitionRequestClientHandler* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean
flinkbot edited a comment on pull request #17439: URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330 ## CI report: * b5929ea88fffdb3c019dce8034cd540ded7ac025 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17423: [FLINK-24443][table-runtime] Reenable IntervalJoinITCase.testRowTimeInnerJoinWithEquiTimeAttrs
flinkbot edited a comment on pull request #17423: URL: https://github.com/apache/flink/pull/17423#issuecomment-938516818 ## CI report: * db880bc54e3bea2940448f9edaf9baf598651c46 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24851) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24841) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (FLINK-24451) Replace the scattered objects with encapsulated LeaderInformation in DefaultLeaderElectionService
[ https://issues.apache.org/jira/browse/FLINK-24451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-24451. - Fix Version/s: 1.15.0 Resolution: Fixed Fixed via 58bd394aea2b8b80f425be7388f9c9bdb51ee7af > Replace the scattered objects with encapsulated LeaderInformation in > DefaultLeaderElectionService > - > > Key: FLINK-24451 > URL: https://issues.apache.org/jira/browse/FLINK-24451 > Project: Flink > Issue Type: Improvement > Components: Runtime / Coordination >Reporter: Aitozi >Priority: Minor > Labels: pull-request-available > Fix For: 1.15.0 > > > A minor code refactor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (FLINK-24451) Replace the scattered objects with encapsulated LeaderInformation in DefaultLeaderElectionService
[ https://issues.apache.org/jira/browse/FLINK-24451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-24451: - Assignee: Aitozi > Replace the scattered objects with encapsulated LeaderInformation in > DefaultLeaderElectionService > - > > Key: FLINK-24451 > URL: https://issues.apache.org/jira/browse/FLINK-24451 > Project: Flink > Issue Type: Improvement > Components: Runtime / Coordination >Reporter: Aitozi >Assignee: Aitozi >Priority: Minor > Labels: pull-request-available > Fix For: 1.15.0 > > > A minor code refactor -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] tillrohrmann closed pull request #17414: [FLINK-24451][HA]Replace the scattered objects with encapsulated LeaderIn…
tillrohrmann closed pull request #17414: URL: https://github.com/apache/flink/pull/17414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-18934) Idle stream does not advance watermark in connected stream
[
https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz updated FLINK-18934:
-
Release Note: We added `Input#processStreamStatus` method in order to take
the {{StreamStatus}} into account when combining watermarks in two/multi input
operators. (was: We added {{Input#processStreamStatus}} method in order to
take the {{StreamStatus}} into account when combining watermarks in two/multi
input operators.)
> Idle stream does not advance watermark in connected stream
> --
>
> Key: FLINK-18934
> URL: https://issues.apache.org/jira/browse/FLINK-18934
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream, Runtime / Task
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: Truong Duc Kien
>Assignee: Dawid Wysakowicz
>Priority: Critical
> Labels: pull-request-available, stale-assigned
> Fix For: 1.14.0
>
>
> Per Flink documents, when a stream is idle, it will allow watermarks of
> downstream operator to advance. However, when I connect an active data stream
> with an idle data stream, the output watermark of the CoProcessOperator does
> not increase.
> Here's a small test that reproduces the problem.
> https://github.com/kien-truong/flink-idleness-testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (FLINK-18934) Idle stream does not advance watermark in connected stream
[
https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz closed FLINK-18934.
Release Note: We added {{Input#processStreamStatus}} method in order to
take the {{StreamStatus}} into account when combining watermarks in two/multi
input operators.
Resolution: Fixed
> Idle stream does not advance watermark in connected stream
> --
>
> Key: FLINK-18934
> URL: https://issues.apache.org/jira/browse/FLINK-18934
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream, Runtime / Task
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: Truong Duc Kien
>Assignee: Dawid Wysakowicz
>Priority: Critical
> Labels: pull-request-available, stale-assigned
> Fix For: 1.14.0
>
>
> Per Flink documents, when a stream is idle, it will allow watermarks of
> downstream operator to advance. However, when I connect an active data stream
> with an idle data stream, the output watermark of the CoProcessOperator does
> not increase.
> Here's a small test that reproduces the problem.
> https://github.com/kien-truong/flink-idleness-testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[
https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426225#comment-17426225
]
Dawid Wysakowicz commented on FLINK-18934:
--
It has not been backported to previous versions because it needed to change the
{{Input}} interface which is marked as {{PublicEvolving}}. We did not want to
introduce such a change in a minor release.
> Idle stream does not advance watermark in connected stream
> --
>
> Key: FLINK-18934
> URL: https://issues.apache.org/jira/browse/FLINK-18934
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream, Runtime / Task
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: Truong Duc Kien
>Assignee: Dawid Wysakowicz
>Priority: Critical
> Labels: pull-request-available, stale-assigned
> Fix For: 1.14.0
>
>
> Per Flink documents, when a stream is idle, it will allow watermarks of
> downstream operator to advance. However, when I connect an active data stream
> with an idle data stream, the output watermark of the CoProcessOperator does
> not increase.
> Here's a small test that reproduces the problem.
> https://github.com/kien-truong/flink-idleness-testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reopened FLINK-18934: -- Reopen to add release notes. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream, Runtime / Task >Affects Versions: 1.11.0, 1.12.0, 1.13.0 >Reporter: Truong Duc Kien >Assignee: Dawid Wysakowicz >Priority: Critical > Labels: pull-request-available, stale-assigned > Fix For: 1.14.0 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (FLINK-24357) ZooKeeperLeaderElectionConnectionHandlingTest#testLoseLeadershipOnLostConnectionIfTolerateSuspendedConnectionsIsEnabled fails with an Unhandled error
[
https://issues.apache.org/jira/browse/FLINK-24357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-24357.
-
Resolution: Fixed
Fixed via
1.15.0: b3ad16cabd2fc5bac34318d373d379d20b139966
1.14.1: f3bbad73fde42653e37b1219b7dc277e4338f477
> ZooKeeperLeaderElectionConnectionHandlingTest#testLoseLeadershipOnLostConnectionIfTolerateSuspendedConnectionsIsEnabled
> fails with an Unhandled error
> -
>
> Key: FLINK-24357
> URL: https://issues.apache.org/jira/browse/FLINK-24357
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
>Affects Versions: 1.15.0
>Reporter: Piotr Nowojski
>Assignee: Till Rohrmann
>Priority: Major
> Labels: pull-request-available, test-stability
> Fix For: 1.15.0, 1.14.1
>
> Attachments: logs-ci_build-test_ci_build_core-1632297723.zip
>
>
> In a [private
> azure|https://dev.azure.com/pnowojski/637f6470-2732-4605-a304-caebd40e284b/_apis/build/builds/517/logs/155]
> build when testing my own PR I've noticed the following error that looks
> unrelated to any of my changes (modifications to {{Task}} class
> error/cancellation handling logic):
> {noformat}
> 2021-09-22T08:09:16.6244936Z Sep 22 08:09:16 [ERROR]
> testLoseLeadershipOnLostConnectionIfTolerateSuspendedConnectionsIsEnabled
> Time elapsed: 28.753 s <<< FAILURE!
> 2021-09-22T08:09:16.6245821Z Sep 22 08:09:16 java.lang.AssertionError: The
> TestingFatalErrorHandler caught an exception.
> 2021-09-22T08:09:16.6246513Z Sep 22 08:09:16 at
> org.apache.flink.runtime.util.TestingFatalErrorHandlerResource.after(TestingFatalErrorHandlerResource.java:78)
> 2021-09-22T08:09:16.6247281Z Sep 22 08:09:16 at
> org.apache.flink.runtime.util.TestingFatalErrorHandlerResource.access$300(TestingFatalErrorHandlerResource.java:33)
> 2021-09-22T08:09:16.6248167Z Sep 22 08:09:16 at
> org.apache.flink.runtime.util.TestingFatalErrorHandlerResource$1.evaluate(TestingFatalErrorHandlerResource.java:57)
> 2021-09-22T08:09:16.6248862Z Sep 22 08:09:16 at
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> 2021-09-22T08:09:16.6249620Z Sep 22 08:09:16 at
> org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
> 2021-09-22T08:09:16.6250210Z Sep 22 08:09:16 at
> org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> 2021-09-22T08:09:16.6250773Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> 2021-09-22T08:09:16.6251375Z Sep 22 08:09:16 at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> 2021-09-22T08:09:16.6251951Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> 2021-09-22T08:09:16.6252562Z Sep 22 08:09:16 at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> 2021-09-22T08:09:16.6253415Z Sep 22 08:09:16 at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> 2021-09-22T08:09:16.6254469Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> 2021-09-22T08:09:16.6255039Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> 2021-09-22T08:09:16.6256238Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> 2021-09-22T08:09:16.6257109Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> 2021-09-22T08:09:16.6257766Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> 2021-09-22T08:09:16.6258406Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> 2021-09-22T08:09:16.6259050Z Sep 22 08:09:16 at
> org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> 2021-09-22T08:09:16.6259827Z Sep 22 08:09:16 at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> 2021-09-22T08:09:16.6260963Z Sep 22 08:09:16 at
> org.junit.runner.JUnitCore.run(JUnitCore.java:115)
> 2021-09-22T08:09:16.6261796Z Sep 22 08:09:16 at
> org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:43)
> 2021-09-22T08:09:16.6262428Z Sep 22 08:09:16 at
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
> 2021-09-22T08:09:16.6263268Z Sep 22 08:09:16 at
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> 2021-09-22T08:09:16.6263875Z Sep 22 08:09:16 at
> java.util.Iterator.forEachRemaining(Iterator.java:116)
> 2021-09-22T08:09:16.6265025Z Sep 22 08:09:16 at
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
>
[GitHub] [flink] tillrohrmann merged pull request #17399: [BP-1.14][FLINK-24357][tests] Harden ZooKeeperLeaderElectionConnectionHandlingTest
tillrohrmann merged pull request #17399: URL: https://github.com/apache/flink/pull/17399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #17398: [FLINK-24357][tests] Harden ZooKeeperLeaderElectionConnectionHandlingTest
tillrohrmann closed pull request #17398: URL: https://github.com/apache/flink/pull/17398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-24413) Casting to a CHAR() and VARCHAR() doesn't trim the string to the specified precision
[
https://issues.apache.org/jira/browse/FLINK-24413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426220#comment-17426220
]
Marios Trivyzas commented on FLINK-24413:
-
I tend to agree with [~jark] at least in the context of DBs as a sink/output.
Even with VARCHAR DBs are strict in terms of the maximum length:
{{postgres=# *create table t(a varchar(5));*}}
{{CREATE TABLE}}
{{postgres=# *insert into t(a) values('abcdefg');*}}
{{ERROR: value too long for type character varying(5)}}
> Casting to a CHAR() and VARCHAR() doesn't trim the string to the specified
> precision
>
>
> Key: FLINK-24413
> URL: https://issues.apache.org/jira/browse/FLINK-24413
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: Marios Trivyzas
>Priority: Major
>
> *CAST**('abcdfe' AS CHAR(3))* should trim the string to 3 chars but currently
> returns the whole string *'abcdfe'*.
>
> PostgreSQL and Oracle for example behave as such:
> postgres=# select '123456afas'::char(4);
> bpchar
>
> 1234
> (1 row)
> postgres=# select '123456afas'::varchar(5);
> varchar
> -
> 12345
> (1 row)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (FLINK-23271) RuntimeException: while resolving method 'booleanValue' in class class java.math.BigDecimal
[ https://issues.apache.org/jira/browse/FLINK-23271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marios Trivyzas reassigned FLINK-23271: --- Assignee: Marios Trivyzas > RuntimeException: while resolving method 'booleanValue' in class class > java.math.BigDecimal > --- > > Key: FLINK-23271 > URL: https://issues.apache.org/jira/browse/FLINK-23271 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Affects Versions: 1.14.0 >Reporter: xiaojin.wy >Assignee: Marios Trivyzas >Priority: Major > Labels: pull-request-available > > *Sql :* > CREATE TABLE database3_t0( > c0 DECIMAL , c1 SMALLINT > ) WITH ( > 'connector' = 'filesystem', > 'path' = 'hdfs:///tmp/database3_t0.csv', > 'format' = 'csv' > ); > INSERT OVERWRITE database8_t0(c0, c1) VALUES(2113554022, cast(-22975 as > SMALLINT)), (1570419395, cast(-26858 as SMALLINT)), (-1569861129, cast(-20143 > as SMALLINT)); > SELECT database8_t0.c0 AS ref0 FROM database8_t0 WHERE CAST > (0.10915913549909961 AS BOOLEAN; > *After excuting the sql, you will find the error:* > java.lang.RuntimeException: while resolving method 'booleanValue' in class > class java.math.BigDecimal > at org.apache.calcite.linq4j.tree.Expressions.call(Expressions.java:424) > at org.apache.calcite.linq4j.tree.Expressions.call(Expressions.java:435) > at > org.apache.calcite.linq4j.tree.Expressions.unbox(Expressions.java:1453) > at > org.apache.calcite.adapter.enumerable.EnumUtils.convert(EnumUtils.java:398) > at > org.apache.calcite.adapter.enumerable.EnumUtils.convert(EnumUtils.java:326) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translateCast(RexToLixTranslator.java:538) > at > org.apache.calcite.adapter.enumerable.RexImpTable$CastImplementor.implementSafe(RexImpTable.java:2450) > at > org.apache.calcite.adapter.enumerable.RexImpTable$AbstractRexCallImplementor.genValueStatement(RexImpTable.java:2894) > at > org.apache.calcite.adapter.enumerable.RexImpTable$AbstractRexCallImplementor.implement(RexImpTable.java:2859) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitCall(RexToLixTranslator.java:1084) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitCall(RexToLixTranslator.java:90) > at org.apache.calcite.rex.RexCall.accept(RexCall.java:174) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitLocalRef(RexToLixTranslator.java:970) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitLocalRef(RexToLixTranslator.java:90) > at org.apache.calcite.rex.RexLocalRef.accept(RexLocalRef.java:75) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translate(RexToLixTranslator.java:237) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translate(RexToLixTranslator.java:231) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translateList(RexToLixTranslator.java:818) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translateProjects(RexToLixTranslator.java:198) > at > org.apache.calcite.rex.RexExecutorImpl.compile(RexExecutorImpl.java:90) > at > org.apache.calcite.rex.RexExecutorImpl.compile(RexExecutorImpl.java:66) > at > org.apache.calcite.rex.RexExecutorImpl.reduce(RexExecutorImpl.java:128) > at > org.apache.calcite.rex.RexSimplify.simplifyCast(RexSimplify.java:2101) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:326) > at > org.apache.calcite.rex.RexSimplify.simplifyUnknownAs(RexSimplify.java:287) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:262) > at > org.apache.flink.table.planner.plan.utils.FlinkRexUtil$.simplify(FlinkRexUtil.scala:224) > at > org.apache.flink.table.planner.plan.rules.logical.SimplifyFilterConditionRule.simplify(SimplifyFilterConditionRule.scala:63) > at > org.apache.flink.table.planner.plan.rules.logical.SimplifyFilterConditionRule.onMatch(SimplifyFilterConditionRule.scala:46) > at > org.apache.calcite.plan.AbstractRelOptPlanner.fireRule(AbstractRelOptPlanner.java:333) > at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:542) > at > org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:407) > at > org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:243) > at > org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:127) > at > org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:202) > at >
[GitHub] [flink] flinkbot commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean
flinkbot commented on pull request #17439: URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330 ## CI report: * b5929ea88fffdb3c019dce8034cd540ded7ac025 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
flinkbot edited a comment on pull request #17438: URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309 ## CI report: * 82cfa4deb7c10c8214e2138aa95332bad4ade3d9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17435: [FLINK-23458][docs] Added the network buffer documentation along wit…
flinkbot edited a comment on pull request #17435: URL: https://github.com/apache/flink/pull/17435#issuecomment-938536222 ## CI report: * c98933bfd363ec39efdc1ef5bfaaa4dd14200461 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24852) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17431: [FLINK-24431][kinesis][efo] Stop consumer deregistration when EAGER EFO configured into 1.12.x
flinkbot edited a comment on pull request #17431: URL: https://github.com/apache/flink/pull/17431#issuecomment-938517957 ## CI report: * 191eee54006303b07fd453ad6971cbf8a55c4b38 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24847) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17409: [FLINK-24437][HA]Remove unhandled exception handler from CuratorFrame…
flinkbot edited a comment on pull request #17409: URL: https://github.com/apache/flink/pull/17409#issuecomment-933172900 ## CI report: * 9323e4c49b91acff900ab3cbd517521fe3628dc6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24839) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FLINK-24488) KafkaRecordSerializationSchemaBuilder does not forward timestamp
Fabian Paul created FLINK-24488: --- Summary: KafkaRecordSerializationSchemaBuilder does not forward timestamp Key: FLINK-24488 URL: https://issues.apache.org/jira/browse/FLINK-24488 Project: Flink Issue Type: Bug Components: Connectors / Kafka Affects Versions: 1.14.0, 1.15.0 Reporter: Fabian Paul When building a KafkaRecordSerializationSchema with its builder the extracted event time timestamp is currently not set at the resulting ProducerRecord. https://github.com/apache/flink/blob/026675a5cb8a3704c51802fb549d6b0bc4759835/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilder.java#L328 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-23271) RuntimeException: while resolving method 'booleanValue' in class class java.math.BigDecimal
[ https://issues.apache.org/jira/browse/FLINK-23271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426202#comment-17426202 ] Marios Trivyzas edited comment on FLINK-23271 at 10/8/21, 2:01 PM: --- Opened a draft PR to drop support for casting decimal numeric to boolean. Work will continue once the Calcite PR: [https://github.com/apache/calcite/pull/2555] is merged, and I posted a TODO list as comment on the PR. was (Author: matriv): Opened a draft PR to drop support for casting decimal numeric to boolean. Work will continue once the Calcite PR: [https://github.com/apache/calcite/pull/2555] is merged. > RuntimeException: while resolving method 'booleanValue' in class class > java.math.BigDecimal > --- > > Key: FLINK-23271 > URL: https://issues.apache.org/jira/browse/FLINK-23271 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / Planner >Affects Versions: 1.14.0 >Reporter: xiaojin.wy >Priority: Major > Labels: pull-request-available > > *Sql :* > CREATE TABLE database3_t0( > c0 DECIMAL , c1 SMALLINT > ) WITH ( > 'connector' = 'filesystem', > 'path' = 'hdfs:///tmp/database3_t0.csv', > 'format' = 'csv' > ); > INSERT OVERWRITE database8_t0(c0, c1) VALUES(2113554022, cast(-22975 as > SMALLINT)), (1570419395, cast(-26858 as SMALLINT)), (-1569861129, cast(-20143 > as SMALLINT)); > SELECT database8_t0.c0 AS ref0 FROM database8_t0 WHERE CAST > (0.10915913549909961 AS BOOLEAN; > *After excuting the sql, you will find the error:* > java.lang.RuntimeException: while resolving method 'booleanValue' in class > class java.math.BigDecimal > at org.apache.calcite.linq4j.tree.Expressions.call(Expressions.java:424) > at org.apache.calcite.linq4j.tree.Expressions.call(Expressions.java:435) > at > org.apache.calcite.linq4j.tree.Expressions.unbox(Expressions.java:1453) > at > org.apache.calcite.adapter.enumerable.EnumUtils.convert(EnumUtils.java:398) > at > org.apache.calcite.adapter.enumerable.EnumUtils.convert(EnumUtils.java:326) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translateCast(RexToLixTranslator.java:538) > at > org.apache.calcite.adapter.enumerable.RexImpTable$CastImplementor.implementSafe(RexImpTable.java:2450) > at > org.apache.calcite.adapter.enumerable.RexImpTable$AbstractRexCallImplementor.genValueStatement(RexImpTable.java:2894) > at > org.apache.calcite.adapter.enumerable.RexImpTable$AbstractRexCallImplementor.implement(RexImpTable.java:2859) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitCall(RexToLixTranslator.java:1084) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitCall(RexToLixTranslator.java:90) > at org.apache.calcite.rex.RexCall.accept(RexCall.java:174) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitLocalRef(RexToLixTranslator.java:970) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.visitLocalRef(RexToLixTranslator.java:90) > at org.apache.calcite.rex.RexLocalRef.accept(RexLocalRef.java:75) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translate(RexToLixTranslator.java:237) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translate(RexToLixTranslator.java:231) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translateList(RexToLixTranslator.java:818) > at > org.apache.calcite.adapter.enumerable.RexToLixTranslator.translateProjects(RexToLixTranslator.java:198) > at > org.apache.calcite.rex.RexExecutorImpl.compile(RexExecutorImpl.java:90) > at > org.apache.calcite.rex.RexExecutorImpl.compile(RexExecutorImpl.java:66) > at > org.apache.calcite.rex.RexExecutorImpl.reduce(RexExecutorImpl.java:128) > at > org.apache.calcite.rex.RexSimplify.simplifyCast(RexSimplify.java:2101) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:326) > at > org.apache.calcite.rex.RexSimplify.simplifyUnknownAs(RexSimplify.java:287) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:262) > at > org.apache.flink.table.planner.plan.utils.FlinkRexUtil$.simplify(FlinkRexUtil.scala:224) > at > org.apache.flink.table.planner.plan.rules.logical.SimplifyFilterConditionRule.simplify(SimplifyFilterConditionRule.scala:63) > at > org.apache.flink.table.planner.plan.rules.logical.SimplifyFilterConditionRule.onMatch(SimplifyFilterConditionRule.scala:46) > at > org.apache.calcite.plan.AbstractRelOptPlanner.fireRule(AbstractRelOptPlanner.java:333) > at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:542) > at >
[GitHub] [flink] flinkbot commented on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
flinkbot commented on pull request #17438: URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309 ## CI report: * 82cfa4deb7c10c8214e2138aa95332bad4ade3d9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
flinkbot edited a comment on pull request #17437: URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904 ## CI report: * fbfc14527fed6e285c2d65460cc317b10e5e2e94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
