[jira] [Reopened] (FLINK-26270) Flink SQL write data to kafka by CSV format , decimal type was converted to scientific notation

2022-03-18 Thread fengjk (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

fengjk reopened FLINK-26270:


> Flink SQL write data to kafka by CSV format , decimal type was converted to 
> scientific notation
> ---
>
> Key: FLINK-26270
> URL: https://issues.apache.org/jira/browse/FLINK-26270
> Project: Flink
>  Issue Type: Bug
>  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Affects Versions: 1.12.4
>Reporter: fengjk
>Priority: Minor
> Fix For: 1.12.4
>
> Attachments: image-2022-02-21-14-11-49-617.png, 
> image-2022-02-21-14-12-17-845.png, image-2022-02-21-14-13-28-605.png, 
> image-2022-02-25-17-38-06-764.png, image-2022-03-07-14-56-00-328.png
>
>
> Source:Oracle
> field type:decimal
> !image-2022-02-21-14-12-17-845.png|width=362,height=137!
> !image-2022-02-25-17-38-06-764.png!
>  
> Sink::kafka
> field type:decimal
> format:CSV
> !image-2022-02-21-14-13-28-605.png|width=259,height=184!
>  
> Cannot set not to convert to scientific notation
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Resolved] (FLINK-26270) Flink SQL write data to kafka by CSV format , decimal type was converted to scientific notation

2022-03-18 Thread fengjk (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

fengjk resolved FLINK-26270.

Fix Version/s: 1.12.4
   Resolution: Fixed

> Flink SQL write data to kafka by CSV format , decimal type was converted to 
> scientific notation
> ---
>
> Key: FLINK-26270
> URL: https://issues.apache.org/jira/browse/FLINK-26270
> Project: Flink
>  Issue Type: Bug
>  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile)
>Affects Versions: 1.12.4
>Reporter: fengjk
>Priority: Minor
> Fix For: 1.12.4
>
> Attachments: image-2022-02-21-14-11-49-617.png, 
> image-2022-02-21-14-12-17-845.png, image-2022-02-21-14-13-28-605.png, 
> image-2022-02-25-17-38-06-764.png, image-2022-03-07-14-56-00-328.png
>
>
> Source:Oracle
> field type:decimal
> !image-2022-02-21-14-12-17-845.png|width=362,height=137!
> !image-2022-02-25-17-38-06-764.png!
>  
> Sink::kafka
> field type:decimal
> format:CSV
> !image-2022-02-21-14-13-28-605.png|width=259,height=184!
>  
> Cannot set not to convert to scientific notation
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] hongshuboy closed pull request #19046: [hotfix][docs] Fix syntax errors in java doc

2022-03-18 Thread GitBox


hongshuboy closed pull request #19046:
URL: https://github.com/apache/flink/pull/19046


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19162:
URL: https://github.com/apache/flink/pull/19162#issuecomment-1072924592


   
   ## CI report:
   
   * d795bae7e9236e1031c2de2dd1c75c28a863231c Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33391)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-26655) Improve the observe logic in SessionObserver

2022-03-18 Thread Biao Geng (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-26655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509168#comment-17509168
 ] 

Biao Geng commented on FLINK-26655:
---

I rewrite this jira after our previous discussion about the check of rest 
service. Now it is used to track the improvement of the observe logic in 
SessionObserver according to your review. cc [~wangyang0918]

> Improve the observe logic in SessionObserver
> 
>
> Key: FLINK-26655
> URL: https://issues.apache.org/jira/browse/FLINK-26655
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Biao Geng
>Priority: Major
>
> -We now consider that JM pod can have 2 possible states after launching:-
>  # -JM is launched but port is not ready.-
>  # -JM is launched, port is ready but rest service is not ready.-
> -It looks that they can be merged as what we really care is if the JM can 
> serve REST calls correctly, not if the JM port is ready.-
> -With above observation, we can merge {{isJobManagerPortReady}} and 
> {{isJobManagerServing}} to check if JM pod can serve correctly.-
>  
> Following the discussion in PR 
> [62|https://github.com/apache/flink-kubernetes-operator/pull/62], we 
> currently discard {{isJobManagerServing}}  and use the 
> {{isJobManagerPortReady}} together with a call to `flinkService.listJobs()`to 
> make sure job manager can serve rest call correctly. The original question of 
> this jira is solved.
> Now I adjust this jira to track the improvement of the observe logic in 
> SessionObserver due to the review comments.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19162:
URL: https://github.com/apache/flink/pull/19162#issuecomment-1072924592


   
   ## CI report:
   
   * d795bae7e9236e1031c2de2dd1c75c28a863231c Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33391)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] liyubin117 commented on pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


liyubin117 commented on pull request #19162:
URL: https://github.com/apache/flink/pull/19162#issuecomment-1072943092


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-26655) Improve the observe logic in SessionObserver

2022-03-18 Thread Biao Geng (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Geng updated FLINK-26655:
--
Description: 
-We now consider that JM pod can have 2 possible states after launching:-
 # -JM is launched but port is not ready.-
 # -JM is launched, port is ready but rest service is not ready.-

-It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.-
-With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.-

 

Following the discussion in PR 
[62|https://github.com/apache/flink-kubernetes-operator/pull/62], we currently 
discard {{isJobManagerServing}}  and use the {{isJobManagerPortReady}} together 
with a call to `flinkService.listJobs()`to make sure job manager can serve rest 
call correctly. The original question of this jira is solved.
Now I adjust this jira to track the improvement of the 

  was:
-We now consider that JM pod can have 2 possible states after launching:-
 # -JM is launched but port is not ready.-
 # -JM is launched, port is ready but rest service is not ready.-

-It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.-
-With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.-


> Improve the observe logic in SessionObserver
> 
>
> Key: FLINK-26655
> URL: https://issues.apache.org/jira/browse/FLINK-26655
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Biao Geng
>Priority: Major
>
> -We now consider that JM pod can have 2 possible states after launching:-
>  # -JM is launched but port is not ready.-
>  # -JM is launched, port is ready but rest service is not ready.-
> -It looks that they can be merged as what we really care is if the JM can 
> serve REST calls correctly, not if the JM port is ready.-
> -With above observation, we can merge {{isJobManagerPortReady}} and 
> {{isJobManagerServing}} to check if JM pod can serve correctly.-
>  
> Following the discussion in PR 
> [62|https://github.com/apache/flink-kubernetes-operator/pull/62], we 
> currently discard {{isJobManagerServing}}  and use the 
> {{isJobManagerPortReady}} together with a call to `flinkService.listJobs()`to 
> make sure job manager can serve rest call correctly. The original question of 
> this jira is solved.
> Now I adjust this jira to track the improvement of the 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-26655) Improve the observe logic in SessionObserver

2022-03-18 Thread Biao Geng (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Geng updated FLINK-26655:
--
Description: 
-We now consider that JM pod can have 2 possible states after launching:-
 # -JM is launched but port is not ready.-
 # -JM is launched, port is ready but rest service is not ready.-

-It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.-
-With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.-

 

Following the discussion in PR 
[62|https://github.com/apache/flink-kubernetes-operator/pull/62], we currently 
discard {{isJobManagerServing}}  and use the {{isJobManagerPortReady}} together 
with a call to `flinkService.listJobs()`to make sure job manager can serve rest 
call correctly. The original question of this jira is solved.
Now I adjust this jira to track the improvement of the observe logic in 
SessionObserver due to the review comments.

  was:
-We now consider that JM pod can have 2 possible states after launching:-
 # -JM is launched but port is not ready.-
 # -JM is launched, port is ready but rest service is not ready.-

-It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.-
-With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.-

 

Following the discussion in PR 
[62|https://github.com/apache/flink-kubernetes-operator/pull/62], we currently 
discard {{isJobManagerServing}}  and use the {{isJobManagerPortReady}} together 
with a call to `flinkService.listJobs()`to make sure job manager can serve rest 
call correctly. The original question of this jira is solved.
Now I adjust this jira to track the improvement of the 


> Improve the observe logic in SessionObserver
> 
>
> Key: FLINK-26655
> URL: https://issues.apache.org/jira/browse/FLINK-26655
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Biao Geng
>Priority: Major
>
> -We now consider that JM pod can have 2 possible states after launching:-
>  # -JM is launched but port is not ready.-
>  # -JM is launched, port is ready but rest service is not ready.-
> -It looks that they can be merged as what we really care is if the JM can 
> serve REST calls correctly, not if the JM port is ready.-
> -With above observation, we can merge {{isJobManagerPortReady}} and 
> {{isJobManagerServing}} to check if JM pod can serve correctly.-
>  
> Following the discussion in PR 
> [62|https://github.com/apache/flink-kubernetes-operator/pull/62], we 
> currently discard {{isJobManagerServing}}  and use the 
> {{isJobManagerPortReady}} together with a call to `flinkService.listJobs()`to 
> make sure job manager can serve rest call correctly. The original question of 
> this jira is solved.
> Now I adjust this jira to track the improvement of the observe logic in 
> SessionObserver due to the review comments.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-26605) Check if JM can serve rest api calls every time before reconcile

2022-03-18 Thread Biao Geng (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Geng updated FLINK-26605:
--
Summary: Check if JM can serve rest api calls every time before reconcile  
(was: Improve the observe logic in SessionObserver)

> Check if JM can serve rest api calls every time before reconcile
> 
>
> Key: FLINK-26605
> URL: https://issues.apache.org/jira/browse/FLINK-26605
> Project: Flink
>  Issue Type: Sub-task
>  Components: Kubernetes Operator
>Reporter: Yang Wang
>Assignee: Biao Geng
>Priority: Major
>  Labels: pull-request-available
>
> Follow the discussion in the PR[1].
> {{JobManagerDeploymentStatus.READY}} does not mean the Flink cluster is ready 
> for accepting REST API calls. This will cause problems when we are running 
> session cluster.
> For example, if something is wrong or very slow with the leader election, 
> {{JobManagerDeploymentStatus}} is {{READY}} but the session cluster is not 
> ready for accepting job submission. What I mean is to update the 
> {{JobManagerDeploymentStatus}} to {{READY}} only when the flink cluster is 
> actually working.
> Another case is even though JobManager crashed backoff, the 
> {{JobManagerDeploymentStatus}} is still {{READY}}.
>  
> [1]. 
> https://github.com/apache/flink-kubernetes-operator/pull/51#discussion_r824359419



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-26655) Improve the observe logic in SessionObserver

2022-03-18 Thread Biao Geng (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Geng updated FLINK-26655:
--
Summary: Improve the observe logic in SessionObserver  (was: Merge 
isJobManagerPortReady and isJobManagerServing to check if JM pod can work 
correctly)

> Improve the observe logic in SessionObserver
> 
>
> Key: FLINK-26655
> URL: https://issues.apache.org/jira/browse/FLINK-26655
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Biao Geng
>Priority: Major
>
> -We now consider that JM pod can have 2 possible states after launching:-
>  # -JM is launched but port is not ready.-
>  # -JM is launched, port is ready but rest service is not ready.-
> -It looks that they can be merged as what we really care is if the JM can 
> serve REST calls correctly, not if the JM port is ready.-
> -With above observation, we can merge {{isJobManagerPortReady}} and 
> {{isJobManagerServing}} to check if JM pod can serve correctly.-



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-26605) Improve the observe logic in SessionObserver

2022-03-18 Thread Biao Geng (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Geng updated FLINK-26605:
--
Summary: Improve the observe logic in SessionObserver  (was: 
JobManagerDeploymentStatus.READY does not correctly reflect the real Flink 
cluster status)

> Improve the observe logic in SessionObserver
> 
>
> Key: FLINK-26605
> URL: https://issues.apache.org/jira/browse/FLINK-26605
> Project: Flink
>  Issue Type: Sub-task
>  Components: Kubernetes Operator
>Reporter: Yang Wang
>Assignee: Biao Geng
>Priority: Major
>  Labels: pull-request-available
>
> Follow the discussion in the PR[1].
> {{JobManagerDeploymentStatus.READY}} does not mean the Flink cluster is ready 
> for accepting REST API calls. This will cause problems when we are running 
> session cluster.
> For example, if something is wrong or very slow with the leader election, 
> {{JobManagerDeploymentStatus}} is {{READY}} but the session cluster is not 
> ready for accepting job submission. What I mean is to update the 
> {{JobManagerDeploymentStatus}} to {{READY}} only when the flink cluster is 
> actually working.
> Another case is even though JobManager crashed backoff, the 
> {{JobManagerDeploymentStatus}} is still {{READY}}.
>  
> [1]. 
> https://github.com/apache/flink-kubernetes-operator/pull/51#discussion_r824359419



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-26655) Merge isJobManagerPortReady and isJobManagerServing to check if JM pod can work correctly

2022-03-18 Thread Biao Geng (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Biao Geng updated FLINK-26655:
--
Description: 
-We now consider that JM pod can have 2 possible states after launching:-
 # -JM is launched but port is not ready.-
 # -JM is launched, port is ready but rest service is not ready.-

-It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.-
-With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.-

  was:
We now consider that JM pod can have 2 possible states after launching:
 # JM is launched but port is not ready.
 # JM is launched, port is ready but rest service is not ready.

It looks that they can be merged as what we really care is if the JM can serve 
REST calls correctly, not if the JM port is ready.
With above observation, we can merge {{isJobManagerPortReady}} and 
{{isJobManagerServing}} to check if JM pod can serve correctly.



> Merge isJobManagerPortReady and isJobManagerServing to check if JM pod can 
> work correctly
> -
>
> Key: FLINK-26655
> URL: https://issues.apache.org/jira/browse/FLINK-26655
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Biao Geng
>Priority: Major
>
> -We now consider that JM pod can have 2 possible states after launching:-
>  # -JM is launched but port is not ready.-
>  # -JM is launched, port is ready but rest service is not ready.-
> -It looks that they can be merged as what we really care is if the JM can 
> serve REST calls correctly, not if the JM port is ready.-
> -With above observation, we can merge {{isJobManagerPortReady}} and 
> {{isJobManagerServing}} to check if JM pod can serve correctly.-



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19162:
URL: https://github.com/apache/flink/pull/19162#issuecomment-1072924592


   
   ## CI report:
   
   * d795bae7e9236e1031c2de2dd1c75c28a863231c Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33391)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java

2022-03-18 Thread GitBox


realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1072939994


   @fapaul Thanks for the guidance, we rebased it to the latest master branch 
of the community and force pushed it recently. We also created backport PRs for 
the release1.14 branch and the release1.15 branch.   And, these PRs have 
successfully passed the azure build. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19156: decouple-hive-planer

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19156:
URL: https://github.com/apache/flink/pull/19156#issuecomment-1072382647


   
   ## CI report:
   
   * 4262952c22b5df5d2a23c5525404b31ae2018ec6 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33362)
 
   * d078329cce4ffd1874793ab7b139ed106b9b1525 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33398)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19156: decouple-hive-planer

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19156:
URL: https://github.com/apache/flink/pull/19156#issuecomment-1072382647


   
   ## CI report:
   
   * 4262952c22b5df5d2a23c5525404b31ae2018ec6 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33362)
 
   * d078329cce4ffd1874793ab7b139ed106b9b1525 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-26618) Remove jar statement not aligned with pipleline.jars

2022-03-18 Thread Leonard Xu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-26618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509151#comment-17509151
 ] 

Leonard Xu commented on FLINK-26618:


Fixed:
  master(1.16):1b041dbd9a781ef7a3927df45149be4f09e9ea7b

> Remove jar statement not aligned with pipleline.jars
> 
>
> Key: FLINK-26618
> URL: https://issues.apache.org/jira/browse/FLINK-26618
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Client
>Affects Versions: 1.14.3
>Reporter: Paul Lin
>Assignee: Paul Lin
>Priority: Major
>  Labels: pull-request-available
>
> Currently, `remove jar` statement doesn't remove the corresponding jars in 
> pipeline.jars.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] leonardBang commented on pull request #19133: [BP-1.15][FLINK-26618] Fix pipeline.jars not aligned with remove-jar statement

2022-03-18 Thread GitBox


leonardBang commented on pull request #19133:
URL: https://github.com/apache/flink/pull/19133#issuecomment-1072932785


   @link3280 You may also need rebase current branch to latest `release-1.15` 
to avoid the failure case.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] leonardBang commented on pull request #19132: [BP-1.14][FLINK-26618] Fix pipeline.jars not aligned with remove-jar statement

2022-03-18 Thread GitBox


leonardBang commented on pull request #19132:
URL: https://github.com/apache/flink/pull/19132#issuecomment-1072932740


   @link3280 You may also need rebase current branch to latest `release-1.14` 
to avoid the failure case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] leonardBang commented on pull request #19070: [FLINK-26618][sql-client] Fix Remove-Jar statement not effective

2022-03-18 Thread GitBox


leonardBang commented on pull request #19070:
URL: https://github.com/apache/flink/pull/19070#issuecomment-1072932511


   Thanks @link3280 for the continuous work, the Github infrastructure broken 
recently which influenced many project .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] leonardBang merged pull request #19070: [FLINK-26618][sql-client] Fix Remove-Jar statement not effective

2022-03-18 Thread GitBox


leonardBang merged pull request #19070:
URL: https://github.com/apache/flink/pull/19070


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19152: [FLINK-26692][e2e] migrate TpcdsTestProgram.java to new source

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19152:
URL: https://github.com/apache/flink/pull/19152#issuecomment-1072298017


   
   ## CI report:
   
   * a3674835e935ea4ed2e413b1793832ebc4fe7349 Azure: 
[CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33390)
 
   * 1c77abc2997c2682e540f8a544c13a7e0dd9675a Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33396)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19152: [FLINK-26692][e2e] migrate TpcdsTestProgram.java to new source

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19152:
URL: https://github.com/apache/flink/pull/19152#issuecomment-1072298017


   
   ## CI report:
   
   * 14454d0b4f4047b1bfb5f71d131460e7bc6987e8 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33377)
 
   * a3674835e935ea4ed2e413b1793832ebc4fe7349 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33390)
 
   * 1c77abc2997c2682e540f8a544c13a7e0dd9675a UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] link3280 commented on pull request #19070: [FLINK-26618][sql-client] Fix Remove-Jar statement not effective

2022-03-18 Thread GitBox


link3280 commented on pull request #19070:
URL: https://github.com/apache/flink/pull/19070#issuecomment-1072930238


   @leonardBang CI finally turns green. Could you merge this PR if possible? 
Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] liyubin117 commented on pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


liyubin117 commented on pull request #19162:
URL: https://github.com/apache/flink/pull/19162#issuecomment-1072929938


   @MartijnVisser I have cherried pick related commits to the new branch based 
on release-1.15 and no conflicts, given Nifi connector still exists in 1.15, I 
have retained the change in Nifi module doc :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18757:
URL: https://github.com/apache/flink/pull/18757#issuecomment-1039117115


   
   ## CI report:
   
   * 989d2280eae23b9a9fda017ef9b686332aaef134 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3)
 
   * 6063dec4366d3463e4e85c4761186c06271d867c Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33395)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-26565) Use lateTrigger when the window maxtimestap of data is less than currentwatermark and it is not discarded because the allow latency parameter

2022-03-18 Thread hehuiyuan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-26565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509148#comment-17509148
 ] 

hehuiyuan commented on FLINK-26565:
---

Hi [~jark]  ,  done .

You can review this pr,   thanks.

> Use lateTrigger when the window maxtimestap of data is less than 
> currentwatermark and  it is not discarded because the allow latency parameter 
> ---
>
> Key: FLINK-26565
> URL: https://issues.apache.org/jira/browse/FLINK-26565
> Project: Flink
>  Issue Type: Improvement
>  Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime
>Reporter: hehuiyuan
>Priority: Minor
>  Labels: pull-request-available
> Attachments: image-2022-03-10-11-27-52-891.png
>
>
> Use lateTrigger when the window maxtimestap of data is less than 
> currentwatermark .
> The data  is not discarded because the allow latency parameter.
> The lateTrigger is set and the window just appeared with this data.
> !image-2022-03-10-11-27-52-891.png|width=543,height=318!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18757:
URL: https://github.com/apache/flink/pull/18757#issuecomment-1039117115


   
   ## CI report:
   
   * 989d2280eae23b9a9fda017ef9b686332aaef134 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3)
 
   * 6063dec4366d3463e4e85c4761186c06271d867c UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal commented on pull request #18928: [FLINK-25545][flink-clients][JUnit5 Migration] Module: flink-clients.

2022-03-18 Thread GitBox


RocMarshal commented on pull request #18928:
URL: https://github.com/apache/flink/pull/18928#issuecomment-1072927408


   Thanks for the @RyanSkraba  review and @zentol  research.
   I updated it based on your suggestions. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830430626



##
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/StreamingKMeans.java
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.clustering.kmeans;
+
+import org.apache.flink.api.common.functions.AggregateFunction;
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.state.ListState;
+import org.apache.flink.api.common.state.ListStateDescriptor;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
+import org.apache.flink.api.java.typeutils.TupleTypeInfo;
+import org.apache.flink.iteration.DataStreamList;
+import org.apache.flink.iteration.IterationBody;
+import org.apache.flink.iteration.IterationBodyResult;
+import org.apache.flink.iteration.Iterations;
+import org.apache.flink.ml.api.Estimator;
+import org.apache.flink.ml.common.distance.DistanceMeasure;
+import org.apache.flink.ml.common.param.HasBatchStrategy;
+import org.apache.flink.ml.linalg.BLAS;
+import org.apache.flink.ml.linalg.DenseVector;
+import org.apache.flink.ml.linalg.Vectors;
+import org.apache.flink.ml.linalg.typeinfo.DenseVectorTypeInfo;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.runtime.state.StateInitializationContext;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
+import org.apache.flink.streaming.api.operators.TwoInputStreamOperator;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import 
org.apache.flink.table.api.bridge.java.internal.StreamTableEnvironmentImpl;
+import org.apache.flink.table.api.internal.TableImpl;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.commons.collections.IteratorUtils;
+import org.apache.commons.lang3.ArrayUtils;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+
+/**
+ * StreamingKMeans extends the function of {@link KMeans}, supporting to train 
a K-Means model
+ * continuously according to an unbounded stream of train data.
+ */
+public class StreamingKMeans
+implements Estimator,
+StreamingKMeansParams {
+private final Map, Object> paramMap = new HashMap<>();
+private Table initModelDataTable;
+
+public StreamingKMeans() {
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+}
+
+public StreamingKMeans(Table... initModelDataTables) {
+Preconditions.checkArgument(initModelDataTables.length == 1);
+this.initModelDataTable = initModelDataTables[0];
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+setInitMode("direct");
+}
+
+@Override
+public StreamingKMeansModel fit(Table... inputs) {
+Preconditions.checkArgument(inputs.length == 1);
+
Preconditions.checkArgument(HasBatchStrategy.COUNT_STRATEGY.equals(getBatchStrategy()));
+
+StreamTableEnvironment tEnv =
+(StreamTableEnvironment) ((TableImpl) 
inputs[0]).getTableEnvironment();
+StreamExecutionEnvironment env = ((StreamTableEnvironmentImpl) 
tEnv).execEnv();
+
+DataStream points =
+tEnv.toDataStream(inputs[0]).map(new 
FeaturesExtractor(getFeaturesCol()));
+points.getTransformation().setParallelism(1);
+
+DataStream initModelDataStream;
+if (getInitMode().equals("random")) {
+initModelDataStream = createRandomCentroids(env, getDims(), 

[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830430626



##
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/StreamingKMeans.java
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.clustering.kmeans;
+
+import org.apache.flink.api.common.functions.AggregateFunction;
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.state.ListState;
+import org.apache.flink.api.common.state.ListStateDescriptor;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
+import org.apache.flink.api.java.typeutils.TupleTypeInfo;
+import org.apache.flink.iteration.DataStreamList;
+import org.apache.flink.iteration.IterationBody;
+import org.apache.flink.iteration.IterationBodyResult;
+import org.apache.flink.iteration.Iterations;
+import org.apache.flink.ml.api.Estimator;
+import org.apache.flink.ml.common.distance.DistanceMeasure;
+import org.apache.flink.ml.common.param.HasBatchStrategy;
+import org.apache.flink.ml.linalg.BLAS;
+import org.apache.flink.ml.linalg.DenseVector;
+import org.apache.flink.ml.linalg.Vectors;
+import org.apache.flink.ml.linalg.typeinfo.DenseVectorTypeInfo;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.runtime.state.StateInitializationContext;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
+import org.apache.flink.streaming.api.operators.TwoInputStreamOperator;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import 
org.apache.flink.table.api.bridge.java.internal.StreamTableEnvironmentImpl;
+import org.apache.flink.table.api.internal.TableImpl;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.commons.collections.IteratorUtils;
+import org.apache.commons.lang3.ArrayUtils;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+
+/**
+ * StreamingKMeans extends the function of {@link KMeans}, supporting to train 
a K-Means model
+ * continuously according to an unbounded stream of train data.
+ */
+public class StreamingKMeans
+implements Estimator,
+StreamingKMeansParams {
+private final Map, Object> paramMap = new HashMap<>();
+private Table initModelDataTable;
+
+public StreamingKMeans() {
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+}
+
+public StreamingKMeans(Table... initModelDataTables) {
+Preconditions.checkArgument(initModelDataTables.length == 1);
+this.initModelDataTable = initModelDataTables[0];
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+setInitMode("direct");
+}
+
+@Override
+public StreamingKMeansModel fit(Table... inputs) {
+Preconditions.checkArgument(inputs.length == 1);
+
Preconditions.checkArgument(HasBatchStrategy.COUNT_STRATEGY.equals(getBatchStrategy()));
+
+StreamTableEnvironment tEnv =
+(StreamTableEnvironment) ((TableImpl) 
inputs[0]).getTableEnvironment();
+StreamExecutionEnvironment env = ((StreamTableEnvironmentImpl) 
tEnv).execEnv();
+
+DataStream points =
+tEnv.toDataStream(inputs[0]).map(new 
FeaturesExtractor(getFeaturesCol()));
+points.getTransformation().setParallelism(1);
+
+DataStream initModelDataStream;
+if (getInitMode().equals("random")) {
+initModelDataStream = createRandomCentroids(env, getDims(), 

[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830430626



##
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/StreamingKMeans.java
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.clustering.kmeans;
+
+import org.apache.flink.api.common.functions.AggregateFunction;
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.state.ListState;
+import org.apache.flink.api.common.state.ListStateDescriptor;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
+import org.apache.flink.api.java.typeutils.TupleTypeInfo;
+import org.apache.flink.iteration.DataStreamList;
+import org.apache.flink.iteration.IterationBody;
+import org.apache.flink.iteration.IterationBodyResult;
+import org.apache.flink.iteration.Iterations;
+import org.apache.flink.ml.api.Estimator;
+import org.apache.flink.ml.common.distance.DistanceMeasure;
+import org.apache.flink.ml.common.param.HasBatchStrategy;
+import org.apache.flink.ml.linalg.BLAS;
+import org.apache.flink.ml.linalg.DenseVector;
+import org.apache.flink.ml.linalg.Vectors;
+import org.apache.flink.ml.linalg.typeinfo.DenseVectorTypeInfo;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.runtime.state.StateInitializationContext;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
+import org.apache.flink.streaming.api.operators.TwoInputStreamOperator;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import 
org.apache.flink.table.api.bridge.java.internal.StreamTableEnvironmentImpl;
+import org.apache.flink.table.api.internal.TableImpl;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.commons.collections.IteratorUtils;
+import org.apache.commons.lang3.ArrayUtils;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+
+/**
+ * StreamingKMeans extends the function of {@link KMeans}, supporting to train 
a K-Means model
+ * continuously according to an unbounded stream of train data.
+ */
+public class StreamingKMeans
+implements Estimator,
+StreamingKMeansParams {
+private final Map, Object> paramMap = new HashMap<>();
+private Table initModelDataTable;
+
+public StreamingKMeans() {
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+}
+
+public StreamingKMeans(Table... initModelDataTables) {
+Preconditions.checkArgument(initModelDataTables.length == 1);
+this.initModelDataTable = initModelDataTables[0];
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+setInitMode("direct");
+}
+
+@Override
+public StreamingKMeansModel fit(Table... inputs) {
+Preconditions.checkArgument(inputs.length == 1);
+
Preconditions.checkArgument(HasBatchStrategy.COUNT_STRATEGY.equals(getBatchStrategy()));
+
+StreamTableEnvironment tEnv =
+(StreamTableEnvironment) ((TableImpl) 
inputs[0]).getTableEnvironment();
+StreamExecutionEnvironment env = ((StreamTableEnvironmentImpl) 
tEnv).execEnv();
+
+DataStream points =
+tEnv.toDataStream(inputs[0]).map(new 
FeaturesExtractor(getFeaturesCol()));
+points.getTransformation().setParallelism(1);
+
+DataStream initModelDataStream;
+if (getInitMode().equals("random")) {
+initModelDataStream = createRandomCentroids(env, getDims(), 

[GitHub] [flink] flinkbot edited a comment on pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19162:
URL: https://github.com/apache/flink/pull/19162#issuecomment-1072924592


   
   ## CI report:
   
   * d795bae7e9236e1031c2de2dd1c75c28a863231c Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33391)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


flinkbot commented on pull request #19162:
URL: https://github.com/apache/flink/pull/19162#issuecomment-1072924592


   
   ## CI report:
   
   * d795bae7e9236e1031c2de2dd1c75c28a863231c UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830429628



##
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/StreamingKMeans.java
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.clustering.kmeans;
+
+import org.apache.flink.api.common.functions.AggregateFunction;
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.state.ListState;
+import org.apache.flink.api.common.state.ListStateDescriptor;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
+import org.apache.flink.api.java.typeutils.TupleTypeInfo;
+import org.apache.flink.iteration.DataStreamList;
+import org.apache.flink.iteration.IterationBody;
+import org.apache.flink.iteration.IterationBodyResult;
+import org.apache.flink.iteration.Iterations;
+import org.apache.flink.ml.api.Estimator;
+import org.apache.flink.ml.common.distance.DistanceMeasure;
+import org.apache.flink.ml.common.param.HasBatchStrategy;
+import org.apache.flink.ml.linalg.BLAS;
+import org.apache.flink.ml.linalg.DenseVector;
+import org.apache.flink.ml.linalg.Vectors;
+import org.apache.flink.ml.linalg.typeinfo.DenseVectorTypeInfo;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.runtime.state.StateInitializationContext;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
+import org.apache.flink.streaming.api.operators.TwoInputStreamOperator;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import 
org.apache.flink.table.api.bridge.java.internal.StreamTableEnvironmentImpl;
+import org.apache.flink.table.api.internal.TableImpl;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.commons.collections.IteratorUtils;
+import org.apache.commons.lang3.ArrayUtils;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+
+/**
+ * StreamingKMeans extends the function of {@link KMeans}, supporting to train 
a K-Means model
+ * continuously according to an unbounded stream of train data.
+ */
+public class StreamingKMeans
+implements Estimator,
+StreamingKMeansParams {
+private final Map, Object> paramMap = new HashMap<>();
+private Table initModelDataTable;
+
+public StreamingKMeans() {
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+}
+
+public StreamingKMeans(Table... initModelDataTables) {
+Preconditions.checkArgument(initModelDataTables.length == 1);
+this.initModelDataTable = initModelDataTables[0];
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+setInitMode("direct");
+}
+
+@Override
+public StreamingKMeansModel fit(Table... inputs) {
+Preconditions.checkArgument(inputs.length == 1);
+
Preconditions.checkArgument(HasBatchStrategy.COUNT_STRATEGY.equals(getBatchStrategy()));
+
+StreamTableEnvironment tEnv =
+(StreamTableEnvironment) ((TableImpl) 
inputs[0]).getTableEnvironment();
+StreamExecutionEnvironment env = ((StreamTableEnvironmentImpl) 
tEnv).execEnv();
+
+DataStream points =
+tEnv.toDataStream(inputs[0]).map(new 
FeaturesExtractor(getFeaturesCol()));
+points.getTransformation().setParallelism(1);
+
+DataStream initModelDataStream;
+if (getInitMode().equals("random")) {
+initModelDataStream = createRandomCentroids(env, getDims(), 

[GitHub] [flink] liyubin117 opened a new pull request #19162: [FLINK-26578][BP-1.15][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


liyubin117 opened a new pull request #19162:
URL: https://github.com/apache/flink/pull/19162


   1.15 BP for parent PR https://github.com/apache/flink/pull/19100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830429430



##
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/StreamingKMeans.java
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.clustering.kmeans;
+
+import org.apache.flink.api.common.functions.AggregateFunction;
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.state.ListState;
+import org.apache.flink.api.common.state.ListStateDescriptor;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
+import org.apache.flink.api.java.typeutils.TupleTypeInfo;
+import org.apache.flink.iteration.DataStreamList;
+import org.apache.flink.iteration.IterationBody;
+import org.apache.flink.iteration.IterationBodyResult;
+import org.apache.flink.iteration.Iterations;
+import org.apache.flink.ml.api.Estimator;
+import org.apache.flink.ml.common.distance.DistanceMeasure;
+import org.apache.flink.ml.common.param.HasBatchStrategy;
+import org.apache.flink.ml.linalg.BLAS;
+import org.apache.flink.ml.linalg.DenseVector;
+import org.apache.flink.ml.linalg.Vectors;
+import org.apache.flink.ml.linalg.typeinfo.DenseVectorTypeInfo;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.runtime.state.StateInitializationContext;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
+import org.apache.flink.streaming.api.operators.TwoInputStreamOperator;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import 
org.apache.flink.table.api.bridge.java.internal.StreamTableEnvironmentImpl;
+import org.apache.flink.table.api.internal.TableImpl;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.commons.collections.IteratorUtils;
+import org.apache.commons.lang3.ArrayUtils;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+
+/**
+ * StreamingKMeans extends the function of {@link KMeans}, supporting to train 
a K-Means model
+ * continuously according to an unbounded stream of train data.
+ */
+public class StreamingKMeans
+implements Estimator,
+StreamingKMeansParams {
+private final Map, Object> paramMap = new HashMap<>();
+private Table initModelDataTable;
+
+public StreamingKMeans() {
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+}
+
+public StreamingKMeans(Table... initModelDataTables) {
+Preconditions.checkArgument(initModelDataTables.length == 1);
+this.initModelDataTable = initModelDataTables[0];
+ParamUtils.initializeMapWithDefaultValues(paramMap, this);
+setInitMode("direct");
+}
+
+@Override
+public StreamingKMeansModel fit(Table... inputs) {
+Preconditions.checkArgument(inputs.length == 1);
+
Preconditions.checkArgument(HasBatchStrategy.COUNT_STRATEGY.equals(getBatchStrategy()));
+
+StreamTableEnvironment tEnv =
+(StreamTableEnvironment) ((TableImpl) 
inputs[0]).getTableEnvironment();
+StreamExecutionEnvironment env = ((StreamTableEnvironmentImpl) 
tEnv).execEnv();
+
+DataStream points =
+tEnv.toDataStream(inputs[0]).map(new 
FeaturesExtractor(getFeaturesCol()));
+points.getTransformation().setParallelism(1);

Review comment:
   Sounds good. Let's leave it as a TODO and explain it in the Java doc.




-- 
This is an automated message from the Apache Git Service.
To 

[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830429315



##
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasDecayFactor.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.common.param;
+
+import org.apache.flink.ml.param.DoubleParam;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.param.ParamValidators;
+import org.apache.flink.ml.param.WithParams;
+
+/** Interface for the shared decay factor param. */
+public interface HasDecayFactor extends WithParams {
+Param DECAY_FACTOR =
+new DoubleParam(
+"decayFactor",
+"The forgetfulness of the previous centroids.",
+0.,
+ParamValidators.gtEq(0));

Review comment:
   Sounds good. Let's limit to be smaller than 1 for now.

##
File path: 
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasDecayFactor.java
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.common.param;
+
+import org.apache.flink.ml.param.DoubleParam;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.param.ParamValidators;
+import org.apache.flink.ml.param.WithParams;
+
+/** Interface for the shared decay factor param. */
+public interface HasDecayFactor extends WithParams {
+Param DECAY_FACTOR =
+new DoubleParam(
+"decayFactor",
+"The forgetfulness of the previous centroids.",
+0.,
+ParamValidators.gtEq(0));

Review comment:
   Sounds good. Let's limit it to be smaller than 1 for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830429261



##
File path: 
flink-ml-lib/src/test/java/org/apache/flink/ml/util/MockMessageQueues.java
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.util;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.LinkedBlockingQueue;
+import java.util.concurrent.TimeUnit;
+
+/** A class that manages global message queues used in unit tests. */
+@SuppressWarnings({"unchecked", "rawtypes"})
+public class MockMessageQueues {
+private static final Map queueMap = new HashMap<>();
+private static long counter = 0;
+
+public static synchronized String createMessageQueue() {
+String id = String.valueOf(counter);
+queueMap.put(id, new LinkedBlockingQueue<>());
+counter++;
+return id;
+}
+
+@SafeVarargs
+public static  void offerAll(String id, T... values) throws 
InterruptedException {
+for (T value : values) {
+offer(id, value);
+}
+}
+
+public static  void offer(String id, T value) throws 
InterruptedException {
+offer(id, value, 1, TimeUnit.MINUTES);
+}
+
+public static  void offer(String id, T value, long timeout, TimeUnit 
unit)
+throws InterruptedException {
+boolean success = queueMap.get(id).offer(value, timeout, unit);
+if (!success) {
+throw new RuntimeException(
+"Failed to offer " + value + " to blocking queue " + id + 
".");
+}
+}
+
+public static  List poll(String id, int num) throws 
InterruptedException {
+List result = new ArrayList<>();
+for (int i = 0; i < num; i++) {
+result.add(poll(id));
+}
+return result;
+}
+
+public static  T poll(String id) throws InterruptedException {
+return poll(id, 1, TimeUnit.MINUTES);
+}
+
+public static  T poll(String id, long timeout, TimeUnit unit) throws 
InterruptedException {
+T value = (T) queueMap.get(id).poll(timeout, unit);
+if (value == null) {
+throw new RuntimeException("Failed to poll next value from 
blocking queue " + id + ".");
+}
+return value;
+}
+
+public static void deleteBlockingQueue(String id) {

Review comment:
   I see. Do you think the logic would be simpler by introducing a `group` 
concept, similar to that of metric group?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830429072



##
File path: flink-ml-lib/src/test/java/org/apache/flink/ml/util/MockKVStore.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.util;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/** Class that manages global key-value pairs used in unit tests. */
+@SuppressWarnings({"unchecked"})
+public class MockKVStore {

Review comment:
   I see. Do you think we can replace `TestMetricReporter ` with Flink's 
InMemoryReporter? I left more details in another comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830429072



##
File path: flink-ml-lib/src/test/java/org/apache/flink/ml/util/MockKVStore.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.util;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/** Class that manages global key-value pairs used in unit tests. */
+@SuppressWarnings({"unchecked"})
+public class MockKVStore {

Review comment:
   I see. Do you think we can replace `TestMetricReporter ` with Flink's 
InMemoryReporter?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830428974



##
File path: flink-ml-lib/src/test/java/org/apache/flink/ml/util/MockKVStore.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.util;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/** Class that manages global key-value pairs used in unit tests. */
+@SuppressWarnings({"unchecked"})
+public class MockKVStore {
+private static final Map map = new HashMap<>();
+
+private static long counter = 0;
+
+/**
+ * Returns a prefix string to make sure key-value pairs created in 
different test cases would
+ * not have the same key.
+ */
+public static synchronized String createNonDuplicatePrefix() {

Review comment:
   In practice it is extremely unlikely that two randomly generated int64 
values collide with each other. This is called `statistically unique`.
   
   According to the Javadoc of Flink's JobID, the JobID is statistically 
unique. And Flink already relies on this kind of uniqueness to differentiate 
multiple Flink jobs in the same Flink session in production. It seems that 
there is no need for strict uniqueness in our tests?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink-ml] lindong28 commented on a change in pull request #70: [FLINK-26313] Support Online KMeans in Flink ML

2022-03-18 Thread GitBox


lindong28 commented on a change in pull request #70:
URL: https://github.com/apache/flink-ml/pull/70#discussion_r830079643



##
File path: 
flink-ml-lib/src/test/java/org/apache/flink/ml/util/TestMetricReporter.java
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.util;
+
+import org.apache.flink.metrics.Gauge;
+import org.apache.flink.metrics.Metric;
+import org.apache.flink.metrics.MetricConfig;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.metrics.reporter.MetricReporter;
+import org.apache.flink.metrics.reporter.Scheduled;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/** A subclass of {@link MetricReporter} that outputs metrics to a global map. 
*/
+public class TestMetricReporter implements MetricReporter, Scheduled {

Review comment:
   Is there anyway to re-use `InMemoryReporter` from Flink? According to 
its Java doc, it seems that `InMemoryReporter` should exactly meet the purpose 
of this class. 
   
   And the `MetricGroup` used in `InMemoryReporter` could be used to fulfill 
the purpose of the prefix here.
   
   Instead of storing/featuring metrics values in a map, could we instead just 
get the metric object directly like this:
   
   
   `((Gauge) InMemoryReporter::findMetric(...).get()).getValue()`

##
File path: 
flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/OnlineKMeansTest.java
##
@@ -0,0 +1,511 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.clustering;
+
+import org.apache.flink.api.common.restartstrategy.RestartStrategies;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.ml.clustering.kmeans.KMeans;
+import org.apache.flink.ml.clustering.kmeans.KMeansModel;
+import org.apache.flink.ml.clustering.kmeans.KMeansModelData;
+import org.apache.flink.ml.clustering.kmeans.OnlineKMeans;
+import org.apache.flink.ml.clustering.kmeans.OnlineKMeansModel;
+import org.apache.flink.ml.common.distance.EuclideanDistanceMeasure;
+import org.apache.flink.ml.linalg.DenseVector;
+import org.apache.flink.ml.linalg.Vectors;
+import org.apache.flink.ml.linalg.typeinfo.DenseVectorTypeInfo;
+import org.apache.flink.ml.util.GlobalBlockingQueues;
+import org.apache.flink.ml.util.MockSinkFunction;
+import org.apache.flink.ml.util.MockSourceFunction;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.ml.util.StageTestUtils;
+import org.apache.flink.ml.util.TestMetricReporter;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import 
org.apache.flink.streaming.api.environment.ExecutionCheckpointingOptions;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.Schema;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.types.Row;
+
+import org.apache.commons.collections.CollectionUtils;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;

[GitHub] [flink] flinkbot edited a comment on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18757:
URL: https://github.com/apache/flink/pull/18757#issuecomment-1039117115


   
   ## CI report:
   
   * 989d2280eae23b9a9fda017ef9b686332aaef134 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19152: [FLINK-26692][e2e] migrate TpcdsTestProgram.java to new source

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19152:
URL: https://github.com/apache/flink/pull/19152#issuecomment-1072298017


   
   ## CI report:
   
   * 14454d0b4f4047b1bfb5f71d131460e7bc6987e8 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33377)
 
   * a3674835e935ea4ed2e413b1793832ebc4fe7349 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33390)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] liyubin117 commented on pull request #19100: [FLINK-26578][docs-zh] Translate new Project Configuration section to Chinese

2022-03-18 Thread GitBox


liyubin117 commented on pull request #19100:
URL: https://github.com/apache/flink/pull/19100#issuecomment-1072916331


   @MartijnVisser sure, I'm doing this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19152: [FLINK-26692][e2e] migrate TpcdsTestProgram.java to new source

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19152:
URL: https://github.com/apache/flink/pull/19152#issuecomment-1072298017


   
   ## CI report:
   
   * 14454d0b4f4047b1bfb5f71d131460e7bc6987e8 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33377)
 
   * a3674835e935ea4ed2e413b1793832ebc4fe7349 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19159: [FLINK-26334][datastream] for 1.15.0 . Modified getWindowStartWithOff…

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19159:
URL: https://github.com/apache/flink/pull/19159#issuecomment-1072596043


   
   ## CI report:
   
   * 21b34eb2c804172ab81ef3b7a327fff2787b9c4f Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33379)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19154: [FLINK-26690][BP-1.15][runtime] Makes globalCleanupAsync call the removal even if the JobGraph is not put into the JobGraphStore, yet

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19154:
URL: https://github.com/apache/flink/pull/19154#issuecomment-1072332575


   
   ## CI report:
   
   * 1a02afeb17a60d5ab1302995b6e0d3bde9bd4b38 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33371)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19159: [FLINK-26334][datastream] for 1.15.0 . Modified getWindowStartWithOff…

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19159:
URL: https://github.com/apache/flink/pull/19159#issuecomment-1072596043


   
   ## CI report:
   
   * 21b34eb2c804172ab81ef3b7a327fff2787b9c4f Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33379)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19159: [FLINK-26334][datastream] for 1.15.0 . Modified getWindowStartWithOff…

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19159:
URL: https://github.com/apache/flink/pull/19159#issuecomment-1072596043


   
   ## CI report:
   
   * 21b34eb2c804172ab81ef3b7a327fff2787b9c4f Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33379)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] realdengziqi commented on pull request #19159: [FLINK-26334][datastream] for 1.15.0 . Modified getWindowStartWithOff…

2022-03-18 Thread GitBox


realdengziqi commented on pull request #19159:
URL: https://github.com/apache/flink/pull/19159#issuecomment-1072909559


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18757:
URL: https://github.com/apache/flink/pull/18757#issuecomment-1039117115


   
   ## CI report:
   
   * 989d2280eae23b9a9fda017ef9b686332aaef134 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18757:
URL: https://github.com/apache/flink/pull/18757#issuecomment-1039117115


   
   ## CI report:
   
   * 989d2280eae23b9a9fda017ef9b686332aaef134 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wanglijie95 commented on pull request #18757: [FLINK-25226][doc] Add documentation about the AdaptiveBatchScheduler

2022-03-18 Thread GitBox


wanglijie95 commented on pull request #18757:
URL: https://github.com/apache/flink/pull/18757#issuecomment-1072907768


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19154: [FLINK-26690][BP-1.15][runtime] Makes globalCleanupAsync call the removal even if the JobGraph is not put into the JobGraphStore, yet

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19154:
URL: https://github.com/apache/flink/pull/19154#issuecomment-1072332575


   
   ## CI report:
   
   * 1a02afeb17a60d5ab1302995b6e0d3bde9bd4b38 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33371)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1027812195


   
   ## CI report:
   
   * 86d2d0a163fa0a0d018bb75203f0c85f54febf0c Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33386)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19154: [FLINK-26690][BP-1.15][runtime] Makes globalCleanupAsync call the removal even if the JobGraph is not put into the JobGraphStore, yet

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19154:
URL: https://github.com/apache/flink/pull/19154#issuecomment-1072332575


   
   ## CI report:
   
   * 1a02afeb17a60d5ab1302995b6e0d3bde9bd4b38 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33371)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] gaoyunhaii commented on pull request #19154: [FLINK-26690][BP-1.15][runtime] Makes globalCleanupAsync call the removal even if the JobGraph is not put into the JobGraphStore, yet

2022-03-18 Thread GitBox


gaoyunhaii commented on pull request #19154:
URL: https://github.com/apache/flink/pull/19154#issuecomment-1072901979


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] RocMarshal commented on pull request #17560: [FLINK-22315][table] Support ADD column/constraint/watermark for ALTER TABLE statement.

2022-03-18 Thread GitBox


RocMarshal commented on pull request #17560:
URL: https://github.com/apache/flink/pull/17560#issuecomment-1072899598


   Please let me know what is your expectation in the  jira. thx a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-107225


   
   ## CI report:
   
   * f21c64d64e3b391f7259931f97799de607afae84 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19158: [FLINK-26334][datastream] for 1.14.0 . Modified getWindowStartWithOff…

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19158:
URL: https://github.com/apache/flink/pull/19158#issuecomment-1072551258


   
   ## CI report:
   
   * a2eb4bc43077668f7f9bddc51aa3eb8de9386b0a Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33376)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19151: [FLINK-26733][table-api-java][python] Deprecate TableConfig ctor and options

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19151:
URL: https://github.com/apache/flink/pull/19151#issuecomment-1072276119


   
   ## CI report:
   
   * 1b76b4f9ea59c4bdbb41a5e36e9c9d17b4becd6d Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33382)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-107225


   
   ## CI report:
   
   * f21c64d64e3b391f7259931f97799de607afae84 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19161: [FLINK-26736][tests][JUnit5 migration] flink-avro-confluent-registry

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19161:
URL: https://github.com/apache/flink/pull/19161#issuecomment-1072663756


   
   ## CI report:
   
   * d47af79f7ad58d4c31fa1b392a72466e3008332e Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33383)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-107225


   
   ## CI report:
   
   * f21c64d64e3b391f7259931f97799de607afae84 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-25797) Translate datastream/formats/parquet.md page into Chinese.

2022-03-18 Thread Martijn Visser (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-25797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509102#comment-17509102
 ] 

Martijn Visser commented on FLINK-25797:


Fixed in master: 0f4b17c534ca092b290115e00f17138312ccad15

> Translate datastream/formats/parquet.md page into Chinese.
> --
>
> Key: FLINK-25797
> URL: https://issues.apache.org/jira/browse/FLINK-25797
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation
>Reporter: RocMarshal
>Priority: Minor
>  Labels: chinese-translation, pull-request-available
> Fix For: 1.16.0
>
>
> file: docs/content.zh/docs/connectors/datastream/formats/parquet.md



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-25797) Translate datastream/formats/parquet.md page into Chinese.

2022-03-18 Thread Martijn Visser (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-25797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Visser updated FLINK-25797:
---
Fix Version/s: 1.16.0

> Translate datastream/formats/parquet.md page into Chinese.
> --
>
> Key: FLINK-25797
> URL: https://issues.apache.org/jira/browse/FLINK-25797
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation
>Reporter: RocMarshal
>Priority: Minor
>  Labels: chinese-translation, pull-request-available
> Fix For: 1.16.0
>
>
> file: docs/content.zh/docs/connectors/datastream/formats/parquet.md



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] MartijnVisser commented on pull request #18646: [FLINK-25797][docs-zh] Translate datastream/formats/parquet.md page into Chinese.

2022-03-18 Thread GitBox


MartijnVisser commented on pull request #18646:
URL: https://github.com/apache/flink/pull/18646#issuecomment-1072869657


   @wangzhiwubigdata Thanks for the PR - Can you also create the backport to 
release-1.15 branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] MartijnVisser merged pull request #18646: [FLINK-25797][docs-zh] Translate datastream/formats/parquet.md page into Chinese.

2022-03-18 Thread GitBox


MartijnVisser merged pull request #18646:
URL: https://github.com/apache/flink/pull/18646


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] MartijnVisser commented on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos

2022-03-18 Thread GitBox


MartijnVisser commented on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-1072868814


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-26381) Wrong document order of Chinese version

2022-03-18 Thread Martijn Visser (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-26381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17509101#comment-17509101
 ] 

Martijn Visser commented on FLINK-26381:


Fixed in master: 48cf55c36fe7c35c827f063e4016669328aa774e 

> Wrong document order of Chinese version
> ---
>
> Key: FLINK-26381
> URL: https://issues.apache.org/jira/browse/FLINK-26381
> Project: Flink
>  Issue Type: Bug
>  Components: chinese-translation
>Affects Versions: 1.14.3
>Reporter: tonny
>Assignee: Yao Zhang
>Priority: Major
>  Labels: pull-request-available
>
> The chapter named "流式分析"(streaming analytics) and "数据管道 & ETL"(Data Pipelines 
> & ETL) under the "实践练习"(Learn Flink) are transposed compared to the English 
> version. 
> It causes important concepts such as "keyed state", "map" missed to solve the 
> exercise in the chapter of streaming analytics.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (FLINK-26381) Wrong document order of Chinese version

2022-03-18 Thread Martijn Visser (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Visser updated FLINK-26381:
---
Fix Version/s: 1.16.0

> Wrong document order of Chinese version
> ---
>
> Key: FLINK-26381
> URL: https://issues.apache.org/jira/browse/FLINK-26381
> Project: Flink
>  Issue Type: Bug
>  Components: chinese-translation
>Affects Versions: 1.14.3
>Reporter: tonny
>Assignee: Yao Zhang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.16.0
>
>
> The chapter named "流式分析"(streaming analytics) and "数据管道 & ETL"(Data Pipelines 
> & ETL) under the "实践练习"(Learn Flink) are transposed compared to the English 
> version. 
> It causes important concepts such as "keyed state", "map" missed to solve the 
> exercise in the chapter of streaming analytics.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] flinkbot edited a comment on pull request #19159: [FLINK-26334][datastream] for 1.15.0 . Modified getWindowStartWithOff…

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19159:
URL: https://github.com/apache/flink/pull/19159#issuecomment-1072596043


   
   ## CI report:
   
   * 21b34eb2c804172ab81ef3b7a327fff2787b9c4f Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33379)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] MartijnVisser commented on pull request #19010: [FLINK-26381][docs] Wrong document order of Chinese version

2022-03-18 Thread GitBox


MartijnVisser commented on pull request #19010:
URL: https://github.com/apache/flink/pull/19010#issuecomment-1072868174


   Thanks for the PR @paul8263 - Do you also want to create backports to 
release-1.15 and release-1.14?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (FLINK-26381) Wrong document order of Chinese version

2022-03-18 Thread Martijn Visser (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Visser reassigned FLINK-26381:
--

Assignee: Yao Zhang  (was: Kent Yao)

> Wrong document order of Chinese version
> ---
>
> Key: FLINK-26381
> URL: https://issues.apache.org/jira/browse/FLINK-26381
> Project: Flink
>  Issue Type: Bug
>  Components: chinese-translation
>Affects Versions: 1.14.3
>Reporter: tonny
>Assignee: Yao Zhang
>Priority: Major
>  Labels: pull-request-available
>
> The chapter named "流式分析"(streaming analytics) and "数据管道 & ETL"(Data Pipelines 
> & ETL) under the "实践练习"(Learn Flink) are transposed compared to the English 
> version. 
> It causes important concepts such as "keyed state", "map" missed to solve the 
> exercise in the chapter of streaming analytics.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] MartijnVisser merged pull request #19010: [FLINK-26381][docs] Wrong document order of Chinese version

2022-03-18 Thread GitBox


MartijnVisser merged pull request #19010:
URL: https://github.com/apache/flink/pull/19010


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (FLINK-26381) Wrong document order of Chinese version

2022-03-18 Thread Martijn Visser (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Visser reassigned FLINK-26381:
--

Assignee: Kent Yao

> Wrong document order of Chinese version
> ---
>
> Key: FLINK-26381
> URL: https://issues.apache.org/jira/browse/FLINK-26381
> Project: Flink
>  Issue Type: Bug
>  Components: chinese-translation
>Affects Versions: 1.14.3
>Reporter: tonny
>Assignee: Kent Yao
>Priority: Major
>  Labels: pull-request-available
>
> The chapter named "流式分析"(streaming analytics) and "数据管道 & ETL"(Data Pipelines 
> & ETL) under the "实践练习"(Learn Flink) are transposed compared to the English 
> version. 
> It causes important concepts such as "keyed state", "map" missed to solve the 
> exercise in the chapter of streaming analytics.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (FLINK-26716) Migrate PostgreSQL tests to Testcontainers

2022-03-18 Thread Martijn Visser (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-26716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn Visser closed FLINK-26716.
--
Fix Version/s: 1.16.0
   Resolution: Fixed

Fixed in master: 0b09d340e26550cc044b8dc91b30f6e59e8d8cf0

> Migrate PostgreSQL tests to Testcontainers
> --
>
> Key: FLINK-26716
> URL: https://issues.apache.org/jira/browse/FLINK-26716
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC, Tests
>Reporter: Alexander Fedulov
>Assignee: Alexander Fedulov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.16.0
>
>
> Currently, PostgreSQL tests are executed based on an embedded database.  This 
> has issues on some systems (Mac) and blocked work on FLINK-25926. It is 
> required to migrate those tests to Testcontainers.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [flink] MartijnVisser merged pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers

2022-03-18 Thread GitBox


MartijnVisser merged pull request #19139:
URL: https://github.com/apache/flink/pull/19139


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19010: [FLINK-26381][docs] Wrong document order of Chinese version

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19010:
URL: https://github.com/apache/flink/pull/19010#issuecomment-1061632219


   
   ## CI report:
   
   * 09c14d42d124750fdae6a1d9c7fba13ad03af422 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33350)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19010: [FLINK-26381][docs] Wrong document order of Chinese version

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19010:
URL: https://github.com/apache/flink/pull/19010#issuecomment-1061632219


   
   ## CI report:
   
   * 09c14d42d124750fdae6a1d9c7fba13ad03af422 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33350)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] MartijnVisser commented on pull request #19010: [FLINK-26381][docs] Wrong document order of Chinese version

2022-03-18 Thread GitBox


MartijnVisser commented on pull request #19010:
URL: https://github.com/apache/flink/pull/19010#issuecomment-1072849978


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1027812195


   
   ## CI report:
   
   * 139f14e97567cd797a341be3aa7627be576ba765 Azure: 
[CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33381)
 
   * 86d2d0a163fa0a0d018bb75203f0c85f54febf0c Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33386)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18601: [FLINK-25699][table] Use HashMap for MAP value constructors

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18601:
URL: https://github.com/apache/flink/pull/18601#issuecomment-1027812195


   
   ## CI report:
   
   * 8f4369d6f778a1600b10798cf4a8895506285991 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30655)
 
   * 139f14e97567cd797a341be3aa7627be576ba765 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33381)
 
   * 86d2d0a163fa0a0d018bb75203f0c85f54febf0c UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19113: [FLINK-26519][table] Remove FlinkTypeFactory singleton

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19113:
URL: https://github.com/apache/flink/pull/19113#issuecomment-1068976231


   
   ## CI report:
   
   * b46ded17741b2d0d4c59885da62e218417c32603 UNKNOWN
   * 9500030cc0a1f697f8fd12543ca793b9fa936614 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33375)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19152: [FLINK-26692][e2e] migrate TpcdsTestProgram.java to new source

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19152:
URL: https://github.com/apache/flink/pull/19152#issuecomment-1072298017


   
   ## CI report:
   
   * 14454d0b4f4047b1bfb5f71d131460e7bc6987e8 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33377)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19145: [hotfix][streaming] fix visibility of the instance variable and fix some typos

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19145:
URL: https://github.com/apache/flink/pull/19145#issuecomment-107225


   
   ## CI report:
   
   * f21c64d64e3b391f7259931f97799de607afae84 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33319)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18646: [FLINK-25797][docs-zh] Translate datastream/formats/parquet.md page into Chinese.

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18646:
URL: https://github.com/apache/flink/pull/18646#issuecomment-1031503295


   
   ## CI report:
   
   * cb7d3ffbe8d6e057a68a473747998c3a646e9ce7 UNKNOWN
   * 99da39634ff199e8b4ed95dee2c20d315f568cd7 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33351)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19010: [FLINK-26381][docs] Wrong document order of Chinese version

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19010:
URL: https://github.com/apache/flink/pull/19010#issuecomment-1061632219


   
   ## CI report:
   
   * 09c14d42d124750fdae6a1d9c7fba13ad03af422 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33350)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19160: [FLINK-26723][runtime]fix the error message thrown by SourceCoordinatorContext

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19160:
URL: https://github.com/apache/flink/pull/19160#issuecomment-1072603632


   
   ## CI report:
   
   * 627769a7be4b3e8fe203b520ab5b7f63e0c4ee26 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33380)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19154: [FLINK-26690][BP-1.15][runtime] Makes globalCleanupAsync call the removal even if the JobGraph is not put into the JobGraphStore, yet

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19154:
URL: https://github.com/apache/flink/pull/19154#issuecomment-1072332575


   
   ## CI report:
   
   * 1a02afeb17a60d5ab1302995b6e0d3bde9bd4b38 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33371)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19148: [FLINK-26704][table] Remove string expressions

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19148:
URL: https://github.com/apache/flink/pull/19148#issuecomment-1072242376


   
   ## CI report:
   
   * abe225e36fad6f3388835bf8db2e5115017a4a90 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33369)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19157: [FLINK-25904][metrics] Lazily initialize Percentile

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19157:
URL: https://github.com/apache/flink/pull/19157#issuecomment-1072453581


   
   ## CI report:
   
   * 435ad2cd07c0d43512b956c35c03c9cb2d5544e2 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33370)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #18940: [FLINK-26249][table-planner] Run BuiltInFunctionsTestBase and BuiltInAggregateFunctionsTestBase in parallel

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #18940:
URL: https://github.com/apache/flink/pull/18940#issuecomment-1055381485


   
   ## CI report:
   
   * 4c39fe3579909a7942ea61ff44e692e7f9f914e3 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33378)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19139: [FLINK-26716][test][connectors/jdbc] Migrate PostgreSQL tests to Testcontainers

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19139:
URL: https://github.com/apache/flink/pull/19139#issuecomment-1071653343


   
   ## CI report:
   
   * 55fda9e49a8540391a56145e281d035ceeede8f4 Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33354)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19147: [FLINK-26688] Completely remove unused options from TableConfig

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19147:
URL: https://github.com/apache/flink/pull/19147#issuecomment-1072220032


   
   ## CI report:
   
   * 33a3244f8e8ae96fe39193759b15df409a557dc2 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33366)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] AHeise merged pull request #19131: [FLINK-26701] Revert FLINK-25927 apart from adding connector-base to flink-dist

2022-03-18 Thread GitBox


AHeise merged pull request #19131:
URL: https://github.com/apache/flink/pull/19131


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #19126: [FLINK-26609][python] Support sum operation in KeyedStream

2022-03-18 Thread GitBox


flinkbot edited a comment on pull request #19126:
URL: https://github.com/apache/flink/pull/19126#issuecomment-1070385440


   
   ## CI report:
   
   * a73169d7357a465b3d8b2a647c0ceaa8b435ee24 UNKNOWN
   * bed8769aa0ba4af511384b6e0555db9514be37ec Azure: 
[SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33363)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   3   4   5   6   7   8   9   10   >