[jira] [Created] (FLINK-26792) BufferedMutator failed when insert and update with a flush in Hbase Sink
lothar created FLINK-26792: -- Summary: BufferedMutator failed when insert and update with a flush in Hbase Sink Key: FLINK-26792 URL: https://issues.apache.org/jira/browse/FLINK-26792 Project: Flink Issue Type: Bug Components: Connectors / HBase Reporter: lothar When I write data from Kafka to Hbase(CDC data contains Insert、Update), once the first insert data and update data with same rowkey in a flush, the data will be invalid. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-26781) Link operator doc site to Flink Website
[ https://issues.apache.org/jira/browse/FLINK-26781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenzhengyu updated FLINK-26781: Attachment: image-2022-03-22-13-56-19-084.png > Link operator doc site to Flink Website > --- > > Key: FLINK-26781 > URL: https://issues.apache.org/jira/browse/FLINK-26781 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator, Project Website >Reporter: Gyula Fora >Assignee: chenzhengyu >Priority: Major > Attachments: image-2022-03-22-13-56-19-084.png > > > Now with the doc improvements it is time to link the operator website to the > Flink website similar to other Flink projects (for example: > https://github.com/apache/flink-web/pull/507/files) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FLINK-26791) Finish projection push down for table store
Jingsong Lee created FLINK-26791: Summary: Finish projection push down for table store Key: FLINK-26791 URL: https://issues.apache.org/jira/browse/FLINK-26791 Project: Flink Issue Type: Sub-task Components: Table Store Reporter: Jingsong Lee Fix For: table-store-0.1.0 Now, there are two TODO in table store: * support projection push down for log store * support projection push down for non-primary-key -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-26706) Introduce Ingress URL templating
[ https://issues.apache.org/jira/browse/FLINK-26706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26706: --- Labels: pull-request-available (was: ) > Introduce Ingress URL templating > > > Key: FLINK-26706 > URL: https://issues.apache.org/jira/browse/FLINK-26706 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator >Reporter: Matyas Orhidi >Assignee: Matyas Orhidi >Priority: Major > Labels: pull-request-available > > Instead of the current basic `ingressDomain` based approach, we could > introduce a more advanced templating mechanism. > Check the Spark Operator's approach for reference: > https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/docs/quick-start-guide.md#driver-ui-access-and-ingress > This would eliminate the need for creating `*.example.com` like wildcard DNS > entries. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-26786) Helm chart: Add default container annotation to the operator deployment
[
https://issues.apache.org/jira/browse/FLINK-26786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510233#comment-17510233
]
Yang Wang commented on FLINK-26786:
---
[~haoxin] Thanks for your contribution.
> Helm chart: Add default container annotation to the operator deployment
> ---
>
> Key: FLINK-26786
> URL: https://issues.apache.org/jira/browse/FLINK-26786
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Xin Hao
>Assignee: Xin Hao
>Priority: Minor
> Labels: pull-request-available
>
> Adding a default container annotation to the operator deployment will be a
> bit easier for the users to check logs and others.
> The annotation should look like :
> {code:java}
> kubectl.kubernetes.io/default-container: {{ .Chart.Name }} {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (FLINK-26786) Helm chart: Add default container annotation to the operator deployment
[
https://issues.apache.org/jira/browse/FLINK-26786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Wang updated FLINK-26786:
--
External issue URL: (was:
https://github.com/apache/flink-kubernetes-operator/pull/89)
> Helm chart: Add default container annotation to the operator deployment
> ---
>
> Key: FLINK-26786
> URL: https://issues.apache.org/jira/browse/FLINK-26786
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Xin Hao
>Assignee: Xin Hao
>Priority: Minor
> Labels: pull-request-available
>
> Adding a default container annotation to the operator deployment will be a
> bit easier for the users to check logs and others.
> The annotation should look like :
> {code:java}
> kubectl.kubernetes.io/default-container: {{ .Chart.Name }} {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (FLINK-26786) Helm chart: Add default container annotation to the operator deployment
[
https://issues.apache.org/jira/browse/FLINK-26786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Wang closed FLINK-26786.
-
Resolution: Fixed
Merged via:
main: 856f6f799c67a528d904f2c4f5664f4bae4c68c5
> Helm chart: Add default container annotation to the operator deployment
> ---
>
> Key: FLINK-26786
> URL: https://issues.apache.org/jira/browse/FLINK-26786
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Xin Hao
>Assignee: Xin Hao
>Priority: Minor
> Labels: pull-request-available
>
> Adding a default container annotation to the operator deployment will be a
> bit easier for the users to check logs and others.
> The annotation should look like :
> {code:java}
> kubectl.kubernetes.io/default-container: {{ .Chart.Name }} {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (FLINK-26786) Helm chart: Add default container annotation to the operator deployment
[
https://issues.apache.org/jira/browse/FLINK-26786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-26786:
---
Labels: pull-request-available (was: )
> Helm chart: Add default container annotation to the operator deployment
> ---
>
> Key: FLINK-26786
> URL: https://issues.apache.org/jira/browse/FLINK-26786
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Xin Hao
>Assignee: Xin Hao
>Priority: Minor
> Labels: pull-request-available
>
> Adding a default container annotation to the operator deployment will be a
> bit easier for the users to check logs and others.
> The annotation should look like :
> {code:java}
> kubectl.kubernetes.io/default-container: {{ .Chart.Name }} {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (FLINK-24736) Non vulenerable jar files for Apache Flink 1.14.4
[ https://issues.apache.org/jira/browse/FLINK-24736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parag Somani updated FLINK-24736: - Description: Hello, We are using Apache flink 1.14.4 as one of base image in our production. Due to recent upgrade, we have many container security defects. I am using "flink-1.14.4-bin-scala_2.12"in our k8s env. Please assist with Flink version having non-vulnerable libraries. List of vulnerable libs are as follows: [7.5] [CVE-2019-16869] [flink-rpc-akka-loader] [1.14.4] [9.1] [CVE-2019-20444] [flink-rpc-akka-loader] [1.14.4] [9.1] [CVE-2019-20445] [flink-rpc-akka-loader] [1.14.4] [7.5] [sonatype-2019-0115] [flink-rpc-akka-loader] [1.14.4] [7.5] [sonatype-2020-0029] [flink-rpc-akka-loader] [1.14.4] [7.5] [CVE-2019-16869] [flink-rpc-akka] [1.14.4] [9.1] [CVE-2019-20444] [flink-rpc-akka] [1.14.4] [9.1] [CVE-2019-20445] [flink-rpc-akka] [1.14.4] [7.5] [sonatype-2019-0115] [flink-rpc-akka] [1.14.4] [7.5] [sonatype-2020-0029] [flink-rpc-akka] [1.14.4] Can you assist with this ? was: Hello, We are using Apache flink 1.14.4 as one of base image in our production. Due to recent upgrade, we have many container security defects. I am using "flink-1.14.3-bin-scala_2.12"in our k8s env. Please assist with Flink version having non-vulnerable libraries. List of vulnerable libs are as follows: [7.5] [CVE-2019-16869] [flink-rpc-akka-loader] [1.14.4] [9.1] [CVE-2019-20444] [flink-rpc-akka-loader] [1.14.4] [9.1] [CVE-2019-20445] [flink-rpc-akka-loader] [1.14.4] [7.5] [sonatype-2019-0115] [flink-rpc-akka-loader] [1.14.4] [7.5] [sonatype-2020-0029] [flink-rpc-akka-loader] [1.14.4] [7.5] [CVE-2019-16869] [flink-rpc-akka] [1.14.4] [9.1] [CVE-2019-20444] [flink-rpc-akka] [1.14.4] [9.1] [CVE-2019-20445] [flink-rpc-akka] [1.14.4] [7.5] [sonatype-2019-0115] [flink-rpc-akka] [1.14.4] [7.5] [sonatype-2020-0029] [flink-rpc-akka] [1.14.4] Can you assist with this ? > Non vulenerable jar files for Apache Flink 1.14.4 > - > > Key: FLINK-24736 > URL: https://issues.apache.org/jira/browse/FLINK-24736 > Project: Flink > Issue Type: Bug >Reporter: Parag Somani >Priority: Major > > Hello, > We are using Apache flink 1.14.4 as one of base image in our production. Due > to recent upgrade, we have many container security defects. > I am using "flink-1.14.4-bin-scala_2.12"in our k8s env. > Please assist with Flink version having non-vulnerable libraries. List of > vulnerable libs are as follows: > [7.5] [CVE-2019-16869] [flink-rpc-akka-loader] [1.14.4] > [9.1] [CVE-2019-20444] [flink-rpc-akka-loader] [1.14.4] > [9.1] [CVE-2019-20445] [flink-rpc-akka-loader] [1.14.4] > [7.5] [sonatype-2019-0115] [flink-rpc-akka-loader] [1.14.4] > [7.5] [sonatype-2020-0029] [flink-rpc-akka-loader] [1.14.4] > [7.5] [CVE-2019-16869] [flink-rpc-akka] [1.14.4] > [9.1] [CVE-2019-20444] [flink-rpc-akka] [1.14.4] > [9.1] [CVE-2019-20445] [flink-rpc-akka] [1.14.4] > [7.5] [sonatype-2019-0115] [flink-rpc-akka] [1.14.4] > [7.5] [sonatype-2020-0029] [flink-rpc-akka] [1.14.4] > Can you assist with this ? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-24736) Non vulenerable jar files for Apache Flink 1.14.4
[ https://issues.apache.org/jira/browse/FLINK-24736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parag Somani updated FLINK-24736: - Description: Hello, We are using Apache flink 1.14.4 as one of base image in our production. Due to recent upgrade, we have many container security defects. I am using "flink-1.14.3-bin-scala_2.12"in our k8s env. Please assist with Flink version having non-vulnerable libraries. List of vulnerable libs are as follows: [7.5] [CVE-2019-16869] [flink-rpc-akka-loader] [1.14.4] [9.1] [CVE-2019-20444] [flink-rpc-akka-loader] [1.14.4] [9.1] [CVE-2019-20445] [flink-rpc-akka-loader] [1.14.4] [7.5] [sonatype-2019-0115] [flink-rpc-akka-loader] [1.14.4] [7.5] [sonatype-2020-0029] [flink-rpc-akka-loader] [1.14.4] [7.5] [CVE-2019-16869] [flink-rpc-akka] [1.14.4] [9.1] [CVE-2019-20444] [flink-rpc-akka] [1.14.4] [9.1] [CVE-2019-20445] [flink-rpc-akka] [1.14.4] [7.5] [sonatype-2019-0115] [flink-rpc-akka] [1.14.4] [7.5] [sonatype-2020-0029] [flink-rpc-akka] [1.14.4] Can you assist with this ? was: Hello, We are using Apache flink 1.14.3as one of base image in our production. Due to recent upgrade, we have many container security defects. I am using "flink-1.14.3-bin-scala_2.12"in our k8s env. Please assist with Flink version having non-vulnerable libraries. List of vulnerable libs are as follows: [7.5] [sonatype-2020-0029] [flink-rpc-akka] [1.14.3] [9.1] [CVE-2019-20445] [flink-rpc-akka] [1.14.3] [9.1] [CVE-2019-20444] [flink-rpc-akka] [1.14.3] [7.5] [CVE-2019-16869] [flink-rpc-akka] [1.14.3] [7.5] [sonatype-2020-0029] [flink-rpc-akka-loader] [1.14.3] [9.1] [CVE-2019-20445] [flink-rpc-akka-loader] [1.14.3] [9.1] [CVE-2019-20444] [flink-rpc-akka-loader] [1.14.3] [7.5] [CVE-2019-16869] [flink-rpc-akka-loader] [1.14.3] Can you assist with this ? Summary: Non vulenerable jar files for Apache Flink 1.14.4 (was: Non vulenerable jar files for Apache Flink 1.14.3) Updating description as we have updated to latest version of apache flink 1.14.4. Please assist to have non-vulnerable libs for the same. > Non vulenerable jar files for Apache Flink 1.14.4 > - > > Key: FLINK-24736 > URL: https://issues.apache.org/jira/browse/FLINK-24736 > Project: Flink > Issue Type: Bug >Reporter: Parag Somani >Priority: Major > > Hello, > We are using Apache flink 1.14.4 as one of base image in our production. Due > to recent upgrade, we have many container security defects. > I am using "flink-1.14.3-bin-scala_2.12"in our k8s env. > Please assist with Flink version having non-vulnerable libraries. List of > vulnerable libs are as follows: > [7.5] [CVE-2019-16869] [flink-rpc-akka-loader] [1.14.4] > [9.1] [CVE-2019-20444] [flink-rpc-akka-loader] [1.14.4] > [9.1] [CVE-2019-20445] [flink-rpc-akka-loader] [1.14.4] > [7.5] [sonatype-2019-0115] [flink-rpc-akka-loader] [1.14.4] > [7.5] [sonatype-2020-0029] [flink-rpc-akka-loader] [1.14.4] > [7.5] [CVE-2019-16869] [flink-rpc-akka] [1.14.4] > [9.1] [CVE-2019-20444] [flink-rpc-akka] [1.14.4] > [9.1] [CVE-2019-20445] [flink-rpc-akka] [1.14.4] > [7.5] [sonatype-2019-0115] [flink-rpc-akka] [1.14.4] > [7.5] [sonatype-2020-0029] [flink-rpc-akka] [1.14.4] > Can you assist with this ? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (FLINK-26786) Helm chart: Add default container annotation to the operator deployment
[
https://issues.apache.org/jira/browse/FLINK-26786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Wang reassigned FLINK-26786:
-
Assignee: Xin Hao
> Helm chart: Add default container annotation to the operator deployment
> ---
>
> Key: FLINK-26786
> URL: https://issues.apache.org/jira/browse/FLINK-26786
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Xin Hao
>Assignee: Xin Hao
>Priority: Minor
>
> Adding a default container annotation to the operator deployment will be a
> bit easier for the users to check logs and others.
> The annotation should look like :
> {code:java}
> kubectl.kubernetes.io/default-container: {{ .Chart.Name }} {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #19112: [FLINK-26678][shell] replace the repeated log4j-console.properties wi…
flinkbot edited a comment on pull request #19112: URL: https://github.com/apache/flink/pull/19112#issuecomment-1068959010 ## CI report: * cdafb53b2c352834634377a240ea35ed1037d7fc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33551) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26786) Helm chart: Add default container annotation to the operator deployment
[
https://issues.apache.org/jira/browse/FLINK-26786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510227#comment-17510227
]
Xin Hao commented on FLINK-26786:
-
Already opened a PR for this.
> Helm chart: Add default container annotation to the operator deployment
> ---
>
> Key: FLINK-26786
> URL: https://issues.apache.org/jira/browse/FLINK-26786
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Xin Hao
>Priority: Minor
>
> Adding a default container annotation to the operator deployment will be a
> bit easier for the users to check logs and others.
> The annotation should look like :
> {code:java}
> kubectl.kubernetes.io/default-container: {{ .Chart.Name }} {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #19177: [FLINK-23399][state] Add a benchmark for rescaling
flinkbot edited a comment on pull request #19177: URL: https://github.com/apache/flink/pull/19177#issuecomment-1073539671 ## CI report: * 57894a9e0d0a2e3a9892f9c712b83a09aaf3ed42 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33550) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19176: [FLINK-26477][python] Support WindowedStream.aggregate in Python DataStream API
flinkbot edited a comment on pull request #19176: URL: https://github.com/apache/flink/pull/19176#issuecomment-1073539582 ## CI report: * b4f31c27c45749fd45fe5b1bfce47fbb574096be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33464) * 68fab992a52e03548dce7faeed0ebf207cf4d7c1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33561) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * daafbbc7d93331d3018f35e68ec72c8682e20477 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33554) * c3f9b1ce635498599d1110fe5d7ab7cd33830752 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33558) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19176: [FLINK-26477][python] Support WindowedStream.aggregate in Python DataStream API
flinkbot edited a comment on pull request #19176: URL: https://github.com/apache/flink/pull/19176#issuecomment-1073539582 ## CI report: * b4f31c27c45749fd45fe5b1bfce47fbb574096be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33464) * 68fab992a52e03548dce7faeed0ebf207cf4d7c1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26786) Helm chart: Add default container annotation to the operator deployment
[
https://issues.apache.org/jira/browse/FLINK-26786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510218#comment-17510218
]
Yang Wang commented on FLINK-26786:
---
[~haoxin] Would you like to work on this ticket?
> Helm chart: Add default container annotation to the operator deployment
> ---
>
> Key: FLINK-26786
> URL: https://issues.apache.org/jira/browse/FLINK-26786
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
>Reporter: Xin Hao
>Priority: Minor
>
> Adding a default container annotation to the operator deployment will be a
> bit easier for the users to check logs and others.
> The annotation should look like :
> {code:java}
> kubectl.kubernetes.io/default-container: {{ .Chart.Name }} {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-26487) Upgrade to Operator SDK 3.0.0 and replace custom informereventsource logic
[ https://issues.apache.org/jira/browse/FLINK-26487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510212#comment-17510212 ] Nicholas Jiang commented on FLINK-26487: [~gyfora], does the info of the release come from the java-operator-sdk channel? > Upgrade to Operator SDK 3.0.0 and replace custom informereventsource logic > -- > > Key: FLINK-26487 > URL: https://issues.apache.org/jira/browse/FLINK-26487 > Project: Flink > Issue Type: Sub-task >Reporter: Gyula Fora >Assignee: Nicholas Jiang >Priority: Major > > This ticket tracks the future required work to bump the operator sdk version > to 3.0.0 once it is released. > This release allows us to remove the custom InformerEventsource logic that we > added to the OperatorUtils class and use the built in functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #19156: decouple-hive-planer
flinkbot edited a comment on pull request #19156: URL: https://github.com/apache/flink/pull/19156#issuecomment-1072382647 ## CI report: * 422a51f81f2509227ac3fbc241a9f18871851e04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33548) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19181: [FLINK-11388][fs]add abstract test classes for recoverable writers(s3/oss)
flinkbot edited a comment on pull request #19181: URL: https://github.com/apache/flink/pull/19181#issuecomment-1073639104 ## CI report: * 735c5712c3843b80d163b5921d762a81d1fdd93b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33477) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) * f3b011dd32d55787dd17abd955df01b63fcebb98 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33560) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * daafbbc7d93331d3018f35e68ec72c8682e20477 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33554) * c3f9b1ce635498599d1110fe5d7ab7cd33830752 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33558) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) * f3b011dd32d55787dd17abd955df01b63fcebb98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26621) flink-tests failed on azure due to Error occurred in starting fork
[
https://issues.apache.org/jira/browse/FLINK-26621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510208#comment-17510208
]
Yun Gao commented on FLINK-26621:
-
I tried to have a look, but with no much progress: I compared the tests runs
between the failed one[1] and the success one[1], the tests run should be the
same. Perhaps it is related to some cases failed to cleanup and the forked
process do not exit with 0?
[1] Failed one:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=33451=logs=a57e0635-3fad-5b08-57c7-a4142d7d6fa9=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7
[2] Success one:
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=33523=logs=a57e0635-3fad-5b08-57c7-a4142d7d6fa9=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7
> flink-tests failed on azure due to Error occurred in starting fork
> --
>
> Key: FLINK-26621
> URL: https://issues.apache.org/jira/browse/FLINK-26621
> Project: Flink
> Issue Type: Bug
> Components: Build System / Azure Pipelines
>Affects Versions: 1.15.0, 1.14.4, 1.16.0
>Reporter: Yun Gao
>Priority: Critical
> Labels: test-stability
>
> {code:java}
> 2022-03-11T16:20:12.6929558Z Mar 11 16:20:12 [WARNING] The requested profile
> "skip-webui-build" could not be activated because it does not exist.
> 2022-03-11T16:20:12.6939269Z Mar 11 16:20:12 [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test
> (integration-tests) on project flink-tests: There are test failures.
> 2022-03-11T16:20:12.6940062Z Mar 11 16:20:12 [ERROR]
> 2022-03-11T16:20:12.6940954Z Mar 11 16:20:12 [ERROR] Please refer to
> /__w/2/s/flink-tests/target/surefire-reports for the individual test results.
> 2022-03-11T16:20:12.6941875Z Mar 11 16:20:12 [ERROR] Please refer to dump
> files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
> 2022-03-11T16:20:12.6942966Z Mar 11 16:20:12 [ERROR] ExecutionException Error
> occurred in starting fork, check output in log
> 2022-03-11T16:20:12.6943919Z Mar 11 16:20:12 [ERROR]
> org.apache.maven.surefire.booter.SurefireBooterForkException:
> ExecutionException Error occurred in starting fork, check output in log
> 2022-03-11T16:20:12.6945023Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:532)
> 2022-03-11T16:20:12.6945878Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:479)
> 2022-03-11T16:20:12.6946761Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:322)
> 2022-03-11T16:20:12.6947532Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:266)
> 2022-03-11T16:20:12.6953051Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1314)
> 2022-03-11T16:20:12.6954035Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1159)
> 2022-03-11T16:20:12.6954917Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:932)
> 2022-03-11T16:20:12.6955749Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
> 2022-03-11T16:20:12.6956542Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> 2022-03-11T16:20:12.6957456Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> 2022-03-11T16:20:12.6958232Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> 2022-03-11T16:20:12.6959038Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> 2022-03-11T16:20:12.6960553Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> 2022-03-11T16:20:12.6962116Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> 2022-03-11T16:20:12.6963009Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
> 2022-03-11T16:20:12.6963737Z Mar 11 16:20:12 [ERROR] at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
> 2022-03-11T16:20:12.6964644Z Mar 11 16:20:12 [ERROR] at
>
[jira] [Closed] (FLINK-26495) Dynamic table options does not work for view
[
https://issues.apache.org/jira/browse/FLINK-26495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee closed FLINK-26495.
Fix Version/s: 1.16.0
Resolution: Fixed
master: e32c04cee5206925c8ddfa112c338bde0fbb39d5
> Dynamic table options does not work for view
>
>
> Key: FLINK-26495
> URL: https://issues.apache.org/jira/browse/FLINK-26495
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Planner
>Affects Versions: 1.15.0
>Reporter: Jane Chan
>Assignee: Jane Chan
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.16.0
>
>
> The dynamic table options (aka. table hints) syntax
> {code:java}
> table_identifier /*+ OPTIONS(key=val [, key=val]*) */ {code}
> does not work for the view without any exception thrown or suggestions to
> users. It is not user-friendly and misleading. We should either throw a
> meaningful exception or support this feature for view.
>
> h4. How to reproduce
> Run the following statements in SQL CLI
> {code:java}
> Flink SQL> create table datagen (f0 int, f1 double) with ('connector' =
> 'datagen', 'number-of-rows' = '5');
> [INFO] Execute statement succeed.
> Flink SQL> create view my_view as select * from datagen;
> [INFO] Execute statement succeed.
> Flink SQL> explain plan for select * from my_view /*+
> OPTIONS('number-of-rows' = '1') */;
> == Abstract Syntax Tree ==
> LogicalProject(f0=[$0], f1=[$1])
> +- LogicalTableScan(table=[[default_catalog, default_database, datagen]])
> == Optimized Physical Plan ==
> TableSourceScan(table=[[default_catalog, default_database, datagen]],
> fields=[f0, f1])
> == Optimized Execution Plan ==
> TableSourceScan(table=[[default_catalog, default_database, datagen]],
> fields=[f0, f1]) {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * daafbbc7d93331d3018f35e68ec72c8682e20477 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33554) * c3f9b1ce635498599d1110fe5d7ab7cd33830752 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #19007: [FLINK-26495][table-planner] Prohibit hints(dynamic table options) on view
JingsongLi merged pull request #19007: URL: https://github.com/apache/flink/pull/19007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * daafbbc7d93331d3018f35e68ec72c8682e20477 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33554) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) * f3b011dd32d55787dd17abd955df01b63fcebb98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * daafbbc7d93331d3018f35e68ec72c8682e20477 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33554) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) * 849140b4515a43a19f74a3b5a38579f0955bf8a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33557) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-ml] lindong28 commented on a change in pull request #52: [FLINK-25527] Add Transformer and Estimator for StringIndexer
lindong28 commented on a change in pull request #52:
URL: https://github.com/apache/flink-ml/pull/52#discussion_r831693277
##
File path:
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/stringindexer/StringIndexer.java
##
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.feature.stringindexer;
+
+import org.apache.flink.api.common.functions.FlatMapFunction;
+import org.apache.flink.api.common.functions.MapPartitionFunction;
+import org.apache.flink.api.java.functions.KeySelector;
+import org.apache.flink.api.java.tuple.Tuple2;
+import org.apache.flink.api.java.tuple.Tuple3;
+import org.apache.flink.ml.api.Estimator;
+import org.apache.flink.ml.common.datastream.DataStreamUtils;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.table.api.internal.TableImpl;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Collector;
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * An Estimator which implements the string indexing algorithm.
+ *
+ * A string indexer maps each input column (string/numerical value) to a
index column (integer
+ * value) such that if the indices of two input are same iff their
corresponding input columns are
Review comment:
There appears to be typo in this sentence.
##
File path:
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/stringindexer/StringIndexerModel.java
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.ml.feature.stringindexer;
+
+import org.apache.flink.api.common.functions.RichFlatMapFunction;
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.api.Model;
+import org.apache.flink.ml.common.broadcast.BroadcastUtils;
+import org.apache.flink.ml.common.datastream.TableUtils;
+import org.apache.flink.ml.param.Param;
+import org.apache.flink.ml.util.ParamUtils;
+import org.apache.flink.ml.util.ReadWriteUtils;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.table.api.internal.TableImpl;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Collector;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.commons.lang3.ArrayUtils;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * A Model which transforms input string/numeric column(s) to integer
column(s) using the model data
+ * computed by {@link StringIndexer}.
+ */
+public class StringIndexerModel
+implements
[GitHub] [flink] zoltar9264 commented on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
zoltar9264 commented on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1074695997 Hi @curcur , commit title in the same line originally. Github seems only show 69 char in one line. And the failed test seems cause by other problem which already be fixed in master. I had rebase to master. @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * Unknown: [CANCELED](TBD) * daafbbc7d93331d3018f35e68ec72c8682e20477 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33554) * c3f9b1ce635498599d1110fe5d7ab7cd33830752 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) * 849140b4515a43a19f74a3b5a38579f0955bf8a4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) * f3b011dd32d55787dd17abd955df01b63fcebb98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19189: [FLINK-26779][rest] OperationKey implements Serializable
flinkbot edited a comment on pull request #19189: URL: https://github.com/apache/flink/pull/19189#issuecomment-1073902118 ## CI report: * ae0c8851badb92bb4196a403058dd57be66576cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33517) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) * f3b011dd32d55787dd17abd955df01b63fcebb98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) * 849140b4515a43a19f74a3b5a38579f0955bf8a4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] ZhangChaoming removed a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
ZhangChaoming removed a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1074673860 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] ZhangChaoming commented on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
ZhangChaoming commented on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1074687643 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-26785) Add FlinkSessionJob CRD
[
https://issues.apache.org/jira/browse/FLINK-26785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-26785:
---
Labels: pull-request-available (was: )
> Add FlinkSessionJob CRD
> ---
>
> Key: FLINK-26785
> URL: https://issues.apache.org/jira/browse/FLINK-26785
> Project: Flink
> Issue Type: Sub-task
> Components: Kubernetes Operator
>Reporter: Aitozi
>Priority: Major
> Labels: pull-request-available
>
> This ticket is to add the {{FlinkSessionJob}} CRD
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [flink] ZhangChaoming removed a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
ZhangChaoming removed a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-1074663359 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) * 849140b4515a43a19f74a3b5a38579f0955bf8a4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (FLINK-26790) Description image about Unaligned Checkpointing maybe incorrect.
[ https://issues.apache.org/jira/browse/FLINK-26790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jinghaihang updated FLINK-26790: Description: Due to the second description ： * It immediately forwards the barrier to the downstream operator by adding it to the end of the output buffers. so i think the picture maybe misleading readers that barrier will not appear in the middle of the data stream. !image-2022-03-22-11-12-20-025.png|width=599,height=303! was: Due to the second description ： * It immediately forwards the barrier to the downstream operator by adding it to the end of the output buffers. so i think the picture maybe misleading readers that barrier will not appear in the middle of the data stream. !image-2022-03-22-11-12-20-025.png! > Description image about Unaligned Checkpointing maybe incorrect. > > > Key: FLINK-26790 > URL: https://issues.apache.org/jira/browse/FLINK-26790 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.13.6, 1.14.4 >Reporter: jinghaihang >Priority: Minor > Attachments: image-2022-03-22-11-12-20-025.png > > > Due to the second description ： > * It immediately forwards the barrier to the downstream operator by adding > it to the end of the output buffers. > so i think the picture maybe misleading readers that barrier will not appear > in the middle of the data stream. > > !image-2022-03-22-11-12-20-025.png|width=599,height=303! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FLINK-26790) Description image about Unaligned Checkpointing maybe incorrect.
jinghaihang created FLINK-26790: --- Summary: Description image about Unaligned Checkpointing maybe incorrect. Key: FLINK-26790 URL: https://issues.apache.org/jira/browse/FLINK-26790 Project: Flink Issue Type: Improvement Components: Documentation Affects Versions: 1.14.4, 1.13.6 Reporter: jinghaihang Attachments: image-2022-03-22-11-12-20-025.png Due to the second description ： * It immediately forwards the barrier to the downstream operator by adding it to the end of the output buffers. so i think the picture maybe misleading readers that barrier will not appear in the middle of the data stream. !image-2022-03-22-11-12-20-025.png! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-22315) Support ADD column/constraint/watermark for ALTER TABLE statement
[ https://issues.apache.org/jira/browse/FLINK-22315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510194#comment-17510194 ] RocMarshal commented on FLINK-22315: [~lsy] Thanks for the comments, cc [~jark] Please let us know what's your opinion. And the current state of the ticket could be available in the PR. > Support ADD column/constraint/watermark for ALTER TABLE statement > - > > Key: FLINK-22315 > URL: https://issues.apache.org/jira/browse/FLINK-22315 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API >Reporter: Jark Wu >Assignee: RocMarshal >Priority: Major > Labels: pull-request-available, stale-assigned > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) * fc9c6f6aca4dc10da870e44c675b9738211e41cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33549) * 849140b4515a43a19f74a3b5a38579f0955bf8a4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26683) Terminate the job anyway if savepoint finished when stop-with-savepoint
[ https://issues.apache.org/jira/browse/FLINK-26683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510191#comment-17510191 ] Liu commented on FLINK-26683: - [~dwysakowicz] Thanks for the reply. In my case, the task doesn't need commit. I agree with you when it comes to committing. > Terminate the job anyway if savepoint finished when stop-with-savepoint > --- > > Key: FLINK-26683 > URL: https://issues.apache.org/jira/browse/FLINK-26683 > Project: Flink > Issue Type: Improvement > Components: Runtime / Checkpointing, Runtime / Coordination >Affects Versions: 1.15.0 >Reporter: Liu >Priority: Major > > When we stop with savepoint, the savepoint finishes. But some tasks failover > for some reason and restart to running. In the end, some tasks are finished > and some tasks are running. In this case, I think that we should terminate > all the tasks anyway instead of restarting since the savepoint is finished > and the job stops consuming data. What do you think? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink] ZhangChaoming removed a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
ZhangChaoming removed a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1062751689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] ZhangChaoming removed a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
ZhangChaoming removed a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-1067783935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] ZhangChaoming commented on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
ZhangChaoming commented on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-1074677027 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * Unknown: [CANCELED](TBD) * daafbbc7d93331d3018f35e68ec72c8682e20477 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33554) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * Unknown: [CANCELED](TBD) * ca2eba84719f8edee2e67aa95d5abde8178ec484 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33552) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] curcur edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
curcur edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1074674833 It is strange for the commit title: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamIm… …pl#getIntersection Would you please make them in the same line? Also, your previous change does not pass all the tests. Would you mind checking what is the problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] curcur commented on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
curcur commented on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1074674833 It is strange for the commit title: FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamIm… …pl#getIntersection Would you please make them in the same line? Also, your previous change does not pass all the tests. Would you mind checking what is the problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] curcur commented on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
curcur commented on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1074674743 It is strange for the commit title: FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamIm… …pl#getIntersection Would you please make them in the same line? Also, your previous change does not pass all the tests. Would you mind checking what is the problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
flinkbot edited a comment on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1073732492 ## CI report: * Unknown: [CANCELED](TBD) * daafbbc7d93331d3018f35e68ec72c8682e20477 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19112: [FLINK-26678][shell] replace the repeated log4j-console.properties wi…
flinkbot edited a comment on pull request #19112: URL: https://github.com/apache/flink/pull/19112#issuecomment-1068959010 ## CI report: * 10e2d2ce4923e1e889f788c5bd94a478fd1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33442) * cdafb53b2c352834634377a240ea35ed1037d7fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33551) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
flinkbot edited a comment on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1015100174 ## CI report: * Unknown: [CANCELED](TBD) * ca2eba84719f8edee2e67aa95d5abde8178ec484 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] ZhangChaoming commented on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax
ZhangChaoming commented on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1074673860 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] zoltar9264 commented on pull request #19183: [FLINK-26766][Runtime/StateBackends] Fix ChangelogStateHandleStreamImpl#getIntersection
zoltar9264 commented on pull request #19183: URL: https://github.com/apache/flink/pull/19183#issuecomment-1074673799 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26724) FlinkKafkaProducerMigrationOperatorTest.testRestoreProducer failed on azure due to Container startup failed
[
https://issues.apache.org/jira/browse/FLINK-26724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510189#comment-17510189
]
Yun Gao commented on FLINK-26724:
-
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=33518=logs=c5f0071e-1851-543e-9a45-9ac140befc32=15a22db7-8faa-5b34-3920-d33c9f0ca23c=7352
> FlinkKafkaProducerMigrationOperatorTest.testRestoreProducer failed on azure
> due to Container startup failed
> ---
>
> Key: FLINK-26724
> URL: https://issues.apache.org/jira/browse/FLINK-26724
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka
>Affects Versions: 1.15.0
>Reporter: Yun Gao
>Priority: Major
> Labels: test-stability
>
> {code:java}
> 2022-03-17T10:27:56.1372771Z Mar 17 10:27:56
> org.testcontainers.containers.ContainerLaunchException: Container startup
> failed
> 2022-03-17T10:27:56.1373469Z Mar 17 10:27:56 at
> org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:336)
> 2022-03-17T10:27:56.1376022Z Mar 17 10:27:56 at
> org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
> 2022-03-17T10:27:56.1376901Z Mar 17 10:27:56 at
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
> 2022-03-17T10:27:56.1377769Z Mar 17 10:27:56 at
> java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384)
> 2022-03-17T10:27:56.1378489Z Mar 17 10:27:56 at
> java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
> 2022-03-17T10:27:56.1379198Z Mar 17 10:27:56 at
> java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
> 2022-03-17T10:27:56.1379892Z Mar 17 10:27:56 at
> java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
> 2022-03-17T10:27:56.1380595Z Mar 17 10:27:56 at
> java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
> 2022-03-17T10:27:56.1381267Z Mar 17 10:27:56 at
> java.util.concurrent.ForkJoinTask.doInvoke(ForkJoinTask.java:401)
> 2022-03-17T10:27:56.1381934Z Mar 17 10:27:56 at
> java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:734)
> 2022-03-17T10:27:56.1382658Z Mar 17 10:27:56 at
> java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
> 2022-03-17T10:27:56.1383409Z Mar 17 10:27:56 at
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
> 2022-03-17T10:27:56.1384358Z Mar 17 10:27:56 at
> java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
> 2022-03-17T10:27:56.1385680Z Mar 17 10:27:56 at
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
> 2022-03-17T10:27:56.1386625Z Mar 17 10:27:56 at
> java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:650)
> 2022-03-17T10:27:56.1387496Z Mar 17 10:27:56 at
> org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl.startKafkaContainerCluster(KafkaTestEnvironmentImpl.java:410)
> 2022-03-17T10:27:56.1388721Z Mar 17 10:27:56 at
> org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl.prepare(KafkaTestEnvironmentImpl.java:106)
> 2022-03-17T10:27:56.1389705Z Mar 17 10:27:56 at
> org.apache.flink.streaming.connectors.kafka.KafkaTestBase.startClusters(KafkaTestBase.java:159)
> 2022-03-17T10:27:56.1390910Z Mar 17 10:27:56 at
> org.apache.flink.streaming.connectors.kafka.KafkaTestBase.startClusters(KafkaTestBase.java:142)
> 2022-03-17T10:27:56.1392365Z Mar 17 10:27:56 at
> org.apache.flink.streaming.connectors.kafka.KafkaMigrationTestBase.testRestoreProducer(KafkaMigrationTestBase.java:134)
> 2022-03-17T10:27:56.1393179Z Mar 17 10:27:56 at
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2022-03-17T10:27:56.1393963Z Mar 17 10:27:56 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 2022-03-17T10:27:56.1394714Z Mar 17 10:27:56 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 2022-03-17T10:27:56.1395908Z Mar 17 10:27:56 at
> java.lang.reflect.Method.invoke(Method.java:498)
> 2022-03-17T10:27:56.1397053Z Mar 17 10:27:56 at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> 2022-03-17T10:27:56.1398364Z Mar 17 10:27:56 at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 2022-03-17T10:27:56.1399604Z Mar 17 10:27:56 at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> 2022-03-17T10:27:56.1400818Z Mar 17 10:27:56 at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 2022-03-17T10:27:56.1402257Z Mar 17 10:27:56 at
>
[jira] [Commented] (FLINK-26177) PulsarSourceITCase.testScaleDown fails with timeout
[
https://issues.apache.org/jira/browse/FLINK-26177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510188#comment-17510188
]
Yun Gao commented on FLINK-26177:
-
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=33522=logs=fc5181b0-e452-5c8f-68de-1097947f6483=995c650b-6573-581c-9ce6-7ad4cc038461=26986
> PulsarSourceITCase.testScaleDown fails with timeout
> ---
>
> Key: FLINK-26177
> URL: https://issues.apache.org/jira/browse/FLINK-26177
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Pulsar
>Affects Versions: 1.15.0
>Reporter: Matthias Pohl
>Priority: Blocker
> Labels: pull-request-available, stale-blocker, test-stability
>
> We observed a [build
> failure|https://dev.azure.com/mapohl/flink/_build/results?buildId=742=logs=f3dc9b18-b77a-55c1-591e-264c46fe44d1=2d3cd81e-1c37-5c31-0ee4-f5d5cdb9324d=26553]
> caused by {{PulsarSourceITCase.testScaleDown}}:
> {code}
> Feb 15 20:56:02 [ERROR] Tests run: 16, Failures: 1, Errors: 0, Skipped: 0,
> Time elapsed: 431.023 s <<< FAILURE! - in
> org.apache.flink.connector.pulsar.source.PulsarSourceITCase
> Feb 15 20:56:02 [ERROR]
> org.apache.flink.connector.pulsar.source.PulsarSourceITCase.testScaleDown(TestEnvironment,
> DataStreamSourceExternalContext, CheckpointingMode)[2] Time elapsed:
> 138.444 s <<< FAILURE!
> Feb 15 20:56:02 java.lang.AssertionError:
> Feb 15 20:56:02
> Feb 15 20:56:02 Expecting
> Feb 15 20:56:02
> Feb 15 20:56:02 to be completed within 2M.
> Feb 15 20:56:02
> Feb 15 20:56:02 exception caught while trying to get the future result:
> java.util.concurrent.TimeoutException
> Feb 15 20:56:02 at
> java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1784)
> [...]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [flink] flinkbot edited a comment on pull request #19189: [FLINK-26779][rest] OperationKey implements Serializable
flinkbot edited a comment on pull request #19189: URL: https://github.com/apache/flink/pull/19189#issuecomment-1073902118 ## CI report: * ae0c8851badb92bb4196a403058dd57be66576cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33517) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19181: [FLINK-11388][fs]add abstract test classes for recoverable writers(s3/oss)
flinkbot edited a comment on pull request #19181: URL: https://github.com/apache/flink/pull/19181#issuecomment-1073639104 ## CI report: * 735c5712c3843b80d163b5921d762a81d1fdd93b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33477) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19112: [FLINK-26678][shell] replace the repeated log4j-console.properties wi…
flinkbot edited a comment on pull request #19112: URL: https://github.com/apache/flink/pull/19112#issuecomment-1068959010 ## CI report: * 10e2d2ce4923e1e889f788c5bd94a478fd1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33442) * cdafb53b2c352834634377a240ea35ed1037d7fc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19189: [FLINK-26779][rest] OperationKey implements Serializable
flinkbot edited a comment on pull request #19189: URL: https://github.com/apache/flink/pull/19189#issuecomment-1073902118 ## CI report: * ae0c8851badb92bb4196a403058dd57be66576cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33517) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19181: [FLINK-11388][fs]add abstract test classes for recoverable writers(s3/oss)
flinkbot edited a comment on pull request #19181: URL: https://github.com/apache/flink/pull/19181#issuecomment-1073639104 ## CI report: * 735c5712c3843b80d163b5921d762a81d1fdd93b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33477) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831722461
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
+
+private Configuration options;
+private ObjectIdentifier tableIdentifier;
+private RowType type;
+
+private List primaryKeys = new ArrayList<>();
+private List partitionKeys = new ArrayList<>();
+private String user = UUID.randomUUID().toString();
+
+public TableStoreBuilder withConfiguration(Configuration options) {
+this.options = options;
+return this;
+}
+
+public TableStoreBuilder withTableIdentifier(ObjectIdentifier
tableIdentifier) {
+this.tableIdentifier = tableIdentifier;
+return this;
+}
+
+public TableStoreBuilder withSchema(RowType type) {
+this.type = type;
+return this;
+}
+
+public TableStoreBuilder withPrimaryKeys(List primaryKeys) {
+this.primaryKeys = primaryKeys;
+return this;
+}
+
+public TableStoreBuilder withPartitionKeys(List partitionKeys)
{
+this.partitionKeys = partitionKeys;
+return this;
+}
+
+public TableStoreBuilder withUser(String user) {
+this.user = user;
+return this;
+}
+
+public TableStore build() {
+List indices = adjustAndValidate();
+return new TableStore(
+options, tableIdentifier, type, indices.get(0),
indices.get(1), user);
+}
+
+private List adjustAndValidate() {
Review comment:
> I don't get it. In my understanding, this is only index adjustment,
why must need schema.
So in your understanding, index adjustment is based on what? Below is the
current index adjusting in `TableStoreFactory`
```java
primaryKeys =
schema.getPrimaryKey().get().getColumns().stream()
.mapToInt(rowType.getFieldNames()::indexOf)
.toArray()
```
without schema, how could `mapToInt` be accomplished?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] wujinhu commented on pull request #19181: [FLINK-11388][fs]add abstract test classes for recoverable writers(s3/oss)
wujinhu commented on pull request #19181: URL: https://github.com/apache/flink/pull/19181#issuecomment-1074667704 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19177: [FLINK-23399][state] Add a benchmark for rescaling
flinkbot edited a comment on pull request #19177: URL: https://github.com/apache/flink/pull/19177#issuecomment-1073539671 ## CI report: * 87fd557372a0e20a36a6de740a0be0cde5201747 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33465) * 57894a9e0d0a2e3a9892f9c712b83a09aaf3ed42 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33550) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #19189: [FLINK-26779][rest] OperationKey implements Serializable
gaoyunhaii commented on pull request #19189: URL: https://github.com/apache/flink/pull/19189#issuecomment-1074666895 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) * fc9c6f6aca4dc10da870e44c675b9738211e41cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33549) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
JingsongLi commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831720164
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
+
+private Configuration options;
+private ObjectIdentifier tableIdentifier;
+private RowType type;
+
+private List primaryKeys = new ArrayList<>();
+private List partitionKeys = new ArrayList<>();
+private String user = UUID.randomUUID().toString();
+
+public TableStoreBuilder withConfiguration(Configuration options) {
+this.options = options;
+return this;
+}
+
+public TableStoreBuilder withTableIdentifier(ObjectIdentifier
tableIdentifier) {
+this.tableIdentifier = tableIdentifier;
+return this;
+}
+
+public TableStoreBuilder withSchema(RowType type) {
+this.type = type;
+return this;
+}
+
+public TableStoreBuilder withPrimaryKeys(List primaryKeys) {
+this.primaryKeys = primaryKeys;
+return this;
+}
+
+public TableStoreBuilder withPartitionKeys(List partitionKeys)
{
+this.partitionKeys = partitionKeys;
+return this;
+}
+
+public TableStoreBuilder withUser(String user) {
+this.user = user;
+return this;
+}
+
+public TableStore build() {
+List indices = adjustAndValidate();
+return new TableStore(
+options, tableIdentifier, type, indices.get(0),
indices.get(1), user);
+}
+
+private List adjustAndValidate() {
Review comment:
I don't get it.
In my understanding, this is only index adjustment, why must need schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19177: [FLINK-23399][state] Add a benchmark for rescaling
flinkbot edited a comment on pull request #19177: URL: https://github.com/apache/flink/pull/19177#issuecomment-1073539671 ## CI report: * 87fd557372a0e20a36a6de740a0be0cde5201747 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33465) * 57894a9e0d0a2e3a9892f9c712b83a09aaf3ed42 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
flinkbot edited a comment on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-997659194 ## CI report: * Unknown: [CANCELED](TBD) * fc9c6f6aca4dc10da870e44c675b9738211e41cc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink] ZhangChaoming commented on pull request #18151: [FLINK-25379][connectors] Support limit push down in DATAGEN connector
ZhangChaoming commented on pull request #18151: URL: https://github.com/apache/flink/pull/18151#issuecomment-1074663359 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831717136
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
+
+private Configuration options;
+private ObjectIdentifier tableIdentifier;
+private RowType type;
+
+private List primaryKeys = new ArrayList<>();
+private List partitionKeys = new ArrayList<>();
+private String user = UUID.randomUUID().toString();
+
+public TableStoreBuilder withConfiguration(Configuration options) {
+this.options = options;
+return this;
+}
+
+public TableStoreBuilder withTableIdentifier(ObjectIdentifier
tableIdentifier) {
+this.tableIdentifier = tableIdentifier;
+return this;
+}
+
+public TableStoreBuilder withSchema(RowType type) {
+this.type = type;
+return this;
+}
+
+public TableStoreBuilder withPrimaryKeys(List primaryKeys) {
+this.primaryKeys = primaryKeys;
+return this;
+}
+
+public TableStoreBuilder withPartitionKeys(List partitionKeys)
{
+this.partitionKeys = partitionKeys;
+return this;
+}
+
+public TableStoreBuilder withUser(String user) {
+this.user = user;
+return this;
+}
+
+public TableStore build() {
+List indices = adjustAndValidate();
+return new TableStore(
+options, tableIdentifier, type, indices.get(0),
indices.get(1), user);
+}
+
+private List adjustAndValidate() {
Review comment:
It's weird that `TableStore` must be first specified with schema then
specified with pk and partitions, why do we impose the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831716722
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
+
+private Configuration options;
+private ObjectIdentifier tableIdentifier;
+private RowType type;
+
+private List primaryKeys = new ArrayList<>();
+private List partitionKeys = new ArrayList<>();
+private String user = UUID.randomUUID().toString();
+
+public TableStoreBuilder withConfiguration(Configuration options) {
+this.options = options;
+return this;
+}
+
+public TableStoreBuilder withTableIdentifier(ObjectIdentifier
tableIdentifier) {
+this.tableIdentifier = tableIdentifier;
+return this;
+}
+
+public TableStoreBuilder withSchema(RowType type) {
+this.type = type;
+return this;
+}
+
+public TableStoreBuilder withPrimaryKeys(List primaryKeys) {
+this.primaryKeys = primaryKeys;
+return this;
+}
+
+public TableStoreBuilder withPartitionKeys(List partitionKeys)
{
+this.partitionKeys = partitionKeys;
+return this;
+}
+
+public TableStoreBuilder withUser(String user) {
+this.user = user;
+return this;
+}
+
+public TableStore build() {
+List indices = adjustAndValidate();
+return new TableStore(
+options, tableIdentifier, type, indices.get(0),
indices.get(1), user);
+}
+
+private List adjustAndValidate() {
Review comment:
> Why we need schema? We can just show index in exception without schema.
because index adjusting needs to be computed based on the physical schema.
If we throw an exception, does this approach against that the builder pattern
doesn't impose call order? How could we call this a builder pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19156: decouple-hive-planer
flinkbot edited a comment on pull request #19156: URL: https://github.com/apache/flink/pull/19156#issuecomment-1072382647 ## CI report: * 609eef2dbf6852c0dd4186e212aafaecc67a390d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33499) * 422a51f81f2509227ac3fbc241a9f18871851e04 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33548) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (FLINK-26759) Legacy source support waiting for recordWriter to be available
[ https://issues.apache.org/jira/browse/FLINK-26759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510187#comment-17510187 ] fanrui commented on FLINK-26759: Hi [~martijnvisser] , thanks for your comment. I understand your thinking. Unfortunately, many companies still use Legacy Source for most flink jobs. There are several reasons: # From the business side, job stability is the most important thing. If it is just to upgrade the Source API, they have no motivation to change the old code. Changes may introduce some stability issues. # The state compatibility of the old and new sources cannot be well resolved, it is quite complicated for users to upgrade the source. # There may only be new jobs or new SQL jobs that use the new Source API with a higher probability. I consulted with some of the big internet companies in China and they said that less than 20% of their jobs in production use the new Source APIs. We have thousands of flink-1.13 jobs in production and only 10% of them use the new Source APIs. From a business perspective, they prefer to optimize the engine without changing the business code. I can also understand if Legacy Source isn't going to be maintained in the end. Thanks a lot. > Legacy source support waiting for recordWriter to be available > -- > > Key: FLINK-26759 > URL: https://issues.apache.org/jira/browse/FLINK-26759 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common, Runtime / Checkpointing >Affects Versions: 1.13.0, 1.14.0, 1.15.0 >Reporter: fanrui >Priority: Major > > In order for Unaligned Checkpoint not to be blocked, StreamTask#processInput > will check recordWriter.isAvailable(). If not available, the data will not be > processed until recordWriter is available. > The new Source api is compatible with the above logic, but Legacy Source is > not compatible with the above logic. When using Unaligned Checkpoint, if the > backpressure of Legacy Source is high, the Checkpoint duration of Legacy > Source will be very long. > > Since legacy sources are often used in production, can we add logic to wait > for recordWriter to be available for legacy source? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
JingsongLi commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831716201
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
+
+private Configuration options;
+private ObjectIdentifier tableIdentifier;
+private RowType type;
+
+private List primaryKeys = new ArrayList<>();
+private List partitionKeys = new ArrayList<>();
+private String user = UUID.randomUUID().toString();
+
+public TableStoreBuilder withConfiguration(Configuration options) {
+this.options = options;
+return this;
+}
+
+public TableStoreBuilder withTableIdentifier(ObjectIdentifier
tableIdentifier) {
+this.tableIdentifier = tableIdentifier;
+return this;
+}
+
+public TableStoreBuilder withSchema(RowType type) {
+this.type = type;
+return this;
+}
+
+public TableStoreBuilder withPrimaryKeys(List primaryKeys) {
+this.primaryKeys = primaryKeys;
+return this;
+}
+
+public TableStoreBuilder withPartitionKeys(List partitionKeys)
{
+this.partitionKeys = partitionKeys;
+return this;
+}
+
+public TableStoreBuilder withUser(String user) {
+this.user = user;
+return this;
+}
+
+public TableStore build() {
+List indices = adjustAndValidate();
+return new TableStore(
+options, tableIdentifier, type, indices.get(0),
indices.get(1), user);
+}
+
+private List adjustAndValidate() {
Review comment:
Why we need schema? We can just show index in exception without schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831716142
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
Review comment:
> there is no call order
If we put the adjusting and validation in `#withXXX` method, how to make
sure the `rowType` has been specified already?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
JingsongLi commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831715299
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
Review comment:
there is no call order, can you take a look to below comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831715598
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
+
+private Configuration options;
+private ObjectIdentifier tableIdentifier;
+private RowType type;
+
+private List primaryKeys = new ArrayList<>();
+private List partitionKeys = new ArrayList<>();
+private String user = UUID.randomUUID().toString();
+
+public TableStoreBuilder withConfiguration(Configuration options) {
+this.options = options;
+return this;
+}
+
+public TableStoreBuilder withTableIdentifier(ObjectIdentifier
tableIdentifier) {
+this.tableIdentifier = tableIdentifier;
+return this;
+}
+
+public TableStoreBuilder withSchema(RowType type) {
+this.type = type;
+return this;
+}
+
+public TableStoreBuilder withPrimaryKeys(List primaryKeys) {
+this.primaryKeys = primaryKeys;
+return this;
+}
+
+public TableStoreBuilder withPartitionKeys(List partitionKeys)
{
+this.partitionKeys = partitionKeys;
+return this;
+}
+
+public TableStoreBuilder withUser(String user) {
+this.user = user;
+return this;
+}
+
+public TableStore build() {
+List indices = adjustAndValidate();
+return new TableStore(
+options, tableIdentifier, type, indices.get(0),
indices.get(1), user);
+}
+
+private List adjustAndValidate() {
Review comment:
I don't think so. Your approach has put an assumption that `#withSchema`
is called first before `#withPartitions` and `#withPrimaryKeys`.
What if `new TableStore(options).withPrimaryKeys(pk).withSchema(rowtype)` is
called?
In my opinion, if we put the index adjusting and validation within the
`TableStore`, it must be computed at the phase before `TableStore` is fully
instantiated, i.e. within some `#build()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
JingsongLi commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831715299
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
Review comment:
there is no call order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19156: decouple-hive-planer
flinkbot edited a comment on pull request #19156: URL: https://github.com/apache/flink/pull/19156#issuecomment-1072382647 ## CI report: * 609eef2dbf6852c0dd4186e212aafaecc67a390d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33499) * 422a51f81f2509227ac3fbc241a9f18871851e04 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a change in pull request #54: [FLINK-26753] PK constraint should include partition keys if table is partitioned
LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r831714348
##
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##
@@ -171,6 +181,83 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+//
+
+/** A builder for constructing a immutable {@link TableStore}. */
+public static final class TableStoreBuilder {
Review comment:
> I think we don't need a builder, actually, `TableStore` is a builder.
Hi Jingsong, thanks for your comments, but please rethink this. Typically, a
builder pattern doesn't impose the specific call order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (FLINK-26422) Update Chinese documentation with the new TablePipeline docs
[ https://issues.apache.org/jira/browse/FLINK-26422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-26422: --- Fix Version/s: 1.15.0 > Update Chinese documentation with the new TablePipeline docs > > > Key: FLINK-26422 > URL: https://issues.apache.org/jira/browse/FLINK-26422 > Project: Flink > Issue Type: Bug > Components: chinese-translation, Documentation >Reporter: Francesco Guardiani >Assignee: zoucao >Priority: Major > Labels: chinese-translation, pull-request-available > Fix For: 1.15.0 > > > Chinese docs needs to be updated with the content of this commit: > https://github.com/apache/flink/commit/4f65c7950f2c3ef849f2094deab0e199ffedf57b -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (FLINK-26422) Update Chinese documentation with the new TablePipeline docs
[ https://issues.apache.org/jira/browse/FLINK-26422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-26422. Resolution: Fixed > Update Chinese documentation with the new TablePipeline docs > > > Key: FLINK-26422 > URL: https://issues.apache.org/jira/browse/FLINK-26422 > Project: Flink > Issue Type: Bug > Components: chinese-translation, Documentation >Reporter: Francesco Guardiani >Assignee: zoucao >Priority: Major > Labels: chinese-translation, pull-request-available > > Chinese docs needs to be updated with the content of this commit: > https://github.com/apache/flink/commit/4f65c7950f2c3ef849f2094deab0e199ffedf57b -- This message was sent by Atlassian Jira (v8.20.1#820001)
