[GitHub] [flink] flinkbot commented on pull request #22458: [FLINK-31743][statebackend/rocksdb] disable rocksdb log relocating wh…

2023-04-22 Thread via GitHub


flinkbot commented on PR #22458:
URL: https://github.com/apache/flink/pull/22458#issuecomment-1518968320

   
   ## CI report:
   
   * eafa27a742032c5499e3a85bd365289b790b7a03 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (FLINK-31886) Upgrade to fabric8 6.5.1 and JOSDK 4.3.0

2023-04-22 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31886:
--

 Summary: Upgrade to fabric8 6.5.1 and JOSDK 4.3.0
 Key: FLINK-31886
 URL: https://issues.apache.org/jira/browse/FLINK-31886
 Project: Flink
  Issue Type: Improvement
  Components: Kubernetes Operator
Reporter: Gyula Fora
 Fix For: kubernetes-operator-1.5.0


Update the Kubernetes (fabric8 & josdk) dependencies to the latest versions 
which contain important fixes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (FLINK-31885) Trigger events on autoscaler errors

2023-04-22 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31885:
--

 Summary: Trigger events on autoscaler errors
 Key: FLINK-31885
 URL: https://issues.apache.org/jira/browse/FLINK-31885
 Project: Flink
  Issue Type: Improvement
  Components: Autoscaler, Kubernetes Operator
Reporter: Gyula Fora
 Fix For: kubernetes-operator-1.5.0


We currently only log (and ignore) autoscaler errors, but we should trigger 
events so it's visible to the user when something went wrong.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-31743) Avoid relocating the RocksDB's log failure when filename exceeds 255 characters

2023-04-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-31743:
---
Labels: pull-request-available  (was: )

> Avoid relocating the RocksDB's log failure when filename exceeds 255 
> characters
> ---
>
> Key: FLINK-31743
> URL: https://issues.apache.org/jira/browse/FLINK-31743
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / State Backends
>Affects Versions: 1.16.1, 1.15.4
>Reporter: jinghaihang
>Assignee: Feifan Wang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.16.2, 1.18.0, 1.17.1
>
>
> Since FLINK-24785 , the file name of the rocksdb LOG is generated by parsing 
> the db path, when the db path is long and the filename exceeds 255 
> characters, the creation of the file will fail, so the relevant rocksdb LOG 
> cannot be seen in the flink log dir.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] zoltar9264 opened a new pull request, #22458: [FLINK-31743][statebackend/rocksdb] disable rocksdb log relocating wh…

2023-04-22 Thread via GitHub


zoltar9264 opened a new pull request, #22458:
URL: https://github.com/apache/flink/pull/22458

   …en instance path too long
   
   
   ## What is the purpose of the change
   
   disable rocksdb log relocating when instance path too long, see 
[FLINK-31743](https://issues.apache.org/jira/browse/FLINK-31743).
   
   
   ## Verifying this change
   
   This change added verification to existing test  
*RocksDBStateBackendConfigTest#testDefaultDbLogDir()*.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-22 Thread Shuiqiang Chen (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715392#comment-17715392
 ] 

Shuiqiang Chen commented on FLINK-31848:


Hi [~zju_zsx],

take a table MyTable(a INT, b INT) for instance, there are three rows:
(1, 1), 
(null, 2), 
(3, 3)

and for the query

select * from MyTable where a < 2 and b < 2

the value of left.nullTerm and left.resultTerm would be:

false, true // a is not null, then evaluate the reuslt of a < 2 to be true, 
need to evaluate right code
true, false // a is null, means the result of a < 2 is UNKNOWN, no need to 
evaluate a < 2 but to evalute b < 2 as right.code
false, false // a is not null, then evaluate the result of a < 2 to be false, 
no need to evaluate right code

by simplying to if(!left.resultTerm), we assuem the result of null < 2 to be 
false, but actually it is UNKNOWN.

For the correctness, if(!left.resultTerm) and if(!left.nullTerm && 
!left.resultTerm) are identical. Since the generated code is not exposed to 
users and not affecting the correctness, the two implementations are fine for 
me.



> And Operator has side effect when operands have udf
> ---
>
> Key: FLINK-31848
> URL: https://issues.apache.org/jira/browse/FLINK-31848
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.13.2
>Reporter: zju_zsx
>Priority: Major
> Attachments: image-2023-04-19-14-54-46-458.png
>
>
>  
> {code:java}
> CREATE TABLE kafka_source (
>    `content` varchar,
>    `testid` bigint,
>    `extra` int
>    );
> CREATE TABLE console_sink (
>    `content` varchar,
>    `testid` bigint
>  )
>   with (
>     'connector' = 'print'
> );
> insert into console_sink
> select 
>    content,testid+1
> from kafka_source where testid is not null and testid > 0 and my_udf(testid) 
> != 0; {code}
> my_udf has a constraint that the testid should not be null, but the testid is 
> not null and testid > 0 does not take effect.
>  
> Im ScalarOperatorGens.generateAnd
> !image-2023-04-19-14-54-46-458.png!
> if left.nullTerm is true, right code will be execute 。
> it seems that
> {code:java}
> if (!${left.nullTerm} && !${left.resultTerm}) {code}
> can be safely replaced with 
> {code:java}
> if (!${left.resultTerm}){code}
> ? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31831) TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure is unstable

2023-04-22 Thread Sergey Nuyanzin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715391#comment-17715391
 ] 

Sergey Nuyanzin commented on FLINK-31831:
-

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=48358&view=logs&j=4d4a0d10-fca2-5507-8eed-c07f0bdf4887&t=7b25afdf-cc6c-566f-5459-359dc2585798&l=10562

> TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure is 
> unstable
> ---
>
> Key: FLINK-31831
> URL: https://issues.apache.org/jira/browse/FLINK-31831
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Affects Versions: 1.18.0
>Reporter: Sergey Nuyanzin
>Assignee: Lijie Wang
>Priority: Critical
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=48212&view=logs&j=39d5b1d5-3b41-54dc-6458-1e2ddd1cdcf3&t=0c010d0c-3dec-5bf1-d408-7b18988b1b2b&l=8399
> {noformat}
> Apr 18 04:17:09 [ERROR] 
> org.apache.flink.test.recovery.TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure
>   Time elapsed: 2.844 s  <<< FAILURE!
> Apr 18 04:17:09 java.lang.AssertionError: Failed to initialize the cluster 
> entrypoint .
> Apr 18 04:17:09   at org.junit.Assert.fail(Assert.java:89)
> Apr 18 04:17:09   at 
> org.apache.flink.test.recovery.TaskManagerDisconnectOnShutdownITCase.testTaskManagerProcessFailure(TaskManagerDisconnectOnShutdownITCase.java:136)
> Apr 18 04:17:09   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)
> Apr 18 04:17:09   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> Apr 18 04:17:09   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (FLINK-31884) Upgrade ExecNode to new version causes the old serialized plan failed to pass Json SerDe round trip

2023-04-22 Thread Jane Chan (Jira)
Jane Chan created FLINK-31884:
-

 Summary: Upgrade ExecNode to new version causes the old serialized 
plan failed to pass Json SerDe round trip
 Key: FLINK-31884
 URL: https://issues.apache.org/jira/browse/FLINK-31884
 Project: Flink
  Issue Type: Bug
  Components: Table SQL / Planner
Affects Versions: 1.18.0
Reporter: Jane Chan
 Fix For: 1.18.0


h4. How to Reproduce
h4. Root Cause

 
h4. Suggested Fix

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31752) SourceOperatorStreamTask increments numRecordsOut twice

2023-04-22 Thread Dong Lin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715387#comment-17715387
 ] 

Dong Lin commented on FLINK-31752:
--

Merged to apache/flink master branch 26bd5fe390e638e97925245da4ccb706b9e658e2.

> SourceOperatorStreamTask increments numRecordsOut twice
> ---
>
> Key: FLINK-31752
> URL: https://issues.apache.org/jira/browse/FLINK-31752
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Metrics
>Affects Versions: 1.17.0
>Reporter: Weihua Hu
>Assignee: Yunfeng Zhou
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2023-04-07-15-51-44-304.png
>
>
> The counter of numRecordsOut was introduce to ChainingOutput to reduce the 
> function call stack depth in 
> https://issues.apache.org/jira/browse/FLINK-30536
> But SourceOperatorStreamTask.AsyncDataOutputToOutput increments the counter 
> of numRecordsOut too. This results in the source operator's numRecordsOut are 
> doubled.
> We should delete the numRecordsOut.inc in 
> SourceOperatorStreamTask.AsyncDataOutputToOutput.
> [~xtsong][~lindong] Could you please take a look at this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (FLINK-31752) SourceOperatorStreamTask increments numRecordsOut twice

2023-04-22 Thread Dong Lin (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong Lin closed FLINK-31752.

Resolution: Fixed

> SourceOperatorStreamTask increments numRecordsOut twice
> ---
>
> Key: FLINK-31752
> URL: https://issues.apache.org/jira/browse/FLINK-31752
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Metrics
>Affects Versions: 1.17.0
>Reporter: Weihua Hu
>Assignee: Yunfeng Zhou
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2023-04-07-15-51-44-304.png
>
>
> The counter of numRecordsOut was introduce to ChainingOutput to reduce the 
> function call stack depth in 
> https://issues.apache.org/jira/browse/FLINK-30536
> But SourceOperatorStreamTask.AsyncDataOutputToOutput increments the counter 
> of numRecordsOut too. This results in the source operator's numRecordsOut are 
> doubled.
> We should delete the numRecordsOut.inc in 
> SourceOperatorStreamTask.AsyncDataOutputToOutput.
> [~xtsong][~lindong] Could you please take a look at this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] lindong28 merged pull request #22449: [FLINK-31752] Fix SourceOperator numRecordsOut duplicate bug

2023-04-22 Thread via GitHub


lindong28 merged PR #22449:
URL: https://github.com/apache/flink/pull/22449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] lindong28 commented on pull request #22449: [FLINK-31752] Fix SourceOperator numRecordsOut duplicate bug

2023-04-22 Thread via GitHub


lindong28 commented on PR #22449:
URL: https://github.com/apache/flink/pull/22449#issuecomment-1518960750

   Thanks for the PR. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] TanYuxin-tyx commented on pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository

2023-04-22 Thread via GitHub


TanYuxin-tyx commented on PR #22395:
URL: https://github.com/apache/flink/pull/22395#issuecomment-1518958068

   OK, LGTM after the fixing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] reswqa commented on pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository

2023-04-22 Thread via GitHub


reswqa commented on PR #22395:
URL: https://github.com/apache/flink/pull/22395#issuecomment-1518957498

   Thanks @TanYuxin-tyx for the quick review, I have updated this PR according 
to your comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] reswqa commented on a diff in pull request #22395: [FLINK-31799][docs] Python connector download link should refer to the url defined in externalized repository

2023-04-22 Thread via GitHub


reswqa commented on code in PR #22395:
URL: https://github.com/apache/flink/pull/22395#discussion_r1174514057


##
docs/layouts/shortcodes/py_connector_download_link.html:
##
@@ -0,0 +1,62 @@
+{{/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/}}{{/*
+Generates an XML snippet for the externalized connector python download table.
+*/}}
+{{ $name := .Get 0 }}
+{{ $connector_version := .Get 1 }}
+{{ $connector := index .Site.Data $name }}
+{{ $flink_version := .Site.Params.VersionTitle }}
+{{ $full_version := printf "%s-%s" $connector_version $flink_version }}
+
+
+{{ if eq $.Site.Language.Lang "en" }}
+In order to use the {{ $connector.name }} in PyFlink jobs, the following
+dependencies are required:
+{{ else if eq $.Site.Language.Lang "zh" }}
+为了在 PyFlink 作业中使用 {{ $connector.name }} ,需要添加下列依赖:
+{{ end }}
+
+
+Version
+PyFlink JAR
+
+
+{{ range $connector.variants }}
+
+{{- .maven -}}
+{{ if $.Site.Params.IsStable }}
+{{ if eq .sql_url nil}}
+There is no sql jar available yet.
+{{ else }}
+Download
+{{ end }}
+{{ else }}
+Only available for stable releases.
+{{ end }}
+
+{{ end }}
+
+
+{{ if eq .Site.Language.Lang "en" }}
+See Python
 dependency management
+for more details on how to use JARs in PyFlink.
+{{ else if eq .Site.Language.Lang "zh" }}
+在 PyFlink 中如何添加 JAR 包依赖参见 Python
 依赖管理。

Review Comment:
   Agree with you, `请参考` is more appropriate here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] huwh commented on pull request #22424: [FLINK-31842][runtime] Calculate the utilization of the task executor only when it is using

2023-04-22 Thread via GitHub


huwh commented on PR #22424:
URL: https://github.com/apache/flink/pull/22424#issuecomment-1518951288

   @reswqa Thanks for the review. 
   
   Sorry for missing one comments. Now it's updated. 
   
   
   extract some logic in SlotSelectionStrategy tests: 
https://github.com/apache/flink/pull/22424/commits/1fed03786d24d11f031489a8ba8c59a5a0459600
   
   migrate some slot pool related tests to junit5, this will be squash to the 
first hotfix commit and change the commit message before merge: 
https://github.com/apache/flink/pull/22424/commits/b7d852a3621a1eefe6efe6219303f0ef4854a8ea
   
   remove function getTaskExecutorUtilization which is only used in test: 
https://github.com/apache/flink/pull/22424/commits/5807589fa15e92c399ea6585d9663e3fe0e7bbb1
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] reswqa commented on pull request #22447: [FLINK-31764][runtime] Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool

2023-04-22 Thread via GitHub


reswqa commented on PR #22447:
URL: https://github.com/apache/flink/pull/22447#issuecomment-1518950603

   Hi @1996fanrui and @akalash, would you mind taking a look at this? Thx~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (FLINK-31743) Avoid relocating the RocksDB's log failure when filename exceeds 255 characters

2023-04-22 Thread Yun Tang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715367#comment-17715367
 ] 

Yun Tang commented on FLINK-31743:
--

[~assassinj] Thanks for the information, already assigned to him.

> Avoid relocating the RocksDB's log failure when filename exceeds 255 
> characters
> ---
>
> Key: FLINK-31743
> URL: https://issues.apache.org/jira/browse/FLINK-31743
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / State Backends
>Affects Versions: 1.16.1, 1.15.4
>Reporter: jinghaihang
>Assignee: Feifan Wang
>Priority: Major
> Fix For: 1.16.2, 1.18.0, 1.17.1
>
>
> Since FLINK-24785 , the file name of the rocksdb LOG is generated by parsing 
> the db path, when the db path is long and the filename exceeds 255 
> characters, the creation of the file will fail, so the relevant rocksdb LOG 
> cannot be seen in the flink log dir.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (FLINK-31743) Avoid relocating the RocksDB's log failure when filename exceeds 255 characters

2023-04-22 Thread Yun Tang (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yun Tang reassigned FLINK-31743:


Assignee: Feifan Wang  (was: jinghaihang)

> Avoid relocating the RocksDB's log failure when filename exceeds 255 
> characters
> ---
>
> Key: FLINK-31743
> URL: https://issues.apache.org/jira/browse/FLINK-31743
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / State Backends
>Affects Versions: 1.16.1, 1.15.4
>Reporter: jinghaihang
>Assignee: Feifan Wang
>Priority: Major
> Fix For: 1.16.2, 1.18.0, 1.17.1
>
>
> Since FLINK-24785 , the file name of the rocksdb LOG is generated by parsing 
> the db path, when the db path is long and the filename exceeds 255 
> characters, the creation of the file will fail, so the relevant rocksdb LOG 
> cannot be seen in the flink log dir.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31881) The Chinese documentation page of Flink official CEP is experiencing confusion.

2023-04-22 Thread Wencong Liu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715363#comment-17715363
 ] 

Wencong Liu commented on FLINK-31881:
-

Hello [~zhaoshuo], I'd like to fix errors in the markdown file. cc [~Weijie 
Guo] 

> The Chinese documentation page of Flink official CEP is experiencing 
> confusion.
> ---
>
> Key: FLINK-31881
> URL: https://issues.apache.org/jira/browse/FLINK-31881
> Project: Flink
>  Issue Type: Improvement
>  Components: chinese-translation
>Affects Versions: 1.18.0
>Reporter: zhaoshuo
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: image-2023-04-22-21-55-15-225.png
>
>
> The Chinese documentation page of Flink official CEP is experiencing 
> confusion.
> https://nightlies.apache.org/flink/flink-docs-master/zh/docs/libs/cep/#%E5%BE%AA%E7%8E%AF%E6%A8%A1%E5%BC%8F%E4%B8%AD%E7%9A%84%E8%BF%9E%E7%BB%AD%E6%80%A7
>  
> !image-2023-04-22-21-55-15-225.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-19010) Add a system metric to show the checkpoint restore time

2023-04-22 Thread Yanfei Lei (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-19010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715362#comment-17715362
 ] 

Yanfei Lei commented on FLINK-19010:


[~zncheng] Do you mean the total restore time of the whole job? I'm glad to add 
this, could you please assign it to me?

> Add a system metric to show the checkpoint restore time
> ---
>
> Key: FLINK-19010
> URL: https://issues.apache.org/jira/browse/FLINK-19010
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Checkpointing, Runtime / Metrics
>Reporter: Zhinan Cheng
>Priority: Minor
>
> Now the system metric only shows the downtime when failure happens. It would 
> be interesting to see the time to restore the checkpoint, so users can better 
> understand the bottleneck of failure recovery.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] flinkbot commented on pull request #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-04-22 Thread via GitHub


flinkbot commented on PR #22457:
URL: https://github.com/apache/flink/pull/22457#issuecomment-1518940766

   
   ## CI report:
   
   * 8b1d56afa45cfbeaf96075f682d57fb1e2aa937c UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] fredia opened a new pull request, #22457: [FLINK-31876][QS] Migrate flink-queryable-state-runtime tests to JUnit5

2023-04-22 Thread via GitHub


fredia opened a new pull request, #22457:
URL: https://github.com/apache/flink/pull/22457

   
   
   ## What is the purpose of the change
   
   Migrate flink-queryable-state-runtime tests to JUnit5
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (FLINK-31835) DataTypeHint don't support Row>

2023-04-22 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715358#comment-17715358
 ] 

Jark Wu commented on FLINK-31835:
-

Hi [~jeff-zou], thanks for reporting this. I think this is expected. You should 
declare the type hint as "ARRAY" to map to {{int[]}}. 
"ARRAY" is recognized as a result of {{Integer[]}}. That's why the 
conversion class is {{ArrayObjectArrayConverter}}. 

But I think the exception message can be improved. 

> DataTypeHint don't support Row>
> 
>
> Key: FLINK-31835
> URL: https://issues.apache.org/jira/browse/FLINK-31835
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / API
>Affects Versions: 1.15.4
>Reporter: jeff-zou
>Priority: Major
>
> Using DataTypeHint("Row>") in a UDF gives the following error:
>  
> {code:java}
> Caused by: java.lang.ClassCastException: class [I cannot be cast to class 
> [Ljava.lang.Object; ([I and [Ljava.lang.Object; are in module java.base of 
> loader 'bootstrap')
> org.apache.flink.table.data.conversion.ArrayObjectArrayConverter.toInternal(ArrayObjectArrayConverter.java:40)
> org.apache.flink.table.data.conversion.DataStructureConverter.toInternalOrNull(DataStructureConverter.java:61)
> org.apache.flink.table.data.conversion.RowRowConverter.toInternal(RowRowConverter.java:75)
> org.apache.flink.table.data.conversion.RowRowConverter.toInternal(RowRowConverter.java:37)
> org.apache.flink.table.data.conversion.DataStructureConverter.toInternalOrNull(DataStructureConverter.java:61)
> StreamExecCalc$251.processElement_split9(Unknown Source)
> StreamExecCalc$251.processElement(Unknown Source)
> org.apache.flink.streaming.runtime.tasks.CopyingChainingOutput.pushToOperator(CopyingChainingOutput.java:82)
>  {code}
>  
> The function is as follows:
> {code:java}
> @DataTypeHint("Row>")
> public Row eval() {
> int[] i = new int[3];
> return Row.of(i);
> } {code}
>  
> This error is not reported when testing other simple types, so it is not an 
> environmental problem.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] flinkbot commented on pull request #22456: [FLINK-31883] Using the unboxed types that prevent nullability issues

2023-04-22 Thread via GitHub


flinkbot commented on PR #22456:
URL: https://github.com/apache/flink/pull/22456#issuecomment-1518934707

   
   ## CI report:
   
   * 1b3b110300d3693f4b38684c7076441e22a3fa8d UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #22455: [FLINK-31828][planner] Use the inner serializer for RawType when doin…

2023-04-22 Thread via GitHub


flinkbot commented on PR #22455:
URL: https://github.com/apache/flink/pull/22455#issuecomment-1518934690

   
   ## CI report:
   
   * c06809e0540764c743a256e20e1398715f3e4fb3 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (FLINK-31828) List field in a POJO data stream results in table program compilation failure

2023-04-22 Thread Aitozi (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715356#comment-17715356
 ] 

Aitozi commented on FLINK-31828:


I have pushed a fix for it. Before this fix the demo will fails with 
EOFException when print the raw type (as shown in the pull request)

After this, in this example, user can define the schema as below. Then 
 
{code:java}
final var schema =
Schema.newBuilder()
.column("key", DataTypes.STRING())
.column("values", DataTypes.RAW(java.util.List.class))
.build(); {code}

> List field in a POJO data stream results in table program compilation failure
> -
>
> Key: FLINK-31828
> URL: https://issues.apache.org/jira/browse/FLINK-31828
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Runtime
>Affects Versions: 1.16.1
> Environment: Java 11
> Flink 1.16.1
>Reporter: Vladimir Matveev
>Priority: Major
>  Labels: pull-request-available
> Attachments: MainPojo.java, generated-code.txt, stacktrace.txt
>
>
> Suppose I have a POJO class like this:
> {code:java}
> public class Example {
> private String key;
> private List> values;
> // getters, setters, equals+hashCode omitted
> }
> {code}
> When a DataStream with this class is converted to a table, and some 
> operations are performed on it, it results in an exception which explicitly 
> says that I should file a ticket:
> {noformat}
> Caused by: org.apache.flink.api.common.InvalidProgramException: Table program 
> cannot be compiled. This is a bug. Please file an issue.
> {noformat}
> Please find the example Java code and the full stack trace attached.
> From the exception and generated code it seems that Flink is upset with the 
> list field being treated as an array - but I cannot have an array type there 
> in the real code.
> Also note that if I _don't_ specify the schema explicitly, it then maps the 
> {{values}} field to a `RAW('java.util.List', '...')` type, which also does 
> not work correctly and fails the job in case of even simplest operations like 
> printing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-31883) StreamSQLExample.Order has nullability issues

2023-04-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-31883:
---
Labels: pull-request-available  (was: )

> StreamSQLExample.Order has nullability issues
> -
>
> Key: FLINK-31883
> URL: https://issues.apache.org/jira/browse/FLINK-31883
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Reporter: chenyu
>Priority: Major
>  Labels: pull-request-available
> Attachments: screenshot-1.png
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] chenyu-opensource opened a new pull request, #22456: [FLINK-31883] Using the unboxed types that prevent nullability issues

2023-04-22 Thread via GitHub


chenyu-opensource opened a new pull request, #22456:
URL: https://github.com/apache/flink/pull/22456

   
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob 
server, rather than through RPC. That way we avoid re-transferring them on each 
deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
 - *The TaskInfo is stored in the blob store on job creation time as a 
persistent artifact*
 - *Deployments RPC transmits only the blob storage reference*
 - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the 
conventions defined in our code quality guide: 
https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe 
tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
 - *Added integration tests for end-to-end deployment with large payloads 
(100MB)*
 - *Extended integration test for recovery after master (JobManager) 
failure*
 - *Added test that validates that TaskInfo is transferred only once across 
recoveries*
 - *Manually verified the change by running a 4 node cluster with 2 
JobManagers and 4 TaskManagers, a stateful streaming program, and killing one 
JobManager and two TaskManagers during the execution, verifying that recovery 
happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
 - The serializers: (yes / no / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
 - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (FLINK-31828) List field in a POJO data stream results in table program compilation failure

2023-04-22 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-31828:
---
Labels: pull-request-available  (was: )

> List field in a POJO data stream results in table program compilation failure
> -
>
> Key: FLINK-31828
> URL: https://issues.apache.org/jira/browse/FLINK-31828
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Runtime
>Affects Versions: 1.16.1
> Environment: Java 11
> Flink 1.16.1
>Reporter: Vladimir Matveev
>Priority: Major
>  Labels: pull-request-available
> Attachments: MainPojo.java, generated-code.txt, stacktrace.txt
>
>
> Suppose I have a POJO class like this:
> {code:java}
> public class Example {
> private String key;
> private List> values;
> // getters, setters, equals+hashCode omitted
> }
> {code}
> When a DataStream with this class is converted to a table, and some 
> operations are performed on it, it results in an exception which explicitly 
> says that I should file a ticket:
> {noformat}
> Caused by: org.apache.flink.api.common.InvalidProgramException: Table program 
> cannot be compiled. This is a bug. Please file an issue.
> {noformat}
> Please find the example Java code and the full stack trace attached.
> From the exception and generated code it seems that Flink is upset with the 
> list field being treated as an array - but I cannot have an array type there 
> in the real code.
> Also note that if I _don't_ specify the schema explicitly, it then maps the 
> {{values}} field to a `RAW('java.util.List', '...')` type, which also does 
> not work correctly and fails the job in case of even simplest operations like 
> printing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] Aitozi opened a new pull request, #22455: [FLINK-31828][planner] Use the inner serializer for RawType when doin…

2023-04-22 Thread via GitHub


Aitozi opened a new pull request, #22455:
URL: https://github.com/apache/flink/pull/22455

   …g casting
   
   ## What is the purpose of the change
   
   Fix wrong serializer used when calling `toObject` for RawType.
   
   Before it will fails the cast with 
   
   
![image](https://user-images.githubusercontent.com/9486140/233818503-dea44202-3424-405f-91f8-8cb5e436dbed.png)
   
   
   ## Brief change log
   
   Return the inner serializer for `RawValueDataSerializer` when doing cast.
   
   
   ## Verifying this change
   
   CastRulesTest
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (yes / no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
 - The serializers: (yes / no / don't know)
 - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
 - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (yes / no)
 - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-22 Thread zju_zsx (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715352#comment-17715352
 ] 

zju_zsx edited comment on FLINK-31848 at 4/23/23 3:29 AM:
--

[~csq]  Although using ${left.nullTerm} may make the code more intuitive, it 
could potentially lead to exceptions. On the other hand, if the left field is 
almost always null, omitting it could result in a more efficient program as it 
would skip the execution of the right code.

So i think we should simplify the code。


was (Author: zju_zsx):
[~csq]  Although using ${left.nullTerm} may make the code more intuitive, it 
could potentially lead to exceptions. On the other hand, if the left field is 
almost always null, omitting it could result in a more efficient program as it 
would skip the execution of the right code.

> And Operator has side effect when operands have udf
> ---
>
> Key: FLINK-31848
> URL: https://issues.apache.org/jira/browse/FLINK-31848
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.13.2
>Reporter: zju_zsx
>Priority: Major
> Attachments: image-2023-04-19-14-54-46-458.png
>
>
>  
> {code:java}
> CREATE TABLE kafka_source (
>    `content` varchar,
>    `testid` bigint,
>    `extra` int
>    );
> CREATE TABLE console_sink (
>    `content` varchar,
>    `testid` bigint
>  )
>   with (
>     'connector' = 'print'
> );
> insert into console_sink
> select 
>    content,testid+1
> from kafka_source where testid is not null and testid > 0 and my_udf(testid) 
> != 0; {code}
> my_udf has a constraint that the testid should not be null, but the testid is 
> not null and testid > 0 does not take effect.
>  
> Im ScalarOperatorGens.generateAnd
> !image-2023-04-19-14-54-46-458.png!
> if left.nullTerm is true, right code will be execute 。
> it seems that
> {code:java}
> if (!${left.nullTerm} && !${left.resultTerm}) {code}
> can be safely replaced with 
> {code:java}
> if (!${left.resultTerm}){code}
> ? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-22 Thread zju_zsx (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715352#comment-17715352
 ] 

zju_zsx commented on FLINK-31848:
-

[~csq]  Although using ${left.nullTerm} may make the code more intuitive, it 
could potentially lead to exceptions. On the other hand, if the left field is 
almost always null, omitting it could result in a more efficient program as it 
would skip the execution of the right code.

> And Operator has side effect when operands have udf
> ---
>
> Key: FLINK-31848
> URL: https://issues.apache.org/jira/browse/FLINK-31848
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / Planner
>Affects Versions: 1.13.2
>Reporter: zju_zsx
>Priority: Major
> Attachments: image-2023-04-19-14-54-46-458.png
>
>
>  
> {code:java}
> CREATE TABLE kafka_source (
>    `content` varchar,
>    `testid` bigint,
>    `extra` int
>    );
> CREATE TABLE console_sink (
>    `content` varchar,
>    `testid` bigint
>  )
>   with (
>     'connector' = 'print'
> );
> insert into console_sink
> select 
>    content,testid+1
> from kafka_source where testid is not null and testid > 0 and my_udf(testid) 
> != 0; {code}
> my_udf has a constraint that the testid should not be null, but the testid is 
> not null and testid > 0 does not take effect.
>  
> Im ScalarOperatorGens.generateAnd
> !image-2023-04-19-14-54-46-458.png!
> if left.nullTerm is true, right code will be execute 。
> it seems that
> {code:java}
> if (!${left.nullTerm} && !${left.resultTerm}) {code}
> can be safely replaced with 
> {code:java}
> if (!${left.resultTerm}){code}
> ? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31883) StreamSQLExample.Order has nullability issues

2023-04-22 Thread chenyu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715351#comment-17715351
 ] 

chenyu commented on FLINK-31883:


Using the unboxed types that prevent nullability issues 

> StreamSQLExample.Order has nullability issues
> -
>
> Key: FLINK-31883
> URL: https://issues.apache.org/jira/browse/FLINK-31883
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Reporter: chenyu
>Priority: Major
> Attachments: screenshot-1.png
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-31883) StreamSQLExample.Order has nullability issues

2023-04-22 Thread chenyu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chenyu updated FLINK-31883:
---
Attachment: screenshot-1.png

> StreamSQLExample.Order has nullability issues
> -
>
> Key: FLINK-31883
> URL: https://issues.apache.org/jira/browse/FLINK-31883
> Project: Flink
>  Issue Type: Bug
>  Components: Tests
>Reporter: chenyu
>Priority: Major
> Attachments: screenshot-1.png
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (FLINK-31883) StreamSQLExample.Order has nullability issues

2023-04-22 Thread chenyu (Jira)
chenyu created FLINK-31883:
--

 Summary: StreamSQLExample.Order has nullability issues
 Key: FLINK-31883
 URL: https://issues.apache.org/jira/browse/FLINK-31883
 Project: Flink
  Issue Type: Bug
  Components: Tests
Reporter: chenyu






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] Myasuka commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2023-04-22 Thread via GitHub


Myasuka commented on PR #21410:
URL: https://github.com/apache/flink/pull/21410#issuecomment-1518927059

   @jiexray Please click `Resolve converasation` button if you think you 
already addressed the comment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] WencongLiu commented on pull request #22440: [FLINK-31131][doc] Fix the missed INITIALIZING of ExecutionState in the state_machine doc

2023-04-22 Thread via GitHub


WencongLiu commented on PR #22440:
URL: https://github.com/apache/flink/pull/22440#issuecomment-1518926951

   > Hi @WencongLiu , thanks for the contribution.
   > 
   > Could you update the PR title and commit message to `[FLINK-31131][doc] 
Fix the missed INITIALIZING of ExecutionState in the state_machine doc`? We 
should add the module name and the initial letter should be upper case.
   > 
   > And these changes LGTM.
   
   Done. @1996fanrui 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (FLINK-31846) Support cancel final checkpoint when all tasks are finished

2023-04-22 Thread Fan Hong (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715345#comment-17715345
 ] 

Fan Hong commented on FLINK-31846:
--

[~pnowojski]  Okay, I will explore these options further.

> Support cancel final checkpoint when all tasks are finished
> ---
>
> Key: FLINK-31846
> URL: https://issues.apache.org/jira/browse/FLINK-31846
> Project: Flink
>  Issue Type: New Feature
>  Components: Runtime / Checkpointing
>Affects Versions: 1.15.2
>Reporter: Fan Hong
>Priority: Major
>
> As stated in [1], all tasks will wait for the final checkpoint before 
> exiting. It also mentioned this mechanism will prolong the execution time.
> So, can we provide configurations to make tasks NOT wait for the final 
> checkpoint?
>  
>  [1]: 
> https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/fault-tolerance/checkpointing/#waiting-for-the-final-checkpoint-before-task-exit



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31882) SqlGateway will throw exception when executing DeleteFromFilterOperation

2023-04-22 Thread luoyuxia (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715342#comment-17715342
 ] 

luoyuxia commented on FLINK-31882:
--

[~yzl] Thanks for reporting. I'll try to fix it.

> SqlGateway will throw exception when executing DeleteFromFilterOperation
> 
>
> Key: FLINK-31882
> URL: https://issues.apache.org/jira/browse/FLINK-31882
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / API, Table SQL / Gateway
>Affects Versions: 1.17.0
>Reporter: yuzelin
>Assignee: luoyuxia
>Priority: Major
>
> Reproduce step:
> Our sink implements `SupportsDeletePushDown`, so when we test a DELETE 
> statement, the `TableEnvironmentImpl` will call the 
> `TableResultInternal executeInternal(DeleteFromFilterOperation 
> deleteFromFilterOperation)` at line 895. This method won't return the 
> JobClient, but the SqlGateway requires one, thus a exception occurs.
> Stack:
> Caused by: 
> org.apache.flink.table.gateway.service.utils.SqlExecutionException: Can't get 
> job client for the operation d4ba1029-664c-44c0-922b-021eb9e1c527.
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.lambda$callModifyOperations$6(OperationExecutor.java:521)
> at java.base/java.util.Optional.orElseThrow(Optional.java:408)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.callModifyOperations(OperationExecutor.java:518)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.executeOperation(OperationExecutor.java:431)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.executeStatement(OperationExecutor.java:200)
> at 
> org.apache.flink.table.gateway.service.SqlGatewayServiceImpl.lambda$executeStatement$1(SqlGatewayServiceImpl.java:212)
> at 
> org.apache.flink.table.gateway.service.operation.OperationManager.lambda$submitOperation$1(OperationManager.java:119)
> at 
> org.apache.flink.table.gateway.service.operation.OperationManager$Operation.lambda$run$0(OperationManager.java:258)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (FLINK-31882) SqlGateway will throw exception when executing DeleteFromFilterOperation

2023-04-22 Thread luoyuxia (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

luoyuxia reassigned FLINK-31882:


Assignee: luoyuxia

> SqlGateway will throw exception when executing DeleteFromFilterOperation
> 
>
> Key: FLINK-31882
> URL: https://issues.apache.org/jira/browse/FLINK-31882
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / API, Table SQL / Gateway
>Affects Versions: 1.17.0
>Reporter: yuzelin
>Assignee: luoyuxia
>Priority: Major
>
> Reproduce step:
> Our sink implements `SupportsDeletePushDown`, so when we test a DELETE 
> statement, the `TableEnvironmentImpl` will call the 
> `TableResultInternal executeInternal(DeleteFromFilterOperation 
> deleteFromFilterOperation)` at line 895. This method won't return the 
> JobClient, but the SqlGateway requires one, thus a exception occurs.
> Stack:
> Caused by: 
> org.apache.flink.table.gateway.service.utils.SqlExecutionException: Can't get 
> job client for the operation d4ba1029-664c-44c0-922b-021eb9e1c527.
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.lambda$callModifyOperations$6(OperationExecutor.java:521)
> at java.base/java.util.Optional.orElseThrow(Optional.java:408)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.callModifyOperations(OperationExecutor.java:518)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.executeOperation(OperationExecutor.java:431)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.executeStatement(OperationExecutor.java:200)
> at 
> org.apache.flink.table.gateway.service.SqlGatewayServiceImpl.lambda$executeStatement$1(SqlGatewayServiceImpl.java:212)
> at 
> org.apache.flink.table.gateway.service.operation.OperationManager.lambda$submitOperation$1(OperationManager.java:119)
> at 
> org.apache.flink.table.gateway.service.operation.OperationManager$Operation.lambda$run$0(OperationManager.java:258)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-31882) SqlGateway will throw exception when executing DeleteFromFilterOperation

2023-04-22 Thread yuzelin (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yuzelin updated FLINK-31882:

Description: 
Reproduce step:

Our sink implements `SupportsDeletePushDown`, so when we test a DELETE 
statement, the `TableEnvironmentImpl` will call the 
`TableResultInternal executeInternal(DeleteFromFilterOperation 
deleteFromFilterOperation)` at line 895. This method won't return the 
JobClient, but the SqlGateway requires one, thus a exception occurs.
Stack:
Caused by: org.apache.flink.table.gateway.service.utils.SqlExecutionException: 
Can't get job client for the operation d4ba1029-664c-44c0-922b-021eb9e1c527.
at 
org.apache.flink.table.gateway.service.operation.OperationExecutor.lambda$callModifyOperations$6(OperationExecutor.java:521)
at java.base/java.util.Optional.orElseThrow(Optional.java:408)
at 
org.apache.flink.table.gateway.service.operation.OperationExecutor.callModifyOperations(OperationExecutor.java:518)
at 
org.apache.flink.table.gateway.service.operation.OperationExecutor.executeOperation(OperationExecutor.java:431)
at 
org.apache.flink.table.gateway.service.operation.OperationExecutor.executeStatement(OperationExecutor.java:200)
at 
org.apache.flink.table.gateway.service.SqlGatewayServiceImpl.lambda$executeStatement$1(SqlGatewayServiceImpl.java:212)
at 
org.apache.flink.table.gateway.service.operation.OperationManager.lambda$submitOperation$1(OperationManager.java:119)
at 
org.apache.flink.table.gateway.service.operation.OperationManager$Operation.lambda$run$0(OperationManager.java:258)

> SqlGateway will throw exception when executing DeleteFromFilterOperation
> 
>
> Key: FLINK-31882
> URL: https://issues.apache.org/jira/browse/FLINK-31882
> Project: Flink
>  Issue Type: Bug
>  Components: Table SQL / API, Table SQL / Gateway
>Affects Versions: 1.17.0
>Reporter: yuzelin
>Priority: Major
>
> Reproduce step:
> Our sink implements `SupportsDeletePushDown`, so when we test a DELETE 
> statement, the `TableEnvironmentImpl` will call the 
> `TableResultInternal executeInternal(DeleteFromFilterOperation 
> deleteFromFilterOperation)` at line 895. This method won't return the 
> JobClient, but the SqlGateway requires one, thus a exception occurs.
> Stack:
> Caused by: 
> org.apache.flink.table.gateway.service.utils.SqlExecutionException: Can't get 
> job client for the operation d4ba1029-664c-44c0-922b-021eb9e1c527.
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.lambda$callModifyOperations$6(OperationExecutor.java:521)
> at java.base/java.util.Optional.orElseThrow(Optional.java:408)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.callModifyOperations(OperationExecutor.java:518)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.executeOperation(OperationExecutor.java:431)
> at 
> org.apache.flink.table.gateway.service.operation.OperationExecutor.executeStatement(OperationExecutor.java:200)
> at 
> org.apache.flink.table.gateway.service.SqlGatewayServiceImpl.lambda$executeStatement$1(SqlGatewayServiceImpl.java:212)
> at 
> org.apache.flink.table.gateway.service.operation.OperationManager.lambda$submitOperation$1(OperationManager.java:119)
> at 
> org.apache.flink.table.gateway.service.operation.OperationManager$Operation.lambda$run$0(OperationManager.java:258)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] flinkbot commented on pull request #22454: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type based on the bytesPersistedDuringAlignment

2023-04-22 Thread via GitHub


flinkbot commented on PR #22454:
URL: https://github.com/apache/flink/pull/22454#issuecomment-1518923312

   
   ## CI report:
   
   * 6fafdf3120e26461e3fb8306c566ecda980daf84 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (FLINK-31882) SqlGateway will throw exception when executing DeleteFromFilterOperation

2023-04-22 Thread yuzelin (Jira)
yuzelin created FLINK-31882:
---

 Summary: SqlGateway will throw exception when executing 
DeleteFromFilterOperation
 Key: FLINK-31882
 URL: https://issues.apache.org/jira/browse/FLINK-31882
 Project: Flink
  Issue Type: Bug
  Components: Table SQL / API, Table SQL / Gateway
Affects Versions: 1.17.0
Reporter: yuzelin






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] flinkbot commented on pull request #22453: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type based on the bytesPersistedDuringAlignment

2023-04-22 Thread via GitHub


flinkbot commented on PR #22453:
URL: https://github.com/apache/flink/pull/22453#issuecomment-1518923298

   
   ## CI report:
   
   * edccb9a86d5759f1459d0bfdc32e5821b6ea024b UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] 1996fanrui opened a new pull request, #22454: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type based on the bytesPersistedDuringAlignment

2023-04-22 Thread via GitHub


1996fanrui opened a new pull request, #22454:
URL: https://github.com/apache/flink/pull/22454

   Backport FLINK-31588 to 1.16


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] 1996fanrui opened a new pull request, #22453: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type based on the bytesPersistedDuringAlignment

2023-04-22 Thread via GitHub


1996fanrui opened a new pull request, #22453:
URL: https://github.com/apache/flink/pull/22453

   Backport FLINK-31588 to 1.17


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Reopened] (FLINK-31588) The unaligned checkpoint type is wrong at subtask level

2023-04-22 Thread Rui Fan (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rui Fan reopened FLINK-31588:
-

> The unaligned checkpoint type is wrong at subtask level
> ---
>
> Key: FLINK-31588
> URL: https://issues.apache.org/jira/browse/FLINK-31588
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
> Attachments: image-2023-03-23-18-45-01-535.png
>
>
> FLINK-20488 supported show checkpoint type for each subtask, and it based on 
> received `CheckpointOptions` and it's right.
> However, FLINK-27251 supported timeout aligned to unaligned checkpoint 
> barrier in the output buffers. It means the received `CheckpointOptions` can 
> be converted from aligned checkpoint to unaligned checkpoint.
> So, the unaligned checkpoint type may be wrong at subtask level. For example, 
> as shown in the figure below, Unaligned checkpoint type is false, but it is 
> actually Unaligned checkpoint (persisted data > 0).
>  
> !image-2023-03-23-18-45-01-535.png|width=1879,height=797!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (FLINK-31588) The unaligned checkpoint type is wrong at subtask level

2023-04-22 Thread Rui Fan (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rui Fan closed FLINK-31588.
---
Fix Version/s: 1.18.0
   Resolution: Fixed

> The unaligned checkpoint type is wrong at subtask level
> ---
>
> Key: FLINK-31588
> URL: https://issues.apache.org/jira/browse/FLINK-31588
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.18.0
>
> Attachments: image-2023-03-23-18-45-01-535.png
>
>
> FLINK-20488 supported show checkpoint type for each subtask, and it based on 
> received `CheckpointOptions` and it's right.
> However, FLINK-27251 supported timeout aligned to unaligned checkpoint 
> barrier in the output buffers. It means the received `CheckpointOptions` can 
> be converted from aligned checkpoint to unaligned checkpoint.
> So, the unaligned checkpoint type may be wrong at subtask level. For example, 
> as shown in the figure below, Unaligned checkpoint type is false, but it is 
> actually Unaligned checkpoint (persisted data > 0).
>  
> !image-2023-03-23-18-45-01-535.png|width=1879,height=797!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31588) The unaligned checkpoint type is wrong at subtask level

2023-04-22 Thread Rui Fan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715340#comment-17715340
 ] 

Rui Fan commented on FLINK-31588:
-

Thanks [~pnowojski] for the review and discussion.

Merged master commit: d46d8d0f6b590f185608b23fbe8b2fcbded111de

> The unaligned checkpoint type is wrong at subtask level
> ---
>
> Key: FLINK-31588
> URL: https://issues.apache.org/jira/browse/FLINK-31588
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Rui Fan
>Assignee: Rui Fan
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2023-03-23-18-45-01-535.png
>
>
> FLINK-20488 supported show checkpoint type for each subtask, and it based on 
> received `CheckpointOptions` and it's right.
> However, FLINK-27251 supported timeout aligned to unaligned checkpoint 
> barrier in the output buffers. It means the received `CheckpointOptions` can 
> be converted from aligned checkpoint to unaligned checkpoint.
> So, the unaligned checkpoint type may be wrong at subtask level. For example, 
> as shown in the figure below, Unaligned checkpoint type is false, but it is 
> actually Unaligned checkpoint (persisted data > 0).
>  
> !image-2023-03-23-18-45-01-535.png|width=1879,height=797!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] 1996fanrui merged pull request #22392: [FLINK-31588][checkpoint] Correct the unaligned checkpoint type after aligned barrier timeout to unaligned barrier on PipelinedSubpartition

2023-04-22 Thread via GitHub


1996fanrui merged PR #22392:
URL: https://github.com/apache/flink/pull/22392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink-connector-jdbc] complone commented on pull request #42: [FLINK-31820] Support data source sub-database and sub-table

2023-04-22 Thread via GitHub


complone commented on PR #42:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/42#issuecomment-1518912732

   > 根据社区贡献手册解释了变化
   
   
   
   > community contribution manual
   
   Thank you, please let me apologize for not understanding the community 
contribution manual. Since I need to develop more functions for my company 
recently, I haven't had time to read your content in JIRA, I will read the 
manual recently and explain clearly Related concepts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] chenyu-opensource closed pull request #22441: [hotfix]Use wrapper classes like other parameters

2023-04-22 Thread via GitHub


chenyu-opensource closed pull request #22441: [hotfix]Use wrapper classes like 
other parameters
URL: https://github.com/apache/flink/pull/22441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (FLINK-31854) Flink connector redshift

2023-04-22 Thread Samrat Deb (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Samrat Deb updated FLINK-31854:
---
Description: 
Proposal :

Add new feature (submodule) flink connector redshift in flink-connector-aws.

 

Next steps 
 - Create a flip for the flink connector redshift 

 

 

  was:
Proposal :

Add new feature (submodule) flink connector redshift in flink-connector-aws.
This connector should be based on FLIP-27 



 

Next steps 
- Create a flip for the flink connector redshift 

 

 


> Flink connector redshift 
> -
>
> Key: FLINK-31854
> URL: https://issues.apache.org/jira/browse/FLINK-31854
> Project: Flink
>  Issue Type: New Feature
>  Components: Connectors / AWS
>Reporter: Samrat Deb
>Priority: Major
>
> Proposal :
> Add new feature (submodule) flink connector redshift in flink-connector-aws.
>  
> Next steps 
>  - Create a flip for the flink connector redshift 
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [flink] noomanee commented on pull request #22400: [FLINK-31689][flink-connector-files] Check expired file state before …

2023-04-22 Thread via GitHub


noomanee commented on PR #22400:
URL: https://github.com/apache/flink/pull/22400#issuecomment-1518702761

   @MartijnVisser As I checked, current test already cover this case. It 
actually hit the condition on 
[line](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/stream/compact/CompactOperatorTest.java#L101).
 I check code coverage of `CompactorOpeartorTest.java` is 98% already, 62 out 
of 63 lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #22452: [FLINK-31799][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore.

2023-04-22 Thread via GitHub


flinkbot commented on PR #22452:
URL: https://github.com/apache/flink/pull/22452#issuecomment-1518680512

   
   ## CI report:
   
   * 6f4c4cf66dd625d756a185cfd98dc8e66ff65e04 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [flink] zzzzzzzs opened a new pull request, #22452: [FLINK-31799][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore.

2023-04-22 Thread via GitHub


zzzs opened a new pull request, #22452:
URL: https://github.com/apache/flink/pull/22452

   ## Brief change log
   fix the typo in docs/content/docs/libs/cep.md
   fix the typo in docs/content.zh/docs/libs/cep.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (FLINK-31881) The Chinese documentation page of Flink official CEP is experiencing confusion.

2023-04-22 Thread zhaoshuo (Jira)
zhaoshuo created FLINK-31881:


 Summary: The Chinese documentation page of Flink official CEP is 
experiencing confusion.
 Key: FLINK-31881
 URL: https://issues.apache.org/jira/browse/FLINK-31881
 Project: Flink
  Issue Type: Improvement
  Components: chinese-translation
Affects Versions: 1.18.0
Reporter: zhaoshuo
 Fix For: 1.18.0
 Attachments: image-2023-04-22-21-55-15-225.png

The Chinese documentation page of Flink official CEP is experiencing confusion.

https://nightlies.apache.org/flink/flink-docs-master/zh/docs/libs/cep/#%E5%BE%AA%E7%8E%AF%E6%A8%A1%E5%BC%8F%E4%B8%AD%E7%9A%84%E8%BF%9E%E7%BB%AD%E6%80%A7

 

!image-2023-04-22-21-55-15-225.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (FLINK-31354) NettyClientServerSslTest.testValidSslConnectionAdvanced timed out

2023-04-22 Thread Sergey Nuyanzin (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-31354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Nuyanzin updated FLINK-31354:

Affects Version/s: 1.18.0

> NettyClientServerSslTest.testValidSslConnectionAdvanced timed out
> -
>
> Key: FLINK-31354
> URL: https://issues.apache.org/jira/browse/FLINK-31354
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Affects Versions: 1.17.0, 1.18.0
>Reporter: Matthias Pohl
>Assignee: Matthias Pohl
>Priority: Critical
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46883&view=logs&j=4d4a0d10-fca2-5507-8eed-c07f0bdf4887&t=7b25afdf-cc6c-566f-5459-359dc2585798&l=8242
> {code}
> Test testValidSslConnectionAdvanced[SSL provider = 
> JDK](org.apache.flink.runtime.io.network.netty.NettyClientServerSslTest) is 
> running.
> 
> 05:15:10,904 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyConfig[] - NettyConfig 
> [server address: localhost/127.0.0.1, server port: 42935, ssl enabled: true, 
> memory segment size (bytes): 1024, transport type: AUTO, number of server 
> threads: 1 (manual), number of client threads>
> 05:15:10,916 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyServer[] - Transport 
> type 'auto': using EPOLL.
> 05:15:12,149 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyServer[] - Successful 
> initialization (took 1245 ms). Listening on SocketAddress /127.0.0.1:42935.
> 05:15:12,150 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyClient[] - Transport 
> type 'auto': using EPOLL.
> 05:15:13,249 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyClient[] - Successful 
> initialization (took 1099 ms).
> 05:15:14,588 [main] ERROR 
> org.apache.flink.runtime.io.network.netty.NettyClientServerSslTest [] - 
> 
> Test testValidSslConnectionAdvanced[SSL provider = 
> JDK](org.apache.flink.runtime.io.network.netty.NettyClientServerSslTest) 
> failed with:
> org.apache.flink.shaded.netty4.io.netty.handler.ssl.SslHandshakeTimeoutException:
>  handshake timed out after 1000ms
> at 
> org.apache.flink.shaded.netty4.io.netty.handler.ssl.SslHandler$7.run(SslHandler.java:2115)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:153)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
> at 
> org.apache.flink.shaded.netty4.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:403)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31354) NettyClientServerSslTest.testValidSslConnectionAdvanced timed out

2023-04-22 Thread Sergey Nuyanzin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715291#comment-17715291
 ] 

Sergey Nuyanzin commented on FLINK-31354:
-

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=48354&view=logs&j=4d4a0d10-fca2-5507-8eed-c07f0bdf4887&t=7b25afdf-cc6c-566f-5459-359dc2585798&l=8673

> NettyClientServerSslTest.testValidSslConnectionAdvanced timed out
> -
>
> Key: FLINK-31354
> URL: https://issues.apache.org/jira/browse/FLINK-31354
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Coordination
>Affects Versions: 1.17.0, 1.18.0
>Reporter: Matthias Pohl
>Assignee: Matthias Pohl
>Priority: Critical
>  Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46883&view=logs&j=4d4a0d10-fca2-5507-8eed-c07f0bdf4887&t=7b25afdf-cc6c-566f-5459-359dc2585798&l=8242
> {code}
> Test testValidSslConnectionAdvanced[SSL provider = 
> JDK](org.apache.flink.runtime.io.network.netty.NettyClientServerSslTest) is 
> running.
> 
> 05:15:10,904 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyConfig[] - NettyConfig 
> [server address: localhost/127.0.0.1, server port: 42935, ssl enabled: true, 
> memory segment size (bytes): 1024, transport type: AUTO, number of server 
> threads: 1 (manual), number of client threads>
> 05:15:10,916 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyServer[] - Transport 
> type 'auto': using EPOLL.
> 05:15:12,149 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyServer[] - Successful 
> initialization (took 1245 ms). Listening on SocketAddress /127.0.0.1:42935.
> 05:15:12,150 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyClient[] - Transport 
> type 'auto': using EPOLL.
> 05:15:13,249 [main] INFO  
> org.apache.flink.runtime.io.network.netty.NettyClient[] - Successful 
> initialization (took 1099 ms).
> 05:15:14,588 [main] ERROR 
> org.apache.flink.runtime.io.network.netty.NettyClientServerSslTest [] - 
> 
> Test testValidSslConnectionAdvanced[SSL provider = 
> JDK](org.apache.flink.runtime.io.network.netty.NettyClientServerSslTest) 
> failed with:
> org.apache.flink.shaded.netty4.io.netty.handler.ssl.SslHandshakeTimeoutException:
>  handshake timed out after 1000ms
> at 
> org.apache.flink.shaded.netty4.io.netty.handler.ssl.SslHandler$7.run(SslHandler.java:2115)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:153)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
> at 
> org.apache.flink.shaded.netty4.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:403)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
> at 
> org.apache.flink.shaded.netty4.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (FLINK-31743) Avoid relocating the RocksDB's log failure when filename exceeds 255 characters

2023-04-22 Thread jinghaihang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-31743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715288#comment-17715288
 ] 

jinghaihang commented on FLINK-31743:
-

H,[~yunta] 
Sorry that due to the adjustment of my work direction, this issue will be 
followed up by my colleague. Please assign the task to [~Feifan Wang] . 
Thanks a lot.

> Avoid relocating the RocksDB's log failure when filename exceeds 255 
> characters
> ---
>
> Key: FLINK-31743
> URL: https://issues.apache.org/jira/browse/FLINK-31743
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / State Backends
>Affects Versions: 1.16.1, 1.15.4
>Reporter: jinghaihang
>Assignee: jinghaihang
>Priority: Major
> Fix For: 1.16.2, 1.18.0, 1.17.1
>
>
> Since FLINK-24785 , the file name of the rocksdb LOG is generated by parsing 
> the db path, when the db path is long and the filename exceeds 255 
> characters, the creation of the file will fail, so the relevant rocksdb LOG 
> cannot be seen in the flink log dir.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)