[jira] [Commented] (FLINK-31542) FatalExceptionClassifier#isFatal returns false if the exception is fatal
[
https://issues.apache.org/jira/browse/FLINK-31542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703678#comment-17703678
]
DavidLiu commented on FLINK-31542:
--
[~danny.cranmer] Would you please help review this PR?
> FatalExceptionClassifier#isFatal returns false if the exception is fatal
>
>
> Key: FLINK-31542
> URL: https://issues.apache.org/jira/browse/FLINK-31542
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Common
>Affects Versions: 1.16.0
>Reporter: Samuel Siebenmann
>Priority: Minor
> Labels: pull-request-available
>
> FatalExceptionClassifier#isFatal returns `false` if the passed throwable is
> fatal and `true` if it is not:
> {code:java}
> public boolean isFatal(Throwable err, Consumer throwableConsumer){
>
> if (validator.test(err)) {
> throwableConsumer.accept(throwableMapper.apply(err));
> return false;
> }
> if (chainedClassifier != null) {
> return chainedClassifier.isFatal(err, throwableConsumer);
> } else {
> return true;
> }
> }
> {code}
> ([github|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java#L44])
> However, the semantics of the method would indicate that it should return
> `true` if the passed throwable is fatal and `false` if it is not (i.e. the
> opposite of what is currently the case).
> Additionally, the method name doesn't clearly indicate its side effects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-31542) FatalExceptionClassifier#isFatal returns false if the exception is fatal
[
https://issues.apache.org/jira/browse/FLINK-31542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703464#comment-17703464
]
DavidLiu commented on FLINK-31542:
--
Please assign this to me, I will fix it.
> FatalExceptionClassifier#isFatal returns false if the exception is fatal
>
>
> Key: FLINK-31542
> URL: https://issues.apache.org/jira/browse/FLINK-31542
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Common
>Affects Versions: 1.16.0
>Reporter: Samuel Siebenmann
>Priority: Minor
>
> FatalExceptionClassifier#isFatal returns `false` if the passed throwable is
> fatal and `true` if it is not:
> {code:java}
> public boolean isFatal(Throwable err, Consumer throwableConsumer){
>
> if (validator.test(err)) {
> throwableConsumer.accept(throwableMapper.apply(err));
> return false;
> }
> if (chainedClassifier != null) {
> return chainedClassifier.isFatal(err, throwableConsumer);
> } else {
> return true;
> }
> }
> {code}
> ([github|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java#L44])
> However, the semantics of the method would indicate that it should return
> `true` if the passed throwable is fatal and `false` if it is not (i.e. the
> opposite of what is currently the case).
> Additionally, the method name doesn't clearly indicate its side effects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] (FLINK-28947) Curator framework fails with NullPointerException
[ https://issues.apache.org/jira/browse/FLINK-28947 ]
DavidLiu deleted comment on FLINK-28947:
--
was (Author: JIRAUSER289843):
It seems Curator has bug. I can help fix it.
> Curator framework fails with NullPointerException
> -
>
> Key: FLINK-28947
> URL: https://issues.apache.org/jira/browse/FLINK-28947
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.15.1
>Reporter: Juha
>Priority: Major
>
> I'm getting the following error in JobManager and as a result JobManager
> exits.
> {code:java}
> Aug 12 06:37:30 server_name java[173]: [2022-08-12 06:37:30,491] ERROR
> Background exception was not retry-able or retry gave up
> (org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.CuratorFrameworkImpl:733)
> Aug 12 06:37:30 server_name java[173]: java.lang.NullPointerException: null
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.utils.Compatibility.getHostAddress(Compatibility.java:116)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.configToConnectionString(EnsembleTracker.java:185)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.processConfigData(EnsembleTracker.java:206)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.access$300(EnsembleTracker.java:50)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker$2.processResult(EnsembleTracker.java:150)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.CuratorFrameworkImpl.sendToBackgroundCallback(CuratorFrameworkImpl.java:926)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.CuratorFrameworkImpl.processBackgroundOperation(CuratorFrameworkImpl.java:683)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.WatcherRemovalFacade.processBackgroundOperation(WatcherRemovalFacade.java:152)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.GetConfigBuilderImpl$2.processResult(GetConfigBuilderImpl.java:222)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.zookeeper3.org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:598)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.zookeeper3.org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:510)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: [2022-08-12 06:37:30,493] ERROR
> Unhandled error in curator framework, error message: Background exception was
> not retry-able or retry gave up
> (org.apache.flink.runtime.util.ZooKeeperUtils:292)
> Aug 12 06:37:30 server_name java[173]: java.lang.NullPointerException: null
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.utils.Compatibility.getHostAddress(Compatibility.java:116)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.configToConnectionString(EnsembleTracker.java:185)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.processConfigData(EnsembleTracker.java:206)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.access$300(EnsembleTracker.java:50)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker$2.processResult(EnsembleTracker.java:150)
>
[jira] [Commented] (FLINK-28947) Curator framework fails with NullPointerException
[
https://issues.apache.org/jira/browse/FLINK-28947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579431#comment-17579431
]
DavidLiu commented on FLINK-28947:
--
It seems Curator has bug. I can help fix it.
> Curator framework fails with NullPointerException
> -
>
> Key: FLINK-28947
> URL: https://issues.apache.org/jira/browse/FLINK-28947
> Project: Flink
> Issue Type: Bug
>Affects Versions: 1.15.1
>Reporter: Juha
>Priority: Major
>
> I'm getting the following error in JobManager and as a result JobManager
> exits.
> {code:java}
> Aug 12 06:37:30 server_name java[173]: [2022-08-12 06:37:30,491] ERROR
> Background exception was not retry-able or retry gave up
> (org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.CuratorFrameworkImpl:733)
> Aug 12 06:37:30 server_name java[173]: java.lang.NullPointerException: null
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.utils.Compatibility.getHostAddress(Compatibility.java:116)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.configToConnectionString(EnsembleTracker.java:185)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.processConfigData(EnsembleTracker.java:206)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.access$300(EnsembleTracker.java:50)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker$2.processResult(EnsembleTracker.java:150)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.CuratorFrameworkImpl.sendToBackgroundCallback(CuratorFrameworkImpl.java:926)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.CuratorFrameworkImpl.processBackgroundOperation(CuratorFrameworkImpl.java:683)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.WatcherRemovalFacade.processBackgroundOperation(WatcherRemovalFacade.java:152)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.GetConfigBuilderImpl$2.processResult(GetConfigBuilderImpl.java:222)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.zookeeper3.org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:598)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.zookeeper3.org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:510)
> [flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: [2022-08-12 06:37:30,493] ERROR
> Unhandled error in curator framework, error message: Background exception was
> not retry-able or retry gave up
> (org.apache.flink.runtime.util.ZooKeeperUtils:292)
> Aug 12 06:37:30 server_name java[173]: java.lang.NullPointerException: null
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.utils.Compatibility.getHostAddress(Compatibility.java:116)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.configToConnectionString(EnsembleTracker.java:185)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.processConfigData(EnsembleTracker.java:206)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
> org.apache.flink.shaded.curator5.org.apache.curator.framework.imps.EnsembleTracker.access$300(EnsembleTracker.java:50)
> ~[flink-shaded-zookeeper-3.5.9.jar:3.5.9-15.0]
> Aug 12 06:37:30 server_name java[173]: at
>
[jira] [Comment Edited] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'
[
https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573268#comment-17573268
]
DavidLiu edited comment on FLINK-28111 at 7/30/22 1:58 PM:
---
This is not an issue, but rather, by design.
The timestamp sequence can not be guranteed when there are two timestamps in
"union all", which will lost the time attribute.
"join" two stream tables with time attribute will also have the similar results.
was (Author: JIRAUSER289843):
This is not an issue, but rather, by design.
The timestamp sequence can not be guranteed when there are two timestamps in
"union all", which will lost the time attribute.
"join" two stream tables with time attribute will have the similar results.
> flinksql use hivecatalog cause union all operation lost 'eventTime
> attribute'
> ---
>
> Key: FLINK-28111
> URL: https://issues.apache.org/jira/browse/FLINK-28111
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime
>Affects Versions: 1.12.4, 1.13.5, 1.14.4
> Environment: flink 1.12.4
> hadoop 2.6.5
> hive 1.1.0
>Reporter: yutao
>Priority: Major
>
> In my scenario , i have 2 topics have same schema ; i register them to
> table and define eventtime.
> then create view use union all 2 table ,and use view group by tumble
> window ;
> but when set hivecatalog ,sql can not run ;just like this:
> Exception in thread "main" org.apache.flink.table.api.TableException: Window
> aggregate can only be defined over a time attribute column, but TIMESTAMP(3)
> encountered.
>
> *The complete code is as follows*
> {code:java}
> package com.unicom.test;
> import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
> import org.apache.flink.table.api.EnvironmentSettings;
> import org.apache.flink.table.api.SqlDialect;
> import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
> import org.apache.flink.table.catalog.hive.HiveCatalog;
> /**
> *
> * @author yt
> */
> public class DataGenAndPrintSink {
> public static void main(String[] args) throws Exception {
> StreamExecutionEnvironment env =
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.setParallelism(1);
> EnvironmentSettings envSetting = EnvironmentSettings
> .newInstance()
> .useBlinkPlanner()
> .inStreamingMode()
> .build();
> StreamTableEnvironment tableEnv = StreamTableEnvironment.create(env,
> envSetting);
> String defaultDatabase = "dc_dw" ;
> String catalogName = "dc_catalog";
> HiveCatalog hive = new HiveCatalog(catalogName, defaultDatabase,
> "hdfs://beh/flink/hive/conf","1.1.0");
> tableEnv.registerCatalog(catalogName, hive);
> tableEnv.useCatalog(catalogName);
> tableEnv.useDatabase(defaultDatabase);
> tableEnv.getConfig().setSqlDialect(SqlDialect.DEFAULT);
> String sourceDDL = "CREATE TABLE IF NOT EXISTS source_table (\n" +
> "-- 维度数据\n" +
> "order_id STRING,\n" +
> "-- 用户 id\n" +
> "user_id BIGINT,\n" +
> "-- 用户\n" +
> "price BIGINT,\n" +
> "-- 事件时间戳\n" +
> "row_time AS cast(CURRENT_TIMESTAMP as timestamp(3)),\n" +
> "-- watermark 设置\n" +
> "WATERMARK FOR row_time AS row_time - INTERVAL '5'
> SECOND\n" +
> ") WITH (\n" +
> " 'connector' = 'datagen',\n" +
> " 'rows-per-second' = '10',\n" +
> " 'fields.order_id.length' = '1',\n" +
> " 'fields.user_id.min' = '1',\n" +
> " 'fields.user_id.max' = '10',\n" +
> " 'fields.price.min' = '1',\n" +
> " 'fields.price.max' = '10'\n" +
> ")";
> String sourceDDL_2 = "CREATE TABLE IF NOT EXISTS source_table_2 (\n" +
> "-- 维度数据\n" +
> "order_id STRING,\n" +
> "-- 用户 id\n" +
> "user_id BIGINT,\n" +
> "-- 用户\n" +
> "price BIGINT,\n" +
> "-- 事件时间戳\n" +
> "row_time AS cast(CURRENT_TIMESTAMP as timestamp(3)),\n" +
> "-- watermark 设置\n" +
> "WATERMARK FOR row_time AS row_time - INTERVAL '5'
> SECOND\n" +
> ") WITH (\n" +
> " 'connector' = 'datagen',\n" +
> " 'rows-per-second' = '10',\n" +
> " 'fields.order_id.length' = '1',\n" +
> "
[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'
[
https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573268#comment-17573268
]
DavidLiu commented on FLINK-28111:
--
This is not an issue, but rather, by design.
The timestamp sequence can not be guranteed when there are two timestamps in
"union all", which will lost the time attribute.
"join" two stream tables with time attribute will have the similar results.
> flinksql use hivecatalog cause union all operation lost 'eventTime
> attribute'
> ---
>
> Key: FLINK-28111
> URL: https://issues.apache.org/jira/browse/FLINK-28111
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / API, Table SQL / Planner, Table SQL / Runtime
>Affects Versions: 1.12.4, 1.13.5, 1.14.4
> Environment: flink 1.12.4
> hadoop 2.6.5
> hive 1.1.0
>Reporter: yutao
>Priority: Major
>
> In my scenario , i have 2 topics have same schema ; i register them to
> table and define eventtime.
> then create view use union all 2 table ,and use view group by tumble
> window ;
> but when set hivecatalog ,sql can not run ;just like this:
> Exception in thread "main" org.apache.flink.table.api.TableException: Window
> aggregate can only be defined over a time attribute column, but TIMESTAMP(3)
> encountered.
>
> *The complete code is as follows*
> {code:java}
> package com.unicom.test;
> import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
> import org.apache.flink.table.api.EnvironmentSettings;
> import org.apache.flink.table.api.SqlDialect;
> import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
> import org.apache.flink.table.catalog.hive.HiveCatalog;
> /**
> *
> * @author yt
> */
> public class DataGenAndPrintSink {
> public static void main(String[] args) throws Exception {
> StreamExecutionEnvironment env =
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.setParallelism(1);
> EnvironmentSettings envSetting = EnvironmentSettings
> .newInstance()
> .useBlinkPlanner()
> .inStreamingMode()
> .build();
> StreamTableEnvironment tableEnv = StreamTableEnvironment.create(env,
> envSetting);
> String defaultDatabase = "dc_dw" ;
> String catalogName = "dc_catalog";
> HiveCatalog hive = new HiveCatalog(catalogName, defaultDatabase,
> "hdfs://beh/flink/hive/conf","1.1.0");
> tableEnv.registerCatalog(catalogName, hive);
> tableEnv.useCatalog(catalogName);
> tableEnv.useDatabase(defaultDatabase);
> tableEnv.getConfig().setSqlDialect(SqlDialect.DEFAULT);
> String sourceDDL = "CREATE TABLE IF NOT EXISTS source_table (\n" +
> "-- 维度数据\n" +
> "order_id STRING,\n" +
> "-- 用户 id\n" +
> "user_id BIGINT,\n" +
> "-- 用户\n" +
> "price BIGINT,\n" +
> "-- 事件时间戳\n" +
> "row_time AS cast(CURRENT_TIMESTAMP as timestamp(3)),\n" +
> "-- watermark 设置\n" +
> "WATERMARK FOR row_time AS row_time - INTERVAL '5'
> SECOND\n" +
> ") WITH (\n" +
> " 'connector' = 'datagen',\n" +
> " 'rows-per-second' = '10',\n" +
> " 'fields.order_id.length' = '1',\n" +
> " 'fields.user_id.min' = '1',\n" +
> " 'fields.user_id.max' = '10',\n" +
> " 'fields.price.min' = '1',\n" +
> " 'fields.price.max' = '10'\n" +
> ")";
> String sourceDDL_2 = "CREATE TABLE IF NOT EXISTS source_table_2 (\n" +
> "-- 维度数据\n" +
> "order_id STRING,\n" +
> "-- 用户 id\n" +
> "user_id BIGINT,\n" +
> "-- 用户\n" +
> "price BIGINT,\n" +
> "-- 事件时间戳\n" +
> "row_time AS cast(CURRENT_TIMESTAMP as timestamp(3)),\n" +
> "-- watermark 设置\n" +
> "WATERMARK FOR row_time AS row_time - INTERVAL '5'
> SECOND\n" +
> ") WITH (\n" +
> " 'connector' = 'datagen',\n" +
> " 'rows-per-second' = '10',\n" +
> " 'fields.order_id.length' = '1',\n" +
> " 'fields.user_id.min' = '1',\n" +
> " 'fields.user_id.max' = '10',\n" +
> " 'fields.price.min' = '1',\n" +
> " 'fields.price.max' = '10'\n" +
> ")";
> tableEnv.executeSql(sourceDDL);
> tableEnv.executeSql(sourceDDL_2);
> String view =
[jira] [Commented] (FLINK-27019) use hive dialect in SqlClient would thrown an error based on 1.15 version
[ https://issues.apache.org/jira/browse/FLINK-27019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573263#comment-17573263 ] DavidLiu commented on FLINK-27019: -- The source codes have supported hive-dialect. This issue cannot be reproduced again, this issue can be closed. > use hive dialect in SqlClient would thrown an error based on 1.15 version > - > > Key: FLINK-27019 > URL: https://issues.apache.org/jira/browse/FLINK-27019 > Project: Flink > Issue Type: Bug > Components: Table SQL / Client >Affects Versions: 1.15.0 >Reporter: Jing Zhang >Priority: Major > Attachments: image-2022-04-02-20-25-25-169.png > > > I use 1.15 rc0 and encounter a problem. > An error would be thrown out if I use hive dialect in SqlClient. > !image-2022-04-02-20-25-25-169.png! > And I already add flink-sql-connector-hive-2.3.6_2.12-1.15-SNAPSHOT.jar. > I note that, load and use hive module could work fine, but use hive dialect > would fail. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable
[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571928#comment-17571928 ] DavidLiu commented on FLINK-27537: -- [~CrynetLogistics] Any comment ? > Remove requirement for Async Sink's RequestEntryT to be serializable > > > Key: FLINK-27537 > URL: https://issues.apache.org/jira/browse/FLINK-27537 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > > Currently, in AsyncSinkBase and it's dependent classes, e.g. the sink writer, > element converter etc., the RequestEntryT generic type is required to be > serializable. > However, this requirement no longer holds and there is nothing that actually > requires this. > Proposed approach: > * Remove the extends serializable from the generic type RequestEntryT -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571827#comment-17571827 ] DavidLiu commented on FLINK-25735: -- [~martijnvisser] The old PR was closed, I provide a new PR [https://github.com/apache/flink/pull/20379] Would you please help review this PR ? Thanks. > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation, pull-request-available > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735 ] DavidLiu deleted comment on FLINK-25735: -- was (Author: JIRAUSER289843): [~martijnvisser] The old PR was closed, I provide a new PR [https://github.com/apache/flink/pull/20379] Would you please help review this PR again? Thanks. > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation, pull-request-available > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735 ] DavidLiu deleted comment on FLINK-25735: -- was (Author: JIRAUSER289843): The pull request is [https://github.com/apache/flink/pull/20143] Please help review it > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation, pull-request-available > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567045#comment-17567045 ] DavidLiu edited comment on FLINK-25735 at 7/27/22 9:57 AM: --- [~martijnvisser] The old PR was closed, I provide a new PR [https://github.com/apache/flink/pull/20379] Would you please help review this PR again? Thanks. was (Author: JIRAUSER289843): [~CrynetLogistics] [~martijnvisser] Would you please help review this PR again? Thanks. > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation, pull-request-available > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571447#comment-17571447 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer] Please help review this Pull Request again，which has been updated. [https://github.com/apache/flink/pull/20360] > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536 ] DavidLiu deleted comment on FLINK-27536: -- was (Author: JIRAUSER289843): [~dannycranmer] Please help review this Pull Request again，which has been updated. [https://github.com/apache/flink/pull/20360] > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 1:54 PM: --- [~dannycranmer] Please help review this Pull Request again，which has been updated. [https://github.com/apache/flink/pull/20360] was (Author: JIRAUSER289843): [~dannycranmer] The old PR was closed, please help review the new Pull Request [https://github.com/apache/flink/pull/20360] The build failure was fixed and verified locally. > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:13 AM: --- [~dannycranmer] The old PR was closed, please help review the new Pull Request [https://github.com/apache/flink/pull/20360] the build failure was fixed and verified locally. was (Author: JIRAUSER289843): [~dannycranmer] I open a new Pull Request [https://github.com/apache/flink/pull/20360] > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:13 AM: --- [~dannycranmer] The old PR was closed, please help review the new Pull Request [https://github.com/apache/flink/pull/20360] The build failure was fixed and verified locally. was (Author: JIRAUSER289843): [~dannycranmer] The old PR was closed, please help review the new Pull Request [https://github.com/apache/flink/pull/20360] the build failure was fixed and verified locally. > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571196#comment-17571196 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:10 AM: --- [~dannycranmer] I open a new Pull Request [https://github.com/apache/flink/pull/20360] was (Author: JIRAUSER289843): [~dannycranmer] I will open a new Pull Request > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571196#comment-17571196 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer] I will open a new Pull Request > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569805#comment-17569805 ] DavidLiu edited comment on FLINK-27536 at 7/26/22 5:09 AM: --- The pull request [https://github.com/apache/flink/pull/20360] Please help review it. was (Author: JIRAUSER289843): The pull request [https://github.com/apache/flink/pull/20338] Please help review it. > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569934#comment-17569934 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer] please review the feedback in PR. Thanks > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable
[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569835#comment-17569835 ] DavidLiu edited comment on FLINK-27537 at 7/22/22 6:37 AM: --- The following files will be covered. [flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java|https://github.com/apache/flink/blob/423143c1a9dcfba2c8ddc08f4c785451b82802be/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java] [flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/table/sink/AsyncDynamicTableSink.java|https://github.com/apache/flink/blob/bdfabeba60db1096ed7e100ed12c4837da5935d7/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/table/sink/AsyncDynamicTableSink.java] [flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBaseBuilder.java|https://github.com/apache/flink/blob/25ecc0b9202050b340fb4d6fc95b0585a8119937/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBaseBuilder.java] [flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java|https://github.com/apache/flink/blob/a2df2665b6ff411a2aeb9b204fd9d46a2af0ecfa/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java] was (Author: JIRAUSER289843): [flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java|https://github.com/apache/flink/blob/423143c1a9dcfba2c8ddc08f4c785451b82802be/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java] > Remove requirement for Async Sink's RequestEntryT to be serializable > > > Key: FLINK-27537 > URL: https://issues.apache.org/jira/browse/FLINK-27537 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > > Currently, in AsyncSinkBase and it's dependent classes, e.g. the sink writer, > element converter etc., the RequestEntryT generic type is required to be > serializable. > However, this requirement no longer holds and there is nothing that actually > requires this. > Proposed approach: > * Remove the extends serializable from the generic type RequestEntryT -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable
[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569835#comment-17569835 ] DavidLiu commented on FLINK-27537: -- [flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java|https://github.com/apache/flink/blob/423143c1a9dcfba2c8ddc08f4c785451b82802be/flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java] > Remove requirement for Async Sink's RequestEntryT to be serializable > > > Key: FLINK-27537 > URL: https://issues.apache.org/jira/browse/FLINK-27537 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > > Currently, in AsyncSinkBase and it's dependent classes, e.g. the sink writer, > element converter etc., the RequestEntryT generic type is required to be > serializable. > However, this requirement no longer holds and there is nothing that actually > requires this. > Proposed approach: > * Remove the extends serializable from the generic type RequestEntryT -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569805#comment-17569805 ] DavidLiu edited comment on FLINK-27536 at 7/22/22 5:13 AM: --- The pull request [https://github.com/apache/flink/pull/20338] Please help review it. was (Author: JIRAUSER289843): https://github.com/apache/flink/pull/20338 > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569805#comment-17569805 ] DavidLiu commented on FLINK-27536: -- https://github.com/apache/flink/pull/20338 > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Minor > Labels: pull-request-available > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569347#comment-17569347 ] DavidLiu commented on FLINK-27536: -- Hello,Zichen Liu. I would like to deal with it. Can you assign this ticket to me? Thank you. > Rename method parameter in AsyncSinkWriter > -- > > Key: FLINK-27536 > URL: https://issues.apache.org/jira/browse/FLINK-27536 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Priority: Minor > > Change the abstract method's parameter naming in AsyncSinkWriter. > From > Consumer> requestResult > to > Consumer> requestToRetry > or something similar. > > This is because the consumer here is supposed to accept a list of requests > that need to be retried. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27537) Remove requirement for Async Sink's RequestEntryT to be serializable
[ https://issues.apache.org/jira/browse/FLINK-27537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569346#comment-17569346 ] DavidLiu commented on FLINK-27537: -- Hello,Zichen Liu. I would like to deal with it. Can you assign this ticket to me? Thank you. > Remove requirement for Async Sink's RequestEntryT to be serializable > > > Key: FLINK-27537 > URL: https://issues.apache.org/jira/browse/FLINK-27537 > Project: Flink > Issue Type: Improvement > Components: Connectors / Common >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Priority: Major > > Currently, in AsyncSinkBase and it's dependent classes, e.g. the sink writer, > element converter etc., the RequestEntryT generic type is required to be > serializable. > However, this requirement no longer holds and there is nothing that actually > requires this. > Proposed approach: > * Remove the extends serializable from the generic type RequestEntryT -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567045#comment-17567045 ] DavidLiu commented on FLINK-25735: -- [~CrynetLogistics] [~martijnvisser] Would you please help review this PR again, Thanks. > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation, pull-request-available > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567045#comment-17567045 ] DavidLiu edited comment on FLINK-25735 at 7/15/22 1:53 AM: --- [~CrynetLogistics] [~martijnvisser] Would you please help review this PR again? Thanks. was (Author: JIRAUSER289843): [~CrynetLogistics] [~martijnvisser] Would you please help review this PR again, Thanks. > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation, pull-request-available > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561984#comment-17561984 ] DavidLiu commented on FLINK-25735: -- The pull request is [https://github.com/apache/flink/pull/20143] Please help review it > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation, pull-request-available > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735 ] DavidLiu deleted comment on FLINK-25735: -- was (Author: JIRAUSER289843): [The PR is https://github.com/apache/flink/pull/20141|https://github.com/apache/flink/pull/20141] > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561880#comment-17561880 ] DavidLiu edited comment on FLINK-25735 at 7/3/22 3:17 PM: -- [The PR is https://github.com/apache/flink/pull/20141|https://github.com/apache/flink/pull/20141] was (Author: JIRAUSER289843): [https://github.com/apache/flink/pull/20141] > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561880#comment-17561880 ] DavidLiu commented on FLINK-25735: -- [https://github.com/apache/flink/pull/20141] > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Assignee: DavidLiu >Priority: Major > Labels: chinese-translation > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
Title: Message Title DavidLiu commented on FLINK-25735 Re: Chinese Translation - Add documentation for KDS Async Sink OK，I will begin to do it. Add Comment This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)
[jira] [Commented] (FLINK-25735) Chinese Translation - Add documentation for KDS Async Sink
[ https://issues.apache.org/jira/browse/FLINK-25735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558422#comment-17558422 ] DavidLiu commented on FLINK-25735: -- Hello,Zichen Liu. I would like to transfer it to Chinese. Can you assign this ticket to me? Thank you. > Chinese Translation - Add documentation for KDS Async Sink > -- > > Key: FLINK-25735 > URL: https://issues.apache.org/jira/browse/FLINK-25735 > Project: Flink > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.15.0 >Reporter: Zichen Liu >Priority: Major > Labels: chinese-translation > > h2. Translate: > * Connectors/Kinesis page to deprecate old sink > (docs/content/docs/connectors/datastream/kinesis.md) > * Metrics page with new sink metrics (docs/content/docs/ops/metrics.md) - > only the section about Kinesis > into Chinese. -- This message was sent by Atlassian Jira (v8.20.7#820007)
