[jira] [Commented] (FLINK-4506) CsvOutputFormat defaults allowNullValues to false, even though doc and declaration says true
[
https://issues.apache.org/jira/browse/FLINK-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529066#comment-15529066
]
Kirill Morozov commented on FLINK-4506:
---
Rollbacked to old behavior, documentation fixed:
https://github.com/apache/flink/pull/2477/commits/34addbfdb5da0cef596e23ff8e1311954ac0682b
> CsvOutputFormat defaults allowNullValues to false, even though doc and
> declaration says true
>
>
> Key: FLINK-4506
> URL: https://issues.apache.org/jira/browse/FLINK-4506
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats, Documentation
>Reporter: Michael Wong
>Assignee: Kirill Morozov
>Priority: Minor
>
> In the constructor, it has this
> {code}
> this.allowNullValues = false;
> {code}
> But in the setAllowNullValues() method, the doc says the allowNullValues is
> true by default. Also, in the declaration of allowNullValues, the value is
> set to true. It probably makes the most sense to change the constructor.
> {code}
> /**
>* Configures the format to either allow null values (writing an empty
> field),
>* or to throw an exception when encountering a null field.
>*
>* by default, null values are allowed.
>*
>* @param allowNulls Flag to indicate whether the output format should
> accept null values.
>*/
> public void setAllowNullValues(boolean allowNulls) {
> this.allowNullValues = allowNulls;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4506) CsvOutputFormat defaults allowNullValues to false, even though doc and declaration says true
[
https://issues.apache.org/jira/browse/FLINK-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508962#comment-15508962
]
Kirill Morozov commented on FLINK-4506:
---
Hi folks! Can anyone make a review of my PR ?
> CsvOutputFormat defaults allowNullValues to false, even though doc and
> declaration says true
>
>
> Key: FLINK-4506
> URL: https://issues.apache.org/jira/browse/FLINK-4506
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats, Documentation
>Reporter: Michael Wong
>Assignee: Kirill Morozov
>Priority: Minor
>
> In the constructor, it has this
> {code}
> this.allowNullValues = false;
> {code}
> But in the setAllowNullValues() method, the doc says the allowNullValues is
> true by default. Also, in the declaration of allowNullValues, the value is
> set to true. It probably makes the most sense to change the constructor.
> {code}
> /**
>* Configures the format to either allow null values (writing an empty
> field),
>* or to throw an exception when encountering a null field.
>*
>* by default, null values are allowed.
>*
>* @param allowNulls Flag to indicate whether the output format should
> accept null values.
>*/
> public void setAllowNullValues(boolean allowNulls) {
> this.allowNullValues = allowNulls;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (FLINK-4506) CsvOutputFormat defaults allowNullValues to false, even though doc and declaration says true
[
https://issues.apache.org/jira/browse/FLINK-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirill Morozov reassigned FLINK-4506:
-
Assignee: Kirill Morozov
> CsvOutputFormat defaults allowNullValues to false, even though doc and
> declaration says true
>
>
> Key: FLINK-4506
> URL: https://issues.apache.org/jira/browse/FLINK-4506
> Project: Flink
> Issue Type: Bug
> Components: Batch Connectors and Input/Output Formats, Documentation
>Reporter: Michael Wong
>Assignee: Kirill Morozov
>Priority: Minor
>
> In the constructor, it has this
> {code}
> this.allowNullValues = false;
> {code}
> But in the setAllowNullValues() method, the doc says the allowNullValues is
> true by default. Also, in the declaration of allowNullValues, the value is
> set to true. It probably makes the most sense to change the constructor.
> {code}
> /**
>* Configures the format to either allow null values (writing an empty
> field),
>* or to throw an exception when encountering a null field.
>*
>* by default, null values are allowed.
>*
>* @param allowNulls Flag to indicate whether the output format should
> accept null values.
>*/
> public void setAllowNullValues(boolean allowNulls) {
> this.allowNullValues = allowNulls;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
