[jira] [Commented] (FLINK-30221) Fix the bug of sum(try_cast(string as bigint)) return null when partial elements can't convert to bigint
[ https://issues.apache.org/jira/browse/FLINK-30221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641265#comment-17641265 ] Tony Zhu commented on FLINK-30221: -- [~lsy] , I agree with [~martijnvisser] that it is as expected to return null when some element got cast error. > Fix the bug of sum(try_cast(string as bigint)) return null when partial > elements can't convert to bigint > > > Key: FLINK-30221 > URL: https://issues.apache.org/jira/browse/FLINK-30221 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API, Table SQL / Runtime >Affects Versions: 1.17.0 >Reporter: dalongliu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-30221) Fix the bug of sum(try_cast(string as bigint)) return null when partial elements can't convert to bigint
[ https://issues.apache.org/jira/browse/FLINK-30221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639823#comment-17639823 ] Tony Zhu commented on FLINK-30221: -- Could you assign to me and I'd like to try the fix. > Fix the bug of sum(try_cast(string as bigint)) return null when partial > elements can't convert to bigint > > > Key: FLINK-30221 > URL: https://issues.apache.org/jira/browse/FLINK-30221 > Project: Flink > Issue Type: Sub-task > Components: Table SQL / API, Table SQL / Runtime >Affects Versions: 1.17.0 >Reporter: dalongliu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-30158) [Flink SQL][Protobuf] NullPointerException when querying Kafka topic using repeated or map attributes
[
https://issues.apache.org/jira/browse/FLINK-30158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17639822#comment-17639822
]
Tony Zhu commented on FLINK-30158:
--
[~jamesmcguirepro] could you provide more info? I'd like to take a look the
detail.
> [Flink SQL][Protobuf] NullPointerException when querying Kafka topic using
> repeated or map attributes
> -
>
> Key: FLINK-30158
> URL: https://issues.apache.org/jira/browse/FLINK-30158
> Project: Flink
> Issue Type: Bug
> Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile), Table
> SQL / Ecosystem
>Affects Versions: 1.16.0
>Reporter: James Mcguire
>Priority: Major
>
> I am encountering a {{java.lang.NullPointerException}} exception when trying
> to use Flink SQL to query a kafka topic that uses either {{repeated}} and/or
> {{map}} attributes.
>
> {*}{*}{*}Replication{*} *steps*
> # Use a protobuf definition that either uses repeated and/or map. This
> protobuf schema should cover a few of the problematic scenarios I ran into:
>
> {code:java}
> syntax = "proto3";
> package example.message;
> option java_package = "com.example.message";
> option java_multiple_files = true;
> message NestedType {
> int64 nested_first = 1;
> oneof nested_second {
> int64 one_of_first = 2;
> string one_of_second = 3;
> }
> }
> message Test {
> repeated int64 first = 1;
> map second = 2;
> } {code}
> 2. Attempt query on topic, even excluding problematic columns:
>
> {code:java}
> [ERROR] Could not execute SQL statement. Reason:
> org.apache.flink.formats.protobuf.PbCodegenException:
> java.lang.NullPointerException{code}
>
>
> log file:
>
> {code:java}
> 2022-11-22 15:33:59,510 WARN org.apache.flink.table.client.cli.CliClient
> [] - Could not execute SQL
> statement.org.apache.flink.table.client.gateway.SqlExecutionException: Error
> while retrieving result.at
> org.apache.flink.table.client.gateway.local.result.CollectResultBase$ResultRetrievalThread.run(CollectResultBase.java:79)
> ~[flink-sql-client-1.16.0.jar:1.16.0]Caused by: java.lang.RuntimeException:
> Failed to fetch next resultat
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.nextResultFromFetcher(CollectResultIterator.java:109)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.hasNext(CollectResultIterator.java:80)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.table.planner.connectors.CollectDynamicSink$CloseableRowIteratorWrapper.hasNext(CollectDynamicSink.java:222)
> ~[?:?]at
> org.apache.flink.table.client.gateway.local.result.CollectResultBase$ResultRetrievalThread.run(CollectResultBase.java:75)
> ~[flink-sql-client-1.16.0.jar:1.16.0]Caused by: java.io.IOException: Failed
> to fetch job execution resultat
> org.apache.flink.streaming.api.operators.collect.CollectResultFetcher.getAccumulatorResults(CollectResultFetcher.java:184)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.streaming.api.operators.collect.CollectResultFetcher.next(CollectResultFetcher.java:121)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.nextResultFromFetcher(CollectResultIterator.java:106)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.hasNext(CollectResultIterator.java:80)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.table.planner.connectors.CollectDynamicSink$CloseableRowIteratorWrapper.hasNext(CollectDynamicSink.java:222)
> ~[?:?]at
> org.apache.flink.table.client.gateway.local.result.CollectResultBase$ResultRetrievalThread.run(CollectResultBase.java:75)
> ~[flink-sql-client-1.16.0.jar:1.16.0]Caused by:
> java.util.concurrent.ExecutionException:
> org.apache.flink.client.program.ProgramInvocationException: Job failed
> (JobID: bc869097009a92d0601add881a6b920c)at
> java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395)
> ~[?:?]at
> java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2022)
> ~[?:?]at
> org.apache.flink.streaming.api.operators.collect.CollectResultFetcher.getAccumulatorResults(CollectResultFetcher.java:182)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.streaming.api.operators.collect.CollectResultFetcher.next(CollectResultFetcher.java:121)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.nextResultFromFetcher(CollectResultIterator.java:106)
> ~[flink-dist-1.16.0.jar:1.16.0]at
> org.apache.flink.streaming.api.operators.collect.CollectResultIterator.hasNex
[jira] [Commented] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convention
[
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605588#comment-17605588
]
Tony Zhu commented on FLINK-28902:
--
Thanks for review. I created another PR
[#20845|https://github.com/apache/flink/pull/20845] .
> FileSystemJobResultStoreTestInternal is a unit test that's not following the
> unit test naming convention
>
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Assignee: Tony Zhu
>Priority: Minor
> Labels: pull-request-available, starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside
> of the test name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents
[
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605120#comment-17605120
]
Tony Zhu edited comment on FLINK-28902 at 9/15/22 5:39 AM:
---
I created this PR [https://github.com/apache/flink/pull/20839]
Could you help review please
was (Author: JIRAUSER295709):
I created this PR [[FLINK-28902][tests] rename
FileSystemJobResultStoreTestInternal to FileSystemJobResultStoreTest and add
Internal to test methods part by tonyzhu918 · Pull Request #20839 ·
apache/flink (github.com)|https://github.com/apache/flink/pull/20839]. Could
you help review please
> FileSystemJobResultStoreTestInternal is a unit test that's not following the
> unit test naming convents
> --
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Assignee: Tony Zhu
>Priority: Minor
> Labels: pull-request-available, starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside
> of the test name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents
[
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605120#comment-17605120
]
Tony Zhu edited comment on FLINK-28902 at 9/15/22 5:38 AM:
---
I created this PR [[FLINK-28902][tests] rename
FileSystemJobResultStoreTestInternal to FileSystemJobResultStoreTest and add
Internal to test methods part by tonyzhu918 · Pull Request #20839 ·
apache/flink (github.com)|https://github.com/apache/flink/pull/20839]. Could
you help review please
was (Author: JIRAUSER295709):
I created this PR. Could you help review please
> FileSystemJobResultStoreTestInternal is a unit test that's not following the
> unit test naming convents
> --
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Assignee: Tony Zhu
>Priority: Minor
> Labels: pull-request-available, starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside
> of the test name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents
[
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605120#comment-17605120
]
Tony Zhu commented on FLINK-28902:
--
I created this PR. Could you help review please
> FileSystemJobResultStoreTestInternal is a unit test that's not following the
> unit test naming convents
> --
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Assignee: Tony Zhu
>Priority: Minor
> Labels: pull-request-available, starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside
> of the test name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents
[
https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603822#comment-17603822
]
Tony Zhu commented on FLINK-28902:
--
Can I try this ticket?
> FileSystemJobResultStoreTestInternal is a unit test that's not following the
> unit test naming convents
> --
>
> Key: FLINK-28902
> URL: https://issues.apache.org/jira/browse/FLINK-28902
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination, Test Infrastructure
>Affects Versions: 1.15.1, 1.16.0
>Reporter: Matthias Pohl
>Priority: Minor
> Labels: starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example
> build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside
> of the test name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
