[GitHub] flink pull request #4472: FLINK-7368: MetricStore makes cpu spin at 100%

2017-08-09 Thread asdf2014 
Github user asdf2014 commented on a diff in the pull request:

https://github.com/apache/flink/pull/4472#discussion_r132358492
  
--- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
 ---
@@ -24,8 +24,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.HashMap;
-import java.util.HashSet;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentSkipListSet;
--- End diff --

Hi, @nicochen . Thank you for the `PR`. There is a import order problem, 
you should change the order of those import as the following code. Otherwise it 
will not pass the `checkstyle` system.
```java
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentSkipListSet;
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4474: FLINK-7369: Add more information for `Key group index out...

2017-08-04 Thread asdf2014 
Github user asdf2014 commented on the issue:

https://github.com/apache/flink/pull/4474
  
You are so polite that you do not have to be sorry :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4474: FLINK-7369: Add more information for `Key group index out...

2017-08-04 Thread asdf2014 
Github user asdf2014 commented on the issue:

https://github.com/apache/flink/pull/4474
  
Hi, @StefanRRichter . Thank you take the suggestion. I have already seen 
the improvement 
[merged](https://github.com/apache/flink/commit/04777538c0a54c113d0f9b49b5922ba47f6e1eb8)
 into master. :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4474: FLINK-7369: Add more information for `Key group in...

2017-08-04 Thread asdf2014 
Github user asdf2014 closed the pull request at:

https://github.com/apache/flink/pull/4474


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4474: FLINK-7369: Add more information for `Key group in...

2017-08-04 Thread asdf2014 
GitHub user asdf2014 opened a pull request:

https://github.com/apache/flink/pull/4474

FLINK-7369: Add more information for `Key group index out of range of key 
group range` exception

When i got the following exception log, it make me confused that the index 
is more than `32` or less than `16`. So, we should add more information for it.

```java
java.lang.IllegalArgumentException: Key group index out of range of key 
group range [16, 32).
at 
org.apache.flink.runtime.state.heap.NestedMapsStateTable.setMapForKeyGroup(NestedMapsStateTable.java:104)
at 
org.apache.flink.runtime.state.heap.NestedMapsStateTable.putAndGetOld(NestedMapsStateTable.java:218)
at 
org.apache.flink.runtime.state.heap.NestedMapsStateTable.put(NestedMapsStateTable.java:207)
at 
org.apache.flink.runtime.state.heap.NestedMapsStateTable.put(NestedMapsStateTable.java:145)
at 
org.apache.flink.runtime.state.heap.HeapValueState.update(HeapValueState.java:72)
at 
org.apache.flink.cep.operator.AbstractKeyedCEPPatternOperator.updateNFA(AbstractKeyedCEPPatternOperator.java:276)
at 
org.apache.flink.cep.operator.AbstractKeyedCEPPatternOperator.processElement(AbstractKeyedCEPPatternOperator.java:171)
at 
org.apache.flink.streaming.runtime.io.StreamInputProcessor.processInput(StreamInputProcessor.java:206)
at 
org.apache.flink.streaming.runtime.tasks.OneInputStreamTask.run(OneInputStreamTask.java:69)
at 
org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:263)
at org.apache.flink.runtime.taskmanager.Task.run(Task.java:702)
at java.lang.Thread.run(Thread.java:745)
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/asdf2014/flink FLINK-7369

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4474


commit 930e042939a65fb1539aa29f514084e0570ed49d
Author: asdf2014 <1571805...@qq.com>
Date:   2017-08-04T07:59:48Z

FLINK-7369: Add more information for `Key group index out of range of key 
group range` exception




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-06-14 Thread asdf2014 
Github user asdf2014 commented on the issue:

https://github.com/apache/flink/pull/2487
  
@rmetzger Alright. Thank you for your asking, but i think our company still 
plan to use `Flink-CEP` and contributing `Bahir-Siddhi` feature is a huge job, 
so... I'm so sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-06-09 Thread asdf2014 
Github user asdf2014 commented on the issue:

https://github.com/apache/flink/pull/2487
  
@dianfu Great! Look forward to.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2487: [FLINK-4520][flink-siddhi] Integrate Siddhi as a light-we...

2017-06-09 Thread asdf2014 
Github user asdf2014 commented on the issue:

https://github.com/apache/flink/pull/2487
  
Hi, @haoch @rmetzger . Why i cannot find `flink-siddhi` in 
[bahir](https://github.com/apache/bahir) or 
[bahir-flink](https://github.com/apache/bahir-flink)? In addition, the 
[flink-siddhi](https://github.com/haoch/flink-siddhi) still depence on `flink 
v1.1.2`. May i ask how long will i could use these advanced features of `Siddhi 
CEP` on flink... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4087: [FLINK-6868][build] Using `scala.binary.version` f...

2017-06-07 Thread asdf2014 
GitHub user asdf2014 opened a pull request:

https://github.com/apache/flink/pull/4087

[FLINK-6868][build] Using `scala.binary.version` for 
`flink-streaming-scala` in `Cassandra Connector`

Using `scala.binary.version` for `flink-streaming-scala` in `Cassandra 
Connector`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/asdf2014/flink cassandra_scala

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4087


commit 61f31e83407aa458161109f9576daf4cfb86a228
Author: asdf2014 <1571805...@qq.com>
Date:   2017-06-08T06:55:25Z

[FLINK-6868][build] Using `scala.binary.version` for 
`flink-streaming-scala` in `Cassandra Connector`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---