[GitHub] flink issue #6219: [hotfix] Fixed typo in docs

2018-07-01 Thread elbaulp
Github user elbaulp commented on the issue:

https://github.com/apache/flink/pull/6219
  
@tillrohrmann You're welcome :-)


---


[GitHub] flink pull request #6219: [hotfix] Fixed typo in docs

2018-06-27 Thread elbaulp
GitHub user elbaulp opened a pull request:

https://github.com/apache/flink/pull/6219

[hotfix] Fixed typo in docs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elbaulp/flink patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/6219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6219


commit ab3f846772e6e5114b19a79bcc91dccf9b012151
Author: Alejandro Alcalde 
Date:   2018-06-27T16:17:54Z

[hotfix] Fixed typo in docs




---


[GitHub] flink pull request #5299: [Hotfix][Doc][DataStream API] Fix Scala code examp...

2018-01-15 Thread elbaulp
GitHub user elbaulp opened a pull request:

https://github.com/apache/flink/pull/5299

[Hotfix][Doc][DataStream API] Fix Scala code example in Controlling Latency 
section



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elbaulp/flink hotfix-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5299


commit 6bb3ced0828c9a3fdf5fc99d17dc8a573eb4163d
Author: Alejandro Alcalde <algui91@...>
Date:   2018-01-15T18:13:27Z

Merge remote-tracking branch 'upstream/master'

commit 7497d756f01aa9b596e11d64a6fa2a24702a53ce
Author: Alejandro Alcalde <algui91@...>
Date:   2018-01-15T18:27:55Z

[Hotfix][doc][DataStream API] Fix Scala code example in Controlling Latency 
section




---


[GitHub] flink issue #5283: [hotfix][doc] Fixed doc typo in DataStream API

2018-01-11 Thread elbaulp
Github user elbaulp commented on the issue:

https://github.com/apache/flink/pull/5283
  
Done, sorry.


---


[GitHub] flink pull request #5283: Fixed doc typo in DataStream API

2018-01-11 Thread elbaulp
GitHub user elbaulp opened a pull request:

https://github.com/apache/flink/pull/5283

Fixed doc typo in DataStream API

Miss-spelled multiple as muplitple

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elbaulp/flink fix-doc-typo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5283


commit e9435aad2e1b57728112c2149cb8e653aff2d986
Author: Alejandro Alcalde <algui91@...>
Date:   2018-01-11T12:49:29Z

Fixed doc typo in DataStream API




---


[GitHub] flink issue #4968: [FLINK-8006] [Startup Shell Scripts] Enclosing $pid in qu...

2017-11-12 Thread elbaulp
Github user elbaulp commented on the issue:

https://github.com/apache/flink/pull/4968
  
Hi, Do I need to do something more in order to this PR be merged?


---


[GitHub] flink issue #4968: [FLINK-8006] [Startup Shell Scripts] Enclosing $pid in qu...

2017-11-08 Thread elbaulp
Github user elbaulp commented on the issue:

https://github.com/apache/flink/pull/4968
  
@greghogan Oh, of course, didn''t saw it, how many $pids! Done.


---


[GitHub] flink issue #4968: [FLINK-8006] [Startup Shell Scripts] Enclosing $pid in qu...

2017-11-07 Thread elbaulp
Github user elbaulp commented on the issue:

https://github.com/apache/flink/pull/4968
  
@greghogan Done, sorry for ignoring the stop script.


---


[GitHub] flink issue #4968: [FLINK-8006] [Startup Shell Scripts] Enclosing $pid in qu...

2017-11-07 Thread elbaulp
Github user elbaulp commented on the issue:

https://github.com/apache/flink/pull/4968
  
@greghogan Didn't realized!, its failing too. I am going to fix it.


---


[GitHub] flink pull request #4968: [FLINK-8006] [Startup Shell Scripts] Enclosing $pi...

2017-11-07 Thread elbaulp
GitHub user elbaulp opened a pull request:

https://github.com/apache/flink/pull/4968

[FLINK-8006] [Startup Shell Scripts] Enclosing $pid in quotes

## What is the purpose of the change

When executing `./bin/start-local.sh` The following errors appears:

flink-1.3.2/bin/flink-daemon.sh: line 79: $pid: ambiguous redirect

This is because $pid contains spaces, so to fix it I've enclose I replaced 
all $pid by "$pid"

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / no)
  - The serializers: (yes / no / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / no / 
don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  - The S3 file system connector: (yes / no / don't know)

No

## Documentation

  - Does this pull request introduce a new feature? (no)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/elbaulp/flink fix-FLINK-8006

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4968


commit 5eb46d363e3eaab321759e18f55b9a96270e523f
Author: Alejandro Alcalde <algu...@gmail.com>
Date:   2017-11-07T12:09:46Z

[FLINK-8006] Enclosing  in quotes




---