[GitHub] flink pull request: [FLINK-2362] - distinct is missing in DataSet ...
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/922#issuecomment-122815918 Thanks for the suggestion @mxm , I updated the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2362] - distinct is missing in DataSet ...
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/922 [FLINK-2362] - distinct is missing in DataSet API documentation add scala and java documentation for the distinct transformation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pp86/flink distinctDoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/922.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #922 commit 942dc1a51e44195ef907ae5c75fba3b3162e8771 Author: Pietro Pinoli pie...@pietros-mbp.lan Date: 2015-07-19T22:51:52Z add scala and java documentation for the distinct transformation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2312][ml][WIP] Randomly Splitting a Dat...
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/921#issuecomment-122709103 Hi @sachingoel0101 , wouldn't it be better to implement the method for a generic DataSet rather than a DataSet of LabeledVector? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-122118573 Hi @fhueske , I'm very sorry, this is the first time I work with github, I am doing some mess :| But, I think I finally succeeded in removing the unwanted commits for documentation. I am not working on the code any more. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121739943 Dear @fhueske , I hope I satisfied your requests! Let me know if some other changes are needed. As you suggested I took the issue on documentation. Thanks, Pietro --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121192327 hello @chiwanpark! what do you think about the tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121187436 sure thing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-121406113 Hi guys, I added some tests. I also added a test on a generic data type which does not implement Comparable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/905 [FLINK-1963] Improve distinct() transformation - add the possibility to use distinct() on Atomic data types - add the possibility to use distinct(_)/distinct(*) on Atomic data types You can merge this pull request into a Git repository by running: $ git pull https://github.com/pp86/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/905.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #905 commit f9a69111c1050d45d14ffb332411af6663482dd5 Author: pietro pinoli pie...@pietros-mbp.lan Date: 2015-07-13T11:32:20Z [FLINK-1963] Improve distinct() transformation - add the possibility to use distinct() on Atomic data types - add the possibility to use distinct(_)/distinct(*) on Atomic data types commit da699987852d7481843d8b8b60c976d3d8e61a69 Author: pietro pinoli pie...@pietros-mbp.lan Date: 2015-07-13T11:58:28Z [FLINK-1963] Improve distinct() transformation ⦠- add the possibility to use distinct() on Atomic data types - add the possibility to use distinct(_)/distinct(*) on Atomic data types commit 911db2d2efcca227d1fdcf595cb6c5a2cd4e92ce Author: pietro pinoli pie...@pietros-mbp.lan Date: 2015-07-13T12:01:20Z Clean code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Github user pp86 commented on the pull request: https://github.com/apache/flink/pull/905#issuecomment-120922481 Dear Chiwan, thanks for you suggestions. I'll integrate them and open a new pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1963] Improve distinct() transformation
Github user pp86 closed the pull request at: https://github.com/apache/flink/pull/905 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Merge pull request #1 from apache/master
Github user pp86 closed the pull request at: https://github.com/apache/flink/pull/737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Merge pull request #1 from apache/master
Github user pp86 closed the pull request at: https://github.com/apache/flink/pull/737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Merge pull request #1 from apache/master
GitHub user pp86 reopened a pull request: https://github.com/apache/flink/pull/737 Merge pull request #1 from apache/master test update You can merge this pull request into a Git repository by running: $ git pull https://github.com/pp86/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/737.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #737 commit 05c5987c69ff37b74a705163b198801b93fe299b Author: pp86 pietro.pin...@gmail.com Date: 2015-05-22T21:01:48Z Merge pull request #1 from apache/master test update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: Merge pull request #1 from apache/master
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/737 Merge pull request #1 from apache/master test update You can merge this pull request into a Git repository by running: $ git pull https://github.com/pp86/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/737.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #737 commit 05c5987c69ff37b74a705163b198801b93fe299b Author: pp86 pietro.pin...@gmail.com Date: 2015-05-22T21:01:48Z Merge pull request #1 from apache/master test update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2043] Change the KMeansDataGenerator to...
GitHub user pp86 opened a pull request: https://github.com/apache/flink/pull/721 [FLINK-2043] Change the KMeansDataGenerator to allow passing a custom path https://issues.apache.org/jira/browse/FLINK-2043 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pp86/flink myBranch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/721.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #721 commit 05c5987c69ff37b74a705163b198801b93fe299b Author: pp86 pietro.pin...@gmail.com Date: 2015-05-22T21:01:48Z Merge pull request #1 from apache/master test update commit 00c6542c7681bd7099ded31985382c6cd1aa43b5 Author: Pietro Pinoli pietro.pin...@gmail.com Date: 2015-05-24T11:53:15Z merging commit 90fa66e7356817b8d0e4190c024f914ee5d70e5b Author: Pietro Pinoli pietro.pin...@gmail.com Date: 2015-05-24T11:35:35Z [FLINK-2043] Change the KMeansDataGenerator to allow passing a custom path --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
