[GitHub] flink pull request: [FLINK-2741] - Use single log statement in Tes...
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1221#issuecomment-145501938 @uce I added the new line according to your hint. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2741] - Use single log statement in Tes...
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1221#issuecomment-145629889 Thanks all for suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...
GitHub user rerngvit opened a pull request: https://github.com/apache/flink/pull/1176 [FLINK-2751] [Documentation] Add quickstart menu to the navigation bar Add quickstart menu to the navigation bar for Flink documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/rerngvit/flink FLINK-2751 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1176.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1176 commit e588f3067e63fbdf261dedb9913087d1f2fa083c Author: Rerngvit Yanggratoke Date: 2015-09-23T22:56:04Z Add quickstart menu to the navigation bar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1176#issuecomment-142868010 @chiwanpark Thanks for reviewing this issue. I modified the pull request according to your comments. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2751] [Documentation] Add quickstart me...
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1176#issuecomment-142900768 @chiwanpark Thanks for reviewing this issue. I modified the pull request according to your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-2751][Documentation] Fix wrong java ver...
GitHub user rerngvit opened a pull request:
https://github.com/apache/flink/pull/1187
[Flink-2751][Documentation] Fix wrong java version requirement in quickstart
Fix wrong java version requirement in quickstart (1.6 -> 1.7)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rerngvit/flink FLINK-2751
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1187
commit e588f3067e63fbdf261dedb9913087d1f2fa083c
Author: Rerngvit Yanggratoke
Date: 2015-09-23T22:56:04Z
Add quickstart menu to the navigation bar
commit 79dd4f48a0fe3a7625de35d2b00dbcd6c487015c
Author: Rerngvit Yanggratoke
Date: 2015-09-24T09:31:04Z
[Flink-2751] - refine changes according to comments
1. Define {{quick_start}}
2. Define active class for {{quick_start}} Dropdown menu
commit 8456490d7c95b4597e118a7bc49a624b93cded94
Author: Rerngvit Yanggratoke
Date: 2015-09-24T11:18:20Z
[Flink-2751] - refine changes according to comments
1. Add '/{link_name}/' for all dropDown toggle condition checks
2. Fix closing tag in line 68 (JobManager High Availability)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-2751][Documentation] Fix wrong java ver...
Github user rerngvit closed the pull request at: https://github.com/apache/flink/pull/1187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-2768][Documentation] Fix wrong java ver...
GitHub user rerngvit opened a pull request: https://github.com/apache/flink/pull/1188 [Flink-2768][Documentation] Fix wrong java version requirement in quickstart Fix wrong java version requirement in quickstart (1.6 -> 1.7) You can merge this pull request into a Git repository by running: $ git pull https://github.com/rerngvit/flink FLINK-2768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1188.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1188 commit b45cc64b1ec9a7fc291b8acac746d45256c8aee0 Author: Rerngvit Yanggratoke Date: 2015-09-28T18:34:46Z [Flink-2768] - Fix wrong java version requirement in quickstart (1.6 -> 1.7 and 6.x -> 7.x) commit e1a16f465fcc2f1c4aa3259ef62a6b6f82299878 Author: Rerngvit Yanggratoke Date: 2015-09-28T18:35:34Z [Flink-2768] - Fix wrong java version requirement in quickstart (1.6 -> 1.7) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [Flink-2768][Documentation] Fix wrong java ver...
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1188#issuecomment-143905322 @hsaputra Thank you for reviewing this PR. I squashed the commits into one as per your comment. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2741] - Use single log statement in Tes...
GitHub user rerngvit opened a pull request: https://github.com/apache/flink/pull/1221 [FLINK-2741] - Use single log statement in TestLogger [FLINK-2741] - Use single log statement in TestLogger You can merge this pull request into a Git repository by running: $ git pull https://github.com/rerngvit/flink FLINK-2741 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1221 commit 2b9e5972d5c7d01f066932187bf9620cd560db9e Author: Rerngvit Yanggratoke Date: 2015-10-03T22:57:21Z [FLINK-2741] - Use single log statement in TestLogger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2741] - Use single log statement in Tes...
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1221#issuecomment-145325375 @hsaputra Thanks for your review. I modified this PR according to your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-2741] - Use single log statement in Tes...
Github user rerngvit commented on the pull request: https://github.com/apache/flink/pull/1221#issuecomment-145364699 The build is failed on an issue not related to the PR. In particular, it failed only on "JDK8 Hadoop 2.5" with "java.io.FileNotFoundException: build-target/lib/flink-dist-*.jar " --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (FLINK-2751) Quickstart is in documentation but only linked through the Flink homepage
[
https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905408#comment-14905408
]
rerngvit yanggratoke commented on FLINK-2751:
-
I would like to help work on this issue.
> Quickstart is in documentation but only linked through the Flink homepage
> -
>
> Key: FLINK-2751
> URL: https://issues.apache.org/jira/browse/FLINK-2751
> Project: Flink
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 0.9, 0.10
>Reporter: Maximilian Michels
> Labels: starter
> Fix For: 0.9, 0.10
>
>
> The Quickstart docs contained in {{docs/quickstart}} should also be included
> in the documentation menu. Basically, we could copy over the Quickstart menu
> from the Flink homepage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2768) Wrong Java version requirements in "Quickstart: Scala API" page
[ https://issues.apache.org/jira/browse/FLINK-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933730#comment-14933730 ] rerngvit yanggratoke commented on FLINK-2768: - I would like to work on this issue. > Wrong Java version requirements in "Quickstart: Scala API" page > --- > > Key: FLINK-2768 > URL: https://issues.apache.org/jira/browse/FLINK-2768 > Project: Flink > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Chiwan Park > Labels: starter > > Since Flink 0.10, we dropped Java 6 support. But "[Quickstart: Scala > API|https://ci.apache.org/projects/flink/flink-docs-master/quickstart/scala_api_quickstart.html]"; > page says that Java 6 is one of minimum requirement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2768) Wrong Java version requirements in "Quickstart: Scala API" page
[ https://issues.apache.org/jira/browse/FLINK-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933753#comment-14933753 ] rerngvit yanggratoke commented on FLINK-2768: - [~chiwanpark] I have a PR for this. Please have a look. > Wrong Java version requirements in "Quickstart: Scala API" page > --- > > Key: FLINK-2768 > URL: https://issues.apache.org/jira/browse/FLINK-2768 > Project: Flink > Issue Type: Bug >Affects Versions: 0.10 >Reporter: Chiwan Park >Assignee: rerngvit yanggratoke > Labels: starter > > Since Flink 0.10, we dropped Java 6 support. But "[Quickstart: Scala > API|https://ci.apache.org/projects/flink/flink-docs-master/quickstart/scala_api_quickstart.html]"; > page says that Java 6 is one of minimum requirement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2169) Add fromParquet() to TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933817#comment-14933817
]
rerngvit yanggratoke commented on FLINK-2169:
-
[~fhueske] I have a question. The method that should be added is
"fromCsvFile()" as in the description or "fromParquet()" as in the title?
> Add fromParquet() to TableEnvironment
> -
>
> Key: FLINK-2169
> URL: https://issues.apache.org/jira/browse/FLINK-2169
> Project: Flink
> Issue Type: New Feature
> Components: Table API
>Affects Versions: 0.9
>Reporter: Fabian Hueske
>Priority: Minor
> Labels: starter
>
> Add a {{fromCsvFile()}} method to the {{TableEnvironment}} to read a
> {{Table}} from a Parquet file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2169) Add fromParquet() to TableEnvironment
[
https://issues.apache.org/jira/browse/FLINK-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934814#comment-14934814
]
rerngvit yanggratoke commented on FLINK-2169:
-
[~aljoscha] Thanks for letting me know. I will look for something else then.
> Add fromParquet() to TableEnvironment
> -
>
> Key: FLINK-2169
> URL: https://issues.apache.org/jira/browse/FLINK-2169
> Project: Flink
> Issue Type: New Feature
> Components: Table API
>Affects Versions: 0.9
>Reporter: Fabian Hueske
>Priority: Minor
> Labels: starter
>
> Add a {{fromCsvFile()}} method to the {{TableEnvironment}} to read a
> {{Table}} from a Parquet file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2100) Add ITCases for all Table API examples
[ https://issues.apache.org/jira/browse/FLINK-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942485#comment-14942485 ] rerngvit yanggratoke commented on FLINK-2100: - [~twalthr] I am seeing ITCases for at least the following APIs: "Join", "select", "groupby", and "filter" in today code. Can you give examples of what are not covered by ITCases in current code? > Add ITCases for all Table API examples > -- > > Key: FLINK-2100 > URL: https://issues.apache.org/jira/browse/FLINK-2100 > Project: Flink > Issue Type: Test > Components: Table API >Reporter: Timo Walther >Priority: Minor > Labels: starter > > Not all examples in the Table API are tested with ITCases. They should be > added. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-1940) StockPrice example cannot be visualized
[ https://issues.apache.org/jira/browse/FLINK-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942488#comment-14942488 ] rerngvit yanggratoke commented on FLINK-1940: - Should this be closed then? > StockPrice example cannot be visualized > --- > > Key: FLINK-1940 > URL: https://issues.apache.org/jira/browse/FLINK-1940 > Project: Flink > Issue Type: Bug > Components: Streaming >Reporter: Gyula Fora > > The planvisualizer fails on the JSON generated by the StockPrice example -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (FLINK-2741) Use single log statement in TestLogger
[
https://issues.apache.org/jira/browse/FLINK-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rerngvit yanggratoke reassigned FLINK-2741:
---
Assignee: rerngvit yanggratoke
> Use single log statement in TestLogger
> --
>
> Key: FLINK-2741
> URL: https://issues.apache.org/jira/browse/FLINK-2741
> Project: Flink
> Issue Type: Improvement
> Components: Tests
>Affects Versions: master
>Reporter: Ufuk Celebi
>Assignee: rerngvit yanggratoke
>Priority: Trivial
>
> {{TestLogger}} prints log statements before and after tests. Currently this
> is done via multiple {{log.info}} statements. Sometimes this leads to
> interleaved output with failure stack traces.
> I would like to change it to a single statements with new lines:
> {code}
> 17:30:31,887 ERROR A - -
> 17:30:31,891 INFO B - Shutting down remote daemon.
> 17:30:31,895 ERROR A - Test testJobManagerCleanUp(A) failed with:
> ...
> 17:30:31,909 ERROR A - =
> {code}
> to
> {code}
> 17:30:31,891 INFO B - Shutting down remote daemon.
> 17:30:31,887 ERROR A -
> -
> Test testJobManagerCleanUp(A) failed with:
> ...
> =
> {code}
> Any opinions? Does this improve readability?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-2741) Use single log statement in TestLogger
[
https://issues.apache.org/jira/browse/FLINK-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942495#comment-14942495
]
rerngvit yanggratoke commented on FLINK-2741:
-
[~till.rohrmann] I have a PR for this issue. Please have a look.
> Use single log statement in TestLogger
> --
>
> Key: FLINK-2741
> URL: https://issues.apache.org/jira/browse/FLINK-2741
> Project: Flink
> Issue Type: Improvement
> Components: Tests
>Affects Versions: master
>Reporter: Ufuk Celebi
>Assignee: rerngvit yanggratoke
>Priority: Trivial
>
> {{TestLogger}} prints log statements before and after tests. Currently this
> is done via multiple {{log.info}} statements. Sometimes this leads to
> interleaved output with failure stack traces.
> I would like to change it to a single statements with new lines:
> {code}
> 17:30:31,887 ERROR A - -
> 17:30:31,891 INFO B - Shutting down remote daemon.
> 17:30:31,895 ERROR A - Test testJobManagerCleanUp(A) failed with:
> ...
> 17:30:31,909 ERROR A - =
> {code}
> to
> {code}
> 17:30:31,891 INFO B - Shutting down remote daemon.
> 17:30:31,887 ERROR A -
> -
> Test testJobManagerCleanUp(A) failed with:
> ...
> =
> {code}
> Any opinions? Does this improve readability?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
